Andrew Halberstadt
eced3471fc
Bug 1436639 - [lint] Make sure flake8 is run with same python as |mach lint| was, r=jmaher
...
This fixes a bug which can happen when the default version of python differs from
the version of python used with mach.
For example, mach explicitly looks for python2.7. This means running |mach lint -l flake8|
should also run flake8 with version 2.7. But if the default is python3, and flake8 is also
installed there, the subprocess call that invokes flake8 will run under python3. This can
lead to errors like "undefined name 'basestring'" and other 2to3 gotchas.
This patch ensures that we run:
python2.7 -m flake8
which explicitly runs flake8 against the same interpreter as mach, no matter the default.
MozReview-Commit-ID: HSuMzDsAvsW
--HG--
extra : rebase_source : d39f97ed0f82f4d2c81f044ef1f7dad0953a3d8d
2018-02-07 23:28:33 -05:00
Mark Banner
2fd2fd7199
Bug 1436389 - Update complexity rules to adapt for the algorithm in the new ESLint. r=mossop
...
MozReview-Commit-ID: 1LlfamNvBEM
--HG--
extra : rebase_source : 8e41e5a5f67bfd43444fde25287cb3709452a349
2018-02-07 16:16:09 +00:00
Mark Banner
b4f572f5fa
Bug 1436389 - Upgrade ESLint to version 4.17.0. r=mossop
...
MozReview-Commit-ID: I4KBELxhBlM
--HG--
extra : rebase_source : d206fb88f8c70d161cc0541a068db1b2f02e7a37
2018-02-07 16:01:29 +00:00
Mark Banner
54c4111311
Bug 1230369 - Add ESLint rules to disallow defining Cc/Ci etc and to prefer the use of Cc/Ci rather than the Components.* equivalents. r=florian
...
MozReview-Commit-ID: 9eAgUO3iIJW
--HG--
extra : rebase_source : 3208d5f74477733e4c81206613f74d7c7821ac0d
2018-02-06 22:40:12 +00:00
Andrew Halberstadt
eb84bf741c
Bug 1429457 - [mozlint] Create formal 'setup' mechanism for bootstrapping lint dependencies, r=gbrown
...
This allows linters to define a 'setup' method which will automatically be
called by |mach lint| before running the linter. Users can also explicitly run
these methods (without doing any actual linting) by running |mach lint --setup|.
MozReview-Commit-ID: 74aY1pfsaX1
--HG--
extra : rebase_source : e6a7d769ba14c996c7a77316928063fa46358c5a
2018-01-25 13:40:02 -05:00
Andrew Halberstadt
4a7ebcb3bb
Bug 1434430 - [flake8] Upgrade version of flake8 used by |mach lint| to 3.5.0 r=rwood
...
MozReview-Commit-ID: BBtM4TEl4Ve
--HG--
extra : rebase_source : 94d276746401426c9adcae5c962380679ffcb083
2018-01-30 16:43:10 -05:00
Andrew Halberstadt
f354075c7a
Bug 1434430 - [flake8] Fix blank 'except' statements r=rwood
...
This is a new issue that gets linted with flake8 3.5.0. Basically you should
never use a blank except: statement.
This will catch all exceptions, including KeyboardInterrupt and SystemExit
(which is likely not intended). If a catch all is needed, use
`except: Exception`. If you *really* mean to also catch KeyboardInterrupt et
al, use `except: BaseException`.
Of course, being specific is often better than a catch all.
MozReview-Commit-ID: FKx80MLO4RN
--HG--
extra : rebase_source : 7c74a7d0d81f2c984b47aff3a0ee3448b791177b
2018-01-31 14:32:08 -05:00
Andrew Halberstadt
974ae38a52
Bug 1434430 - [flake8] Drop support for the FLAKE8 environment variable r=rwood
...
The flake8 linter requires a specific version of flake8, so that running it
locally vs in CI vs in mozreview will all produce the same results.
Allowing consumers to specify a custom flake8 binary via the FLAKE8 environment
variable, subverts that goal and can result in unexplained errors showing up in
some configurations but not others.
MozReview-Commit-ID: 1s0nC8ZO6Qi
--HG--
extra : rebase_source : f3913e2bce7770edf8deba18890f063975ca0844
2018-01-31 14:05:52 -05:00
Gurzau Raul
1315ffda06
Merge inbound to mozilla-central. a=merge
2018-02-02 00:22:39 +02:00
Florian Quèze
fcd9a3a0c8
Bug 1339461 - add an eslint rule to detect when indexOf should be replaced with includes, r=Standard8.
2018-02-01 20:47:23 +01:00
Andrew McCreight
cf2f48b80d
Bug 767640, part 2 - Update eslint rules to take into account the definitions of Ci, Cr, Cc and Cu. r=florian
...
MozReview-Commit-ID: 4PyMh0WeA4r
--HG--
extra : rebase_source : 868258ad6d98698f13faee5d6af67adcb20b63a2
2018-01-25 09:45:45 -08:00
Bogdan Tara
5c052cc871
Merge mozilla-central to autoland. a=merge CLOSED TREE
2018-01-31 12:10:31 +02:00
Bogdan Tara
1a6614b8b5
Merge inbound to mozilla-central. a=merge
2018-01-31 12:00:14 +02:00
Mark Banner
9a2172526a
Bug 1434449 - Enable no-unused-vars for the global (as well as local) scope on jsm files, whitelist directories still to be fixed. r=florian.
...
MozReview-Commit-ID: 3vBWDR3UjGF
--HG--
extra : rebase_source : 61495d14a8d761e71b4072b02e2ca57e77f44059
2018-01-30 22:10:08 +00:00
arthur.iakab
c4dd80eca3
Merge mozilla-central to autoland
2018-01-31 00:41:58 +02:00
Mark Banner
15e66f33ed
Bug 1434332 - Add a checklist for adding new linters to the tree. r=ahal
...
MozReview-Commit-ID: FnYIXS5oZvW
--HG--
extra : rebase_source : 2eba61a24a4ca313f3c1d65adef454e34c57bdb5
2018-01-30 16:55:20 +00:00
Dorel Luca
0e6d4442ff
Backed out 2 changesets (bug 767640) for talos failure on scripts/MozillaFileLogger.js on a CLOSED TREE
...
Backed out changeset 073aecb9bee5 (bug 767640)
Backed out changeset 6bc5ccfb1bd3 (bug 767640)
2018-01-30 21:53:28 +02:00
Andrew McCreight
aa6a1107ab
Bug 767640, part 2 - Update eslint rules to take into account the definitions of Ci, Cr, Cc and Cu. r=florian
...
MozReview-Commit-ID: 4PyMh0WeA4r
--HG--
extra : rebase_source : da3db733d6c682ee137c90f8a5a9afaf85713c48
2018-01-25 09:45:45 -08:00
Kris Maglione
19a956c2c6
Bug 1431533
: Part 5b - Fix ESLint errors left over after rewrite. r=florian
...
MozReview-Commit-ID: 7bVI1iM6hor
--HG--
extra : source : 0b97a30cadb1a96d3cafae6b79ef0d3ec26770cf
extra : amend_source : 09a90b29837e339eec7bdf8504f86c28e74ca3dd
extra : intermediate-source : a1eca62826a1341ca24d4d2a93d4884d4fc7ad51
extra : histedit_source : eb26e73b531f9a34d3401d39f60b533b27b78540
2018-01-18 16:27:26 -08:00
Kris Maglione
6425ff4f8d
Bug 1431533
: Part 4 - Add ESLint support for ChromeUtils import methods. r=florian
...
This adds support for detecting globals created by these helpers, as well as a
rule to enforce their use over the older XPConnect variants.
The latter rule also supports fixing code to use the newer variants, and will
be used in the next part to rewrite in-tree ESLint-enabled code that fails it.
MozReview-Commit-ID: 6Bgo6ohQA5j
--HG--
extra : source : fbef09c3e8af1653f270db589f73f2786c23ddc2
extra : intermediate-source : e2674287e57fbf6835729f42b8491359c2c4bfd5
2018-01-18 12:53:01 -08:00
George Dan, Ryan Neilsen, Dylan Turner
4cbac2527f
Bug 1387632: Rename ProfileStorage module to FormAutofillStorage. r=MattN
...
--HG--
rename : browser/extensions/formautofill/ProfileStorage.jsm => browser/extensions/formautofill/FormAutofillStorage.jsm
extra : rebase_source : aa456b06046f1d995d65bec13044cde081559061
extra : histedit_source : 620bdb1c33de4b4b656066ea6432826f3631c3b4
2018-01-30 14:44:59 -08:00
Simon Fraser
5acab0f13e
Bug 1432627 Add shellcheck linter to CI r=ahal
...
MozReview-Commit-ID: 2IYUsXunfab
--HG--
extra : rebase_source : 806ab4abfb1838a1b5eec279f5e93ce5c703685d
2018-01-29 15:27:04 +00:00
Margareta Eliza Balazs
acf50fbab3
Backed out changeset 85794e045326 (bug 1432627) for shell lint failure in /builds/worker/checkouts/gecko/taskcluster/docker/firefox-snap/runme.sh:50:95 on a CLOSED TREE
2018-01-29 19:09:55 +02:00
Simon Fraser
82f0264fa1
Bug 1432627 Add shellcheck linter to CI r=ahal
...
MozReview-Commit-ID: 2IYUsXunfab
--HG--
extra : rebase_source : a40376ffc66e4a35d30e7e02a6ec208b1f52b021
2018-01-29 15:27:04 +00:00
Andrew Halberstadt
a8b5fc493f
Bug 1433912 - [lint] Only run codespell linter on python/mozlint and tools/lint for now, r=sylvestre
...
This is a bustage fix that needs to get out quickly. Once landed we can take
the time to enable it on more directories, or preferably change it to a
blacklist.
MozReview-Commit-ID: Gbf7q2L0tg3
--HG--
extra : rebase_source : a58ae64c655b24e686710a663d4538b4cfe020f7
2018-01-29 10:25:54 -05:00
Sylvestre Ledru
8238fab711
Bug 1433410 - Add codespell support for mach lint r=ahal
...
MozReview-Commit-ID: Ii6QjPMN0Ks
--HG--
extra : rebase_source : 854dc0994e9e204c5c5f9f25a4e956c9f51001d0
2018-01-27 10:35:31 +01:00
Kit Cambridge
2449a744b8
Bug 1305563 - Add a BufferedBookmarksEngine
that can be toggled with a pref. r=markh,tcsc
...
This patch adds a new bookmarks engine, pref'd off, that writes to the
buffer instead of Places.
MozReview-Commit-ID: 7idBa03kOzm
--HG--
extra : rebase_source : 671ebeb3de824dc43c0ef14b2dfe065a33e2911a
2017-12-19 17:10:54 -08:00
Kit Cambridge
8d7187be91
Bug 1305563 - Add a bookmark mirror and two-way merger for synced bookmarks. r=mak,markh,rnewman,tcsc
...
The mirror matches the complete bookmark tree stored on the Sync
server, stores new bookmarks changed on the server since the last
sync, merges the local and remote trees, applies the resulting merged
tree back to Places, fires observer notifications for all items changed
in the merge, and stages locally changed bookmarks for upload.
MozReview-Commit-ID: MbeFQUargt
--HG--
extra : rebase_source : b635fd65ef10ab9ce3a2f9af2e527d342a790f6e
2018-01-06 07:44:33 -08:00
shindli
4615d385bd
Backed out changeset e414096f1c3b (bug 1433410) for yaml lint failures in tools/lint/codespell.yml:12:81 on a CLOSED TREE
2018-01-27 01:20:16 +02:00
Sylvestre Ledru
904937e12f
Bug 1433410 - Add codespell support for mach lint r=ahal
...
MozReview-Commit-ID: Ii6QjPMN0Ks
--HG--
extra : rebase_source : f5aec5f35d5f882132fb09fe094dc2cfc41b1392
2018-01-26 23:58:29 +01:00
Sylvestre Ledru
3a35e750f3
Bug 1433417 - Fix a bunch of typo in the doc r=ahal
...
MozReview-Commit-ID: LRgL0CMJdDP
--HG--
extra : rebase_source : b99364bb96c1501a674a1726a3b5fdf0664a8e4f
2018-01-26 12:50:07 +01:00
Thom Chiovoloni
6321345295
Bug 1429250 - Avoid repeated traversals of toFetch in _processIncoming. r=eoger,kitcambridge
...
MozReview-Commit-ID: N1Zr8iT7da
--HG--
extra : rebase_source : ddaa51704c93985219d15b31aec7ff7e19b2832f
2018-01-09 19:22:33 -05:00
Kris Maglione
aec63e140c
Backed out 3 changesets (bug 1431533
) for Android mochitest bustage. CLOSED TREE
...
MozReview-Commit-ID: 5ubE9EMQpZ9
--HG--
extra : histedit_source : df68d7595925c07d9d6e8bacc2c46e69556f479a%2C72b768b9825e20ede6603ead75f871c50dc041f7
2018-01-24 22:04:59 -08:00
Kris Maglione
f54fba48ac
Bug 1431533
: Follow-up: Fix no-single-arg-cu-import exemption to allow ChromeUtils. r=bustage CLOSED TREE
...
MozReview-Commit-ID: 8BmInGGSnU2
--HG--
extra : amend_source : 4c60590a513eca5c2b601cc4ef50a964e2a80fa1
2018-01-24 21:23:56 -08:00
Kris Maglione
b78186b970
Bug 1431533
: Part 4 - Add ESLint support for ChromeUtils import methods. r=florian
...
This adds support for detecting globals created by these helpers, as well as a
rule to enforce their use over the older XPConnect variants.
The latter rule also supports fixing code to use the newer variants, and will
be used in the next part to rewrite in-tree ESLint-enabled code that fails it.
MozReview-Commit-ID: 6Bgo6ohQA5j
--HG--
extra : rebase_source : feca0a0ed339420ea19faa1f6614e6253f0c840e
extra : absorb_source : d32d3d23fbd2c7dcae082375a1f9a61766b04b75
extra : histedit_source : 83cebb4f3eb66a79d38ee5412a5739d0c603425b
2018-01-18 12:53:01 -08:00
Edouard Oger
d149a0176b
Bug 1426306 - Store only derived keys instead of storing kB/kA. r=glasserc,markh,rfkelly
...
MozReview-Commit-ID: Hgv5hxSH4qX
--HG--
extra : rebase_source : fa6d45480a2078e841c72b2c8c92541811633737
2018-01-05 15:56:00 -05:00
Simon Fraser
7ab95eccbd
Bug 1432517 Add shellcheck support for mach lint r=ahal
...
MozReview-Commit-ID: 1Mzg6y3JKbn
--HG--
extra : rebase_source : ceb32257265952e173ff83434395acfabb001cb4
2018-01-23 16:32:04 +00:00
Dorel Luca
2f4f0ba72d
Merge mozilla-central to autoland r=merge
2018-01-23 12:12:21 +02:00
Mark Banner
a773c73dbb
Bug 1131491 - Remove old synchronous Place's transactions. r=mak
...
MozReview-Commit-ID: FNCijeajgeh
--HG--
extra : rebase_source : 4207cdd7b789fbbcce3b2117324ea22e1a313fe6
2018-01-22 15:41:12 +00:00
Tom Prince
946b7e38eb
Bug 1430316: Lint the mozharness configs; r=jlund
...
Differential Revision: https://phabricator.services.mozilla.com/D385
--HG--
extra : rebase_source : c4c6e2a4c28c29cc6906d2b757063ef38ac2209a
2018-01-12 16:54:17 -07:00
Mark Banner
a501264a60
Bug 1431452 - Fix formatting of ESLint's docs. r=mossop
...
MozReview-Commit-ID: KUFa9ncqaxV
--HG--
extra : rebase_source : 4444037e785ca91d20179a1cf6ec1f936b65ad0d
2018-01-18 16:33:28 +00:00
Mark Banner
44d164f81d
Bug 1431129 - Remove no-mixed-spaces-and-tabs from the ESLint config, since no-tabs disallows tabs anyway. r=mossop.
...
MozReview-Commit-ID: 395itqTz9T8
--HG--
extra : rebase_source : 744f1765e1ee41fcaca608a2821c6f0d7a76d608
2018-01-18 10:03:02 +00:00
iceman
5d31e3d10a
Bug 1407763 - Enable py2 and py3 compat linters for testing/marionette. r=ahal
...
MozReview-Commit-ID: 4IYhPPGlJlo
--HG--
extra : rebase_source : a27b89c734082fc8acbc329ded75d7ef87d70dbe
2018-01-17 16:14:43 +01:00
Gijs Kruitbosch
d332684bb0
Bug 1431069 - allow eslint to deal with ChromeUtils imports, r=standard8
...
MozReview-Commit-ID: KHVewE1Rrov
--HG--
extra : rebase_source : 392ba268ec2b8851a5ef33a1e7ee8be83e83aa91
2018-01-17 13:20:59 +00:00
Mark Banner
bc030d501e
Bug 1430923 - Handle EXPORTED_SYMBOLS in ESLint to help define globals in jsm files, and disallow 'let EXPORTED_SYMBOLS = '. r=mossop
...
MozReview-Commit-ID: 5abfpM8EAEL
--HG--
extra : rebase_source : b266018a3754459aa8628217232f86e1a56c00b7
2018-01-16 23:07:25 +00:00
Mark Banner
893d64c0f9
Bug 1430615 - Remove ESLint rules duplicated in devtools/.eslintrc.js where they are already defined in recommended.js. r=jdescottes
...
MozReview-Commit-ID: 4wGkJjqzsoG
--HG--
extra : rebase_source : c78841f1b9d37c1ee3dc2077e2d41b2b16bbd26f
2018-01-15 16:46:49 +00:00
Tom Prince
24b745390b
Bug 1424967: Fix remaining lint error in upload_symbols.py; r=ted.mielczarek
...
MozReview-Commit-ID: LsvBXNy1SA6
--HG--
extra : rebase_source : a799e7907dd1fe21f3f5a4996b1ee83ba8f314e7
2017-12-12 22:42:23 -07:00
Noemi Erli
8e22628788
Backed out 2 changesets (bug 1424967) for f8 lint failures in /builds/worker/checkouts/gecko/toolkit/crashreporter/tools/upload_symbols.py:78:5 on a CLOSED TREE
...
Backed out changeset 02a7d3b84dcd (bug 1424967)
Backed out changeset e027f4bf3ed2 (bug 1424967)
2018-01-17 02:07:20 +02:00
Tom Prince
507b5088d1
Bug 1424967: Fix remaining lint error in upload_symbols.py; r=ted.mielczarek
...
MozReview-Commit-ID: LsvBXNy1SA6
--HG--
extra : rebase_source : 265b83adbb75eb644bcd530169a4e32c943008c1
2017-12-12 22:42:23 -07:00
Kris Maglione
9188b197f6
Bug 1323845: Part 1 - Support multiple schema root namespaces. r=aswan
...
MozReview-Commit-ID: DfOjHGzLJro
--HG--
extra : rebase_source : 9dcd2ff1c93e41eb9771068e65aad350d295ba18
extra : absorb_source : d43bc1bff19576fe07a4cd33efa3b6df63954570
extra : histedit_source : 4f1d31ab7b09a36b4e5d6220d71185becef47ea8%2Cad4b2eaa4d1535a67e41e6e379d13893f56d1eaf
2017-12-16 15:05:13 -06:00
Andrew Halberstadt
14685fa5e9
Bug 1429223 - [lint] Obsolete the eslintvalidate hooks by printing error message with upgrade path, r=standard8
...
This replaces the eslintvalidate hooks with an error message
prompting the user to upgrade to tools/lint/hooks.py.
The reasons for deprecating eslintvalidate are twofold:
1) It only runs eslint, so developers might miss errors from
other linters.
2) It isn't as well maintained, and I've started to see
reports of problems in the wild. It doesn't make sense to
maintain two sets of hooks that do the same thing.
MozReview-Commit-ID: CseeVIof2om
--HG--
extra : rebase_source : e859c368d14cd1bf7e7d85f0de5bbb89e88402d9
2018-01-09 20:03:58 -05:00
James Graham
5080014924
Bug 1428585 - Fixup flake8 error, r=me ON A CLOSED TREE
...
MozReview-Commit-ID: HbmZzerSQUd
2018-01-09 15:47:06 +00:00
James Graham
4cf161480a
Bug 1428585 - Fail the wpt lint if the lint process has a non-zero exit code, r=ahal
...
MozReview-Commit-ID: GiUewbmru37
2018-01-09 14:46:04 +00:00
Simon Fraser
537673de00
Bug 1401995 Update funsize to use async, to reduce task time r=jlorenzo
...
MozReview-Commit-ID: 24IU3pcJseY
--HG--
extra : rebase_source : a2b4d681ee3dbec82a523b39aff6d9e2e69d42f5
2018-01-03 14:42:47 +00:00
Mark Banner
4b9832fad4
Bug 1428305 - When clobbering node_modules for ESLint on Windows, use winrm to better handle symlinks. r=ahal
...
MozReview-Commit-ID: ACrxlr7ERAI
--HG--
extra : rebase_source : b6c6debf93504c955928bc5d7bd05c811bd3d265
2018-01-05 11:14:15 +00:00
Tom Prince
739a0defb2
Bug 1427213: Clean up docstrings in mozpack.path; r=glandium
...
MozReview-Commit-ID: 91cm9XJROy0
--HG--
extra : rebase_source : 1ab1ce1063096651f9095fd221656c852b6892d8
2017-12-27 15:57:32 -07:00
Thom Chiovoloni
3e7a2e240e
Bug 1425544 - Ensure trace level logging is used throughout sync tests. r=markh
...
MozReview-Commit-ID: Icl1qk07LKm
--HG--
extra : rebase_source : c0e35f3e435e720f0375b3826ee4ba745d1e134b
2017-12-20 18:29:21 -05:00
Florian Quèze
db57009a12
Bug 1421992 - Rename do_execute_soon, do_print and do_register_cleanup to executeSoon, info and registerCleanupFunction to match mochitest names, r=Gijs.
2017-12-21 11:08:23 +01:00
Florian Quèze
7dcab2c656
Bug 1421992 - Remove obsolete do_check_* implementations, r=Gijs.
2017-12-21 11:08:21 +01:00
Mark Banner
30935fa314
Bug 1369722 - Disable ESLint browser environment for jsm files. r=mossop
...
MozReview-Commit-ID: IVAyPmTqtCB
--HG--
extra : rebase_source : 7db82ead3e0ca7fcbf909021c8eafc79f7cd2a9a
2017-11-07 22:59:09 +00:00
Andrew Halberstadt
ee40e820d8
Bug 1336857 - [lint] Fix 'wpt' linter on Windows, r=jgraham
...
MozReview-Commit-ID: 3yIXWkinHDD
--HG--
extra : rebase_source : de0f8adac59a74b7b7f3f4515d246c35dc467b28
2017-12-14 12:37:01 -05:00
Clément David
e315ae631a
Bug 1419495 - Remove SelfSupport service r=dexter r=smaug
2017-12-02 21:52:30 +01:00
Andrew Halberstadt
0e697ce235
Bug 1422302 - Create python/mozterm for sharing terminal blessings across modules r=gps
...
This is a new module that will provide a place to store some common
abstractions around the 'blessings' module. The main entrypoint is:
from mozterm import Terminal
term = Terminal()
If blessings is available, this will return a blessings.Terminal()
object. If it isn't available, or something went wrong on import,
this will return a NullTerminal() object, which is a drop-in
replacement that does no formatting.
MozReview-Commit-ID: 6c63svm4tM5
--HG--
extra : rebase_source : 9ab221774d92a418d9b098d79bb2c88f75d937f8
2017-12-04 09:38:24 -05:00
Mark Banner
499ca20f31
Bug 1421968 - Enable ESLint rule mozilla/use-services by default, but whitelist it for various directories still to be fixed. r=mossop
...
MozReview-Commit-ID: KOZWr7FiDQZ
--HG--
extra : rebase_source : 92c9bc236c9043f6ce25cc2ba45264918eb2ac15
2017-11-28 19:24:12 +00:00
Tom Prince
615d82c39d
Bug 1421162
: Remove some dead mozharness mar
code; r=jlund
...
MozReview-Commit-ID: JvkQ713z1eW
--HG--
extra : rebase_source : 25329f9d189cc1ca1c5823bfa0c15966417ff841
extra : source : d768123592505cb15bcb03f86b62e244c066626a
2017-11-27 22:50:31 -07:00
Mark Banner
35c35f9fa8
Bug 1422724 - Remove items that are no longer in PlacesUtils.jsm from ESLint's module.json list. r=mak
...
MozReview-Commit-ID: IkbT2Vz65FJ
--HG--
extra : rebase_source : 196caa055821cd850c3b3c82c7e717c9b0c91e68
2017-12-04 12:09:44 +00:00
Edouard Oger
0095a12f6f
Bug 1420266 - Regenerate constants.js exports in modules.json. r=tcsc
...
MozReview-Commit-ID: BvBZLLOk6oZ
--HG--
extra : rebase_source : 0c4dba8e8c9e95a071250a49c8a43cdc5da6fd96
2017-11-23 15:22:29 -05:00
Mark Banner
e4262540c6
Bug 1417944 - Enable ESLint rule mozilla/use-services for toolkit/. r=mossop
...
MozReview-Commit-ID: JhHXYma5Adp
--HG--
extra : rebase_source : 79d9876a82b39070d5d3cd1e9464e23d113c88a8
2017-11-22 13:36:34 +00:00
Mark Banner
4da30e3721
Bug 1386351 - Let the Lint hook default to pre-push (for git) if being called directly. r=glandium
...
MozReview-Commit-ID: 9TnLu8w92oN
2017-11-23 09:09:33 +00:00
steveck-chung
45ecb2c0e5
Bug 1022925 - Part 2: Move alternative name to extension file. r=lchang,scottwu
...
MozReview-Commit-ID: 4rFagXU5iit
--HG--
extra : rebase_source : af0f34250fd0f92c84aa3d9b648e72d5e08ca828
2017-11-10 18:36:22 +08:00
Ed Lee
2791b99bc9
Bug 1417017 - Check for content. usage at global and within add_task for no-cpows-in-tests. r=standard8
...
MozReview-Commit-ID: Asz6dM29uRJ
--HG--
extra : rebase_source : 4f5b67cc5ff48cbdb9afddc24f5842ecaeff0b15
2017-11-14 02:17:57 -08:00
Csoregi Natalia
2bccdfa7a0
Backed out 2 changesets (bug 1022925) for failing browser/base/content/test/static/browser_all_files_referenced.js r=backout on a CLOSED TREE
...
Backed out changeset edbf6d586c9a (bug 1022925)
Backed out changeset 44f9fc2f03bb (bug 1022925)
--HG--
rename : browser/extensions/formautofill/addressmetadata/addressReferences.js => browser/extensions/formautofill/content/addressReferences.js
2017-11-21 17:00:09 +02:00
steveck-chung
172ad9bbb9
Bug 1022925 - Part 2: Move alternative name to extension file. r=lchang,scottwu
...
MozReview-Commit-ID: 4rFagXU5iit
--HG--
extra : rebase_source : c80881a1154583494af6c8b560a2ed70e2f0af8c
2017-11-10 18:36:22 +08:00
Dan Banner
b2e847755c
Bug 1367704 - Enable the semi ESLint rule across the tree. r=standard8
...
MozReview-Commit-ID: GrlcOI9K2hJ
--HG--
extra : rebase_source : 6574cf3c67eb11733ffd9999c260f71c8551abc4
2017-05-28 19:57:46 +01:00
Andrew Halberstadt
c10125cefb
Bug 1405588 - [lint] Stop forwarding 'args' in the git pre-push hook, r=standard8
...
The args passed in from the git pre-push hook aren't necessarily a valid ref,
so can result in failure. By default, the git implementation should be smart
enough to automatically determine which ref to compare against, so passing this
in from the hook shouldn't be necessary.
MozReview-Commit-ID: ESMQqbeGOHd
--HG--
extra : rebase_source : 3c363b6c531f278d7c5b3ddf41fb0f16e79966dc
2017-11-01 17:07:18 -04:00
Mark Banner
7f5c3c3582
Bug 1375689 - Turn on experimentalObjectRestSpread in ESlint options. r=mossop
...
MozReview-Commit-ID: BLZp3HskBji
--HG--
extra : rebase_source : 721d0586deb572a5e989547d592d741cc9d15950
2017-11-14 13:21:16 +00:00
Mark Banner
2cb6019eeb
Bug 1371293 - Automatically clobber node_modules when upgrading from ESLint 3 to 4. r=ahal
...
This is intended to help with ensuring that developer's profiles cleanup and upgrade correctly, as we've seen issues in the past.
MozReview-Commit-ID: CqCRDN0y64I
--HG--
extra : rebase_source : a4668cd40bfaf1dc031e02713de78767305d4728
2017-11-07 14:30:56 +00:00
Mark Banner
c62d0c64f8
Bug 1371293 - Upgrade ESLint to version 4.8.0, configuration changes. r=mossop
...
MozReview-Commit-ID: 2YHYOLTtqxu
--HG--
extra : rebase_source : 7bbc673bb72d546e1fca63227d54b6607a4ab33e
2017-10-09 10:54:16 +01:00
Geoff Brown
cbb956e0c3
Bug 1407679 - Merge nsIIOService and nsIIOService2; r=nwgh
2017-11-10 07:03:36 -07:00
Margareta Eliza Balazs
7e070192d7
Merge inbound to mozilla-central r=merge a=merge
2017-11-10 11:55:43 +02:00
Nicholas Nethercote
f4dd5e2636
Bug 1414096 (attempt 2) - Remove support for nsISupportsString values in nsPrefBranch::{get,set}ComplexValue(). r=florian.
...
Bug 1345294 introduced nsPrefBranch::{get,set}StringPref(), which allowed the
getting of utf8 strings from prefs, which previously required using
nsISupportsString with {get,set}ComplexValue. That bug also converted most
uses.
This patch finishes the job.
- It removes the nsISupportsString support.
- It converts existing code that relied on the nsISupportsString.
- It removes the lint that was set up to detect such uses of nsISupportsString.
--HG--
extra : rebase_source : b885ee784704819e181430200af5ef762e269d14
2017-11-10 09:07:48 +11:00
Edouard Oger
1873a289f7
Bug 1415957 - Remove MozMill from TPS. r=tcsc
...
MozReview-Commit-ID: HyBXrNqhzIf
--HG--
extra : rebase_source : da197fa045f70621d5549e961876cfc6ce15264b
2017-11-09 15:34:06 -05:00
Narcis Beleuzu
57d9eb5fb1
Backed out 1 changesets (bug 1414096) for dt1 failures "devtools/client/commandline/test/browser_cmd_pref3.js" r=backout on a CLOSED TREE
...
Backed out changeset e843de356b7e (bug 1414096)
2017-11-08 18:04:01 +02:00
Narcis Beleuzu
218e1676cb
Merge inbound to mozilla-central r=merge a=merge
2017-11-08 12:51:09 +02:00
Nicholas Nethercote
8b3d03c666
Bug 1414096 - Remove support for nsISupportsString values in nsPrefBranch::{get,set}ComplexValue(). r=florian.
...
Bug 1345294 introduced nsPrefBranch::{get,set}StringPref(), which allowed the
getting of utf8 strings from prefs, which previously required using
nsISupportsString with {get,set}ComplexValue. That bug also converted most
uses.
This patch finishes the job.
- It removes the nsISupportsString support.
- It converts existing code that relied on the nsISupportsString.
- It removes the lint that was set up to detect such uses of nsISupportsString.
--HG--
extra : rebase_source : fb7af066adfa0491a79fae6282a62b08661553c8
2017-10-31 16:34:35 +11:00
Thom Chiovoloni
935734388d
Bug 1412351 - Make sync behave better during shutdown r=kitcambridge
...
MozReview-Commit-ID: 4zWNph8Zdld
--HG--
extra : rebase_source : 12e9f82222a4bcfe2161ad02669619b57f0442fe
2017-10-27 13:37:49 -04:00
Nick Alexander
96a9c22d8b
Bug 1409087 - Part 4: Remove browser JUnit 3 tests and build apparatus for {browser,background}.apk. r=Grisha,ted.mielczarek
...
The browser JUnit 3 test suite has never run in automation, and no
test has been added or updated since 2016. Half of the existing
"tests" are broken on my local device. This allows to clean several
Makefile's related to this undeveloped testing approach, which won't
be pursued post-Gradle.
MozReview-Commit-ID: 1EbGMLntuyR
--HG--
extra : rebase_source : b4751f96851a8df61c0333a3e0ade3805b280dfe
2017-11-02 16:03:00 -07:00
Thom Chiovoloni
4a77d5a93f
Bug 1388224 - Remove SyncStorageRequest HTTP wrapper class, which is no longer used r=kitcambridge
...
MozReview-Commit-ID: EgExfizNll5
--HG--
extra : rebase_source : 85a6098a5b985990bd3a8483936bf6cf768f1f0b
2017-11-01 17:17:46 -04:00
Sebastian Hengst
4ff29d14f8
merge mozilla-inbound to mozilla-central. r=merge a=merge
...
MozReview-Commit-ID: GSDYk9wLOAM
--HG--
rename : browser/base/content/test/general/browser_bug561636.js => browser/modules/test/browser/formValidation/browser_form_validation.js
rename : browser/base/content/test/general/browser_bug595507.js => browser/modules/test/browser/formValidation/browser_validation_iframe.js
rename : browser/modules/test/browser/browser_bug1319078.js => browser/modules/test/browser/formValidation/browser_validation_invisible.js
2017-11-01 22:55:12 +01:00
Jim Chen
d19eceacd5
Bug 1406168 - 1. Remove JNI.jsm; r=sebastian
...
Remove JNI.jsm. Convert code that used JNI.jsm to the equivalent using
EventDispatcher.
MozReview-Commit-ID: JQdCubcTBAR
2017-11-01 14:48:48 -04:00
Mark Banner
d7b2685724
Bug 1412890 - Enable ESLint rule mozilla/use-services for toolkit/components/passwordmgr. r=MattN
...
MozReview-Commit-ID: BNojtj1cAji
--HG--
extra : rebase_source : 8480740988f3d7f94358360926ae8957c06a0758
2017-10-30 16:28:39 +00:00
Attila Craciun
566b7a287d
Backed out 1 changesets (bug 1412890) possible ESlint failure r=backout on a CLOSED TREE.
...
Backed out changeset cac71ff2481c (bug 1412890)
2017-11-01 10:32:50 +02:00
Mark Banner
7dcccb8252
Bug 1412890 - Enable ESLint rule mozilla/use-services for toolkit/components/passwordmgr. r=MattN
...
MozReview-Commit-ID: BNojtj1cAji
--HG--
extra : rebase_source : cfbe9b186e4be171674807a48d9e1accb67b34db
2017-10-30 16:28:39 +00:00
Valentin Gosu
1bd153659e
Bug 1407720 - Merge nsICookieManager and nsICookieManager2 r=nwgh
...
MozReview-Commit-ID: HuzeeB43YZZ
--HG--
extra : rebase_source : 3924170ce50126dbbae7c97cae601b69d0ab95af
2017-10-31 13:02:28 +01:00
Mark Banner
01008c7d57
Bug 1412778 - Enable ESLint rule no-cpows-in-tests across the whole tree. r=florian
...
MozReview-Commit-ID: 8pidN7x6MYh
--HG--
extra : rebase_source : 6a0d6800091231fc1535223bd7fc6df0ba40d47b
2017-10-30 09:55:39 +00:00
Mark Banner
3b50478984
Bug 1246896 - Bump version number of eslint-plugin-mozilla, and update its dev dependencies. r=florian
...
MozReview-Commit-ID: 1rmbkvCeXfa
--HG--
extra : rebase_source : a79b9c1412914362bfd227478511c54729b801e7
2017-10-27 16:44:53 +01:00
Mark Banner
0f98aa8a05
Bug 1246896 - Improve detection for mozilla/no-cpows-in-tests.js 'content' - only notify when content is used as an identifier. r=florian
...
MozReview-Commit-ID: 1X38Wq4hUmZ
--HG--
extra : rebase_source : 6d7b0e8c9048045b47af02590455e060411953e3
2017-10-13 17:04:48 +01:00
Mark Banner
272b0102c2
Bug 1246896 - Add some basic tests for ESLint rule mozilla/no-cpows-in-tests.js. r=florian
...
MozReview-Commit-ID: 2tZS1GYUUbH
--HG--
extra : rebase_source : 9feff09ef0305e67b3580c6260740ccdbfa699c4
2017-10-13 16:10:36 +01:00
Sebastian Hengst
443416f881
Merge mozilla-central to autoland. r=merge a=merge
2017-10-26 00:39:55 +02:00
Andrew Halberstadt
59d606ead7
Bug 1411568 - Enable py3 linter on testing/xpcshell r=stevea1+601043
...
MozReview-Commit-ID: 722pub6TTuQ
--HG--
extra : rebase_source : 54571c07d49cdb01b3593c861fa708f51fd2f7bd
2017-10-25 08:51:16 -04:00
Sebastian Hengst
1ead0a96a9
Backed out changeset dab1c5badddb (bug 1407679) for failing server startup in mochitests on Android. r=backout on a CLOSED TREE
...
--HG--
extra : amend_source : 3dc4cb2bbaf55f3f6329687ce64d4e862fc3800b
2017-10-24 21:18:26 +02:00
Valentin Gosu
9dd47ebf50
Bug 1407679 - Merge nsIIOService and nsIIOService2 r=nwgh
...
Removes deprecated nsIIOService2.newChannelFromURIWithProxyFlags
MozReview-Commit-ID: Gr3nA25kcre
--HG--
extra : rebase_source : 3407b5ed0f8f7067523abee28c137db3cac86b14
2017-10-20 16:41:07 +02:00
Steve Armand
fa0b6e7c7e
Bug 1397849 - Enable py2 and py3 linter on testing/mozbase. r=ahal
...
MozReview-Commit-ID: GnaVLhtO4un
--HG--
extra : rebase_source : 8839a423c5db505469b813957649b1605ed5737f
2017-09-25 22:57:18 -04:00
Sylvestre Ledru
e0bda6ceaf
Bug 1410938 - Make mach_commands.py flake8/pep8 compatible and add it the list of flake8 files r=gps
...
MozReview-Commit-ID: HKWsDehR0vZ
--HG--
extra : rebase_source : 1e77f8aee5f909dd7b4cfaace6014015c51cf589
2017-10-23 18:40:22 +02:00
Attila Craciun
a323e78c2b
Merge mozilla-central to mozilla-inbound. r=merge a=merge CLOSED TREE
2017-10-25 12:36:59 +03:00
Steve Armand
df510b4622
Bug 1403131 - Run linters against mozharness scripts and configs. r=rail
...
MozReview-Commit-ID: 3dkx1SQiIns
--HG--
extra : rebase_source : 45f049032243b8bbae7d052a89cefcdb2b7e1f60
2017-10-24 20:21:41 -04:00
Sebastian Hengst
a79a507dc2
Backed out changeset 6fa6cfe0199c (bug 1403131) for mass reftest failures. r=backout on a CLOSED TREE
...
--HG--
extra : amend_source : 4d399778793d9239e5c441fe237a15d12c4f1360
2017-10-23 16:39:24 +02:00
Steve Armand
3be377b84e
Bug 1403131 - Run linters against mozharness scripts and configs. r=rail
...
--HG--
extra : rebase_source : 4d9458f1819de0a73af9191d560557ab01ffa32e
extra : histedit_source : 1a3c743a9a1c6a3304e4a924be90164fcf882e1f%2C440a79ff12f256a2a79aff6b592fe838c1c9e6e3
2017-10-23 09:46:15 -04:00
Patrick Brosset
714264d3e8
Bug 1406061 - Remove the unused Jsbeautify.jsm module; r=jdescottes
...
MozReview-Commit-ID: KF39qXJ2s11
--HG--
extra : rebase_source : 29394e085bf80d394dd4e1c6013082c0ebe94069
2017-10-19 09:58:19 +02:00
Mark Banner
8340eb52c8
Bug 1230373
- Add an ESLint rule to prefer using Services.jsm rather than getService. r=mossop
...
MozReview-Commit-ID: G9dp4PxcyT7
--HG--
extra : rebase_source : 957b5ead56c8c778b1ba812343c132b34030135f
2017-10-06 17:03:38 +01:00
Mark Banner
d4ad271c61
Bug 1230373
- Fix an issue with eslint-plugin-mozilla not detecting the global scope properly when arrow functions are used. r=mossop
...
MozReview-Commit-ID: IOCM8Fjl0xQ
--HG--
extra : rebase_source : 63face219569f50bdfb00bcd7384f334ec6113c2
2017-10-16 15:08:26 +01:00
Blake Kaplan
0a9754f57f
Bug 1406212 - Remove the code that handles extensions for e10s{,-multi}. r=Felipe
...
MozReview-Commit-ID: ElPZIBmOYHR
--HG--
extra : rebase_source : 97e955084c71be1658a588013160d69469dc307c
2017-09-28 16:09:20 -07:00
Steve Armand
82b69a173f
Bug 1408365 - Enable flake8/py2/py3 linters on python/mozboot. r=ahal
...
MozReview-Commit-ID: 3koZq509bjP
--HG--
extra : rebase_source : 9accfc2b727fd7c1f4fad97d1a244d62f4fae714
2017-10-13 23:33:00 -04:00
Philipp Kewisch
28bc073914
Bug 1312191 - Do not hardcode INDENT_LEVEL in xbl preprocessor. r=miker
...
MozReview-Commit-ID: EiufIKCNfSs
--HG--
extra : rebase_source : 8acea9052135d88cbf1f58f7090d5a9d60c61c2e
2017-10-08 14:40:16 +02:00
Phil Ringnalda
ecdb97c7dc
Backed out 6 changesets (bug 1406212) for mass reftest failures
...
CLOSED TREE
Backed out changeset 1c9fe35de901 (bug 1406212)
Backed out changeset 1acc4c270bf9 (bug 1406212)
Backed out changeset d9ea9cff849f (bug 1406212)
Backed out changeset 5bf2f08f01f9 (bug 1406212)
Backed out changeset 1a050da96e9e (bug 1406212)
Backed out changeset 1b5e78113f06 (bug 1406212)
MozReview-Commit-ID: LizV8CD4IY4
2017-10-12 19:45:23 -07:00
Blake Kaplan
4c3264d49f
Bug 1406212 - Remove the code that handles extensions for e10s{,-multi}. r=Felipe
...
MozReview-Commit-ID: ElPZIBmOYHR
--HG--
extra : rebase_source : 967287969f7d8c52c7522f449de55e8f36dd3f35
2017-09-28 16:09:20 -07:00
Edouard Oger
4397201c90
Bug 1407726 - Add reason field to push messages sent with /notify. r=tcsc
...
MozReview-Commit-ID: 3sRpheND9Wa
--HG--
extra : rebase_source : 23f7dffb920f9f9f14ccdd16f171c489f36745cc
2017-10-11 14:58:21 -04:00
Sylvestre Ledru
358507fde2
Bug 1406650 - Make build/*.py and a few other files flake8 compatible and add them to the list of files to check r=chmanchester
...
MozReview-Commit-ID: icmFJtbWdN
--HG--
extra : rebase_source : 7b2ef783822bcad7f955bad8cbd6cea6df588f92
2017-10-07 16:45:22 +02:00
Sylvestre Ledru
816ba0c177
Bug 1406668 - Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium
...
MozReview-Commit-ID: 89NxxGUVjHV
--HG--
extra : rebase_source : 278ceb2d7d31da086216288bd54688fe25faa03b
2017-10-12 15:22:59 +02:00
Sebastian Hengst
3980c1732a
Backed out changeset 4dc78384cb58 (bug 1406668) for flake8 linting failures. r=backout
...
--HG--
extra : rebase_source : 20f93207038c76e2804f255e4ebfdd5e03a8f7cc
2017-10-12 15:08:35 +02:00
Sylvestre Ledru
a102c9f46a
Bug 1406668 - Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium
...
MozReview-Commit-ID: 89NxxGUVjHV
--HG--
extra : rebase_source : 658301cb32e9c042cd1931456e4e7b8f475900bd
2017-10-11 16:28:29 +02:00
Sebastian Hengst
7a40cdf1bb
Backed out changeset b526011049ee (bug 1406668) for linting failures. r=backout
...
--HG--
extra : amend_source : fe8373f9572300c7fd090f529c6957fbf905d9ef
2017-10-12 14:41:28 +02:00
Sylvestre Ledru
4e4de3339f
Bug 1406668 - Make build/moz.configure/*.configure compliant to the pep8 format + add to the list of directories to check r=glandium
...
MozReview-Commit-ID: 89NxxGUVjHV
--HG--
extra : rebase_source : 3d22007ea6793961e7031603efe58cdc66e3c6c9
2017-10-11 16:28:29 +02:00
Sylvestre Ledru
20dc07df5f
Bug 1406672 - check_macroassembler_style.py: add to the list of file to check r=ahal
...
MozReview-Commit-ID: 8BzsrTLcEY6
--HG--
extra : rebase_source : 7b01271fed086771df1720665ad1532ef8252812
2017-10-11 16:15:18 +02:00
Sylvestre Ledru
d1799c5b65
Bug 1406669 - Add the .configure extension to flake8 support r=ahal
...
MozReview-Commit-ID: ErnYnQMv5pj
--HG--
extra : rebase_source : 0ee34dd517f735220a950c1a1df1213625d7e417
2017-10-11 16:03:32 +02:00
Sylvestre Ledru
61e0724a88
Bug 1406666 - Add testing/*cppun*.py to the list of flake8 compliant code r=ahal
...
MozReview-Commit-ID: KWsXMRgy4XG
--HG--
extra : rebase_source : b6e82fcd6f5dfb9f823ac5d00c623387b7e95632
2017-10-07 19:45:12 +02:00
Peter Van der Beken
772f1ee5da
Bug 1383059 - Remove instanceof for supplemental interfaces. Part 2: remove support for supplemental interfaces in instanceof code and remove unnecessary ChromeWindow interface. r=bz.
...
--HG--
extra : rebase_source : e8ce446e7f1844c6d1d352896873cbb865837632
extra : source : 944786dca81aed2e480562694bfabc6e5fbf1266
2017-07-05 23:01:04 +02:00
Dan Banner
14ad0fcb62
Bug 1395890 - Change all ESLint rules that are warnings to errors. r=standard8
...
MozReview-Commit-ID: LJS6m1GppiS
--HG--
extra : rebase_source : 4a14e3309b7d554d9a1aa0d26f464e26bec3291e
2017-09-18 19:07:17 +01:00
Kris Maglione
3676137220
Bug 1404172: Remove MatchPattern.jsm. r=aswan
...
MozReview-Commit-ID: ItGMuChHS3z
--HG--
rename : toolkit/modules/addons/MatchPattern.jsm => toolkit/modules/addons/MatchURLFilters.jsm
extra : rebase_source : 986542ba4270799ca1d213d5b4807d12ab7ac148
2017-09-28 18:27:44 -07:00
Andrew Halberstadt
8dd527bf64
Bug 1401309 - Add python/mozversioncontrol to flake8 linter, r=gps
...
MozReview-Commit-ID: KuyEYa3Mbgd
--HG--
extra : rebase_source : cd3c111432de83d19004946c491f10959fd6d675
2017-09-20 10:02:26 -04:00
Sebastian Hengst
73fac0091d
Backed out changeset dbe60b600dc0 (bug 1397853) for failining linter py-compat at testing/mochitest/runtests.py:2236. r=backout
2017-09-28 14:58:36 +02:00
Steve Armand
f8318d16e8
Bug 1397853 - Enable py2 and py3 linter on testing/mochitest. r=ahal
...
MozReview-Commit-ID: EhkNhyFHDox
--HG--
extra : rebase_source : 5200a985034c7ca0a494bc7d02a4c842e85dec3a
2017-09-24 21:28:25 -04:00
Tomislav Jovanovic
74b5af87d6
Bug 1386427 - Part 2: Extract HostManifestManager to NativeManifests.jsm r=kmag
...
MozReview-Commit-ID: GrVBZbkTfrB
--HG--
rename : toolkit/components/extensions/NativeMessaging.jsm => toolkit/components/extensions/NativeManifests.jsm
rename : toolkit/components/extensions/test/xpcshell/test_native_messaging.js => toolkit/components/extensions/test/xpcshell/test_native_manifests.js
extra : rebase_source : c83a79d2af724c5d6d15a6ca09330cc6173a8853
2017-09-15 20:14:56 +02:00
Thom Chiovoloni
6348cd2190
Bug 1393659 - Fix inconsistent handling of max_post_bytes and max_request_bytes r=markh
...
MozReview-Commit-ID: 4jwpAYNuoQj
--HG--
extra : rebase_source : f32ecbd9740f7d8647fdf37ad6bbb53e332320ac
2017-09-13 18:02:41 -07:00
Andrew Halberstadt
1815a94c1d
Bug 1392787 - Add a linter to prevent comment-disabling tests in manifestparser manifests, r=jmaher
...
MozReview-Commit-ID: LG47ASBMA17
--HG--
extra : rebase_source : 34d736370e1718b1b3f0ad1f4f08c768bc4b5ba3
2017-08-23 09:33:18 -04:00
Sebastian Hengst
48545a66e9
Backed out changeset f4c33a37fe6d (bug 1395890) for failing browser-chrome's browser/components/extensions/test/browser/browser_ext_find.js. r=backout on a CLOSED TREE
2017-09-19 16:35:31 +02:00
Dan Banner
d9bd75f0cc
Bug 1395890 - Change all ESLint rules that are warnings to errors. r=standard8
...
MozReview-Commit-ID: LJS6m1GppiS
--HG--
extra : rebase_source : 0428c961831f079a63f345c8d6684b869fbcdecd
2017-09-18 19:07:17 +01:00
Steve Armand
d11ffd18db
Bug 1399989 - Add python/mach to flake8 linter. r=gps
...
MozReview-Commit-ID: KKnBgYFwpfT
--HG--
extra : rebase_source : 4e4b3453a91970366dba0073853ad3ab62738c81
2017-09-17 22:41:17 -04:00
Mark Banner
5c31c8a30b
Bug 1399946 - Bump version number of eslint-plugin-mozilla for releasing the dependency fixes from bug 1395879. r=ahal
...
MozReview-Commit-ID: 79nDcgcvm0c
--HG--
extra : rebase_source : 78d2dd8eaec5d36c8611effe96f93949b76929e9
2017-09-18 09:15:57 +01:00
Edouard Oger
dc3b62bea0
Bug 1383663 part 3 - Update FxA local state on profile email change. r=markh
...
MozReview-Commit-ID: 5epKjoT4TF3
--HG--
extra : rebase_source : 3c9737d304d2a4a4448e43c1f4a13e738716453e
2017-08-21 17:01:57 -04:00
Phil Ringnalda
e6c038d6ee
Backed out 3 changesets (bug 1383663) for timeouts in browser_aboutAccounts.js and failures in test_web_channel.js
...
Backed out changeset f384a524cac6 (bug 1383663)
Backed out changeset 9d26a627e2f8 (bug 1383663)
Backed out changeset c7d46e2e8ddc (bug 1383663)
MozReview-Commit-ID: 88xbdeVJtK2
2017-09-16 10:40:00 -07:00
Edouard Oger
3d91da7159
Bug 1383663 part 3 - Update FxA local state on profile email change. r=markh
...
MozReview-Commit-ID: 5epKjoT4TF3
--HG--
extra : rebase_source : 437b8d56d48898b347ecaf3d9ca0f6cc3176d2e2
2017-08-21 17:01:57 -04:00
Mark Banner
2c7467dd71
Bug 1395879 - Remove espree/escope etc from the direct dependencies of eslint-plugin-mozilla since they are really peerDependencies supplied by the existing eslint peer. r=mossop
...
MozReview-Commit-ID: 2FEfFaEoomU
--HG--
extra : rebase_source : f284707bb792443de11c57524f0bd296fdc675cf
2017-09-01 11:27:33 +01:00
Steve Armand
5d8117b9de
Bug 1397852 - Enable flake8 linter on testing/xpcshell. r=ahal
...
MozReview-Commit-ID: CvZVXQPx8jF
--HG--
extra : rebase_source : 359f148397ef5584028e343080c6774407f74db6
2017-09-14 09:51:27 -04:00
ruby
af79c59e2a
Bug 1397427 - Enable py2 linter on tools/tryselect, r=ahal
...
MozReview-Commit-ID: K12XisbVQGq
--HG--
extra : rebase_source : 6a97dda2be81fa45601c2f09486c4a187f177cf5
2017-09-13 11:57:47 +05:30
Alexandre Poirot
f2bfc94341
Bug 1399449 - Convert devtools/client/responsivedesign/responsivedesign.jsm to a commonjs module. r=jryans
...
MozReview-Commit-ID: Jl6OGUWnbHN
--HG--
rename : devtools/client/responsivedesign/responsivedesign.jsm => devtools/client/responsivedesign/responsivedesign.js
extra : rebase_source : 329c364fc4c256273b0d02a8119637aed428134c
2017-09-13 14:33:58 +02:00
Steve Armand
5934392346
Bug 1397855 - Enable py2 and py3 linter on testing/xpcshell. r=ahal
...
MozReview-Commit-ID: CsfIcI1ma7J
--HG--
extra : rebase_source : 53658c33432927f72ddce0999f18c2b7df261f6d
2017-09-07 21:15:35 -04:00
Sebastian Hengst
be553422dd
merge mozilla-central to autoland. r=merge a=merge
2017-09-13 11:30:55 +02:00
Andrew Halberstadt
a5c7e81ae6
Bug 1398765 - Fix directory exclusion bug in py-compat linters, r=gps
...
The excluded directories aren't being properly handled in the py2/py3 compat
linters. In order for FileFinder to apply the exclusions properly they need
to either be relative to or contained by the base.
This means that currently the following will work:
./mach lint -l py2 <topsrcdir>
./mach lint -l py2 testing/mochitest
But this is broken:
./mach lint -l py2 testing
This change fixes the compat linters so exclude paths will be made relative
to the FileFinder base before passing them in. Any exclude not contained by
the base is simply discarded as it won't be relevant to that FileFinder
instance anyway.
MozReview-Commit-ID: LJx97TvKlSa
--HG--
extra : rebase_source : b8f0cb20ec5a88a33c26ace699ed9216b070f443
2017-09-11 09:03:53 -04:00
Sebastian Hengst
69de1aac47
Backed out changeset ec61b7a902c2 (bug 1397855) for XPCshell bustage, at least on Android. r=backout on a CLOSED TREE
2017-09-12 21:42:12 +02:00
Steve Armand
d4bfc7402c
Bug 1397855 - Enable py2 and py3 linter on testing/xpcshell. r=ahal
...
MozReview-Commit-ID: CsfIcI1ma7J
--HG--
extra : rebase_source : 1cdb7a848813a4a4872005095550b74c13ebecdf
2017-09-07 21:15:35 -04:00
Kris Maglione
e99cced382
Bug 1371065: Part 1 - Remove external references to the add-on SDK. r=Mossop,glandium
...
MozReview-Commit-ID: D5KyHcg8Ujk
--HG--
extra : rebase_source : 1a74ccb2963f2946a49c8bf720af595151b48fd1
2017-09-12 11:54:47 -07:00
Ionut Goldan
f3028165fe
Bug 1396217 - resolve py2 and py3 lint errors r=jmaher
...
MozReview-Commit-ID: LG332HzJKcw
--HG--
extra : rebase_source : b82da0cceac18f310cadf945578464c2fb4704c4
2017-09-08 11:27:26 +03:00
Steve Armand
08d5fcd935
Bug 1397423 - Enable py2 linter on python/mozlint. r=ahal
...
MozReview-Commit-ID: 6QX7YCmfjdJ
--HG--
extra : rebase_source : 0610d67f376c462b0f103a6510f21459fc39f940
2017-09-06 22:52:46 -04:00
Dustin J. Mitchell
d7b6f0148a
Bug 1397318: mozlint -l py2 for taskcluster/; r=ahal
...
MozReview-Commit-ID: 1ZUOrIfxQef
--HG--
extra : rebase_source : c398af2faa83812a70213679d5cb4ad0024d8f7d
2017-09-06 17:29:32 +00:00
Sebastian Hengst
9c8a09d458
merge mozilla-inbound to mozilla-central. r=merge a=merge
...
MozReview-Commit-ID: KLssMPhSQ0O
2017-09-06 11:26:13 +02:00
Sebastian Hengst
b278f15c7f
merge mozilla-central to mozilla-inbound. r=merge a=merge
2017-09-06 00:00:04 +02:00
Cosm
917335fa1c
Bug 1395956 - Update gecko.readthedocs links to the new firefox-source-docs.mozilla.org location. r=chutten
2017-09-02 22:11:02 +05:30
Mark Hammond
27afdd11e1
Bug 1396544 - don't schedule syncs when Sync isn't configured. r=rnewman
...
MozReview-Commit-ID: AM0G43vFyty
--HG--
extra : rebase_source : 9888cfd079f4761debb710d1bbe064956aec1093
2017-09-05 12:40:53 +10:00
Steve Armand
e46ff00709
Bug 1368967 - Enable the ESLint generator-star-spacing rule across mozilla-central. r=standard8
...
MozReview-Commit-ID: 5do3eoCEAMR
--HG--
extra : rebase_source : 5f692e474e1d7d173fcb4c9c08617f0fe489e443
2017-09-04 00:49:32 -04:00
Mark Hammond
2dad858a21
Bug 1375635 - Add telemetry for how often and long users are in bad authentication states. r=Dexter,rweiss+418169,tcsc
...
MozReview-Commit-ID: BW8ixM3wmxJ
--HG--
extra : rebase_source : 6872e86fbd6ff00c4ab65ef4bf8c6195e06de54b
2017-07-27 11:59:24 +10:00
Andrew Halberstadt
3411e8b3d4
Bug 1391019 - Add py2 and py3 compatability linters, r=gps
...
check_compat.py was adapted from gps' check-py3-compat.py in mercurial:
https://www.mercurial-scm.org/repo/hg/file/tip/contrib/check-py3-compat.py
The py3 linter simply runs ast.parse(f) for each file being linted. Any syntax errors
are formatted as mozlint results and dumped to stdout as json. I looked into also
importing the file (using 3.5+'s importlib.util.spec_from_file_location), but there
were too many problems:
1. Lots of false positives (e.g module not found)
2. Some files seemed to run indefinitely on import
I decided to punt on importing for now, we can always investigate in a follow-up.
The py2 linter runs ast.parse(f), and also checks that the file has:
from __future__ import absolute_import, print_function
Initially every python file in the tree is excluded from the py2 check, though
at least this makes it easy to find+fix, and new files in un-excluded
directories will automatically be linted.
MozReview-Commit-ID: ABtq9dnPo9T
--HG--
extra : rebase_source : 60762937284d498514cd020b90cbfd2ba23f0b70
2017-08-31 10:12:02 -04:00
Andrew Halberstadt
3c2a0965ed
Bug 1391019 - Move tools/lint/flake_/__init__.py to tools/lint/python/flake8.py, r=gps
...
This will allow us keep python related linting files in the same place.
MozReview-Commit-ID: ABtq9dnPo9T
--HG--
rename : tools/lint/flake8_/__init__.py => tools/lint/python/__init__.py
rename : tools/lint/flake8_/__init__.py => tools/lint/python/flake8.py
rename : tools/lint/flake8_/flake8_requirements.txt => tools/lint/python/flake8_requirements.txt
extra : rebase_source : 2568bc0bf8f4adbf8e0be73a54d5da068a8d81b0
2017-08-31 10:06:08 -04:00
Andrew Halberstadt
74afe80557
Bug 1339178 - Add python/mach_commands.py and config/mozunit.py to flake8 linter, r=davehunt
...
MozReview-Commit-ID: Gcsz6z8MeOi
--HG--
extra : rebase_source : 121c9007d336cecbd068075dc54d66cc06e8334e
2017-08-29 14:41:38 -04:00
Andrew Halberstadt
2255a9eed7
Bug 1395126 - Support cascading configuration for flake8, r=bc
...
This allows .flake8 files to override one another, and fixes a pretty bad known
bug with our flake8 implementation. For example, say we have a .flake8 file at:
/foo/.flake8
Before this patch, if we ran |mach lint foo/bar|, the configuration defined in
that .flake8 file wouldn't get picked up. It would only work if running the
specific directory that contains it, e.g |mach lint foo|.
This change additionally allows multiple .flake8 files to be used. So if
there's one defined at both:
/.flake8
/foo/.flake8
Then running |mach lint foo/bar| will first apply the root .flake8, then the
one under /foo (overriding earlier configuration).
This bug still doesn't make flake8 configuration perfect though. Any directory
containing a .flake8 file still needs to be explicitly listed in the "include"
section of /tools/lint/flake8.yml. Otherwise in the example above, if running
|mach lint /|, it wouldn't be able to find /foo/.flake8. This is a hard problem
and is likely best solved by fixing flake8's upstream configuration handling.
Unfortunately this means we still can't switch from a whitelist to a blacklist.
MozReview-Commit-ID: 3DZAi1QHYYo
--HG--
extra : rebase_source : 51298c5847f6c2792581d9b312c87b70fa716ee1
2017-08-29 17:32:31 -04:00
Phil Ringnalda
5e0cb1d330
Merge m-c to m-i
...
MozReview-Commit-ID: 3TTO51aTTST
2017-08-26 18:20:19 -07:00
Zibi Braniecki
c5a354a1d6
Bug 1393928 - Expose intl/l10n .jsm APIs explicitly. r=mossop
...
MozReview-Commit-ID: Z57nlQJnQT
--HG--
extra : rebase_source : 5b6e5e804a14eef7847dfa1aada4588d401a43f6
2017-08-25 12:59:18 -07:00
Kris Maglione
b744ab0807
Bug 1384714: Use subscript loader to load browser.xul scripts. r=Mossop
...
There's a lot of overhead to loading scripts from <script> tags in
browser.xul. They're loaded asynchronously, and can't begin loading until
after we begin loading browser.xul. They're loaded using off-main-thread
compilation, which means we need to create and merge a new JS zone for each
script we load that way. They don't benefit from the startup cache at all.
If we load those scripts using the subscript loader, they're loaded from the
preloader cache, and begin loading as early as possible. And they're all
loaded into a single off-thread zone, which means there are less zones to
create and merge. From a quick test, this seems to save about 20-40ms on
Windows ts_paint talos runs.
The main downside is that subscript loader scripts don't benefit from lazy
parsing, so we might wind up increasing memory usage if most of the functions
in those scripts aren't used very often. But we should hopefully be able to
fix that by migrating more browser JS to lazy loading.
MozReview-Commit-ID: Lozb0d0QweC
--HG--
extra : rebase_source : 069a003dfd1d6d66540da814a1fd19742c4fca26
extra : amend_source : b93e0ef7b320c99f4a27ddf6e8af6a681b6dba0f
2017-07-25 20:56:37 -07:00
Dan Banner
f1eb5aaa84
Bug 1392119 - Enable the ESLint no-caller rule across mozilla-central r=standard8
...
MozReview-Commit-ID: JOC1330iFnh
--HG--
extra : rebase_source : 2afcb219d4a0d78f996bdc2c841456d2dccff605
2017-08-23 13:38:24 +01:00
Wes Kocher
e8f7cc0bb3
Backed out 2 changesets (bug 1392787) for build bustage a=backout CLOSED TREE
...
Backed out changeset 2ce8a387fa80 (bug 1392787)
Backed out changeset bf5a6ff97a8f (bug 1392787)
MozReview-Commit-ID: 2cA5bdnNDIe
2017-08-24 14:00:42 -07:00
Andrew Halberstadt
b24f01064e
Bug 1392787 - Add a linter to prevent comment-disabling tests in manifestparser manifests, r=jmaher
...
MozReview-Commit-ID: LG47ASBMA17
--HG--
extra : rebase_source : df925b5d234a889bfb472eb33a3204465aa64f79
2017-08-23 09:33:18 -04:00
Mark Banner
a53020d022
Bug 1392098 - Enable the new ESLint no-useless-run-test rule across the tree. r=mossop
...
MozReview-Commit-ID: 35MaseieNUk
--HG--
extra : rebase_source : 98eaec6a67fd3b30ea6b0be641f26c3911012fab
2017-08-20 18:52:05 +01:00
Mark Banner
a9005029b6
Bug 1392098 - Add an ESLint rule to avoid unnecessary run_test() functions. r=mossop
...
MozReview-Commit-ID: pbXjamX4bk
--HG--
extra : rebase_source : cc506d08e7d47e75464ca7f07bd3ef323184270d
2017-08-18 21:49:44 +01:00
Andrew Halberstadt
115f346cd8
Bug 1392795 - [yamllint] Group paths to lint by their closest config and run each config group separately, r=dustin
...
This makes configuration files for yamllint work a bit better. It's still not perfect, but it's an improvement
on the current situation.
MozReview-Commit-ID: IKxgQm1a7bP
--HG--
extra : rebase_source : 051fafe21337f0557ee39ec71c90e74fd61d3da7
2017-08-23 11:28:28 -04:00
Wes Kocher
c043502159
Merge m-c to autoland, a=merge
...
MozReview-Commit-ID: 7sFZmPUXSx6
2017-08-18 17:21:29 -07:00
James Graham
30cd16ab59
Bug 1391582 - Fix wpt lint for upstream changes, a=testonly
...
MozReview-Commit-ID: 42Bozz991wW
2017-08-18 17:26:54 +01:00
Luke Chang
04df87ad05
Bug 1387988 - [Form Autofill] Move "findLabelElements" function to FormAutofillHeuristics.jsm. r=MattN
...
MozReview-Commit-ID: 93c9R7JaCLA
--HG--
extra : rebase_source : 2cb9276901c4f2ff91da55cc5d0dc095a74524dd
2017-08-07 18:34:27 +08:00
Andrew Halberstadt
411adfbc83
Bug 1387555 - [mozlint] Make use of quickfix when using --edit with vim/nvim, r=dylan
...
MozReview-Commit-ID: BlJbWVv1CeO
--HG--
extra : rebase_source : 005f72d9f74ccd86ae73a298acde6b0b3fd6a550
2017-08-09 10:03:02 -04:00
Andrew Halberstadt
d2109610fb
Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
...
MozReview-Commit-ID: 5lO0uAjHMsw
--HG--
extra : rebase_source : 8607b3964da207a6076c79b6f1d75b40503cdd7d
2017-08-10 14:48:21 -04:00
Phil Ringnalda
0ff5a4285d
Backed out changeset 6896f93a2327 (bug 1385352) for not making it to m-c before the next violation of its new linting rule merged to autoland
...
MozReview-Commit-ID: 3HDE2C3wSU0
2017-08-10 20:21:19 -07:00
Wes Kocher
cff9e9b197
Merge m-c to autoland, a=merge
...
MozReview-Commit-ID: 2YvHbITn9w3
2017-08-10 18:25:34 -07:00
Wes Kocher
936a9461f6
Merge inbound to m-c a=merge
...
MozReview-Commit-ID: KRQeIGmhAPA
2017-08-10 18:14:34 -07:00
Justin Wood
20a660940c
Bug 1387862 - Lint the linter config yaml files themselves. r=ahal
...
We should have CI Lint YAML files in the tree.
MozReview-Commit-ID: F8hTBerSNIj
--HG--
extra : rebase_source : 87f84b855f29b5625bacae5c199d99d144c02bc8
2017-08-06 13:47:03 -04:00
Justin Wood
8d2bd44930
Bug 1387862 - Lint NSS's taskcluster.yml. r=dustin
...
We should have CI Lint YAML files in the tree.
MozReview-Commit-ID: ATX5IOK747y
--HG--
extra : rebase_source : c7a5a0e7a33a6a52ec92d6d6fd8a7c35bfdfa5c0
2017-08-06 13:44:41 -04:00
Justin Wood
f66ff278ca
Bug 1387862 - Lint python/mozlint yaml files. r=ahal
...
We should have CI Lint YAML files in the tree.
MozReview-Commit-ID: IMOKGhxKFJW
--HG--
extra : rebase_source : 8c695dcb3a81b6683bc76ba663feeacb3126691e
2017-08-06 13:43:04 -04:00
Justin Wood
5b369e18a4
Bug 1387862 - Lint taskcluster's cron.yml file, fixup lint errors. r=dustin
...
We should have CI Lint YAML files in the tree.
MozReview-Commit-ID: 758kdSddjJN
--HG--
extra : rebase_source : d538b8400a92d14ab6b397f33327619e885106cc
2017-08-06 13:35:27 -04:00
Justin Wood
3f653d8d9b
Bug 1387862 - Lint taskcluster yaml files. r=dustin
...
We should have CI Lint YAML files in the tree.
MozReview-Commit-ID: L83j6SODA3w
--HG--
extra : rebase_source : afb1a26e4a6819fc326f3bd1e9b856d6104597a8
2017-08-06 13:26:13 -04:00
Justin Wood
b09ed76339
Bug 1387862 - Add initial support for ./mach lint -l yaml r=ahal,dustin
...
We should have CI Lint YAML files in the tree.
MozReview-Commit-ID: HYVWXzNnnzG
--HG--
rename : tools/lint/flake8_/__init__.py => tools/lint/yamllint_/__init__.py
extra : rebase_source : f4919be1341f6081b99d8b122004f9c2978cc677
2017-08-06 13:23:48 -04:00
Sebastian Hengst
19fae7e07d
Backed out changeset 98c08b9cc52e (bug 1387862) for linting failure at .cron.yml:51 (too few spaces). r=backout
2017-08-10 14:30:46 +02:00
Sebastian Hengst
65a53b0bca
Backed out changeset a86a804e64ee (bug 1387862)
2017-08-10 14:29:59 +02:00
Sebastian Hengst
88b3637c8c
Backed out changeset c13bd0798514 (bug 1387862)
2017-08-10 14:29:54 +02:00
Sebastian Hengst
ca07202265
Backed out changeset 103073e92350 (bug 1387862)
2017-08-10 14:29:48 +02:00
Sebastian Hengst
33266b5810
Backed out changeset 9e1723c2e1c9 (bug 1387862)
2017-08-10 14:29:43 +02:00
Sebastian Hengst
ce4158f736
Backed out changeset 57176d7ff82a (bug 1387862)
2017-08-10 14:29:37 +02:00
Justin Wood
1a5e403ed2
Bug 1387862 - Lint the linter config yaml files themselves. r=ahal
...
We should have CI Lint YAML files in the tree.
MozReview-Commit-ID: F8hTBerSNIj
--HG--
extra : rebase_source : 2d1d3d8d98fd3f0abe3494c49ad01072181c4e08
2017-08-06 13:47:03 -04:00
Justin Wood
6f775a5e66
Bug 1387862 - Lint NSS's taskcluster.yml. r=dustin
...
We should have CI Lint YAML files in the tree.
MozReview-Commit-ID: ATX5IOK747y
--HG--
extra : rebase_source : 24583ac74033923f0e4bcf6053169f09ef76b833
2017-08-06 13:44:41 -04:00
Justin Wood
582030b224
Bug 1387862 - Lint python/mozlint yaml files. r=ahal
...
We should have CI Lint YAML files in the tree.
MozReview-Commit-ID: IMOKGhxKFJW
--HG--
extra : rebase_source : a2e47f5c5517e999fe21bac4f86491611bd0cece
2017-08-06 13:43:04 -04:00
Justin Wood
687c9e4240
Bug 1387862 - Lint taskcluster's cron.yml file, fixup lint errors. r=dustin
...
We should have CI Lint YAML files in the tree.
MozReview-Commit-ID: 758kdSddjJN
--HG--
extra : rebase_source : 8c8d55ea55737a5c2faca9f91478c72296c881b7
2017-08-06 13:35:27 -04:00
Justin Wood
b987f769d1
Bug 1387862 - Lint taskcluster yaml files. r=dustin
...
We should have CI Lint YAML files in the tree.
MozReview-Commit-ID: L83j6SODA3w
--HG--
extra : rebase_source : b5aee7a53c2fe25381116e45a4475d66ebba2903
2017-08-06 13:26:13 -04:00
Justin Wood
143c24a47a
Bug 1387862 - Add initial support for ./mach lint -l yaml r=ahal,dustin
...
We should have CI Lint YAML files in the tree.
MozReview-Commit-ID: HYVWXzNnnzG
--HG--
rename : tools/lint/flake8_/__init__.py => tools/lint/yamllint_/__init__.py
extra : rebase_source : 54460179e51f6263099a6837e1111dcce05a9331
2017-08-06 13:23:48 -04:00