Commit Graph

245 Commits

Author SHA1 Message Date
Jonathan Kew
8ebb1db8e5 Bug 1131451 part 2 - Respect the container height when converting vertical-RTL inline-direction coordinates. r=dholbert
* * *
Bug 1131451 part 2a - Remove hack for rtl-in-vertical-mode from ReflowAbsoluteFrame. r=dholbert
* * *
Bug 1131451 part 2b - Mark relative-overconstrained tests that now pass in vertical mode with rtl. r=dholbert
* * *
Bug 1131451 part 2c - Mark vertical border-collapse bevel tests that now pass. r=dholbert
* * *
Bug 1131451 part 2d - Remove partial rtl-in-vertical support from nsBidiPresUtils now that logical-coordinate classes handle it better. r=dholbert
* * *
Bug 1131451 part 2e - Remove hack for float positioning in vertical mode with dir=rtl. r=dholbert
* * *
Bug 1131451 part 2f - Mark vertical-mode float-in-rtl reftests that are now passing. r=dholbert
* * *
Bug 1131451 part 2g - Compute both dimensions of containerSize in nsFlexContainerFrame::DoLayout. r=dholbert
* * *
Bug 1131451 part 2h - Mark flexbox writing-mode tests that are now passing. r=dholbert
2015-07-16 10:08:05 +01:00
Jonathan Kew
4e6c40d7ea Bug 1131451 part 1 - Replace containerWidth with containerSize in logical-coordinate classes and APIs, frame classes, etc. r=dholbert 2015-07-16 10:07:57 +01:00
Jonathan Kew
a3380043e5 Bug 1174507 - Replace the frame flag CONTAINS_RELATIVE_HEIGHT with CONTAINS_RELATIVE_BSIZE, and adjust callsites appropriately. r=dholbert 2015-06-18 07:33:50 +01:00
Daniel Holbert
84c7d709a6 Bug 1173646 part 4: Convert isize/bsize into flex container's writing-mode in flexbox macros that aim to pick a main-axis or cross-axis value. r=mats 2015-06-12 14:28:24 -07:00
Daniel Holbert
ec88b067da Bug 1173646 part 3: Make FlexItems cache their WritingMode, for quick access. r=mats 2015-06-12 14:28:24 -07:00
Simon Montagu
7f1b0db94c Bug 1147834: Use abstract coordinates in nsHTMLReflowState, r=jfkthame 2015-06-04 03:43:02 -07:00
Eric Rahm
75c4bebb79 Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-03 15:25:57 -07:00
Carsten "Tomcat" Book
5471309381 Backed out 14 changesets (bug 1165515) for linux x64 e10s m2 test failures
Backed out changeset d68dcf2ef372 (bug 1165515)
Backed out changeset 7c3b45a47811 (bug 1165515)
Backed out changeset b668b617bef2 (bug 1165515)
Backed out changeset d0916e1283a2 (bug 1165515)
Backed out changeset ac4dc7489942 (bug 1165515)
Backed out changeset e9632ce8bc65 (bug 1165515)
Backed out changeset c16d215cc7e4 (bug 1165515)
Backed out changeset e4d474f3c51a (bug 1165515)
Backed out changeset d87680bf9f7c (bug 1165515)
Backed out changeset b3c0a45ba99e (bug 1165515)
Backed out changeset 9370fa197674 (bug 1165515)
Backed out changeset 50970d668ca1 (bug 1165515)
Backed out changeset ffa4eb6d24b9 (bug 1165515)
Backed out changeset 5fcf1203cc1d (bug 1165515)

--HG--
extra : rebase_source : 6fb850d063cbabe738f97f0380302153e3eae97a
2015-06-02 13:05:56 +02:00
Eric Rahm
a9afd68cef Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-01 22:17:33 -07:00
Wes Kocher
4e9f80ed2e Backed out 14 changesets (bug 1165515) for b2g mochitest-6 permafail CLOSED TREE
Backed out changeset 9b97e2aa2ed9 (bug 1165515)
Backed out changeset 150606c022a2 (bug 1165515)
Backed out changeset 4e875a488349 (bug 1165515)
Backed out changeset 467e7feeb546 (bug 1165515)
Backed out changeset d6b6cc373197 (bug 1165515)
Backed out changeset 0615265b593c (bug 1165515)
Backed out changeset fafd1dce9f08 (bug 1165515)
Backed out changeset d1df869245f9 (bug 1165515)
Backed out changeset 6876a7c63611 (bug 1165515)
Backed out changeset b7841c94a9a3 (bug 1165515)
Backed out changeset e5e3617f7c73 (bug 1165515)
Backed out changeset 39be3db95978 (bug 1165515)
Backed out changeset 0ec74176f8de (bug 1165515)
Backed out changeset 5b928dd10d71 (bug 1165515)
2015-06-01 17:57:58 -07:00
Eric Rahm
f82c0e7caf Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-01 14:31:01 -07:00
Daniel Holbert
769c903ec3 Bug 1165667: Use reflow state's reference rendering context during flex layout, instead of creating a temporary one. r=mats 2015-05-21 18:35:16 -07:00
Eric Rahm
3925a960aa Bug 1165515 - Part 1: Convert PR_LOG to MOZ_LOG. r=froydnj 2015-05-21 13:22:04 -07:00
Eric Rahm
4879ae86f4 Bug 1165518 - Part 2: Replace prlog.h with Logging.h. rs=froydnj 2015-05-19 11:15:34 -07:00
Daniel Holbert
beb52571e8 Bug 1158290 part 6: Use new GET_[MAIN|CROSS]_COMPONENT_LOGICAL macros, to reduce explicit width/height usage. r=mats 2015-05-15 11:57:08 -07:00
Daniel Holbert
f3e246f4b3 Bug 1158290 part 5: Use logical coords & axes in methods that compute flex container's own main size & cross size. r=mats 2015-05-15 11:57:06 -07:00
Daniel Holbert
12bc60a2d9 Bug 1158290 part 4: Clarify documentation & naming of ClampFlexContainerMainSize (now called ResolveFlexContainerMainSize). r=mats 2015-05-15 11:57:05 -07:00
Daniel Holbert
cf76677b63 Bug 1158290 part 3: Convert GenerateFlexLines to use logical axes & sizes. r=mats 2015-05-12 13:34:25 -07:00
Daniel Holbert
44b034651d Bug 1158290 part 2: Use logical (not physical) skipsides & borderpadding when chipping away from available BSize. r=mats 2015-05-12 13:34:23 -07:00
Daniel Holbert
f82cdd0c52 Bug 1158290 part 1: Use AvailableBSize instead of AvailableHeight, throughout flex layout. r=mats
This patch was auto-generated, with the following command:
  sed -i "s/vailableHeight/vailableBSize/g" nsFlexContainerFrame.*
2015-05-12 13:34:22 -07:00
Eric Rahm
e1ce2b6323 Bug 1162673 - Part 1: Remove instances of #ifdef PR_LOGGING in layout. r=froydnj
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
2015-05-11 13:53:18 -07:00
Daniel Holbert
51fe298034 Bug 1155312: Convert flex container nsHTMLReflowMetrics/aDesiredSize-populating code to use logical coords. r=mats 2015-04-17 10:41:23 -07:00
Daniel Holbert
e3066d1874 Bug 1152913 part 3: Make flexbox's PositionTracker classes track whether axis is reversed, & directly convert flex item final sizes/positions to logical coords. r=mats 2015-04-16 12:01:14 -07:00
Daniel Holbert
a55ee7cc16 Bug 1152913 part 2: Convert flexbox 'IsAxisHorizontal' checks to use new logical-axis member data. r=mats 2015-04-10 13:35:42 -07:00
Daniel Holbert
4d8faad43f Bug 1152913 part 1: Make FlexboxAxisTracker store the WritingMode & representation of how flex axes map to it. r=mats 2015-04-10 13:35:15 -07:00
Daniel Holbert
938764f65f Bug 1152951: Delete the copy-constructor and reassignment operator for FlexboxAxisTracker & PositionTracker state-management classes. r=mats 2015-04-10 09:27:54 -07:00
Daniel Holbert
64b999f2ed Bug 1149854: Use range-based "for" loops when iterating over child frames in nsFlexContainerFrame.cpp. r=xidorn 2015-03-31 21:50:46 -07:00
Mats Palmgren
25fa3a4765 Bug 1148971 - Make nsITheme::GetMinimumWidgetSize return a LayoutDeviceIntSize result instead of the unit-less nsIntSize type. r=roc 2015-03-30 11:36:14 -04:00
Carsten "Tomcat" Book
5c532881b3 Backed out changeset 513192eb7df4 (bug 1148971) for causing bc2 memory leaks 2015-03-30 15:04:09 +02:00
Mats Palmgren
2121f47090 Bug 1148971 - Make nsITheme::GetMinimumWidgetSize return a LayoutDeviceIntSize result instead of the unit-less nsIntSize type. r=roc 2015-03-30 10:37:33 +00:00
Mats Palmgren
ed9ed2d61a Bug 1148833 part 3 - Remove nsIFrame::WillReflow and add a non-virtual MarkInReflow method instead that sets NS_FRAME_IN_REFLOW. Call it at the start of Reflow(). r=roc 2015-03-29 22:38:40 +00:00
Daniel Holbert
5dcbd48aa9 Bug 1148294 part 1: Determine flex axes (in FlexboxAxisTracker) using the flex container's writing mode. r=mats 2015-03-27 12:06:03 -07:00
Daniel Holbert
98f5c76fe5 Bug 1148298 part 4: Convert flexbox helper-function IsAxisHorizontal() to be a private implementation detail of FlexboxAxisTracker. r=mats 2015-03-27 12:06:03 -07:00
Daniel Holbert
29c7cd0fa0 Bug 1148298 part 3: Make flexbox helper GetBaselineOffsetFromOuterCrossEdge take a FlexboxAxisTracker instead of an explicit axis. r=mats 2015-03-27 12:06:03 -07:00
Daniel Holbert
ce1fb7a7d6 Bug 1148298 part 2: Replace flexbox static helper-function GetSizePropertyForAxis() with a FlexboxAxisTracker method. r=mats 2015-03-27 12:06:03 -07:00
Daniel Holbert
caf96df332 Bug 1148298 part 1: Convert most flexbox-layout IsAxisHorizontal() calls into IsMainAxisHorizontal()/IsCrossAxisHorizontal(). r=mats 2015-03-27 12:06:03 -07:00
Daniel Holbert
3025ef62e7 Bug 1148078: Replace the word "Logical" with "Flex-Relative" in some vars & functions in flexbox layout. r=mats 2015-03-26 14:37:48 -07:00
Daniel Holbert
acb8e18785 Bug 1128354: Don't optimize away a flex item's second reflow, if it has percent-height children. r=mats 2015-03-19 23:00:05 -07:00
Daniel Holbert
d2fb7e676f Bug 1142686: check flex item's content-box size (not border-box size) when deciding whether to skip final reflow. r=mats 2015-03-13 23:08:21 -07:00
Daniel Holbert
326494d266 Backed out changeset 6cd4d71818ee (bug 1142686) because it wasn't quite the final patch version 2015-03-13 23:07:57 -07:00
Daniel Holbert
877422a643 Bug 1142686: check flex item's content-box size (not border-box size) when deciding whether to skip final reflow. r=mats
--HG--
rename : layout/style/test/test_dynamic_change_causing_reflow.html => layout/style/test/test_flexbox_reflow_counts.html
2015-03-13 23:00:37 -07:00
Jonathan Kew
d92097e485 Bug 1121748 - patch 2 - Use the flex-item frame's final size when computing its logical position within the flex container. r=smontagu 2015-02-02 14:17:00 -08:00
Jonathan Kew
f665472a1c Bug 1127679 - Fix use of incorrect writing mode in flex-item relative positioning. r=smontagu 2015-02-02 18:29:52 +00:00
Daniel Holbert
f3f221e566 Bug 1054010: Skip final reflow for flex items that receive an earlier 'measuring reflow' with the right size. r=mats 2015-01-23 14:15:11 -08:00
Daniel Holbert
38ef50f263 Bug 1054054 part 4: Remove stale XXXdholbert comment from ReflowFlexItem. (no review, comment-only) 2015-01-23 10:26:16 -08:00
Daniel Holbert
14edea4218 Bug 1054054 part 3: De-indent ReflowFlexItem function-body (no review, whitespace-only). 2015-01-23 10:26:00 -08:00
Daniel Holbert
93662abfdf Bug 1054054 part 2: Add "a" prefix to args which were formerly local variables, in ReflowFlexItem. r=mats 2015-01-23 10:25:59 -08:00
Daniel Holbert
36b02b61f3 Bug 1054054 part 1: Split out code for doing final reflow of each flex item into its own helper-function, "ReflowFlexItem". r=mats 2015-01-23 10:25:58 -08:00
Daniel Holbert
b6b424d410 Bug 1054058 part 3: Use local var to cache flex item's "normal" block offset in container, rather than looking it up. r=mats 2015-01-22 15:12:11 -08:00
Daniel Holbert
d9ae35f978 Bug 1054058 part 2: Resolve flex item ascent (baseline) values lazily. r=mats 2015-01-22 15:12:11 -08:00