Gerald Squelart
60a48742e4
Bug 1211741 - Remove libstagefright ID3 files. r=k17e
2015-10-06 14:24:00 +02:00
Jan Henning
7db0ee08cb
Bug 1202286 - Part 0 - Add some explicit namespace references to keep the compiler and IntelliSense happy. r=esawin
...
DecoderTraits.cpp pulls in MP3Demuxer.h which in turn pulls in mp4_demuxer/ByteReader.h. In that context, for some reason the ByteReader can't find the definition for MediaByteBuffer unless it is prefixed with the proper namespace.
MP3Demuxer.cpp itself compiles fine, but for some reason in Visual Studio IntelliSense complains about TimeUnit and TimeIntervals being undefined unless the using statement uses the full namespace hierarchy.
Also fix a small typo.
--HG--
extra : rebase_source : fc46fc82bf06b61c9ac31c2f4331f84f8557c51e
2015-10-01 11:29:48 +02:00
Gerald Squelart
8d3b440600
Bug 1156505 - p2: Null-check sampleTable before use. r=rillian
2015-10-02 16:13:00 +02:00
Gerald Squelart
3912254dc2
Bug 1156505 - p1: Added test case file from bug. r=rillian
2015-10-05 04:01:00 +02:00
Nigel Babu
81457d9f19
Backed out changeset b05d8992f36c (bug 1156505) for build bustage on a CLOSED TREE
...
--HG--
extra : amend_source : 713237598ed473d81ac91f800a7e8601bc1f777d
2015-10-05 12:40:46 +05:30
Nigel Babu
20b4fdf19f
Backed out changeset dd628d2021d5 (bug 1156505)
2015-10-05 12:40:44 +05:30
Gerald Squelart
ffc47660b8
Bug 1156505 - p2: Null-check sampleTable before use - r=rillian
...
--HG--
extra : rebase_source : 9bacf9a568f1020ba19957cba06f3792b4e7c325
2015-10-02 16:13:00 +02:00
Gerald Squelart
9e0bca97d2
Bug 1156505 - p1: Added test case file from bug - r=rillian
...
--HG--
extra : rebase_source : 3ed46238e2e70b355aa9bb3a7628f2168cfb5203
2015-10-01 00:59:00 +02:00
Gerald Squelart
1fe6483699
Bug 1204580
- p2: Check box ranges. r=rillian
2015-10-02 09:20:39 +02:00
Gerald Squelart
9a4c54dec5
Bug 1204580
- p1: Added test case files. r=rillian
2015-10-02 09:20:13 +02:00
Gerald Squelart
3c9a325b39
Bug 1207909
- p2: Fixed a warning (uninitialized 'err') and typo - r=jya
2015-09-30 07:37:00 +02:00
Gerald Squelart
1866c4d412
Bug 1207909
- p1: Fixed ALOGV statement - r=jya
2015-09-30 07:36:00 +02:00
Gerald Squelart
29585ecb47
Bug 1200326 - p4 - Added test case from bug 1200326, with more checks - r=rillian
2015-09-26 04:44:00 +02:00
Gerald Squelart
842c4906d8
Bug 1200326 - p3 - Test case filenames are now in a list, to allow adding more tests - r=rillian
2015-09-26 04:43:00 +02:00
Gerald Squelart
3d366a1473
Bug 1200326 - part 2 - Parse subsets of the input stream - r=rillian
...
In addition to starting parsing at different points across the input stream,
different sizes are given, from the minimum step size up to the remainder of the stream.
--HG--
extra : amend_source : 1d98d71cba9bf87f4501b3a554a3c7fa0adc81bc
2015-09-26 04:42:00 +02:00
Gerald Squelart
8e4e911bcf
Bug 1200326 - P 1 - Moved test case contents from test source into separate file - r=rillian
...
This will make it easier to modify input files and add more of them.
2015-09-26 04:40:00 +02:00
Jean-Yves Avenard
28995f8c35
Bug 1207441
: [mp4] Ignore invalid tracks. r=gerald
...
This is designed to minimize the chance of regressions.
2015-09-28 14:12:47 +10:00
Jean-Yves Avenard
b048d19b03
Bug 1206211: P2. Abort on OOM. r=kentuckyfriedtakahe
2015-09-24 16:42:54 +10:00
Jean-Yves Avenard
5414266df5
Bug 1206211: P1. Ensure operation can't overflow. r=kentuckyfriedtakahe
2015-09-24 16:42:54 +10:00
Jean-Yves Avenard
4b6099e165
Bug 1207478: P2. Prevent potential division by zero. r=gerald
2015-09-24 16:42:52 +10:00
Jean-Yves Avenard
7d65b942c5
Bug 1207478: P1. Prevent microseconds calculation overflow. r=gerald
...
This leaves us safe until year 294441 (assuming unix timestamp).
2015-09-24 16:42:51 +10:00
Chris Peterson
71920a9550
Bug 1207030 - Enable -Wshadow flag in more directories that have no -Wshadow warnings. r=glandium
2015-09-22 21:39:03 -07:00
Jean-Yves Avenard
c5be92978d
Bug 1207021: [mp4] Properly set dts on plain mp4 media. r=edwin
2015-09-23 12:59:26 +10:00
Jean-Yves Avenard
d9647c7d7e
Bug 1138992: P2. Add gtest. r=kentuckyfriedtakahe
2015-09-23 12:59:24 +10:00
Jean-Yves Avenard
9626f348b2
Bug 1138992: P1. Ignore ctts version if we have 0 samples in the table. r=kentuckyfriedtakahe
2015-09-23 12:59:24 +10:00
Wes Kocher
9379203266
Backed out changeset 51994c27948c (bug 1197280) for test_eme_non_mse_fails.html failures CLOSED TREE
2015-09-16 14:39:03 -07:00
Ralph Giles
02eebef322
Bug 1197280 - Use CheckedInt instead of manual comparison. r=baku,gerald
...
This is less error-prone and somewhat easier to read.
Based on a patch from Joshua J. Drake and suggestions
from Andrea Marchesini.
NB CheckedInt<T>::value() returns a T, so the comparison with
SIZE_MAX should always succeed. Doesn't warn on clang though.
2015-09-16 11:44:31 -07:00
Jean-Yves Avenard
a927b107f0
Bug 1205179: [mp4] Don't reject 7 bytes long avcC atom. r=gerald
...
An AVC3 stream will typically use 7 bytes avcC (due to have 0 SPS/PPS)
2015-09-16 18:14:18 +10:00
Jean-Yves Avenard
69d5bfe389
Bug 1189992: Don't assume the last chunk always contains the sample we're looking for. r=gerald
...
If a chunk contains no samples it should be skipped and continue the search (and maybe hit EOS)
2015-09-16 12:37:47 +10:00
Jean-Yves Avenard
3ab91d9f87
Bug 1197086: Change error into verbose only. r=rillian
...
the kKeyMaxInputSize is no longer used to determine the size of the allocated memory buffer as it's now dynamic.
2015-09-15 11:27:37 +10:00
Jean-Yves Avenard
123ded9cd5
Bug 1202012: P2. Make stagefright works on big-endian systems. r=rillian
2015-09-15 11:27:37 +10:00
Jean-Yves Avenard
c6d2e5e3fa
Bug 1202012: Use QTv2 header when available. r=rillian
2015-09-15 11:27:36 +10:00
Jean-Yves Avenard
c90766327d
Bug 1186716
: Error if SPS NAL parsing failed. r=rillian
...
--HG--
extra : rebase_source : f06f2da854db0df3e0472ead49deaeab051501b4
2015-09-14 15:34:33 -07:00
Ralph Giles
7a066ceb75
Bug 1203736 - Convert H264::DecodeSPS assert to error return. r=jya
...
This lets us verify checking in a gtest.
--HG--
extra : rebase_source : 01906b3541c7153e3e207f62cc31b94f75281ec4
2015-09-10 14:48:17 -07:00
Jean-Yves Avenard
a0d1bf988d
Bug 1185115: P2. replace all stagefright::Vector with nsTArray. r=kentuckyfriedtakahe
2015-09-12 19:57:15 +10:00
Jean-Yves Avenard
ccb0cb109c
Revert "Bug 1185115: P2. replace all stagefright::Vector with nsTArray. r=kentuckyfriedtakahe"
...
This reverts commit 757c4bd76326
2015-09-12 16:57:43 +10:00
Jean-Yves Avenard
2842b5f002
Bug 1185115: P2. replace all stagefright::Vector with nsTArray. r=kentuckyfriedtakahe
2015-09-12 16:47:30 +10:00
Johannes Pfrang
025fee3612
Bug 1202266 - Suppress '-Wformat-security' in libstagefright CXXFLAGS. r=kentuckyfriedtakahe
...
--HG--
extra : rebase_source : a93c2b3648b6dd14bf0a679fa241e8780c693780
2015-09-10 09:49:00 +02:00
Ralph Giles
a54711a5f4
Bug 1202677 - Reject mp4 streams with short avc chunks. r=gerald
2015-09-08 14:03:44 -07:00
Ralph Giles
bd0011b79c
Bug 1187076 - Warn at end of SPS buffers. r=jya
...
Previously we asserted if we tried to read past the end
of a buffer in parsing H.264 SPS headers. This only affected
debug builds, but the failures were reported as crashes in
automated testing.
Therefore, commute the assert to a warning and silently accept
bad data of this type. The read is safe with the first assert
removed because of the subsequent check, and a similar one in
the parent class.
2015-09-08 21:46:22 -07:00
Nicholas Nethercote
24cd9d5226
Bug 1203005 - Remove all traces of -Wdeclaration-after-statement. r=glandium.
...
Even though we compile C code as C99, we used to need
-Wdeclaration-after-statement because MSVC didn't allow declarations after
statements.
However, Visual Studio 2013 added support, so we can now merrily mix
declarations and statements everywhere. Hooray.
--HG--
extra : rebase_source : 00a89fed733008785429827408a0c6c466971080
2015-09-09 04:57:44 -07:00
Gerald Squelart
14790add1a
Bug 1187067 - Added gtests using the bug's test file, running simple checks and many parsing runs to catch parser crashes. r=rillian
2015-09-04 07:07:00 +02:00
Gerald Squelart
6666b45098
Bug 1187067 - Null-check mLastTrack before dereferencing it - r=rillian
2015-09-03 00:58:00 +02:00
Gerald Squelart
f40848d246
Bug 1201404 - Implement minimal gtests to exercise the MPEG4 parser - r=rillian
2015-09-03 00:05:00 +02:00
Ralph Giles
03b4683f2c
Bug 1186715 - Add diagnostic asserts. r=k17e
2015-08-19 10:33:13 -07:00
Nicholas Nethercote
f44287005f
Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
...
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
Chris Peterson
6b261a1c9e
Bug 1197563
- Polyfill __func__ for MSVC 2013 and earlier. r=froydnj
2015-08-20 23:39:18 -07:00
Anthony Jones
bf71b3c4f9
Bug 1180101 - Skip four bytes when we hit a zero length box; r=jya
2015-08-26 18:12:59 +12:00
Jean-Yves Avenard
1a98b5d4e0
Bug 1196398: [mp4] Do not allocate memory spanning across ftyp and moov atom. r=kentuckyfriedtakahe
...
A typical non-fragmented mp4 would have the ftyp atom located at the beginning of the mp4 and the moov at the end. We would to calculate the location of the metadata by spanning the byte range of the two atoms.
As such, we would typically allocate an amount of memory equivalent to the size of the mp4.
Instead we now reconstruct the metadata to only have the ftyp and moov atoms contiguously.
2015-08-21 15:35:31 +10:00
Jean-Yves Avenard
af3e91f01a
Revert "Bug 1196398: [mp4] Do not allocate memory spanning across ftyp and moov atom. r=kentuckyfriedtakahe"
...
This reverts commit 73156610be5f
2015-08-21 14:48:23 +10:00