Commit Graph

882 Commits

Author SHA1 Message Date
Ehsan Akhgari
ab20502fb9 Bug 1547813 - Part 7: Introduce a storage partitioning API; r=baku
This API abstracts away the details of the decision on what context should be
partitioned away from the consumers and centralizes the decision making into
the same location in the code base.

Differential Revision: https://phabricator.services.mozilla.com/D29742

--HG--
extra : moz-landing-system : lando
2019-05-25 01:25:41 +00:00
Ehsan Akhgari
e2a2c24b6e Bug 1547813 - Part 1: Introduce nsICookieService::BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN; r=baku
This new code designates our new cookie policy for blocking cookies and
storage access from third-party trackers and partitioning the cookie jar
of the rest of third-party resources.

Differential Revision: https://phabricator.services.mozilla.com/D29736

--HG--
extra : moz-landing-system : lando
2019-05-25 01:25:23 +00:00
Andrea Marchesini
c926d65d2f Bug 1553867 - Reduce the number of ClonePrincipalForPermission() call in CookieSettings, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32364

--HG--
extra : moz-landing-system : lando
2019-05-24 19:05:35 +00:00
Andrea Marchesini
52816e049d Bug 1554137 - nsICookie and nsICookie2 should be builtinclass interfaces, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32461

--HG--
extra : moz-landing-system : lando
2019-05-24 17:01:21 +00:00
Sylvestre Ledru
993c03acb1 Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31769

--HG--
extra : moz-landing-system : lando
2019-05-22 22:37:14 +00:00
Andrea Marchesini
7b8a38ee05 Bug 1551729 - Revert bug 1548432 - Re-introducing the support for cookies without values, r=mayhemer
This patch reverts the second part of bug 1548432.

Differential Revision: https://phabricator.services.mozilla.com/D31267

--HG--
extra : moz-landing-system : lando
2019-05-22 06:31:22 +00:00
Mihai Alexandru Michis
68421ffba4 Backed out changeset 754426d70d28 (bug 1551729) for causing wpt failures. CLOSED TREE 2019-05-21 15:17:37 +03:00
Andrea Marchesini
32c1b6bb89 Bug 1551729 - Revert bug 1548432 - Re-introducing the support for cookies without values, r=mayhemer
This patch reverts the second part of bug 1548432.

Differential Revision: https://phabricator.services.mozilla.com/D31267

--HG--
extra : moz-landing-system : lando
2019-05-21 08:57:21 +00:00
Dorel Luca
06b2e4e9d2 Backed out changeset 41c511d9528c (bug 1551729) for causing WPT failures in cookies/http-state/mozilla-tests.html. CLOSED TREE 2019-05-20 23:40:10 +03:00
Andrea Marchesini
b2c76acaf1 Bug 1551729 - Revert bug 1548432 - Re-introducing the support for cookies without values, r=mayhemer
This patch reverts the second part of bug 1548432.

Differential Revision: https://phabricator.services.mozilla.com/D31267

--HG--
extra : moz-landing-system : lando
2019-05-20 15:16:06 +00:00
Andrea Marchesini
4e58d1f5a3 Bug 1551826 - Use StaticPrefs for network.cookie.staleThreshold in nsCookie, r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D31218

--HG--
extra : moz-landing-system : lando
2019-05-15 13:33:47 +00:00
Andrea Marchesini
289365e128 Bug 1551821 - Get rid of pref network.cookie.same-site.enabled, r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D31217

--HG--
extra : moz-landing-system : lando
2019-05-15 13:33:45 +00:00
Andrew McCreight
2841945140 Bug 1550860 - Mark implicit builtinclass interfaces explicitly. r=nika
If an XPIDL interface has a method or attribute that is [notxpcom],
then it is implicitly treated as [builtinclass], even if it is not
marked as such. For clarity, this patch goes through and marks every
place that relies on this behavior (aside from some test code).

Differential Revision: https://phabricator.services.mozilla.com/D30714

--HG--
extra : moz-landing-system : lando
2019-05-13 19:51:49 +00:00
Noemi Erli
6430d23336 Backed out 12 changesets (bug 1547813) for failures in browser_partitionedIndexedDB.js CLOSED TREE
Backed out changeset 98989127264b (bug 1547813)
Backed out changeset f9d790139a26 (bug 1547813)
Backed out changeset a29f58cef022 (bug 1547813)
Backed out changeset c1288949de1c (bug 1547813)
Backed out changeset 8cad4fd197b1 (bug 1547813)
Backed out changeset 807ce59e7e6e (bug 1547813)
Backed out changeset 06943593738c (bug 1547813)
Backed out changeset 4ced8d49ddc3 (bug 1547813)
Backed out changeset 77a040f527e9 (bug 1547813)
Backed out changeset b4651cfaff30 (bug 1547813)
Backed out changeset 279c140a4d71 (bug 1547813)
Backed out changeset 0e0241f3d366 (bug 1547813)
2019-05-09 20:04:16 +03:00
Ehsan Akhgari
b9c7626390 Bug 1547813 - Part 9: Ensure the cookie service does third-party checks when the cookie policy is set to nsICookieService::BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30118

--HG--
extra : moz-landing-system : lando
2019-05-08 19:38:08 +00:00
Ehsan Akhgari
c7cb5521d1 Bug 1547813 - Part 8: Introduce a CookieSettings API to query whether cookies from third-party trackers must be rejected and use it in Gecko; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30117

--HG--
extra : moz-landing-system : lando
2019-05-08 20:22:18 +00:00
Ehsan Akhgari
f33f21e80b Bug 1547813 - Part 7: Introduce a storage partitioning API; r=baku
This API abstracts away the details of the decision on what context should be
partitioned away from the consumers and centralizes the decision making into
the same location in the code base.

Differential Revision: https://phabricator.services.mozilla.com/D29742

--HG--
extra : moz-landing-system : lando
2019-05-08 20:15:13 +00:00
Ehsan Akhgari
564ae33dab Bug 1547813 - Part 1: Introduce nsICookieService::BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN; r=baku
This new code designates our new cookie policy for blocking cookies and
storage access from third-party trackers and partitioning the cookie jar
of the rest of third-party resources.

Differential Revision: https://phabricator.services.mozilla.com/D29736

--HG--
extra : moz-landing-system : lando
2019-05-08 19:37:40 +00:00
Andrea Marchesini
42390cde39 Bug 1546598 - Remove domain cookies in nsICookieService.removeCookiesFromRootDomain(), r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D30384

--HG--
extra : moz-landing-system : lando
2019-05-08 22:37:02 +00:00
Ehsan Akhgari
3d7881e880 Bug 1549011 - Ignore cookie name-value-pair strings with an empty name; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D29929

--HG--
extra : moz-landing-system : lando
2019-05-08 08:51:42 +00:00
Andrea Marchesini
f8565bf748 Bug 1320404 - Remove appId from origin attributes - part 1 - OriginAttributes and nsIPrincipal, r=Ehsan,flod
Differential Revision: https://phabricator.services.mozilla.com/D29353

--HG--
extra : moz-landing-system : lando
2019-05-03 17:13:17 +00:00
Gurzau Raul
b4e790d05f Merge inbound to mozilla-central. a=merge 2019-05-03 07:16:59 +03:00
Gurzau Raul
0068b9927d Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-05-03 01:17:27 +03:00
Ehsan Akhgari
782c6b7440 Bug 1548432 - Part 2: Ignore cookie name-value-pair strings without a "=" character; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D29619

--HG--
extra : moz-landing-system : lando
2019-05-02 17:12:55 +00:00
Ehsan Akhgari
6fa7b44385 Bug 1543219 follow-up: Address review comment 2019-05-02 13:04:56 -04:00
Jorg K
0a06472d5d Bug 1543219 - Allow Mailnews to check protocol flags for cookie permissions. r=jorgk
This reinstates nsIProtocolHandler::URI_FORBIDS_COOKIE_ACCESS removed in bug 1517057, Part 1, rev 23a0332b18a1
2019-05-02 18:07:51 +02:00
Cosmin Sabou
a884fb99d8 Backed out 4 changesets (bug 1320404) for xperf failures on permissions.sqlite-journal.
Backed out changeset fbacf18b6532 (bug 1320404)
Backed out changeset fed7c475d75c (bug 1320404)
Backed out changeset 557b586f774a (bug 1320404)
Backed out changeset 5a20b5f43280 (bug 1320404)
2019-05-02 04:51:18 +03:00
Andrea Marchesini
7e61125d8f Bug 1320404 - Remove appId from origin attributes - part 1 - OriginAttributes and nsIPrincipal, r=Ehsan,flod
Differential Revision: https://phabricator.services.mozilla.com/D29353

--HG--
extra : moz-landing-system : lando
2019-05-01 23:21:45 +00:00
Sylvestre Ledru
e226046cb8 Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan
# ignore-this-changeset

Depends on D28954

Differential Revision: https://phabricator.services.mozilla.com/D28956

--HG--
extra : moz-landing-system : lando
2019-05-01 08:47:10 +00:00
Ehsan Akhgari
c541551107 Bug 1547397 - Part 3: Move the permission manager code to extensions/permissions; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D29116

--HG--
rename : extensions/cookie/nsPermission.cpp => extensions/permissions/nsPermission.cpp
rename : extensions/cookie/nsPermission.h => extensions/permissions/nsPermission.h
rename : extensions/cookie/nsPermissionManager.cpp => extensions/permissions/nsPermissionManager.cpp
rename : extensions/cookie/nsPermissionManager.h => extensions/permissions/nsPermissionManager.h
rename : extensions/cookie/test/.eslintrc.js => extensions/permissions/test/.eslintrc.js
rename : extensions/cookie/test/browser.ini => extensions/permissions/test/browser.ini
rename : extensions/cookie/test/browser_permmgr_sync.js => extensions/permissions/test/browser_permmgr_sync.js
rename : extensions/cookie/test/browser_permmgr_viewsrc.js => extensions/permissions/test/browser_permmgr_viewsrc.js
rename : extensions/cookie/test/gtest/PermissionManagerTest.cpp => extensions/permissions/test/gtest/PermissionManagerTest.cpp
rename : extensions/cookie/test/gtest/moz.build => extensions/permissions/test/gtest/moz.build
rename : extensions/cookie/test/moz.build => extensions/permissions/test/moz.build
rename : extensions/cookie/test/unit/test_permmanager_cleardata.js => extensions/permissions/test/unit/test_permmanager_cleardata.js
rename : extensions/cookie/test/unit/test_permmanager_default_pref.js => extensions/permissions/test/unit/test_permmanager_default_pref.js
rename : extensions/cookie/test/unit/test_permmanager_defaults.js => extensions/permissions/test/unit/test_permmanager_defaults.js
rename : extensions/cookie/test/unit/test_permmanager_expiration.js => extensions/permissions/test/unit/test_permmanager_expiration.js
rename : extensions/cookie/test/unit/test_permmanager_getAllForURI.js => extensions/permissions/test/unit/test_permmanager_getAllForURI.js
rename : extensions/cookie/test/unit/test_permmanager_getAllWithTypePrefix.js => extensions/permissions/test/unit/test_permmanager_getAllWithTypePrefix.js
rename : extensions/cookie/test/unit/test_permmanager_getPermissionObject.js => extensions/permissions/test/unit/test_permmanager_getPermissionObject.js
rename : extensions/cookie/test/unit/test_permmanager_idn.js => extensions/permissions/test/unit/test_permmanager_idn.js
rename : extensions/cookie/test/unit/test_permmanager_load_invalid_entries.js => extensions/permissions/test/unit/test_permmanager_load_invalid_entries.js
rename : extensions/cookie/test/unit/test_permmanager_local_files.js => extensions/permissions/test/unit/test_permmanager_local_files.js
rename : extensions/cookie/test/unit/test_permmanager_matches.js => extensions/permissions/test/unit/test_permmanager_matches.js
rename : extensions/cookie/test/unit/test_permmanager_matchesuri.js => extensions/permissions/test/unit/test_permmanager_matchesuri.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_4-7.js => extensions/permissions/test/unit/test_permmanager_migrate_4-7.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_4-7_no_history.js => extensions/permissions/test/unit/test_permmanager_migrate_4-7_no_history.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_5-7a.js => extensions/permissions/test/unit/test_permmanager_migrate_5-7a.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_5-7b.js => extensions/permissions/test/unit/test_permmanager_migrate_5-7b.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_6-7a.js => extensions/permissions/test/unit/test_permmanager_migrate_6-7a.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_6-7b.js => extensions/permissions/test/unit/test_permmanager_migrate_6-7b.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_7-8.js => extensions/permissions/test/unit/test_permmanager_migrate_7-8.js
rename : extensions/cookie/test/unit/test_permmanager_notifications.js => extensions/permissions/test/unit/test_permmanager_notifications.js
rename : extensions/cookie/test/unit/test_permmanager_removeall.js => extensions/permissions/test/unit/test_permmanager_removeall.js
rename : extensions/cookie/test/unit/test_permmanager_removebytype.js => extensions/permissions/test/unit/test_permmanager_removebytype.js
rename : extensions/cookie/test/unit/test_permmanager_removebytypesince.js => extensions/permissions/test/unit/test_permmanager_removebytypesince.js
rename : extensions/cookie/test/unit/test_permmanager_removeforapp.js => extensions/permissions/test/unit/test_permmanager_removeforapp.js
rename : extensions/cookie/test/unit/test_permmanager_removepermission.js => extensions/permissions/test/unit/test_permmanager_removepermission.js
rename : extensions/cookie/test/unit/test_permmanager_removesince.js => extensions/permissions/test/unit/test_permmanager_removesince.js
rename : extensions/cookie/test/unit/test_permmanager_subdomains.js => extensions/permissions/test/unit/test_permmanager_subdomains.js
rename : extensions/cookie/test/unit/xpcshell.ini => extensions/permissions/test/unit/xpcshell.ini
extra : moz-landing-system : lando
2019-04-30 14:06:53 +00:00
Ehsan Akhgari
bba7e3c8b0 Bug 1547114 - Part 8: Move nsCookiePermission to netwerk/cookie; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D29078

--HG--
rename : extensions/cookie/nsCookiePermission.cpp => netwerk/cookie/nsCookiePermission.cpp
rename : extensions/cookie/nsCookiePermission.h => netwerk/cookie/nsCookiePermission.h
extra : moz-landing-system : lando
2019-04-26 22:31:57 +00:00
Ehsan Akhgari
c8fea1ecad Bug 1547114 - Part 5: Remove nsICookiePermission::CanAccess(); r=baku
Differential Revision: https://phabricator.services.mozilla.com/D28996

--HG--
extra : moz-landing-system : lando
2019-04-26 15:41:07 +00:00
Ehsan Akhgari
565bc7aba8 Bug 1547114 - Part 1: Remove nsICookiePermission::CanAccessURI(); r=baku
Differential Revision: https://phabricator.services.mozilla.com/D28914

--HG--
extra : moz-landing-system : lando
2019-04-26 15:49:17 +00:00
Andreea Pavel
81b8902215 Backed out 4 changesets (bug 1547114) for multiple failures e.g. xpcshell at test_SitePermissions.js on a CLOSED TREE
Backed out changeset 4167117f548f (bug 1547114)
Backed out changeset 0a4180b074ea (bug 1547114)
Backed out changeset c92df939a4d6 (bug 1547114)
Backed out changeset fc4e5936eeae (bug 1547114)
2019-04-26 18:35:28 +03:00
Ehsan Akhgari
b3c08a7ca4 Bug 1547114 - Part 4: Mark nsICookiePermission as non-scriptable; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D28917

--HG--
extra : moz-landing-system : lando
2019-04-26 12:02:21 +00:00
Ehsan Akhgari
9421931e25 Bug 1547114 - Part 1: Remove nsICookiePermission::CanAccessURI(); r=baku
Differential Revision: https://phabricator.services.mozilla.com/D28914

--HG--
extra : moz-landing-system : lando
2019-04-26 12:02:20 +00:00
Andrew McCreight
f242e71c8a Bug 1545822 - Clean up some whitespace in XPIDL files. r=froydnj
The attributes for an interface should be on the line right before the
interface.

Interface attributes should be separated by spaces.

Clean up some trailing whitespace in widget/.

Differential Revision: https://phabricator.services.mozilla.com/D28234

--HG--
extra : moz-landing-system : lando
2019-04-21 01:47:00 +00:00
Johann Hofmann
f296ce765f Bug 1536454 - Part 2 - Add modificationTime attribute to nsIPermission.idl. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D26943

--HG--
extra : moz-landing-system : lando
2019-04-18 13:43:10 +00:00
Brian Grinstead
ede8c44ef2 Bug 1544322 - Part 2.1 - Remove the [type] attribute for one-liner <script> tags loading files in /tests/SimpleTest/ in everything except for dom/ r=bzbarsky
This excludes dom/, otherwise the file size is too large for phabricator to handle.

This is an autogenerated commit to handle scripts loading mochitest harness files, in
the simple case where the script src is on the same line as the tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 2` argument.

Differential Revision: https://phabricator.services.mozilla.com/D27456

--HG--
extra : moz-landing-system : lando
2019-04-16 03:50:44 +00:00
Andrea Marchesini
6f470dae23 Bug 1515913 - Implement nsICookieService.removeCookiesFromRootDomain, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D27289

--HG--
extra : moz-landing-system : lando
2019-04-12 20:27:21 +00:00
Andrea Marchesini
a2db742a8c Bug 1536411 - StoragePrincipal - part 6 - Cookies, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D24864

--HG--
extra : moz-landing-system : lando
2019-04-12 05:30:43 +00:00
Cosmin Sabou
af07021e88 Backed out 10 changesets (bug 1536411) for causing leaks in CondVar, MessagePortService, MessagePortServiceData.
Backed out changeset eda5854cd7e8 (bug 1536411)
Backed out changeset f94dfbf2476c (bug 1536411)
Backed out changeset c68dc3152faa (bug 1536411)
Backed out changeset f67d157e8baf (bug 1536411)
Backed out changeset 1107a9767f38 (bug 1536411)
Backed out changeset ccbe1af00fb9 (bug 1536411)
Backed out changeset 552c4b588524 (bug 1536411)
Backed out changeset 2eb20578159b (bug 1536411)
Backed out changeset 45708d22bb6d (bug 1536411)
Backed out changeset 87601ef1d4d4 (bug 1536411)
2019-04-11 22:48:49 +03:00
Andrea Marchesini
0830861f7e Bug 1536411 - StoragePrincipal - part 6 - Cookies, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D24864

--HG--
extra : moz-landing-system : lando
2019-04-11 16:28:51 +00:00
Andrea Marchesini
ddda66db66 Bug 1543314 - Cookies should be sent to the content process also for first-party channels when cookieBehavior is set to 2, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D26859

--HG--
extra : moz-landing-system : lando
2019-04-10 15:25:13 +00:00
Ehsan Akhgari
f08e2307eb Bug 1533394 - Re-enable browser_serviceWorker.js now that bug 1498102 has been fixed; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D26022

--HG--
extra : moz-landing-system : lando
2019-04-04 07:47:43 +00:00
Andrea Marchesini
ac66f432bc Bug 1534538 - Principal serialization should not serialize base domain if not needed, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D24710

--HG--
extra : moz-landing-system : lando
2019-03-29 19:20:52 +00:00
Mark Banner
dba6983e75 Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D23850

--HG--
extra : moz-landing-system : lando
2019-03-28 09:38:14 +00:00
Andrea Marchesini
6449f116c4 Bug 1534343 - Document should check if its mCookieSettings exists before using it, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D23764

--HG--
extra : moz-landing-system : lando
2019-03-21 06:44:00 +00:00
Coroiu Cristina
5f875389c3 Backed out changeset bdefd9c7fc99 (bug 1534343) for mochitest failures at netwerk/cookie/test/mochitest/test_xmlDocument.html on Android on a CLOSED TREE 2019-03-19 17:50:08 +02:00
Andrea Marchesini
7f2e25b635 Bug 1534340 - Fix a nullptr check in CookieServiceChild::RequireThirdPartyCheck, r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D23873

--HG--
extra : moz-landing-system : lando
2019-03-19 13:23:28 +00:00