Commit Graph

647 Commits

Author SHA1 Message Date
Kagami Sascha Rosylight
dacfc1c203 Bug 1931497 - Part 7: Remove parent process ping in PContent and PushService r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D218626
2024-11-19 15:32:19 +00:00
Kagami Sascha Rosylight
cea4a11e31 Bug 1931497 - Part 6: Adjust notification lifetime documentation comment r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D229173
2024-11-19 15:32:19 +00:00
Kagami Sascha Rosylight
1b30e11e06 Bug 1931497 - Part 5: Remove now-redundant Notification members r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D229172
2024-11-19 15:32:18 +00:00
Kagami Sascha Rosylight
979ce687f8 Bug 1931497 - Part 4: Remove WorkerNotificationObserver r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D210339
2024-11-19 15:32:18 +00:00
Kagami Sascha Rosylight
5d94422e96 Bug 1931497 - Part 2: Implement tab focusing for workers on RecvNotifyClick r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D218666
2024-11-19 15:32:18 +00:00
Kagami Sascha Rosylight
b8ad0a480f Bug 1931497 - Part 1: Close NotificationParent on RecvClose r=asuth
And also mark as dangling when unregistering, so that Close() won't cause double unregistration.

Differential Revision: https://phabricator.services.mozilla.com/D226935
2024-11-19 15:32:17 +00:00
Kagami Sascha Rosylight
7b8016ebab Bug 1930676 - Part 8: Remove MainThreadNotificationObserver r=asuth
1. `new Notification()` and `notification.close()` in the main thread starts using PNotification
2. GlobalTeardownObserver inheritance is removed for NotificationChild::ActorDestroy
3. GlobalFreezeObserver inheritance is removed for the same inheritance in the child actor
4. Grabbing Notification objects are now done by DETH::KeepAliveIfHasListenersFor instead of via observers
5. WorkerNotificationObserver now directly has all the members MainThreadNotificationObserver had. It'll be removed soon too as a followup.

Differential Revision: https://phabricator.services.mozilla.com/D228682
2024-11-15 00:35:43 +00:00
Kagami Sascha Rosylight
defce8455a Bug 1930676 - Part 7: Implement NotificationChild::FrozenCallback r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D228897
2024-11-15 00:35:43 +00:00
Kagami Sascha Rosylight
a856f8b1b6 Bug 1930676 - Part 6: Implement Child::ActorDestroy r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D228896
2024-11-15 00:35:42 +00:00
Kagami Sascha Rosylight
35c21f918f Bug 1930676 - Part 5: Implement RecvNotifyClick r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D228684
2024-11-15 00:35:42 +00:00
Kagami Sascha Rosylight
e646a1103c Bug 1930676 - Part 4: Implement RecvClose r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D228895
2024-11-15 00:35:42 +00:00
Kagami Sascha Rosylight
975f22542c Bug 1930676 - Part 3: Add skeleton PNotification functions r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D228681
2024-11-15 00:35:41 +00:00
Kagami Sascha Rosylight
d1c3c65afc Bug 1930676 - Part 2: Always unpersist on alertfinished r=asuth
An error should still trigger unpersist.

Differential Revision: https://phabricator.services.mozilla.com/D228894
2024-11-15 00:35:41 +00:00
Kagami Sascha Rosylight
9c7f51e8cd Bug 1930676 - Part 1: Remove redundant promise argument from CreateActor r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D228893
2024-11-15 00:35:40 +00:00
Kagami Sascha Rosylight
0a7824667a Bug 1930506 - Remove nsIAlertsService::ShowPersistentNotification r=nalexander,geckoview-reviewers,win-reviewers,gstoll,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D228659
2024-11-13 08:11:36 +00:00
Kagami Sascha Rosylight
abf63ced1d Bug 1928702 - Part 12: Add extra coverage for Glean metrics r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227853
2024-11-11 20:34:15 +00:00
Kagami Sascha Rosylight
e558ae71bd Bug 1928702 - Part 11: Migrate ShowPersistentNotification to use IPC r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227696
2024-11-11 20:34:15 +00:00
Kagami Sascha Rosylight
1d459f1839 Bug 1928702 - Part 10: Implement alertfinished behavior r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227695
2024-11-11 20:34:15 +00:00
Kagami Sascha Rosylight
34b3b0666d Bug 1928702 - Part 9: Implement alertclickcallback behavior r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227694
2024-11-11 20:34:14 +00:00
Kagami Sascha Rosylight
9579011f6d Bug 1928702 - Part 8: Implement permission check r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227693
2024-11-11 20:34:14 +00:00
Kagami Sascha Rosylight
43b9a319da Bug 1928702 - Part 7: Settle ShowResolver r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227692
2024-11-11 20:34:13 +00:00
Kagami Sascha Rosylight
1d5d28dfbc Bug 1928702 - Part 6: Move NotificationObserver functions to NotificationUtils r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227691
2024-11-11 20:34:13 +00:00
Kagami Sascha Rosylight
042f87e241 Bug 1928702 - Part 5: Implement RecvShow r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227690
2024-11-11 20:34:13 +00:00
Kagami Sascha Rosylight
0692c5d465 Bug 1928702 - Part 4: Implement ActorDestroy r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227689
2024-11-11 20:34:12 +00:00
Kagami Sascha Rosylight
32859ae3d3 Bug 1928702 - Part 3: Move more functions to NotificationUtils r=asuth
Moving functions that can be called from both Notification and IPC actors, that are needed for ActorDestroy.

Differential Revision: https://phabricator.services.mozilla.com/D227688
2024-11-11 20:34:12 +00:00
Kagami Sascha Rosylight
21033fe93d Bug 1928702 - Part 2: Create PNotification via PBackground r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227687
2024-11-11 20:34:11 +00:00
Kagami Sascha Rosylight
b9e417e526 Bug 1928702 - Part 1: Add skeleton PNotification r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227686
2024-11-11 20:34:11 +00:00
Norisz Fay
d0b3b4838f Backed out 12 changesets (bug 1928702) for causing gv-junit failures on OpenWindowTest#openWindowNullResult CLOSED TREE
Backed out changeset 1bb3c36a15c3 (bug 1928702)
Backed out changeset 984db15bc9e2 (bug 1928702)
Backed out changeset 622a66cdac2e (bug 1928702)
Backed out changeset 33642b1c547b (bug 1928702)
Backed out changeset 56ab49acff35 (bug 1928702)
Backed out changeset f318fe78ff14 (bug 1928702)
Backed out changeset 3daeacd08336 (bug 1928702)
Backed out changeset a497ddb030f6 (bug 1928702)
Backed out changeset 5a94b945a3ad (bug 1928702)
Backed out changeset 984f6e687ff5 (bug 1928702)
Backed out changeset bb63792c3333 (bug 1928702)
Backed out changeset 93937caf6d13 (bug 1928702)
2024-11-07 21:28:27 +02:00
Kagami Sascha Rosylight
ff90fc36ff Bug 1928702 - Part 12: Add extra coverage for Glean metrics r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227853
2024-11-07 17:32:08 +00:00
Kagami Sascha Rosylight
48bd5a924b Bug 1928702 - Part 11: Migrate ShowPersistentNotification to use IPC r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227696
2024-11-07 17:32:07 +00:00
Kagami Sascha Rosylight
3a177d33c8 Bug 1928702 - Part 10: Implement alertfinished behavior r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227695
2024-11-07 17:32:07 +00:00
Kagami Sascha Rosylight
67f5796023 Bug 1928702 - Part 9: Implement alertclickcallback behavior r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227694
2024-11-07 17:32:07 +00:00
Kagami Sascha Rosylight
40535d1aa0 Bug 1928702 - Part 8: Implement permission check r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227693
2024-11-07 17:32:06 +00:00
Kagami Sascha Rosylight
9c01efbcb5 Bug 1928702 - Part 7: Settle ShowResolver r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227692
2024-11-07 17:32:06 +00:00
Kagami Sascha Rosylight
bbe06a50b0 Bug 1928702 - Part 6: Move NotificationObserver functions to NotificationUtils r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227691
2024-11-07 17:32:05 +00:00
Kagami Sascha Rosylight
add20a2eaf Bug 1928702 - Part 5: Implement RecvShow r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227690
2024-11-07 17:32:05 +00:00
Kagami Sascha Rosylight
baa2566f17 Bug 1928702 - Part 4: Implement ActorDestroy r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227689
2024-11-07 17:32:05 +00:00
Kagami Sascha Rosylight
c2fa7e3ebb Bug 1928702 - Part 3: Move more functions to NotificationUtils r=asuth
Moving functions that can be called from both Notification and IPC actors, that are needed for ActorDestroy.

Differential Revision: https://phabricator.services.mozilla.com/D227688
2024-11-07 17:32:04 +00:00
Kagami Sascha Rosylight
8886918b0f Bug 1928702 - Part 2: Create PNotification via PBackground r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227687
2024-11-07 17:32:03 +00:00
Kagami Sascha Rosylight
299cf0f16d Bug 1928702 - Part 1: Add skeleton PNotification r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D227686
2024-11-07 17:32:03 +00:00
Iulian Moraru
3e09eabd4e Backed out 10 changesets (bug 1928672, bug 1922020) for causing mochitest-plain failures on test_different_domain_in_hierarchy.html. CLOSED TREE
Backed out changeset c7c93c34f516 (bug 1928672)
Backed out changeset 4e6a8bea3574 (bug 1922020)
Backed out changeset 11718a55e298 (bug 1922020)
Backed out changeset ff0655d8a6a9 (bug 1922020)
Backed out changeset cabd41ab53e4 (bug 1922020)
Backed out changeset 88eac74dbe86 (bug 1922020)
Backed out changeset ea5096fafb29 (bug 1922020)
Backed out changeset 852d8a2132c8 (bug 1922020)
Backed out changeset e66184701c85 (bug 1922020)
Backed out changeset f52eb9bf4d08 (bug 1922020)
2024-11-05 01:46:32 +02:00
Benjamin VanderSloot
3201bf6536 Bug 1922020, part 9 - Remove reliance on window.opener storage access heuristic in user.js from dom/notification - r=saschanaz
I simply gave up here because I don't know what the correct behavior we should test for in a partitioned worker is.

The heuristic was making the xorigin test work because the window open would force the iframe into a non-partitioned state

Differential Revision: https://phabricator.services.mozilla.com/D224814
2024-11-04 20:38:38 +00:00
Goloman Adrian
4373312425 Backed out 10 changesets (bug 1928672, bug 1922020) for causing bc failures @browser_permissionPropagation.js. CLOSED TREE
Backed out changeset 48e75896365c (bug 1928672)
Backed out changeset efa4047d526e (bug 1922020)
Backed out changeset 3df5f4781f39 (bug 1922020)
Backed out changeset 23e201efd3b8 (bug 1922020)
Backed out changeset 4c05fa56cf47 (bug 1922020)
Backed out changeset 43f97ae7eb6f (bug 1922020)
Backed out changeset 5e14c27894de (bug 1922020)
Backed out changeset cf506f71a542 (bug 1922020)
Backed out changeset e034708dee92 (bug 1922020)
Backed out changeset 787a649b70b8 (bug 1922020)
2024-11-04 18:11:34 +02:00
Benjamin VanderSloot
42d70eac94 Bug 1922020, part 9 - Remove reliance on window.opener storage access heuristic in user.js from dom/notification - r=saschanaz
I simply gave up here because I don't know what the correct behavior we should test for in a partitioned worker is.

The heuristic was making the xorigin test work because the window open would force the iframe into a non-partitioned state

Differential Revision: https://phabricator.services.mozilla.com/D224814
2024-11-04 13:04:40 +00:00
Sandor Molnar
4844cd6ff2 Backed out 4 changesets (bug 1922020) for causing mochitest plain failures. CLOSED TREE
Backed out changeset 758a808aa636 (bug 1922020)
Backed out changeset 09892a5bf0f2 (bug 1922020)
Backed out changeset 0ad002c61500 (bug 1922020)
Backed out changeset 4f130b2a64e4 (bug 1922020)
2024-10-31 22:20:58 +02:00
Benjamin VanderSloot
61d6fe2ce2 Bug 1922020, part 9 - Remove reliance on window.opener storage access heuristic in user.js from dom/notification - r=saschanaz
I simply gave up here because I don't know what the correct behavior we should test for in a partitioned worker is.

The heuristic was making the xorigin test work because the window open would force the iframe into a non-partitioned state

Differential Revision: https://phabricator.services.mozilla.com/D224814
2024-10-31 18:36:30 +00:00
Alexandru Marc
9615ca2956 Backed out 4 changesets (bug 1922020) for causing build bustages @ ActorsParent.cpp. CLOSED TREE
Backed out changeset 3926397fec17 (bug 1922020)
Backed out changeset 37af765882cb (bug 1922020)
Backed out changeset cd59a5e18609 (bug 1922020)
Backed out changeset 33e10ef1ba65 (bug 1922020)
2024-10-31 17:54:02 +02:00
Benjamin VanderSloot
85c8276c5a Bug 1922020, part 9 - Remove reliance on window.opener storage access heuristic in user.js from dom/notification - r=saschanaz
I simply gave up here because I don't know what the correct behavior we should test for in a partitioned worker is.

The heuristic was making the xorigin test work because the window open would force the iframe into a non-partitioned state

Differential Revision: https://phabricator.services.mozilla.com/D224814
2024-10-31 15:14:16 +00:00
Kagami Sascha Rosylight
183d09046b Bug 1914203 - Add telemetry for notification permission r=asuth,bvandersloot
Following the parent patch in bug 1914417, this will allow us to decide whether we can block ABA access or not. (Bonus, also whether we can remove requestPermission in non-secure context.)

Differential Revision: https://phabricator.services.mozilla.com/D219777
2024-09-20 14:02:28 +00:00
Kagami Sascha Rosylight
b710b85738 Bug 1914417 - Refactor notification permission checker using principal partition key r=asuth,bvandersloot
This patch keeps the current status where Firefox and Chrome both allows notification permission in ABA context although the spec does not cover it. (https://github.com/whatwg/notifications/issues/177, also listed in https://privacycg.github.io/storage-partitioning/#remaining-user-agent-state)

The child patch in bug 1914203 will add a telemetry to see whether the usage is low enough so that we can block ABA access, to make it more consistent with storage partitioning.

Differential Revision: https://phabricator.services.mozilla.com/D219908
2024-09-20 14:02:28 +00:00