Commit Graph

88 Commits

Author SHA1 Message Date
Steven MacLeod
aabed44243 Bug 1038174 - Prevent a race condition when writing the experiments cache. r=gfritzsche
We now mark the experiments cache as clean before writing the cache.
This means that any changes to the data between collecting it and when
the actual write executes will properly mark the cache as dirty.

--HG--
extra : rebase_source : 1c8b2dd2365ff2c27e7b545c5347ab178d6818d9
extra : histedit_source : a6b10099af6e8d4c67450e9f4afef403d5b74436
2014-07-24 17:21:03 -04:00
Qeole
295a3b1ef4 Bug 1040761 - Re-add state info for experiments async shutdown blocker from bug 1012924. r=gfritzsche 2014-07-25 13:40:17 +02:00
Alexandre Poirot
7ea4dd517f Bug 1027242 - Blacklist mulet's failing tests + expose 'mulet' to ini files; fix previous bustage on a CLOSED TREE, r=ahal 2014-07-02 15:40:56 -07:00
Qeole
4deb84bd12 Bug 1032970 - Stopping maxStartTime from incorrectly disabling experiments which have already started. r=gfritzsche 2014-07-18 16:53:20 +02:00
Georg Fritzsche
9f477b8fe2 Bug 1012466 - Test cleanups. r=bsmedberg 2014-07-09 15:17:36 +02:00
Georg Fritzsche
3ac251048e Bug 1012466 - Properly synchronize experiments shutdown with the AddonManager by using its shutdown barrier. r=bsmedberg 2014-07-08 17:36:24 +02:00
Gregory Szorc
04d5343419 Bug 1033836 - Rename services-common to services/common; rs=rnewman
The upcoming build system patches don't support hypthens in path names.
Changing this for that reason is kind of silly, but it's the easiest
way. Besides, nothing else uses hyphens in directory names.

--HG--
extra : rebase_source : 42dda2b1f16a3c0bfe17397a70092362e400530f
2014-07-02 16:49:36 -07:00
Benjamin Smedberg
5c436f72de Bug 1031326 - Fix experiment cache upgrade: the cache data is a raw JSObject, not a map. r=gfritzsche 2014-06-27 13:44:21 -04:00
Benjamin Smedberg
ad9fa6b673 Bug 1017806 followup: include the branch data in the public API and therefore in FHR 2014-06-25 18:11:55 -04:00
Benjamin Smedberg
8295abf927 Bug 1017806 - Record and report on optional branches of experiments, so that each experiment doesn't have to re-invent data collection. r=gfritzsche 2014-06-25 15:16:13 -04:00
Felipe Gomes
77c19b1008 Bug 1028612 - Options for jsfilter sandbox unused. r=gfritzsche 2014-06-22 21:25:15 -03:00
Georg Fritzsche
fb8786968f Bug 1021002 - Fix telemetry experiments jsfilter evaluation. r=bsmedberg 2014-06-13 14:50:10 +02:00
Carsten "Tomcat" Book
0f24f14f35 Merge mozilla-central to fx-team 2014-05-16 14:33:31 +02:00
Georg Fritzsche
6a300dfda4 Bug 1005270 - Trigger experiments initialization on opening the addon manager UI. r=bsmedberg 2014-05-16 12:56:25 +02:00
David Rajchenbach-Teller
fdb3455861 Bug 1010289 - Experiments.jsm should now handle its errors. r=bsmedberg 2014-05-15 03:12:00 +02:00
Benjamin Smedberg
fbb11389d3 Bug 1007710 - Add information about the currently-active experiment to the telemetry ping, r=gfritzsche+vladan
--HG--
extra : rebase_source : a6bde09d91162d9a77fa2d121442e2397e6c9526
2014-05-15 09:11:01 -04:00
Benjamin Smedberg
b5e445e96d Bug 1004665 - If the crash reporter is disabled, .annotateCrashReport will throw an exception. Catch it and continue, r=gfritzsche
--HG--
extra : rebase_source : 5a86f06dbca38f9f2d692aeb651789e452b96bc9
2014-05-05 10:31:26 -04:00
Georg Fritzsche
dc09780554 Bug 992258 - Trigger a refresh of the experiments view in the addon manager when experiments change. r=irving 2014-05-06 12:18:10 +02:00
Georg Fritzsche
58e667b67b Bug 1001787 - Set the endDate on historic experiments early enough. r=bsmedberg
We expect all historic experiments to have a valid endDate. Setting an experiment to disabled and then calling into reconcileAddonState can trigger calls into Experiments.getExperiments() via the AddonManager, so we need to set the endDate before that.
2014-04-29 18:21:06 +02:00
Georg Fritzsche
1157d26b10 Bug 1001787 - Propagate changes for foreign experiment addon uninstalls so we properly save the experiments state. r=bsmedberg 2014-04-29 18:20:56 +02:00
Georg Fritzsche
35ec4fcf52 Bug 1001787 - Add test for foreign experiment addon uninstalls keeping the state properly over restarts. r=bsmedberg 2014-04-29 18:20:45 +02:00
Georg Fritzsche
d8ddb7641c Bug 1000719 - Add tracing on logging experiment rejections and telemetry tests. r=bsmedberg 2014-04-28 16:11:26 +02:00
Georg Fritzsche
6f532852a9 Bug 986677 - Add time left and activity state to experiments in the Addon Manager UI. r=unfocused 2014-04-23 14:34:49 +02:00
Georg Fritzsche
d8177bc07c Bug 990111 - Add-on provider for historical experiments. r=irving 2014-04-23 14:34:48 +02:00
Benjamin Smedberg
853bdc2773 Bug 995027 logging - add traces to figure out whether uninit was called and where it got stuck, r=gfritzsche
--HG--
extra : rebase_source : 6c2e5dcce364bbce746a11b4e8841283656162c2
2014-04-17 10:52:23 -04:00
Georg Fritzsche
a5cb1d787d Bug 989137 - Part 18: Fix experiments uninit behavior. r=bsmedberg 2014-04-17 15:47:37 +02:00
Georg Fritzsche
45a81a1f65 Bug 989137 - Part 15: Return a promise from Experiments.init(). r=gfritzsche 2014-04-17 15:47:37 +02:00
Georg Fritzsche
473a9cbc89 Bug 989137 - Part 14: Rename functions for associating with Add-on Manager. r=gfritzsche 2014-04-17 15:47:37 +02:00
Georg Fritzsche
fc857b817b Bug 989137 - Part 13: Ability to ignore hashes of downloaded experiments. r=gfritzsche 2014-04-17 15:47:36 +02:00
Georg Fritzsche
e51bb9befc Bug 989137 - Part 12: Refactor experiment and add-on state management. r=gfritzsche 2014-04-17 15:47:36 +02:00
Georg Fritzsche
c143ccc852 Bug 989137 - Backout re-ordered patches that conflict with a known-good patch stack: 1ab6bbd62c76, 5c3a195a107e, 73da7e611e92, 2c1a0b0551fb. r=me 2014-04-17 15:47:36 +02:00
Gregory Szorc
9e7c752bea Bug 989137 - Part 14: Return a promise from Experiments.init(); r=gfritzsche
Upcoming tests will need to wait on init() to finish before running. We
now return a promise so these tests don't have to look at internal
variables.

--HG--
extra : rebase_source : 487645efe419fb3fa3371f85a81e8f3e1ccd9012
extra : amend_source : 3d6bb785e0ecdabcbff1e5bc62ee7dc56cbb7244
extra : histedit_source : 8d12f7e5c47995a408509a85a527bc86f9a76ccb
2014-04-10 13:29:02 -07:00
Gregory Szorc
9712b346d6 Bug 989137 - Part 13: Rename functions for associating with Add-on Manager; r=gfritzsche
The previous experiment feature expands the scope of these functions. A
rename was in order.

--HG--
extra : rebase_source : 054d7a440e3e15436ff7fbcbc4f91b28dd4fc9fd
2014-04-10 13:27:36 -07:00
Gregory Szorc
6ab6b755f8 Bug 989137 - Part 12: Ability to ignore hashes of downloaded experiments; r=gfritzsche
We normally validate hashes of XPIs as part of installing experiments.
While a useful security feature, this patch makes that optional. This in
turn makes automated and manual testing easier.

--HG--
extra : rebase_source : 292653411391843fad3f62d0bee01e11779313b6
2014-04-10 13:18:19 -07:00
Georg Fritzsche
e5fe9cdf14 Bug 993084 - Fix experiments health report provider test. r=bsmedberg 2014-04-15 18:12:26 +02:00
Georg Fritzsche
62be24a2fb Bug 993084 - Consolidate pref name constants for experiment tests. r=bsmedberg 2014-04-15 18:12:26 +02:00
Georg Fritzsche
ad820c03ef Bug 993084 - Delay initialization of telemetry experiments if there is no active experiment. r=bsmedberg
To sync experiment state with the addon manager, we need to start it early when there is a
active experiment.
However, initializing the telemetry experiments system too early can lead to performance
regressions, so we delay the initialization if we don't have an active experiment.
2014-04-15 18:12:26 +02:00
Georg Fritzsche
acbb3e6fd1 Bug 994727 - Telemetry experiments: Fix disabling the feature. r=bsmedberg 2014-04-11 16:29:29 +02:00
Georg Fritzsche
31ff5e9a1c Bug 994727 - Telemetry experiments: Test coverage for disabling the feature. r=bsmedberg 2014-04-11 16:29:29 +02:00
Georg Fritzsche
c825d4572d Bug 993084 - Don't load experiments module if the feature is preffed off. r=bsmedberg 2014-04-10 16:56:25 +02:00
Gregory Szorc
404a6147ae Bug 989137 - Part 11: Make service initialization and uninitialization more robust; r=gfritzsche
Subsequent patches were running into race conditions and bugs related to
Experiments instance initialization state. This patch plugs the
necessary holes in initialization state management to unblock work.

The fixes are far from robust. There are still race conditions and bugs.
They should probably be addressed later.

--HG--
extra : rebase_source : 5f0c7fa1f554d09a21b1452506884dc771cb829d
2014-04-07 14:11:31 -07:00
Benjamin Smedberg
5fea1d7db6 Bug 993084 attempt - make CommonUtils and Metrics imports lazy, since they aren't going to be needed anywhere near startup or when experiments is disabled, r=gps 2014-04-08 17:18:17 -04:00
Gregory Szorc
257b8e331e Bug 989137 - Part 10: Add a testing-only JSM for common AddonManager operations; r=Unfocused, r=gfritzsche
There is a lot of boilerplate testing code that performs common
AddonManager operations. Some common operations used for testing
Experiments have been refactored into a testing-only JSM that lives as
part of the Add-ons Manager.

--HG--
extra : rebase_source : f18cf54c7af6d390ed4437bd0ed0eb4beea76b0d
2014-04-04 15:58:29 -07:00
Gregory Szorc
618fcdf16e Bug 989137 - Part 9: Ensure add-ons are enabled when they should be; r=Unfocused, r=gfritzsche
Experiment add-ons are disabled by default in the Addon Manager. This
patch will manually enable them if necessary.

--HG--
extra : rebase_source : 2271372b232b5d85af32a4a96f2e3beb867cabf9
2014-04-04 15:58:27 -07:00
Gregory Szorc
374f95c48e Bug 989137 - Part 8: Prevent unknown experiments from being installed; r=Unfocused
The experiments service insists on being in control of experiments.
Before, it wasn't being as assertive as it needed to be: other browser
components could install experiments behind its back. This patch
reasserts the experiments service as king of experiments add-on
management.

--HG--
extra : rebase_source : 91439622e47419fae7675d83890e83cf37db453b
2014-04-04 15:58:26 -07:00
Phil Ringnalda
8d395ba254 Backed out 3 changesets (bug 989137) for a sudden influx of xpcshell failures
CLOSED TREE

Backed out changeset 831a3ccce100 (bug 989137)
Backed out changeset d3053c4e4c51 (bug 989137)
Backed out changeset 7e410c1d61e6 (bug 989137)
2014-04-05 20:30:24 -07:00
Gregory Szorc
464ae0d5b4 Bug 989137 - Part 10: Add a testing-only JSM for common AddonManager operations; r=Unfocused, r=gfritzsche
There is a lot of boilerplate testing code that performs common
AddonManager operations. Some common operations used for testing
Experiments have been refactored into a testing-only JSM that lives as
part of the Add-ons Manager.

--HG--
extra : rebase_source : 7b595e2a93637a1b2746e0182fbbe897c93fb6d9
2014-04-04 15:58:29 -07:00
Gregory Szorc
a87eaf884a Bug 989137 - Part 9: Ensure add-ons are enabled when they should be; r=Unfocused, r=gfritzsche
Experiment add-ons are disabled by default in the Addon Manager. This
patch will manually enable them if necessary.

--HG--
extra : rebase_source : be3d7c7489fa851dc421b5bae05978fa8ba17539
2014-04-04 15:58:27 -07:00
Gregory Szorc
8539252e0c Bug 989137 - Part 8: Prevent unknown experiments from being installed; r=Unfocused
The experiments service insists on being in control of experiments.
Before, it wasn't being as assertive as it needed to be: other browser
components could install experiments behind its back. This patch
reasserts the experiments service as king of experiments add-on
management.

--HG--
extra : rebase_source : 6d9b94f91865ef3c6929bc34cd3e7bb57e112d14
2014-04-04 15:58:26 -07:00
Benjamin Smedberg
96822a64e4 Bug 992208 - Add Telemetry Experiments to the package so that they are actually used. Also a basic test that the service exists and can be created. r=gfritzsche 2014-04-04 13:03:29 -04:00