Michal Novotny
815ac794a5
Bug 1561944 - Implement nsINetworkLinkService.networkID for Android r=valentin
...
Patch changes nsAndroidNetworkLinkService so it uses NetlinkService for network ID calculation as well as for notifications about network changes.
Differential Revision: https://phabricator.services.mozilla.com/D43385
--HG--
extra : moz-landing-system : lando
2019-09-19 13:47:46 +00:00
Jeremy Lempereur
c3d1703996
Bug 1580157 - Add tests to network attributes sorting. r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D45893
--HG--
extra : moz-landing-system : lando
2019-09-17 18:58:39 +00:00
Valentin Gosu
54d27f2b21
Bug 1576386
- Set a 2 second timeout when shutting down the Link Monitor thread r=mayhemer
...
The thread calls into some windows APIs that may sometimes block for a long time. Since we're shutting down anyway, it is OK to sometimes leak this thread, similar to what we do for DNS resolver threads.
The patch converts nsNotifyAddrListener::mThread to a nsIThreadPool (with a max of 1 thread) so that we may call shutdownWithTimeout on it.
Differential Revision: https://phabricator.services.mozilla.com/D46002
--HG--
extra : moz-landing-system : lando
2019-09-17 11:38:49 +00:00
Valentin Gosu
03918d82cc
Bug 1580130 - Call calculateNetworkId() after every CheckAdaptersAddresses r=dragana
...
Since we sometimes coalesce SendEvents, calling it from there is not actually correct, and sometimes we fail to recompute the networkID when network changes happen.
Differential Revision: https://phabricator.services.mozilla.com/D45331
--HG--
extra : moz-landing-system : lando
2019-09-13 06:41:37 +00:00
Valentin Gosu
078dddfc0a
Bug 1576386
- Don't recompute the networkId during shutdown r=michal
...
Calling the windows APIs may block shutdown.
Differential Revision: https://phabricator.services.mozilla.com/D45161
--HG--
extra : moz-landing-system : lando
2019-09-11 14:38:52 +00:00
Jeremy Lempereur
28fa1df24e
Bug 1562386 - Sort network attributes before hashing them to get a networkID r=mayhemer,michal,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D38418
--HG--
extra : moz-landing-system : lando
2019-09-10 11:02:25 +00:00
Brindusan Cristian
41e89721b3
Backed out changeset 566627a48370 (bug 1562386) for bustages on nsNotifyAddrListener.cpp:222:21. CLOSED TREE
...
--HG--
extra : histedit_source : d26c75e2ded633ed92ce294faf94e2c9ec259c74
2019-09-09 14:28:10 +03:00
Jeremy Lempereur
d70444d071
Bug 1562386 - Sort network attributes before hashing them to get a networkID r=mayhemer,michal
...
Differential Revision: https://phabricator.services.mozilla.com/D38418
--HG--
extra : moz-landing-system : lando
2019-09-06 10:12:51 +00:00
Michal Novotny
a9aa8451c2
Bug 1570932 - Add telemetry about how often we observe network change events, r=dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D44215
--HG--
extra : moz-landing-system : lando
2019-08-30 18:18:19 +00:00
Michal Novotny
19c05de902
Bug 1576826 - Intermittent Assertion failure: isResponse, at NetlinkService.cpp:613, r=kershaw
...
Obviously broadcasted messages can be multipart too.
Differential Revision: https://phabricator.services.mozilla.com/D43849
--HG--
extra : moz-landing-system : lando
2019-08-29 12:08:53 +00:00
Michal Novotny
390918caab
Bug 1567616 - network id based on default gateway is wrong when VPN overrides default gateway by more specific routes r=dragana
...
This patch implements NetlinkService which communicates with kernel via netlink socket. It keeps track of addresses, default routes, interfaces and neighbors and uses it to calculate network ID.
Differential Revision: https://phabricator.services.mozilla.com/D43175
--HG--
rename : netwerk/system/linux/nsNotifyAddrListener_Linux.cpp => netwerk/system/linux/nsNetworkLinkService.cpp
rename : netwerk/system/linux/nsNotifyAddrListener_Linux.h => netwerk/system/linux/nsNetworkLinkService.h
extra : moz-landing-system : lando
2019-08-26 21:46:32 +00:00
Andreea Pavel
f042d32425
Backed out changeset 22469090e93e (bug 1567616) for build bustages on a CLOSED TREE
...
--HG--
rename : netwerk/system/linux/nsNetworkLinkService.cpp => netwerk/system/linux/nsNotifyAddrListener_Linux.cpp
rename : netwerk/system/linux/nsNetworkLinkService.h => netwerk/system/linux/nsNotifyAddrListener_Linux.h
2019-08-27 00:30:40 +03:00
Michal Novotny
128254f45e
Bug 1567616 - network id based on default gateway is wrong when VPN overrides default gateway by more specific routes r=dragana
...
This patch implements NetlinkService which communicates with kernel via netlink socket. It keeps track of addresses, default routes, interfaces and neighbors and uses it to calculate network ID.
Differential Revision: https://phabricator.services.mozilla.com/D43175
--HG--
rename : netwerk/system/linux/nsNotifyAddrListener_Linux.cpp => netwerk/system/linux/nsNetworkLinkService.cpp
rename : netwerk/system/linux/nsNotifyAddrListener_Linux.h => netwerk/system/linux/nsNetworkLinkService.h
extra : moz-landing-system : lando
2019-08-26 20:03:33 +00:00
Kershaw Chang
50cb9b047f
Bug 1568898 - Calaulate network id when ip changed r=michal
...
Differential Revision: https://phabricator.services.mozilla.com/D39699
--HG--
extra : moz-landing-system : lando
2019-08-13 16:48:05 +00:00
Kershaw Chang
91a9c98998
Bug 1564960 - Calaulate network id on stream transport thread r=michal
...
Differential Revision: https://phabricator.services.mozilla.com/D39020
--HG--
extra : moz-landing-system : lando
2019-08-14 13:20:25 +00:00
Michal Novotny
82a7200c4b
Bug 1561273 - network ID: ipv4NetworkId/scanArp returns gateway IP instead of its MAC, r=kershaw
...
This patch fixes a bug in ipv4NetworkId where we wrongly hashed IP address instead of MAC address. It also simplifies getMac function. MAC address must be 6 bytes long. If it's not it's probably an error and we must not use it.
Differential Revision: https://phabricator.services.mozilla.com/D39349
--HG--
extra : moz-landing-system : lando
2019-07-26 12:29:01 +00:00
Valentin Gosu
7ab22ff110
Bug 1561005 - Add empty GetNetworkID impl for Android r=michal
...
Differential Revision: https://phabricator.services.mozilla.com/D35883
--HG--
extra : moz-landing-system : lando
2019-06-28 11:42:05 +00:00
Valentin Gosu
49e0220e23
Bug 1561005 - Implement nsINetworkLinkService.networkID on mac r=michal
...
Depends on D35780
Differential Revision: https://phabricator.services.mozilla.com/D35781
--HG--
extra : moz-landing-system : lando
2019-06-28 12:41:27 +00:00
Valentin Gosu
c657dcfafe
Bug 1561005 - Implement nsINetworkLinkService.networkID on Linux r=michal
...
* calculateNetworkId is now called before sending each ChangeEvent
* mNetworkId is truncated when no IPv4/IPv6 IDs could be computed
Differential Revision: https://phabricator.services.mozilla.com/D35780
--HG--
extra : moz-landing-system : lando
2019-06-28 11:42:09 +00:00
Valentin Gosu
7aa44d1987
Bug 1561005 - Make windows networkID use the INetworkListManager API r=mayhemer,michal
...
Depends on D35683
Differential Revision: https://phabricator.services.mozilla.com/D35684
--HG--
extra : moz-landing-system : lando
2019-06-28 16:35:22 +00:00
Valentin Gosu
ce90534047
Bug 1561005 - Add nsINetworkLinkService.networkID r=michal
...
Differential Revision: https://phabricator.services.mozilla.com/D35683
--HG--
extra : moz-landing-system : lando
2019-06-28 11:42:12 +00:00
Valentin Gosu
e19cd483fd
Bug 1395914 - Update histogram with two new values for IPv6 network-id changes r=michal
...
Differential Revision: https://phabricator.services.mozilla.com/D34905
--HG--
extra : moz-landing-system : lando
2019-06-28 11:42:14 +00:00
Valentin Gosu
18173f21d2
Bug 1395914 - Figure out network id for IPv6 too (mac) r=michal
...
Differential Revision: https://phabricator.services.mozilla.com/D34904
--HG--
extra : moz-landing-system : lando
2019-06-28 11:42:16 +00:00
Valentin Gosu
1fc5fb9a40
Bug 1395914 - Figure out network id for IPv6 too (Linux) r=michal
...
Differential Revision: https://phabricator.services.mozilla.com/D34903
--HG--
extra : moz-landing-system : lando
2019-06-28 11:42:18 +00:00
Mihai Alexandru Michis
ff9ddc0bc1
Backed out 8 changesets (bug 1395914, bug 1561005) for causing bustages in nsNetworkLinkService and nsNotifyAddrListener.cpp CLOSED TREE
...
Backed out changeset c552aeab0fbf (bug 1561005)
Backed out changeset 61cf9ae8abcf (bug 1561005)
Backed out changeset 5c33e521c0e8 (bug 1561005)
Backed out changeset 82eeb4c5e535 (bug 1561005)
Backed out changeset 6b3b29de9c78 (bug 1561005)
Backed out changeset 719b3b61b9a9 (bug 1395914)
Backed out changeset 2b23587aa5ff (bug 1395914)
Backed out changeset 47f2f3e8d5f9 (bug 1395914)
2019-06-28 14:37:13 +03:00
Valentin Gosu
8673cb0d40
Bug 1561005 - Add empty GetNetworkID impl for Android r=michal
...
Differential Revision: https://phabricator.services.mozilla.com/D35883
--HG--
extra : moz-landing-system : lando
2019-06-27 09:03:28 +00:00
Valentin Gosu
1d08465e38
Bug 1561005 - Implement nsINetworkLinkService.networkID on mac r=michal
...
Differential Revision: https://phabricator.services.mozilla.com/D35781
--HG--
extra : moz-landing-system : lando
2019-06-27 09:03:11 +00:00
Valentin Gosu
20a97e21d6
Bug 1561005 - Implement nsINetworkLinkService.networkID on Linux r=michal
...
* calculateNetworkId is now called before sending each ChangeEvent
* mNetworkId is truncated when no IPv4/IPv6 IDs could be computed
Differential Revision: https://phabricator.services.mozilla.com/D35780
--HG--
extra : moz-landing-system : lando
2019-06-27 09:02:59 +00:00
Valentin Gosu
6806c4f960
Bug 1561005 - Make windows networkID use the INetworkListManager API r=michal
...
Depends on D35683
Differential Revision: https://phabricator.services.mozilla.com/D35684
--HG--
extra : moz-landing-system : lando
2019-06-28 11:21:59 +00:00
Valentin Gosu
cc4af7a576
Bug 1561005 - Add nsINetworkLinkService.networkID r=michal
...
Differential Revision: https://phabricator.services.mozilla.com/D35683
--HG--
extra : moz-landing-system : lando
2019-06-28 11:11:19 +00:00
Valentin Gosu
d36aaea3c9
Bug 1395914 - Update histogram with two new values for IPv6 network-id changes r=michal
...
Differential Revision: https://phabricator.services.mozilla.com/D34905
--HG--
extra : moz-landing-system : lando
2019-06-27 09:02:13 +00:00
Valentin Gosu
b8945b8f06
Bug 1395914 - Figure out network id for IPv6 too (mac) r=michal
...
Differential Revision: https://phabricator.services.mozilla.com/D34904
--HG--
extra : moz-landing-system : lando
2019-06-27 09:01:56 +00:00
Valentin Gosu
95534fc1ce
Bug 1395914 - Figure out network id for IPv6 too (Linux) r=michal
...
Differential Revision: https://phabricator.services.mozilla.com/D34903
--HG--
extra : moz-landing-system : lando
2019-06-27 09:19:57 +00:00
Sylvestre Ledru
e226046cb8
Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan
...
# ignore-this-changeset
Depends on D28954
Differential Revision: https://phabricator.services.mozilla.com/D28956
--HG--
extra : moz-landing-system : lando
2019-05-01 08:47:10 +00:00
Sylvestre Ledru
0b4021fcad
Bug 1521460 - Also reformat objective-c files r=mstange,ehsan,spohl
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D17139
--HG--
extra : histedit_source : 084f340503d2e1a2d9e1753c38b2c4ee9c7819f3
2019-01-21 18:18:16 +01:00
Tooru Fujisawa
7983faeb5d
Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp
2018-12-01 04:52:05 +09:00
Benjamin Bouvier
a7f1d173a0
Bug 1511383: Update vim modelines after clang-format; r=sylvestre
...
- modify line wrap up to 80 chars; (tw=80)
- modify size of tab to 2 chars everywhere; (sts=2, sw=2)
--HG--
extra : rebase_source : 7eedce0311b340c9a5a1265dc42d3121cc0f32a0
extra : amend_source : 9cb4ffdd5005f5c4c14172390dd00b04b2066cd7
2018-11-30 16:39:55 +01:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Gabriele Svelto
19e52bebd4
Bug 1510582 - Remove useless inclusions of Services.h r=erahm
...
Differential Revision: https://phabricator.services.mozilla.com/D13240
--HG--
extra : moz-landing-system : lando
2018-11-28 17:25:23 +00:00
Emilio Cobos Álvarez
fffb25b74f
Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
...
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Andi-Bogdan Postelnicu
3f2298c2f6
Bug 1457411 - Update netwerk module to make use of newer methods introduced with c++11 and c++14. r=valentin
...
MozReview-Commit-ID: 666LNaHyiuQ
--HG--
extra : rebase_source : f3a24e0342d8dcdf9020dd473bc6b1045cbc533b
2018-04-30 19:46:04 +03:00
Sylvestre Ledru
4591d82b23
Bug 1394734 - Replace CONFIG['CLANG*'] by CONFIG['CC_TYPE'] r=glandium
...
MozReview-Commit-ID: HbF5oT5HW6f
--HG--
extra : rebase_source : eca479b6ae4bff7f600d1cdb39e11ac2057e4e79
2017-12-07 22:09:38 +01:00
Sylvestre Ledru
d60d69e2cb
Bug 1411001 - Remove the +x permissions on cpp & h files r=froydnj
...
MozReview-Commit-ID: DjDkL20wRg0
--HG--
extra : rebase_source : a343d83d1f4e97e4ba56d0f57fec93079df0b5ea
2017-10-23 20:59:55 +02:00
Tom Ritter
f1a3d26f61
Bug 1392641 Check return value for functions declared with warn_unused_result r=bagder,nwgh
...
MozReview-Commit-ID: BJj3Lvtntd6
--HG--
extra : rebase_source : 1776aab1d6de123323dc034d11b24a6c7b9d7ea1
2017-08-25 14:37:44 -05:00
Tom Ritter
d06bc69178
Bug 1392642 Remove unused variables in netwerk/ to silence warnings r=bagder,nwgh
...
MozReview-Commit-ID: LLTB5RJ4ZMz
--HG--
extra : rebase_source : 26a94bce6e9a3f22542d04e9930ff74eddd1f7ca
2017-08-24 12:03:19 -05:00
Mats Palmgren
b3981c5e09
Bug 1376469 - Use LookupForAdd instead of Get+Put to avoid unnecessary hashtable lookups. r=froydnj
...
MozReview-Commit-ID: BPEFZeLkNp
2017-06-28 01:03:17 +02:00
Bill McCloskey
f115503a0b
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book
8a1350b5a6
Backed out changeset 4f6302a98ae4 (bug 1372405
)
...
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey
6b3e84ed5f
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
ea1b86680c
Backed out changeset 9846de3bd954 (bug 1372405
)
...
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00