Commit Graph

6885 Commits

Author SHA1 Message Date
Makoto Kato
c4cb964c8e Bug 1572613 - Use frame pointer based stack walker even if Android/x86 and Android/x86-64. r=jseward
Actually, we use clang for all Linux and Android platform, so it is no reason to use frame pointer based stack walker for LUL on Android/x86 and Android/x86-64 if no DWARF rule.

Differential Revision: https://phabricator.services.mozilla.com/D41320

--HG--
extra : moz-landing-system : lando
2019-08-13 07:34:29 +00:00
Henrik Skupin
0529daadd3 Bug 1573406 - Remove every trace of Firefox UI update tests. r=webdriver-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D41834

--HG--
extra : moz-landing-system : lando
2019-08-14 11:08:45 +00:00
Andrew Halberstadt
773c593e22 Bug 1570772 - [lint] Add the root 'node_modules' to the GLOBAL_EXCLUDES list, r=sylvestre
Depends on D41755

Differential Revision: https://phabricator.services.mozilla.com/D41756

--HG--
extra : moz-landing-system : lando
2019-08-13 13:45:46 +00:00
Andrew Halberstadt
64fa3bdb48 Bug 1570772 - [lint] Don't enforce licenses in empty files, r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D41755

--HG--
extra : moz-landing-system : lando
2019-08-13 13:45:06 +00:00
championshuttler
13bb66f32b Bug 1460678 - Improve mach doc performance, use sphinx's -J argument. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D41058

--HG--
extra : moz-landing-system : lando
2019-08-13 13:18:24 +00:00
Sylvestre Ledru
ec62555094 Bug 1562642 - Add some devtools dirs to the list of thirdparty code r=jlast
Ride along: also add node_modules/ (generated by moz lint)

Differential Revision: https://phabricator.services.mozilla.com/D41566

--HG--
extra : moz-landing-system : lando
2019-08-12 15:58:10 +00:00
Nick Alexander
8e0d872e6e Bug 1542004 - Add android-javadoc lint. r=agi
This also applies the error listener just to the Javadoc tasks
(previously, it applied to the `apiGenerate*` tasks as well, 'cuz they
inherit from `Javadoc`).

Differential Revision: https://phabricator.services.mozilla.com/D41634

--HG--
extra : moz-landing-system : lando
2019-08-13 01:45:03 +00:00
Will Hawkins
3050e35cce Bug 1572235: Expose a method to remove markers leftover from previous runs of the profiler. r=gerald
Differential Revision: https://phabricator.services.mozilla.com//D41275

--HG--
extra : histedit_source : c73fed719d5e5e607ede15bbbf74ed5554083b21
2019-08-09 21:04:57 +03:00
Brendan Dahl
b474db77c6 Bug 1551344 - Part 1: Remove XULDocument code. r=smaug,Jamie
All .xul files have been loading as HTMLDocuments for a few weeks now, so
it should be safe to remove the XULDocument implementation.

Differential Revision: https://phabricator.services.mozilla.com/D41238

--HG--
extra : moz-landing-system : lando
2019-08-09 19:57:50 +00:00
Axel Hecht
d3cf6d2c83 Bug 1571671 - Enable RST linting on fluent docs in intl/l10n/docs. r=championshuttler
Differential Revision: https://phabricator.services.mozilla.com/D40831

--HG--
extra : moz-landing-system : lando
2019-08-09 19:20:59 +00:00
Greg Tatum
ea78dcd35f Bug 1571216 - Disable stack walking test on macOS beta and release; r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D40820

--HG--
extra : moz-landing-system : lando
2019-08-09 15:15:33 +00:00
Erica Wright
cafcffa6a9 Bug 1557050 - Add basic telemetry to protection report. r=mtigley,johannh
Differential Revision: https://phabricator.services.mozilla.com/D39750

--HG--
extra : moz-landing-system : lando
2019-08-08 18:53:41 +00:00
Agi Sferro
d5d199cc40 Bug 1571492 - Add apiLint command in api_changes lint errors. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D41140

--HG--
extra : moz-landing-system : lando
2019-08-08 04:05:10 +00:00
Jared Wein
7ddc91c1db Bug 1571567 - Enable the no-fallthrough eslint rule. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D40744

--HG--
extra : moz-landing-system : lando
2019-08-08 15:18:51 +00:00
Bogdan Tara
844afcfb06 Backed out 10 changesets (bug 1571567) complementary backout after es lint failure on the patch CLOSED TREE
Backed out changeset ce83fa75ae32 (bug 1571567)
Backed out changeset 7aa97ba7cce9 (bug 1571567)
Backed out changeset 777d79076e99 (bug 1571567)
Backed out changeset fbdf6b75a484 (bug 1571567)
Backed out changeset e2ed4620f232 (bug 1571567)
Backed out changeset 2c67015f12c6 (bug 1571567)
Backed out changeset 7ec086bb5bd5 (bug 1571567)
Backed out changeset 42df735c8556 (bug 1571567)
Backed out changeset 7d5fc57b2809 (bug 1571567)
Backed out changeset 606bafb8211c (bug 1571567)
2019-08-08 18:13:54 +03:00
Nazım Can Altınova
2d7895a7ea Bug 1572456 - Switch the files of multi/single page information tests. r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D41216

--HG--
extra : moz-landing-system : lando
2019-08-08 14:53:19 +00:00
Alexander Surkov
002fc892ce Bug 1539651 - Convert places-popup-base and places-popup-arrow bindings to Custom Elements r=mak
Differential Revision: https://phabricator.services.mozilla.com/D33821

--HG--
rename : browser/components/places/content/menu.xml => browser/components/places/content/places-menupopup.js
extra : moz-landing-system : lando
2019-08-08 14:28:36 +00:00
Jared Wein
1b77b801de Bug 1571567 - Enable the no-fallthrough eslint rule. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D40744

--HG--
extra : moz-landing-system : lando
2019-08-08 12:45:00 +00:00
championshuttler
8c832e8927 Bug 1526796 - Removed Sphinx documentation output files is not removed from web server. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D35598

--HG--
extra : moz-landing-system : lando
2019-08-08 10:22:00 +00:00
Gerald Squelart
a2e0f9390e Bug 1571348 - ProfilerMarkerPayload::Set...() can be replaced with constructor arguments - r=gregtatum
`ProfilerMarkerPayload::Set...()` functions are only used by derived classes in
the same files, and these values could just be set during construction.

Differential Revision: https://phabricator.services.mozilla.com/D40619

--HG--
extra : moz-landing-system : lando
2019-08-07 01:53:55 +00:00
rdalal
43acd674ea Bug 1569330 - Disable telemetry check in Normandy recipe runner r=mythmon,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D39576

--HG--
extra : moz-landing-system : lando
2019-08-06 23:54:34 +00:00
championshuttler
ca9164e8bd Bug 1536103 - Fix Sphinx Warning for not referenced hyperlinks. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D39057

--HG--
extra : moz-landing-system : lando
2019-07-28 12:08:11 +00:00
Agi Sferro
41549d2c74 Bug 1571308 - Use error code from apilint. r=nalexander
Failures in apilint have a rule code so include that in the information from
the lint.

Differential Revision: https://phabricator.services.mozilla.com/D40578

--HG--
extra : moz-landing-system : lando
2019-08-06 17:26:31 +00:00
Greg Tatum
db5c7f8a80 Bug 1571171 - Make test helper doAtLeastOnePeriodicSample non-async; r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D40701

--HG--
extra : moz-landing-system : lando
2019-08-06 14:49:16 +00:00
Greg Tatum
cf59c7c0d7 Bug 1521929 - Remove RSS and USS measurements from the profiler; r=gerald,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D40287

--HG--
extra : moz-landing-system : lando
2019-08-05 15:37:18 +00:00
Agi Sferro
6c32deae47 Bug 1571308 - Don't include |detail| in apilint output. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D40575

--HG--
extra : moz-landing-system : lando
2019-08-05 16:33:30 +00:00
Nick Alexander
c5f931e3b5 Bug 1512487 - Part 3: Convert Android-specific code analyses into mozlints. r=ahal,agi
API lint is arguably the most valuable lint of all, but it's also hard
to fit into the Phab ecosystem, since there's no place to hang the
"API hash not correct" message in the case when the hash hasn't been
updated at all.  Therefore, this commit doesn't convert it.  See also
https://github.com/mozilla-mobile/gradle-apilint/issues/61 for adding
file/line information to API lint.

Differential Revision: https://phabricator.services.mozilla.com/D35277

--HG--
rename : mobile/android/config/mozconfigs/android-api-16-frontend/nightly => mobile/android/config/mozconfigs/android-api-16/nightly-android-lints
extra : moz-landing-system : lando
2019-08-02 20:34:23 +00:00
Nick Alexander
fd38e457ec Bug 1512487 - Part 1: Allow lints to inspect part of the build environment. r=ahal
This allows lints to "condition" themselves on having a build
environment or a specific build application.  It also adds the "name"
parameter, so that setup functions can be shared across lints.

`MozbuildObject` cannot be used as parameters to functions distributed
via multiprocessing, since they cannot be pickled (due, currently, to
internal terminal handles).  Therefore we extract just a few key
parts of the environment to expose.

Differential Revision: https://phabricator.services.mozilla.com/D35274

--HG--
extra : moz-landing-system : lando
2019-08-02 20:30:02 +00:00
Edwin Gao
5d0a507d0c Bug 1559975 - convert testing/mochitest to python3 r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D37096

--HG--
extra : moz-landing-system : lando
2019-08-02 19:44:34 +00:00
Edwin Gao
1eb2f0f7be Bug 1559975 - convert dom/bindings to python3 r=ahal,bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D36634

--HG--
extra : moz-landing-system : lando
2019-08-02 19:45:12 +00:00
Edwin Gao
7e8510c1ae Bug 1559975 - convert layout/style to python3 r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D35699

--HG--
extra : moz-landing-system : lando
2019-08-02 19:46:12 +00:00
Greg Tatum
ba44f243ee Bug 1567390 - Add a merged stack test for the profiler; r=canaltinova
Depends on D40324

Differential Revision: https://phabricator.services.mozilla.com/D40422

--HG--
extra : moz-landing-system : lando
2019-08-02 14:18:18 +00:00
Greg Tatum
49a90e42a6 Bug 1567390 - Add a JS stack collection test; r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D40324

--HG--
extra : moz-landing-system : lando
2019-08-02 14:15:15 +00:00
Greg Tatum
0c8eb702d9 Bug 1567390 - Add a stackwalking test to the profiler; r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D40308

--HG--
extra : moz-landing-system : lando
2019-08-02 14:06:26 +00:00
championshuttler
32c5d281c3 Bug 1486796 - Add mermaid package to Firefox source docs. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D39742

--HG--
extra : moz-landing-system : lando
2019-08-01 19:07:38 +00:00
Bastien Abadie
74eca00f1f Bug 1569882 - Fix mozlint unit tests for relative path outputs, r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D39877

--HG--
extra : moz-landing-system : lando
2019-07-30 23:30:15 +00:00
Gerald Squelart
a8ae8a7a30 Bug 1569515 - Show overhead stats in Profiler tests - r=canaltinova
cppunittest TestBaseProfiler and gtest GeckoProfiler.Markers now show overhead
stats.
(Separate patch, because we may want to remove them after a while.)

Differential Revision: https://phabricator.services.mozilla.com/D39642

--HG--
extra : moz-landing-system : lando
2019-07-31 01:28:53 +00:00
Gerald Squelart
ce889db273 Bug 1569515 - Collect overhead stats in ProfileBuffer - r=canaltinova
`ProfileBuffer` is now responsible for collecting overhead stats, and adding
them to the struct returned by `profiler_get_buffer_info()`.

Differential Revision: https://phabricator.services.mozilla.com/D39641

--HG--
extra : moz-landing-system : lando
2019-07-31 01:28:51 +00:00
Gerald Squelart
68db1b82de Bug 1569506 - SamplerThread can own a Sampler instead of being one - r=canaltinova
`SamplerThread` inheriting from `Sampler` was a bit confusing, and scary with no
virtual destructor&functions.
`SamplerThread` only uses `Sampler`'s `Disable()` and
`SuspendAndSampleAndResumeThread()` functions, and `SamplerThread` is never
accessed through a `Sampler` reference/pointer.
So `SamplerThread` can just own a `Sampler` to make that relationship clearer.

Differential Revision: https://phabricator.services.mozilla.com/D39640

--HG--
extra : moz-landing-system : lando
2019-07-31 01:28:49 +00:00
championshuttler
c14004740f Bug 1569472 - Level Down the Error level to 2. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D39663

--HG--
extra : moz-landing-system : lando
2019-07-30 15:20:00 +00:00
championshuttler
55342ff5a5 Bug 1569472 - Fix taskcluster docs linting errors. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D39627

--HG--
extra : moz-landing-system : lando
2019-07-30 15:20:00 +00:00
Andrew Halberstadt
afb38c0807 Bug 1569704 - Update tools/tryselect bug component metadata, r=glob
Differential Revision: https://phabricator.services.mozilla.com/D39725

--HG--
extra : moz-landing-system : lando
2019-07-30 06:31:49 +00:00
Olli Pettay
c7ee50989c Bug 1565930, try to make Promise less error prone to compartment mismatches, r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D38762

--HG--
extra : moz-landing-system : lando
2019-07-29 14:43:54 +00:00
Nick Alexander
f2e38650f0 Bug 1566171 - Part 1: Expose browsertime helpers to Raptor harness. r=barret
This will allow mozharness tooling, which does not run through `mach`,
to fish these paths.

Differential Revision: https://phabricator.services.mozilla.com/D38775

--HG--
extra : moz-landing-system : lando
2019-07-26 21:29:57 +00:00
Andreas Tolfsen
6d34028758 bug 1568881: mozbase: run rustfmt checks in ci; r=whimboo
The Rust port of mozbase passes all the lints, but there are ~20
warnings.  The warnings will not make the rustfmt job on Treeherder fail.

Differential Revision: https://phabricator.services.mozilla.com/D39367

--HG--
extra : moz-landing-system : lando
2019-07-26 12:02:40 +00:00
Andreas Tolfsen
439f43de87 bug 1568889: tools/lint: run rustfmt on geckodriver and webdriver; r=webdriver-reviewers,whimboo
Includes geckodriver and the webdriver crate in the rustfmt job
on Treeherder.

Enabling this does not cause any errors, but we are seeing 93 warnings.
These are not fatal and do not cause the job to fail in continuous
integration.

Differential Revision: https://phabricator.services.mozilla.com/D39368

--HG--
extra : moz-landing-system : lando
2019-07-26 11:18:08 +00:00
Edwin Gao
233b2d7fc7 Bug 1541424 - ensure path expansion in mach try respects manifest annotations r=ahal,marco
Differential Revision: https://phabricator.services.mozilla.com/D38771

--HG--
extra : moz-landing-system : lando
2019-07-25 17:10:43 +00:00
Julian Descottes
5689ca6238 Bug 1568823 - Move Parser.jsm to a regular module in devtools/shared/webconsole r=nchevobbe
Depends on D39333

Differential Revision: https://phabricator.services.mozilla.com/D39335

--HG--
rename : devtools/shared/Parser.jsm => devtools/shared/webconsole/parser.js
extra : moz-landing-system : lando
2019-07-25 13:17:11 +00:00
Nick Alexander
280126dff5 Bug 1564256 - Part 2: Produce browsertime.zip in a toolchain task. r=mshal
In browsertime.zip we should have:

browsertime/
  package.json
  package-lock.json
  node_modules/
    .bin/
      browsertime -> ../browsertime/bin/browsertime.js
    browsertime/
      ...

The idea is that we'll fetch browsertime.zip in a generic-worker
environment and be able to run Node.js from within the top level
browsertime/ directory.

Differential Revision: https://phabricator.services.mozilla.com/D38773

--HG--
extra : moz-landing-system : lando
2019-07-24 20:59:55 +00:00
Nick Alexander
ceec08a80d Bug 1564256 - Part 1: Don't install optional browsertime packages in automation. r=barret
browsertime depends on a few architecture and OS specific packages:
- sharp (libvips)
- geckodriver
- chromedriver

Our toolchain task packages up `tools/browsertime/node_modules` and
we'd like to use the resulting toolchain archive across all of our
test platforms.  Since in automation we don't require sharp (which is
only used for screenshotting), and we provide `geckodriver` and
`chromedriver` at the task level, the simplest way is to make these
`optionalDependencies` at the NPM level and not install them in our
toolchain task.

Differential Revision: https://phabricator.services.mozilla.com/D38772

--HG--
extra : moz-landing-system : lando
2019-07-24 20:58:39 +00:00