Commit Graph

376 Commits

Author SHA1 Message Date
Graeme McCutcheon
ad641e5247 Bug 510575 - fix calculation of bounds in nsTypedSelection::GetIndicesForInterval, and ensure range adding code always checks for duplicates. r=roc 2009-09-25 11:11:42 +01:00
Graeme McCutcheon
164332ae56 Bug 493111 - ASSERTION: Range index not returned. r=roc 2009-09-22 19:05:39 +01:00
Neil Deakin
a7f4a724cd Bug 516991, get the right scrollable view from within the selection scroll timer, otherwise scrolling is jumpy, r=roc 2009-09-17 16:33:29 -04:00
Mats Palmgren
dea07412a1 Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX. b=512106 r=roc 2009-09-16 17:01:36 +02:00
Neil Deakin
51b0e867e6 Bug 503943, add mouse capturing api to elements, remove capturing from views, r=roc,sr=smaug 2009-09-13 09:13:16 -04:00
Neil Deakin
cef5702d08 Bug 503943, back out mouse capture patch, CLOSED TREE 2009-09-10 12:11:41 -04:00
Neil Deakin
6d007b6255 Bug 503943, add mouse capturing api to elements, remove capturing from views, r=roc,sr=smaug 2009-09-10 08:51:36 -04:00
Alexander Surkov
1c8c857964 Bug 417929 - nsIAccessiblTable selectRows does not unselect previously selected rows, r=marcoz, davidb, ginn, smaug, sr=roc 2009-09-10 11:06:54 +08:00
Boris Zbarsky
8f435d226b Backed out changeset 4aa19414e651 (bug 488249) to fix test orange.
--HG--
extra : rebase_source : ae1c0155ec32b0887eff27ded77c6ba2b37dda64
2009-08-24 20:51:57 -04:00
David Zbarsky
0aa6350041 Bug 488249. Replace IsNodeOfType(eHTML) checks with namespace checks. r+sr=jst 2009-08-24 16:02:07 -04:00
Hashem Masoud
b71a1a1cfa Bug 489502 - Replace NS_ASSERTION(0, ...) by NS_ERROR(...) in mozilla-central; r=benjamin 2009-08-14 16:09:00 +02:00
timeless@mozdev.org
3c817bcdd3 Bug 506645 nsTypedSelection::AddItem doesn't always null check aOutIndex
r=smaug
2009-08-12 11:49:55 +02:00
timeless@mozdev.org
58d9ac5cce Bug 506258 nsFrameSelection::ConstrainFrameAndPointToAnchorSubtree doesn't seem to use anchorFrame or anchorFrameOffset
r=roc
2009-08-12 11:49:54 +02:00
Robert O'Callahan
421cab991c Bug 506874. Don't temporarily remove ranges from the selection while we alter the frame state. Also adds a bunch of selection tests. r=smaug
--HG--
extra : rebase_source : 5d4fd55728e1167cc57451b5c80a46643191678b
2009-08-03 14:12:57 +12:00
Michael Kohler
4b7c87c984 Bug 106386 - Correct misspellings in source code (old); Part 2; r=timeless 2009-07-27 10:47:02 +02:00
Robert O'Callahan
8bab94a96a Bug 371839. Simplify SetSelected signature and semantics, and reimplement it in nsTextFrame much more efficiently. r=bzbarsky
--HG--
extra : rebase_source : 18c390e3ebd09de82b1a23699c56b741f928ca37
2009-07-27 10:05:41 +12:00
Graeme McCutcheon
1c6412faca Bug 348681 follow-up comment fix. 2009-05-09 22:36:17 +01:00
Graeme McCutcheon
7c815c938d Bug 348681 - Don't allow overlapping ranges in the selection. r+sr=roc 2009-05-09 22:30:19 +01:00
L. David Baron
e51a27d783 Traverse and unlink selection listeners. (Bug 490071) r+sr=peterv 2009-05-08 21:59:26 -07:00
Masayuki Nakano
cfff67f8c9 Bug 482138 [TSF] nsTextFrame has to draw composition string by TIP specified style r+sr=roc 2009-04-23 12:27:12 +09:00
Boris Zbarsky
d631c2329b Bug 488417. Need to hold strong refs to ranges across calling RemoveRange. r+sr=roc 2009-04-21 15:57:40 -04:00
Boris Zbarsky
bff20cf17a Bug 486547. Fix build bustage on Windows 2009-04-06 14:39:02 -04:00
Boris Zbarsky
15b0e0b5f3 Bug 486547 part 7. Simplify some more of the table code in nsFrameSelection. r+sr=smaug 2009-04-06 13:21:30 -04:00
Boris Zbarsky
aa115a4e74 Bug 486547 part 6. Simplify some cell-related code in nsFrameSelection. r+sr=smaug 2009-04-06 13:20:32 -04:00
Boris Zbarsky
17796c6f64 Bug 486547 part 5. Switch various table cell selection stuff off nsIDOMRange. r+sr=smaug 2009-04-06 13:20:30 -04:00
Boris Zbarsky
fe07c58568 Bug 486547 part 4. Switch some more code off nsIDOMNode/nsIDOMRange r+sr=smaug 2009-04-06 13:17:38 -04:00
Boris Zbarsky
75e8ba1c24 Bug 486547 part 3. Eliminate the Fetch*Node methods of nsTypedSelection. r+sr=smaug 2009-04-06 13:17:38 -04:00
Boris Zbarsky
f92fc0c496 Bug 486547 part 2. Switch nsFrameSelection::mMaintainRange to storing nsIRange, not nsIDOMRange. r+sr=smaug 2009-04-06 13:17:38 -04:00
Boris Zbarsky
081b4b02e7 Bug 486547 part 1. Switch nsTypedSelection to storing nsIRange, not nsIDOMRange, objects. r+sr=smaug 2009-04-06 13:17:37 -04:00
Olli Pettay
b6cf78a6a8 Bug 478245 - Crash [@ nsEventStateManager::PreHandleEvent], r+sr=dbaron 2009-03-11 17:43:08 +02:00
Olli Pettay
58e1a51801 Bug 466856 - Crash [@ nsTypedSelection::CopyRangeToAnchorFocus], r+sr=roc 2009-02-26 18:36:34 +02:00
Peter Van der Beken
122dcedc98 Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles). r=bent, sr=bz. 2009-01-14 13:24:10 +01:00
Peter Van der Beken
c31332c26a Back out changeset 9fd8740decb8 (Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles).) to try to fix orange. 2009-01-14 15:12:37 +01:00
Peter Van der Beken
2353ea8945 Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles). r=bent, sr=bz. 2009-01-14 13:24:10 +01:00
Benjamin Smedberg
3498a5f86e Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
73a6fab34b Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
802d1a10c7 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Uri Bernstein
030cd64a09 Set mMaintainRange to null when there is no selection. b=470212 r=mats sr=roc 2009-01-08 22:17:49 +01:00
Mats Palmgren
4097da34ae Don't crash if views were destroyed while flushing notifications. b=421839 r+sr=roc 2008-12-08 00:11:37 +01:00
Vladimir Vukicevic
5ab3bffacb b=461813, crash in nsFrameSelection::HandleDrag; r+sr=roc 2008-11-04 11:29:13 -08:00
Markus Stange
1b2252f6c6 Bug 462793 - Changing listbox selection with keyboard no longer scrolls to make the newly selected item visible, r+sr=roc 2008-11-04 15:38:16 +01:00
Benjamin Smedberg
bb3bf9ec94 Bug 461212 - deCOM frame traversal (relanding) r=mats.palmgren sr=roc 2008-10-30 10:15:22 -07:00
Benjamin Smedberg
555c5a8f1c Backed out changeset affcc1c08bc0 (deCOM frame enumerator) due to regression from it or bug 461410. 2008-10-28 02:47:40 -04:00
Benjamin Smedberg
2127dcfc13 Bug 461212 - deCOM frame enumerator, r=mats.palmgren sr=roc 2008-10-28 00:47:19 -04:00
Uri Bernstein
2ed96f2ef8 Bug 459921 - Double-click-and-drag selects previous word when dragging to left half of first letter of a word. r+sr=roc. 2008-10-21 11:52:52 +02:00
Uri Bernstein
269b19b637 Bug 415707 - multiple text selection improvement doesn't work with double-click "word-by-word" or triple-click "paragraph" modes. r+sr=roc. 2008-10-17 21:46:33 +02:00
Theppitak Karoonboonyanan
88e1b95b7b Bug 157546. The 'delete' key should delete an entire cluster. r=peterv,r+sr=roc 2008-10-16 20:44:32 +13:00
Olli Pettay
3cba110fca bug 302775 - extractContents doesn't work if start and end node of a Range object is an attribute node, r=peterv, sr=sicking 2008-10-15 12:40:28 +03:00
Uri Bernstein
ce54716f69 Bug 459660: Remove two unused members of nsTypedSelection and their accessors. r+sr=roc. 2008-10-13 23:25:21 +02:00
Uri Bernstein
3f918b6ada Bug 459588: Kill OLD_SELECTION code. r+sr=roc. 2008-10-13 00:11:51 +02:00