Commit Graph

28593 Commits

Author SHA1 Message Date
Petru Lingurar
3f5101c956 Bug 1562831 - Stop the Crash Service cleanly to prevent it's restart; r=VladBaicu
The service would be restarted after System.exit(0) which would show the crash
feedback form again to the user.

That System.exit(0) was initially used to prevent a silent ANR because of the
Service being started from background on Android Oreo+ without a foreground
notification.

To overcome all this we'll also use a foreground notification on Android Oreo+
but with NotificationManager.IMPORTANCE_LOW to be non-intrusive.

Differential Revision: https://phabricator.services.mozilla.com/D36746

--HG--
extra : moz-landing-system : lando
2019-07-03 13:13:10 +00:00
Dylan Roeh
5e0a7630a4 Bug 1499396 - Add basic testing for PromptDelegate. r=geckoview-reviewers,snorp
Some tests still disabled due to either test environment weirdness or actual breakage.

Differential Revision: https://phabricator.services.mozilla.com/D36531

--HG--
extra : moz-landing-system : lando
2019-07-02 22:51:43 +00:00
Henri Sivonen
29ac9cfdbe Bug 1545429 - Avoid passing unsupported Android screen orientation flag combinations to Gecko. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D36351

--HG--
extra : moz-landing-system : lando
2019-07-02 17:42:34 +00:00
Andreea Pavel
7c9308d2ee Bug 1533934 - ignore SessionLifecycleTest.createFromParcel on pgo r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D36240

--HG--
extra : moz-landing-system : lando
2019-07-02 16:58:09 +00:00
John Lin
a987fc3b69 Bug 1552607 - p2: check sample session ID when processing buffers. r=jya
Because IPC call runs asynchronously in both remote decoder process and
content process, ProcessOutput() for buffers prior to Flush() could be
scheduled to run after the flush promise is resolved, and Codec.queueInput()
could be preempted and processes prior sample after flush.
To help check the validness of buffers, a session ID increased by flush
is added to both RemoteDataDecoder and remote codec service and will be
passed through IPC. If the passed ID doesn't agree with current session
ID, it means the buffer doesn't belong to current session and should be
discard.

Differential Revision: https://phabricator.services.mozilla.com/D36382

--HG--
extra : moz-landing-system : lando
2019-07-02 18:12:44 +00:00
John Lin
a06092b96c Bug 1552607 - p1: filter out invalid input buffers. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D36381

--HG--
extra : moz-landing-system : lando
2019-07-02 18:12:35 +00:00
Dorel Luca
88e2b90713 Backed out changeset 3b5355424e78 (bug 1499396) for geckoview failure in org.mozilla.geckoview.test.PromptDelegateTest.buttonTest 2019-07-02 18:27:54 +03:00
Dylan Roeh
5b4527cd3a Bug 1499396 - Add basic testing for PromptDelegate. r=geckoview-reviewers,snorp
Some tests still disabled due to either test environment weirdness or actual breakage.

Differential Revision: https://phabricator.services.mozilla.com/D36531

--HG--
extra : moz-landing-system : lando
2019-07-02 13:58:06 +00:00
Cameron McCormack
890e42b6af Bug 1562359 - Tweak XUL scrollbar styles on GeckoView to avoid cached scrollbar style assertions. r=emilio
For content like:

  <select>
    <optgroup style="overflow: scroll">
      <option>

the existing rules would match the <xul:scrollbar> elements that are
generated for the <optgroup>, since they use descendant selectors after
the `select:not([size]):not([multiple])`, even though the intention
(probably!) is to match only the scrollbars created for the <select>
itself.

On Android, we don't actually render <select> elements in the page;
instead we use some system UI popup.  So in practice the difference in
rendering here isn't relevant.  (It's possible we could remove these
rules entirely.)

Differential Revision: https://phabricator.services.mozilla.com/D36449

--HG--
extra : moz-landing-system : lando
2019-07-02 00:12:59 +00:00
Mihai Alexandru Michis
74781bb639 Backed out 2 changesets (bug 1552607) for causing checkstyle failures. CLOSED TREE
Backed out changeset 53a39e402451 (bug 1552607)
Backed out changeset 6385b8616d54 (bug 1552607)
2019-07-02 04:19:01 +03:00
John Lin
38358d2cf0 Bug 1552607 - p2: check sample session ID when processing buffers. r=jya
Because IPC call runs asynchronously in both remote decoder process and
content process, ProcessOutput() for buffers prior to Flush() could be
scheduled to run after the flush promise is resolved, and Codec.queueInput()
could be preempted and processes prior sample after flush.
To help check the validness of buffers, a session ID increased by flush
is added to both RemoteDataDecoder and remote codec service and will be
passed through IPC. If the passed ID doesn't agree with current session
ID, it means the buffer doesn't belong to current session and should be
discard.

Differential Revision: https://phabricator.services.mozilla.com/D36382

--HG--
extra : moz-landing-system : lando
2019-07-01 23:42:59 +00:00
John Lin
b657d905d9 Bug 1552607 - p1: filter out invalid input buffers. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D36381

--HG--
extra : moz-landing-system : lando
2019-07-01 23:42:50 +00:00
Mike Shal
3fc78297a0 Bug 1562258 - Disable tests on instrumented builds; r=froydnj
We don't run any tests on these builds, since they are just used to
generate the profile data for the final build. We can save some time by
skipping all test related code.

Differential Revision: https://phabricator.services.mozilla.com/D36511

--HG--
extra : moz-landing-system : lando
2019-07-01 20:09:48 +00:00
Csoregi Natalia
dd29ddd1c8 Bug 1554189 - Disabled org.mozilla.geckoview.test.MediaDelegateTest.testDeviceRecordingEventAudioAndVideo on debug builds. r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D35158

--HG--
extra : moz-landing-system : lando
2019-06-29 16:08:51 +00:00
Brad Arant
550f6e5b6d Bug 1489458 - Remove extraneous console logging in browser.js.;r=VladBaicu
Differential Revision: https://phabricator.services.mozilla.com/D36284

--HG--
extra : moz-landing-system : lando
2019-06-28 12:32:14 +00:00
Eitan Isaacson
e074850ca4 Bug 1558289 - Dispatch accessibility focus events when focusing hovered node. r=geckoview-reviewers,snorp
This patch works around a case where the node that we want to set a11y
focus to is input focused, and the gecko a11y virtual cursor is set to
it.

In gecko a11y we don't have a distinction of hover/a11y focus like in
Android, the virtual cursor is already set to the position through the
explore by touch and sends a HOVER_ENTER to android. An accessibility
service will typically listen for thos events and then explicitly
request a11y focus on the node. Since it is internally already set, it
would result in a no-op and no event will be dispatched.

Differential Revision: https://phabricator.services.mozilla.com/D36141

--HG--
extra : moz-landing-system : lando
2019-06-27 21:21:42 +00:00
shindli
5715d5b394 Backed out 2 changesets (bug 1557269) for causing bustage because of maven zip not being found CLOSED TREE
Backed out changeset e3d495f69dfb (bug 1557269)
Backed out changeset b469d332f316 (bug 1557269)
2019-07-01 18:10:05 +03:00
Andrei Lazar
bbcf0bde8c Bug 1562622 Startup crash - java.lang.IllegalStateException: This ViewTreeObserver is not alive, call getViewTreeObserver() again r=petru
Now checking the global view tree observer to see if it's alive in order to unsubscribe from further
notifications.

Differential Revision: https://phabricator.services.mozilla.com/D36485

--HG--
extra : moz-landing-system : lando
2019-07-01 13:03:37 +00:00
Johan Lorenzo
45b8110131 Bug 1557269 - part 1: Remove target.maven.zip r=mtabara
Differential Revision: https://phabricator.services.mozilla.com/D34865

--HG--
extra : moz-landing-system : lando
2019-07-01 14:01:13 +00:00
ksenia
48253641cb Bug 1562248 - scrolling in Gmail fix and some ua overrides removal for webcompat go faster r=denschub,rhelmer
Differential Revision: https://phabricator.services.mozilla.com/D36347

--HG--
extra : moz-landing-system : lando
2019-07-01 08:35:53 +00:00
Tom Ritter
cb9ccdf33d Bug 1538072 - Crash if a null principal or a non-file uri tries to load a file:// uri (ContentParent.cpp case) r=nika
Differential Revision: https://phabricator.services.mozilla.com/D34171

--HG--
extra : moz-landing-system : lando
2019-06-28 20:10:03 +00:00
dlee
d1ed4c245a Bug 1531354 - P5. Safe Browsing test entries are directly stored in LookupCache. r=gcp
Create test entries via update introduces performance overhead.
We can store them directly in LookupCache and do not save test entries
to disk.

Differential Revision: https://phabricator.services.mozilla.com/D34576

--HG--
extra : moz-landing-system : lando
2019-06-29 19:05:41 +00:00
championshuttler
60ba27adf8 Bug 1536103 - Fix various Sphinx Warning in 'mach doc' (3). r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D35314

--HG--
extra : moz-landing-system : lando
2019-06-26 20:00:31 +00:00
Dennis Schubert
d55ffc8976 Bug 1561299 - Import WebCompat GoFaster 4.3.1 with -webkit-scrollbar interventions. r=rhelmer
Differential Revision: https://phabricator.services.mozilla.com/D35805

--HG--
extra : moz-landing-system : lando
2019-06-27 20:24:20 +00:00
Dylan Roeh
6e7c55ee7a Bug 1561135 - Don't automatically enable font inflation when automatic font size adjustment is enabled in GV. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D35819

--HG--
extra : moz-landing-system : lando
2019-06-28 01:12:14 +00:00
Andreea Pavel
6a3541e629 Backed out changeset 3ec2481cd32d (bug 1561135) android build bustages on a CLOSED TREE 2019-06-28 01:47:33 +03:00
Dylan Roeh
faccb486ba Bug 1561135 - Don't automatically enable font inflation when automatic font size adjustment is enabled in GV. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D35819

--HG--
extra : moz-landing-system : lando
2019-06-27 21:50:03 +00:00
Andreea Pavel
ebe2d9e7fd Bug 1546297 - ignored RuntimeSettingsTest.fontSize on pgo r=gbrown
CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D36234

--HG--
extra : source : e291257145ad2c459690da0e52c162f785de4c90
extra : histedit_source : 92a20d3a3afb0d55c73183d355109a5cec229bc8
2019-06-27 19:40:22 +00:00
Andreea Pavel
9f0c287f44 Backed out 13 changesets (bug 1546297, bug 1553515) for increasing gv-junit intermittent failures on a CLOSED TREE
Backed out changeset e291257145ad (bug 1546297)
Backed out changeset 080d770c7b35 (bug 1553515)
Backed out changeset bbc184402f36 (bug 1553515)
Backed out changeset 8fe9f5d7fef9 (bug 1553515)
Backed out changeset faa333bb64e2 (bug 1553515)
Backed out changeset 98cf5b0cadf1 (bug 1553515)
Backed out changeset dbbb8fe1ecfb (bug 1553515)
Backed out changeset 84414ac99629 (bug 1553515)
Backed out changeset d3734e6fe22a (bug 1553515)
Backed out changeset 9e9dc0e7afb3 (bug 1553515)
Backed out changeset 3d1a0d412dfd (bug 1553515)
Backed out changeset 2b1f78e255ce (bug 1553515)
Backed out changeset 0c29929cc67c (bug 1553515)
2019-06-28 00:11:50 +03:00
Andreea Pavel
0fd81f05c0 Bug 1546297 - ignored RuntimeSettingsTest.fontSize on pgo r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D36234

--HG--
extra : moz-landing-system : lando
2019-06-27 19:40:22 +00:00
Agi Sferro
21961c2f05 Bug 1553515 - Make sure runtime has started before running tests. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32584

--HG--
extra : moz-landing-system : lando
2019-06-27 19:00:47 +00:00
Agi Sferro
392dbb1d81 Bug 1553515 - Replace loopUntilIdle -> waitForCondition. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32583

--HG--
extra : moz-landing-system : lando
2019-06-27 19:00:45 +00:00
Agi Sferro
523b352f17 Bug 1553515 - Add GeckoResult.accept. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32582

--HG--
extra : moz-landing-system : lando
2019-06-27 19:00:43 +00:00
Agi Sferro
e26f7e3d8c Bug 1553515 - Add waitForCondition. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32581

--HG--
extra : moz-landing-system : lando
2019-06-27 19:00:35 +00:00
Agi Sferro
afb0f85038 Bug 1553515 - Use lambads in GeckoResultTest for readability. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32580

--HG--
extra : moz-landing-system : lando
2019-06-27 19:00:33 +00:00
Agi Sferro
d57b516357 Bug 1553515 - Add FOREGROUND_SERVICE for CrashTest. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32579

--HG--
extra : moz-landing-system : lando
2019-06-27 19:00:31 +00:00
Agi Sferro
18a5315181 Bug 1553515 - Never reuse session. r=snorp
Reusing sessions doesn't actually save that much time and avoids a lot of
hard-to-debug intermittents.

Differential Revision: https://phabricator.services.mozilla.com/D32578

--HG--
extra : moz-landing-system : lando
2019-06-27 19:00:29 +00:00
Agi Sferro
bee429b736 Bug 1553515 - Use javascript to track scrolling instead of ScrollDelegate. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32577

--HG--
extra : moz-landing-system : lando
2019-06-27 19:00:27 +00:00
Agi Sferro
1d0f6f0cca Bug 1553515 - Account for errors in PermissionDelegateTest.geolocation. r=snorp
Sometime the geolocation test fails because the position is not retrieved
quickly enough, this is OK as we're just trying to make sure that the
permission is correct.

Differential Revision: https://phabricator.services.mozilla.com/D32576

--HG--
extra : moz-landing-system : lando
2019-06-27 19:00:25 +00:00
Agi Sferro
6724e140bb Bug 1553515 - Use environment.defaultTimeoutMillis in tests. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32575

--HG--
extra : moz-landing-system : lando
2019-06-27 19:00:23 +00:00
Agi Sferro
b8bc7109bf Bug 1553515 - Wait to load a page in crashContentMultipleSessions. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32574

--HG--
extra : moz-landing-system : lando
2019-06-27 19:00:16 +00:00
Agi Sferro
593e0b54dd Bug 1553515 - Don't use reflection in ContentDelegateTest. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32573

--HG--
extra : moz-landing-system : lando
2019-06-27 19:00:14 +00:00
Andreea Pavel
8055bf446f Backed out 12 changesets (bug 1553515) android gradle failures on a CLOSED TREE
Backed out changeset 879397260d90 (bug 1553515)
Backed out changeset 7a1fb1222e52 (bug 1553515)
Backed out changeset 9a058acc45e8 (bug 1553515)
Backed out changeset 5a9d7367edb7 (bug 1553515)
Backed out changeset c4287e1c1485 (bug 1553515)
Backed out changeset a44d58f58ce4 (bug 1553515)
Backed out changeset b2b2a5d55e93 (bug 1553515)
Backed out changeset 316439eec048 (bug 1553515)
Backed out changeset ac9c129bfbcc (bug 1553515)
Backed out changeset 9fca72dc9b74 (bug 1553515)
Backed out changeset 5435965d4c04 (bug 1553515)
Backed out changeset 2889a14d1858 (bug 1553515)
2019-06-27 21:21:13 +03:00
Agi Sferro
b8e6490b77 Bug 1553515 - Make sure runtime has started before running tests. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32584

--HG--
extra : moz-landing-system : lando
2019-06-27 15:58:45 +00:00
Agi Sferro
b9b75a5400 Bug 1553515 - Replace loopUntilIdle -> waitForCondition. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32583

--HG--
extra : moz-landing-system : lando
2019-06-27 15:58:46 +00:00
Agi Sferro
4f0dfa866e Bug 1553515 - Add GeckoResult.accept. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32582

--HG--
extra : moz-landing-system : lando
2019-06-27 15:58:16 +00:00
Agi Sferro
a00eeafc7b Bug 1553515 - Add waitForCondition. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32581

--HG--
extra : moz-landing-system : lando
2019-06-27 15:58:18 +00:00
Agi Sferro
fdf7807894 Bug 1553515 - Use lambads in GeckoResultTest for readability. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32580

--HG--
extra : moz-landing-system : lando
2019-06-27 15:58:25 +00:00
Agi Sferro
4bf8f2bfd0 Bug 1553515 - Add FOREGROUND_SERVICE for CrashTest. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D32579

--HG--
extra : moz-landing-system : lando
2019-06-27 15:58:27 +00:00
Agi Sferro
caf8533a75 Bug 1553515 - Never reuse session. r=snorp
Reusing sessions doesn't actually save that much time and avoids a lot of
hard-to-debug intermittents.

Differential Revision: https://phabricator.services.mozilla.com/D32578

--HG--
extra : moz-landing-system : lando
2019-06-27 15:58:29 +00:00