Users may want to know what the wizard is changing before they answer
prompts. Add the names of impacted config options to messages so people
can make more informed decisions.
--HG--
extra : commitid : 6p2kijj68zV
extra : rebase_source : 6468ab56fad7292ac9811c546882693aee8b5922
We want to encourage people to use reviewboard over bzexport.
--HG--
extra : commitid : 4SacVKrLjxU
extra : rebase_source : 8a466b026d273a10e09184a21d14870cfb89b959
Progress is enabled by default in Mercurial 3.5. extensions.progress
no-ops. Don't prompt for it on newer Mercurial versions.
--HG--
extra : commitid : 5zyqyanQ64o
extra : rebase_source : 9fe52282b715949b8565683ffce9a7538325b3c6
The messaging on this could be bikeshedded. Something is better than
nothing, that's for sure.
--HG--
extra : commitid : BIflUCCjwsg
extra : rebase_source : 72913ca7cfeadaf6f3efd1a277282a6786d2ba66
Before, we prompted for Bugzila username/password if the hgrc contained
credentials in cookie form. Don't do that.
--HG--
extra : commitid : 1aGcwtZzsDM
extra : rebase_source : e7a1355f44b641337adb6cefd3c90ef1bf077fbd
~/.hgrc files are likely created with the user's default umask, which
commonly gives default permissions of 644. If the hgrc config contains
sensitive information (such as Bugzilla credentials), these file
permissions could result in others stealing sensitive data.
Detect when the group and other file mode bits are set and prompt to
remove these permissions.
--HG--
extra : commitid : 6vVKQNd9yLi
extra : rebase_source : 860379bfbf8fdb4eef70b069e41a41239d93e40f
Bugzilla credentials are optional. Make this more obvious by adding
"optional" to the prompt.
Bugzilla credentials are stored in plain text. Explicitly call this out
in the help text so users can make informed decisions about whether to
capture the credentials.
--HG--
extra : commitid : DjPaYeh7oTo
extra : rebase_source : 05439551c097af9407ba15a54ab558637af4658b
When we pause the sampler in the parent, we should pause it in the child as well.
Similarly, when the parent resumes, the child should also resume.
--HG--
extra : commitid : CI7X3B04eB5
extra : rebase_source : 8fdaae4004015fa54747599cff54acd187683a71
extra : amend_source : d5960310c462c208485802d70b1535f09ceaeccf
configobj doesn't support semicolon comments. Why, I don't know, since
they are pretty common in ini files.
Do a static check for semicolon comments and print a more actionable
error message.
--HG--
extra : commitid : CULjsg4do9Z
extra : rebase_source : f135cc726462c73a8363ebb8c98092177cf7ffd3
extra : amend_source : 0b8c67d5b0be3bc07cf7ff4f136bb58d342368c4
An upcoming commit will display the path of the config file in the error
message. In order to do this, the calling scope needs to know the path
to the config file.
--HG--
extra : commitid : 5CDrz1hQOOA
extra : rebase_source : 1c29359c9e98b15c99de9efb30add0b0a108aa59
extra : amend_source : 1aa2c504ce72fbdeae1da2f0a6f876e37c46f5f8
They aren't needed.
--HG--
extra : commitid : 62sGc753PYY
extra : rebase_source : 8fc70f03909e693c20b756828045c4844b43325e
extra : amend_source : aa3e557c6e81824ed8788a8412f7ead09731f42d
The creation of the directory used to be handled by the running of the
wizard. Now, since we touch the state file first, we need to create the
directory manually. Derp.
--HG--
extra : commitid : AyZNZgiy6c9
extra : rebase_source : 6deae7653be73f1245a0e1df924f05ccf9cc289c
extra : amend_source : c078de8411e6f6ce2321a03aac071f097beab1b5
Mach grew support for docstrings in `mach help` output a few weeks ago.
Add a docstring for `mach mercurial-setup`.
--HG--
extra : commitid : G9xQeLS1Lo5
extra : rebase_source : 2dca87da7e973317dbce7f715d48c7109f65f922
While not common, there are a few cases where `mach mercurial-setup`
fails. When checking the last time this command was executed, it is
sufficient to record the intent to run the command, not the fact that it
executed to completion.
--HG--
extra : commitid : K9SMNXWNIgl
extra : rebase_source : 3275e2162e0e4cf4e00c66271458b08b4f2e5f7e
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
This prevents 8 module imports from occurring at mach startup time.
As part of this, I discovered a redundant import of "sys" and eliminated
it.
--HG--
extra : commitid : AsZJHdCVbV0
extra : rebase_source : 53b1d5912ba85c7d363d9da21329a6fa65a2bce2
This removes ambiguity as to which modules are being imported, making
import slightly faster as Python doesn't need to test so many
directories for file presence.
All files should already be using absolute imports because mach command
modules aren't imported to the package they belong to: they instead
belong to the "mach" package. So relative imports shouldn't have been
used.
--HG--
extra : commitid : 6tFME1KKfTD
extra : rebase_source : 78728f82f5487281620e00c2a8004cd5e1968087
We're about to deploy this to release automation. We might as well have
normal people start using it as well. We could perhaps even have the
extension print out information on how to resume interrupted downloads
someday, so it will pay to have this enabled so they can utilize that
feature some day in the future.
DONTBUILD (NPOTB)
--HG--
extra : commitid : CVW0xQNKjt3
extra : rebase_source : 8c5f609b036ac081c1af5f7428bb8d4a4c2ed476
extra : histedit_source : adb57e6fbb5f50af619fb98e1fbb17c815aca76e
We dropped support for Mercurial 3.0 in version-control-tools. Bump
minimum versions in extensions to reflect this.
We highly recommend people run a modern Mercurial. Bump the minimum
non-legacy version to reflect that.
--HG--
extra : commitid : 8YtjoVnYauL
extra : rebase_source : 949c27a376226bbd32430047176012b51e891255
extra : histedit_source : aff04954269ed777c9b26ec3f1fda6526b1ae317
CLOSED TREE
Backed out changeset 12ce98475c6e (bug 1119980)
Backed out changeset bdb8d05f8870 (bug 1119980)
Backed out changeset a68a18840492 (bug 1119980)
Currently we only mark the version-control-tools repo as needing updating, if
we did not pass a path param to prompt_external_extension(). This is because if
no path is passed, the extension is used from the version-control-tools repo,
and so if _no_ path is passed, it's presumed the extension is external to the
repo. However this is not always the case - eg if we need to specify a specific
file for an extension (vs the entire directory), we have to do so be passing in
the path. We hit this case for reviewboard.
With this change, we always mark the version-control-tools repo as needing an
update, no matter where the extension was located.
mqext was moved into the version-control-tools repo some time ago, but mach
mercurial-setup was still pointing at the old repo location, which is no longer
being updated.
This is needed for compatibility with an upcoming release of
MozillaBuild, which distributes Mercurial as a Python package, not as a
standalone Windows program. As a result, it introduces "hg" into $PATH,
which "which" will happily prefer as the "hg" binary. This upsets
subprocess. So, we explicitly prefer "hg.exe" over "hg".
We could accomplish the same thing by calling which.whichall() and
sorting results. But this is more code and IMO not worth the effort to
implement.
--HG--
extra : rebase_source : 750ba02c02fd4a9fab42ccf128eab4f5e7741564
extra : amend_source : 8fb84c0ed5cd14dd27ad6cd7b78fb2ac1ffc87a2
