Commit Graph

3388 Commits

Author SHA1 Message Date
Mike Hommey
38189d89a7 Bug 1523146 - Remove checks for MSVC < 2017. r=dmajor
We reject MSVC compilers < 2017 already, there's no point checking for
smaller versions after that.

Differential Revision: https://phabricator.services.mozilla.com/D17770

--HG--
extra : moz-landing-system : lando
2019-01-28 03:30:03 +00:00
Cosmin Sabou
ee75c9f2c6 Backed out 6 changesets (bug 1516228) for causing bug 1523056. a=backout
Backed out changeset 24ebb52d21fa (bug 1516228)
Backed out changeset 53d93ee3ad84 (bug 1516228)
Backed out changeset 4f53ede33517 (bug 1516228)
Backed out changeset 2e6bec87c9f3 (bug 1516228)
Backed out changeset 09ee05a4cc30 (bug 1516228)
Backed out changeset 8456feb780f7 (bug 1516228)
2019-01-26 21:12:33 +02:00
Mike Hommey
7ebdb00756 Bug 1516228 - Use llvm-objdump for symbol related tests in check_binary.py. r=firefox-build-system-reviewers,mshal
Depends on D17466

Differential Revision: https://phabricator.services.mozilla.com/D17467

--HG--
extra : moz-landing-system : lando
2019-01-24 23:32:29 +00:00
Rob Lemley
ca5106306b Bug 1517298 - Add comm mozharness configs to mozharness test archive. r=firefox-build-system-reviewers,mshal
First step in moving Thunderbird mozharness unittest configurations out of
M-C. This merges the comm/mozharness directory into the mozharness test
archive's mozharness/configs/ so that the comm config files can be accessed
later by desktop_unittest.py. This inclusion is conditional and will only happen
when building Thunderbird; there are no changes to the mozharness.zip file when
building Firefox.

Differential Revision: https://phabricator.services.mozilla.com/D16374

--HG--
extra : moz-landing-system : lando
2019-01-22 20:15:36 +00:00
Sylvestre Ledru
6fc1c58e53 Bug 1521460 - clang-format: also update .m files r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D17388

--HG--
extra : moz-landing-system : lando
2019-01-24 08:10:47 +00:00
Sebastian Hengst
2ecf173b14 Merge mozilla-central to autoland 2019-01-23 11:31:44 +02:00
Mike Hommey
03a6fa8570 Bug 1521691 - Remove _MSC_VER from configure. r=chmanchester
The only use in configure itself is for a MSVC version check that is now
always true (we don't accept versions < 19.15 anymore).

The only uses in the build system are in code that could just use
CC_TYPE instead.

Differential Revision: https://phabricator.services.mozilla.com/D17207

--HG--
extra : moz-landing-system : lando
2019-01-23 00:35:10 +00:00
shindli
2aae270ee0 Backed out 2 changesets (bug 1521691) for bustages in clang-plugin.dll CLOSED TREE
Backed out changeset 09e1109d2350 (bug 1521691)
Backed out changeset cfee3de00f12 (bug 1521691)
2019-01-23 00:51:59 +02:00
Mike Hommey
bc1c78e811 Bug 1521691 - Remove _MSC_VER from configure. r=chmanchester
The only use in configure itself is for a MSVC version check that is now
always true (we don't accept versions < 19.15 anymore).

The only uses in the build system are in code that could just use
CC_TYPE instead.

Differential Revision: https://phabricator.services.mozilla.com/D17207

--HG--
extra : moz-landing-system : lando
2019-01-22 22:26:15 +00:00
Matt Howell
18090fd14b Bug 1514806 Part 6 - Disable running UPX in the installer package for targets it doesn't support. r=firefox-build-system-reviewers,mshal#firefox-build-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D15984

--HG--
extra : moz-landing-system : lando
2019-01-22 21:58:55 +00:00
Harry Twyford
70df5bbf20 Bug 1313429 - Add Touch Bar functionality to Firefox r=spohl,mikedeboer,flod
Adds Touch Bar functionality to Firefox across eight commits.

Differential Revision: https://phabricator.services.mozilla.com/D5496

--HG--
extra : moz-landing-system : lando
2019-01-22 17:13:33 +00:00
Gurzau Raul
136dc5e8bc Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-01-23 02:05:32 +02:00
Sylvestre Ledru
ed9edfad94 Bug 1521460 - mach clang-format: Also reformat objective-c files r=ehsan
Differential Revision: https://phabricator.services.mozilla.com/D17137

--HG--
extra : histedit_source : fd828fa85107af6261032b1c67894338f2502a57
2019-01-21 18:08:57 +01:00
Mike Hommey
8f49277c52 Bug 1496995 - Account for all dictionaries when updating built_in_addons.json during l10n repack. r=nalexander
All directories are part of the langpack that is being merged in, but
when the langpack includes the english dictionary, it is not handled
at the same time as other dictionaries, because it is also part of the
original application.

Instead of trying to catch all places where a dictionary might be added
to the final repack, we wrap the formatter so that it tracks all of them
wherever they're added from, and updates the built_in_addons.json file
accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D16785

--HG--
extra : moz-landing-system : lando
2019-01-18 21:53:16 +00:00
Chris Manchester
63da49dd4f Bug 1520516 - Set verbose logging for cargo when -v is passed to |./mach build|. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D16907

--HG--
extra : moz-landing-system : lando
2019-01-18 19:03:24 +00:00
Mike Hommey
1e8669d97c Bug 1520718 - In python configure, fix when in option. r=nalexander
Make option(..., when='--foo') equivalent to
option(..., when=depends('--foo')(lambda x: x)).

Differential Revision: https://phabricator.services.mozilla.com/D16795

--HG--
extra : moz-landing-system : lando
2019-01-17 17:04:06 +00:00
Emilio Cobos Álvarez
d708f206c0 Bug 1520683 - When the file generation fails, don't write to the underlying file. r=mshal,froydnj
That way we avoid massive rebuilds due to errors that are recoverable and that
would make the file generation succeed with the same contents as before.

Differential Revision: https://phabricator.services.mozilla.com/D16858

--HG--
extra : moz-landing-system : lando
2019-01-17 15:52:10 +00:00
Mike Hommey
9af1040202 Bug 1520394 - Wrap the os and subprocess modules in python configure sandbox. r=nalexander
Because the sandbox has its own environment from which it initializes,
os.environ should reflect that in the sandbox. And the few obvious
things that use os.environ too, i.e. subprocess.*.

Depends on D16667

Differential Revision: https://phabricator.services.mozilla.com/D16668

--HG--
extra : moz-landing-system : lando
2019-01-16 23:39:10 +00:00
Mike Hommey
5215f57b1d Bug 1520108 - Move MOZ_CONFIGURE_OPTIONS to toolkit/moz.configure. r=froydnj
It is only used to fill about:buildconfig.

Differential Revision: https://phabricator.services.mozilla.com/D16526

--HG--
extra : moz-landing-system : lando
2019-01-15 15:28:00 +00:00
Cosmin Sabou
1558607307 Backed out 6 changesets (bug 1514806) for causing windows 2012 opt repack bustages.
Backed out changeset 63debb1d02d3 (bug 1514806)
Backed out changeset 803d20ba3f80 (bug 1514806)
Backed out changeset 3b95c5d8466d (bug 1514806)
Backed out changeset eb09e108a439 (bug 1514806)
Backed out changeset 6a738993de29 (bug 1514806)
Backed out changeset 303b19a8b923 (bug 1514806)

--HG--
rename : other-licenses/7zstub/firefox/7zSD.win32.manifest => other-licenses/7zstub/firefox/7zSD.manifest
rename : other-licenses/7zstub/firefox/7zSD.Win32.sfx => other-licenses/7zstub/firefox/7zSD.sfx
2019-01-15 19:17:09 +02:00
Matt Howell
f8a790571f Bug 1514806 Part 6 - Disable running UPX in the installer package for targets it doesn't support. r=firefox-build-system-reviewers,mshal#firefox-build-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D15984

--HG--
extra : moz-landing-system : lando
2019-01-14 21:59:06 +00:00
Ted Mielczarek
131e617300 bug 1517793 - fix mach run --debug to not hit an exception if no debugger can be found. r=nalexander
This change simply moves a check for the "no debugger found" situation out
of a conditional so it will catch more cases.

Differential Revision: https://phabricator.services.mozilla.com/D16476

--HG--
extra : moz-landing-system : lando
2019-01-14 18:09:48 +00:00
Alex Chronopoulos
3b021adba2 Bug 1519358 - Update upstream commint hash when import libdav1d. r=TD-Linux
Differential Revision: https://phabricator.services.mozilla.com/D16298

--HG--
extra : moz-landing-system : lando
2019-01-14 21:46:32 +00:00
Mike Hommey
482de8b58a Bug 1519308 - Try toolchain-prefixed pkg-config. r=froydnj
When doing cross-compiles for Desktop, system pkg-config is going to be
looking for .pc files for the host, but systems setup for cross-compiles
come with a toolchain-prefixed pkg-config, which we should be looking
for.

Differential Revision: https://phabricator.services.mozilla.com/D16318

--HG--
extra : moz-landing-system : lando
2019-01-11 23:56:19 +00:00
Daniel Varga
f0a9c979bb Merge mozilla-inbound to mozillia-central. a=merge 2019-01-11 06:14:14 +02:00
Eric Rahm
f32fd66363 Bug 1519209 - Disable NSS_ALLOW_SSLKEYLOGFILE in beta and release. r=glandium
This disables NSS_ALLOW_SSLKEYLOGFILE in beta in release in order to avoid shutdown hangs until the NSS project has time to fix the root cause of the issue.

--HG--
extra : rebase_source : 51c84d4841308d283f993a7fda576031d7c4f449
2019-01-10 13:14:41 -08:00
Mike Hommey
8bfba15706 Bug 1519042 - Replace the last non-third-part uses of OS_TEST with TARGET_CPU. r=ted
Depends on D16161

Differential Revision: https://phabricator.services.mozilla.com/D16162

--HG--
extra : moz-landing-system : lando
2019-01-10 22:06:10 +00:00
Mike Hommey
d5fbdc4b28 Bug 1519030 - Move libav-fft configuration to python configure. r=mshal
Differential Revision: https://phabricator.services.mozilla.com/D16157

--HG--
extra : moz-landing-system : lando
2019-01-10 22:00:41 +00:00
Ehsan Akhgari
946ce15a46 Bug 1518959 - Don't format Java files by default; r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D16115

--HG--
extra : moz-landing-system : lando
2019-01-10 09:05:54 +00:00
Ted Mielczarek
70af650a9f bug 1517909 - format build telemetry time correctly when seconds has no fractional component. r=nalexander
It turns out that Python's `datetime.isoformat` method will leave off the
fractional component of seconds if it would be all zeroes, but the voluptuous
`Datetime` validator wants it to be present, so it's possible to hit an error
if you run mach at exactly an integer second.

This patch switches from `isoformat` to `strftime` with an explicit format
string instead.

Differential Revision: https://phabricator.services.mozilla.com/D15981

--HG--
extra : moz-landing-system : lando
2019-01-08 21:29:26 +00:00
Chris Manchester
b101c5a8f3 Bug 1517532 - Extend artifact builds to find and download artifacts from pgo builds when MOZ_PGO is set. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D15988

--HG--
extra : moz-landing-system : lando
2019-01-08 23:03:27 +00:00
Nick Alexander
848c9b1c1e Bug 1496190 - Add |mach package-multi-locale|; produce multi-locale GeckoView archives. r=Callek,firefox-build-system-reviewers,ted
All that is really required for this ticket is to invoke |mach android
archive-geckoview| after |mach package| in the right place.

But it's actively unhelpful to have this magic in mozharness --
especially since the documentation in `locales.rst` is subtly
incorrect (the environment variables and Make variables don't quite
work as written).  So this commit adds a Mach command to do the actual
work and replaces most of the mozharness magic with that command.
Since the l10n Make targets check out the l10n HG repositories
locally, this basically Just Works without the mozharness checkout
steps when developing locally.

Differential Revision: https://phabricator.services.mozilla.com/D12455

--HG--
extra : moz-landing-system : lando
2019-01-07 19:22:44 +00:00
Chris Manchester
0851ff9f4a Bug 1507344 - Add configure machinery for MOZ_PROFILE_USE and merging profile. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D13863

--HG--
extra : moz-landing-system : lando
2018-12-21 19:02:11 +00:00
Mike Hommey
012ea52a90 Bug 1515901 - Avoid loading mozconfig multiple times from MozbuildObject. r=froydnj
When running `mach help`, mozconfig is loaded multiple times, and even
with an almost empty mozconfig, this makes mach help take close to 10
seconds on my Windows machine.

With some memoization, the time to run mach help gets down to 2s.

Differential Revision: https://phabricator.services.mozilla.com/D15186

--HG--
extra : moz-landing-system : lando
2018-12-29 14:15:38 +00:00
Dorel Luca
af4a060def Backed out changeset e8700e52f777 (bug 1515901) for build bustage. CLOSED TREE 2018-12-22 01:17:42 +02:00
Mike Hommey
c683c549a5 Bug 1515852 - Move --with-system-jpeg to python configure. r=froydnj
We remove --disable-libjpeg-turbo because that's only useful when Yasm
is too old, and the required version is now almost 8 years old, so we
can reasonably require people to upgrade rather than workaround with a
--disable option.

The valid_yasm_version function can seem overkill, but that's because
future moves of other things to python configure will pile up.

Differential Revision: https://phabricator.services.mozilla.com/D15184

--HG--
extra : moz-landing-system : lando
2018-12-21 15:47:22 +00:00
Mike Hommey
eb8e6cb9c3 Bug 1515843 - Remove HOST_AR/HOST_RANLIB. r=ted
Now that we're not even building host static libraries, we don't need
variables for the tools used to build them.

Ironically, we weren't even running HOST_RANLIB.

Depends on D15172

Differential Revision: https://phabricator.services.mozilla.com/D15173

--HG--
extra : moz-landing-system : lando
2018-12-21 23:00:17 +00:00
Mike Hommey
d3856a0bf1 Bug 1515843 - Stop building host static libraries. r=ted
The build system has skipped creating target static libraries for very
long, except in very specific cases.

We can actually do the same for host static libraries, for which we
don't even need the escape hatch to still allow to create static
libraries.

Depends on D15171

Differential Revision: https://phabricator.services.mozilla.com/D15172

--HG--
extra : moz-landing-system : lando
2018-12-21 23:00:00 +00:00
Mike Hommey
5bd8a6be34 Bug 1515526 - Remove need_help_dependency arguments in python configure code. r=chmanchester
It turns out all the changes related to --help linting in lint.py make
them unnecessary, and we still can detect missing --help arguments
without them, per test_lint.py. On the flip side, keeping those
need_help_dependency arguments makes some functions executed twice
because some memoized functions end up being called for both cases
need_help_dependency=True and need_help_dependency=False.

Differential Revision: https://phabricator.services.mozilla.com/D15054

--HG--
extra : moz-landing-system : lando
2018-12-21 22:55:16 +00:00
Mike Hommey
94a4048c0f Bug 1515901 - Avoid loading mozconfig multiple times from MozbuildObject. r=froydnj
When running `mach help`, mozconfig is loaded multiple times, and even
with an almost empty mozconfig, this makes mach help take close to 10
seconds on my Windows machine.

With some memoization, the time to run mach help gets down to 2s.

Differential Revision: https://phabricator.services.mozilla.com/D15186

--HG--
extra : moz-landing-system : lando
2018-12-21 15:43:03 +00:00
Mike Hommey
73f192f7fd Bug 1515808 - Compensate for older python's buggy inspect.getblock. r=nalexander
Fixing this unveils an issue in TestRecursiveMake::test_linkage that
was happening locally but not on automation, due to the Binary()
template never being invoked on automation.

Differential Revision: https://phabricator.services.mozilla.com/D15162

--HG--
extra : moz-landing-system : lando
2018-12-21 00:47:29 +00:00
Mike Hommey
67f412262c Bug 1515577 - Don't quote shell strings when they contain a ~, except in first position. r=ted
We only need to quote strings that would be treated specially by the
shell, and "foo~bar" doesn't get any sort of expansion, while "~foo"
gets a user expansion, and to avoid that expansion, those latter strings
need to be quoted, but not the former.

Differential Revision: https://phabricator.services.mozilla.com/D15065

--HG--
extra : moz-landing-system : lando
2018-12-21 00:05:32 +00:00
Brindusan Cristian
c292cb5988 Backed out changeset 6944bc1c900b (bug 1515577) for build bustages on test_checks_configure.py. 2018-12-21 00:45:51 +02:00
Mike Hommey
7fe4875fe9 Bug 1515577 - Don't quote shell strings when they contain a ~, except in first position. r=ted
We only need to quote strings that would be treated specially by the
shell, and "foo~bar" doesn't get any sort of expansion, while "~foo"
gets a user expansion, and to avoid that expansion, those latter strings
need to be quoted, but not the former.

Differential Revision: https://phabricator.services.mozilla.com/D15065

--HG--
extra : moz-landing-system : lando
2018-12-20 21:51:01 +00:00
Sebastian Hengst
767c971623 Backed out 21 changesets (bug 1492664) for breaking cron task for nightlies. a=backout
Backed out changeset a7d50dbb2c8e (bug 1492664)
Backed out changeset 2d876c4ece8b (bug 1492664)
Backed out changeset c82285d253de (bug 1492664)
Backed out changeset bf6d089640eb (bug 1492664)
Backed out changeset d9a7f2ce49c3 (bug 1492664)
Backed out changeset 06c466ab4323 (bug 1492664)
Backed out changeset c1ea4a10cc8d (bug 1492664)
Backed out changeset 4c63a04fdd47 (bug 1492664)
Backed out changeset 742b038bb1dd (bug 1492664)
Backed out changeset 911b4b0fb683 (bug 1492664)
Backed out changeset 870c8cec99e5 (bug 1492664)
Backed out changeset 77699b51336b (bug 1492664)
Backed out changeset 29f33f22fd8b (bug 1492664)
Backed out changeset e7f305408708 (bug 1492664)
Backed out changeset 335a92b1f424 (bug 1492664)
Backed out changeset c566f1c8dcdf (bug 1492664)
Backed out changeset c77ae59aba41 (bug 1492664)
Backed out changeset 9c35dd209c6b (bug 1492664)
Backed out changeset a972d6b4434e (bug 1492664)
Backed out changeset 5ea6f03f845e (bug 1492664)
Backed out changeset 0699d3873e44 (bug 1492664)

--HG--
extra : histedit_source : 5cb1f7e50f25d4a875c1a58c86b7dce902e1a89c%2C20f1ab1a843b612cfcc67cf5c6ff745d65abf076
2018-12-20 12:43:22 +02:00
Razvan Maries
f658ebcbab Merge mozilla-inbound to mozilla-central a=merge 2018-12-20 07:04:06 +02:00
Tom Prince
afa141b26c Bug 1514124: [win64-aarch64] Pass the architecture to mar generation, so that it can pass the appropriate arch flag to xz; r=aki,Callek
XZ supports rewritting addresses in executable code, which is architechture
specific. The updater is compiled with support for the target architecture
only, so we can't always compress updates passing `--x86` to XZ. This threads
the architecture through to the repackage steps, so we can pass the appropraite
flags to the update packaging scripts.

Differential Revision: https://phabricator.services.mozilla.com/D14601

--HG--
extra : moz-landing-system : lando
2018-12-17 21:45:09 +00:00
Ted Mielczarek
ca6f7a626f bug 1512499 - handle psutil returning None for physical_cores. r=froydnj
psutil has a bug on arm systems where it will return None for physical_cores:
https://github.com/giampaolo/psutil/issues/1359

This causes us to generate invalid telemetry data which raises an error. Fix
this by simply omitting the field in this case.

Differential Revision: https://phabricator.services.mozilla.com/D14969

--HG--
extra : moz-landing-system : lando
2018-12-19 15:07:11 +00:00
Nick Alexander
b1f817c8c9 Bug 1509573 - Part 0: Only compile Java via Gradle in export tier. r=chmanchester.mielczarek
This was always an accident of history: we forced export tier without
avoiding it in the libs tier.

Differential Revision: https://phabricator.services.mozilla.com/D14893

--HG--
extra : moz-landing-system : lando
2018-12-18 23:25:55 +00:00
Nick Alexander
a79bace97e Bug 1498406 - Part 1: Don't check for javac, javah, jar. r=froydnj
The build system no longer invokes these directly: they're all fetched
and invoked by Gradle and its plugins.

Differential Revision: https://phabricator.services.mozilla.com/D14287

--HG--
extra : moz-landing-system : lando
2018-12-17 23:04:14 +00:00