This patch adds two things to JsPropertyProvider:
- when provided an input which try to access an unsafe
getter properties, the function will indicate that an
unsafe getter should be invoked, with its name.
- a new boolean argument that when set to true would
invoke any unsafe getter that might be in the expression
to be completed.
For simplicity sake, the function only warns the user
of the presence of an unsafe getter when it's the last
property of the expression:
`object.myGetter.` will return that `myGetter` should be invoked
`object.myGetter.a.b.` will not (because then, a and b could
also be getters, and it's getting complex to handle both in
the function itself as in the UI).
Tests are added to ensure this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D11170
--HG--
extra : moz-landing-system : lando
Now all targets are considered as remote, so isRemote attribute is misleading.
Remote means that we are going through the RDP protocol to debug the target
and we now always do. If some callsite wants to do something special for local tabs
it is better to read target.isLocalTab attribute.
MozReview-Commit-ID: IYlj0wO02PO
Differential Revision: https://phabricator.services.mozilla.com/D11009
--HG--
extra : moz-landing-system : lando
Previously, we would always hard-code the basis-start and final-start line names first in
the grid column template used to display the minimap.
Because there may be cases where base+delta is actually negative, we cannot do that anymore.
This fixes that by removing this hard-coding and sorting the entire array of sizes before
generating the grid column template.
The test that I added is only a few lines, but to make it simpler to write, I had to
merge doc_flexbox_simple.html and doc_flexbox_specific_cases.html, which is why you are
seeing several test changed here.
Also, to make sure the test case I added would behave the same across platforms, I used the
Ahem font, which is often use in Layout tests as it only has 1 glyph that's exactly the size
of the font-size.
Differential Revision: https://phabricator.services.mozilla.com/D11175
--HG--
extra : moz-landing-system : lando
Similar to what we do from WebIDE (where we pass "webide").
Let me know if the string is ok here or if you would prefer something else.
Differential Revision: https://phabricator.services.mozilla.com/D11166
--HG--
extra : moz-landing-system : lando
The use of <iframe mozbrowser> in test_saveHeapSnapshot_e10s_01.html has
implicitly depended on the "network.disable.ipc.security" pref set to
false, which is the default for desktop and not applicable for Fennec.
With the new mobile test harness, this pref needs to be set explicitly
by the test.
Differential Revision: https://phabricator.services.mozilla.com/D7786
Depends on D10586
Adds a new `type` param to the `change` object passed from server to the client to describe the change type. For changes to rules, the client marks the whole rule as either added or removed and styles it accordingly in the Changes panel.
Change types for declarations are not used at this time, but are put in for consistency and future-proofing.
Differential Revision: https://phabricator.services.mozilla.com/D11116
--HG--
extra : moz-landing-system : lando
Depends on D10585
Renames the logChange() to logDeclarationChange() to distinguish it from the newly introduced logSelectorChange() method which tracks selector rename by logging two changes: a whole rule remove using the old selector and a whole rule insertion add using the new selector.
MozReview-Commit-ID: 9VoVMHYXumE
Differential Revision: https://phabricator.services.mozilla.com/D10586
--HG--
extra : moz-landing-system : lando
Depends on D10584
Other methods for tracking changes need to make use of the CSS rule
metadata (selector, rule index, ancestors, etc). This extracts that
logic into an accessor on the StyleRuleActor to facilitate reuse.
The CSS rule metadata will be augmented with information about a CSS
change (declarations added or removed) before being tracked.
MozReview-Commit-ID: xXec1XgUhk
Differential Revision: https://phabricator.services.mozilla.com/D10585
--HG--
extra : moz-landing-system : lando
Depends on D10582
Improves the reducer for tracking CSS changes to handle more than one
CSS declaration changed in one operation. This is a requirement for
tracking whole rule removal or whole rule addition, like it happens
when renaming a CSS selector in the Rules view.
MozReview-Commit-ID: 25pf2GRiH4D
Differential Revision: https://phabricator.services.mozilla.com/D10584
--HG--
extra : moz-landing-system : lando
This isn't strictly necessary for this patch series, but it adds an
optimization to improve performance for React rendering and solves
warnings thrown while using React in dev mode.
MozReview-Commit-ID: ujqOa9qUsd
Differential Revision: https://phabricator.services.mozilla.com/D10582
--HG--
extra : moz-landing-system : lando
In many places we were using bounds to calculate an objects dimensions but that obviously doesn't work when an object is rotated e.g.
{F588303}
Also, we were using `getBoxQuads()`, which gives the co-ordinates of the translated object. We were then applying the transform matrix to the canvas even though the coordinates came from the object **after** it was already transformed.
Anyhow, now we get the dimensions of objects as if they are not transformed and then apply the transformation matrix, which gives a great result every time.
Differential Revision: https://phabricator.services.mozilla.com/D9805
--HG--
extra : moz-landing-system : lando