EditorBase parameter of GetTextNode is unnecessary because it uses static method only. Also, we should return nsINode to reduce QI.
MozReview-Commit-ID: 3KazYFcr899
--HG--
extra : rebase_source : 092bbcc84d7c1e7174029bb90f606f3953fe8597
This change will allow the border drawing code to deal with the following
changes, which will make us no longer force the fieldset to be wider than the
legend. Without this patch, allowing the fieldset to be narrower than the
legend causes the vertical inline-start-side and inline-end-side borders of the
fieldset to paint under the legend, because the current code only modifies the
painting of the block-start-side border (the one the legend is positioned on).
This does change behavior in one situation, which the new tests test. For
relatively positioned legends, we used to use the original vertical location but
the positioned horizontal location of the legend to decide which parts of the
border to not paint. In the new setup, we use the original location for both.
I did check that this new behavior matches Chrome and Safari. Edge seems to
have our old behavior.
The only call site of CalcLengthWith() with a null style context is
CalcLengthWithInitialFont(). CalcLengthWithInitialFont() calls
CalcLengthWith() with a valid nsStyleFont and aUseProvidedRootEmSize
true, so we can get the rem unit font size from the nsStyleFont when called
from CalcLengthWithInitialFont().
MozReview-Commit-ID: A9LKfQEozaB
This is the first patch which creates a helper function to compute a line-width
value to an absolute length. With this helper, we could share the computation
for other line-width value properties, e.g., border-width, column-rule-width.
MozReview-Commit-ID: GnsmzGl5KBo
--HG--
extra : rebase_source : efe7c253b07c7d15531106f841383bd8a5ad463a
This code has been moved around several times, but it originated in bug 995704. Comments 20 and later indicate that the value was changed from 1k to 4k per review, and the code comments weren't updated.
MozReview-Commit-ID: JQjoWq1jGF9
--HG--
extra : rebase_source : f91924693645aef2d003692c8749c996d812d9fc
extra : amend_source : 9cb57f677acd1d61c78f8297d0136b6ab2f09b26
This change will allow the border drawing code to deal with the following
changes, which will make us no longer force the fieldset to be wider than the
legend. Without this patch, allowing the fieldset to be narrower than the
legend causes the vertical inline-start-side and inline-end-side borders of the
fieldset to paint under the legend, because the current code only modifies the
painting of the block-start-side border (the one the legend is positioned on).
This does change behavior in one situation, which the new tests test. For
relatively positioned legends, we used to use the original vertical location but
the positioned horizontal location of the legend to decide which parts of the
border to not paint. In the new setup, we use the original location for both.
I did check that this new behavior matches Chrome and Safari. Edge seems to
have our old behavior.
- poll all buffers when started or flushed.
- retry only for timed out.
- remove unnecessary polling
MozReview-Commit-ID: DU9vvjJkwDH
--HG--
extra : rebase_source : 54d734585e198413b2f1afbdad9b073b4e14a153