Commit Graph

5089 Commits

Author SHA1 Message Date
Nick Alexander
f049bde942 Bug 1512487 - Part 2: Add "global" lint type. r=ahal
This patch adds a global lint that only runs when a file or directory
that matches their configuration (via `extensions` and `exclude`) has
been modified or specified.

Global lints never shard into chunks; they are, by definition global
(i.e., across the entire source tree) and act on all inputs in a
single invocation.  It's up to the global lint to manage command line
sizes, etc.  Since batching is handled by the lint type but sharding
is handled by the lint roller, there's a little abstraction leak so
that the lint type can control how its invocation is sharded: the
existing `batch` member is generalized from the existing `True` and
`False` to add a new `"global"` value which disables sharding.

Differential Revision: https://phabricator.services.mozilla.com/D35275

--HG--
extra : moz-landing-system : lando
2019-08-02 20:34:09 +00:00
Nick Alexander
fd38e457ec Bug 1512487 - Part 1: Allow lints to inspect part of the build environment. r=ahal
This allows lints to "condition" themselves on having a build
environment or a specific build application.  It also adds the "name"
parameter, so that setup functions can be shared across lints.

`MozbuildObject` cannot be used as parameters to functions distributed
via multiprocessing, since they cannot be pickled (due, currently, to
internal terminal handles).  Therefore we extract just a few key
parts of the environment to expose.

Differential Revision: https://phabricator.services.mozilla.com/D35274

--HG--
extra : moz-landing-system : lando
2019-08-02 20:30:02 +00:00
Zibi Braniecki
b87d8246a9 Bug 1501886 - Migrate menubar to Fluent. r=fluent-reviewers,Pike,flod
Differential Revision: https://phabricator.services.mozilla.com/D34379

--HG--
extra : moz-landing-system : lando
2019-08-02 16:07:44 +00:00
Andreea Pavel
3b500e9fdd Backed out changeset 7a06c08bf267 (bug 1501886) for bc failures e.g. browser_window_menu_list.js on a CLOSED TREE 2019-08-02 05:44:47 +03:00
Zibi Braniecki
2a1b1da4ee Bug 1501886 - Migrate menubar to Fluent. r=fluent-reviewers,Pike,flod
Differential Revision: https://phabricator.services.mozilla.com/D34379

--HG--
extra : moz-landing-system : lando
2019-08-01 14:21:13 +00:00
Moritz Birghan
31f729e8c4 Bug 1004308 - rename BadCertServer to BadCertAndPinningServer r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D39748

--HG--
rename : security/manager/ssl/tests/unit/tlsserver/cmd/BadCertServer.cpp => security/manager/ssl/tests/unit/tlsserver/cmd/BadCertAndPinningServer.cpp
extra : moz-landing-system : lando
2019-07-31 17:06:07 +00:00
Bryce Seager van Dyk
3acd2d8056 Bug 1570352 - Make sure ensure_java correctly passes extra search dirs to which. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D40065

--HG--
extra : moz-landing-system : lando
2019-07-31 17:12:21 +00:00
Joel Maher
ea680be1a5 Bug 1569916 - run reftest/crashtest on android-hw when gfx/* files change. r=ahal
run reftest/crashtest on android-hw when gfx/* files change.

Differential Revision: https://phabricator.services.mozilla.com/D39900

--HG--
extra : moz-landing-system : lando
2019-07-31 13:43:59 +00:00
Andrew Halberstadt
d3ccaac56c Bug 1473498 - Fix Python 3 environment variables with subprocess r=glandium
On Windows in Python 2, the subprocess module requires the use of bytes with
the 'env' argument. For that reason, we would sometimes use byte strings with
'os.environ' like so:

    os.environ[b"FOO"] = b"bar"

However, this is a failure with Python 3 as 'os.environ' must only be used with
the text type. This patch creates a new 'setenv' helper that ensures we create
new environment with 'bytes' on Python 2, and 'text' on Python 3.

Differential Revision: https://phabricator.services.mozilla.com/D38237

--HG--
extra : moz-landing-system : lando
2019-07-30 21:35:53 +00:00
Johan Lorenzo
13648fa0df Bug 1563711 - Remove target.maven.zip r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D38175

--HG--
extra : moz-landing-system : lando
2019-07-30 15:35:12 +00:00
Bastien Abadie
74eca00f1f Bug 1569882 - Fix mozlint unit tests for relative path outputs, r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D39877

--HG--
extra : moz-landing-system : lando
2019-07-30 23:30:15 +00:00
Mike Hommey
0b648ba79b Bug 1569075 - Rename FileAvoidWrite mode argument. r=chmanchester
It causes confusion because it's the mode used to _read_ the overwritten
file. Make that more obvious by renaming to `readmode`.

Differential Revision: https://phabricator.services.mozilla.com/D39445

--HG--
extra : moz-landing-system : lando
2019-07-30 21:03:12 +00:00
Andi-Bogdan Postelnicu
d7d56b3178 Bug 1569880 - Report build errors during review-phase for C/C++ code. r=bastien
Differential Revision: https://phabricator.services.mozilla.com/D39843

--HG--
extra : moz-landing-system : lando
2019-07-30 07:42:18 +00:00
Bastien Abadie
cd3055975d Bug 1568771 - Output paths relative to repository in ./mach static-analysis check-coverity, r=andi
Differential Revision: https://phabricator.services.mozilla.com/D39306

--HG--
extra : moz-landing-system : lando
2019-07-30 06:44:52 +00:00
Bastien Abadie
11ff2f61f3 Bug 1568484 - Output issues relative paths in mozlint, r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D39162

--HG--
extra : moz-landing-system : lando
2019-07-26 15:39:17 +00:00
James Willcox
3076806612 Bug 1561323 - Fix spurious reconfigure problem with debug builds r=nalexander,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D39701

--HG--
extra : moz-landing-system : lando
2019-07-29 16:49:17 +00:00
Edwin Gao
a1cc4534a7 Bug 1519369 - support 'debugger' parser argument for mach test command r=ahal,gbrown
Differential Revision: https://phabricator.services.mozilla.com/D39229

--HG--
extra : moz-landing-system : lando
2019-07-26 15:18:18 +00:00
Mike Hommey
177a9940a7 Bug 1568713 - Do some sanity checks on FileAvoidWrite inputs. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D39271

--HG--
extra : moz-landing-system : lando
2019-07-25 22:49:21 +00:00
Makoto Kato
e4d28810e5 Bug 774115 - Support mach bootstrap on Windows for Android. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D33584

--HG--
extra : moz-landing-system : lando
2019-07-25 09:29:10 +00:00
Bastien Abadie
6621e16e02 Bug 1568535 - Output relative paths in mach static-analysis check, r=andi
Differential Revision: https://phabricator.services.mozilla.com/D39197

--HG--
extra : moz-landing-system : lando
2019-07-25 08:50:50 +00:00
Bastien Abadie
08c32bbebe Bug 1568558 - Output paths relative to repository in ./mach clang-format, r=andi
Differential Revision: https://phabricator.services.mozilla.com/D39211

--HG--
extra : moz-landing-system : lando
2019-07-25 08:50:33 +00:00
Mike Shal
1c560ed0f2 Bug 1567619 - Avoid double stat in preprocessed file installs; r=glandium
Followup to bug 1566044.

Differential Revision: https://phabricator.services.mozilla.com/D38763

--HG--
extra : moz-landing-system : lando
2019-07-23 03:03:36 +00:00
Mike Hommey
6a8d20b0cc Bug 1564216 - Require clang 5 for OSX builds. r=froydnj
There is less incentive to keep things building with older versions of
clang for OSX builds, and we're going to require an objective-C feature
that was added in clang 5.

Differential Revision: https://phabricator.services.mozilla.com/D38581

--HG--
extra : moz-landing-system : lando
2019-07-22 21:31:39 +00:00
Simon Sapin
0540fe3688 Bug 1565193 - Require Rust 1.36 r=glandium
MozReview-Commit-ID: GjcKBjZvTPr

Differential Revision: https://phabricator.services.mozilla.com/D37709

--HG--
extra : moz-landing-system : lando
2019-07-19 04:50:22 +00:00
Agi Sferro
d0cb127dad Bug 1515248 - Upgrade to Android-Gradle plugin 3.2.1 and build-tools 28.0.3. r=agi
Differential Revision: https://phabricator.services.mozilla.com/D15159

--HG--
extra : moz-landing-system : lando
2019-07-20 17:27:53 +00:00
Edwin Gao
bf3cb1ec8b Bug 1559975 - fix python2 linter errors for python/devtools r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D37640

--HG--
extra : moz-landing-system : lando
2019-07-16 17:46:08 +00:00
Mike Shal
4e0a8ed2b5 Bug 1566044 - Missing inputs in install manifests should trigger updates; r=nalexander
The preprocessed install manifest code uses a Makefile dependency file
to list inputs. If one of the inputs was missing (due to a file removal
or rename), an incremental build would fail until clobbered. We should
treat a missing input as simply being out-of-date and continue
processing.

Differential Revision: https://phabricator.services.mozilla.com/D38576

--HG--
extra : moz-landing-system : lando
2019-07-18 22:40:57 +00:00
Andrew Halberstadt
9c1c973edf Bug 1473498 - [mach] Fix Py3 compatibility issues in telemetry.py r=firefox-build-system-reviewers,chmanchester
Depends on D36104

Differential Revision: https://phabricator.services.mozilla.com/D38193

--HG--
extra : moz-landing-system : lando
2019-07-16 20:53:18 +00:00
Andrew Halberstadt
4e06e1101d Bug 1473498 - [mach] Fix Python 3 decorator compatibility r=firefox-build-system-reviewers,chmanchester
Differential Revision: https://phabricator.services.mozilla.com/D36104

--HG--
extra : moz-landing-system : lando
2019-07-16 20:42:34 +00:00
Chris Manchester
c418bfd3d5 Bug 1566219 - Provide dist-toolchains for use with sccache in bootstrap on macOS. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D38151

--HG--
extra : moz-landing-system : lando
2019-07-16 18:50:59 +00:00
Andrew Halberstadt
63b68be0e1 Bug 1473498 - Fix Py3 compatibility issue in python/mozbuild/mozbuild/testing.py r=nalexander
Depends on D37763

Differential Revision: https://phabricator.services.mozilla.com/D37764

--HG--
extra : moz-landing-system : lando
2019-07-16 15:14:49 +00:00
Mike Hommey
5bfb4c9c92 Bug 1564314 - Make linters happy with the gdbpp code. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D37676

--HG--
extra : moz-landing-system : lando
2019-07-11 18:19:44 +00:00
Mike Hommey
f7f0525dc1 Bug 1564314 - Move gdbpp back to python/. r=nalexander
Somehow bug 1346025 moved it to third_party/python but... it's not third
party code.

Differential Revision: https://phabricator.services.mozilla.com/D37364

--HG--
rename : third_party/python/gdbpp/gdbpp/__init__.py => python/gdbpp/gdbpp/__init__.py
rename : third_party/python/gdbpp/gdbpp/enumset.py => python/gdbpp/gdbpp/enumset.py
rename : third_party/python/gdbpp/gdbpp/linkedlist.py => python/gdbpp/gdbpp/linkedlist.py
rename : third_party/python/gdbpp/gdbpp/owningthread.py => python/gdbpp/gdbpp/owningthread.py
rename : third_party/python/gdbpp/gdbpp/smartptr.py => python/gdbpp/gdbpp/smartptr.py
rename : third_party/python/gdbpp/gdbpp/string.py => python/gdbpp/gdbpp/string.py
rename : third_party/python/gdbpp/gdbpp/tarray.py => python/gdbpp/gdbpp/tarray.py
rename : third_party/python/gdbpp/gdbpp/thashtable.py => python/gdbpp/gdbpp/thashtable.py
extra : moz-landing-system : lando
2019-07-11 02:39:31 +00:00
Tom Prince
2208f1c2cf Bug 1458385: Generate MARs with the appropriate channel-id explicitly; r=nthomas
Rather than relying on the mar-channel-id set in the `mar` binary, set the channel
explicitly from taskcluster. This allows us to re-use the `mar` binary between
builds/channels.

Differential Revision: https://phabricator.services.mozilla.com/D37481

--HG--
extra : moz-landing-system : lando
2019-07-11 16:40:13 +00:00
Andrew Halberstadt
1190fb0269 Bug 1563797 - Use 'backports.shutil_which' instead of 'which' in the build system r=firefox-build-system-reviewers,chmanchester
Credit: Callek for figuring out an issue in 'make check' making the binary
absolute in mozbuild.base.

Differential Revision: https://phabricator.services.mozilla.com/D37319

--HG--
extra : moz-landing-system : lando
2019-07-11 14:04:39 +00:00
Andrew Halberstadt
3486ba642c Bug 1563797 - Use 'backports.shutil_which' instead of 'which' across the tree r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D37097

--HG--
extra : moz-landing-system : lando
2019-07-11 14:03:39 +00:00
Victor Porof
9350016346 Bug 1564824 - Format source fails with Prettier on patches with moved files where the original directory also does not exist, r=andi
Differential Revision: https://phabricator.services.mozilla.com/D37537

--HG--
extra : moz-landing-system : lando
2019-07-10 11:15:18 +00:00
Andreea Pavel
a35fc693c4 Backed out changeset fa94c9a03e3f (bug 1564314) for linting failures on a CLOSED TREE
--HG--
rename : python/gdbpp/gdbpp/__init__.py => third_party/python/gdbpp/gdbpp/__init__.py
rename : python/gdbpp/gdbpp/enumset.py => third_party/python/gdbpp/gdbpp/enumset.py
rename : python/gdbpp/gdbpp/linkedlist.py => third_party/python/gdbpp/gdbpp/linkedlist.py
rename : python/gdbpp/gdbpp/owningthread.py => third_party/python/gdbpp/gdbpp/owningthread.py
rename : python/gdbpp/gdbpp/smartptr.py => third_party/python/gdbpp/gdbpp/smartptr.py
rename : python/gdbpp/gdbpp/string.py => third_party/python/gdbpp/gdbpp/string.py
rename : python/gdbpp/gdbpp/tarray.py => third_party/python/gdbpp/gdbpp/tarray.py
rename : python/gdbpp/gdbpp/thashtable.py => third_party/python/gdbpp/gdbpp/thashtable.py
2019-07-10 10:12:34 +03:00
Mike Hommey
2f3833c4b3 Bug 1564314 - Move gdbpp back to python/. r=nalexander
Somehow bug 1346025 moved it to third_party/python but... it's not third
party code.

Differential Revision: https://phabricator.services.mozilla.com/D37364

--HG--
rename : third_party/python/gdbpp/gdbpp/__init__.py => python/gdbpp/gdbpp/__init__.py
rename : third_party/python/gdbpp/gdbpp/enumset.py => python/gdbpp/gdbpp/enumset.py
rename : third_party/python/gdbpp/gdbpp/linkedlist.py => python/gdbpp/gdbpp/linkedlist.py
rename : third_party/python/gdbpp/gdbpp/owningthread.py => python/gdbpp/gdbpp/owningthread.py
rename : third_party/python/gdbpp/gdbpp/smartptr.py => python/gdbpp/gdbpp/smartptr.py
rename : third_party/python/gdbpp/gdbpp/string.py => python/gdbpp/gdbpp/string.py
rename : third_party/python/gdbpp/gdbpp/tarray.py => python/gdbpp/gdbpp/tarray.py
rename : third_party/python/gdbpp/gdbpp/thashtable.py => python/gdbpp/gdbpp/thashtable.py
extra : moz-landing-system : lando
2019-07-09 16:09:14 +00:00
Mike Hommey
20ee1b2284 Bug 1563158 - Properly handle imply_option dependency loops when when is involved. r=chmanchester
This is an extension of the relaxation added in bug 1529799.

Differential Revision: https://phabricator.services.mozilla.com/D36716

--HG--
extra : moz-landing-system : lando
2019-07-09 22:04:01 +00:00
Makoto Kato
ecd47d34f4 Bug 1562389 - Better detect non-clang-cl native windows clang. r=glandium
When building Gecko/Android/aarch64 on Windows, `--target` parameter may not be incorrect value. Although `check_compiler`'s `info` is target compiler, clang on Windows is always detected as `clang-cl`, not `clang`.

```
c:/Users/mkato/.mozbuild/clang/bin/clang.exe -E  -dM - < /dev/null
...
#define _MSC_VER 1916
```

So even if using clang on Windows, not clang-cl, we should detect as 'clang' correctly

Differential Revision: https://phabricator.services.mozilla.com/D36422

--HG--
extra : moz-landing-system : lando
2019-07-08 10:35:40 +00:00
Justin Wood
4b233fe605 Bug 1559975 - Make python/mach lint with 'py2' and 'py3' r=catlee
Depends on D36096

Differential Revision: https://phabricator.services.mozilla.com/D36099

--HG--
extra : moz-landing-system : lando
2019-07-05 14:24:58 +00:00
Justin Wood
939e67a089 Bug 1559975 - Make python/mozbuild lint with 'py2' and 'py3' r=catlee
Differential Revision: https://phabricator.services.mozilla.com/D36090

--HG--
extra : moz-landing-system : lando
2019-07-05 14:36:43 +00:00
Victor Porof
fc0105c226 Bug 1556393 - Pre 0 (m-c): Create a simple Prettier command for running format-source, r=andi
Differential Revision: https://phabricator.services.mozilla.com/D36720

--HG--
extra : source : c168aefc21dfec8a1935272201592f3781df07b0
extra : intermediate-source : 008847a148cfd171e6e23425be5d6876c6174ef0
2019-07-04 14:50:20 +02:00
Andi-Bogdan Postelnicu
d2e65163f9 Bug 1563326 - for code-analysis target do not globally import PackageFrontend. r=sylvestre
By globally importing PackageFrontend from the globe-analysis module we break the logger for
the PackageFrontend package.

Differential Revision: https://phabricator.services.mozilla.com/D36887

--HG--
extra : moz-landing-system : lando
2019-07-04 11:42:16 +00:00
Ed Lee
475d41e647 Bug 1563243 - Add optimistic images, string robustness and bug fixes to New Tab Page r=pdahiya,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D36764

--HG--
extra : moz-landing-system : lando
2019-07-03 23:49:07 +00:00
Mike Hommey
7256ffeb9b Bug 1560044 - Always use a SDK path on macOS. r=nalexander
The SDK headers may not be installed in /usr/include. The usual response
has been to have people run e.g. `open
/Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg`
which is not really sustainable.

This makes builds that happen on a macOS host try to detect their SDK
and use that as a default for --with-macos-sdk, which has the side
effect of enabling the SDK version check in that configuration.

Differential Revision: https://phabricator.services.mozilla.com/D36558

--HG--
extra : moz-landing-system : lando
2019-07-03 22:11:05 +00:00
Francesco Lodolo (:flod)
e14e57c33f Bug 1563216 - Remove Fluent migration recipes for Firefox 68 r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D36754

--HG--
extra : moz-landing-system : lando
2019-07-03 13:36:06 +00:00
Andrew Halberstadt
1a58163ed7 Bug 1473498 - [mach] Enable test_logger with Python 3 r=firefox-build-system-reviewers,chmanchester
Depends on D36101

Differential Revision: https://phabricator.services.mozilla.com/D36102

--HG--
extra : moz-landing-system : lando
2019-07-02 20:59:46 +00:00
Andrew Halberstadt
3f6339271d Bug 1473498 - [mach] Enable test_config with Python 3 r=firefox-build-system-reviewers,chmanchester
Depends on D36100

Differential Revision: https://phabricator.services.mozilla.com/D36101

--HG--
extra : moz-landing-system : lando
2019-07-02 20:59:03 +00:00