Commit Graph

84 Commits

Author SHA1 Message Date
J. Ryan Stinnett
c2bd027ba3 Bug 1326479 - Update ESLint to 3.12.2. r=jaws
MozReview-Commit-ID: 472UvTOhP2R

--HG--
extra : rebase_source : 2bc3cd4cd451a61a49d5059430ae4ed9c6d1496f
2016-12-30 15:23:15 -06:00
Mark Banner
071c48e792 Bug 1325374 - Specify more globals in browser.js/nsBrowserGlue.js, and start fixing up some of places. r=mossop
MozReview-Commit-ID: C22lTfaUzHB

--HG--
extra : rebase_source : 8d186d18814a84363ebf2657dd7584a26edd845f
2016-12-22 12:14:05 +00:00
Mark Banner
59a8c923af Bug 1325339 - tools/lint/eslint/eslint-plugin-mozilla isn't being linted. r=mossop
MozReview-Commit-ID: ImgANPcndoF

--HG--
extra : rebase_source : 0eb85c185d907ac9c07ba26662f60dbb81511610
2016-12-22 10:53:51 +00:00
Cykesiopka
25866904e6 Bug 1322914 - Enable flake8 linting for security/manager. r=mgoodwin
Various non-conformant B2G related files are simply ignored, since it's not
worth the time to update them to conform.

MozReview-Commit-ID: 5QMbg5pHSbn

--HG--
extra : rebase_source : a133549edc619c2c4fd1d002070d563a145be0d9
2016-12-13 00:25:45 +08:00
Ethan Glasser-Camp
8c71fbb490 Bug 1319884 - Leftover cleanups, r=MattN
I didn't realize this file was here when I updated kinto.js to 6.0.0.

MozReview-Commit-ID: 4G1cplpz4r5

--HG--
extra : rebase_source : 228ce612db2c7d648d82b541f9b01a4e96e285b4
2016-11-23 14:22:44 -05:00
Henrik Skupin
39b88340ad Bug 1319705 - Move Puppeteer to testing/marionette and make it available for Marionette tests in test packages. r=gps
MozReview-Commit-ID: 521o0fV72SQ

--HG--
rename : testing/puppeteer/.flake8 => testing/marionette/puppeteer/.flake8
rename : testing/puppeteer/firefox/MANIFEST.in => testing/marionette/puppeteer/firefox/MANIFEST.in
rename : testing/puppeteer/firefox/docs/Makefile => testing/marionette/puppeteer/firefox/docs/Makefile
rename : testing/puppeteer/firefox/docs/api/appinfo.rst => testing/marionette/puppeteer/firefox/docs/api/appinfo.rst
rename : testing/puppeteer/firefox/docs/api/keys.rst => testing/marionette/puppeteer/firefox/docs/api/keys.rst
rename : testing/puppeteer/firefox/docs/api/l10n.rst => testing/marionette/puppeteer/firefox/docs/api/l10n.rst
rename : testing/puppeteer/firefox/docs/api/places.rst => testing/marionette/puppeteer/firefox/docs/api/places.rst
rename : testing/puppeteer/firefox/docs/api/prefs.rst => testing/marionette/puppeteer/firefox/docs/api/prefs.rst
rename : testing/puppeteer/firefox/docs/api/security.rst => testing/marionette/puppeteer/firefox/docs/api/security.rst
rename : testing/puppeteer/firefox/docs/api/software_update.rst => testing/marionette/puppeteer/firefox/docs/api/software_update.rst
rename : testing/puppeteer/firefox/docs/api/utils.rst => testing/marionette/puppeteer/firefox/docs/api/utils.rst
rename : testing/puppeteer/firefox/docs/conf.py => testing/marionette/puppeteer/firefox/docs/conf.py
rename : testing/puppeteer/firefox/docs/index.rst => testing/marionette/puppeteer/firefox/docs/index.rst
rename : testing/puppeteer/firefox/docs/make.bat => testing/marionette/puppeteer/firefox/docs/make.bat
rename : testing/puppeteer/firefox/docs/ui/about_window/window.rst => testing/marionette/puppeteer/firefox/docs/ui/about_window/window.rst
rename : testing/puppeteer/firefox/docs/ui/browser/notifications.rst => testing/marionette/puppeteer/firefox/docs/ui/browser/notifications.rst
rename : testing/puppeteer/firefox/docs/ui/browser/tabbar.rst => testing/marionette/puppeteer/firefox/docs/ui/browser/tabbar.rst
rename : testing/puppeteer/firefox/docs/ui/browser/toolbars.rst => testing/marionette/puppeteer/firefox/docs/ui/browser/toolbars.rst
rename : testing/puppeteer/firefox/docs/ui/browser/window.rst => testing/marionette/puppeteer/firefox/docs/ui/browser/window.rst
rename : testing/puppeteer/firefox/docs/ui/deck.rst => testing/marionette/puppeteer/firefox/docs/ui/deck.rst
rename : testing/puppeteer/firefox/docs/ui/menu.rst => testing/marionette/puppeteer/firefox/docs/ui/menu.rst
rename : testing/puppeteer/firefox/docs/ui/pageinfo/window.rst => testing/marionette/puppeteer/firefox/docs/ui/pageinfo/window.rst
rename : testing/puppeteer/firefox/docs/ui/update_wizard/dialog.rst => testing/marionette/puppeteer/firefox/docs/ui/update_wizard/dialog.rst
rename : testing/puppeteer/firefox/docs/ui/windows.rst => testing/marionette/puppeteer/firefox/docs/ui/windows.rst
rename : testing/puppeteer/firefox/firefox_puppeteer/__init__.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/__init__.py
rename : testing/puppeteer/firefox/firefox_puppeteer/api/__init__.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/api/__init__.py
rename : testing/puppeteer/firefox/firefox_puppeteer/api/appinfo.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/api/appinfo.py
rename : testing/puppeteer/firefox/firefox_puppeteer/api/keys.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/api/keys.py
rename : testing/puppeteer/firefox/firefox_puppeteer/api/l10n.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/api/l10n.py
rename : testing/puppeteer/firefox/firefox_puppeteer/api/places.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/api/places.py
rename : testing/puppeteer/firefox/firefox_puppeteer/api/prefs.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/api/prefs.py
rename : testing/puppeteer/firefox/firefox_puppeteer/api/security.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/api/security.py
rename : testing/puppeteer/firefox/firefox_puppeteer/api/software_update.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/api/software_update.py
rename : testing/puppeteer/firefox/firefox_puppeteer/api/utils.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/api/utils.py
rename : testing/puppeteer/firefox/firefox_puppeteer/base.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/base.py
rename : testing/puppeteer/firefox/firefox_puppeteer/decorators.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/decorators.py
rename : testing/puppeteer/firefox/firefox_puppeteer/errors.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/errors.py
rename : testing/puppeteer/firefox/firefox_puppeteer/mixins.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/mixins.py
rename : testing/puppeteer/firefox/firefox_puppeteer/puppeteer.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/puppeteer.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/__init__.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/__init__.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/about_window/__init__.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/about_window/__init__.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/about_window/deck.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/about_window/deck.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/about_window/window.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/about_window/window.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/base.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/base.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/browser/__init__.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/browser/__init__.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/browser/notifications.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/browser/notifications.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/browser/tabbar.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/browser/tabbar.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/browser/toolbars.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/browser/toolbars.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/browser/window.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/browser/window.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/deck.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/deck.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/menu.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/menu.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/pageinfo/__init__.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/pageinfo/__init__.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/pageinfo/deck.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/pageinfo/deck.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/pageinfo/window.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/pageinfo/window.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/update_wizard/__init__.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/update_wizard/__init__.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/update_wizard/dialog.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/update_wizard/dialog.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/update_wizard/wizard.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/update_wizard/wizard.py
rename : testing/puppeteer/firefox/firefox_puppeteer/ui/windows.py => testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/windows.py
rename : testing/puppeteer/firefox/requirements-docs.txt => testing/marionette/puppeteer/firefox/requirements-docs.txt
rename : testing/puppeteer/firefox/requirements.txt => testing/marionette/puppeteer/firefox/requirements.txt
rename : testing/puppeteer/firefox/setup.py => testing/marionette/puppeteer/firefox/setup.py
extra : rebase_source : 2c34436c2669cab33d7d3b3f2b23c46c7d3a27d7
2016-11-24 17:02:52 +01:00
Ehsan Akhgari
f0f85366d9 Bug 1318218 - Remove PermissionsTable; r=baku,jryans
This also removes the WebIDE UI for viewing the permissions table.
2016-11-18 08:59:35 -05:00
Ehsan Akhgari
d07f79a266 Bug 1318210 - Remove nsIAppsService; r=baku 2016-11-17 10:41:36 -05:00
Ehsan Akhgari
354db69f04 Bug 1318207 - Remove Navigator.mozPermissionSettings; r=baku 2016-11-17 09:19:13 -05:00
Mark Banner
baa174d6e7 Bug 1228761 - 'mach eslint' should look for 'nodejs' as well as 'node' executables to better support linux. r=ahal
MozReview-Commit-ID: 768u0MyMWA0

--HG--
extra : rebase_source : 3d9b430887a612864c0295f4dd53918a40ab84f9
2016-11-11 17:15:40 +00:00
Carsten "Tomcat" Book
4b6cab91f9 merge mozilla-inbound to mozilla-central a=merge 2016-11-10 16:59:38 +01:00
Dave Townsend
baee0ed159 Bug 1315402: Detect more head files for tests automatically. r=standard8, r=jryans
Some test files aren't named according to the standard style so this attempts
to first detect test files by loading the test manifest files in the directory
and matching the filename to sections in them. Any file listed in a manifest is
considered to be a test. It still falls back to filename matching if no manifest
could be found, particularly in the event the manifest has a strange name and
we can't identify the test type from it.

The manifests for a directory are cached to speed up checking when linting
multiple files in the same directory.

MozReview-Commit-ID: 91bxOeZZcKa

--HG--
extra : rebase_source : 18190110a14083aead00cd9e6bbd9c5a6a264bff
2016-11-04 15:46:07 -07:00
Jared Wein
5bb7b57b66 Bug 1316096 - Change eslint configuration to use string values for rules instead of integers, making it easier for others who are reading the rules to know if a rule is set to off, warn, or error. r=mossop
MozReview-Commit-ID: 2Xuj5nxuQdO

--HG--
extra : rebase_source : fab5c4903b47d48080ff3c07825440e12f718698
2016-11-08 15:14:19 -05:00
Phil Ringnalda
393b414467 Merge m-i to m-c, a=merge
MozReview-Commit-ID: 48WAQwKUCpw
2016-11-02 19:28:38 -07:00
Andrew Halberstadt
8a863b62f5 Bug 1313956 - Upgrade ESLint to 3.8.1 for improved async/await support, r=miker
MozReview-Commit-ID: 5iRwM1aUdJE

--HG--
extra : rebase_source : 2a34073569d8fa70bcafe6a88666a67bb8164d2f
2016-10-30 18:33:27 -07:00
Wes Kocher
df5dbf81cc Merge central to inbound a=merge 2016-11-02 17:31:08 -07:00
Sebastian Hengst
a8f157b8d8 Backed out changeset c88863b64010 (bug 1312355) for eslint bustage. r=backout 2016-11-01 20:43:18 +01:00
Dave Townsend
f137514b8d Bug 1312355: Use a fixed lookup table for variables imported from JS modules. r=standard8
MozReview-Commit-ID: EhKhBvAAlXd

--HG--
extra : rebase_source : f114924e8fa6464e6f4f82730773e8f78fcbcde4
2016-11-01 12:24:04 -07:00
Mark Banner
f7fca8642f Bug 1240165 - Expand the eslint rule 'mark-test-function-used' to cover xpcshell tests as well as gecko tests and apply to the whole tree. r=miker
MozReview-Commit-ID: FlbJ8yzWXlw

--HG--
extra : rebase_source : 3f9a2997b36ef8f019e38e4af61a0c44e0e7283c
2016-10-26 09:46:40 +01:00
Francesco Pischedda
78c3624c28 Bug 1285555 - [flake8] Automatically install/update flake8 package to correct version r=ahal
Changed flake8 installation strategy, try to update it using testings/lint/flake8_requirements.txt
moved flake8_requirements to tools/lint/flake8 directory
extracted common pip invocations to _run_pip function
minor fixes
fixed calls to check_process (concatenating list to tuple)
removed update_pip function and its error message variable
if flake8 installation reports and error print pip command output - replaced out with e.output in print function

MozReview-Commit-ID: Fmq22aL8dMq

--HG--
extra : rebase_source : 2e2f942c1ffab012795c632ceacf6debf0dc1407
2016-10-15 09:45:22 +02:00
Eric Rahm
c15406fea3 Bug 1312143 - Delete toolkit/obsolete. r=John-Galt
This removes the obsolete toolkit directory. A few references to dialogOverlay
have been updated to just used <dialog> directly. The InlineSpellCheckerUI var
has also been moved directly to browser.js and defined as lazy getter.

MozReview-Commit-ID: JZfi0W2wqCL
2016-10-24 18:23:24 -07:00
Philipp Kewisch
602501b0f2 Bug 1303871 - Lines generated by xbl preprocessor can cause various rule incompatibilities. r=miker
MozReview-Commit-ID: 5x63vEptBIn

--HG--
extra : rebase_source : 8f82acf97dfc1b0587a8ecdadcccad4bfeb2dce4
2016-09-20 11:34:40 +02:00
Philipp Kewisch
4ceb6d2129 Bug 1280883 - Avoid effects of ASI when preprocessing XBL for eslint. r=miker
MozReview-Commit-ID: KozbJCGIpFo

--HG--
extra : rebase_source : bd0fa2ff793391f0100b0310fa4f5d1680241e33
2016-09-19 11:33:26 +02:00
Mark Banner
56a7b3961a Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop
MozReview-Commit-ID: JrbFxQ5rj6I

--HG--
rename : .eslintrc => .eslintrc.js
rename : accessible/.eslintrc => accessible/.eslintrc.js
rename : accessible/tests/browser/.eslintrc => accessible/tests/browser/.eslintrc.js
rename : browser/.eslintrc => browser/.eslintrc.js
rename : browser/base/content/test/alerts/.eslintrc => browser/base/content/test/alerts/.eslintrc.js
rename : browser/base/content/test/chrome/.eslintrc => browser/base/content/test/chrome/.eslintrc.js
rename : browser/base/content/test/general/.eslintrc => browser/base/content/test/general/.eslintrc.js
rename : browser/base/content/test/newtab/.eslintrc => browser/base/content/test/newtab/.eslintrc.js
rename : browser/base/content/test/plugins/.eslintrc => browser/base/content/test/plugins/.eslintrc.js
rename : browser/base/content/test/popupNotifications/.eslintrc => browser/base/content/test/popupNotifications/.eslintrc.js
rename : browser/base/content/test/referrer/.eslintrc => browser/base/content/test/referrer/.eslintrc.js
rename : browser/base/content/test/social/.eslintrc => browser/base/content/test/social/.eslintrc.js
rename : browser/components/contextualidentity/test/browser/.eslintrc => browser/components/contextualidentity/test/browser/.eslintrc.js
rename : browser/components/customizableui/test/.eslintrc => browser/components/customizableui/test/.eslintrc.js
rename : browser/components/dirprovider/tests/unit/.eslintrc => browser/components/dirprovider/tests/unit/.eslintrc.js
rename : browser/components/downloads/test/browser/.eslintrc => browser/components/downloads/test/browser/.eslintrc.js
rename : browser/components/downloads/test/unit/.eslintrc => browser/components/downloads/test/unit/.eslintrc.js
rename : browser/components/extensions/.eslintrc => browser/components/extensions/.eslintrc.js
rename : browser/components/extensions/test/browser/.eslintrc => browser/components/extensions/test/browser/.eslintrc.js
rename : browser/components/extensions/test/xpcshell/.eslintrc => browser/components/extensions/test/xpcshell/.eslintrc.js
rename : browser/components/feeds/test/.eslintrc => browser/components/feeds/test/.eslintrc.js
rename : browser/components/feeds/test/chrome/.eslintrc => browser/components/feeds/test/chrome/.eslintrc.js
rename : browser/components/feeds/test/unit/.eslintrc => browser/components/feeds/test/unit/.eslintrc.js
rename : browser/components/migration/tests/unit/.eslintrc => browser/components/migration/tests/unit/.eslintrc.js
rename : browser/components/newtab/tests/browser/.eslintrc => browser/components/newtab/tests/browser/.eslintrc.js
rename : browser/components/newtab/tests/xpcshell/.eslintrc => browser/components/newtab/tests/xpcshell/.eslintrc.js
rename : browser/components/originattributes/test/browser/.eslintrc => browser/components/originattributes/test/browser/.eslintrc.js
rename : browser/components/places/tests/browser/.eslintrc => browser/components/places/tests/browser/.eslintrc.js
rename : browser/components/places/tests/chrome/.eslintrc => browser/components/places/tests/chrome/.eslintrc.js
rename : browser/components/places/tests/unit/.eslintrc => browser/components/places/tests/unit/.eslintrc.js
rename : browser/components/preferences/in-content/tests/.eslintrc => browser/components/preferences/in-content/tests/.eslintrc.js
rename : browser/components/privatebrowsing/test/browser/.eslintrc => browser/components/privatebrowsing/test/browser/.eslintrc.js
rename : browser/components/safebrowsing/content/test/.eslintrc => browser/components/safebrowsing/content/test/.eslintrc.js
rename : browser/components/search/test/.eslintrc => browser/components/search/test/.eslintrc.js
rename : browser/components/selfsupport/test/.eslintrc => browser/components/selfsupport/test/.eslintrc.js
rename : browser/components/sessionstore/test/.eslintrc => browser/components/sessionstore/test/.eslintrc.js
rename : browser/components/sessionstore/test/unit/.eslintrc => browser/components/sessionstore/test/unit/.eslintrc.js
rename : browser/components/shell/test/.eslintrc => browser/components/shell/test/.eslintrc.js
rename : browser/components/shell/test/unit/.eslintrc => browser/components/shell/test/unit/.eslintrc.js
rename : browser/components/tests/browser/.eslintrc => browser/components/tests/browser/.eslintrc.js
rename : browser/components/translation/test/.eslintrc => browser/components/translation/test/.eslintrc.js
rename : browser/components/translation/test/unit/.eslintrc => browser/components/translation/test/unit/.eslintrc.js
rename : browser/components/uitour/test/.eslintrc => browser/components/uitour/test/.eslintrc.js
rename : browser/experiments/test/xpcshell/.eslintrc => browser/experiments/test/xpcshell/.eslintrc.js
rename : browser/extensions/formautofill/.eslintrc => browser/extensions/formautofill/.eslintrc.js
rename : browser/extensions/formautofill/test/browser/.eslintrc => browser/extensions/formautofill/test/browser/.eslintrc.js
rename : browser/extensions/pdfjs/test/.eslintrc => browser/extensions/pdfjs/test/.eslintrc.js
rename : browser/modules/test/.eslintrc => browser/modules/test/.eslintrc.js
rename : browser/modules/test/unit/social/.eslintrc => browser/modules/test/unit/social/.eslintrc.js
rename : browser/modules/test/xpcshell/.eslintrc => browser/modules/test/xpcshell/.eslintrc.js
rename : devtools/.eslintrc => devtools/.eslintrc.js
rename : devtools/.eslintrc.mochitests => devtools/.eslintrc.mochitests.js
rename : devtools/.eslintrc.xpcshell => devtools/.eslintrc.xpcshell.js
rename : devtools/client/aboutdebugging/test/.eslintrc => devtools/client/aboutdebugging/test/.eslintrc.js
rename : devtools/client/animationinspector/test/.eslintrc => devtools/client/animationinspector/test/.eslintrc.js
rename : devtools/client/animationinspector/test/unit/.eslintrc => devtools/client/animationinspector/test/unit/.eslintrc.js
rename : devtools/client/canvasdebugger/test/.eslintrc => devtools/client/canvasdebugger/test/.eslintrc.js
rename : devtools/client/commandline/test/.eslintrc => devtools/client/commandline/test/.eslintrc.js
rename : devtools/client/debugger/new/test/mochitest/.eslintrc => devtools/client/debugger/new/test/mochitest/.eslintrc.js
rename : devtools/client/debugger/test/.eslintrc => devtools/client/debugger/test/.eslintrc.js
rename : devtools/client/dom/.eslintrc => devtools/client/dom/.eslintrc.js
rename : devtools/client/dom/test/.eslintrc => devtools/client/dom/test/.eslintrc.js
rename : devtools/client/framework/test/.eslintrc => devtools/client/framework/test/.eslintrc.js
rename : devtools/client/inspector/.eslintrc => devtools/client/inspector/.eslintrc.js
rename : devtools/client/inspector/components/test/.eslintrc => devtools/client/inspector/components/test/.eslintrc.js
rename : devtools/client/inspector/computed/test/.eslintrc => devtools/client/inspector/computed/test/.eslintrc.js
rename : devtools/client/inspector/fonts/test/.eslintrc => devtools/client/inspector/fonts/test/.eslintrc.js
rename : devtools/client/inspector/markup/test/.eslintrc => devtools/client/inspector/markup/test/.eslintrc.js
rename : devtools/client/inspector/rules/test/.eslintrc => devtools/client/inspector/rules/test/.eslintrc.js
rename : devtools/client/inspector/shared/test/.eslintrc => devtools/client/inspector/shared/test/.eslintrc.js
rename : devtools/client/inspector/test/.eslintrc => devtools/client/inspector/test/.eslintrc.js
rename : devtools/client/jsonview/.eslintrc => devtools/client/jsonview/.eslintrc.js
rename : devtools/client/jsonview/test/.eslintrc => devtools/client/jsonview/test/.eslintrc.js
rename : devtools/client/memory/test/browser/.eslintrc => devtools/client/memory/test/browser/.eslintrc.js
rename : devtools/client/memory/test/unit/.eslintrc => devtools/client/memory/test/unit/.eslintrc.js
rename : devtools/client/netmonitor/.eslintrc => devtools/client/netmonitor/.eslintrc.js
rename : devtools/client/netmonitor/har/test/.eslintrc => devtools/client/netmonitor/har/test/.eslintrc.js
rename : devtools/client/netmonitor/test/.eslintrc => devtools/client/netmonitor/test/.eslintrc.js
rename : devtools/client/performance/test/.eslintrc => devtools/client/performance/test/.eslintrc.js
rename : devtools/client/performance/test/unit/.eslintrc => devtools/client/performance/test/unit/.eslintrc.js
rename : devtools/client/projecteditor/test/.eslintrc => devtools/client/projecteditor/test/.eslintrc.js
rename : devtools/client/promisedebugger/test/.eslintrc => devtools/client/promisedebugger/test/.eslintrc.js
rename : devtools/client/responsive.html/test/browser/.eslintrc => devtools/client/responsive.html/test/browser/.eslintrc.js
rename : devtools/client/responsive.html/test/unit/.eslintrc => devtools/client/responsive.html/test/unit/.eslintrc.js
rename : devtools/client/responsivedesign/test/.eslintrc => devtools/client/responsivedesign/test/.eslintrc.js
rename : devtools/client/scratchpad/test/.eslintrc => devtools/client/scratchpad/test/.eslintrc.js
rename : devtools/client/shadereditor/test/.eslintrc => devtools/client/shadereditor/test/.eslintrc.js
rename : devtools/client/shared/components/.eslintrc => devtools/client/shared/components/.eslintrc.js
rename : devtools/client/shared/components/test/browser/.eslintrc => devtools/client/shared/components/test/browser/.eslintrc.js
rename : devtools/client/shared/components/test/mochitest/.eslintrc => devtools/client/shared/components/test/mochitest/.eslintrc.js
rename : devtools/client/shared/shim/test/.eslintrc => devtools/client/shared/shim/test/.eslintrc.js
rename : devtools/client/shared/test/.eslintrc => devtools/client/shared/test/.eslintrc.js
rename : devtools/client/shared/test/unit/.eslintrc => devtools/client/shared/test/unit/.eslintrc.js
rename : devtools/client/sourceeditor/.eslintrc => devtools/client/sourceeditor/.eslintrc.js
rename : devtools/client/sourceeditor/test/.eslintrc => devtools/client/sourceeditor/test/.eslintrc.js
rename : devtools/client/storage/test/.eslintrc => devtools/client/storage/test/.eslintrc.js
rename : devtools/client/styleeditor/test/.eslintrc => devtools/client/styleeditor/test/.eslintrc.js
rename : devtools/client/webaudioeditor/test/.eslintrc => devtools/client/webaudioeditor/test/.eslintrc.js
rename : devtools/client/webconsole/net/.eslintrc => devtools/client/webconsole/net/.eslintrc.js
rename : devtools/client/webconsole/net/test/mochitest/.eslintrc => devtools/client/webconsole/net/test/mochitest/.eslintrc.js
rename : devtools/client/webconsole/net/test/unit/.eslintrc => devtools/client/webconsole/net/test/unit/.eslintrc.js
rename : devtools/client/webconsole/new-console-output/test/.eslintrc => devtools/client/webconsole/new-console-output/test/.eslintrc.js
rename : devtools/client/webconsole/test/.eslintrc => devtools/client/webconsole/test/.eslintrc.js
rename : devtools/client/webide/test/.eslintrc => devtools/client/webide/test/.eslintrc.js
rename : devtools/server/tests/browser/.eslintrc => devtools/server/tests/browser/.eslintrc.js
rename : devtools/server/tests/mochitest/.eslintrc => devtools/server/tests/mochitest/.eslintrc.js
rename : devtools/server/tests/unit/.eslintrc => devtools/server/tests/unit/.eslintrc.js
rename : devtools/shared/heapsnapshot/tests/unit/.eslintrc => devtools/shared/heapsnapshot/tests/unit/.eslintrc.js
rename : devtools/shared/platform/content/.eslintrc => devtools/shared/platform/content/.eslintrc.js
rename : devtools/shared/platform/content/test/.eslintrc => devtools/shared/platform/content/test/.eslintrc.js
rename : devtools/shared/security/tests/unit/.eslintrc => devtools/shared/security/tests/unit/.eslintrc.js
rename : devtools/shared/tests/browser/.eslintrc => devtools/shared/tests/browser/.eslintrc.js
rename : devtools/shared/tests/unit/.eslintrc => devtools/shared/tests/unit/.eslintrc.js
rename : devtools/shared/transport/tests/unit/.eslintrc => devtools/shared/transport/tests/unit/.eslintrc.js
rename : devtools/shared/webconsole/test/unit/.eslintrc => devtools/shared/webconsole/test/unit/.eslintrc.js
rename : devtools/shared/worker/tests/browser/.eslintrc => devtools/shared/worker/tests/browser/.eslintrc.js
rename : mobile/android/components/extensions/.eslintrc => mobile/android/components/extensions/.eslintrc.js
rename : mobile/android/components/extensions/test/mochitest/.eslintrc => mobile/android/components/extensions/test/mochitest/.eslintrc.js
rename : security/manager/.eslintrc.json => security/manager/.eslintrc.js
rename : security/manager/ssl/tests/.eslintrc.json => security/manager/ssl/tests/.eslintrc.js
rename : security/manager/ssl/tests/mochitest/browser/.eslintrc.json => security/manager/ssl/tests/mochitest/browser/.eslintrc.js
rename : security/manager/ssl/tests/mochitest/mixedcontent/.eslintrc.json => security/manager/ssl/tests/mochitest/mixedcontent/.eslintrc.js
rename : security/manager/ssl/tests/mochitest/stricttransportsecurity/.eslintrc.json => security/manager/ssl/tests/mochitest/stricttransportsecurity/.eslintrc.js
rename : security/manager/ssl/tests/unit/.eslintrc.json => security/manager/ssl/tests/unit/.eslintrc.js
rename : security/manager/tools/.eslintrc.json => security/manager/tools/.eslintrc.js
rename : storage/.eslintrc => storage/.eslintrc.js
rename : testing/mochitest/browser.eslintrc => testing/mochitest/browser.eslintrc.js
rename : testing/mochitest/chrome.eslintrc => testing/mochitest/chrome.eslintrc.js
rename : testing/mochitest/mochitest.eslintrc => testing/mochitest/mochitest.eslintrc.js
rename : testing/xpcshell/xpcshell.eslintrc => testing/xpcshell/xpcshell.eslintrc.js
rename : toolkit/.eslintrc => toolkit/.eslintrc.js
rename : toolkit/components/aboutmemory/tests/.eslintrc => toolkit/components/aboutmemory/tests/.eslintrc.js
rename : toolkit/components/aboutperformance/tests/browser/.eslintrc => toolkit/components/aboutperformance/tests/browser/.eslintrc.js
rename : toolkit/components/addoncompat/tests/browser/.eslintrc => toolkit/components/addoncompat/tests/browser/.eslintrc.js
rename : toolkit/components/alerts/test/.eslintrc => toolkit/components/alerts/test/.eslintrc.js
rename : toolkit/components/asyncshutdown/tests/xpcshell/.eslintrc => toolkit/components/asyncshutdown/tests/xpcshell/.eslintrc.js
rename : toolkit/components/autocomplete/tests/unit/.eslintrc => toolkit/components/autocomplete/tests/unit/.eslintrc.js
rename : toolkit/components/captivedetect/test/unit/.eslintrc => toolkit/components/captivedetect/test/unit/.eslintrc.js
rename : toolkit/components/commandlines/test/unit/.eslintrc => toolkit/components/commandlines/test/unit/.eslintrc.js
rename : toolkit/components/commandlines/test/unit_unix/.eslintrc => toolkit/components/commandlines/test/unit_unix/.eslintrc.js
rename : toolkit/components/commandlines/test/unit_win/.eslintrc => toolkit/components/commandlines/test/unit_win/.eslintrc.js
rename : toolkit/components/contentprefs/tests/mochitest/.eslintrc => toolkit/components/contentprefs/tests/mochitest/.eslintrc.js
rename : toolkit/components/contentprefs/tests/unit/.eslintrc => toolkit/components/contentprefs/tests/unit/.eslintrc.js
rename : toolkit/components/contentprefs/tests/unit_cps2/.eslintrc => toolkit/components/contentprefs/tests/unit_cps2/.eslintrc.js
rename : toolkit/components/crashes/tests/xpcshell/.eslintrc => toolkit/components/crashes/tests/xpcshell/.eslintrc.js
rename : toolkit/components/crashmonitor/test/unit/.eslintrc => toolkit/components/crashmonitor/test/unit/.eslintrc.js
rename : toolkit/components/ctypes/tests/chrome/.eslintrc => toolkit/components/ctypes/tests/chrome/.eslintrc.js
rename : toolkit/components/ctypes/tests/unit/.eslintrc => toolkit/components/ctypes/tests/unit/.eslintrc.js
rename : toolkit/components/downloads/test/unit/.eslintrc => toolkit/components/downloads/test/unit/.eslintrc.js
rename : toolkit/components/extensions/.eslintrc => toolkit/components/extensions/.eslintrc.js
rename : toolkit/components/extensions/test/mochitest/.eslintrc => toolkit/components/extensions/test/mochitest/.eslintrc.js
rename : toolkit/components/extensions/test/xpcshell/.eslintrc => toolkit/components/extensions/test/xpcshell/.eslintrc.js
rename : toolkit/components/feeds/test/.eslintrc => toolkit/components/feeds/test/.eslintrc.js
rename : toolkit/components/filepicker/test/unit/.eslintrc => toolkit/components/filepicker/test/unit/.eslintrc.js
rename : toolkit/components/filewatcher/tests/xpcshell/.eslintrc => toolkit/components/filewatcher/tests/xpcshell/.eslintrc.js
rename : toolkit/components/formautofill/test/browser/.eslintrc => toolkit/components/formautofill/test/browser/.eslintrc.js
rename : toolkit/components/formautofill/test/chrome/.eslintrc => toolkit/components/formautofill/test/chrome/.eslintrc.js
rename : toolkit/components/formautofill/test/xpcshell/.eslintrc => toolkit/components/formautofill/test/xpcshell/.eslintrc.js
rename : toolkit/components/jsdownloads/test/browser/.eslintrc => toolkit/components/jsdownloads/test/browser/.eslintrc.js
rename : toolkit/components/jsdownloads/test/data/.eslintrc => toolkit/components/jsdownloads/test/data/.eslintrc.js
rename : toolkit/components/jsdownloads/test/unit/.eslintrc => toolkit/components/jsdownloads/test/unit/.eslintrc.js
rename : toolkit/components/lz4/tests/xpcshell/.eslintrc => toolkit/components/lz4/tests/xpcshell/.eslintrc.js
rename : toolkit/components/mediasniffer/test/unit/.eslintrc => toolkit/components/mediasniffer/test/unit/.eslintrc.js
rename : toolkit/components/narrate/.eslintrc => toolkit/components/narrate/.eslintrc.js
rename : toolkit/components/narrate/test/.eslintrc => toolkit/components/narrate/test/.eslintrc.js
rename : toolkit/components/osfile/tests/mochi/.eslintrc => toolkit/components/osfile/tests/mochi/.eslintrc.js
rename : toolkit/components/osfile/tests/xpcshell/.eslintrc => toolkit/components/osfile/tests/xpcshell/.eslintrc.js
rename : toolkit/components/passwordmgr/.eslintrc => toolkit/components/passwordmgr/.eslintrc.js
rename : toolkit/components/passwordmgr/test/.eslintrc => toolkit/components/passwordmgr/test/.eslintrc.js
rename : toolkit/components/passwordmgr/test/browser/.eslintrc => toolkit/components/passwordmgr/test/browser/.eslintrc.js
rename : toolkit/components/passwordmgr/test/unit/.eslintrc => toolkit/components/passwordmgr/test/unit/.eslintrc.js
rename : toolkit/components/perf/.eslintrc => toolkit/components/perf/.eslintrc.js
rename : toolkit/components/perfmonitoring/tests/browser/.eslintrc => toolkit/components/perfmonitoring/tests/browser/.eslintrc.js
rename : toolkit/components/places/tests/.eslintrc => toolkit/components/places/tests/.eslintrc.js
rename : toolkit/components/places/tests/bookmarks/.eslintrc => toolkit/components/places/tests/bookmarks/.eslintrc.js
rename : toolkit/components/places/tests/browser/.eslintrc => toolkit/components/places/tests/browser/.eslintrc.js
rename : toolkit/components/places/tests/chrome/.eslintrc => toolkit/components/places/tests/chrome/.eslintrc.js
rename : toolkit/components/places/tests/expiration/.eslintrc => toolkit/components/places/tests/expiration/.eslintrc.js
rename : toolkit/components/places/tests/favicons/.eslintrc => toolkit/components/places/tests/favicons/.eslintrc.js
rename : toolkit/components/places/tests/history/.eslintrc => toolkit/components/places/tests/history/.eslintrc.js
rename : toolkit/components/places/tests/migration/.eslintrc => toolkit/components/places/tests/migration/.eslintrc.js
rename : toolkit/components/places/tests/network/.eslintrc => toolkit/components/places/tests/network/.eslintrc.js
rename : toolkit/components/places/tests/queries/.eslintrc => toolkit/components/places/tests/queries/.eslintrc.js
rename : toolkit/components/places/tests/unifiedcomplete/.eslintrc => toolkit/components/places/tests/unifiedcomplete/.eslintrc.js
rename : toolkit/components/places/tests/unit/.eslintrc => toolkit/components/places/tests/unit/.eslintrc.js
rename : toolkit/components/promiseworker/tests/xpcshell/.eslintrc => toolkit/components/promiseworker/tests/xpcshell/.eslintrc.js
rename : toolkit/components/prompts/test/.eslintrc => toolkit/components/prompts/test/.eslintrc.js
rename : toolkit/components/remotebrowserutils/tests/browser/.eslintrc => toolkit/components/remotebrowserutils/tests/browser/.eslintrc.js
rename : toolkit/components/satchel/test/.eslintrc => toolkit/components/satchel/test/.eslintrc.js
rename : toolkit/components/satchel/test/browser/.eslintrc => toolkit/components/satchel/test/browser/.eslintrc.js
rename : toolkit/components/satchel/test/unit/.eslintrc => toolkit/components/satchel/test/unit/.eslintrc.js
rename : toolkit/components/search/tests/xpcshell/.eslintrc => toolkit/components/search/tests/xpcshell/.eslintrc.js
rename : toolkit/components/social/test/xpcshell/.eslintrc => toolkit/components/social/test/xpcshell/.eslintrc.js
rename : toolkit/components/sqlite/tests/xpcshell/.eslintrc => toolkit/components/sqlite/tests/xpcshell/.eslintrc.js
rename : toolkit/components/startup/tests/browser/.eslintrc => toolkit/components/startup/tests/browser/.eslintrc.js
rename : toolkit/components/startup/tests/unit/.eslintrc => toolkit/components/startup/tests/unit/.eslintrc.js
rename : toolkit/components/telemetry/tests/unit/.eslintrc => toolkit/components/telemetry/tests/unit/.eslintrc.js
rename : toolkit/components/terminator/tests/xpcshell/.eslintrc => toolkit/components/terminator/tests/xpcshell/.eslintrc.js
rename : toolkit/components/thumbnails/test/.eslintrc => toolkit/components/thumbnails/test/.eslintrc.js
rename : toolkit/components/timermanager/tests/unit/.eslintrc => toolkit/components/timermanager/tests/unit/.eslintrc.js
rename : toolkit/components/url-classifier/tests/mochitest/.eslintrc => toolkit/components/url-classifier/tests/mochitest/.eslintrc.js
rename : toolkit/components/url-classifier/tests/unit/.eslintrc => toolkit/components/url-classifier/tests/unit/.eslintrc.js
rename : toolkit/components/urlformatter/tests/unit/.eslintrc => toolkit/components/urlformatter/tests/unit/.eslintrc.js
rename : toolkit/components/viewsource/test/.eslintrc => toolkit/components/viewsource/test/.eslintrc.js
rename : toolkit/components/viewsource/test/browser/.eslintrc => toolkit/components/viewsource/test/browser/.eslintrc.js
rename : toolkit/components/workerloader/tests/.eslintrc => toolkit/components/workerloader/tests/.eslintrc.js
rename : toolkit/components/xulstore/tests/chrome/.eslintrc => toolkit/components/xulstore/tests/chrome/.eslintrc.js
rename : toolkit/components/xulstore/tests/xpcshell/.eslintrc => toolkit/components/xulstore/tests/xpcshell/.eslintrc.js
rename : toolkit/content/tests/browser/.eslintrc => toolkit/content/tests/browser/.eslintrc.js
rename : toolkit/content/tests/chrome/.eslintrc => toolkit/content/tests/chrome/.eslintrc.js
rename : toolkit/content/tests/unit/.eslintrc => toolkit/content/tests/unit/.eslintrc.js
rename : toolkit/content/tests/widgets/.eslintrc => toolkit/content/tests/widgets/.eslintrc.js
rename : toolkit/crashreporter/test/browser/.eslintrc => toolkit/crashreporter/test/browser/.eslintrc.js
rename : toolkit/crashreporter/test/unit/.eslintrc => toolkit/crashreporter/test/unit/.eslintrc.js
rename : toolkit/crashreporter/test/unit_ipc/.eslintrc => toolkit/crashreporter/test/unit_ipc/.eslintrc.js
rename : toolkit/forgetaboutsite/test/browser/.eslintrc => toolkit/forgetaboutsite/test/browser/.eslintrc.js
rename : toolkit/forgetaboutsite/test/unit/.eslintrc => toolkit/forgetaboutsite/test/unit/.eslintrc.js
rename : toolkit/identity/tests/chrome/.eslintrc => toolkit/identity/tests/chrome/.eslintrc.js
rename : toolkit/identity/tests/unit/.eslintrc => toolkit/identity/tests/unit/.eslintrc.js
rename : toolkit/modules/addons/.eslintrc => toolkit/modules/addons/.eslintrc.js
rename : toolkit/modules/subprocess/.eslintrc => toolkit/modules/subprocess/.eslintrc.js
rename : toolkit/modules/subprocess/test/xpcshell/.eslintrc => toolkit/modules/subprocess/test/xpcshell/.eslintrc.js
rename : toolkit/modules/tests/browser/.eslintrc => toolkit/modules/tests/browser/.eslintrc.js
rename : toolkit/modules/tests/chrome/.eslintrc => toolkit/modules/tests/chrome/.eslintrc.js
rename : toolkit/modules/tests/mochitest/.eslintrc => toolkit/modules/tests/mochitest/.eslintrc.js
rename : toolkit/modules/tests/xpcshell/.eslintrc => toolkit/modules/tests/xpcshell/.eslintrc.js
rename : toolkit/mozapps/downloads/tests/chrome/.eslintrc => toolkit/mozapps/downloads/tests/chrome/.eslintrc.js
rename : toolkit/mozapps/downloads/tests/unit/.eslintrc => toolkit/mozapps/downloads/tests/unit/.eslintrc.js
rename : toolkit/mozapps/extensions/.eslintrc => toolkit/mozapps/extensions/.eslintrc.js
rename : toolkit/mozapps/extensions/test/browser/.eslintrc => toolkit/mozapps/extensions/test/browser/.eslintrc.js
rename : toolkit/mozapps/extensions/test/mochitest/.eslintrc => toolkit/mozapps/extensions/test/mochitest/.eslintrc.js
rename : toolkit/mozapps/extensions/test/xpcshell/.eslintrc => toolkit/mozapps/extensions/test/xpcshell/.eslintrc.js
rename : toolkit/mozapps/extensions/test/xpinstall/.eslintrc => toolkit/mozapps/extensions/test/xpinstall/.eslintrc.js
rename : toolkit/mozapps/update/tests/chrome/.eslintrc => toolkit/mozapps/update/tests/chrome/.eslintrc.js
rename : toolkit/mozapps/update/tests/unit_aus_update/.eslintrc => toolkit/mozapps/update/tests/unit_aus_update/.eslintrc.js
rename : toolkit/mozapps/update/tests/unit_base_updater/.eslintrc => toolkit/mozapps/update/tests/unit_base_updater/.eslintrc.js
rename : toolkit/mozapps/update/tests/unit_service_updater/.eslintrc => toolkit/mozapps/update/tests/unit_service_updater/.eslintrc.js
rename : toolkit/profile/test/.eslintrc => toolkit/profile/test/.eslintrc.js
rename : toolkit/themes/osx/mochitests/.eslintrc => toolkit/themes/osx/mochitests/.eslintrc.js
rename : toolkit/xre/test/.eslintrc => toolkit/xre/test/.eslintrc.js
rename : tools/lint/eslint/eslint-plugin-mozilla/lib/rules/.eslintrc => tools/lint/eslint/eslint-plugin-mozilla/lib/rules/.eslintrc.js
extra : rebase_source : 60affc4b9bf436bba7e0e21a8da3a85d16c9fc06
2016-10-18 08:38:10 +01:00
Andrew Halberstadt
352b4ef478 Bug 1309963 - Fix hidden eslint error output when the first line is blank, r=jgraham
The 'eslint' linter will assume there is an error message if the output is not valid
JSON. However, if output[0] evaluates to False, then it will also replace the output
with '[]' (which means success).

But if the error starts with a blank line, then output[0] is False and we wrongfully
don't print the rest of the message.

MozReview-Commit-ID: 9fXpmtlUUT1

--HG--
extra : rebase_source : b0466ea665cc311d9512756349b079c136a83ac1
2016-10-13 16:22:26 -04:00
Philipp Kewisch
7a35040ddc Bug 1306366 - mach eslint no longer accepts --no-ignore as a parameter. r=ahal
MozReview-Commit-ID: LpT0Qlv6vsE

--HG--
extra : rebase_source : ea59047c9b9029c7e5362e68499b24a0eac67eb1
2016-10-14 14:20:23 +02:00
Francesco Pischedda
f45ed99748 Bug 1280573 - Add testing/mozbase to flake8 linter: r=ahal
added testing/mozbase to tools/lint/flake8.lint
fixed a first batch of PEP8 errors/warnings

at first the commad autopep8 -i --max-line-length 99 -r -j 8 .
has been used to fix simpler problems, run from testing/mozbase

some of the issues can not easily fixed :
- undefined 'names' in code for example isLinux - isLinux and isBsd "fixed" with # noqa
- undefined 'message' resolved with return fmt.format(...
- undefined 'structured' resolved replacing those with mozlog
- long comments - some remaining - addressed with # noqa
- package level import everything - addressed with # flake8: noqa

restored testing/mozbase/mozdevice/mozdevice/Zeroconf.py
fixed issues reported on mozreview
fixed ')' in testing/mozbase/mozprocess/mozprocess/qijo.py imports
finally fixed multiline string at testing/mozbase/manifestparser/tests/test_manifestparser.py:114
^^^ and again, but now with ./mach python-test --path-only testing/mozbase/manifestparser/tests/test_manifestparser.py passing
fixed testing/mozbase/manifestparser/tests/test_convert_directory.py assert

fixed this error:
10:15:21     INFO -      return lambda line: stack_fixer_module.fixSymbols(line)
10:15:21     INFO -  TypeError: fixSymbols() takes exactly 2 arguments (1 given)

fixed two spaces lint error even of #  noqa comments
restored assignement to lambda with #  noqa to silence the lint error
global noqa for testing/mozbase/manifestparser/tests/test_filters.py
stupid is/is not error...

MozReview-Commit-ID: 1FpJF54GqIi

--HG--
extra : rebase_source : 3cf0277fb36a296e3506aeacc2ff05e1b03f9eac
2016-09-30 16:08:37 +02:00
Prabhjyot Singh Sodhi
ebb9f983f1 Bug 1280571 - Add testing/mochitest to the flake8 linter, r=ahal
MozReview-Commit-ID: INBZaZzcPmF

--HG--
extra : rebase_source : c0ba416f110b2768fc744de0fbee21c765081400
2016-09-28 08:28:04 -04:00
Dave Townsend
76fbb2e22e Bug 1312355: Use a fixed lookup table for variables imported from JS modules. r=standard8
MozReview-Commit-ID: EhKhBvAAlXd

--HG--
extra : rebase_source : 935a96957ffb9e5f7e752c00e150d1757989d867
2016-11-01 12:24:04 -07:00
Wes Kocher
765926408d Backed out changeset e1d144423657 (bug 1280571) for making leaks hard to diagnose a=backout CLOSED TREE 2016-09-21 16:56:50 -07:00
Prabhjyot Singh Sodhi
58b6130e52 Bug 1280571 - Add testing/mochitest to the flake8 linter, r=ahal
This also adds E402 (no imports at top of file) to the global ignore list. The
other error codes added were previously ignored by default, but now that we
have started a custom ignore list, need to be listed explicitly.

MozReview-Commit-ID: RtMuVEX6i5

--HG--
extra : rebase_source : 939bc9354f5891c680513d7e9068d0438e169132
2016-09-21 08:49:46 -04:00
Carsten "Tomcat" Book
4f900773f5 merge mozilla-inbound to mozilla-central a=merge 2016-09-21 12:03:31 +02:00
Philipp Kewisch
a5e487b1ed Bug 1298879 - Upgrade to ESLint 3.5.0 for faster linting. r=miker
--HG--
extra : amend_source : f9192046a1c22f631d6423ce4ffc6e4e0e11dfc1
2016-09-20 10:27:03 +01:00
Philipp Kewisch
7fca5359ea Bug 1303725 - Make mach eslint output more helpful in case of an error. r=miker
MozReview-Commit-ID: KvTrBfnPjtn

--HG--
extra : rebase_source : a8060752ea34cffb964b654535c19b04a0cb8598
2016-09-19 22:17:40 +02:00
Bryce Van Dyk
00c9132cb6 Bug 1303646 - Escape backslashes when processing flake8 output. r=ahal
During process_line each line is loaded into JSON. As it stands it is possible
to attempt loads on lines containing single backslashes. This will fail the
load as these characters are invalid in JSON. This is particularly noticeable on
Windows, where all paths will contain these characters.

This changeset escapes any back slashes in the lines. It also adds logging to
the error case for the JSON loading, so failures aren't silently swallowed.

***
Fix issues brought up in review, silly mistakes in last changeset.

- Update log message upon encountering non JSON linter output that cannot be
  handled by json.loads.
- Correct typo: formate -> format.
- Correct replace string. Was using r'\\\\', which will evaluate to 3 slashes,
  now using '\\\\', which evaluates to 2. Opting not to use a raw string here
  because of the confusion over the final backslash interaction (final one still
  needs to be escaped even in a raw string).

MozReview-Commit-ID: Hfa0jSdnege

--HG--
extra : rebase_source : bd29d2437cf61f01df6d01a70ed651b49e33656e
2016-09-20 08:41:09 +12:00
James Graham
b20e631b19 Bug 1302796 - Add --check-clean flag to mach manifest update and mozlint integration, r=ahal,Ms2ger
MozReview-Commit-ID: 8Z4ywNEbF8G

--HG--
extra : rebase_source : 029995f188d14d0b70ed6e146a0feb71a046512f
2016-09-13 14:20:20 +01:00
James Graham
bba975bca2 Bug 1302796 - Add integration between structured logging and lints, r=ahal
MozReview-Commit-ID: K3tu0Zdg5go

--HG--
extra : rebase_source : 2b78059908c3a297b8ce7d134af20733fc082df5
2016-09-13 14:18:41 +01:00
Henrik Skupin
a5a7c13571 Bug 1300776 - Add testing/marionette/harness to flake8 linter (except mixins, tests) . r=ahal
MozReview-Commit-ID: F9Hfze9zvzE

--HG--
extra : rebase_source : ddd2e63bf13967da1d66d49cbdd189b68e0e7402
2016-09-06 15:46:08 +02:00
Andrew Halberstadt
1cad660f54 Bug 1299540 - Fix WindowsError when running eslint from msys, r=smacleod
This fixes a regression from bug 1258341 where the eslint binary no longer
gets run from a shell on msys. Without this, a WindowsError [Error 139] is
thrown.

MozReview-Commit-ID: FQ3LhTzd8nL

--HG--
extra : rebase_source : 33490fd9e41a2691f0b0c815916185fcf8936987
2016-08-31 14:32:44 -04:00
Andrew Halberstadt
c40eeb57dc Bug 1258341 - Merge eslint-plugin-mozilla docs with the main linting docs, r=miker
This does 3 things:

1) Moves all the long descriptions for the rules into the main index.rst
   document. This just makes it simpler, and there didn't seem to be much
   point in having a separate document for each rule.
2) Moves index.rst to tools/lint/docs/eslint-plugin-mozilla.rst
3) Creates a new eslint.rst landing page, and includes it.

MozReview-Commit-ID: 1e3QBkMFOBe

--HG--
rename : tools/lint/eslint/eslint-plugin-mozilla/docs/index.rst => tools/lint/docs/linters/eslint-plugin-mozilla.rst
extra : rebase_source : ab2c5c89bfa77da994f20fbecffed25e9f475ce8
2016-08-25 11:58:32 -04:00
Andrew Halberstadt
6bd4aab95e Bug 1258341 - Rewrite eslint taskcluster task to use |mach lint| instead of |mach eslint|, r=smacleod
This also renames the tasks:

    eslint-gecko -> mozlint-eslint
    flake8-gecko -> mozlint-flake8

MozReview-Commit-ID: KYhC6SEySC3

--HG--
rename : taskcluster/ci/legacy/tasks/tests/eslint-gecko.yml => taskcluster/ci/legacy/tasks/tests/mozlint-eslint.yml
extra : rebase_source : 3f3b4d0226bf014d49ade2eb56b67ce62197e179
2016-08-25 10:00:51 -04:00
Andrew Halberstadt
9703ac2438 Bug 1258341 - Modify 'eslint' implementation to work with the mozlint framework, r=smacleod
This integrates 'eslint' with the mozlint framework. The old |mach eslint| command is kept around
for backwards compatibility and will simply dispatch to |mach lint|. But |mach lint| should be
preferred as the old command may eventually be removed.

The old |mach eslint| command should be mostly backwards compatible with a few exceptions:

    1. Can no longer define --extensions on the command line, this is instead hardcoded into
       eslint.lint.
    2. No longer using eslint formatters. However, the default mozlint formatter should be
       identical to the default eslint formatter, so developers should not notice a change.
       This does mean that non-default eslint formatters can no longer be used unless a mozlint
       copy of them is created.
    3. Installs dependencies automatically without prompting the user. This was necessary due to
       python multiprocessing limitations, but is actually also a better UX. Because the npm
       dependencies aren't global anymore, there isn't really any reason *not* to install them
       automatically.

Apart from that, any difference from the old |mach eslint| I'd consider a bug.

The main eslint implementation now lives in tools/lint/eslint.lint instead of
tools/lint/mach_commands.py.


MozReview-Commit-ID: KYhC6SEySC3

--HG--
extra : rebase_source : 36d06b1a3fced764e17154cc53091d7722919b67
2016-08-30 14:28:56 -04:00
Michael Ratcliffe
4fab0b64e1 Bug 1270926 - Shrinkwrap eslint support on XHTML files r=mratcliffe
MozReview-Commit-ID: 8i7Rayhzob5
2016-08-23 14:20:08 -07:00
Matthew Noorenberghe
a59bf6717f Bug 1270926 - Support ESLint on XHTML files. r=ahal
MozReview-Commit-ID: 4iYODbZQiB9
2016-08-23 14:42:21 -07:00
Andrew Halberstadt
ed73940aa9 Bug 1288425 - Make sure we skip invalid extensions when linting with --rev or --workdir, r=smacleod
Some linters, such as flake8, will lint invalid file extensions if you explicitly pass them in. E.g,
|flake8 foobar.js| will result in flake8 attempting to lint a JS file. This is a problem because passing
in files explicitly is exactly what the --rev/--workdir options do. If a developer modifies a JS file
then runs |mach lint -l flake8 -w|, that JS file will get linted.

To prevent this, mozlint needs to handle file extensions instead of relying on the underlying linter to
do it. This patch adds an "extensions" config option to the LINTER dict, and will filter these files out
as part of the 'filterpaths' steps.

MozReview-Commit-ID: KYhC6SEySC3

--HG--
extra : rebase_source : 6fea2942b2db1bea7deca1d6738546362b6ebd65
2016-08-09 16:24:04 -04:00
Andrew Halberstadt
5353a06823 Bug 1289805 - Don't pass in --exclude to flake8 paths that contain custom configuration, r=smacleod
This fixes a bug in flake8, where if you pass in --exclude to a path with a custom .flake8 file, that
configuration will be ignored. I'm not sure why this happens.

Prior to this commit series, the 'exclude' paths weren't being passed on to the flake8 linter properly.
This is why the problems hasn't surfaced until now. This is a band-aid fix until a proper (likely
upstream) fix can be landed.

MozReview-Commit-ID: KYhC6SEySC3

--HG--
extra : rebase_source : 0dbf30dcb17c37787c2ddebbb3c7de5f3b63860b
2016-08-09 16:28:13 -04:00
Gregory Szorc
1fdad6619c NO BUG - Reconcile eslint Sphinx docs index with reality
Drop/add missing pages as appropriate.

MozReview-Commit-ID: KckObsl2RdU

--HG--
extra : rebase_source : f906beba5a7aa9731967e349ef685b935a2f8015
2016-08-16 16:37:51 -07:00
Piyush Sinha
7e1a93b672 Bug 1274167 - Add Linter(flake8) support for Firefox-ui and Puppeteer.r=whimboo
MozReview-Commit-ID: Ga3iaEH54yH

--HG--
extra : rebase_source : 264c275f6e4bf8feaa2a65479aba43ca1e2cd27e
2016-08-15 02:16:18 +05:30
Jared Wein
df53d45313 Bug 1291910 - Add ability for mach eslint to accept --fix. r=Felipe
MozReview-Commit-ID: 5PB2oI2jPri

--HG--
extra : rebase_source : 42d03b9ab93c4ef390d0dfa59d25dd330309071d
2016-08-03 19:18:55 -04:00
J. Ryan Stinnett
c9822d13cd Bug 1288225 - Exclude eslint-plugin-mozilla from tooltool. r=ahal
This removes the in-tree plugin from the tooltool archive and uses that code
directly from the Gecko checkout instead.

For automation, we now get ESLint and external plugins from tooltool and then
symbolic link to the in-tree plugin.

For local development, we install ESLint and external plugins following the
shrinkwrap file created from the last change to the tooltool archive.  The local
plugin is then installed.

This change also removes the list of module versions from mach_commands.py, so
there is only one place to update module versions for the future.

MozReview-Commit-ID: AhbZ8lVPmN4
2016-07-28 11:53:54 -05:00