We did a bailout from Ion with a MagicValue(JS_OPTIMIZED_OUT) on top of the stack, then passed that
value to TypeMonitorResult and asserted in addMonitorStubForValue because we expected a different
kind of magic value.
This patch moves MagicValue handling into TypeMonitorMagicValue and calls it from both places so we
have consistent behavior.
Differential Revision: https://phabricator.services.mozilla.com/D41019
--HG--
extra : moz-landing-system : lando
APPLICATION_REPUTATION_BINARY is now replaced by APPLICATION_REPUTATION_BINARY_TYPE,
we can remove it from telemetry.
Depends on D37275
Differential Revision: https://phabricator.services.mozilla.com/D37276
--HG--
extra : moz-landing-system : lando
This patch adds a telemetry, APPLICATION_REPUTATION_BINARY_TYPE, which
records different binary type based on the file extension.
1. BinaryFile, file is considered as a binary file, file is eligible for remote lookup
2. NonBinaryFile, file is not considered as a binary file.
3. MozNonBinaryFile, file is considered as a binary file in Chrome, but we don't
send a download protection ping for this file
4. UnknownFile, file is not in any of the above lists.
Differential Revision: https://phabricator.services.mozilla.com/D37275
--HG--
extra : moz-landing-system : lando
This patch removes two entries:
- devtools/client/netmonitor/launchpad.js: this file no longer exists.
- devtools/client/webconsole/test/mocha-test-setup.js: this file is a proper JS
file, not a prefs file.
The patch also reformats mocha-test-setup.js.
Differential Revision: https://phabricator.services.mozilla.com/D41150
--HG--
extra : moz-landing-system : lando
This includes the Save to Pocket action.
Previously, keyboard users had to press f6 twice to focus the iframe.
Worse, screen reader users weren't aware anything popped up at all.
Differential Revision: https://phabricator.services.mozilla.com/D40913
--HG--
extra : moz-landing-system : lando
Avoiding lots of `if (isParent)` conditions reduces code size by 2016 bytes for
a local build on my Linux64 box.
Differential Revision: https://phabricator.services.mozilla.com/D40921
--HG--
extra : moz-landing-system : lando
Helps support migrating from XUL DOM to an HTML DOM structure. I attempted
to remove the early return when the root element is not a XUL element, but
it appears setting the transparency on a non XUL root is still broken
(test widget/tests/test_mouse_scroll.xul started failing on windows).
Differential Revision: https://phabricator.services.mozilla.com/D40734
--HG--
extra : moz-landing-system : lando
After some bad experiences, I think EntryReader should be move-only:
- It needs to be moveable so it can be created from a function, and move-
constructed into a Maybe<> if needed.
- It can be passed around as a reference.
Previously, it could be passed by value, but it was too easy to create bugs,
e.g.: A function delegates to a sub-function to read something at the beginning,
then the first function wants to read more past that, but if the reader was
passed by value the first function would not see past what the sub-function did
read.
As a bonus, `mRing` can now be a reference instead of a pointer, and other
members can be const.
Differential Revision: https://phabricator.services.mozilla.com/D40958
--HG--
extra : moz-landing-system : lando
It's defined first as false, and again later in the file as true. This patch
removes the first definition, which is currently overridden by the second.
Depends on D40919
Differential Revision: https://phabricator.services.mozilla.com/D40920
--HG--
extra : moz-landing-system : lando
security-prefs.js is #included into greprefs.js, but there's no good reason for
it to be separate from all.js. Having it separate makes it easier to overlook,
and all.js has a bunch of `security.*` prefs in it anyway.
This patch inlines it into all.js. It inlines it at the start of the file to
minimize the risk of the change, so that the prefs end up in greprefs.js in the
same order as before.
Differential Revision: https://phabricator.services.mozilla.com/D40919
--HG--
extra : moz-landing-system : lando
When a directory, like toolkit/library, builds both a static and a
shared library, and another, like toolkit/library/gtest, depends on the
static part, it currently needs to wait for the shared library to be
finished building, preventing both libraries being built in parallel.
By separating shared libraries to a different target, we allow more
parallelism to the build.
Differential Revision: https://phabricator.services.mozilla.com/D41099
--HG--
extra : moz-landing-system : lando
It's much nicer.
One nice thing about this is that the new code is subject to the existing
threadedness checking, which identified that several of these should be atomic
because they're accessed off the main thread.
Differential Revision: https://phabricator.services.mozilla.com/D40792
--HG--
extra : moz-landing-system : lando
In order to support multiple API's (WebVR + WebXR) being enabled simultaneously, a new class, gfx::VRManagerEventObserver, implements a pure virtual interface to be shared by both the WebVR and WebXR observers of XR device related events.
Differential Revision: https://phabricator.services.mozilla.com/D39985
--HG--
extra : moz-landing-system : lando
This patch ressurects HiddenFrame.jsm and uses it when handling
the --screenshot command line argument to load the requested page
in a content process. The actual logic for grabbing the image is
also ported to a JSWindowActor. The test for this feature remains
suboptimal as described in the bug.
Differential Revision: https://phabricator.services.mozilla.com/D40148
--HG--
rename : browser/components/shell/HeadlessShell.jsm => browser/components/shell/ScreenshotChild.jsm
extra : moz-landing-system : lando
The patch makes the code for handling screenshots in the driver and
listener module easier to understand. Also it sets the default values
for optional arguments once, which doesn't require duplicated code
for the listener anymore.
Further there was a bug which treated the "full" parameter with a
higher priority as an element, if both are defined.
Differential Revision: https://phabricator.services.mozilla.com/D40818
--HG--
extra : moz-landing-system : lando
This patch implements the MozPower class in the Mozpower module which is the interface for the user to use the power measurement tooling. It primarily detects the user's OS and CPU combination and provides the appropriate methods for them.
Differential Revision: https://phabricator.services.mozilla.com/D39194
--HG--
extra : moz-landing-system : lando
This patch implements the MacIntelPower class in the Mozpower module. It is used for power measurement testing on Mac Intel-based machines using Intel Power Gadget.
Differential Revision: https://phabricator.services.mozilla.com/D39193
--HG--
extra : moz-landing-system : lando
This patch implements IntelPowerGadget and IPGResultsHandler for the Mozpower module. These classes handle data generation with Intel Power Gadget as well as cleaning the data and formatting it into the PERFHERDER_DATA format.
Differential Revision: https://phabricator.services.mozilla.com/D39192
--HG--
extra : moz-landing-system : lando
This patch initializes the Mozpower module and implements the PowerBase class. This class is used as a base for subclasses that implement power measurement tooling for various OS and CPU combinations.
Differential Revision: https://phabricator.services.mozilla.com/D39191
--HG--
extra : moz-landing-system : lando
