Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Olli Pettay
f3c3cde4c7
bug 1430701, remove now unused nsLightFrameIterator, r=mrbkap
...
--HG--
extra : rebase_source : 875b320c75414c3911a252e39267d1a424a51f37
2018-07-20 19:32:22 +03:00
Daniel Holbert
5110d9e202
Bug 1443672: Adjust a few .cpp files in layout to #include their own header first. r=emilio
...
MozReview-Commit-ID: L4ZSDT5Akhi
--HG--
extra : rebase_source : 4795c4eaf84957639f446471788697956fe2bf17
2018-03-06 15:59:36 -08:00
Noemi Erli
2062223489
Backed out changeset 04fecea9eaf0 (bug 1443672) as per dholbert's request on a CLOSED TREE
2018-03-07 20:55:26 +02:00
Daniel Holbert
93e46d9a9b
Bug 1443672: Adjust a few .cpp files in layout to #include their own header first. r=emilio
...
MozReview-Commit-ID: L4ZSDT5Akhi
--HG--
extra : rebase_source : 4795c4eaf84957639f446471788697956fe2bf17
2018-03-06 15:59:36 -08:00
Daniel Holbert
912ec5051e
Bug 1437623 part 2: (layout/base) Add missing includes/namespaces to preemptively fix unified bustage. r=mats
...
MozReview-Commit-ID: G4ufWWf9qRC
--HG--
extra : rebase_source : d7b814a8b9f5d3a6371eef14280598943a259c99
2018-02-13 09:08:42 -08:00
ben.tian@gmail.com
0f573ba322
Bug 1413834 - part 4: Limit frame traversal inside scope owned by document root when shadow host has no frame , r=smaug, emilio
...
--HG--
extra : rebase_source : 1e7fb01bda9a0927b1bea3085ab50eb3caf054c5
2018-01-26 17:49:47 +02:00
ben.tian@gmail.com
8e8a01efb7
Bug 1413834 - part 1: Limit frame traversal and getting of next tabindex inside scope owned by document root, r=smaug
...
--HG--
extra : rebase_source : 6a9bca46f5e98311b0179b8b44bebe59bb77e676
2018-01-26 17:47:44 +02:00
Daniel Holbert
680815cd6e
Bug 1412346 part 5: (automated patch) Switch a bunch of C++ files in layout to use our standard mode lines. r=jfkthame
...
This patch was generated automatically by the "modeline.py" script, available
here: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py
For every file that is modified in this patch, the changes are as follows:
(1) The patch changes the file to use the exact C++ mode lines from the
Mozilla coding style guide, available here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line
(2) The patch deletes any blank lines between the mode line & the MPL
boilerplate comment.
(3) If the file previously had the mode lines and MPL boilerplate in a
single contiguous C++ comment, then the patch splits them into
separate C++ comments, to match the boilerplate in the coding style.
MozReview-Commit-ID: EuRsDue63tK
--HG--
extra : rebase_source : 3356d4b80ff6213935192e87cdbc9103fec6084c
2017-10-27 10:33:53 -07:00
Sylvestre Ledru
4e9cf83ee8
Bug 1378712 - Remove all trailing whitespaces r=Ehsan
...
MozReview-Commit-ID: Kdz2xtTF9EG
--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Mats Palmgren
357e4b9560
bug 1368547 part 2 - Remove nsFrameManager/PresShell methods dealing with placeholders and introduce a nsIFrame::GetPlaceholderFrame() convenience method. r=jfkthame
...
MozReview-Commit-ID: GBUiUBqJxhQ
2017-05-31 21:29:49 +02:00
Mats Palmgren
f03ef6fe25
Bug 1368802 - nsFrameIterator::GetPlaceholderFrame should only try to get the placeholder for out-of-flow frames, because in-flow frames never have a placeholder. r=jfkthame
...
MozReview-Commit-ID: CcAlCWMHQQX
2017-05-31 21:29:49 +02:00
Emilio Cobos Álvarez
e44543aad4
Bug 1360241: Devirtualize nsIFrame::GetType. r=heycam
...
MozReview-Commit-ID: 5Nzhyta5Hle
--HG--
extra : rebase_source : c2e9d4bfb9239f5e851d110cd7dff98c1e1a8d8b
2017-04-30 17:30:08 +02:00
Cameron McCormack
f5bb6f2dfd
Bug 1322185
- Rename some StyleDisplay enum values for consistency. r=xidorn
...
MozReview-Commit-ID: K27LmXKWNdk
2016-12-05 21:36:28 -10:00
Daniel Holbert
c31ad35f39
Bug 1304540
part 2: Use nsCOMPtr/RefPtr (and their forget() API) instead of manual NS_ADDREF macros, in a few files within layout. r=mats
...
MozReview-Commit-ID: SrJNtbwc1B
--HG--
extra : rebase_source : 2fd086157bf4d8d16effe18037258a3bf12623fc
2016-09-21 15:41:26 -07:00
Daniel Holbert
2a6754c4c7
Bug 1304540
part 1: minor code-cleanup in the neighborhood of some NS_ADDREF usages. r=mats
...
DETAILS ON THE CLEANUP:
* In nsFrameTraversal.cpp:
- Whitespace fix.
- Remove a useless nullptr assignment.
- Use "=" to initialize a nsCOMPtr, per coding style guideline ("initialize variables with nsFoo aFoo = bFoo and not nsFoo aFoo(bFoo)").
* In nsPresShell.cpp:
- Wrap a longish assignment to 2 lines (since next patch will make the first line longer, which would push the whole thing over 80 characters if it weren't wrapped).
- Add braces around "if" body.
* In nsTextFrame.cpp:
- Remove a useless nullptr assignment.
- Move the "metrics->GetThebesFontGroup()" call slightly earlier, so it happens *before* we've implicitly transferred ownership the object pointed to by "metrics".
- Add a code-comment.
MozReview-Commit-ID: LG6vgOmM9MK
--HG--
extra : rebase_source : 7754d4edefb09ae7992275b9dcb7e84371955d9c
2016-09-21 15:39:48 -07:00
Emilio Cobos Álvarez
619cb14d87
Bug 1299066: Make NS_STYLE_DISPLAY_* an enum class. Prefer indexing instead of linear search in the frame constructor r=heycam,bz
...
The main renaming was generated with the following python script:
```
import sys
import re
CAMEL_CASE_REGEX = re.compile(r"(^|_|-)([A-Z])([A-Z]+)")
DISPLAY_REGEX = re.compile(r"\bNS_STYLE_DISPLAY_([^M][A-Z_]+)\b")
def to_camel_case(ident):
return re.sub(CAMEL_CASE_REGEX,
lambda m: m.group(2) + m.group(3).lower(), ident)
def constant_to_enum(constant):
return "StyleDisplay::" + to_camel_case(constant) + ("_" if constant == "NONE" else "")
def process_line(line):
return re.sub(DISPLAY_REGEX,
lambda m: constant_to_enum(m.group(1)), line)
lines = []
with open(sys.argv[1], "r") as f:
for line in f:
lines.append(process_line(line))
with open(sys.argv[1], "w") as f:
for line in lines:
f.write(line)
```
And the following shell commands:
```
find . -name '*.cpp' -exec python display.py {} \;
find . -name '*.h' -exec python display.py {} \;
```
MozReview-Commit-ID: 91xYCbLC2Vf
2016-09-01 20:41:17 -07:00
Ting-Yu Lin
1889f6bc41
Bug 1227927 Part 2 - Remove nsIFrame::GetFirstPrincipalChild(). r=mats
...
--HG--
extra : commitid : 5qtaK1nS8RC
extra : rebase_source : dcc98f423b2446269beb6fa6a9d092ae8213f38e
2016-01-29 22:42:14 +08:00
Neil Deakin
bf46cf123d
Bug 1132518, add a flag to nsIFrameTraversal to skip the popup checks, r=mats
2015-07-13 06:07:49 -04:00
Ehsan Akhgari
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Benoit Jacob
e1b7dbca34
Bug 1028588 - Fix dangerous public destructors in layout/ - r=dbaron
2014-06-23 18:40:01 -04:00
Mats Palmgren
a6feda0f22
Bug 508665 - part 1, Change the signature of SetParent/GetParent from nsIFrame* to nsContainerFrame*. r=roc
2014-05-24 22:20:39 +00:00
Birunthan Mohanathas
5f1fde8824
Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj
2014-04-27 03:06:00 -04:00
Arnaud Sourioux
a127266e74
Bug 974687 - Part 1: Add about 300 MOZ_OVERRIDE in layout/. r=dholbert
2014-02-24 09:41:56 -05:00
Daniel Holbert
77bedd32f8
Bug 841261: Use init list instead of assignment in nsFrameIterator constructor. r=mats
2013-02-18 08:59:55 -08:00
L. David Baron
c5b9eee040
Bug 781360 patch 3: Rename {nsIFrame,nsStyleContext,nsComputedDOMStyle}::GetStyle* to Style*, since they can never return null. r=dholbert
...
Except for the changes in:
layout/generic/nsIFrame.h (part)
layout/style/nsComputedDOMStyle.h (all)
layout/style/nsRuleNode.cpp (part)
layout/style/nsStyleContext.cpp (part)
layout/style/nsStyleContext.h (part)
(see patch 3b in the bug), this patch was written with the sed script:
s/\<GetStyle\(Font\|Color\|List\|Text\|Visibility\|Quotes\|UserInterface\|TableBorder\|SVG\|Background\|Position\|TextReset\|Display\|Content\|UIReset\|Table\|Margin\|Padding\|Border\|Outline\|XUL\|SVGReset\|Column\)\>/Style\1/g
2013-02-16 13:51:02 -08:00
Ehsan Akhgari
ea346b3dff
Bug 579517 follow-up: Remove NSPR types that crept in
2012-10-25 14:44:37 -04:00
Ehsan Akhgari
8e702f60c5
Backed out 2 changesets (bug 579517)
...
Backed out changeset 5298adc70963
Backed out changeset 86ccf7c918ce (bug 579517)
2012-10-25 12:32:24 -04:00
Ehsan Akhgari
f3c0ac7a23
Code hygiene: don't use PR_TRUE and PR_FALSE, and use stdint types instead of PRInt types (no bug really, but you could say bug 579517)
2012-10-25 11:48:19 -04:00
David Zbarsky
e1da975f5f
Backout bug 779684 for topcrash
2012-10-15 14:35:50 -04:00
David Zbarsky
dca3fd6326
Bug 779684: Create a stack-based nsFrameIterator class out of nsIFrameTraversal and nsIFrameEnumerator r=roc
...
--HG--
rename : layout/base/nsFrameTraversal.cpp => layout/base/nsFrameIterator.cpp
rename : layout/base/nsFrameTraversal.h => layout/base/nsFrameIterator.h
2012-08-05 23:00:55 -04:00
Aryeh Gregor
d0ad5a7d0c
Bug 777292 part 2 - Change all nsnull to nullptr
2012-07-30 17:20:58 +03:00
Ehsan Akhgari
65884fba1f
Bug 758992 - Make the classes which use the XPCOM nsISupports implementation macros final, to avoid the warning about deleting using a pointer to a base class with virtual functions and no virtual dtor (layout parts); r=roc
...
--HG--
extra : rebase_source : 9f3da1b47dcb9d7cc950488b9b70aa682b6984de
2012-06-18 23:26:34 -04:00
Gervase Markham
82ff7027aa
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
Michael Wu
d2b70213ac
Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
...
--HG--
rename : tools/trace-malloc/bloatblame.c => tools/trace-malloc/bloatblame.cpp
2011-09-28 23:19:26 -07:00
Mats Palmgren
f1c56f2e22
Bug 653649 - New way of getting child lists from frames. (part 4/5) r=roc
...
Remove the nsIAtom* child list names and use child list ID enum instead.
2011-08-24 22:54:30 +02:00
Craig Topper
26bac156fd
Bug 654369 - Part 11: Remove OOM checks from layout/base r=bz
...
--HG--
extra : rebase_source : a725d78f3e128d6d4ca1eb48eec1cfc78f7762bf
2011-04-28 22:02:40 -07:00
Craig Topper
3d7073c4a5
Bug 253889: DeCOMtaminate nsIPresShell r=roc
2010-03-20 17:54:19 -04:00
Boris Zbarsky
ba8c31506f
Bug 512336. Make frame lists doubly-linked. r=roc,fantasai
2009-10-02 12:27:37 -04:00
Mats Palmgren
2c137c2022
Bug 233463, patch 5 - Remove nsFrameList(nsIFrame*) ctor. r=bzbarsky
2009-09-18 13:09:36 +02:00
Uri Bernstein
0dd3c83d88
Bug 466568. Don't traverse into scrollable frames if we're not allowed to traverse out of them. r+sr=roc
2008-12-03 14:24:07 +13:00
Benjamin Smedberg
bb3bf9ec94
Bug 461212 - deCOM frame traversal (relanding) r=mats.palmgren sr=roc
2008-10-30 10:15:22 -07:00
Benjamin Smedberg
555c5a8f1c
Backed out changeset affcc1c08bc0 (deCOM frame enumerator) due to regression from it or bug 461410.
2008-10-28 02:47:40 -04:00
Benjamin Smedberg
2127dcfc13
Bug 461212 - deCOM frame enumerator, r=mats.palmgren sr=roc
2008-10-28 00:47:19 -04:00
enndeakin@sympatico.ca
239bab7b12
Bug 385275, handle tab navigation in popups properly, r+sr=roc
2007-08-15 18:09:58 -07:00
enndeakin@sympatico.ca
0fd6590d13
Bug 387720, fix shift+tab not working, popup reworking uncovered this bug which manifested itself as a regression, r+sr=roc
2007-07-12 06:54:42 -07:00
jwalden@mit.edu
6d7584839a
Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
2007-07-08 00:08:04 -07:00
benjamin@smedbergs.us
baab01ada6
Bug 376636 - Building with gcc 4.3 and -pendatic fails due to extra semicolons, patch by Art Haas <ahaas@airmail.net>, rs=me
2007-04-23 07:21:53 -07:00
sayrer@gmail.com
c939167a6c
bug 378339. nsFrameIterator doesn't initialize mOffEdge. r=uriber, sr=roc
2007-04-22 21:14:25 -07:00
cvshook%sicking.cc
a39ff30284
Kill remainders of ns(XBL|HTML|XUL|Layout)Atoms. r/sr=jst b=368128
2007-01-30 00:06:41 +00:00