Commit Graph

19763 Commits

Author SHA1 Message Date
Mihai Alexandru Michis
40d1ce7288 Backed out changeset 86a23ca27412 (bug 1621116) for causing gtest and mochitest failures.
CLOSED TREE
2020-03-20 23:53:34 +02:00
Dave Townsend
5bcaed8ab0 Bug 1621116: Make the version and build ID of the previous instance of Firefox to use the current profile available. r=froydnj
We cache this information in compatibility.ini so we can just expose it on
nsIXULRuntime.

Differential Revision: https://phabricator.services.mozilla.com/D66112

--HG--
extra : moz-landing-system : lando
2020-03-20 19:41:14 +00:00
Doug Thayer
48dd5d7d4e Bug 1623668 - Advance lateWriteChecksStage to xpcom-shutdown r=froydnj
Depends on D67542

Differential Revision: https://phabricator.services.mozilla.com/D67543

--HG--
extra : moz-landing-system : lando
2020-03-20 20:08:53 +00:00
Daniel Varga
156fc636e7 Backed out changeset 42851810d9e9 (bug 1621116) on request from the dev
CLOSED TREE
2020-03-20 21:35:01 +02:00
Dave Townsend
096dde646f Bug 1621116: Make the version and build ID of the previous instance of Firefox to use the current profile available. r=froydnj
We cache this information in compatibility.ini so we can just expose it on
nsIXULRuntime.

Differential Revision: https://phabricator.services.mozilla.com/D66112

--HG--
extra : moz-landing-system : lando
2020-03-20 19:22:24 +00:00
Simon Giesecke
e3a19c9b3e Bug 1620632 - Added tests for moving nsTArray/AutoTArray/FallibleTArray with MoveOnly element type. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D66081

--HG--
extra : moz-landing-system : lando
2020-03-20 17:06:29 +00:00
Simon Giesecke
58d0171406 Bug 1620632 - Ensure nsTArray_Impl only declares a copy-constructor/assignment operator if E is copy-constructible. r=froydnj
To correctly implement this, it must be known on instantiation whether E is
copy-constructible, which is not the case if only a forward declaration is
available. This can be resolved either by making sure a full definition of E is
available, which is preferable. But in cases where this is not (easily) possible,
the information can be explicitly provided by the MOZ_DECLARE_COPY_CONSTRUCTIBLE
and MOZ_DECLARE_NON_COPY_CONSTRUCTIBLE macros. In particular, declarations for
IPDL-declared types are added to nsTArray.h itself, like it was already done
for MOZ_DECLARE_RELOCATE_USING_MOVE_CONSTRUCTOR.

Differential Revision: https://phabricator.services.mozilla.com/D66244

--HG--
extra : moz-landing-system : lando
2020-03-20 17:13:51 +00:00
Simon Giesecke
7e9a7de895 Bug 1620632 - Rename confusingly named types/macros for relocation handling of nsTArray. r=froydnj
Specifically, this renames
* nsTArray_CopyChooser to nsTArray_RelocationStrategy
* the Copy template argument of nsTArray_base to RelocationStrategy
* nsTArray_CopyWithConstructors to nsTArray_RelocateUsingMoveConstructor
* nsTArray_CopyWithMemutils to nsTArray_RelocateUsingMemutils
* DECLARE_USE_COPY_CONSTRUCTORS to MOZ_DECLARE_RELOCATE_USING_MOVE_CONSTRUCTOR

Differential Revision: https://phabricator.services.mozilla.com/D66243

--HG--
extra : moz-landing-system : lando
2020-03-20 17:04:27 +00:00
Gabriele Svelto
d3eaf3858d Bug 1622452 - Remove the remote exception handler when a content process shuts down r=froydnj
This works on all platforms with the exception of Linux where we remove the
exception handler only if the sandbox is disabled. With the sandbox enabled we
would have to whitelist sigaltstack() which breakpad uses to remove the
alternate signal stack which is not worth the fuss.

Besides this patch refactors the code that sets and unsets the exception
handler, cutting down on the duplication:

* The XRE_UnsetRemoteExceptionHandler() call is removed from XULAppAPI.h since it
  was no longer used
* The duplicate checks for the special strings used to disable the remote exception
  handler have been removed from CrashReporter::UnsetRemoteExceptionHandler()
  leaving them in the calling code
* The SetRemoteExceptionHandler() function was consolidated into only one
  piece of code with only one non-platform-specific shared prototype
* Some additional code was factored out to improve the readability

These changes pave the way both for bug 1614933 and for the oxidation of the
exception handler code.

Differential Revision: https://phabricator.services.mozilla.com/D67213

--HG--
extra : moz-landing-system : lando
2020-03-19 14:06:31 +00:00
Simon Giesecke
5621715961 Bug 1622114 - Improve array manipulation in CleanupIDBTransactions. r=dom-workers-and-storage-reviewers,smaug,asuth
- Do not remove elements one-by-one but use remove-erase pattern.
- Move mPendingIDBTransactions array instead of copying.

Differential Revision: https://phabricator.services.mozilla.com/D67159

--HG--
extra : moz-landing-system : lando
2020-03-19 12:55:12 +00:00
Mike Hommey
0f365ba2c5 Bug 1621452 - Generate xpidllex.py and xpidlyacc.py with python2. r=rstewart
Ply doesn't actually support python3. The generation of the files seems
to work with python3 for some reason, but running the corresponding
tests doesn't. The only version of ply that supports python3 is
currently in beta, so upgrading ply is probably not an option at the
moment.

Other commands that do use ply (mach webidl-parser-test and
ipc/ipdl/Makefile.in) have not switched to python3 (probably because
they don't work). Let's go with the simpler thing for now: switch back
to python 2 for xpidllex.py and xpidlyacc.py, which will make them
deterministically created again.

Differential Revision: https://phabricator.services.mozilla.com/D67400

--HG--
extra : moz-landing-system : lando
2020-03-18 23:53:17 +00:00
Simon Giesecke
7434f710c9 Bug 1623325 - Fix nsTArrayBackInserter and add moving test. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D67337

--HG--
extra : moz-landing-system : lando
2020-03-18 16:07:12 +00:00
Jon Coppeard
8c62e61474 Bug 1622854 - Switch JSHolderMap to use HashMap r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D67018

--HG--
extra : moz-landing-system : lando
2020-03-18 14:01:22 +00:00
Jon Coppeard
1170608da0 Bug 1622854 - Factor out the JS holder map into a separate class r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D67017

--HG--
extra : moz-landing-system : lando
2020-03-17 19:42:57 +00:00
Emilio Cobos Álvarez
664a546418 Bug 1618260 - Fix number input so that it honors overflow-clip-box-block. r=mats
This never worked, but it's more visible with the new form controls which have
more padding.

Make the anonymous div and co a pseudo-element, so that they inherit from the
<input> properly in all cases. This works for non-number inputs because the
editor root is a direct child of the <input>, but it doesn't for number inputs
because there's a flex wrapper in between.

This way overflow-clip-box: inherit does what we want. Reset the padding in the
inline direction, as the padding for <input type=number> applies to the arrow
boxes as well, and thus we'd double-apply it.

Differential Revision: https://phabricator.services.mozilla.com/D65271

--HG--
extra : moz-landing-system : lando
2020-03-18 09:21:44 +00:00
Sean Feng
28bbd32a07 Bug 1377999 - Make Attribute to adapt the DOMArena changes r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D57700

--HG--
extra : moz-landing-system : lando
2020-03-17 14:53:13 +00:00
Sean Feng
053f3e648d Bug 1377999 - Make nsIContent to declare a final DeleteCycleCollectable r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D63263

--HG--
extra : moz-landing-system : lando
2020-03-17 14:53:00 +00:00
Sean Feng
91fd21bfd1 Bug 1377999 - Refactor some macros to support a final DeleteCycleCollectable r=smaug
There's no existing macro to allow use declare a final
DeleteCycleCollectable, this patch adds one

Differential Revision: https://phabricator.services.mozilla.com/D63262

--HG--
extra : moz-landing-system : lando
2020-03-17 14:52:58 +00:00
Markus Stange
93518320ab Bug 1620097 - Add markers and labels for category service observer notifications. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D66074

--HG--
extra : moz-landing-system : lando
2020-03-17 04:11:35 +00:00
André Bargull
0105311d41 Bug 1618258 - Part 1: Rename FinalizationGroup to FinalizationRegistry. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D66930

--HG--
rename : js/src/builtin/FinalizationGroupObject.cpp => js/src/builtin/FinalizationRegistryObject.cpp
rename : js/src/builtin/FinalizationGroupObject.h => js/src/builtin/FinalizationRegistryObject.h
rename : js/src/gc/FinalizationGroup.cpp => js/src/gc/FinalizationRegistry.cpp
extra : moz-landing-system : lando
2020-03-16 10:41:08 +00:00
Lina Cambridge
9697819fb5 Bug 1622082 - Expose NS_CreateBackgroundTaskQueue to moz_task. r=KrisWright
This commit moves `NS_CreateBackgroundTaskQueue` into an `extern "C"`
block, adds a `create_background_task_queue` function to `moz_task`,
and makes it possible to dispatch Rust `TaskRunnable`s to any event
target, instead of just an `nsIThread`.

Differential Revision: https://phabricator.services.mozilla.com/D66700

--HG--
extra : moz-landing-system : lando
2020-03-13 21:15:51 +00:00
Kartikaya Gupta
6d4a82e018 Bug 1617427 - Add a DOMWindowUtils API to disable APZ on a particular element. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D66424

--HG--
extra : moz-landing-system : lando
2020-03-13 19:56:33 +00:00
Toshihito Kikuchi
3bc1f2c50b Bug 1605308 - Do not use ShellExecuteByExplorer when a downloaded file is an executable. r=Gijs,froydnj
This is one of the efforts to reduce usage of `ShellExecuteByExplorer`
(bug 1620335).

The purpose of using `ShellExecuteByExplorer` in the scenario to open a
downloaded file is to support applications which are not compatible with
the mitigation policies of our process.  When a downloaded file is an
executable, however, we prefer security to compatibility and in particular
we want to prevent binary planting on a user's download directory.

The proposed fix is to go to `ShellExecuteExW` straight if the target
file to launch is an executable.

Differential Revision: https://phabricator.services.mozilla.com/D66325

--HG--
extra : moz-landing-system : lando
2020-03-12 22:05:34 +00:00
Cosmin Sabou
e7343ec23b Backed out changeset 01cef3030838 (bug 1605308) for build bustages on nsLocalFileWin.cpp
CLOSED TREE
2020-03-12 23:26:54 +02:00
Toshihito Kikuchi
156f519842 Bug 1605308 - Do not use ShellExecuteByExplorer when a downloaded file is an executable. r=Gijs,froydnj
This is one of the efforts to reduce usage of `ShellExecuteByExplorer`
(bug 1620335).

The purpose of using `ShellExecuteByExplorer` in the scenario to open a
downloaded file is to support applications which are not compatible with
the mitigation policies of our process.  When a downloaded file is an
executable, however, we prefer security to compatibility and in particular
we want to prevent binary planting on a user's download directory.

The proposed fix is to go to `ShellExecuteExW` straight if the target
file to launch is an executable.

Differential Revision: https://phabricator.services.mozilla.com/D66325

--HG--
extra : moz-landing-system : lando
2020-03-12 21:05:24 +00:00
Simon Giesecke
ec9babdc85 Bug 1617170 - Move DECLARE_USE_COPY_CONSTRUCTORS for StructuredCloneReadInfo to dom/indexedDB/IndexedDatabase.h r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D65293

--HG--
extra : moz-landing-system : lando
2020-03-11 16:53:20 +00:00
David Teller
28e34497c9 Bug 1589493 - Extending BrowserTestUtils.crashFrame to allow crashing with an OOM;r=mconley,froydnj,dmajor
BrowserTestUtils.crashFrame now accepts additional `options`, with an argument `crashType` that may
take "CRASH_OOM" or "CRASH_INVALID_POINTER_DEREF"|null to specify the nature of the crash. The names
are taken from CrashTestUtils.jsm but this module cannot be imported as such as it has non-trivial
binary dependencies.

Depends on D54130

Differential Revision: https://phabricator.services.mozilla.com/D54700

--HG--
extra : moz-landing-system : lando
2020-03-10 14:00:27 +00:00
Oana Pop Rus
9bbf887ea0 Merge autoland to mozilla-central. a=merge 2020-03-09 23:47:11 +02:00
ffxbld
7a35fa9703 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2020-03-09 15:41:51 +00:00
Andrew McCreight
f138cbb009 Bug 1619229, part 3 - Incrementally finalize for most internal GCs. r=smaug
Right now, we sync finalize for a sync GC, even if it is triggered by the JS
engine itself. This can cause issues because the finalizer can run JS, which
can break assumptions made by the JIT.

This patch avoids that by running the finalizers incrementally for most internal
GC triggers. We still run sync for DESTROY_RUNTIME because we're going to shut
down right away.

Differential Revision: https://phabricator.services.mozilla.com/D65649

--HG--
extra : moz-landing-system : lando
2020-03-06 13:23:32 +00:00
Andrew McCreight
d8ecfbc863 Bug 1619229, part 1 - Thread GC reason into the GC callback. r=sfink
Differential Revision: https://phabricator.services.mozilla.com/D65647

--HG--
extra : moz-landing-system : lando
2020-03-08 23:22:39 +00:00
Emma Malysz
ff6fc06f79 Bug 1619317, ensure we set isWow64 to the correct value after taking it off the main thread r=aklotz
Differential Revision: https://phabricator.services.mozilla.com/D65127

--HG--
extra : moz-landing-system : lando
2020-03-09 14:29:32 +00:00
Boris Zbarsky
61e0515f43 Bug 1618011 part 6. Pass a BindingCallContext (if neded) and source description to primitive conversions. r=peterv
The BindingCallContext tracks what method the conversion is for, and the source
description is how the primitive is involved in that method (e.g. "argument 5").

Differential Revision: https://phabricator.services.mozilla.com/D64887

--HG--
extra : moz-landing-system : lando
2020-03-06 23:05:16 +00:00
Arthur Iakab
14247fb057 Backed out 11 changesets (bug 1618011)for Linting failure.
CLOSED TREE

Backed out changeset 8b11ddd8999f (bug 1618011)
Backed out changeset 11df2f359473 (bug 1618011)
Backed out changeset c50121035d50 (bug 1618011)
Backed out changeset 8b8c4c60c34b (bug 1618011)
Backed out changeset b01f8c66110b (bug 1618011)
Backed out changeset 433fdf04058c (bug 1618011)
Backed out changeset 29a9227d08ac (bug 1618011)
Backed out changeset b2dfa2e66d24 (bug 1618011)
Backed out changeset 85650ee945c4 (bug 1618011)
Backed out changeset 278a213e5304 (bug 1618011)
Backed out changeset 9119aeb72ea4 (bug 1618011)
2020-03-07 00:15:57 +02:00
Boris Zbarsky
0a681b4df5 Bug 1618011 part 6. Pass a BindingCallContext (if neded) and source description to primitive conversions. r=peterv
The BindingCallContext tracks what method the conversion is for, and the source
description is how the primitive is involved in that method (e.g. "argument 5").

Differential Revision: https://phabricator.services.mozilla.com/D64887

--HG--
extra : moz-landing-system : lando
2020-03-06 20:38:55 +00:00
Markus Stange
aae2ad8790 Bug 1616400 - Do not recreate the inner reader for nested omni.ja archives if the Omnijar already has it. r=aklotz
This is already done for the outer nsJAR, but it wasn't done for the inner nsJAR.
(The omnijar is a nested zip archive on Android: the outer archive is the APK and the inner is the omnijar file.)
So we were re-using the file mapping but not the result of the uncompression.

Differential Revision: https://phabricator.services.mozilla.com/D63970

--HG--
extra : moz-landing-system : lando
2020-03-06 20:35:53 +00:00
Boris Zbarsky
4a89a400e1 Bug 1600331. When an idle runnable is queued from a background thread, lazily queue it from a non-idle runnable. r=smaug
Idle runnables do weird things involving unlocking the event queue mutex while
looking for runnables, such that queueing one from off the main thread might
cause it to basically never run if it gets queued during one of those
temporary-unlock periods.

Differential Revision: https://phabricator.services.mozilla.com/D65019

--HG--
extra : moz-landing-system : lando
2020-03-03 01:47:24 +00:00
Simon Giesecke
2d1ae94059 Bug 1619260 - Prevent assertion when processing nsStringBuffer leaks. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D64949

--HG--
extra : moz-landing-system : lando
2020-03-02 14:31:09 +00:00
Marco Zehe
6d5bea032c Bug 1608961 - Support ARIA 1.3 aria-description property, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D64283

--HG--
extra : moz-landing-system : lando
2020-03-02 10:59:22 +00:00
Simon Giesecke
41c3e177f8 Bug 1618186 - Remove AnyStaticMutex. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D64358

--HG--
extra : moz-landing-system : lando
2020-02-28 14:24:21 +00:00
Marco Zehe
93ff1614a5 Bug 1608965 Part 2 - Add ARIA suggestion role, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D64546

--HG--
extra : moz-landing-system : lando
2020-03-01 19:37:33 +00:00
Mike Shal
43842108f2 Bug 1618620 - Convert ErrorList.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D64621

--HG--
extra : moz-landing-system : lando
2020-02-28 00:28:17 +00:00
Mike Shal
449e9c0820 Bug 1618620 - Convert gen_static_components.py to py3; r=firefox-build-system-reviewers,rstewart
Note that perfecthash.py is also used by other scripts, so it needs to
remain py2 compatible for now.

Differential Revision: https://phabricator.services.mozilla.com/D64620

--HG--
extra : moz-landing-system : lando
2020-02-28 21:27:17 +00:00
Tooru Fujisawa
9939f785e0 Bug 1612515 - Part 4: Move RunCBindgen.py to /build. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D64541

--HG--
rename : layout/style/RunCbindgen.py => build/RunCbindgen.py
extra : moz-landing-system : lando
2020-02-28 14:07:15 +00:00
Simon Giesecke
69b996524d Bug 1618165 - Provide BaseAutoLock and BaseAutoUnlock deduction guides for Mutex references. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D64359

--HG--
extra : moz-landing-system : lando
2020-02-28 07:59:30 +00:00
Razvan Maries
166e40b3c8 Backed out changeset b6ce0a07d782 (bug 1618165) for build bustages on WeakRef.cpp. CLOSED TREE 2020-02-27 23:13:40 +02:00
Simon Giesecke
81fcf51f06 Bug 1618165 - Provide BaseAutoLock and BaseAutoUnlock deduction guides for Mutex references. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D64359

--HG--
extra : moz-landing-system : lando
2020-02-27 15:37:41 +00:00
Andrew McCreight
4babb2b5ab Bug 1609815 - Remove Web Replay C++ implementation. r=jgilbert,jandem,gbrown
Patch by bhackett and jlaster. Also reviewed by mccr8.

Differential Revision: https://phabricator.services.mozilla.com/D60197

--HG--
extra : moz-landing-system : lando
2020-02-27 17:39:15 +00:00
Emilio Cobos Álvarez
87e0a1e02f Bug 1613564 - Minor nsstring cleanup / tweaks. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63968

--HG--
extra : moz-landing-system : lando
2020-02-27 15:42:58 +00:00
Ciure Andrei
00dd87f6f4 Backed out changeset d407a28318e6 (bug 1609815) for causing windows ming bustages CLOSED TREE
--HG--
extra : histedit_source : b2c748e31e0f6ba8fcf9960a336e0bbd361b07e6
2020-02-27 07:05:19 +02:00