Commit Graph

223 Commits

Author SHA1 Message Date
Matthew Noorenberghe
280f3dd879 Bug 1581969 - Don’t activate the newSavedLogin trigger on accounts.firefox.com. r=jaws
The user may be in the process of setting up Sync so prompting to setup login Sync from a CFR would be untimely.

Differential Revision: https://phabricator.services.mozilla.com/D46252

--HG--
extra : moz-landing-system : lando
2019-09-22 09:58:47 +00:00
Andrei Oprea
27712eefb8 Bug 1577148 - Open What's New Panel message links with the keyboard r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D46150

--HG--
extra : moz-landing-system : lando
2019-09-17 18:56:03 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Ed Lee
fd0c14a1da Bug 1581195 - Add bookmarked CFR, errored snippet and bug fixes to New Tab Page r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D45892

--HG--
extra : moz-landing-system : lando
2019-09-13 22:57:40 +00:00
Liang-Heng Chen
223988a9dd Bug 1570631 - Part 3: implement doorhangers using CFR; r=k88hudson
#   add `OPEN_PROTECTION_PANEL` command
  #   add `type` trigger matching
  #   add `trackingProtection` trigger listener
  #   add socialtracker/fingerprinter/cryptominer doorhangers

Differential Revision: https://phabricator.services.mozilla.com/D43084

--HG--
extra : moz-landing-system : lando
2019-09-11 09:16:49 +00:00
Liang-Heng Chen
2744750d67 Bug 1570631 - Part 1.1: popup enhancement; r=k88hudson
# support `recommendation.content.anchor_id`
  # support `recommendation.content.skip_address_bar_notifier`
  # support `recommendation.content.learn_more`
  # support `recommendation.content.icon_dark_theme`
  # support `recommendation.content.icon_class`

Differential Revision: https://phabricator.services.mozilla.com/D44177

--HG--
extra : moz-landing-system : lando
2019-09-11 09:16:49 +00:00
Liang-Heng Chen
fdd785b020 Bug 1570631 - Part 1: refactoring; r=k88hudson,andreio
1. extract generation of `secondaryActions` to make one-secondary-button possible
2. exteact `addImpression`
3. extract `showPopup`

Differential Revision: https://phabricator.services.mozilla.com/D43606

--HG--
extra : moz-landing-system : lando
2019-09-11 08:53:50 +00:00
Ed Lee
a38c7e2387 Bug 1579949 - Add text-promo designs, after-login triplets and bug fixes to New Tab Page r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D45225

--HG--
extra : moz-landing-system : lando
2019-09-10 20:58:43 +00:00
Andrei Oprea
50158a6799 Bug 1578236 - Add back the CFR message after navigating between tabs when a host is not defined r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D44804

--HG--
extra : moz-landing-system : lando
2019-09-05 17:12:45 +00:00
Andrei Oprea
95146c9c2f Bug 1571022 - Conditional rendering for CFR feature recommendations r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D43630

--HG--
extra : moz-landing-system : lando
2019-08-31 00:02:44 +00:00
Ed Lee
3fcd7e0edd Bug 1577888 - Add whatsnew badge, optimistic cards and bug fixes to New Tab Page r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D44271

--HG--
extra : moz-landing-system : lando
2019-08-30 23:28:49 +00:00
Matthew Noorenberghe
a41be805f6 Bug 1574812 - Don't try...catch routeMessageToTarget, only the sendAsyncMessage. r=Mardak
As far as I can tell the try...catch was originally added around various sendAsyncMessage calls but then when some logic got moved to a helper, the try...catch didn't move along with it. This try...catch made it very annoying to debug an issue with bug 1570372 because it swallowed errors that were getting thrown. It doesn't seem like a good idea to swallow all errors for large pieces of code.

Differential Revision: https://phabricator.services.mozilla.com/D43863

--HG--
extra : moz-landing-system : lando
2019-08-29 05:03:30 +00:00
Andrei Oprea
8f00553d5f Bug 1577458 - Add fluent branding files to Whats New Panel r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D43964

--HG--
extra : moz-landing-system : lando
2019-08-29 14:12:59 +00:00
Ed Lee
34ee136dbf Bug 1577331 - Add TopSites spocs, promo backend and bug fixes to New Tab Page r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D43830

--HG--
extra : moz-landing-system : lando
2019-08-28 22:08:51 +00:00
Andrei Oprea
0ec4eb4e31 Bug 1570983 - The What's New Panel is wrongly dismissed r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D43248

--HG--
extra : moz-landing-system : lando
2019-08-26 20:14:50 +00:00
Nihanth Subramanya
05165a0bf7 Bug 1575346 - Add offset for info message when setting subview max-height. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D43337

--HG--
extra : moz-landing-system : lando
2019-08-24 19:28:06 +00:00
Ed Lee
3cf7e1697b Bug 1576284 - Add Firefox wordmark, protection template and bug fixes to New Tab Page r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D43310

--HG--
extra : moz-landing-system : lando
2019-08-24 06:35:25 +00:00
Coroiu Cristina
07bbadf755 Backed out changeset 2aa1a97003cb (bug 1576284) for browser-chrome failures at browser/base/content/test/performance/browser_startup_mainthreadio.js 2019-08-24 08:00:00 +03:00
Ed Lee
52996d5c83 Bug 1576284 - Add Firefox wordmark, protection template and bug fixes to New Tab Page r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D43310

--HG--
extra : moz-landing-system : lando
2019-08-24 00:54:23 +00:00
Emily McMinn
71497c28dc Bug 1572551 - Added tooltip for "Recommended Extension" and "Recommended Feature" icons r=k88hudson
Added tooltip for "Recommended Extension" and "Recommended Feature" icons. This covers both bug #1572551 and #1572555.

Differential Revision: https://phabricator.services.mozilla.com/D42669

--HG--
extra : moz-landing-system : lando
2019-08-21 14:48:12 +00:00
Thomas Nguyen
bbd6f51a56 Bug 1528697 - Add cenum referrerpolicy in ReferrerInfo.idl r=ckerschb,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D41955

--HG--
extra : moz-landing-system : lando
2019-08-21 13:28:23 +00:00
Thomas Nguyen
fe6a6a4285 Bug 1567940 Apply ReferrerInfo to Download and fix Go to Download Page button r=Gijs,dimi
In the old way, if referrer is ommited we will not be able to go to
download page. In that case, we should use originalReferrer in
ReferrerInfo object

Differential Revision: https://phabricator.services.mozilla.com/D39875

--HG--
extra : moz-landing-system : lando
2019-08-20 16:22:44 +00:00
Nan Jiang
0ce65ed8c4 Bug 1575228 - Bump the holdback group to 5% for extended triplets rollout r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D42652

--HG--
extra : moz-landing-system : lando
2019-08-20 15:12:24 +00:00
Emily McMinn
1aed975eea Bug 1565159 - Added keyboard access to WhatsNew panel messages r=k88hudson,andreio
Replaced the message body div with an unstyled button element, which creates the correct tabbing behavior.

Differential Revision: https://phabricator.services.mozilla.com/D41829

--HG--
extra : moz-landing-system : lando
2019-08-19 19:02:17 +00:00
Mark Banner
b1970e6a2f Bug 1571466 - Cleanup unnecessary ESLint global definitions. r=mossop
These are raised as redeclares or unused variables by ESLint 6.

Differential Revision: https://phabricator.services.mozilla.com/D37268

--HG--
extra : moz-landing-system : lando
2019-08-19 07:11:56 +00:00
Matthew Noorenberghe
4f572e67ba Bug 1570372 - Add a newSavedLogin CFR trigger for when a login is saved from a doorhanger. r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D42074

--HG--
extra : moz-landing-system : lando
2019-08-15 18:48:14 +00:00
Ed Lee
5ff7943b7d Bug 1574334 - Add lazy cards, story engagements and bug fixes to New Tab Page r=pdahiya,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D42229

--HG--
extra : moz-landing-system : lando
2019-08-16 05:54:16 +00:00
Scott
612df20386 Bug 1573930 - FF prefs to control DS and mitigation strat r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D42064

--HG--
extra : moz-landing-system : lando
2019-08-15 13:01:26 +00:00
Ed Lee
ca11959d3e Bug 1573174 - Add Pocket footers, Monitor adjustments and bug fixes to New Tab Page r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D41669

--HG--
extra : moz-landing-system : lando
2019-08-13 02:22:39 +00:00
mandy cheang
09055a1aae Bug 1568197 - load JSMs lazily in ActivityStream.jsm and OnboardingMessageProvider.jsm. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D40461

--HG--
extra : moz-landing-system : lando
2019-08-12 19:03:31 +00:00
Ed Lee
01f019235c Bug 1572640 - Add triplets animation, RTAMO installation and bug fixes to New Tab Page r=k88hudson,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D41328

--HG--
extra : moz-landing-system : lando
2019-08-09 13:38:11 +00:00
Kate Hudson
0fb9a5f7e3 Bug 1570481 - Update and reorder set of first run cards r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D41234

--HG--
extra : moz-landing-system : lando
2019-08-08 17:19:14 +00:00
Jared Wein
776e7c17fb Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D40745

--HG--
extra : moz-landing-system : lando
2019-08-08 15:18:49 +00:00
Bogdan Tara
844afcfb06 Backed out 10 changesets (bug 1571567) complementary backout after es lint failure on the patch CLOSED TREE
Backed out changeset ce83fa75ae32 (bug 1571567)
Backed out changeset 7aa97ba7cce9 (bug 1571567)
Backed out changeset 777d79076e99 (bug 1571567)
Backed out changeset fbdf6b75a484 (bug 1571567)
Backed out changeset e2ed4620f232 (bug 1571567)
Backed out changeset 2c67015f12c6 (bug 1571567)
Backed out changeset 7ec086bb5bd5 (bug 1571567)
Backed out changeset 42df735c8556 (bug 1571567)
Backed out changeset 7d5fc57b2809 (bug 1571567)
Backed out changeset 606bafb8211c (bug 1571567)
2019-08-08 18:13:54 +03:00
Jared Wein
bfdcad7ada Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D40745

--HG--
extra : moz-landing-system : lando
2019-08-08 01:38:50 +00:00
Ed Lee
9775cca0a1 Bug 1571115 - Add context message, react-transition-group package and bug fixes to New Tab Page r=k88hudson,fluent-reviewers,flod
Depends on D40119

Differential Revision: https://phabricator.services.mozilla.com/D41092

--HG--
extra : moz-landing-system : lando
2019-08-08 05:36:24 +00:00
Andrei Oprea
4ecf5f7454 Bug 1567522 - Show info message in the Protection panel. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D39042

--HG--
extra : moz-landing-system : lando
2019-08-07 17:57:48 +00:00
Andrei Oprea
62370fbd48 Bug 1533846 - Clear WeakMap entries for Messaging System notifications r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D40432

--HG--
extra : moz-landing-system : lando
2019-08-06 09:26:33 +00:00
Andrei Oprea
0baa66f01b Bug 1570935 - Remove clip-path property for causing performance regression r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D40414

--HG--
extra : moz-landing-system : lando
2019-08-02 15:39:15 +00:00
Brindusan Cristian
d90b71c656 Backed out changeset 2d2938a3bee6 (bug 1533846) for bc failures at browser_asrouter_toolbarbadge.js. CLOSED TREE 2019-08-05 14:40:08 +03:00
Andrei Oprea
2255219c63 Bug 1533846 - Clear WeakMap entries for Messaging System notifications r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D40432

--HG--
extra : moz-landing-system : lando
2019-08-05 08:50:22 +00:00
Kate Hudson
9d98f6740c Bug 1570745 - Add extended triplets, moments page mechanism, special snippet r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D40277

--HG--
extra : moz-landing-system : lando
2019-08-02 18:33:30 +00:00
arthur.iakab
30ac545240 Backed out changeset d780672e184a (bug 1570745) for causing browser chrome failures on browser_asrouter_toolbarbadge.js CLOSED TREE 2019-08-02 18:58:58 +03:00
Kate Hudson
28c7fb1eb0 Bug 1570745 - Add extended triplets, moments page mechanism, special snippet r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D40277

--HG--
extra : moz-landing-system : lando
2019-08-02 14:54:45 +00:00
Andrei Oprea
061101f9e1 Bug 1561547 - Use Messaging System to badge the FxA accounts toolbar button r=r1cky
Differential Revision: https://phabricator.services.mozilla.com/D37879

--HG--
extra : moz-landing-system : lando
2019-07-31 19:39:34 +00:00
Ed Lee
f7d0d30b65 Bug 1569306 - Add trailhead cards, accessibile headers and bug fixes to New Tab Page r=k88hudson,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D39561

--HG--
extra : moz-landing-system : lando
2019-07-29 06:55:43 +00:00
Bogdan Tara
dfedc5dd8a Backed out changeset 2cb4cc20ea9d (bug 1569306) for gecko decision bustage CLOSED TREE 2019-07-29 09:46:16 +03:00
Ed Lee
97c5d52826 Bug 1569306 - Add trailhead cards, accessibile headers and bug fixes to New Tab Page r=k88hudson,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D39561

--HG--
extra : moz-landing-system : lando
2019-07-29 06:30:12 +00:00
Marco Bonardo
44ccf4da4e Bug 1569217 - Use single quoted literals in IFNULL, NULLIF, COALESCE. r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D39514

--HG--
extra : moz-landing-system : lando
2019-07-26 15:53:55 +00:00
Bogdan Tara
f78b8d0022 Backed out changeset 3ecae0d7af5e (bug 1561547) for browser_startup_flicker.js failures CLOSED TREE 2019-07-24 19:22:24 +03:00