Commit Graph

1533 Commits

Author SHA1 Message Date
Edward Lee
eddf2bd551 Bug 463459 - Use a separate pref instead of empty restrict/match values to specify defaults. r=dietrich, a1.9.1=beltzner 2008-12-10 10:58:43 -06:00
Robert Kaiser
3a5b06705b fix up my test bustage by removing a spurious { the review didn't catch, not sure why I did put it there, sorry. 2008-12-10 14:33:52 +01:00
Robert Kaiser
027bd4b1b3 bug 468341 - Some toolkit places tests fail on SeaMonkey unit test boxes - make tests mor tolerant to default prefs, non-override DOM error messages, non-existing browser-specific services and protcol defintions, r=sdwilsh a=tests-only 2008-12-10 13:18:14 +01:00
Marco Bonardo
e86d32227f followup to Bug 431558 - implement preventive maintenance for places.sqlite, remove observer on test finish, r=sdwilsh 2008-12-10 11:44:01 +01:00
Dietrich Ayala
8cc50e63d7 Bug 463513 - Tagging service could hold a fixed cache instead of an open node, r=mak77 2008-12-10 11:40:13 +01:00
Shawn Wilsher
fe66178c10 Bug 466582 - smarter handling of remote chrome (and not allowing it)
This adds a new flag, URI_IS_LOCAL_RESOURCE, to nsIProtocolHandler that allows
something of this protocol to be registered in chrome.

This changeset removes a runtime check every time we open a chrome channel to
see if it is remote to a registration time check that checks flags.  The old
code could be easily worked around, and allowed for remote resources to be used.

r=bsmedberg
r=bz
sr=bz
2008-12-09 16:27:42 -05:00
Marco Bonardo
6ad8f55fc3 Bug 465510 - random failures on test_database_sync_after_addVisit.js, r=sdwilsh 2008-12-09 21:39:32 +01:00
Marco Bonardo
28e377dc8d Bug 467971 - random failures on test_multiple_visits_around_sync.js, r=sdwilsh 2008-12-09 21:39:32 +01:00
Marco Bonardo
dacc704011 Bug 431558 - implement preventive maintenance for places.sqlite, r=dietrich 2008-12-09 21:39:32 +01:00
Shawn Wilsher
205d129c10 Backed out changeset b6f762fde736 (bug 466582) for unit test orange. 2008-12-08 18:51:46 -05:00
Shawn Wilsher
2a28a8b2b1 Bug 466582 - smarter handling of remote chrome (and not allowing it)
r=bsmedberg, r=bz, sr=bz
2008-12-08 17:14:14 -05:00
Daniel Holbert
20e31abd7a Bug 418643 trivial follow-up: Remove unneded 'typedef' token, in 'typedef struct folderChildrenInfo { ...', to fix compiler warning. r=sdwilsh 2008-12-07 11:56:39 -08:00
Marco Bonardo
c6585034a9 ug 466303 - When removing bookmark backups remove also old html ones, r=dietrich 2008-12-05 16:27:23 +01:00
Marco Bonardo
4f8ca57707 Bug 460119 - Convert autocomplete feedback increase to an async query, r=dietrich 2008-12-04 16:41:06 +01:00
Marco Bonardo
eeef97ba32 Bug 423139 - BOOKMARK_REDIRECT_TIME_THRESHOLD is weird, r=dietrich 2008-12-04 16:11:04 +01:00
Marco Bonardo
f43a4b2785 Bug 460830 - Tag containers and queries have bogus QUERY_TYPE definition, r=dietrich 2008-12-04 16:01:19 +01:00
Marco Bonardo
9d047df9a0 Bug 463863 - Download history not shown in Places history, r=dietrich, ui-r=beltzner 2008-12-04 13:59:04 +01:00
Marco Bonardo
ec68772557 backing out bug 414715 due to possible Ts regression 2008-11-27 16:10:36 +01:00
Dietrich Ayala
2ed8d0e593 Bug 414715. Notify the user if places.sqlite is locked. r=pike, r=mak77, ui-review=faaborg, a=blocking-firefox3.1 2008-11-26 20:59:47 -05:00
mak77@bonardo.net
0ccda1ba20 Bug 463471 - temp tables are not correctly synced to disk when the user clear private data on shutdown (r=sdwilsh, r=dietrich) 2008-11-13 22:45:49 -08:00
Ehsan Akhgari
725a61af3c Bug 461710 - Write an automated test to ensure that visited link coloring is turned off in private browsing mode (further fixes); r=dietrich (NPOTB) 2008-11-13 23:12:03 +03:30
Dietrich Ayala
6bf15180d8 Fix for bug 445704 (JSON bookmarks backup has localized filename (and can't be easily restored). r=zeniko, a=beltzner. 2008-11-13 17:54:25 +01:00
Marco Bonardo
0b3ae28218 backout test for bug 463471 causing orange 2008-11-13 11:33:01 +01:00
Dietrich Ayala
5e5d254f63 [mq]: backout-bug-463471 2008-11-12 23:50:19 -08:00
Marco Bonardo
083c4c9d26 Bug 463471 - temp tables are not correctly synced to disk when the user clear private data on shutdown, r=dietrich, sdwilsh a=beltzner 2008-11-12 21:50:02 +01:00
Marco Bonardo
db938e81e9 Bug 462366 - correct bogus importBookmarksHTML behaviour, r=dietrich a=beltzner 2008-11-12 21:45:53 +01:00
Edward Lee
bca5e2de96 Bug 463661 - Create a pref to control the location bar search sources (history, bookmark, both, none). r=dietrich, a1.9.1b2=beltzner
Bug 463535 - Continuing search immediately after changing prefs give wrong results
2008-11-10 10:04:36 -06:00
Marco Bonardo
58f4661b50 Bug 459493 - remove placesBackground, r+a=mconnor 2008-11-06 23:22:10 +01:00
mak77@bonardo.net
91d78ac749 Bug 418643 - Bookmark folder deletion executes too many SQL statements (r=dietrich) 2008-11-05 14:02:12 -08:00
Dietrich Ayala
8e667ace8a Bug 419792 - Use optimized query to get tags for nsNavHistoryResultNode (r=mano) 2008-11-05 10:20:00 -08:00
Dietrich Ayala
847e2d6bcc Bug 457473 - Bookmark copy creates bookmark with duplicate guid - regression in FF 3.0.3 (r=mano) 2008-11-05 10:15:49 -08:00
Shawn Wilsher
e3aac65f0c Bug 453180 - Adding moz_annos_placeattributeindex should be done in migration code not shutdown
r=dietrich
2008-11-03 22:41:16 -05:00
Shawn Wilsher
bde8862b7a Bug 453179 - Remove unused indecies in a migration code path - not shutdown
r=dietrich
2008-11-03 22:41:15 -05:00
Shawn Wilsher
4dfcbd54b5 Bug 453177 - Move moz_places.user_title removal back to MigrateV6Up
r=dietrich
2008-11-03 22:41:15 -05:00
Ehsan Akhgari
8541e60302 Bug 461710 - Write an automated test to ensure that visited link coloring is turned off in private browsing mode; r=dietrich 2008-11-04 02:52:23 +03:30
Ehsan Akhgari
b8a5cb58c9 Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [Places unit test fix]; r=dietrich 2008-11-04 02:52:22 +03:30
Ehsan Akhgari
c078acab37 Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [unit test API changes]; r,sr=mconnor 2008-11-04 02:52:22 +03:30
Dietrich Ayala
8cc8a04b63 Bug 462379 - (NS_ERROR_FAILURE) [nsINavBookmarksService.insertBookmark] when trying to star a bookmark (r=sdwilsh, for marco, sdwilsh) 2008-10-31 17:59:38 -07:00
Dietrich Ayala
6ac4e61f10 Bug 415960 - bookmark tags edit control should provide autocomplete (r=mano, core by asouzis@users.sf.net) 2008-10-31 09:16:22 -07:00
Dietrich Ayala
3da086a9c9 backing out bug 462379 due to persistent test failures 2008-10-30 23:11:04 -07:00
Edward Lee
f1472613c5 More bug 462379 followup (both == 2) rs=sdwilsh 2008-10-30 20:30:35 -05:00
Dietrich Ayala
22a04cd7f2 bug 462379 followup (for sdwilsh@forerunnerdesigns.com) 2008-10-30 16:36:14 -07:00
Shawn Wilsher
8a7df4c6aa Bug 462379 - (NS_ERROR_FAILURE) [nsINavBookmarksService.insertBookmark] when trying to star a bookmark
r=dietrich
2008-10-30 17:20:33 -04:00
Marco Bonardo
caedf6ca4c Bug 462206 - finalize statements in nsPlacesDBFlush, r=sdwilsh 2008-10-30 09:51:34 +01:00
Marco Bonardo
0b5b8f64ca Bug 462205 - add statementCallback interface to nsPlacesDBFlush, r=sdwilsh 2008-10-30 09:45:21 +01:00
Marco Bonardo
a05f287958 Bug 462204 - Don't try to cancel a not existant timer in nsPlacesDBFlush, r=sdwilsh 2008-10-30 09:42:36 +01:00
Marco Bonardo
5f64e01cf3 Bug 462213 - make migrateV8 tolerant to downgrade-upgrade paths, r=sdwilsh 2008-10-30 09:37:49 +01:00
Shawn Wilsher
2ebdec533a Bug 462047 - nsPlacesDBFlush.js should have an error handler.
This changeset adds the handleError method from mozIStorageStatementCallback to
nsPlacesDBFlush so we can report errors to the error console if they occur.
r=dietrich
2008-10-28 17:44:35 -04:00
Marco Bonardo
d06f0e2486 Bug 460947 - fsync stuff has a wrong query for expiration sites cap
r=dietrich
2008-10-27 18:52:23 -04:00
Marco Bonardo
bf1db1a23a Bug 459934 - should lazy-load places autocomplete statements
r=dietrich
r=sdwilsh
2008-10-27 18:52:23 -04:00
Shawn Wilsher
a776db5391 Bug 459789 - lazily get mDB[Invalid|Old]Frecencies
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
ba67e3dc04 Bug 459788 - Lazily get mDBBookmarkToUrlResult
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
2452632409 Bug 459786 - lazily get mDBVisitTo[Visit|URL]Result
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
09427291bc Bug 459787 - remove mDBUrlToUrlResult
This changeset removes an unused query that was in the startup path.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
3673b405f4 Bug 459781 - create our string bundle in a more sane way
This changeset only creates the string bundle when we need it, and only in one
place as opposed to two separate places.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
cf3da2eccf Bug 459776 - date formatter is unused
This changeset removes a small part of code that places does in startup that is
not used or needed.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
c2c58ede5b Bug 459773 - Creating a collation is expensive
This makes a lazy getter for getting our collation saving us about 3% of places
startup time.
r=dietrich
2008-10-27 18:52:21 -04:00
Marco Bonardo
1e25281a87 Bug 455474 - cleanup nsNavBookmarks::Init
r=dietrich
2008-10-27 18:52:21 -04:00
Marco Bonardo
636252beee Bug 459491 - nsPlacesDBFlush could use async queries instead of background thread
r=sdwilsh

--HG--
rename : toolkit/components/places/tests/background/head_background.js => toolkit/components/places/tests/sync/head_sync.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_modifyBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_modifyBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_quit_application.js => toolkit/components/places/tests/sync/test_database_sync_after_quit_application.js
rename : toolkit/components/places/tests/background/test_multiple_bookmarks_around_sync.js => toolkit/components/places/tests/sync/test_multiple_bookmarks_around_sync.js
rename : toolkit/components/places/tests/background/test_multiple_visits_around_sync.js => toolkit/components/places/tests/sync/test_multiple_visits_around_sync.js
2008-10-27 18:52:21 -04:00
Shawn Wilsher
51ee94d2ad Bug 459315 - Wrap favicon work in a transaction
This wraps a series of statements that run on the main thread to reduce the
number of fsyncs that end up happening.
r=dietrich
2008-10-27 18:52:21 -04:00
Shawn Wilsher
fe1e270944 Bug 459299 - nsNavHistory::SetPageTitleInternal is slow
This caches a statement that is created any time a pages title changes.  The
creation of the statement took roughly 66% of the functions execution time
according to shark.
It also removes a transaction that was not needed in this method.
r=dietrich
2008-10-27 18:52:21 -04:00
Marco Bonardo
3d0d41ee56 Bug 456029 - optimize the temp table triggers
This changeset makes the triggers work much faster which should greatly reduce
the timings of adding a visit and a bookmark.
r=sdwilsh
2008-10-27 18:52:21 -04:00
Shawn Wilsher
3f60a72d69 Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77
2008-10-27 18:52:20 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
febae1a322 Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-27 18:52:20 -04:00
Shawn Wilsher
7d6c83e21f Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-10-27 18:52:19 -04:00
Ehsan Akhgari
202ab53e20 Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [places part]; r=dietrich 2008-10-20 00:44:59 +03:30
Shawn Wilsher
829fc431ab Backout places fsync changes 2008-10-17 12:29:34 -04:00
Marco Bonardo
5d71eb1aea followup to bug 459934, fix memory leak, mpa=mano, for post facto review 2008-10-17 08:56:25 -04:00
Marco Bonardo
31179017d1 Bug 459934 - should lazy-load places autocomplete statements
r=dietrich
r=sdwilsh
2008-10-17 06:12:53 -04:00
Shawn Wilsher
30a43bf34a Bug 459789 - lazily get mDB[Invalid|Old]Frecencies
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
69ca4066be Bug 459788 - Lazily get mDBBookmarkToUrlResult
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
6e74a7cc96 Bug 459786 - lazily get mDBVisitTo[Visit|URL]Result
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
0630ed6ac5 Bug 459787 - remove mDBUrlToUrlResult
This changeset removes an unused query that was in the startup path.
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
1bf6dc8334 Bug 459781 - create our string bundle in a more sane way
This changeset only creates the string bundle when we need it, and only in one
place as opposed to two separate places.
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
fa8ebfbf47 Bug 459776 - date formatter is unused
This changeset removes a small part of code that places does in startup that is
not used or needed.
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
a3921cb60e Bug 459773 - Creating a collation is expensive
This makes a lazy getter for getting our collation saving us about 3% of places
startup time.
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
a34b89c878 Bug 455474 - cleanup nsNavBookmarks::Init
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
6a40b81d8f Bug 459491 - nsPlacesDBFlush could use async queries instead of background thread
r=sdwilsh

--HG--
rename : toolkit/components/places/tests/background/head_background.js => toolkit/components/places/tests/sync/head_sync.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_modifyBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_modifyBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_quit_application.js => toolkit/components/places/tests/sync/test_database_sync_after_quit_application.js
rename : toolkit/components/places/tests/background/test_multiple_bookmarks_around_sync.js => toolkit/components/places/tests/sync/test_multiple_bookmarks_around_sync.js
rename : toolkit/components/places/tests/background/test_multiple_visits_around_sync.js => toolkit/components/places/tests/sync/test_multiple_visits_around_sync.js
2008-10-17 06:12:52 -04:00
Shawn Wilsher
7318a31e87 Bug 459315 - Wrap favicon work in a transaction
This wraps a series of statements that run on the main thread to reduce the
number of fsyncs that end up happening.
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
1d8ed87e7e Bug 459299 - nsNavHistory::SetPageTitleInternal is slow
This caches a statement that is created any time a pages title changes.  The
creation of the statement took roughly 66% of the functions execution time
according to shark.
It also removes a transaction that was not needed in this method.
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
17cb4ef937 Bug 456029 - optimize the temp table triggers
This changeset makes the triggers work much faster which should greatly reduce
the timings of adding a visit and a bookmark.
r=sdwilsh
2008-10-17 06:12:52 -04:00
Shawn Wilsher
324faf73c0 Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77

--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-10-17 06:12:51 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
ab683c2014 Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-17 06:12:51 -04:00
Shawn Wilsher
4e36cb2d33 Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-10-17 06:12:50 -04:00
Shawn Wilsher
5b77a76c5c Bug 460315 - set journal_mode to TRUNCATE
Sets the journal_mode to the places database to TRUNCATE
r=dietrich
2008-10-16 15:59:33 -04:00
Marco Bonardo
619bf4f3db Bug 458683 - Backup only uri nodes into tag containers, r=dietrich 2008-10-14 17:24:08 +02:00
Neil Rashbrook
55b6b71d92 Bug 459571 Places autocomplete results contain incorrect search string r=sdwilsh,mardak 2008-10-14 14:54:17 +01:00
Marco Bonardo
e1b2894e8b Bug 457698 - nsNavHistoryFolderResultNode::OnItemAdded ignores dynamic containers, r=dietrich 2008-10-13 18:14:50 +02:00
Marco Bonardo
a391ff7b7f Bug 457686 - appendURINode should not append to a dynamic container if we are inside an excludeItems query, r=dietrich 2008-10-13 18:06:50 +02:00
Marco Bonardo
c6d47a93d5 Bug 457681 - if ExcludeReadOnlyFolders is false, readonly dynamic containers are still excluded, r=dietrich 2008-10-13 17:58:36 +02:00
Marco Bonardo
8f29aaecf4 Bug 457677 - PlacesUtils ignores dynamic containers, r=dietrich 2008-10-13 17:54:25 +02:00
Marco Bonardo
81dc5853ba Bug 458013 - QueryResultNode Tag refresh optimization is useless as it is, r=dietrich 2008-10-13 14:11:27 +02:00
Ben Turner
a2d746ccc9 Bug 455436 - "XPConnect insists on using its own error reporter even when another is already set." r+sr=jst. 2008-10-12 11:32:34 -07:00
Arpad Borsos
c72ef7d248 Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan 2008-10-10 17:04:34 +02:00
Daniel Holbert
5492039225 Bug 458167 - (comments-only changes) Grammar Nazi Vol1: s/it's/its/ for the posessive version of the word, and a few other misc comment-typos, in these directories: accessible browser config profile rdf toolkit tools xpcom xpfe 2008-10-01 23:49:45 -07:00
Marco Bonardo
6a006b9d98 Bug 448584 - Don't save invalid uri nodes while doing a JSON backup (don't stop while saving data), r=dietrich 2008-09-30 10:41:36 +02:00
Dietrich Ayala
934c43402b Bug 420331 - wyciwyg: uris show up in location bar (r=mardak) 2008-09-29 23:46:52 -07:00
Dietrich Ayala
370acd949a test for bug 331459 - Places query ignores onlyBookmarked 2008-09-29 23:28:08 -07:00
Dietrich Ayala
c558a34e69 pushing test for bug 433317, forgot to check-in initially 2008-09-29 23:22:46 -07:00
Marco Bonardo
e31c9fa941 Follow-up to Bug 329534 - Live bookmarks load way too aggressively. Try to workaround possible VM timers bugs that could cause test failures. r=dietrich 2008-09-30 01:24:44 +02:00
Takeshi Ichimaru
72b3a54878 Bug 329534 - Live bookmarks load way too aggressively (lock up/hang/freeze browser), r=dietrich, mak77 2008-09-27 13:05:28 +02:00
Shawn Wilsher
f60345fb2a Backed out changeset ebafcda56f98 (bug 456910)
Backed out for Tp regression (bug 457288)
2008-09-26 15:55:03 -04:00
Shawn Wilsher
806eded4d9 Bug 456910 - Stop using exclusive locking in places
This allows us to greatly reduce the number of fsyncs when upgrading to sqlite.
The perf loss in no longer using this locking is not significant (10^-6 %).
r=dietrich
2008-09-25 13:50:41 -04:00
Marco Bonardo
3036bf3069 Bug 407468 - Livemark loading and failed to load messages should be static menuitems from menu.xml, original patch by Michael Schonfeld <dev@schonfeld.org>, r=mano 2008-09-25 12:30:33 +02:00
Marco Bonardo
5ca634dfa3 Bug 418671 - Clean up places views drag and drop code, r=mano 2008-09-19 17:47:45 +02:00
Shawn Wilsher
cc2a825eaf backout merge 2008-09-18 15:05:36 -04:00
Shawn Wilsher
450b35fe86 backout merge 2008-09-18 15:03:15 -04:00
Shawn Wilsher
64718a9784 Backed out changeset eb14737f8488 (places fsync work) 2008-09-18 15:02:55 -04:00
Shawn Wilsher
d3a9172439 backout merge 2008-09-18 15:02:17 -04:00
Shawn Wilsher
650756b4f5 Backed out changeset c99b7659dc0a (places fsync work) 2008-09-18 15:01:51 -04:00
Shawn Wilsher
8300c0e3a7 backout merge 2008-09-18 15:01:01 -04:00
Shawn Wilsher
7a7b8024e3 Backed out changeset f3c9af143cc1 (places fsync work) 2008-09-18 15:00:30 -04:00
Shawn Wilsher
08a9d0f966 Backed out changeset dabae13daacb 2008-09-18 14:47:31 -04:00
Shawn Wilsher
9113a3c5ad Test breakage fix from bug 449640 2008-09-18 13:51:33 -04:00
Shawn Wilsher
0b053bff4f Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77

--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-09-18 11:10:47 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
50c693b57c Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-09-18 11:10:34 -04:00
Shawn Wilsher
8e5d57582f Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-09-18 11:10:09 -04:00
Marco Bonardo
53243f3fe0 Bug 430442 - Undo and redo in the library are sometimes not correctly working, r=dietrich 2008-09-11 16:16:54 +02:00
Phil Ringnalda
a0c3300d49 Bug 454360 - Use Components.results.NS_BINDING_ABORTED instead of hardcoding the value, r=gavin 2008-09-09 21:33:27 -07:00
Ted Mielczarek
ff7706a544 bug 447642 - get rid of --disable-mochitest, replace MOZ_MOCHITEST with ENABLE_TESTS. r=bsmedberg 2008-09-09 13:59:11 -04:00
Serge Gautherie
741c241c5f Bug 450938 - "test_417228-other-roots.js:89: strict warning: assignment to undeclared variable excludedFolderId"; Av1; r=mano 2008-09-07 16:46:41 +02:00
Marco Bonardo
c1681d4bce Bug 451499 - wrong folder icon appears on smart bookmarks, r=dietrich 2008-09-06 17:21:55 +02:00
Shawn Wilsher
23fb28ac56 Bug 453181 - Remove code that is labeled REMOVE ME
This changeset removes a bunch of code that was labeled REMOVE ME with a release
stated.  All those releases have passed, so let's get rid of the code.
r=dietrich
2008-09-05 12:20:40 -04:00
Oleg Romashin
7e07caf07b Bug 453821 - Places building in embedding-minimal profile failed. r=edilee. 2008-09-05 17:49:49 +03:00
Shawn Wilsher
14b19841ca Bug 451590 - nsNavHistory needs nsIClassInfo with THREADSAFE flag
This changeset marks nsNavHistory as threadsafe so we can use the database
connection on more than one thread in JS.  It also adds assertions on every
other public API to ensure that it is only running on the main thread.
r=dietrich
r=bent
2008-09-04 18:11:14 -04:00
Simon Wagner
d4f2b2ffe9 Bug 452958 - Livemarks service does not show children with empty titles, r=dietrich 2008-09-04 19:00:18 +02:00
Shawn Wilsher
df607921d6 Bug 452777 - regression from lastInsertRowID: Undo folder deletion mix up views
r=Mak77
2008-09-03 12:45:20 -04:00
Marco Bonardo
c7cbc9f577 Bug 442731 - GIF favicons are not resampled in places.sqlite (large icons are stored), r=dietrich, pavlov 2008-09-02 13:59:59 +02:00
Shawn Wilsher
65dbea367a Bug 429988 - Use a background thread for places work when possible
This changeset creates a JS module that acts as a wrapper for a background
thread to do places work on.
Tests included!
r=bent
r=dietrich
2008-08-27 22:33:01 -04:00
Edward Lee
c70ae20d95 Bug 451760 - Allow matching at beginning of title/url by pref. r=dietrich 2008-08-24 10:45:33 -05:00
Shawn Wilsher
ef657651d7 Bug 451244 - nsNavHistory does not use threadsafe refcounting
This changeset makes nsNavHistory use the threadsafe addref and release macros
so database access can be done off of the main thread via nsPIPlacesDatabase.
r=dietrich
2008-08-19 23:31:53 -05:00
Marco Bonardo
f5dcca37c7 Bug 411966 - Wrong favicon appears in the bookmarks list, r=dietrich 2008-08-19 11:26:16 -04:00
Marco Bonardo
7e9f44d6b6 Bug 427142 sporadic test_393498.js failure on bm-win2k3-pgo01 because of VM timer issues. r=dietrich 2008-08-18 12:55:24 -04:00
Dietrich Ayala
8e8f112b0a Bug 450674 - Fix test_expiration.js
r=sdwilsh
2008-08-16 18:34:36 -04:00
Shawn Wilsher
2e4f783618 Bug 449884 - Stop using mozIStorageConnection::GetLastInsertRowID
It turns out that this is not a safe function to use at all when you start using
the database connection on more than one thread.  It also does not work as
expected when triggers are used to insert data into a database.
r=dietrich
2008-08-16 18:28:28 -04:00
Shawn Wilsher
b4e36bcb89 Bug 444763 - Use an unshared cache connection instead of a shared one
This makes places no longer use a shared cache for the database.  This wins us
about 7% for location bar queries.  For those needing access to the places
database now, they should QI nsINavHistoryService to nsPIPlacesDatase and get
the database connection off of it.
r=dietrich
2008-08-16 18:23:24 -04:00
Shawn Wilsher
060ff3099d Bug 449506 - Expose the places db connection
This adds a private interface that consumers can QI to to get access to the
internal database connection.
r=dietrich
2008-08-16 18:21:23 -04:00
Dão Gottwald
0c121f919f Backed out changeset be5521120b06 2008-08-13 09:52:48 +02:00
Marco Bonardo
d9373d105c Bug 411966 – Wrong favicon appears in the bookmarks list. r=dietrich 2008-08-13 08:44:38 +02:00
L. David Baron
d085d73186 Merge backout of changeset fb56f835e52d due to test failure and leaks. 2008-08-06 11:54:04 -07:00
L. David Baron
ec79daa1f1 Backed out changeset fb56f835e52d due to test failure and leaks. 2008-08-06 11:53:44 -07:00
Dietrich Ayala
8ba146f69f bustage fix for bug 329534 2008-08-06 10:20:30 -07:00
Dietrich Ayala
d563eb2d10 [mq]: bug-329534-livemarks-load 2008-08-06 09:51:14 -07:00
Edward Lee
a5fcbc5aa7 Bug 422698 - different levels of URL decoding for address bar and autocomplete suggestions 2008-08-05 18:16:35 -07:00
Edward Lee
95ae0af44d Bug 424717 - Location bar autocomplete should be willing to complete to a URL with a different protocol 2008-08-05 18:16:12 -07:00
Edward Lee
e7a7358974 Bug 424509 - Location bar autocomplete favors "http://" over domain name starting with "h". r=dietrich 2008-08-05 17:56:04 -07:00
Shawn Wilsher
3f3b07898a Bug 443433 - [refactor] move places table creation statements to one file
This refactors how tables are created in places.  There is no change in logic.
r=dietrich
2008-08-04 13:14:17 -04:00
Shawn Wilsher
6fc4c9b907 Address spelling mistake from review comment for bug 443068. 2008-08-04 13:07:17 -04:00
Shawn Wilsher
6701a8e6a0 Bug 443068 - Move triggers into migration code
This moves all the triggers created by places into the appropriate migration
functions.  This saves us two queries to sqlite_master every time the places
service starts up.
r=dietrich
2008-08-04 12:59:56 -04:00
Edward Lee
90bebef2e9 Backout 6831521f03ac to fix Bug 446621 - Slowdown on AutoComplete - AwesomeBar. a=beltzner 2008-07-22 08:49:39 -07:00
Edward Lee
afe774f818 Bug 412736 - in the case of a frecency tie, break it with h.typed and h.visit_count. r=dietrich 2008-07-21 23:29:51 -07:00
Edward Lee
eda9f0d79c Bug 424557 - Allow AwesomeBar to default search only urls (or history/titles/bookmarks/tags). r=dietrich 2008-07-21 14:27:50 -07:00
Marco Bonardo
24b6d38299 bug 427142 - sporadic test_393498.js failure on bm-win2k3-pgo01 because of VM timer issues. r=dietrich 2008-07-21 11:41:09 -04:00
Edward Lee
71548b9fde Bug 395161 - Make it possible to restrict the url bar autocomplete results to bookmarks/tagged/history entries and match only url/title. r=dietrich 2008-07-19 01:51:34 -07:00
Edward Lee
d1d8aa6bda Bug 249468 - Add all bookmark keywords to location bar autocomplete drop-down list 2008-07-17 04:50:37 -07:00
Edward Lee
1bef7eb888 Bug 392143 - show keywords as url bar autocomplete choices. r=dietrich, r=gavin 2008-07-17 04:48:40 -07:00
Edward Lee
5cb6496071 Bug 406422 - Globally decay adaptive input history to allow for new entries. r=dietrich 2008-07-16 13:45:42 -07:00
Serge Gautherie
31d8086891 Bug 311672 – Remove the obsolete 2nd parameter from |nsIStringBundleService::createBundle(...)| "JS" callers. r=zeniko/mano 2008-07-12 11:56:02 +02:00
Olli Pettay
9ae74171ca Relanding Bug 444432 - Mozilla2 Tinderbox 'qm-win2k3-moz2-01': test_places/unit/test_419731.js: FAIL 2008-07-11 16:00:41 +03:00
Asaf Romano
4c9b67afe0 Bug 443734 - Remove initBookmarksToolbar. r=gavin. 2008-07-05 22:00:06 +03:00
Dietrich Ayala
b6f0608f6d Bug 429832 - Add API to nsIFaviconService to handle data URIs (for manish@flock.com, r=marco, r=dietrich) 2008-07-03 11:07:56 -07:00
Dietrich Ayala
7a0d6067ed Bug 433317 - Renamed title of saved search folder isn't updated outside the Library until Firefox is restarted (r=marco, r=mano) 2008-07-03 10:40:16 -07:00
Dietrich Ayala
95e2024781 Bug 437078 - GUIDs not included in bookmark backups (r=mano) 2008-07-03 10:17:13 -07:00
Dietrich Ayala
2167147598 Bug 436219: nsINavBookmarksService.runInBatchMode comment is incorrect (r=mano) 2008-07-02 14:35:46 -07:00
Shawn Wilsher
124b7ecaa6 Bug 429987
Remove unused IN_MEMORY_LINKS
r=dietrich
2008-06-11 16:52:24 -04:00
peterv@propagandism.org
45727ae1a7 Fix for bug 426261 (Crash in nsNavHistoryContainerResultNode::GetSortType() during bookmark synchronization). Patch by ondrej and me, r=Mano, a=beltzner. 2008-05-27 08:48:31 -07:00
edward.lee@engineering.uiuc.edu
30f57ae706 Leak bustage fix for Bug 434340 - The bookmark tags feature is broken on Firefox 3.0rc1 for OpenSolaris 2008-05-26 19:28:47 -07:00
edward.lee@engineering.uiuc.edu
8b264731f0 Bug 434340 - Firefox 3.0pre crashes with auto completion for tagged bookmark. p=ginn.chen@sun.com (Ginn Chen), r=Mardak, r=dietrich, b-ff3=beltzner, a1.9=beltzner 2008-05-26 14:20:34 -07:00
dietrich@mozilla.com
767748fd1f Bug 433525 - crash [@ nsNavHistoryQueryResultNode::IsContainersQuery()] (r=marco, r=mano, a=schrep) 2008-05-23 09:22:54 -07:00
gavin@gavinsharp.com
d62cf5b07b Back out bug 432938 because it caused bug 433241, a=schrep/beltzner 2008-05-11 13:12:29 -07:00
reed@reedloden.com
6dadad9e91 Bug 398811 - "Remove MOZILLA_1_8_BRANCH ifdefs from toolkit on trunk" [p=mh+mozilla@glandium.org (Mike Hommey) r=gavin a1.9=damons] 2008-05-09 00:25:29 -07:00
dietrich@mozilla.com
469c7bd521 Bug 430792 - Site's favicon is replaced if browser error page is shown (comment change only, for ehsan.akhgari@gmail.com, r=dietrich) 2008-05-08 09:36:54 -07:00
dietrich@mozilla.com
ca27ef83a7 Bug 430792 - Site's favicon is replaced if browser error page is shown (for ehsan.akhgari@gmail.com, r=dietrich, a=beltzner) 2008-05-07 21:35:08 -07:00
dietrich@mozilla.com
76573af049 Bug 428481 - nsFaviconService calls Abandon on a scoped global statement (for mak77@supereva.it, r=dietrich, a=schrep) 2008-05-07 21:26:10 -07:00
dietrich@mozilla.com
ece7dc0e83 Bug 419957 - History sidebar "By Site" should use visit_count to avoid display of empty sites (for ondrej@allpeers.com, r=dietrich, a=beltzner) 2008-05-06 21:33:05 -07:00
dietrich@mozilla.com
c2f963e3ae backing out, tree is closed 2008-05-06 20:28:03 -07:00
dietrich@mozilla.com
4026e710af Bug 419957 - History sidebar "By Site" should use visit_count to avoid display of empty sites (for ondrej@allpeers.com, r=dietrich, a=beltzner) 2008-05-06 20:26:19 -07:00
dietrich@mozilla.com
dd184ae583 Bug 417228 - Bookmarks outside the three default folders aren't restored (r=mano, a=schrep) 2008-05-06 13:58:45 -07:00
dietrich@mozilla.com
b151718f4d Bug 429811 - Tag container isn't updated immediately when bookmark is removed (r=mano, a=mconnor) 2008-05-05 12:57:22 -07:00
dietrich@mozilla.com
07c9fb68d6 perf testing bug 431758 (a=mconnor) 2008-05-05 11:11:49 -07:00
philringnalda@gmail.com
02eab41c31 Ignore siteURI annotation changes that are for the default livemark, not our livemark 2008-05-03 13:33:24 -07:00
philringnalda@gmail.com
2e35c75e9d Better logging for livemark siteURI test failures 2008-05-03 12:38:23 -07:00
gavin@gavinsharp.com
d398feba9e Bug 421180: When removing bookmarks existing keywords aren't deleted/removed, patch by Marco Bonardo <mak77@supereva.it>, r=dietrich, a=damon 2008-04-29 12:20:50 -07:00
gavin@gavinsharp.com
ba06f48c66 Bug 402799: Saved searches that match on tags show duplicates, patch by Marco Bonardo <mak77@supereva.it>, r=dietrich, a=beltzner 2008-04-29 12:16:42 -07:00
gavin@gavinsharp.com
98a7d6e165 Bug 425230: add a transaction to ClearHistory, patch by Marco Bonardo <mak77@supereva.it>, r=dietrich, a=mconnor 2008-04-28 03:11:08 -07:00
dietrich@mozilla.com
f2c0b5a596 Bug 423212 - ###!!! ASSERTION: EndUpdateBatch without a begin: 'mBatchInProgress' (r=mano, a=mconnor) 2008-04-25 16:40:48 -07:00
dietrich@mozilla.com
ebe98c34f2 Bug 405938 - problems when import/exporting of saved searches (r=mano, a=mconnor) 2008-04-25 16:37:26 -07:00
dietrich@mozilla.com
ff1f851a4f Bug 423515 - If Unfiled Bookmarks is moved to Bookmarks Menu, unfiled bookmarks are invisible until browser is restarted (r=mano, a=mconnor) 2008-04-25 14:36:40 -07:00
dietrich@mozilla.com
dcc488e824 Bug 430600 - crash in CanAddURI (r=mano, a=beltzner) 2008-04-24 12:42:01 -07:00
edward.lee@engineering.uiuc.edu
5f26263c8c Bug 429531 - Location bar should show non-word-boundary matches below word-boundary matches. r=dietrich, ui-r=beltzner, b-ff3=beltzner, a1.9=beltzner 2008-04-23 21:20:05 -07:00
edward.lee@engineering.uiuc.edu
659efec9be Bug 251337 - Download manager history should have "aging" option, just like the browser history. r=sdwilsh, r=mano, r=bsmedberg, a1.9=damons 2008-04-22 16:37:00 -07:00
dholbert@cs.stanford.edu
6578c25995 Backing out mardak's Bug 251337 checkin to fix Thunderbird & Sunbird tinderbox bustage. 2008-04-21 16:00:59 -07:00
edward.lee@engineering.uiuc.edu
3fd277d1d9 Bug 251337 - Download manager history should have "aging" option, just like the browser history. r=sdwilsh, r=mano, a1.9=damons 2008-04-21 14:48:55 -07:00
edward.lee@engineering.uiuc.edu
8b6d40dcc9 Bug 429498 - Location bar does not search consistently (matches 1-after a CamelCase). r=dietrich, b-ff3=beltzner, a1.9=mconnor 2008-04-20 19:47:41 -07:00
dietrich@mozilla.com
4fb52f67f0 Bug 429505 - OnItemRemoved() fails to live-update for children that are folder-shortcuts (r=mano, a=damon) 2008-04-19 10:58:54 -07:00
edward.lee@engineering.uiuc.edu
36404ec7b9 Unconfuse comment and add prefs for bug 422869 2008-04-17 17:44:12 -07:00
dietrich@mozilla.com
f86548c76e Bug 427746 - Bookmarks toolbar is empty when using 'copy' context menu option (for mak77@supereva.it, r=mano, a=beltzner) 2008-04-16 12:33:39 -07:00
dietrich@mozilla.com
73f5a662e4 Bug 426056 - Unresponsive script modules/utils.js after dropping a folder into the Tags folder (for mak77@supereva.it, r=mano, a=beltzner) 2008-04-15 10:17:34 -07:00
dietrich@mozilla.com
3db519063e Bug 424769 - Smart bookmarks Recent Tags menu contains self reference (PPC Mac) (for mak77@supereva.it, r=dietrich, a=beltzner) 2008-04-15 10:07:13 -07:00
gavin@gavinsharp.com
5563507482 Bug 428422: setItemTitle does not need to do 2 queries, patch by Marco Bonardo <mak77@supereva.it>, r=dietrich, a=beltzner 2008-04-13 18:10:20 -07:00