Commit Graph

4980 Commits

Author SHA1 Message Date
Brian Hackett
091f2992d2 Bug 1573938 - Never collect wrapper JSObjects when recording/replaying, r=mccr8.
Differential Revision: https://phabricator.services.mozilla.com/D42011

--HG--
extra : moz-landing-system : lando
2019-08-16 20:51:12 +00:00
Kagami Sascha Rosylight
b14e2b2516 Bug 1414372: Introduce interface mixins r=bzbarsky
Add IDLInterfaceMixin with a new superclass shared with existing IDLInterfaceOrNamespace.

Differential Revision: https://phabricator.services.mozilla.com/D38802

--HG--
extra : moz-landing-system : lando
2019-08-15 16:53:49 +00:00
Jon Coppeard
c772fc6cda Bug 1573844 - Remove external references to js::Class r=mccr8
Depends on D41985

Differential Revision: https://phabricator.services.mozilla.com/D41986

--HG--
extra : moz-landing-system : lando
2019-08-14 17:15:15 +00:00
Jon Coppeard
6d38179350 Bug 1573844 - Remove external references to js::Jsvalify and js::Valueify r=mccr8
These are now no-ops so can be removed.

Depends on D41983

Differential Revision: https://phabricator.services.mozilla.com/D41984

--HG--
extra : moz-landing-system : lando
2019-08-14 17:24:59 +00:00
Jon Coppeard
66fc30ba53 Bug 1573844 - Remove js::Class definition and alias JSClass to it r=tcampbell,mccr8
JSClass contained void* members corresponding to the internal pointer members of js::Class. This stores the internal members in JSClass and removes js::Class.

This leaves js::Class aliased to JSClass while we remove references to it. I also aliased Jsvalify and Valueify into global scope temporarily to make this compile. These get removed in the following patches.

I had to remove a few functions which now don't compile with js::Class being the same type as JSClass.

Differential Revision: https://phabricator.services.mozilla.com/D41983

--HG--
extra : moz-landing-system : lando
2019-08-15 08:32:22 +00:00
Jon Coppeard
81a8266309 Bug 1573419 - Fix assertion failure finalizing JSObjects during shutdown r=bzbarsky
The problem is that if there is a leak at shutdown we can end up calling ClearWrapper on a wrapper that has already been cleared by the JS engine. The patch just relaxes the assertion to allow this. I tested this on try with a bunch of retriggers and it seems to fix the problem.

Differential Revision: https://phabricator.services.mozilla.com/D41938

--HG--
extra : moz-landing-system : lando
2019-08-15 08:29:26 +00:00
Jon Coppeard
d23ec38129 Bug 1573508 - Replace external references to js::ClassOps with JSClassOps r=mccr8
Depends on D41759

Differential Revision: https://phabricator.services.mozilla.com/D41760

--HG--
extra : moz-landing-system : lando
2019-08-14 09:45:31 +00:00
Nathan Froyd
b0b2a5088c Bug 1573537 - add parentheses for property info count static_assert; r=bzbarsky
Otherwise we're computing (1ull << CHAR_BIT) * sizeof(...), which is not
quite what we wanted.

Differential Revision: https://phabricator.services.mozilla.com/D41773

--HG--
extra : moz-landing-system : lando
2019-08-13 17:47:04 +00:00
Jon Coppeard
4f45eff7cc Bug 1572782 - Remove external references to js::FreeOp r=mccr8?
Replace external use of js::FreeOp with JSFreeOp.

Differential Revision: https://phabricator.services.mozilla.com/D41411

--HG--
extra : moz-landing-system : lando
2019-08-12 10:43:32 +00:00
Jon Coppeard
a00726d223 Bug 1572782 - Remove js::FreeOp and make JSFreeOp opaque in public API r=tcampbell?
Merge js::FreeOp and JSFreeOp, but alias the former to the latter while we fix uses.

Differential Revision: https://phabricator.services.mozilla.com/D41410

--HG--
extra : moz-landing-system : lando
2019-08-12 10:43:32 +00:00
Oana Pop Rus
44aafcc0d0 Backed out 4 changesets (bug 1572782) for build bustages at build/src/obj-firefox/dist/include/nsIXPCScriptable.h on a CLOSED TREE
Backed out changeset ec9d15c69bc8 (bug 1572782)
Backed out changeset 8239e4baa0f4 (bug 1572782)
Backed out changeset 9fd7bea2b512 (bug 1572782)
Backed out changeset 11d750555fe1 (bug 1572782)
2019-08-12 13:37:03 +03:00
Jon Coppeard
68fef4ffb0 Bug 1572782 - Remove external references to js::FreeOp r=mccr8?
Replace external use of js::FreeOp with JSFreeOp.

Differential Revision: https://phabricator.services.mozilla.com/D41411

--HG--
extra : moz-landing-system : lando
2019-08-12 10:16:00 +00:00
Jon Coppeard
9d51a35e93 Bug 1572782 - Remove js::FreeOp and make JSFreeOp opaque in public API r=tcampbell?
Merge js::FreeOp and JSFreeOp, but alias the former to the latter while we fix uses.

Differential Revision: https://phabricator.services.mozilla.com/D41410

--HG--
extra : moz-landing-system : lando
2019-08-12 10:15:57 +00:00
Brendan Dahl
b474db77c6 Bug 1551344 - Part 1: Remove XULDocument code. r=smaug,Jamie
All .xul files have been loading as HTMLDocuments for a few weeks now, so
it should be safe to remove the XULDocument implementation.

Differential Revision: https://phabricator.services.mozilla.com/D41238

--HG--
extra : moz-landing-system : lando
2019-08-09 19:57:50 +00:00
Kagami Sascha Rosylight
54112deff0 Bug 1572405 - Fix Py3 referenced before assignment error r=bzbarsky
`except Exception as exception` in Python 3 removes the `exception` variable in the outer scope whereas Python 2 does not. This mitigates the error caused by the Py3 behavior.

Differential Revision: https://phabricator.services.mozilla.com/D41194

--HG--
extra : moz-landing-system : lando
2019-08-09 06:27:36 +00:00
Edwin Gao
1eb2f0f7be Bug 1559975 - convert dom/bindings to python3 r=ahal,bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D36634

--HG--
extra : moz-landing-system : lando
2019-08-02 19:45:12 +00:00
Boris Zbarsky
4694cad683 Bug 1570350. Refactor ConstructJSImplementation to make consumers a bit simpler. r=mccr8
We could get rid of the need to specify the impl class at the callsite by
taking a T** instead of returning an already_AddRefed<T>, but I'm not sure
which is uglier...

The change from `globalHolder->GetGlobalJSObject()` to `global.Get()` is OK,
because `globalHolder` was coming from the nsISupports attached to
`global.Get()` anyway, so those are the same global JS object.

Differential Revision: https://phabricator.services.mozilla.com/D40060

--HG--
extra : moz-landing-system : lando
2019-07-31 21:38:00 +00:00
Boris Zbarsky
3581c41939 Bug 1568729. Only include the static pref headers we really need in binding code. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D39528

--HG--
extra : moz-landing-system : lando
2019-07-28 11:08:00 +00:00
Yoshi Cheng-Hao Huang
e17d60cbf4 Bug 1551810 - Part 1: return bool in CallbackTracer methods. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D38980

--HG--
extra : moz-landing-system : lando
2019-07-26 08:59:38 +00:00
Nicholas Nethercote
18fae65f38 Bug 1563139 - Remove StaticPrefs.h. r=glandium
This requires replacing inclusions of it with inclusions of more specific prefs
files.

The exception is that StaticPrefsAll.h, which is equivalent to StaticPrefs.h,
and is used in `Codegen.py` because doing something smarter is tricky and
suitable for a follow-up. As a result, any change to StaticPrefList.yaml will
still trigger recompilation of all the generated DOM bindings files, but that's
still a big improvement over trigger recompilation of every file that uses
static prefs.

Most of the changes in this commit are very boring. The only changes that are
not boring are modules/libpref/*, Codegen.py, and ServoBindings.toml.

Differential Revision: https://phabricator.services.mozilla.com/D39138

--HG--
extra : moz-landing-system : lando
2019-07-26 01:10:23 +00:00
Kris Maglione
4bd4d680d4 Bug 1566952: Part 1 - Annotate mochitests that crash with Fission enabled. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D38725

--HG--
extra : rebase_source : 3e8b32b86b12b22d038baa770070a5c8095043c9
2019-07-17 13:37:48 -07:00
Kagami Sascha Rosylight
cbdbeb0691 Bug 1565130 - Update parser/runtests.py for Python 3 r=firefox-build-system-reviewers,mshal
Differential Revision: https://phabricator.services.mozilla.com/D38813

--HG--
extra : moz-landing-system : lando
2019-07-23 22:14:23 +00:00
Gurzau Raul
9866332964 Backed out 3 changesets (bug 1559975) for linting failure at WebIDL.py on a CLOSED TREE.
Backed out changeset a7154744a5d7 (bug 1559975)
Backed out changeset 4005ac274170 (bug 1559975)
Backed out changeset 68ed1ccb5921 (bug 1559975)
2019-07-19 18:25:10 +03:00
Edwin Gao
805e1d99d2 Bug 1559975 - convert dom/bindings to python3 r=ahal,bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D36634

--HG--
extra : moz-landing-system : lando
2019-07-19 14:15:00 +00:00
Andrew McCreight
ac69d4bf7b Bug 1510760, part 4 - Add transplant support to GetRemoteOuterWindowProxy(). r=peterv
When we call GetRemoteOuterWindowProxy in the middle of a transplant,
the remote proxy that the function returns will be almost immediately
swapped with some other object. Rather than trying to fix up the
remote proxy map when that happens, this patch adds a new argument
that is a pointer to the object, if any, that the remote proxy is
going to be swapped to. This will be used in the remote proxy map.

Having a value in the remote proxy map that is not a remote proxy
could cause issues if somebody ends up calling
GetRemoteOuterWindowProxy() a second time before the transplant has
finished. To avoid that, my patch asserts that we are returning an
object with the appropriate class.

Differential Revision: https://phabricator.services.mozilla.com/D37598

--HG--
extra : moz-landing-system : lando
2019-07-18 19:36:17 +00:00
Andrew McCreight
3c4247618f Bug 1510760, part 2 - Add the remote proxy handler to SetDOMProxyInformation. r=peterv,tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D37596

--HG--
extra : moz-landing-system : lando
2019-07-18 19:36:13 +00:00
Andrew McCreight
dd23a020fe Bug 1510760, part 1 - Make GetBrowsingContext and GetOuterWindow callable elsewhere. r=peterv
Also fix an existing formatting issue.

Differential Revision: https://phabricator.services.mozilla.com/D37595

--HG--
extra : moz-landing-system : lando
2019-07-18 19:36:11 +00:00
Noemi Erli
1916d2be66 Backed out 5 changesets (bug 1510760) for bustages in nsGlobalWindowOuter.cpp
Backed out changeset 19a972ea7855 (bug 1510760)
Backed out changeset 524ac8b3040d (bug 1510760)
Backed out changeset 3bc5442338bc (bug 1510760)
Backed out changeset cb12d4068aca (bug 1510760)
Backed out changeset 75b769608cce (bug 1510760)
2019-07-18 19:18:47 +03:00
Andrew McCreight
c7d6336a9d Bug 1510760, part 4 - Add transplant support to GetRemoteOuterWindowProxy(). r=peterv
When we call GetRemoteOuterWindowProxy in the middle of a transplant,
the remote proxy that the function returns will be almost immediately
swapped with some other object. Rather than trying to fix up the
remote proxy map when that happens, this patch adds a new argument
that is a pointer to the object, if any, that the remote proxy is
going to be swapped to. This will be used in the remote proxy map.

Having a value in the remote proxy map that is not a remote proxy
could cause issues if somebody ends up calling
GetRemoteOuterWindowProxy() a second time before the transplant has
finished. To avoid that, my patch asserts that we are returning an
object with the appropriate class.

Differential Revision: https://phabricator.services.mozilla.com/D37598

--HG--
extra : moz-landing-system : lando
2019-07-18 15:02:57 +00:00
Andrew McCreight
d957b14cdb Bug 1510760, part 2 - Add the remote proxy handler to SetDOMProxyInformation. r=peterv,tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D37596

--HG--
extra : moz-landing-system : lando
2019-07-18 15:02:47 +00:00
Andrew McCreight
6307831c6e Bug 1510760, part 1 - Make GetBrowsingContext and GetOuterWindow callable elsewhere. r=peterv
Also fix an existing formatting issue.

Differential Revision: https://phabricator.services.mozilla.com/D37595

--HG--
extra : moz-landing-system : lando
2019-07-18 15:02:45 +00:00
Kris Maglione
0962c2b731 Bug 1566182: Annotate mochitests that fail with Fission enabled. r=mccr8
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.

There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.

Differential Revision: https://phabricator.services.mozilla.com/D38247

--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
2019-07-15 16:19:32 -07:00
Nicholas Nethercote
624de194fe Bug 1565110 - Rename abc.def and ghi.jkl prefs as dom.webidl.test[12]. r=bzbarsky
Depends on D37669

Differential Revision: https://phabricator.services.mozilla.com/D37670

--HG--
extra : moz-landing-system : lando
2019-07-12 04:39:12 +00:00
Markus Stange
6efbe54e95 Bug 1515214 - Add CallbackObject::GetDescription and TimeoutHandler::GetDescription. r=bzbarsky
This allows us to create profiler markers whose description contains the name
of the function and its file / line number. This allows the profiler UI to
match up setTimeout callbacks for multiple instances of the same page load, in
order to create meaningful profile comparisons based on markers.

Differential Revision: https://phabricator.services.mozilla.com/D19192

--HG--
extra : moz-landing-system : lando
2019-07-10 20:48:14 +00:00
Barret Rennie
4636522c18 Bug 1289211 - Rename InfallibleTArray to nsTArray in dom/bindings/ r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D36942

--HG--
extra : moz-landing-system : lando
2019-07-10 03:25:38 +00:00
Kagami Sascha Rosylight
936e15f95d Bug 1563937: Support Python 3 in WebIDL.py r=firefox-build-system-reviewers,bzbarsky,mshal
Should allow Servo to start Python 3 migration.

Differential Revision: https://phabricator.services.mozilla.com/D37160

--HG--
extra : moz-landing-system : lando
2019-07-10 02:36:57 +00:00
Boris Zbarsky
3910c9fe0a Bug 1561887 part 2. Fix cycle-collection skipping of JSEventHandler to work correctly. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D36870

--HG--
extra : moz-landing-system : lando
2019-07-09 17:04:59 +00:00
Kagami Sascha Rosylight
30a1af2b27 Bug 1020975: Allow LenientFloat to be only in a specific overload r=bzbarsky
This assumes that LenientFloat won't break float-less overload behavior.

Differential Revision: https://phabricator.services.mozilla.com/D36747

--HG--
extra : moz-landing-system : lando
2019-07-09 12:58:42 +00:00
Sylvestre Ledru
131d0c6a02 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35622

--HG--
extra : moz-landing-system : lando
2019-07-06 08:18:28 +00:00
Victor Porof
0a8ff0ad85 Bug 1561435 - Format dom/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35951

--HG--
extra : source : 62f3501af4bc1c0bd1ee1977a28aee04706a6663
2019-07-05 10:44:55 +02:00
Oana Pop Rus
2ad74ef9f7 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-07-04 06:38:21 +03:00
Boris Zbarsky
19251f27ce Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting. r=peterv
`= {}` can now be used to indicate that an optional dictionary should have the
default value of 'default-initialized dictionary'

Differential Revision: https://phabricator.services.mozilla.com/D36504

--HG--
extra : moz-landing-system : lando
2019-07-03 07:52:35 +00:00
Kris Maglione
b459f53a11 Bug 1561061: Move SpecialPowers pref env code to parent and make sane-ish. r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D35706

--HG--
extra : rebase_source : ec33af8c17048c3828d4ca4643e2e17bd2a854c0
extra : source : c2d0956f41d82e76c682f829807e818863cd802a
2019-06-24 13:47:53 -07:00
Kagami Sascha Rosylight
509d2d30b6 Bug 1366738: Implement [LegacyWindowAlias] r=bzbarsky
Add [LegacyWindowAlias] extended attribute support for WebKitCSSMatrix and webkitURL.

Differential Revision: https://phabricator.services.mozilla.com/D35601

--HG--
extra : moz-landing-system : lando
2019-07-03 08:37:01 +00:00
Cosmin Sabou
3ef8d24958 Backed out changeset 8e16f13a88c8 (bug 1562680) for colliding with Bug 1366738 that was backed out. CLOSED TREE 2019-07-03 10:46:39 +03:00
Mihai Alexandru Michis
9c4d142e96 Backed out changeset 509af1e0771d (bug 1366738) for causing failures in test_WebKitCSSMatrix.html CLOSED TREE 2019-07-03 10:21:30 +03:00
Boris Zbarsky
73f095abc4 Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting. r=peterv
`= {}` can now be used to indicate that an optional dictionary should have the
default value of 'default-initialized dictionary'

Differential Revision: https://phabricator.services.mozilla.com/D36504

--HG--
extra : moz-landing-system : lando
2019-07-03 06:44:36 +00:00
Mihai Alexandru Michis
c7fc76c18f Backed out changeset 12653dd76667 (bug 1562680) for causing bustages in FuzzingFunctions.webidl CLOSED TREE 2019-07-03 09:34:48 +03:00
Boris Zbarsky
3a5c721abb Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting. r=peterv
`= {}` can now be used to indicate that an optional dictionary should have the
default value of 'default-initialized dictionary'

Differential Revision: https://phabricator.services.mozilla.com/D36504

--HG--
extra : moz-landing-system : lando
2019-07-03 06:15:54 +00:00
Kagami Sascha Rosylight
8dd328fee0 Bug 1366738: Implement [LegacyWindowAlias] r=bzbarsky
Add [LegacyWindowAlias] extended attribute support for WebKitCSSMatrix and webkitURL.

Differential Revision: https://phabricator.services.mozilla.com/D35601

--HG--
extra : moz-landing-system : lando
2019-07-03 02:37:11 +00:00