The "is" operator tests if two objects are the same object, and
does not consider the values of the two objects.
This also gives a better pytest error message should the assertion fails.
MozReview-Commit-ID: GOUek15TUPU
--HG--
extra : rebase_source : f15e92aff9f593d702f0abd8631e2609b8b6e919
Using the "--showlocals" pytest flag we can show the values of
variables in the local scope in the pytest tracebacks. This seems
like a good thing to do to ease debugging.
Thanks-to: Dave Hunt <dave.hunt@gmail.com>
MozReview-Commit-ID: F62untoxEyi
--HG--
extra : rebase_source : db803258395e9bbacf10b06dc8ca367ae79ec67f
Instead of the default pytest error message when the assertion
fails, which is rather pointless because we know we did not match
the 200 HTTP status code, display the string representation of
wdclient.error.WebDriverException.
This string representation includes the remote end's stacktrace,
which is infinitely more useful in this context.
MozReview-Commit-ID: 6XUgEEc9Qoj
--HG--
extra : rebase_source : 68fbcf5e70bfcc064302b139b0c5edff2a0ecb72
This adds a new error.from_response(wdclient.Response) function that lets
a WebDriverException be constructed from a wdclient.Response object.
If the Response is not an error, i.e. has a 200 HTTP status code,
an UnknownErrorException is raised.
MozReview-Commit-ID: JW89Ily2voC
--HG--
extra : rebase_source : 5b126f3d62fc19a1ef0df7374167a7ee6828ab29
We talk about "error codes", not "status codes", for WebDriver errors.
This is a non-functional change.
MozReview-Commit-ID: Bl8zT8lZvzK
--HG--
extra : rebase_source : 7271e6a00170f58e4f1f0086c3d46b67664c7e4a
When showing wdclient.Response's object representation, prettify
the error if there is one. Otherwise include the full body as before.
MozReview-Commit-ID: 64QpsB89Oiw
--HG--
extra : rebase_source : d29a1b644156c6b0557d7d408a9b9398bc11d754
There have been some interface improvements since this was last updated.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 5da0a8d8725edde1aab0e802b1381bb379fd6638
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 7b8c0483bd121f9906c551ecb41dadff5e7da1c9
Some odd touchpad utils give focus to window under mouse cursor when user tries
to scroll the content with swiping or something.
This is really odd behavior because some windows like popup windows doesn't
want focus. However, such ones do actually. For making easier to check such
device's behavior, we should have a pref to emulate such behavior.
MozReview-Commit-ID: 6euwpHn7blf
--HG--
extra : rebase_source : cc23f08f422f25f2851404696e06e069c7936186
Check for filenames which differ only by .asm vs .c filename
extensions when importing a new version of the libaom reference
implementation of the av1 video codec.
These confuse our build system as well. Also remove the obsolete
vp8 and vp9 search directories, which generate warnings from 'find'.
MozReview-Commit-ID: DRZL7GUrsYh
--HG--
extra : rebase_source : 4bc8708dd3b2e386c19bd6b952ca2587a2284a19
Bug 1365460 introduced code paths behind MOZ_DEBUG #ifdefs, but
MOZ_DEBUG is never defined, while it is available in CONFIG in
moz.builds. This is kind of a confusing situation, but the fact that
we've been able to avoid those problems for so long would tend to
put the blame on mozjemalloc, and fixes should go there.
Except that bug 1261161 explains that the only existing alternative
(the DEBUG #define), as used in MFBT, is not working for spidermonkey,
so it actually makes sense to converge to MOZ_DEBUG rather than DEBUG.
So start defining MOZ_DEBUG globally, fixing the mozjemalloc issues of
not having the debug code enabled. Bug 1261161 can then take care of
changing the DEBUG #ifdefs.
--HG--
extra : rebase_source : 37e3d03ac8350c62c8059d4ca01d1ecfdf5f421a
The way inlining is disabled in mozjemalloc is via a #define of "inline"
to nothing, which is a dubious way to do that. This makes the compiler
trigger warnings we -Werror on for some static functions. While there
are such functions in mozjemalloc.cpp that could be fixed by wrapping
them in the right #ifdefs, there are also others coming from headers,
and it's not something that can be fixed in a satisfactory way.
The right way to disable inlining is to pass the right compiler flags
for that. But inlining is the least of the problems to debug optimized
C++ code, so it feels like if debugging requires some optimization
tweaking, it should be done manually with compile flags when needed,
instead of fiddling with #defines to remove keywords.
--HG--
extra : rebase_source : 962c3409f86060c4d5ddf966778b58b64f89c31d
Instead of unconditionally pushing and popping clips per display item,
this patch changes things so that for each recursive display list, we
create an ItemClips struct. We push this onto the stack when we enter
the display list, and pop it off at the end. For each display item, we
check to see if the clips would actually change compared to the previous
display item, and only do the pop/repush in that case.
MozReview-Commit-ID: GadIp2J8TrA
--HG--
extra : rebase_source : ba64c6b4659b8e51cab19b807088b9a50d71b85a
This makes ScrollingLayersHelper a non-RAII type class, and instead adds
methods to notify it of when we start processing a new transaction or a
new display item within the transaction. This patch has no functional
changes, it's non-obvious refactoring.
MozReview-Commit-ID: 3yq9sPiHMge
--HG--
extra : rebase_source : 286423f56de59211e320f015cb1004a1e98332b8
Storing the per-item clip state in a struct like this will allow us to
easily compare the desired clip state across items, so we can avoid
doing unnecessary work when going from one item to the next. This patch
has no functional changes, it's just refactoring.
MozReview-Commit-ID: 49B6hmsWZ4V
--HG--
extra : rebase_source : 8ac4bbf039f81bc2d26e92924ed041fa3d18e5ba
Instead just keep a ref to it as a member variable. No functional
change.
MozReview-Commit-ID: 5fccUlSifsA
--HG--
extra : rebase_source : a14672f926c383354db76e553ae23613fe4a432a
