Add a displayName property on the NodeActor, which compute from Element.prefix + Element.localName.
The computation is made by a getNodeDisplayName function which can be imported wherever needed.
Edit some tests to ensure we correctly display node names.
MozReview-Commit-ID: 6z0G3ynbMoU
--HG--
extra : transplant_source : %E0%AFM%88D%BC%AD%08%1D%A4%FB%F2%5D%9E%D3%90%DE%94%EC%CD
For simple rules like function spacing, we can auto-fix these across the code
base so they are followed in a consistent way.
To generate this patch, I ran:
./mach eslint devtools --no-ignore --fix
After this, I reverted any changes to third party files that we really do want
to ignore.
MozReview-Commit-ID: 6Q8BApkAW20
The breadcrumbs widget used to have a feature where it would show the first
child of the current selection even the DOM tree hadn't been expanded that
far yet.
This was to allow keyboard navigating the DOM through the breadcrumbs.
The breadcrumbs is a very rarely used widget and this code was unnecessarily
making things complex.
It was decided that this feature would be removed.
Instead, the breadcrumbs now act as simple linear elements in a toolbar and
you can keyboard navigate them with LEFT/RIGHT only. TAB/shift-TAB simply go
in/out of the breadcrumbs widget.
MozReview-Commit-ID: BmcaLnVBOBn
--HG--
extra : rebase_source : 1673a6c9da02cf8b3b542e4ce905ccb239250aa7
The code used to make the tooltip appear/disappear when hovering targets
has been extracted to a separate class that can be shared between the
current Tooltip.js implementation and the upcoming HTMLTooltip.
MozReview-Commit-ID: UYSjPFeMYK
--HG--
extra : rebase_source : 5dcca2d5887ffc98fec621092640073a0909c13f
Make sure that result node id is not empty before appending it to the results
MozReview-Commit-ID: 5SuTrNf4t8v
--HG--
extra : transplant_source : E%AF%D7%A9W%DC%C6u%8B%9F%FF%00%A7%FEY%1A%7E%CA%AE%95
Add an ATTRIBUTE search state to better handle attribute's search.
Edit test to make sure we handle it right
MozReview-Commit-ID: ADcIJRbhjO
--HG--
extra : transplant_source : %C7R%AC%EE%2A%BA%C1%FE%B4%E4%D3%B0%D6c%B1%AB%B5%04%C6%CB
shared/test/head had custom methods to open the Computed & Rule view.
They did not register any test actor and could be called several times
in the same test.
In order to reuse the openInspector method from inspector/test/head, the
tests have been modified.
We are moving from
openRuleView() -> do rule view tests -> openComputedView() -> do computed view tests
to
openInspector() -> select rule view -> do rule view tests -> select computed view -> do computed view tests
A bit more verbose for the tests themselves, but this will be useful when
migrating the shared tests to using the testActor.
MozReview-Commit-ID: 94cOqhPICyI
--HG--
extra : rebase_source : f7892af19b78ecdbb759fb21d17920f0f6e0f4c6
Include inspector/test/head in shared/test/head and remove the redundant functions.
Comparing with markup/test/head and computed/test/head, some functions were also
duplicated and have been moved up to inspector/test/head or shared-head.
Logic for opening the inspector will be moved in part2.
MozReview-Commit-ID: 5EIalpbf3cf
--HG--
extra : rebase_source : 83fced672cf2da515b32fa5f1f85b3b12a4ffe5c
The collapsible sidebar has min-height:35vh and max-height:75vh
when viewport-width < 700px (ie vertical layout).
These bounds should not apply when the panel is collapsed. The
collapsing relies on negative margins to hide the panel, which
can only work if the computed height remains constant once the
panel has been collapsed.
Added a new mochitest checking that the height and margin-bottom
are constant through a layout switch.
MozReview-Commit-ID: K6EGiBtJ11S
--HG--
extra : rebase_source : 5141f4610b586c32158d0b3ee2f50fda230f3c05
Previously, every test and support file would be synced to the objdir
when running any test. Now that only those support files and tests requested
are synced, we note support files required beyond those in a test's
directory in ini manifests.
MozReview-Commit-ID: EmlDz9d4lqt
Extracted a shared helper to open the browser context menu and choose
the 'inspect element' item. This helper works with e10s.
Adapted it a little bit so it waits for the right events in order to
make sure the inspector is ready.
This also involved modifying inspectNode in nsContextMenu.js to make it
wait until the node was selected and the node was ready.
Used this in browser_inspector_initialization.js,
browser_rules_content_02.js and browser_markup_keybindings_04.js
Also removed a now useless inspector-updated event that was trigger from
the animation-inspector panel in some situation. This was left behind
from a long time ago but didn't serve any purpose anymore.
MozReview-Commit-ID: 5bFHxxrwxhL
--HG--
extra : rebase_source : cb30c7e47605f59674f2344dba10af814172333d
Extracted a shared helper to open the browser context menu and choose
the 'inspect element' item. This helper works with e10s.
Adapted it a little bit so it waits for the right events in order to
make sure the inspector is ready.
This also involved modifying inspectNode in nsContextMenu.js to make it
wait until the node was selected and the node was ready.
Used this in browser_inspector_initialization.js,
browser_rules_content_02.js and browser_markup_keybindings_04.js
Also removed a now useless inspector-updated event that was trigger from
the animation-inspector panel in some situation. This was left behind
from a long time ago but didn't serve any purpose anymore.
--HG--
extra : commitid : BUtFyFVXwYi
extra : rebase_source : 1553c9ebc1d8da035058552924e4ad3cd1b09f09
The auto-refresh highlighter base class was getting a reference to the window
object to use for highlighting at instanciation time.
This reference should be updated if a navigation of the highlight environment
occurs.
This commit maps the "win" property to a getter, so that win is always in sync
with the current highlight environment.
--HG--
rename : devtools/client/inspector/test/browser_inspector_highlighter-iframes.js => devtools/client/inspector/test/browser_inspector_highlighter-iframes_01.js
