Commit Graph

330 Commits

Author SHA1 Message Date
joe%retrovirus.com
baebbe6102 * Moved changeBookmarkURI functionality from controller.js into
nsINavBookmarksService
* Added annotation and favicon handling to changeBookmarkURI
* Added brettw's copyAnnotations patch to nsIAnnotationService
* Added a GetAnnotationService() to the annotation service for faster
  intra-component access
* Added a getBookmarkFoldersTArray() to nsINavBookmarksService for easier
  intra-component memory management; updated getBookmarkFolders() to use it
* Added stub for tagRoot to nsINavBookmarksService; DO NOT USE until 329961
  has been resolved
* Quick fix for Add Bookmarks breakage caused by 329546

bug=330192
r=brettw@gmail.com
sr=bryner@bryanryner.com
2006-03-23 06:24:54 +00:00
beng%bengoodger.com
dc5b2bd13d 329269, more command handling cleanup for places views. make sure the right commands are enabled for items in the readonly area of the places list, and generally. make sure reload commands are enabled appropriately. also, some spit and polish for the organizer window r=annie.sullivan@gmail.com 2006-03-23 00:53:54 +00:00
brettw%gmail.com
b91abc175b Fix bustage on Windows 2006-03-23 00:43:57 +00:00
brettw%gmail.com
22deb9822e Bug 329546 r=ben@mozilla.org, annie.sullivan Separate out view from history
result.
2006-03-23 00:31:48 +00:00
brettw%gmail.com
34c8c3500d Bug 331017 r=bryner Folder IDs are re-used resulting in wrong icons. 2006-03-22 22:34:31 +00:00
brettw%gmail.com
612d885dd2 Bug 329738 r=annie.sullivan Empty titles for bookmarks ignored. 2006-03-22 22:29:12 +00:00
brettw%gmail.com
f1d1c64266 Bug 326475 r=bryner Fix signedness error in result tree update. 2006-03-22 22:26:22 +00:00
brettw%gmail.com
dd43a161df Bug 327818 r=bryner Make 0 days of history disable history. 2006-03-22 22:22:41 +00:00
brettw%gmail.com
82d13512d6 Bug 330524 r=annie.sullivan Bookmark folders with unusual options (not showing
everything) don't update when new subfolders are added.
2006-03-22 22:12:52 +00:00
brettw%gmail.com
ac106b9bba Bug 330126 r=annie.sullivan Pages aren't marked as typed. 2006-03-22 21:58:59 +00:00
joe%retrovirus.com
f2f9ff880f This submission is a roll-up of three patches developed & approved during
the branch freeze:
330052 add bookmark dialog should have a default folder selected
329792 remove dead code for old tag-style folder selector in bookmark properties
330023 allow for editing of folder names

r=annie.sullivan@gmail.com
sr=ben@mozilla.org
2006-03-22 03:36:41 +00:00
brettw%gmail.com
c189db3cf0 Bug 320181 r=annie.sullivan Rewrite autocomplete code for places. 2006-03-20 23:13:01 +00:00
beng%bengoodger.com
aeb958d61d 330802 - regression in toolbar/menu D&D due to not using newer property names r=annie.sullivan@gmail.com 2006-03-17 22:50:53 +00:00
beng%bengoodger.com
a867d35b6d 330851 - ts/txul regressions... experiment by reverting to old init behavior. r=annie.sullivan@gmail.com 2006-03-17 18:12:49 +00:00
joe%retrovirus.com
3f1406a60e Removes non-assignable containers from the folder tree in the bookmark
properties dialog.

bug=330054
r=brettw
sr=ben
2006-03-17 03:19:41 +00:00
beng%bengoodger.com
3618ce030e 329269 various improvements to view initialization r=annie.sullivan@gmail.com 330736 - bug in query serialization r=brettw@gmail.com 2006-03-17 02:01:06 +00:00
annie.sullivan%gmail.com
19c5b5e582 Bug 330216: Fixes JavaScript warning when checking id of nodes with no id, patch by Phil Ringalda <philringnalda@gmail.com> r=annie.sullivan@gmail.com sr=ben@mozilla.org 2006-03-15 21:20:36 +00:00
annie.sullivan%gmail.com
780cacb5b6 Fixes several bugs with open in tabs: makes menus set selection in command events in case DOMMenuItemActive doesn't get sent, only shows Open in Tabs menuitem if there are two or more items in the menu, and respects browser.tabs.loadFolderAndReplace and browser.tabs.loadBookmarksInBackground prefs. Also moves #include of debug.js to browser.js as this was causing JavaScript errors on the mac. r=ben@mozilla.org sr=darin@meer.net bug=330130 2006-03-15 19:59:09 +00:00
joe%retrovirus.com
c867d63a62 Changes a few remaining ASSERT() calls to NS_ASSERT() calls that I had missed
when working on bug 327349.

bug=330489
r=annie.sullivan@gmail.com
sr=ben@mozilla.org
2006-03-14 22:58:59 +00:00
joe%retrovirus.com
cef3e07235 Replace use of deprecated window.title with window.document.title.
bug=330075
r=annie.sullivan@gmail.com
sr=ben@mozilla.org
2006-03-14 17:20:23 +00:00
joe%retrovirus.com
bd7b62fd23 Moved Ben's JavaScript ASSERT function to be NS_ASSERT in
toolkit/content/debug.js

debug.js is now included by globalOverlay.js, but if that's not in your
scope you can just #include debug.js directly.

NS_ASSERT() shows a dialog box containing a stack trace when it's called
with a condition that isn't true.  The dialog box will be suppressed in
final builds, but in nightlies and alphas, it's useful for encouraging
bug submissions.  To disable the dialogs, set XUL_ASSERT_PROMPT=0 in
your environment.

bug=327349
r=darin@meer.net, gavin.sharp@gmail.com
2006-03-14 01:56:09 +00:00
brettw%gmail.com
47430fafa3 Bug 330220 r=annie.sullivan Incorrect behavior when resorting after insertion.
Causes items not to resort, occasional crashes.
2006-03-13 19:13:31 +00:00
beng%bengoodger.com
2a9e312db8 329269 - more work on places organizer. menus, accessible sorting and grouping options, etc. still a work in progress. r=annie.sullivan@gmail.com 2006-03-10 23:48:40 +00:00
brettw%gmail.com
1776867707 Bug 328598 r=vladimir Rollback 0-fill deleted DB entries and vacuum on
explicit clear to improve shutdown times.
2006-03-10 21:02:32 +00:00
brettw%gmail.com
42c99db36e Bug 329854 r=joe.hughes Add a excludeReadOnlyFolders to query options for
use when filing.
2006-03-10 19:44:28 +00:00
annie.sullivan%gmail.com
1e43db4652 Fixes bug where messages when bookmark folder children were shifted caused separators not to be removed correctly. bug=329892 r=brettw@gmail.com 2006-03-10 19:22:32 +00:00
joe%retrovirus.com
a1baed1ab6 Changes to bookmark properties dialog:
* Customized bookmark properties dialog for add vs. edit cases
* Added support for changing URI of bookmark (annotations not carried over yet)
* Add support for viewing properties of history entries
* Changed from tag-style control to folder tree for folder selection,
  yielding layout and accessibility improvements
* Switched to using standard dialog buttons

bug=329272
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com
2006-03-10 17:36:41 +00:00
annie.sullivan%gmail.com
73f1a70a04 Fixes bug where observers didn't check the parent correctly on folder notifications. bug=329892 r=ben@mozilla.org 2006-03-10 00:09:32 +00:00
beng%bengoodger.com
d245cc99cc 329956 - add bookmark button on toolbar no longer works. r=joe@retrovirus.com 2006-03-09 22:02:21 +00:00
joe%retrovirus.com
6ee44b5596 Temporary tweak to the Bookmark Properties dialog so that it doesn't
take over the screens of nightly users with large bookmark hierarchies.

bug=329761
r=joe@retrovirus.com
sr=ben@mozilla.org
2006-03-09 22:00:58 +00:00
brettw%gmail.com
333e978287 Bug 329691 r=bryner Refactor init so that table creation happens before the
dummy database statement (which keeps the cache from expiring) starts. Fixes
errors during DB init and also performance problems on first run.
2006-03-09 17:34:35 +00:00
brettw%gmail.com
b33591dc65 Bug 329831 r=annie.sullivan Make QueryStringToQueries return empty array if
there is no input.
2006-03-09 17:27:14 +00:00
beng%bengoodger.com
55dc9c72be fallout from 329586 - make sure places organizer trees find the browser window so they can open bookmarks 2006-03-09 08:42:05 +00:00
beng%bengoodger.com
4f1506ea51 revert part of previous change to 329586 to reduce Ts on windows 2006-03-09 04:58:07 +00:00
beng%bengoodger.com
1968c27e50 329586 - browser shim cleanup, tidies up some UI update notification in the browser, fixes a few menu items here and there, removes unnecessary initialization, moves places to its own window, removes all code to do with maintaining places as a tab, renames osme objects and member variables, formatting issues, creates a browser controller for updating commands. r=annie.sullivan@gmail.com 2006-03-09 02:08:45 +00:00
mark%moxienet.com
db4ea6c86f 329806 Fix history import when upgrading from 1.0 profile without going through 1.5. r=bryner 2006-03-09 01:17:36 +00:00
brettw%gmail.com
ef6412bece Comment out bug 329819 and 329691 which was causing problems. 2006-03-08 21:40:09 +00:00
brettw%gmail.com
d305bbd079 Bug 329819 r=annie.sullivan Fix Tp regression from bug 329691, the dummy table
needs data in it to hold the statement (and hence the cache) open.
2006-03-08 21:23:22 +00:00
brettw%gmail.com
db969df09c Bug 329698 r=joe@retrovirus.com,bryner Implement GetPageAnnotationNames 2006-03-08 20:33:49 +00:00
brettw%gmail.com
d930ffbce5 Bug 329691 r=darin Errors creating tables in some situations (leads to error
creating bookmark service).
2006-03-08 16:51:32 +00:00
annie.sullivan%gmail.com
560c49ad1d Fixes JavaScript warnings about trailing commas and redefined variables. bug=329171 r=ben@mozilla.org 2006-03-07 23:20:08 +00:00
brettw%gmail.com
3bf94f4f67 Bug 329524 r=joe.hughes ReplaceItem bookmark call doesn't update cache. 2006-03-07 22:50:22 +00:00
annie.sullivan%gmail.com
7038dc011b Bug 328779: Statusbar text for bookmark menu items, Patch by Dave Townsend <mossop@blueprintit.co.uk> r=annie.sullivan@gmail.com sr=ben@mozilla.org 2006-03-07 18:41:38 +00:00
beng%bengoodger.com
12ccb5f107 329587 - controllers registered after places controller cannot execute any commands due to places controller consuming all. r=fritz@google.com 2006-03-07 18:24:28 +00:00
annie.sullivan%gmail.com
a746ead8e1 Makes toolbar and menu initialize from place attribute
bug=329531 r=ben@mozilla.org
2006-03-07 16:10:37 +00:00
brettw%gmail.com
604956368a Bug 329563 r=annie.sullivan Clarify annotation IDL documentation 2006-03-07 00:58:30 +00:00
joe%retrovirus.com
30d30c1b17 * Allows the user to access Bookmark Properties dialog from context menus.
* Adds support for editing the bookmark shortcut (formerly keyword) in the Bookmark Properties dialog.
* Improves the appearance of the Bookmark Properties dialog.
* Removes dead code from PlacesBrowserShim in browser.js

NOTE: This doesn't reflect the final UI for this functionality; rather,
this change is intended to add functionality for users of the nightlies.

bug=322988
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com
2006-03-07 00:52:35 +00:00
annie.sullivan%gmail.com
3bc14e6bed Moving "Open in Tabs" out of menu/toolbar binding and into browser code.
bug=329266 r=ben@mozilla.org
2006-03-05 01:40:26 +00:00
annie.sullivan%gmail.com
a7d4222b3c Adds menuitem for Open In Tabs.
Reorganizes code so that command/click handlers for toolbar/menu bindings can be attached by overlays.
r=ben@mozilla.org bug=327034
2006-03-04 01:12:05 +00:00
brettw%gmail.com
d3c8daa506 Bug 327206 r=annie.sullivan Make folder result nodes' readonly property sync
with bookmark readonly property.
2006-03-03 21:16:23 +00:00