Commit Graph

2212 Commits

Author SHA1 Message Date
justdave%syndicomm.com
bb1c25a4d0 Fix for bug 72862: fixes more Perl warnings in RelationSet.pm and globals.pl 2001-06-01 02:14:23 +00:00
justdave%syndicomm.com
ed939131dc Fix for bug 57848, perl warnings in several files.
Patch by Nick Hibma <n_hibma@qubesoft.com>
r= justdave@syndicomm.com
2001-06-01 02:07:28 +00:00
ian%hixie.ch
07b4d3d583 * fixing some syntactic errors
* added addUserGroup and removeUserGroup to the data source interface for users
* added some comments
* changed many double quotes |"| to single quotes |'| where double quotes were not needed
* implemented the remaining methods for the MySQL implementation of the user data source
* added a mode flag to user fields (idea from MattyT) so that fields can be disabled, hidden, etc
2001-06-01 00:32:35 +00:00
jake%acutex.net
d520cdb669 Bugzilla was leaking information about bugs marked secure (using bug groups). This checkin fixes bugs 39524, 39527, 39531, and 39533.
Patches by Myk Melez <myk@mozilla.org>.
r= jake@acutex.net
2001-05-31 15:52:25 +00:00
jake%acutex.net
7da1a248bc Bug 80388 - cvsblame shouldn't require layers for popups
r=baloo
2001-05-30 22:13:03 +00:00
jake%acutex.net
8cbb7741ca Fix for bug 45164 - New users created by the admin were not subject to the userregexp for groupsets.
Patch by Joe Robins <jmrobins@tgix.com>
r= jake@acutex.net
2001-05-30 15:47:30 +00:00
justdave%syndicomm.com
17dff3efe0 Dummy commit so I can put the attributions I forgot in the previous one.
Patch from bug 65290 was by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-05-29 21:27:12 +00:00
justdave%syndicomm.com
8f363f7f6e Fix for bug 65290: can now edit user-regexps for system groups 2001-05-29 21:25:02 +00:00
ian%hixie.ch
76d1f38fb9 Change the semantics of address changing, making it faster, smaller, simpler, and better. Aaah... :-) In the new system, instead of cloning the current $session object to pass it back to the output code, you pass the real $session object to the output code, just making sure that the relevant field has been warned to return a different address than found in the database. 2001-05-29 20:34:12 +00:00
justdave%syndicomm.com
de23e17707 Fix for bug 65399: Can't use string ("") as an ARRAY ref while "strict refs" in use at query.cgi due to no components defined in a product.
Patch by Matthias Radestock <matthias@sorted.org>
r= justdave@syndicomm.com
2001-05-29 20:30:51 +00:00
justdave%syndicomm.com
3aaea9ad25 Additional cleanup for bug 73191. newquip.html is no longer needed. 2001-05-29 18:44:00 +00:00
ian%hixie.ch
1b89023d7a Adding some XXX comments regarding a known bug (when the user is changing their address, fields try to update the database before the new address has been authenticated) 2001-05-29 09:11:33 +00:00
ian%hixie.ch
2411ff6005 * Fixing a minor bug in the MySQL implementation of the string data source
* Started implementing the MySQL version of the user data source (completed so far: database creation and a few of the SELECT calls)
* Changed the user property 'disabled' to 'mode' to enable extensibility
* Fix a potential bug with changing addresses (make sure the fake session object doesn't update the database -- this is an incomplete solution so far, fields still have the bug)
2001-05-29 09:07:10 +00:00
justdave%syndicomm.com
c2cf48b4bd Fix for bug 78045: change references to README in error messages to point to the Bugzilla Guide instead.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave@syndicomm.com
2001-05-29 08:10:28 +00:00
justdave%syndicomm.com
5205d71b1c Landing quips.cgi (bug 73191) by Owen Taylor <otaylor@redhat.com>
Submitted by Martin Baulig <baulig@suse.de> from bugzilla.gnome.org
r= justdave@syndicomm.com
2001-05-29 04:01:48 +00:00
justdave%syndicomm.com
93046edb9a Fix for bug 77699 and bug 71503: fix javascript errors in quicksearch and improve IE5 compatibility
Patch by Stephan Lee <slee@uk.bnsmc.com> and Andreas Franke <afranke@ags.uni-sb.de>
2001-05-29 03:05:46 +00:00
ian%hixie.ch
fe6643848b * Moving 'type' to the front of the list of things returned by the User data source's 'getField*' methods so that they map more directly to the user field constructor arguments
* Moving 'typeData' around in the order of the user field constructor arguments to match the User data source's 'getField*' methods so that, again, they map more directly
* Renaming the 'getFieldFrom*' methods to 'getFieldBy*' to be consistent with 'getUserBy*'
* Implemented UserFieldFactory.pm
* Implemented Passwords.pm
2001-05-28 23:43:56 +00:00
ian%hixie.ch
e60cd56ae6 * Correcting a typo in Input.pm
* Added a comment to DataSource/User.pm explaining how (typically) to search for a username
* Fleshed out the DataSource/User.pm API by adding some schema management methods
* Added notes on which fields in the database schema should be keys
* Added comment to Service/User.pm noting the difference between Objects, Services, and Service Instances
* Changed 'user.field.factory' to 'user.fieldFactory' to prevent a namespace collision with 'user.field.(type)'
* Calling 'insertField' in one case which I missed when adding the method
* Implemented 'hash', 'joinGroup', 'invalidateRights', 'writeProperties' and 'writeGroups'
* Changed Service/UserField.pm so that one user field class can be used for any category
* Added a 'username' convenience method and implemented 'write'
* Added a comment to Service/UserFieldFactory.pm explaining how it should work
* Removed the 'user.field.generic.generic' field implementation, replaced it with a simpler 'user.field.string' implementation
2001-05-28 20:09:23 +00:00
jake%acutex.net
bbb2c13524 Bug 79739 - Initial Owner and QA Contact were not being handled correctly by the email interface after they were changed to userid's in bug 66876.
r= justdave@syndicomm.com
2001-05-25 12:48:47 +00:00
jake%acutex.net
4cf2c59aa4 Mention the Bugzilla project page and where to report bugs
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave@syndicomm.com, jake@acutex.net
2001-05-24 12:58:33 +00:00
ian%hixie.ch
1ffb74226d Added some minor corrections and clarifications to the documentation.
Added some comments to various user-related files.
Factored out some code that started becoming common when inserting fields in Service/User.pm.
Added code to deal with adding new contact details.
Added code to support removing fields from a user.
2001-05-24 07:06:41 +00:00
timeless%mac.com
68152b8d2a 62446 extra spaces inside links on some lxr-generated pages
r=terry
2001-05-24 04:10:23 +00:00
timeless%mac.com
2ed9571632 45785 Swapped ALIGN/VALIGN attributes
39224 duplicate word on lxr.mozilla.org/ ("use use")
r=terry
2001-05-24 04:07:43 +00:00
jake%acutex.net
7d7408335b Bug 71552 - Remove oldemailtech from Bugzilla
r= justdave@syndicomm.com
2001-05-24 03:10:49 +00:00
ian%hixie.ch
d9c627c0b9 Started work on fleshing out the user components. This is still work in progress. 2001-05-14 06:45:08 +00:00
ian%hixie.ch
76a1624abe Initial checkin of the Field part of the User work. Just ideas at the moment, nothing here is implemented, and much of it is likely to change. 2001-05-13 20:54:35 +00:00
ian%hixie.ch
57c85fb025 First pass at adding User objects (derived from Session). Lots of XXX code -- none of this works, it's basically all stubs.
In addition to the code that actually does stuff, I still need to add a MySQL implementation of the data source and the Field class and its associated Factory.
Also added Passwords.pm (stubs for a password generator and encryptor) and made Session objects store a pointer to the controller object.
2001-05-13 18:11:54 +00:00
ian%hixie.ch
a47f424255 Added a bit more support for objects (as opposed to services): added a new objectCreate() constructor and an objectInit() method.
Added an optimisation to Controller.pm so that service names will be hashed once accessed. This should make multiple accesses of the same service a lot quicker. To go with this I added some diagnostics code (on exit) and moved the code around a little bit.
Fixed a minor transgression of the coding style guidelines in Magic*Array.pm. :-)
Neatened up the code in Output.pm.
Made it so Session objects assume they have an 'app' property, and so don't need to be passed $app all the time. (Sessions are objects now.)
Added an unimplemented getAddress() method to the Session class.
2001-05-13 18:04:52 +00:00
ian%hixie.ch
b211b52c46 fixing two rather serious (albeit simple) bugs in the strings data source; adding a comment to Input.pm in preparation for doing the user authentication stuff 2001-05-13 05:52:24 +00:00
justdave%syndicomm.com
66952b81d2 Fix for bug 38859: escape invalid email addresses for HTML before displaying to the user.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net, justdave@syndicomm.com
2001-05-11 18:02:38 +00:00
justdave%syndicomm.com
c3637c7ac6 Fix for bug 80045: 500 Server Error in IE (but not Netscape or Mozilla) on errors looking up email addresses.
Patch by <jake@acutex.net>
r= justdave@syndicomm.com
2001-05-10 18:16:51 +00:00
justdave%syndicomm.com
08322c85b4 Fix for bug 38854: reports.cgi needs to escape (untrusted) url params
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-05-10 03:02:52 +00:00
justdave%syndicomm.com
6d5e40ea64 Fix for bug 38855: showvotes.cgi needs to escape (untrusted) url params
Patch by Myke Melez <myk@mozilla.org>
r= jake@acutex.net
2001-05-10 02:53:22 +00:00
justdave%syndicomm.com
c699c249ad Fix for bug 79730: Minor minor typo in move.pl (recieve -> receive).
Patch by gavins@iplbath.com (Gavin Shelley).
r= justdave@syndicomm.com
2001-05-09 18:32:35 +00:00
ian%hixie.ch
0ecf1d5628 adding some progress messages to the setup output; making COSES more resilient to invalid input 2001-05-08 00:05:42 +00:00
ian%hixie.ch
572285560e Slight changes to make output code more flexible 2001-05-07 07:04:17 +00:00
ian%hixie.ch
b8a735d31d * fixed the methodMissing() method so that it actually is possible to use it to do method dispatching;
* factored out some of the method dispatching code by adding a dispatchMethod() method to the controller;
* turned the Dispatcher class into simply a function on the base Service class and removed Dispatcher.pm;
* made it possible for services to be both services and objects and provide different services depending on which context they were called in (and used this to make the AdminCommands module actually do what it was intended to in the first place, namely, only work for CommandLine access);
* fixed it so if a service is first created by getServiceList the constructed version will actually be cached;
* made output more generic by allowing services to implement arbitrary parts of the output API, used that to make AdminCommands usable without requiring additional code to support it;
* added some documentation;
* added some dump(10) statements to help debugging;
* fixed the string datasource SQL;
* fixed the DBI database so it can handle errors;
* added tableExists API to the DBI database helper.
Thanks to myk, justdave and zach for some ideas.
2001-05-06 06:26:24 +00:00
ian%hixie.ch
aac5db9914 Made the lack of a configuration file be non-fatal (and factored out the low level code while I was at it). We need that so that the configuration data source can actually go in and create the configuration file if it is missing; otherwise the program exits with "no configuration file! waah!" before you get to the configuration-file-creation code! 2001-05-05 19:00:06 +00:00
ian%hixie.ch
1dc1d947ea Implementing (and documenting!) PLIF::debug() as suggested by zach. a=hixie 2001-05-05 18:28:08 +00:00
ian%hixie.ch
0baba2d269 work in progress 2001-05-05 07:12:56 +00:00
ian%hixie.ch
1987fac6eb Blatantly copied http://scarab.tigris.org/scarab-design.html and changed it to suit Bugzilla 2001-05-03 10:57:46 +00:00
ian%hixie.ch
318280bff2 Creating new Bugzilla 3 directory. Nothing to see here yet! 2001-05-03 10:41:12 +00:00
ian%hixie.ch
cfc5246ba6 Fixing various typos and spelling mistakes spotted by timeless. There shouldn't be any code level changes here. moa=hixie 2001-04-29 08:35:29 +00:00
justdave%syndicomm.com
4f193d1f18 rolling version number to 2.13 for development 2001-04-27 19:36:20 +00:00
justdave%syndicomm.com
6c276b00a8 addition to 2.12 release notes 2001-04-27 19:32:27 +00:00
Chris.Yeh%nokia.com
ad4e9851e6 Fix for sendmail daemons that don't support EHLO. We never use the extended
functionality anyway, so replace it with a standard HELO. Thanks to Ken Key for
helping me track this down.
2001-04-26 22:53:20 +00:00
justdave%syndicomm.com
4a8cfd0de6 Backing out .htaccess commit, these don't belong here yet. It broke checksetup.pl, too. 2001-04-26 04:16:03 +00:00
barnboy%trilobyte.net
8ab8b154ac Added .htaccess files for shadow/, data/, and /.
I added related information to the Bugzilla Guide, and
tacked in a couple of last-minute additions.  Also fixed the
annoying "Tip: HINT:" thing.
2001-04-26 01:51:59 +00:00
tara%tequilarista.org
b9aa9e56ce Tara is a bucket head. Floating version to 2.12 ship for tag and stripe 2001-04-25 15:45:27 +00:00
tara%tequilarista.org
c992df21c5 Removing forward planning text 2001-04-25 15:38:34 +00:00