Commit Graph

7572 Commits

Author SHA1 Message Date
Mike Hommey
b5706992db Bug 1537641 - Make MIDL use clang-cl as a preprocessor. r=dmajor
Using clang-cl as a preprocessor fails with:
```
In file included from z:\build\build\src\accessible\ipc\win\handler\HandlerData.idl:8:
z:\build\build\src\accessible\ipc\win\handler/AccessibleHandler.h(27,8): error: pasting formed 'Accessible2_3.', an invalid preprocessing token [-Winvalid-token-paste]
import NEWEST_IA2_IDL;
       ^
z:\build\build\src\accessible\ipc\win\handler/AccessibleHandler.h(15,24): note: expanded from macro 'NEWEST_IA2_IDL'
                       ^
z:\build\build\src\accessible\ipc\win\handler/AccessibleHandler.h(14,22): note: expanded from macro 'IDLFOR'
                     ^
z:\build\build\src\accessible\ipc\win\handler/AccessibleHandler.h(13,36): note: expanded from macro '__GENIDL'
                                   ^
1 error generated.
midl : command line error MIDL1003 : error returned by the C preprocessor (1)
```

There's only one place using the NEWEST_IA2_IDL and accompanying
macros, we can just avoid the issue altogether by expanding it manually
(and it's not like the macro buys much, the other arm of the __midl ifdef
has a #include "Accessible2_3.h" that doesn't use the macro either,
presumably for the same reason).

Differential Revision: https://phabricator.services.mozilla.com/D24868

--HG--
extra : moz-landing-system : lando
2019-03-26 16:29:17 +00:00
James Teh
ef2bda893e Bug 1473234: make a11y listen to DOM events from iframes and shadow DOM. r=eeejay
1. Register with the root document window's parent target, since this receives events for iframes and shadow DOM. (The root document itself doesn't.)
2. Hold onto the target node when scheduling processing of the DOM event, as GetOriginalTarget returns null when we process shadow DOM events async.

Depends on D21349

Differential Revision: https://phabricator.services.mozilla.com/D21350

--HG--
extra : moz-landing-system : lando
2019-03-25 05:04:36 +00:00
arthur.iakab
35c8a01713 Merge mozilla-central to autoland 2019-03-25 17:54:29 +02:00
arthur.iakab
ee02cd6515 Merge inbound to mozilla-central a=merge 2019-03-25 17:53:27 +02:00
dlee
d7d67be8c9 Bug 1522412 - P3. Adopt nsIChannel.LOAD_BYPASS_URL_CLASSIFIER in the algorithm determining if we should classify a channel's URI. r=Ehsan,mayhemer
This patch uses the flag to exempt channels from classification, but it
doesn't include the use cases of this flag.

See Bug 1442496 for the list of the call sites should use this flag.

Differential Revision: https://phabricator.services.mozilla.com/D22112

--HG--
extra : moz-landing-system : lando
2019-03-25 12:48:25 +00:00
dlee
9878ae650d Bug 1522412 - P2. Remove nsIChannel.LOAD_CLASSIFY_URI flag. r=Ehsan
nsIChannel.LOAD_CLASSIFY_URI is no longer required so we can remove it from
the codebase.
In the mean time, we add a new LOAD_BYPASS_URL_CLASSIFIER load flag for
channel creator to be able to force channel to bypass URL classifier check.
The use of the new LOAD_BYPASS_URL_CLASSIFIER flag will be addressed in
the other patches.

Differential Revision: https://phabricator.services.mozilla.com/D22111

--HG--
extra : moz-landing-system : lando
2019-03-25 12:47:57 +00:00
James Teh
1911fb04f0 Bug 1530931: Correctly handle retrieving a container accessible for a shadow root. r=eeejay
This can happen, for example, when GetAccessibleOrContainer is called within SelectionManager::ProcessSelectionChanged due to focusing a direct child of a shadow root.
In this case, the common ancestor is the shadow root itself.
Previously, we returned null in this case because GetFlattenedTreeParent doesn't work on the shadow root itself.
Now, we check if the given node is the shadow root, and if so, we use the shadow host instead.
This prevents the "We must reach document accessible implementing text interface!" assertion in SelectionManager::ProcessSelectionChanged when a direct child of a shadow root gets focus.

Differential Revision: https://phabricator.services.mozilla.com/D21349

--HG--
extra : moz-landing-system : lando
2019-03-25 05:04:29 +00:00
Eitan Isaacson
0bcec64436 Bug 1538021 - Use owner of WindowEventDispatcher as window for messaging. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D24442

--HG--
extra : moz-landing-system : lando
2019-03-23 21:22:02 +00:00
Eitan Isaacson
05665102b2 Bug 1536123 - Move virtual cursor to caret offset. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D23911

--HG--
extra : moz-landing-system : lando
2019-03-21 16:20:51 +00:00
Ian Moody
4bb3237beb Bug 1536648 - accessible/ manual ESLint no-throw-literal fixes. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D24107

--HG--
extra : moz-landing-system : lando
2019-03-20 00:23:17 +00:00
Mark Banner
2219bbd153 Bug 1536645 - Enable some ESLint rules in accessible/tests/browser where they are already enabled in the global configuration. r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D24105

--HG--
extra : moz-landing-system : lando
2019-03-21 08:51:28 +00:00
Mark Banner
4896af57f9 Bug 1536645 - Remove unnecessary rule definitions (obsolete, no need to override etc) in accessible/tests/browser/.eslintrc.js. r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D24104

--HG--
extra : moz-landing-system : lando
2019-03-21 08:51:08 +00:00
Gurzau Raul
2666e16a53 Backed out 7 changesets (bug 1522412) for xpcshell failures at test_shouldclassify.js on a CLOSED TREE.
Backed out changeset 7c998456e1fd (bug 1522412)
Backed out changeset ebb581ddf1d1 (bug 1522412)
Backed out changeset 850e1c68d978 (bug 1522412)
Backed out changeset fe288a48cecb (bug 1522412)
Backed out changeset 5399bca472b1 (bug 1522412)
Backed out changeset 91e5b339fe11 (bug 1522412)
Backed out changeset b80098d0a5c4 (bug 1522412)
2019-03-21 11:02:09 +02:00
Dimi Lee
fe284ca3d4 Bug 1522412 - P3. Adopt nsIChannel.LOAD_BYPASS_URL_CLASSIFIER in the algorithm determining if we should classify a channel's URI. r=Ehsan,mayhemer
This patch uses the flag to exempt channels from classification, but it
doesn't include the use cases of this flag.

See Bug 1442496 for the list of the call sites should use this flag.

Differential Revision: https://phabricator.services.mozilla.com/D22112

--HG--
extra : moz-landing-system : lando
2019-03-21 07:32:46 +00:00
Dimi Lee
8f1caf4049 Bug 1522412 - P2. Remove nsIChannel.LOAD_CLASSIFY_URI flag. r=Ehsan
nsIChannel.LOAD_CLASSIFY_URI is no longer required so we can remove it from
the codebase.
In the mean time, we add a new LOAD_BYPASS_URL_CLASSIFIER load flag for
channel creator to be able to force channel to bypass URL classifier check.
The use of the new LOAD_BYPASS_URL_CLASSIFIER flag will be addressed in
the other patches.

Differential Revision: https://phabricator.services.mozilla.com/D22111

--HG--
extra : moz-landing-system : lando
2019-03-21 07:30:51 +00:00
Narcis Beleuzu
8f2eeb4b40 Backed out 2 changesets (bug 1530931, bug 1473234) for crashtest failures on RootAccessible::RemoveEventListeners . CLOSED TREE
Backed out changeset 54057e1121b5 (bug 1473234)
Backed out changeset faa43bdd3347 (bug 1530931)
2019-03-21 05:53:57 +02:00
Mats Palmgren
be049c79d6 Bug 205202 part 4 - [css-lists][css-pseudo] Rename various uses of bullet with marker to avoid any misleading association with nsBulletFrame (idempotent patch). r=emilio 2019-03-24 23:13:53 +01:00
James Teh
44f8fe46e4 Bug 1473234: make a11y listen to DOM events from iframes and shadow DOM. r=eeejay
1. Register with the root document window's parent target, since this receives events for iframes and shadow DOM. (The root document itself doesn't.)
2. Hold onto the target node when scheduling processing of the DOM event, as GetOriginalTarget returns null when we process shadow DOM events async.

Differential Revision: https://phabricator.services.mozilla.com/D21350

--HG--
extra : moz-landing-system : lando
2019-03-01 02:48:47 +00:00
James Teh
d4b9670c0d Bug 1530931: Correctly handle retrieving a container accessible for a shadow root. r=eeejay
This can happen, for example, when GetAccessibleOrContainer is called within SelectionManager::ProcessSelectionChanged due to focusing a direct child of a shadow root.
In this case, the common ancestor is the shadow root itself.
Previously, we returned null in this case because GetFlattenedTreeParent doesn't work on the shadow root itself.
Now, we check if the given node is the shadow root, and if so, we use the shadow host instead.

This prevents the "We must reach document accessible implementing text interface!" assertion in SelectionManager::ProcessSelectionChanged when a direct child of a shadow root gets focus.

Differential Revision: https://phabricator.services.mozilla.com/D21349

--HG--
extra : moz-landing-system : lando
2019-03-20 15:19:44 +00:00
Eitan Isaacson
ec2f69700f Bug 1535701 - Followup to fix checkstyle and eslint.
Differential Revision: https://phabricator.services.mozilla.com/D24232

--HG--
extra : moz-landing-system : lando
2019-03-20 18:17:23 +00:00
Eitan Isaacson
2b6876f959 Bug 1535701 - Don't clear focus when moving vc away from focused node. r=yzen
This is more consistent with how it works in GeckoView. We need to give
up this behavior because it reset the top-level caret position on each
blur. This interferes with find in page which goes to the next search
result past the current caret.

Differential Revision: https://phabricator.services.mozilla.com/D23746

--HG--
extra : moz-landing-system : lando
2019-03-20 16:48:36 +00:00
Dão Gottwald
4a910bb78f Bug 1536753 - browser_test_focus_urlbar.js: make waitForSearchFinish work with the quantumbar enabled. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D24144

--HG--
extra : moz-landing-system : lando
2019-03-20 10:29:26 +00:00
Ian Moody
167f623a3e Bug 1246594 - Enable ESLint rule no-throw-literal by default. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D24088

--HG--
extra : moz-landing-system : lando
2019-03-19 22:02:42 +00:00
Gijs Kruitbosch
1e96300cf3 Bug 1353013 - create preloaded newtab browser from an idle task, only in top window(s), r=dthayer
This limits us to 1 preloaded browser per window, in the top 3 normal windows + top 3 private windows.
If we try to create additional browsers beyond that, we instead move a pre-existing browser across.

Differential Revision: https://phabricator.services.mozilla.com/D21129

--HG--
extra : moz-landing-system : lando
2019-03-19 17:29:48 +00:00
Alex Gaynor
177fb00eba Bug 1375863 - fold MOZ_CONTENT_SANDBOX and MOZ_GMP_SANDBOX into MOZ_SANDBOX; r=jld,firefox-build-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D22975

--HG--
extra : moz-landing-system : lando
2019-03-18 22:31:59 +00:00
Samuel Thibault
2d9c404352 Bug 1535325 atk: Always convert control character events into key names r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D23638

--HG--
extra : moz-landing-system : lando
2019-03-19 01:04:19 +00:00
Emilio Cobos Álvarez
e66fb8488c Bug 1535165 - Use cbindgen for text-decoration-line. r=dholbert,boris
Differential Revision: https://phabricator.services.mozilla.com/D23412

--HG--
extra : moz-landing-system : lando
2019-03-18 17:58:16 +00:00
Eitan Isaacson
c35dbb6950 Bug 1479042 - Handle text insertion and name change events as live regions and announce. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D21612

--HG--
extra : moz-landing-system : lando
2019-03-15 23:10:42 +00:00
Eitan Isaacson
6d8e53ccd1 Bug 1479042 - Add Android announcement event plumbing. r=yzen
Depends on D21610

Differential Revision: https://phabricator.services.mozilla.com/D21611

--HG--
extra : moz-landing-system : lando
2019-03-05 19:36:05 +00:00
Mark Banner
6ea18465bb Bug 1534661 - Fix the QuantumBar results view to have an accessible role of ROLE_COMBOBOX_LIST. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D23155

--HG--
extra : moz-landing-system : lando
2019-03-15 16:43:11 +00:00
Edwin Gao
a5bef7a7c7 Bug 1531590, 1531598, 1534811, 1336075, 1531571, 1531572, 1531572, 1531574, 1534855, 1534857, 1535082 - skip tests in mochitest-dev-tools and mochitest-browser-chrome suites for windows10-aarch64 r=jmaher
Bug 1531598 - disable browser_markup_copy_image_data.js
Bug 1531598 - disable browser_markup_links_04.js
Bug 1531598 - disable browser_inspector_menu-01-sensitivity.js
Bug 1534811 - disable accessible/tests/browser/general
Bug 1336075 - disable browser_largeAllocation_non_win32.js
Bug 1531571 - disable browser_jsterm_context_menu_labels.js
Bug 1531572 - disable browser_jsterm_helper_dollar_x.js
Bug 1531573 - disable browser_jsterm_no_input_and_tab_key_pressed.js
Bug 1531574 - disable browser_jsterm_syntax_highlight_output.js
Bug 1534855 - disable accessible/tests/browser/
Bug 1534857 - disable browser_ext_slow_script.js
Bug 1535082 - disable browser_jsterm_helper_dollar_dollar.js

Differential Revision: https://phabricator.services.mozilla.com/D23369

--HG--
extra : moz-landing-system : lando
2019-03-13 19:47:25 +00:00
Boris Zbarsky
9a4ba73134 Bug 1534370 part 3. Mark InsertFromTransferable as MOZ_CAN_RUN_SCRIPT. r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D23042

--HG--
extra : moz-landing-system : lando
2019-03-12 01:55:03 +00:00
Eitan Isaacson
50711a42d5 Bug 1531579 - Refresh viewport cache on tree mutations and fire android event. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D21610

--HG--
extra : moz-landing-system : lando
2019-03-12 21:58:37 +00:00
Dorel Luca
df51e27b6a Backed out changeset 583048926c12 (bug 1531579) for Geckoview failure. CLOSED TREE 2019-03-12 01:38:46 +02:00
Eitan Isaacson
adcc1ec434 Bug 1531579 - Refresh viewport cache on tree mutations and fire android event. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D21610

--HG--
extra : moz-landing-system : lando
2019-03-05 19:28:41 +00:00
Eitan Isaacson
9559a7c4a2 Bug 1531346 - Check for cyclical relationship with aria-activedescendant. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D22633

--HG--
extra : moz-landing-system : lando
2019-03-08 07:55:13 +00:00
Martin Robinson
d74ffde9eb Bug 1533429 - Return -1 for atk_text_get_caret_offset when we can't get the offset r=surkov
This makes Gecko conform to the newly documented expected behavior of ATK.

MozReview-Commit-ID: K9sRUDqeLq4

Differential Revision: https://phabricator.services.mozilla.com/D22550

--HG--
extra : moz-landing-system : lando
2019-03-07 18:07:24 +00:00
Alexander Surkov
e5f57aa59a Bug 1525101 - Convert autocomplete-rich-result-popup into a Custom Element, r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D20506

--HG--
extra : moz-landing-system : lando
2019-03-05 17:45:57 +00:00
Tim Nguyen
fa021187df Bug 1513343 - Remove textarea binding and replace usages with html:textarea. r=bgrins,dao
Differential Revision: https://phabricator.services.mozilla.com/D15001

--HG--
extra : moz-landing-system : lando
2019-03-05 11:41:42 +00:00
Mark Banner
8fa4d25923 Bug 1532367 - Remove accessible/.eslintrc.js and use the global rules for accessible/ r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D21973

--HG--
extra : moz-landing-system : lando
2019-03-04 21:47:38 +00:00
Neil Deakin
66040975f2 Bug 1519953, replace calls to retrieve boxobject position and size with getBoundingClientRect, r=gijs
--HG--
extra : rebase_source : 65a9e08513ada3cda6beeb09d7f8a53620c2999f
2019-03-01 12:26:45 -05:00
Neil Deakin
b5b280bfa8 Bug 1519955, Don't use boxobject properties in accessibility, r=jteh
--HG--
extra : rebase_source : 07d7bf9f4fec981f9f3c0c6ed52e78fdddedca5c
2019-03-01 12:26:37 -05:00
Ryan Hunt
179b832433 Bug 1523969 part 1 - Move method definition inline comments to new line in accessible/. r=jamie
Differential Revision: https://phabricator.services.mozilla.com/D21101

--HG--
extra : rebase_source : 5b1dc394aba125c9f14977efc1a71b60455d1bf6
2019-02-25 16:02:26 -06:00
Eitan Isaacson
130d8fe6b2 Bug 1512567 - Check that we didn't already create an IPCDoc for the DocAccessible. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D20594

--HG--
extra : moz-landing-system : lando
2019-02-26 17:05:47 +00:00
Samuel Thibault
c839074621 Bug 919508 - layout: add more tests for text inspection from accessibility layer r=jfkthame
--HG--
extra : histedit_source : d9dcae87e90fc0c997b03f157c54a8ed6ee72cbc
2019-02-22 22:13:06 +01:00
Samuel Thibault
fb05007f2c Bug 919508 - layout: Do not trim spaces when inspected from accessibility layer r=jfkthame
--HG--
extra : histedit_source : 3fbe469291ddca0344d6fd88dcadb6282f1ca846
2019-02-22 22:12:48 +01:00
Eitan Isaacson
bf64f6d78e Bug 1525470 - Include description in accessible hints. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D19870

--HG--
extra : moz-landing-system : lando
2019-02-21 17:45:17 +00:00
James Teh
8f27acc472 Bug 1529407: Correct MSAA accValue and accRole for role="document". r=MarcoZ
1. When role="document" is (redundantly) used on the body element, still expose the URL via accValue, just like we do for role="application".
2. Expose ROLE_SYSTEM_DOCUMENT for role="document" (rather than the string "document") as per the spec. (Chrome already does this, so I don't expect backwards compat problems with clients.)

Differential Revision: https://phabricator.services.mozilla.com/D20582

--HG--
extra : moz-landing-system : lando
2019-02-21 06:48:02 +00:00
Dorel Luca
0c4863aaf0 Backed out changeset ac4f1b5527fd (bug 1525470) for failures in geckoview in org.mozilla.geckoview.test.AccessibilityTest.testCheckbox. CLOSED TREE 2019-02-20 02:53:14 +02:00
Eitan Isaacson
2ba937125b Bug 1525470 - Include description in accessible hints. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D19870

--HG--
extra : moz-landing-system : lando
2019-02-19 18:56:30 +00:00