Commit Graph

1327 Commits

Author SHA1 Message Date
Jim Blandy
7e20285e70 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Benoit Jacob
6cbcf7b515 Bug 1028588 - Fix dangerous public destructors in uriloader - r=smaug 2014-06-23 14:49:09 -04:00
Dave Hylands
edc2be9cf4 Bug 986331 - Enable .3g2 file extension to be recognized as 3gpp video. r=cajbir 2014-06-05 14:22:15 -07:00
Robert O'Callahan
2a92625af7 Bug 1015664. Part 2: Remove some NS_HIDDEN usage. r=bsmedberg 2014-06-03 00:08:24 +12:00
Robert O'Callahan
cbb8fdebfc Bug 1015664. Part 1: Remove NS_HIDDEN_() usage. r=bsmedberg 2014-06-03 00:08:21 +12:00
Monica Chew
aabd897512 Bug 1011799: Integrate nsIRedirectChannel redirects into application reputation check 2014-05-28 16:06:21 -07:00
Neil Rashbrook
ef8d375d0b Bug 869836 - Part 9a: Use AssignLiteral(MOZ_UTF16(...)) instead of Assign(NS_LITERAL_STRING(...)). r=ehsan
Relading with correct bug number so DONTBUILD.

--HG--
extra : amend_source : 6e05de7729c27761564124212b7d4cbe3318e482
2014-05-26 21:54:10 +03:00
Birunthan Mohanathas
7ed88d413a Backout 8b8bbe7aa1cc due to wrong bug number 2014-05-27 14:42:13 +03:00
Neil Rashbrook
71828ecc1c Bug 995730 - Part 9a: Use AssignLiteral(MOZ_UTF16(...)) instead of Assign(NS_LITERAL_STRING(...)). r=ehsan
--HG--
extra : rebase_source : d2d3d611c06a2a7ec930fb11576d7c8335c0a6e2
2014-05-26 21:54:10 +03:00
Birunthan Mohanathas
952b834c76 Bug 869836 - Part 9: Use AssignLiteral instead of Assign(NS_LITERAL_STRING(...)). r=ehsan 2014-05-22 06:48:52 +03:00
Birunthan Mohanathas
aea8617b92 Bug 869836 - Part 7: Use AppendLiteral instead of Append where possible. r=ehsan 2014-05-22 06:48:51 +03:00
Birunthan Mohanathas
58641805f1 Bug 869836 - Part 6: Use EqualsLiteral instead of Equals where possible. r=ehsan 2014-05-22 06:48:51 +03:00
Birunthan Mohanathas
0e6f3a6562 Bug 869836 - Part 3: Use Append('c') instead of AppendLiteral("c"). r=ehsan 2014-05-22 06:48:51 +03:00
Birunthan Mohanathas
19bebbc68d Bug 869836 - Part 2: Use AppendLiteral instead of Append(NS_LITERAL_STRING(...)). r=ehsan 2014-05-22 06:48:50 +03:00
Hiroyuki Ikezoe
ba123c375e Bug 984194 - Use do_check_matches to output meaningful failure log. r=sworkman 2014-05-19 19:38:00 -04:00
Ethan Tseng
d3a0791173 Bug 1000340 - Remove obsolete codes to launch video app for RTSP. r=sworkman 2014-05-21 11:08:18 +08:00
Makoto Kato
752e23f084 Bug 1008795 - Remove MOZ_ENABLE_MEEGOTOUCHSHARE. r=romaxa 2014-05-12 20:01:04 +09:00
Neil Rashbrook
5b3f3e053a Bug 514280 Only use nsCOMPtr for interfaces r=bsmedberg 2014-05-11 10:47:11 +01:00
Neil Rashbrook
fac8c73779 Backout of bug 514280 changeset c738f7348dea for build failure on a CLOSED TREE 2014-05-08 20:35:09 +01:00
Neil Rashbrook
5b1f7b4a77 Bug 514280 Only use nsCOMPtr for interfaces r=bsmedberg 2014-05-08 20:08:38 +01:00
Birunthan Mohanathas
5f1fde8824 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
James Gilbertson
e568288872 Bug 757927 - Return the result of loadUriInternal instead of always returning NS_OK. r=wesj, r=blassey 2014-04-18 22:00:00 -04:00
Brad Lassey
2c199039f5 bug 962658 - test_badMimeType.html | Assertion count 6 is greater than expected range 0-0 assertions. on Android 4.0 Debug r=gbrown
--HG--
extra : rebase_source : e601fa6f2ed385a28bb25550c4a13aa63f5a452b
2014-04-11 00:33:47 -04:00
Ghislain 'Aus' Lacroix
45b6f0b459 Bug 981539 - Ensure there is always a transfer object instance available in nsExternalAppHandler::OnSaveComplete for e10s. r=bz 2014-04-04 08:32:07 -07:00
Masayuki Nakano
d42c98a423 Bug 990855 part.2 Remove dom/events from local includes of moz.build files r=smaug 2014-04-03 13:18:38 +09:00
snigdha
9cc482da68 Bug 798033 - Headers should generally not do "using namespace" at file scope. r=jib, r=jmathies, r=rjesup, r=ekr, r=ncameron, r=blassey 2014-04-01 08:29:25 -04:00
Ghislain 'Aus' Lacroix
85bbd9301e Bug 982006 - Make GetDownloadDirectory return error for both SD card missing and SD card busy. r=bz 2014-03-31 12:10:44 -07:00
Ritesh Khadgaray
abbc738751 Bug 947868 - Fix nsMIMEInfoUnix::GetHasDefaultHandler to properly handle the protocol scheme. r=karlt 2014-03-24 08:57:39 -04:00
Ghislain 'Aus' Lacroix
d8e84e5a6d Bug 960749 - Improve error messages when < and > are used in filenames. r=bsmedberg
* Unify OS_FILE_ILLEGAL_CHARACTERS
* Provide KNOWN_PATH_SEPARATORS in addition to FILE_PATH_SEPARATOR.
* Update nsExternalAppHandler to use KNOWN_PATH_SEPARATORS instead of
  FILE_PATH_SEPARATOR when removing path separators.
* Fix DownloadsIPC.jsm when compiling with MOZ_DEBUG (would throw on undefined download.id).
* Add test for stripping out illegal characters when downloading.
2014-03-20 14:05:40 -07:00
Nathan Froyd
73447b07b9 Bug 984466 - change CallQueryInterface to assert in cases of trivial conversions; r=ehsan 2014-03-17 13:00:17 -04:00
Andrew McCreight
a6896f5162 Bug 983993, part 2 - Remove unused hash table arguments from the Unix nsOSHelperAppService. 2014-03-18 14:25:39 -07:00
Andrew McCreight
32e5aaa404 Bug 983993, part 1 - Remove trailing whitespace from nsOSHelperAppService. 2014-03-18 14:25:39 -07:00
Neil Rashbrook
db90ab0285 Bug 514280 Remove GetIID r=bsmedberg
--HG--
extra : rebase_source : b913300be047e87c24fb95f7bd17793ebd2c5995
2014-03-18 00:23:11 +00:00
Wes Kocher
c879b47079 Backed out 2 changesets (bug 514280) for OSX build bustage on a CLOSED TREE
Backed out changeset 2a015b45d808 (bug 514280)
Backed out changeset a01f97c1ed02 (bug 514280)
2014-03-17 15:19:53 -07:00
Neil Rashbrook
af909242bc Bug 514280 Remove GetIID r=bsmedberg
--HG--
extra : rebase_source : 179d6cd1cfb272ca258b0bc64225b27252c9ffbe
2014-03-17 19:07:46 +00:00
Kyle Huey
fe6c4e28d6 Bug 967364: Rename already_AddRefed::get to take. r=bsmedberg 2014-03-15 12:00:15 -07:00
Bill McCloskey
fd05f3eb04 Bug 982828 - [e10s] Disable mochitest-plain tests that don't pass in e10s (r=ted) 2014-03-13 21:38:19 -07:00
Wes Kocher
3b83e5bb22 Backed out changeset 88425ad0f06a (bug 982828) for introducing various mochitest-5 failures on a CLOSED TREE
* * *
Backed out changeset 94f9ebdc6662 (bug 982828)
2014-03-13 19:41:21 -07:00
Bill McCloskey
e784b5aef6 Bug 982828 - [e10s] Disable mochitest-plain tests that don't pass in e10s (r=ted) 2014-03-13 15:41:41 -07:00
Bill McCloskey
006786a6b4 Backed out changeset d6261f65070a 2014-03-13 15:52:27 -07:00
Bill McCloskey
ed100f425c Bug 982828 - [e10s] Disable mochitest-plain tests that don't pass in e10s (r=ted) 2014-03-13 15:41:41 -07:00
Vaibhav Agarwal
c75ff964a1 Bug 971132 - B2G mochitests should use the new manifest format for runtests; r=jmaher 2014-03-13 10:40:10 -04:00
Ehsan Akhgari
f23b2e398b Revert the debugging patches for bug 968200
--HG--
extra : rebase_source : 86523689a0d105fae8ddb2fea426bd02bfdcfe28
2014-03-12 09:51:00 -04:00
Reuben Morais
ec8881744e Bug 946239 - Follow up, address review comment. 2014-03-11 19:43:43 -03:00
Reuben Morais
86adb61852 Bug 946239 - Divert download channels to the parent process. r=bz 2014-03-11 19:41:48 -03:00
Ghislain 'Aus' Lacroix
450921d60c Bug 949991 - [Download Manager] Nothing happens if you try to download a file while the device is connected as USB. r=bz 2014-03-06 12:42:07 -08:00
Simon Montagu
755000e10d Use the new ReplaceChars with char16_t array. Bug 979556, r=bsmedberg 2014-03-05 21:04:36 +02:00
Ryan VanderMeulen
0d7b59001e Backed out changeset 6f05267b4afc (bug 798033) for Android bustage. 2014-03-05 09:55:52 -05:00
snigdha
a441998156 Bug 798033 - Headers should generally not do "using namespace" at file scope. r=jib, r=jmathies, r=rjesup, r=ekr, r=ncameron, r=blassey 2014-03-05 08:47:45 -05:00
Ryan VanderMeulen
0dc3c5e22c Merge m-c to inbound. 2014-02-25 15:28:35 -05:00