Commit Graph

15386 Commits

Author SHA1 Message Date
Nicolas Chevobbe
bc581a4d5e Bug 1534927 - Create warningGroup outside of console.group. r=Honza.
With this patch, we always create warningGroups outside of the outermost
console.group the first warning message could be in.
This is done because we don't want a warningGroup to be burried in a console.group,
or worse, in a console.groupCollapsed, where it wouldn't be visible at all.

The messages reducer is modified to do that, and a test is added
to ensure all the group interactions work as expected.

Differential Revision: https://phabricator.services.mozilla.com/D25910

--HG--
extra : moz-landing-system : lando
2019-04-09 14:05:04 +00:00
Cosmin Sabou
a0d1e27a85 Backed out 3 changesets (bug 1539344) for devtools failures on browser_toolbox_target.js. CLOSED TREE
Backed out changeset 878f78400ed7 (bug 1539344)
Backed out changeset 8b3d1e3ae296 (bug 1539344)
Backed out changeset 29b64aed3474 (bug 1539344)
2019-04-09 14:03:07 +03:00
Alexandre Poirot
24425de294 Bug 1540694 - Removed scopedCuImport usages. r=jdescottes
ChromeUtils.import no longer pollute the global scope,
so we can switch to it and remove this ancient helper.

Depends on D26078

Differential Revision: https://phabricator.services.mozilla.com/D26079

--HG--
extra : moz-landing-system : lando
2019-04-09 08:44:03 +00:00
Alexandre Poirot
953f28d1a8 Bug 1540694 - Fix DEBUG_DEVTOOLS_ALLOCATIONS now that DevTools share the unique system compartment. r=jdescottes
In bug 1517210, DevTools started sharing the same compartment than JSMs.
So we can no longer use a Debugger instance bound to jsdebugger.jsm as it
would run in the same compartment than DevTools code we want to inspect
from the allocation tracker.
Instead, we instantiate the Debugger from a custom Sandbox loaded
in a unique and distinct compartment.

Depends on D26077

Differential Revision: https://phabricator.services.mozilla.com/D26078

--HG--
extra : moz-landing-system : lando
2019-04-09 08:41:19 +00:00
Alexandre Poirot
9a96c419f3 Bug 1540694 - Remove unecessary import-globals-from. r=jdescottes
Now that there is a shared head.js, the import-globals-from is done from there.

Differential Revision: https://phabricator.services.mozilla.com/D26077

--HG--
extra : moz-landing-system : lando
2019-04-09 08:41:17 +00:00
Noemi Erli
4d1c376ac0 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-04-09 13:00:14 +03:00
Noemi Erli
dd7e27f4a8 Merge inbound to mozilla-central. a=merge 2019-04-09 12:55:19 +03:00
Belén Albeza
a0613f0489 Bug 1539344 - Part 3: add Jest tests to check display of debug target type info r=jdescottes,Ola
Differential Revision: https://phabricator.services.mozilla.com/D25376

--HG--
extra : moz-landing-system : lando
2019-04-09 09:50:49 +00:00
Razvan Maries
a3e3bcf2fe Merge mozilla-central to mozilla-inbound. a=merge on a CLOSED TREE 2019-04-09 06:43:36 +03:00
Andrew McCreight
1b901ff2db Bug 1542024 - Eliminate nsXPCWrappedJSClass by moving its methods into nsXPCWrappedJS. r=bzbarsky
I changed DelegatedQueryInterface and CallMethod to be non-static
methods rather than taking an explicit |self| parameter.

There is already a method nsXPCWrappedJS::CallMethod() with the same
signature, but it is a shim, so I inlined it into the version in
XPCWrappedJSClass.cpp.

I also fixed up a few comments that mention nsXPCWrappedJSClass.

The new comments starting with "We now need to enter the realm" were
written by Boris, and are a little more explicit so they are easier to
understand.

I renamed DebugDump() to DebugDumpInterfaceInfo() to be more
informative.

Differential Revision: https://phabricator.services.mozilla.com/D26422

--HG--
extra : moz-landing-system : lando
2019-04-08 21:39:27 +00:00
Belén Albeza
f142e50fd7 Bug 1539344 - Part 2: display target type icon in DebugTargetInfo component r=jdescottes,Ola
Differential Revision: https://phabricator.services.mozilla.com/D25375

--HG--
extra : moz-landing-system : lando
2019-04-08 12:52:03 +00:00
Belén Albeza
5b663e7187 Bug 1539344 - Part 1: share constants between about:debugging and DebugTargetInfo r=jdescottes,Ola
Differential Revision: https://phabricator.services.mozilla.com/D25374

--HG--
extra : moz-landing-system : lando
2019-04-08 09:18:58 +00:00
Brian Hackett
ffa20b4d14 Bug 1542659 Part 3 - Avoid throwing when enumerating proxy properties, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D26453

--HG--
extra : rebase_source : 136c986b58610ac72603a4016de98cef149dff1b
2019-04-07 16:02:42 -10:00
Brian Hackett
e3e30e99e4 Bug 1542659 Part 2 - Remove unnecessary ReplayInspector instrumentation, r=pbro.
Differential Revision: https://phabricator.services.mozilla.com/D26452

--HG--
extra : rebase_source : 596c0dbe2f29ab74d1253aeeb0e73e666a69c34a
2019-04-07 16:02:04 -10:00
Brian Hackett
7154d679ab Bug 1542659 Part 1 - Hook require() when replaying, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D26451

--HG--
extra : rebase_source : 6697485b1dc098d6b276957953b537bfdcfb1109
2019-04-07 16:00:49 -10:00
Ciure Andrei
9df9f73d71 Backed out changeset 8de77b46cd56 (bug 1529867) to remove the disable for browser_dbg-windowless-workers.js a=backout
--HG--
extra : histedit_source : d960a236d71f480dfee881e02d5c629d96170c74
2019-04-08 21:53:27 +03:00
Nicolas Chevobbe
c25d4ff00b Bug 1542721 - Fix console mocha tests. r=bgrins.
Adding a mock for devtools/shared/layout/utils fixes the test.

Differential Revision: https://phabricator.services.mozilla.com/D26562

--HG--
extra : moz-landing-system : lando
2019-04-08 16:44:03 +00:00
Dorel Luca
ca1e4e263d Backed out changeset 4fef2150bef9 (bug 1534984) for DevTools Failures in devtools/client/responsive.html/test/browser/browser_toolbox_swap_browsers.js. CLOSED TREE 2019-04-08 19:23:02 +03:00
Belén Albeza
d3d11b05a5 Bug 1505368 - Show error page in about:devtools-toolbox when target is destroyed r=jdescottes,daisuke
Differential Revision: https://phabricator.services.mozilla.com/D20315

--HG--
extra : moz-landing-system : lando
2019-04-08 15:41:38 +00:00
Micah Tigley
a17d89a9d3 Bug 1534984 - Add a button for toggling print styles simulation in the Rule View toolbar r=gl
Differential Revision: https://phabricator.services.mozilla.com/D25142

--HG--
extra : moz-landing-system : lando
2019-04-08 14:58:57 +00:00
Micah Tigley
270557bf86 Bug 1534984 - Add a button for toggling print styles simulation in the Rule View toolbar r=gl
Differential Revision: https://phabricator.services.mozilla.com/D25142

--HG--
extra : moz-landing-system : lando
2019-04-08 20:22:12 +00:00
Hemakshi Sachdev
6c85a24a58 Bug 1538171 - Remove the style-editor-options-popup XUL menupopup from the StyleEditor and use the JS Menu API instead. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D26075

--HG--
extra : moz-landing-system : lando
2019-04-08 13:16:46 +00:00
Andreea Pavel
4ebc473f0c Bug 1529867 - Disable browser_dbg-windowless-workers.js on windows ccov, mac !debug and linux for frequent failures. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D25511

--HG--
extra : moz-landing-system : lando
2019-04-08 13:19:44 +00:00
Dorel Luca
762bb29429 Merge mozilla-central to autoland 2019-04-08 13:49:06 +03:00
Dorel Luca
1be446680f Merge mozilla-inbound to mozilla-central. a=merge 2019-04-08 13:45:29 +03:00
Julian Descottes
b6dc05b08d Bug 1539071 - Wait for toolbox destroy to finish before reloading toolbox tab;r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D26010

--HG--
extra : moz-landing-system : lando
2019-04-08 09:42:24 +00:00
Mellina Yonashiro
16ecae45e0 Bug 1538108 - Hide the computed expander and shorthand overridden list in the new rules view when the computed values are empty r=gl 2019-04-08 01:27:47 -04:00
Logan Smyth
57e7f884ac Bug 1540803 - Fix flakey test by waiting for source to fully load. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D26260

--HG--
extra : moz-landing-system : lando
2019-04-07 13:18:51 +00:00
Ciure Andrei
3ff6ff6d6f Backed out changeset 5937ad352b2d (bug 1542024) for perma failing 406106-1.html CLOSED TREE 2019-04-09 00:12:32 +03:00
Razvan Maries
d497a06e29 Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2019-04-08 23:59:57 +03:00
Andrew McCreight
ccc11f67db Bug 1542024 - Eliminate nsXPCWrappedJSClass by moving its methods into nsXPCWrappedJS. r=bzbarsky
I changed DelegatedQueryInterface and CallMethod to be non-static
methods rather than taking an explicit |self| parameter.

I did a tiny bit of cleanup in the nsIXPConnectJSObjectHolder case of
DelegatedQueryInterface().

There is already a method nsXPCWrappedJS::CallMethod() with the same
signature, but it is a shim, so I inlined it into the version in
XPCWrappedJSClass.cpp.

I also fixed up a few comments that mention nsXPCWrappedJSClass.

The new comments starting with "We now need to enter the realm" were
written by Boris, and are a little more explicit so they are easier to
understand.

I renamed DebugDump() to DebugDumpInterfaceInfo() to be more
informative.

Differential Revision: https://phabricator.services.mozilla.com/D26422

--HG--
extra : moz-landing-system : lando
2019-04-08 19:44:45 +00:00
Brian Hackett
12b3f158bd Bug 1497393 Part 9 - Add test for inspector support while replaying.
--HG--
extra : rebase_source : 19577fa7a3fab74be208e6805d39fab737e88cc1
extra : histedit_source : 9daa438bf16c0e3fbfc6d3d37b322421b1b0f5b2
2019-03-09 16:46:39 -10:00
Brian Hackett
09aed40948 Bug 1497393 Part 8 - Client side changes for inspector support while replaying, r=pbro.
Differential Revision: https://phabricator.services.mozilla.com/D22864

--HG--
extra : rebase_source : e553f8caf0d105c2692253cdebe8c5f2ae6402e4
extra : histedit_source : e781b3fd08134a521205c7b6ab829692ecd6a06a
2019-03-09 16:46:16 -10:00
Brian Hackett
f4af857cef Bug 1497393 Part 7 - Server side changes for inspector support while replaying, r=pbro.
Differential Revision: https://phabricator.services.mozilla.com/D22863

--HG--
extra : rebase_source : 1069a8534dd79e1d2cf309c9d3f3c27079077087
extra : histedit_source : 1a750a022d46da836181f913d012081ea608da7f
2019-03-09 16:45:50 -10:00
Brian Hackett
c27709d468 Bug 1497393 Part 6 - Emit event when the debugger pauses or resumes, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D22862

--HG--
extra : rebase_source : e3f7f651439798c139f9e89834d071be67bca493
extra : histedit_source : 8c53059c88a67a2eba76bd8a1e01b58645712d50
2019-03-09 16:42:20 -10:00
Brian Hackett
eefdeac0e8 Bug 1497393 Part 5 - Add ReplayInspector module for accessing objects in a replaying process, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D22861

--HG--
extra : rebase_source : 63c20073bb6e76d882ed0719e550685b2874a28e
2019-03-09 16:41:32 -10:00
Brian Hackett
e96d35aa99 Bug 1497393 Part 4 - Suppress event handling at the usual times in server when replaying, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D22860

--HG--
extra : rebase_source : f2daf3cf81931052e80a50d4f9057808d335328c
2019-03-09 16:40:40 -10:00
Brian Hackett
7d26be7959 Bug 1497393 Part 3 - Remove ReplayDebuggerObject.global, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D22859

--HG--
extra : rebase_source : e5e63bf1da796a3131ed1948c5b9f38f316bc2df
2019-03-09 16:39:02 -10:00
Brian Hackett
f5672e6b59 Bug 1497393 Part 2 - Tweak definition of target.isReplayEnabled(), r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D22858

--HG--
extra : rebase_source : a8d0aeaf08920454dd27084c3e1663719d0116bf
2019-03-09 16:38:34 -10:00
Brian Hackett
0e51aaf966 Bug 1497393 Part 1 - Add isReplaying global to server bindings, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D22857

--HG--
extra : rebase_source : 14b0daad9f6ef4f372b44e0081bd5ff9b1d270cf
2019-03-09 16:37:20 -10:00
Brian Hackett
a278b7606d Bug 1535362 - Add a Context object for rejecting out of date client operations, r=loganfsmyth.
--HG--
extra : rebase_source : 157eceedb2ff8df3b4217d3821d98ed2a9f6dc3f
2019-04-05 16:49:33 -10:00
Andreea Pavel
4146c75e78 Merge mozilla-inbound to mozilla-central. a=merge 2019-04-06 13:58:33 +03:00
shindli
bd30279387 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-04-06 00:53:02 +03:00
Ehsan Akhgari
9d957462b6 Bug 1533584 - Part 2: Make sure browser_storage_listings.js does not depend on the value of the privacy.documentCookies.maxage pref
Landed on a CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D26354

--HG--
extra : moz-landing-system : lando
2019-04-05 18:16:06 +00:00
Logan Smyth
a3ee4f41cb Bug 1541258 - Handle the generated source not being found to avoid flakiness. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D26342

--HG--
extra : moz-landing-system : lando
2019-04-05 18:35:45 +00:00
David Walsh
76f00e70d7 Bug 1541563 - Sync 131 - Align watch expressions and scopes pane r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D25995

--HG--
extra : moz-landing-system : lando
2019-04-05 17:33:29 +00:00
David Walsh
1578579b3e Bug 1541563 - Sync 131 - Fix string linkification greediness r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D25994

--HG--
extra : moz-landing-system : lando
2019-04-05 17:33:22 +00:00
David Walsh
c8835a2c67 Bug 1541563 - Sync 131 - Render href attribute in String rep URLs. r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D25993

--HG--
extra : moz-landing-system : lando
2019-04-05 17:33:20 +00:00
David Walsh
32b408dd23 Bug 1541563 - Sync 131 - Upgrade launchpad r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D25992

--HG--
extra : moz-landing-system : lando
2019-04-05 17:33:13 +00:00
David Walsh
2574a8e5dc Bug 1541563 - Sync 131 - Fix sourcemaps test click position after SVG update r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D25991

--HG--
extra : moz-landing-system : lando
2019-04-05 17:33:08 +00:00