Commit Graph

1678 Commits

Author SHA1 Message Date
Nathan Froyd
2ebbd09068 Bug 1320752 - remove mozilla/Function.h; r=gerald
We have std::function available now, which is likely to be somewhat more
efficient.
2016-11-28 11:03:53 -05:00
Nicholas Nethercote
7e1a8cf56c Bug 1315138 - gtestify storage/test/*.cpp. r=mak,erahm.
This change is mostly straightforward, except for the following.

- It removes all the printing from the do_check_* macros because gtest macros
  do appropriate printing.

- test_StatementCache.cpp needs some special gtest magic for the type
  parameterization.

- It merges the four tests in test_unlock_notify.cpp because they rely on being
  executed in order, and so aren't independent.

- storage_test_harness_tail.h is no longer necessary because gtest provides the
  test looping functionality.

- It uses #include and the preprocessor to remove the duplication between
  test_deadlock_detector.cpp and xpcom/tests/DeadlockDetector.cpp.

- It makes the test in test_service_init_background_thread.cpp a death test to
  force it to be the first storage gtest, because it fails otherwise.

- It adds code to undo the SQLite mutex hooking as necessary, so that tests
  don't interfere with each other.

- It de-virtualizes Spinner's destructor (as identified in bug 1318282).

--HG--
rename : storage/test/storage_test_harness.h => storage/test/gtest/storage_test_harness.h
rename : storage/test/test_AsXXX_helpers.cpp => storage/test/gtest/test_AsXXX_helpers.cpp
rename : storage/test/test_StatementCache.cpp => storage/test/gtest/test_StatementCache.cpp
rename : storage/test/test_asyncStatementExecution_transaction.cpp => storage/test/gtest/test_asyncStatementExecution_transaction.cpp
rename : storage/test/test_async_callbacks_with_spun_event_loops.cpp => storage/test/gtest/test_async_callbacks_with_spun_event_loops.cpp
rename : storage/test/test_binding_params.cpp => storage/test/gtest/test_binding_params.cpp
rename : storage/test/test_deadlock_detector.cpp => storage/test/gtest/test_deadlock_detector.cpp
rename : storage/test/test_file_perms.cpp => storage/test/gtest/test_file_perms.cpp
rename : storage/test/test_mutex.cpp => storage/test/gtest/test_mutex.cpp
rename : storage/test/test_service_init_background_thread.cpp => storage/test/gtest/test_service_init_background_thread.cpp
rename : storage/test/test_statement_scoper.cpp => storage/test/gtest/test_statement_scoper.cpp
rename : storage/test/test_transaction_helper.cpp => storage/test/gtest/test_transaction_helper.cpp
rename : storage/test/test_true_async.cpp => storage/test/gtest/test_true_async.cpp
rename : storage/test/test_unlock_notify.cpp => storage/test/gtest/test_unlock_notify.cpp
extra : rebase_source : dbb695c112564efa1945116be1a8435988982e74
2016-11-11 09:59:23 +11:00
Masatoshi Kimura
9c32f727eb Bug 1318857 - Unhide nsTSubstring_CharT::StripChars in nsTString_CharT. r=froydnj
MozReview-Commit-ID: CyQhH2y9lbm

--HG--
extra : rebase_source : d733decec808e7a74deefe149672ec4bdbc7f3f1
2016-11-20 00:53:37 +09:00
Ryan VanderMeulen
c2e0dbedb5 Merge m-c to inbound. a=merge 2016-11-18 15:48:29 -05:00
Ehsan Akhgari
5914626c41 Bug 1318678 - Use libmfbt instead of libmozglue 2016-11-18 13:11:00 -05:00
Ehsan Akhgari
34114d2517 Bug 1318678 - Fix linking TestBlockingProgram on OSX after bug 1317638 landed 2016-11-18 13:03:18 -05:00
Andi-Bogdan Postelnicu
a6f9209af4 Bug 1317954 - Use C++11's override and remove virtual where applicable in xpcom/. r=froydnj
MozReview-Commit-ID: 2XXoxNHYCKm

--HG--
extra : rebase_source : f4a144b706aa467a1cf713db57adcbefa40b8b96
2016-11-16 14:27:07 +02:00
Andi-Bogdan Postelnicu
be53fc59dd Bug 1317954 - Replace string literals containing escaped characters with raw string literals in xpcom/. r=froydnj
MozReview-Commit-ID: INLv2bNrLYX

--HG--
extra : rebase_source : 99d516e153b2dcb5185b30ee6072c4e6575517b7
2016-11-16 14:26:03 +02:00
Andi-Bogdan Postelnicu
60bb054c02 Bug 1317954 - Replace default bodies of special member functions with = default; in xpcom/. r=froydnj
MozReview-Commit-ID: 5GXchMr0VvV

--HG--
extra : rebase_source : ac32605ef643f67ffd0f0894f31eed8f01804e2f
2016-11-16 14:25:31 +02:00
Andi-Bogdan Postelnicu
42effb5bbf Bug 1317954 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in xpcom/. r=froydnj
MozReview-Commit-ID: EZZrYF1W81B

--HG--
extra : rebase_source : 30eea607d07ac819a0e55a2c4b0f8c359c156705
2016-11-16 14:24:59 +02:00
Andi-Bogdan Postelnicu
d7f83a7ea6 Bug 1317954 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in xpcom/. r=froydnj
MozReview-Commit-ID: 9mKXvXyYa6U

--HG--
extra : rebase_source : 55f74f93829b52b2c347a62520a79ab867adca35
2016-11-16 14:24:21 +02:00
James Cheng
c1ca1ea63f Bug 1317638 - Fix build fail in TestBlockingProcess.cpp if enabling warnings as errors. r=erahm
MozReview-Commit-ID: AChdrrdhf4Z

--HG--
extra : rebase_source : 3aab53ea08a0c6699f963b32e1f896cb13d02359
2016-11-15 16:33:59 +08:00
Benjamin Smedberg
58606875d8 Bug 1314955 part B - Remove the tests for binary-component which is no longer supported. r=froydnj
MozReview-Commit-ID: G7MATc8AGt1

--HG--
extra : rebase_source : f5f0886aab2b6981a12d9c32b120e65a2d022bc8
extra : source : a99c6ce96b6f25a4935bc41fe32841c9b94f1546
2016-10-26 11:34:32 -04:00
Iris Hsiao
66ac15df36 Backed out changeset a99c6ce96b6f (bug 1314955) 2016-11-16 15:19:42 +08:00
Benjamin Smedberg
89ac51de41 Bug 1314955 part B - Remove the tests for binary-component which is no longer supported. r=froydnj
MozReview-Commit-ID: G7MATc8AGt1

--HG--
extra : rebase_source : e83168f601f5dde167227ed5df502be54ba252fc
2016-10-26 11:34:32 -04:00
Carsten "Tomcat" Book
8cfa5253e8 merge mozilla-inbound to mozilla-central a=merge 2016-11-15 12:26:41 +01:00
Michelangelo De Simone
47eb98d13a Bug 1317451 - ASSERT_DEATH replaced by ASSERT_DEATH_IF_SUPPORTED. r=froydnj
MozReview-Commit-ID: Auqwd0NlM17

--HG--
extra : rebase_source : 67a86926e1ddce38ec24f651c2cc79c6a872bc93
2016-11-13 11:12:49 -08:00
Eric Rahm
fa2367d041 Bug 1316732 - Remove TestMinStringAPI. r=bsmedberg
This GeckoSimpleProgram is not run and tests a feature we're removing.

MozReview-Commit-ID: FWZdQTZchf3
2016-11-14 11:33:47 -08:00
Eric Rahm
3fa6be1ab6 Bug 1316904 - Convert windows XPCOM tests to gtest. r=froydnj
This converts TestNtPathToDosPath and TestCOM to gtests.

MozReview-Commit-ID: EeNwvsj4cAs
2016-11-11 12:02:52 -08:00
Eric Rahm
61de62099e Bug 1316193 - Fix unified bustage. r=me ON A CLOSED TREE
MozReview-Commit-ID: 4ylYi9LkwJm
2016-11-10 13:23:21 -08:00
Eric Rahm
a79e2262d5 Bug 1316437 - Convert TestSTLWrappers to a gtest. r=bsmedberg
MozReview-Commit-ID: HRmnWvxyNP

--HG--
rename : xpcom/tests/TestSTLWrappers.cpp => xpcom/tests/gtest/TestSTLWrappers.cpp
2016-11-10 13:04:06 -08:00
Eric Rahm
59b65be14f Bug 1316436 - Remove NSPR dependency from TestBlockingProcess.cpp. r=bsmedberg
MozReview-Commit-ID: y1NuXrwEr9
2016-11-10 13:02:03 -08:00
Eric Rahm
07c557837c Bug 1316424 - Convert XPCOM test TestBase64 to a gtest. r=bsmedberg
MozReview-Commit-ID: 89kKMhkzwXK

--HG--
rename : xpcom/tests/TestBase64.cpp => xpcom/tests/gtest/TestBase64.cpp
2016-11-10 13:01:01 -08:00
Eric Rahm
1f55e2d522 Bug 1316195 - Remove XPCOM test TestRegistrationOrder. r=bsmedberg
MozReview-Commit-ID: 2CLSKxNukVj
2016-11-10 12:59:56 -08:00
Eric Rahm
59373784d1 Bug 1316194 - Remove unused XPCOM test TestINIParser. r=bsmedberg
MozReview-Commit-ID: 2gQgR6V3kee
2016-11-10 12:59:20 -08:00
Eric Rahm
bf24d0b9f2 Bug 1316191 - Convert XPCOM test TestRacingServiceManager to a gtest. r=bsmedberg
MozReview-Commit-ID: QppJYYZrtT

--HG--
rename : xpcom/tests/TestRacingServiceManager.cpp => xpcom/tests/gtest/TestRacingServiceManager.cpp
2016-11-10 12:58:09 -08:00
Eric Rahm
07d602bad9 Bug 1316193 - Convert XPCOM test TestThreadPoolListener to a gtest. r=bsmedberg
MozReview-Commit-ID: JiyYTGGuKJo

--HG--
rename : xpcom/tests/TestThreadPoolListener.cpp => xpcom/tests/gtest/TestThreadPoolListener.cpp
2016-11-10 12:55:36 -08:00
Eric Rahm
416c229a90 Bug 1316189 - Convert XPCOM test TestCallTemplate to a gtest. r=bsmedberg
MozReview-Commit-ID: FGCmfjyKNa1

--HG--
rename : xpcom/tests/TestCallTemplates.cpp => xpcom/tests/gtest/TestCallTemplates.cpp
2016-11-10 12:50:43 -08:00
Eric Rahm
a94c02e198 Bug 1313489 - Part 2: Convert DeadlockDetectorScalability to a gtest. r=froydnj
This converts the tests to gtests. Most of them are just runtime tests and just
hava dummy assertion that everything ran. One test remains disabled, although
it's still built-in. You can run the disabled test with the following command:

> GTEST_ALSO_RUN_DISABLED_TESTS=1 ./mach gtest DeadlockDetectorScalability.*

MozReview-Commit-ID: 57rxjiZKjQ6

--HG--
rename : xpcom/tests/TestDeadlockDetectorScalability.cpp => xpcom/tests/gtest/TestDeadlockDetectorScalability.cpp
2016-11-10 12:47:48 -08:00
Eric Rahm
bdcf82a40b Bug 1313489 - Part 1: Remove dead code. r=froydnj
MozReview-Commit-ID: HSS4Sf7O1I6
2016-11-10 12:47:47 -08:00
Eric Rahm
64b21983e5 Bug 1313488 - Part 1: Convert XPCOM test TestDeadlockDetector to a gtest. r=froydnj
This converts TestDeadlockDetector to a gtest. The logic for spawning off
subprocesses is replaced with gtest's built-in death tests. On linux this will
clone() the process and assert that the child process generates the appropriate
assertion message. On OSX it will use fork(). In theory this should work on
Windows as well buy spawning a new process but this test currently disabled
there.

MozReview-Commit-ID: 9Sl0hHBVGT3

--HG--
rename : xpcom/tests/TestDeadlockDetector.cpp => xpcom/tests/gtest/TestDeadlockDetector.cpp
2016-11-10 12:47:23 -08:00
Eric Rahm
54a94346b1 Bug 1313488 - Part 0: Adding missing includes. r=froydnj
Add missing includes to fix unified builds.

MozReview-Commit-ID: 3xkozGdrdBf
2016-11-10 12:47:21 -08:00
Nathan Froyd
23c8029288 Bug 1316127 - add tests for edge cases for nsUnescapeCount; r=erahm
There are no tests for this piece of code otherwise, and it'd be good to
have cases for non-escape sequences of various flavors.
2016-11-10 23:11:31 -05:00
Sebastian Hengst
5df0c97c52 Backed out changeset d769f46c4248 (bug 1313488) for leak in Linux x64 debug. r=backout 2016-11-09 21:10:47 +01:00
Sebastian Hengst
1e466eed57 Backed out changeset deabf7bc6526 (bug 1313488)
--HG--
rename : xpcom/tests/gtest/TestDeadlockDetector.cpp => xpcom/tests/TestDeadlockDetector.cpp
2016-11-09 21:10:10 +01:00
Sebastian Hengst
e4f364202e Backed out changeset 7b0acef284ad (bug 1313489) 2016-11-09 21:10:06 +01:00
Sebastian Hengst
9341b600b5 Backed out changeset 54098e53a584 (bug 1313489)
--HG--
rename : xpcom/tests/gtest/TestDeadlockDetectorScalability.cpp => xpcom/tests/TestDeadlockDetectorScalability.cpp
2016-11-09 21:10:02 +01:00
Eric Rahm
348457dcac Bug 1315830 - Remove unused nsIFileEnumerator program. r=froydnj
This seems to have been added back in 2000 as some sort of ad-hoc nsIFile test.
There is now an actual gtest for nsIFile so this should be safe to remove.

MozReview-Commit-ID: DMeVmBNmf8f
2016-11-09 10:33:17 -08:00
Eric Rahm
e7e98cc775 Bug 1313489 - Part 2: Convert DeadlockDetectorScalability to a gtest. r=froydnj
This converts the tests to gtests. Most of them are just runtime tests and just
hava dummy assertion that everything ran. One test remains disabled, although
it's still built-in. You can run the disabled test with the following command:

> GTEST_ALSO_RUN_DISABLED_TESTS=1 ./mach gtest DeadlockDetectorScalability.*

MozReview-Commit-ID: 57rxjiZKjQ6

--HG--
rename : xpcom/tests/TestDeadlockDetectorScalability.cpp => xpcom/tests/gtest/TestDeadlockDetectorScalability.cpp
2016-11-09 10:25:17 -08:00
Eric Rahm
c0f8aff99b Bug 1313489 - Part 1: Remove dead code. r=froydnj
MozReview-Commit-ID: HSS4Sf7O1I6
2016-11-09 10:25:15 -08:00
Eric Rahm
1634281923 Bug 1313488 - Part 1: Convert XPCOM test TestDeadlockDetector to a gtest. r=froydnj
This converts TestDeadlockDetector to a gtest. The logic for spawning off
subprocesses is replaced with gtest's built-in death tests. On linux this will
clone() the process and assert that the child process generates the appropriate
assertion message. On OSX it will use fork(). In theory this should work on
Windows as well buy spawning a new process but this test currently disabled
there.

MozReview-Commit-ID: 9Sl0hHBVGT3

--HG--
rename : xpcom/tests/TestDeadlockDetector.cpp => xpcom/tests/gtest/TestDeadlockDetector.cpp
2016-11-09 10:24:58 -08:00
Eric Rahm
91cddc126f Bug 1313488 - Part 0: Adding missing includes. r=froydnj
Add missing includes to fix unified builds.

MozReview-Commit-ID: 3xkozGdrdBf
2016-11-09 10:24:56 -08:00
Eric Rahm
2faeed6d55 Bug 1313485 - Convert XPCOM test TestJemalloc to a gtest. r=njn
MozReview-Commit-ID: 5yzn8o33Ne5

--HG--
rename : xpcom/tests/TestJemalloc.cpp => memory/gtest/TestJemalloc.cpp
2016-11-09 10:24:22 -08:00
Eric Rahm
502d8d220a Bug 1313484 - Convert XPCOM test TestTimers to a gtest. r=froydnj
MozReview-Commit-ID: 8sH5fbvv9wZ

--HG--
rename : xpcom/tests/TestTimers.cpp => xpcom/tests/gtest/TestTimers.cpp
2016-11-09 10:23:43 -08:00
Eric Rahm
6ee0d39aef Bug 1316184 - Make SimplePrograms that need XUL GeckoSimplePrograms. r=froydnj 2016-11-08 16:15:34 -08:00
Phil Ringnalda
652fc04e1a Backed out 5 changesets (bug 1313489, bug 1313488, bug 1313484) in hopes that OS X will go back to building without complaining about missing symbols in nsIFileEnumerator
Backed out changeset 276b093c968f (bug 1313489)
Backed out changeset 5a062f72097d (bug 1313489)
Backed out changeset dbd9b56b50e7 (bug 1313488)
Backed out changeset 22e770047827 (bug 1313488)
Backed out changeset 6a7831fbca69 (bug 1313484)

MozReview-Commit-ID: KP9gk9o11co

--HG--
rename : xpcom/tests/gtest/TestDeadlockDetector.cpp => xpcom/tests/TestDeadlockDetector.cpp
rename : xpcom/tests/gtest/TestDeadlockDetectorScalability.cpp => xpcom/tests/TestDeadlockDetectorScalability.cpp
rename : xpcom/tests/gtest/TestTimers.cpp => xpcom/tests/TestTimers.cpp
2016-11-07 19:12:13 -08:00
Sebastian Hengst
193fc03fc6 Backed out changeset 1b545e55e42a (bug 1313485) for bustage. r=backout
--HG--
rename : memory/gtest/TestJemalloc.cpp => xpcom/tests/TestJemalloc.cpp
2016-11-07 23:46:09 +01:00
Eric Rahm
3162321eb2 Bug 1313489 - Part 2: Convert DeadlockDetectorScalability to a gtest. r=froydnj
This converts the tests to gtests. Most of them are just runtime tests and just
hava dummy assertion that everything ran. One test remains disabled, although
it's still built-in. You can run the disabled test with the following command:

> GTEST_ALSO_RUN_DISABLED_TESTS=1 ./mach gtest DeadlockDetectorScalability.*

MozReview-Commit-ID: 57rxjiZKjQ6

--HG--
rename : xpcom/tests/TestDeadlockDetectorScalability.cpp => xpcom/tests/gtest/TestDeadlockDetectorScalability.cpp
2016-11-07 14:27:20 -08:00
Eric Rahm
e1ab61c934 Bug 1313489 - Part 1: Remove dead code. r=froydnj
MozReview-Commit-ID: HSS4Sf7O1I6
2016-11-07 14:27:18 -08:00
Eric Rahm
d29d2d6fe0 Bug 1313488 - Part 1: Convert XPCOM test TestDeadlockDetector to a gtest. r=froydnj
This converts TestDeadlockDetector to a gtest. The logic for spawning off
subprocesses is replaced with gtest's built-in death tests. On linux this will
clone() the process and assert that the child process generates the appropriate
assertion message. On OSX it will use fork(). In theory this should work on
Windows as well buy spawning a new process but this test currently disabled
there.

MozReview-Commit-ID: 9Sl0hHBVGT3

--HG--
rename : xpcom/tests/TestDeadlockDetector.cpp => xpcom/tests/gtest/TestDeadlockDetector.cpp
2016-11-07 14:27:04 -08:00