Commit Graph

31 Commits

Author SHA1 Message Date
Nicolas Chevobbe
895226c6fe Bug 1613035 - Set devtools.target-switching.enabled in tests when needed and remove skip/fail-if = fision. r=ochameau.
This patch sets the pref for tests where it's needed (often
when the test navigates from an origin to another).
When possible, the skip-if=fission tag is removed.
For remaining issue, referencing to the bug where we should
re-enable those tests.

Differential Revision: https://phabricator.services.mozilla.com/D61559

--HG--
extra : moz-landing-system : lando
2020-02-13 09:42:27 +00:00
Luca Greco
d961c28763 Bug 1611418 - SourceMapURLService originalPositionFor should return null when sourcemaps are disable via prefs. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D60956

--HG--
extra : moz-landing-system : lando
2020-01-24 13:33:45 +00:00
Nicolas Chevobbe
66887be8da Bug 1589346 - Fix navigation to debugger from console on prettified sources. r=loganfsmyth.
This revert the changes made in Bug 1587839, except the added test.
The safer fix to be uplifted is to only fix the original issue
in the SmartTrace component, where we remove any sourceId we might
have when creating the new mapped frame.

We also modify the browser_dbg-pretty-print-console test to ensure
clicking on a prettified location in the console does open the
debugger with the expected location.

Differential Revision: https://phabricator.services.mozilla.com/D50173

--HG--
extra : moz-landing-system : lando
2019-10-25 12:16:52 +00:00
Daniel Varga
2d8c1c6548 Backed out changeset fac6219649be (bug 1587839) on request by nchevobbe DONTBUILD
--HG--
extra : rebase_source : 7704b8ca8bdaf66bc68d488fd81a824f5bfc6678
2019-10-25 14:56:44 +03:00
Nicolas Chevobbe
28e37b5b09 Bug 1587839 - Fix navigation to debugger from console on prettified sources. r=loganfsmyth.
This revert the changes made in Bug 1587839, except the added test.
The safer fix to be uplifted is to only fix the original issue
in the SmartTrace component, where we remove any sourceId we might
have when creating the new mapped frame.

We also modify the browser_dbg-pretty-print-console test to ensure
clicking on a prettified location in the console does open the
debugger with the expected location.

Differential Revision: https://phabricator.services.mozilla.com/D50173

--HG--
extra : moz-landing-system : lando
2019-10-25 06:21:18 +00:00
Nicolas Chevobbe
3469d5121d Bug 1587839 - Pass the sourceId to sourcemap service subscribe callback. r=loganfsmyth.
The sourceId is then used in the various places where we call the sourcemap service.
A test is added in the console to make sure that we do navigate to the mapped
location in the debugger.

Differential Revision: https://phabricator.services.mozilla.com/D49103

--HG--
extra : moz-landing-system : lando
2019-10-16 00:16:55 +00:00
Alexandre Poirot
52a0e9273a Bug 1565263 - Support target switching for the console. r=nchevobbe,yulia,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D40016

--HG--
extra : moz-landing-system : lando
2019-10-09 08:03:43 +00:00
Alexandre Poirot
baecf18127 Bug 1567726 - Do not request stylesheets front for content processes in the source map service. r=yulia
This actor isn't implemented for processes, but only by browsing context targets.

Differential Revision: https://phabricator.services.mozilla.com/D38905

--HG--
extra : moz-landing-system : lando
2019-07-26 16:54:34 +00:00
yulia
cc00bf541b Bug 1559819 - rename threadClient to threadFront; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D32848

--HG--
rename : devtools/client/debugger/src/actions/tests/helpers/threadClient.js => devtools/client/debugger/src/actions/tests/helpers/threadFront.js
rename : devtools/shared/client/thread-client.js => devtools/shared/fronts/thread.js
extra : moz-landing-system : lando
2019-07-11 09:45:32 +00:00
Victor Porof
f6db0ee557 Bug 1561435 - Format devtools/client/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35884

--HG--
extra : source : 60e4496cf9699dc59f2f4738cb60f87cbdb01e67
2019-07-05 11:24:38 +02:00
Nicolas Chevobbe
e1af9012ee Bug 1501632 - Return an unsubscribe function from SourceMapURLService.prototype.subscribe; r=loganfsmyth.
The SourceMapURLService has a subscribe and an unsubscribe
functions to respectively listen and stop listening for
source map changes on a given location (url + line + column).
The unsubscribe function need to be called with the same
parameters as the subscribe function, which means the consumer
need to keep a reference to the callback.
By making the subscribe function return the unsubscribe function,
this makes things a bit easier.

Differential Revision: https://phabricator.services.mozilla.com/D9784

--HG--
extra : moz-landing-system : lando
2018-10-25 17:15:45 +00:00
Logan Smyth
5053ff0b5a Bug 1500632 - source-map-url-service should trigger subscribers when files matching them are detected. r=tromey
Differential Revision: https://phabricator.services.mozilla.com/D9433

--HG--
extra : moz-landing-system : lando
2018-10-24 12:55:01 +00:00
Alexandre Poirot
6f0326bd3a Bug 1222047 - Manage StyleSheets fronts via target.getFront. r=yulia
Summary: Depends On D3316

Tags: #secure-revision

Bug #: 1222047

Differential Revision: https://phabricator.services.mozilla.com/D3317

MozReview-Commit-ID: KMVHXrGlncU
2018-08-23 03:51:40 -07:00
Julian Descottes
640fe52298 Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4

--HG--
extra : rebase_source : 65de1b0aba412d9044b5196115f74276caa058f2
2018-06-01 12:36:09 +02:00
Mark Banner
c07518ff8d Bug 1451659 - Automated ESLint fixes for devtools/client/framework/. r=jdescottes
MozReview-Commit-ID: 26jRtf8ZzTr

--HG--
extra : rebase_source : e70c7307b4d72a5e2572647d9628e8757e924a35
2018-04-04 22:10:09 +01:00
Nicolas Chevobbe
5789c8f4fa Bug 1382581 - Remove old-event-emitter usage from devtools/client/framework; r=bgrins.
MozReview-Commit-ID: 4oQJ3391H9S

--HG--
extra : rebase_source : b7068d3b50cec893cb8b1e1b7ab49f37a13723bd
2018-03-14 17:31:12 +01:00
Tom Tromey
c43bfd93a0 Bug 1179820 - Convert style editor to client-side source maps; r=gl
MozReview-Commit-ID: CV53VKKZz4A

--HG--
extra : rebase_source : d140eb449a1a3197ea7d9cc6484a9267e2bb64af
2017-09-29 07:36:30 -06:00
Tom Tromey
19c7bf1424 Bug 952127 - notify source map subscribers after pretty-printing; r=bgrins
Intercept the applySourceMap source map worker request, so that when a
source is pretty-printed, source map subscribers can be updated.

That this does not yet handle pretty-printing original sources.  This
isn't supported yet by the debugger, and since the plan is to handle it
by augmenting the existing source map, it should be easy to fix this
code when it is implemented.

The mochitest is included here for testing but I am going to land it
upstream as well.

MozReview-Commit-ID: 3Lp1ikO8IzZ

--HG--
extra : rebase_source : f2f02e9e963864567a9dbe3a7e050afcb5f4d3b6
2017-09-15 07:54:56 -06:00
Tom Tromey
78f67a858a Bug 1388497 - apply source maps to CSS warnings in the console; r=bgrins
MozReview-Commit-ID: 8ObL0uwENrM

--HG--
extra : rebase_source : ae9376ca9df6da9db775c1148cfca0b867109628
2017-08-15 14:32:56 -06:00
Julian Descottes
95fd656ac8 Bug 1396071 - check if SourceMapURLService has been destroyed after async call;r=tromey
MozReview-Commit-ID: KsKtgvC9LXt

--HG--
extra : rebase_source : 343f25d553fccb077952db835ddf8fbc25a3c91a
2017-09-02 00:59:46 +02:00
Tom Tromey
1cd992f014 Bug 1391768 - register existing source actors in source map service init; r=bgrins
MozReview-Commit-ID: Ao1viu9sk5O

--HG--
extra : rebase_source : b7f9b697e88f90475e11457256c0df61b2068c38
2017-08-29 14:21:58 -06:00
Tom Tromey
f3c29aa2eb Bug 1371852 - make Frame component listen for source-map pref changes; r=jryans
MozReview-Commit-ID: 51DTsRGogCh

--HG--
extra : rebase_source : fc40cb117e4d504066e11170c6cae546e419ab4f
2017-06-12 16:44:27 -06:00
Tom Tromey
ef18fbbeaf Bug 1366853 - SourceMapURLService must wait for sources to be available; r=bgrins
MozReview-Commit-ID: CVbYQCzJQTu

--HG--
extra : rebase_source : 82895f7d9ef57e821d8f3759966f0db364bf5423
2017-05-22 13:47:42 -06:00
Phil Ringnalda
aea7a458b8 Backed out changeset cff7d7889369 (bug 1366853) for frequently failing browser_source_map-no-race.js at line 39 with: newLoc is null.
MozReview-Commit-ID: CEfFwc3LA2K
2017-06-08 19:29:28 -07:00
Tom Tromey
cb34410a81 Bug 1366853 - SourceMapURLService must wait for sources to be available; r=bgrins
MozReview-Commit-ID: CVbYQCzJQTu

--HG--
extra : rebase_source : 8a77d672917ac4016ad433fbd298b3d620123a9a
2017-05-22 13:47:42 -06:00
Sebastian Hengst
3d00e6950a Backed out changeset 30c2b38c4a0f (bug 1366853) for frequently failing browser_source_map-no-race.js at line 39 with: newLoc is null. r=backout 2017-06-03 12:37:10 +02:00
Tom Tromey
49c7a6f294 Bug 1366853 - SourceMapURLService must wait for sources to be available; r=bgrins
MozReview-Commit-ID: CVbYQCzJQTu

--HG--
extra : rebase_source : 97d3d93a9c7f6e77848005c3a4ac957d7d64517d
2017-05-22 13:47:42 -06:00
Tom Tromey
01a1d5e2f7 Bug 1366062 - clear SourceMapURLService cache on navigation; r=jryans
MozReview-Commit-ID: Elr6d2c7ZJR

--HG--
extra : rebase_source : b301ceb9ed7684e200a129ca1052f4d69b393589
2017-05-18 12:39:36 -06:00
Tom Tromey
9f4ebe5770 Bug 1317962 - use source maps in stack traces in the console; r=jryans
MozReview-Commit-ID: 9SPZDi50XZv

--HG--
extra : rebase_source : e8d9e5eaeb0de0f18b34eae13499d394df696f52
2017-05-02 12:51:51 -06:00
Tom Tromey
5b3ab3e49e Bug 1349354 - remove now-unused source-map-service; r=jryans
MozReview-Commit-ID: umdc4XrpGf

--HG--
extra : rebase_source : 3c4ff9485a970181123fe5d762cfa772b47f6338
2017-05-15 03:17:19 -06:00
Tom Tromey
7cf598b980 Bug 1359144 - use client-side source map service in console; r=jryans
MozReview-Commit-ID: Jn9fr1EoPg9

--HG--
extra : rebase_source : 533abb2bd654a3d6d9046862436f73be3fa64667
2017-04-28 10:12:57 -06:00