Commit Graph

104 Commits

Author SHA1 Message Date
Tom Prince
c9b692824c Bug 1459355: Don't pass parameters as part of actions; r=dustin
This causes actions to fail on graphs with large parameters, such as
release graphs and try pushes.

Differential Revision: https://phabricator.services.mozilla.com/D37499

--HG--
extra : moz-landing-system : lando
2019-08-09 17:02:15 +00:00
Brian Stack
f0b92f7367 Bug 1542233 - Add link to treeherder for all notification emails r=tomprince
This should make all emails from pushes link to treeherder as requested in the bug. I've made  a try push and confirmed that the "thanks for your submission" email still happens with proper links.  I am pretty sure this will set the link in non-try pushes correctly but if it doesn't, nothing will actually break afaict.

Differential Revision: https://phabricator.services.mozilla.com/D37116

--HG--
extra : moz-landing-system : lando
2019-07-08 18:47:27 +00:00
Dustin J. Mitchell
f3654593cc Bug 1547724 - send cron failure notifications to sheriffs / ciduty r=aryx
Differential Revision: https://phabricator.services.mozilla.com/D30598

--HG--
extra : moz-landing-system : lando
2019-05-16 15:37:05 +00:00
Dustin J. Mitchell
a4256b1185 Bug 1547781 - expire try decision artifacts after 28 days r=Callek
This ensures that the artifacts an action task might consult will be gone at
the same time that the push's tasks expire.

Differential Revision: https://phabricator.services.mozilla.com/D29270

--HG--
extra : moz-landing-system : lando
2019-04-30 13:48:25 +00:00
Dustin J. Mitchell
850305dbcc Bug 1547781 - test that .taskcluster.yml renders; r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D29269

--HG--
extra : moz-landing-system : lando
2019-04-30 13:48:05 +00:00
Tom Prince
b4849975d4 Bug 1488313: [taskgraph] Don't notify sherrifs on cron decision task failures on try; r=dustin
Differential Revision: https://phabricator.services.mozilla.com/D25090

--HG--
extra : moz-landing-system : lando
2019-03-27 19:38:05 +00:00
Dustin J. Mitchell
ed9ceeeeb7 Bug 1491371, 1512188 - use new decision task image, with new options r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D24401

--HG--
extra : moz-landing-system : lando
2019-03-21 18:12:23 +00:00
Dustin J. Mitchell
4b406f0a1e Bug 1534283 - add a 'tasks_for' property; r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D23569

--HG--
extra : moz-landing-system : lando
2019-03-14 20:01:32 +00:00
Dustin J. Mitchell
c8fe0990f8 Bug 1524358 - get commit message locally, rather than from task parameters r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D18288

--HG--
extra : moz-landing-system : lando
2019-02-01 23:27:48 +00:00
Dustin J. Mitchell
0a44f01f62 Bug 1524358 - use ownTaskId, instead of as_slugid('decision'), in .taskcluster.yml r=Callek,tomprince
This is a forward-looking change to allow evaluation of .taskcluster.yml in
situations where as_slugid is not defined -- such as in the Taskcluster hooks
service.

Differential Revision: https://phabricator.services.mozilla.com/D18269

--HG--
extra : moz-landing-system : lando
2019-02-01 23:27:47 +00:00
Dustin J. Mitchell
da6fa3a08b Bug 1524358 - document inputs to .taskcluster.yml more deeply r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D18287

--HG--
extra : moz-landing-system : lando
2019-02-01 23:27:48 +00:00
Aki Sasaki
99c00fea5e Bug 1521264 - add clientId to action context + description. r=dustin
Differential Revision: https://phabricator.services.mozilla.com/D17976

--HG--
extra : moz-landing-system : lando
2019-01-29 20:46:13 +00:00
Cosmin Sabou
cdfad80704 Backed out changeset aee9f213f3c7 (bug 1496890) for causing Bug 1521264. a=backout 2019-01-19 11:22:32 +02:00
Dustin J. Mitchell
5e4c79d90d Bug 1496890 - include client calling triggerHook in action description r=aki
Differential Revision: https://phabricator.services.mozilla.com/D16875

--HG--
extra : moz-landing-system : lando
2019-01-17 18:22:20 +00:00
Dustin J. Mitchell
1516eb0435 Bug 1492664 - set TASKCLUSTER_ROOT_URL and TASKCLUSTER_PROXY_URL; r=tomprince,glandium
Eventually, workers will provide these variables directly
(https://bugzilla.mozilla.org/show_bug.cgi?id=1460015).  But for now, this
ensures that TASKCLUSTER_ROOT_URL is set everywhere in production, and
TASKCLUSTER_PROXY_URL is set wherever the proxy is active.

The taskgraph Taskcluster utils module gets a `get_root_url()` that gets the
root URL for the current run, either from an environment variable in production
or, on the command line, defaulting to https://taskcluster.net for user
convenience.  When the production instance's URL changes, we can simply change
that default.

Other changes to use this function are reserved for later commits.

This changes the docker build process propagate TASKCLUSTER_ROOT_URL into the
docker images where necessary (using %ARG), specifically to create URLs for
debian repo paths.

--HG--
extra : rebase_source : 4f50e9d066da62a1887baabd8603844c85a32ee6
extra : source : 5ea6f03f845e49d503f5d0283557f54561c41654
2018-09-25 20:18:19 +00:00
Danut Labici
9027f6e4c6 BUG 1500166 - notify ciduty by email if a nightly hook fails + fix identation issue. r=tomprice
--HG--
extra : rebase_source : 3c816fde539f2ac3ba0292737f8d00e7cc95af5e
2018-12-20 18:39:43 +02:00
Sebastian Hengst
767c971623 Backed out 21 changesets (bug 1492664) for breaking cron task for nightlies. a=backout
Backed out changeset a7d50dbb2c8e (bug 1492664)
Backed out changeset 2d876c4ece8b (bug 1492664)
Backed out changeset c82285d253de (bug 1492664)
Backed out changeset bf6d089640eb (bug 1492664)
Backed out changeset d9a7f2ce49c3 (bug 1492664)
Backed out changeset 06c466ab4323 (bug 1492664)
Backed out changeset c1ea4a10cc8d (bug 1492664)
Backed out changeset 4c63a04fdd47 (bug 1492664)
Backed out changeset 742b038bb1dd (bug 1492664)
Backed out changeset 911b4b0fb683 (bug 1492664)
Backed out changeset 870c8cec99e5 (bug 1492664)
Backed out changeset 77699b51336b (bug 1492664)
Backed out changeset 29f33f22fd8b (bug 1492664)
Backed out changeset e7f305408708 (bug 1492664)
Backed out changeset 335a92b1f424 (bug 1492664)
Backed out changeset c566f1c8dcdf (bug 1492664)
Backed out changeset c77ae59aba41 (bug 1492664)
Backed out changeset 9c35dd209c6b (bug 1492664)
Backed out changeset a972d6b4434e (bug 1492664)
Backed out changeset 5ea6f03f845e (bug 1492664)
Backed out changeset 0699d3873e44 (bug 1492664)

--HG--
extra : histedit_source : 5cb1f7e50f25d4a875c1a58c86b7dce902e1a89c%2C20f1ab1a843b612cfcc67cf5c6ff745d65abf076
2018-12-20 12:43:22 +02:00
Dustin J. Mitchell
4a0a6eae05 Bug 1492664 - set TASKCLUSTER_ROOT_URL and TASKCLUSTER_PROXY_URL; r=tomprince,glandium
Eventually, workers will provide these variables directly
(https://bugzilla.mozilla.org/show_bug.cgi?id=1460015).  But for now, this
ensures that TASKCLUSTER_ROOT_URL is set everywhere, and TASKCLUSTER_PROXY_URL
is set wherever the proxy is active.

The setup for the mach commands defaults to https://taskcluster.net for user
convenience.  When the production instance's URL changes, we can simply change
that default.

This changes the docker build process propagate TASKCLUSTER_ROOT_URL into the
docker images where necessary (using %ARG), specifically to create URLs for
debian repo paths.

--HG--
extra : rebase_source : 0626ebdb66a9f4078cb75ab71be256c334297363
2018-09-25 20:18:19 +00:00
Margareta Eliza Balazs
2e5e28f518 Backed out 16 changesets (bug 1492664) for breaking developer artifact builds, requested by standard8 a=backout
Backed out changeset 31e500489665 (bug 1492664)
Backed out changeset f4945658d45f (bug 1492664)
Backed out changeset 6d17291b8b92 (bug 1492664)
Backed out changeset 90f3faa36137 (bug 1492664)
Backed out changeset 0b229b00818a (bug 1492664)
Backed out changeset 5eb2c77d70a9 (bug 1492664)
Backed out changeset e1ebad5d89c5 (bug 1492664)
Backed out changeset 3017e5890739 (bug 1492664)
Backed out changeset c8b7e620eabf (bug 1492664)
Backed out changeset d3dfbd848236 (bug 1492664)
Backed out changeset 5c92bb5ac895 (bug 1492664)
Backed out changeset fb7cfca6ebc3 (bug 1492664)
Backed out changeset 0c4101230d4d (bug 1492664)
Backed out changeset b93a0fcc86f3 (bug 1492664)
Backed out changeset 6dc9522ee0bf (bug 1492664)
Backed out changeset 85d7f8b330eb (bug 1492664)
2018-12-19 11:45:29 +02:00
Dustin J. Mitchell
211a6cf5e3 Bug 1492664 - set TASKCLUSTER_ROOT_URL and TASKCLUSTER_PROXY_URL; r=tomprince,glandium
Eventually, workers will provide these variables directly
(https://bugzilla.mozilla.org/show_bug.cgi?id=1460015).  But for now, this
ensures that TASKCLUSTER_ROOT_URL is set everywhere, and TASKCLUSTER_PROXY_URL
is set wherever the proxy is active.

The setup for the mach commands defaults to https://taskcluster.net for user
convenience.  When the production instance's URL changes, we can simply change
that default.

This changes the docker build process to propagate TASKCLUSTER_ROOT_URL into
the docker images, and for good measure includes some code to use that value to
generate debian repo paths.

Differential Revision: https://phabricator.services.mozilla.com/D14196

--HG--
extra : moz-landing-system : lando
2018-12-18 05:37:41 +00:00
Tom Prince
fe977ab920 Bug 1486970 - Create revision and pushlog-id index routes for cron decision tasks. r=dustin,aki
This changeset actually creates the new routes we want for decision tasks, and adds the supporting code for passing push info
in to the taskgraph.

This must land after scriptworker is updated and deployed. This has the affect of also un-hardcoding the .taskcluster.yml
fields applied in the first part of this bug.

This changeset in particular will ride trains and not be uplifted (outside of compelling reasons).

Differential Revision: https://phabricator.services.mozilla.com/D5195

--HG--
extra : moz-landing-system : lando
2018-11-27 22:33:09 +00:00
Dustin J. Mitchell
d5fbd16a25 Bug 1509997 - set priorities cron > action > decision r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D12991

--HG--
extra : moz-landing-system : lando
2018-11-26 22:13:41 +00:00
J.C. Jones
329de1ce5e Bug 1505930 - Promote try-push analysis result r=catlee
"It's the best!" used to be front-and-center on try push email notifications,
within the content area of the automated happiness-intensifier email.

Bug 1490515 regressed the happiness to the far-right side of the subject line.
In keeping with "It's the best!" deserving a top-level treatment, it should be
duplicated (by value) in the message body.

Differential Revision: https://phabricator.services.mozilla.com/D11374

--HG--
extra : moz-landing-system : lando
2018-11-08 21:40:53 +00:00
Sebastian Hengst
823c8a37c2 Bug 1500166 - notify ciduty by email if a nightly hook fails + fix identation issue: fix indentation. a=bustage-fix 2018-10-23 18:27:00 +03:00
Danut Labici
afd8da3931 BUG 1500166 - notify ciduty by email if a nightly hook fails + fix identation issue. r=tomprice a=dlabici 2018-10-23 18:09:30 +03:00
Danut Labici
1ee5d25b26 BUG 1500166: notify ciduty by email if a nightly hook fails, r=tomprince a=dlabici 2018-10-23 16:17:19 +03:00
Dustin J. Mitchell
c2f2a7caaf Bug 1494333 - index crons just like artifacts r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D7099

--HG--
extra : moz-landing-system : lando
2018-10-11 13:29:11 +00:00
Andreea Pavel
50041c9be3 Backed out changeset 8db96096643b (bug 1494333) for breaking nigthlies a=backout 2018-10-11 02:51:53 +03:00
Dustin J. Mitchell
be80a48cec Bug 1494333 - index crons just like artifacts r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D7099

--HG--
extra : moz-landing-system : lando
2018-10-02 19:02:14 +00:00
Connor Sheehan
f8eb1abca2 Bug 1490515: add "on-completed" notify route to try push decision tasks r=tomprince
Buildbot had a feature where a notification email would be sent to
the user who triggered the build jobs once Buildbot had begun
processing the request. Since we have migrated off Buildbot, we
have lost this much-appreciated functionality. Taskcluster
allows us to send emails when a task fails, raises an exception
or completes successfully. We already send notification emails
out for the first two cases, sending an email on completion of
the Gecko decision task would essentially replicate the Buildbot
functionality. This commit adds the "on-completed" notification
route when the repository project alias corresponds to a known
try repo. In that case, we also add data to the
`extra.notification.email` section which creates a link to the
Treeherder view for the scheduled jobs.

Differential Revision: https://phabricator.services.mozilla.com/D6253

--HG--
extra : moz-landing-system : lando
2018-09-24 13:46:55 +00:00
Dustin J. Mitchell
1db578453a Bug 1491621 - use different priorities for different kinds of decisions r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D6193

--HG--
extra : moz-landing-system : lando
2018-09-19 20:41:01 +00:00
Justin Wood
d3a9739ed5 Bug 1486970 - Create revision and pushlog-id index routes for cron decision tasks. r=dustin,aki
This hardcodes the push info in .taskgraph.yml for cron so that we don't break Chain Of Trust (signing)
on other branches (uplifts) when we adjust scriptworker to start passing in this data to json-e.

This allows us to incrementally roll this out without needing a flag day, and will be needed on all production branches.

Differential Revision: https://phabricator.services.mozilla.com/D4501

--HG--
extra : moz-landing-system : lando
2018-09-14 16:47:09 +00:00
Cosmin Sabou
08f6c0c2ce Backed out changeset 79d78bba6f68 (bug 1486970) for braking backfiling and add new jobs tasks. CLOSED TREE 2018-09-13 22:10:20 +03:00
Justin Wood
6a9c360740 Bug 1486970 - Create revision and pushlog-id index routes for cron decision tasks. r=dustin,aki
This hardcodes the push info in .taskgraph.yml for cron so that we don't break Chain Of Trust (signing)
on other branches (uplifts) when we adjust scriptworker to start passing in this data to json-e.

This allows us to incrementally roll this out without needing a flag day, and will be needed on all production branches.

Differential Revision: https://phabricator.services.mozilla.com/D4501

--HG--
extra : moz-landing-system : lando
2018-09-13 02:32:05 +00:00
Tom Prince
b8f29771e0 Bug 1469610: [taskgraph] Use action.taskGroupId to set ACTION_TASK_GROUP_ID; r=dustin
This makes it consistent with everywhere else in `.taskcluster.yml` where we
refer to the action task group.

Differential Revision: https://phabricator.services.mozilla.com/D1707

--HG--
extra : moz-landing-system : lando
2018-09-07 17:30:12 +00:00
Cosmin Sabou
5daea4b632 Backed out changeset 3db3193ec938 (bug 1486970) for braking the nightlies with signing issues. a=backout 2018-08-30 03:49:42 +03:00
Justin Wood
32546f18c2 Bug 1486970 - Create revision and pushlog-id index routes for cron decision tasks. r=dustin
Differential Revision: https://phabricator.services.mozilla.com/D4501

--HG--
extra : moz-landing-system : lando
2018-08-29 15:40:37 +00:00
Dustin J. Mitchell
91f4fe8c61 Bug 1398277: special-case retriggering of tasks not in the taskgraph; r=bstack
This will apply to cron tasks, action tasks, and decision tasks.  It is a
distinct retrigger implementation because (a) we do not want to follow
dependencies, and (b) it takes a lot of scopes to create a decision task, so we
need to limit access to this action.

MozReview-Commit-ID: 21DVSiagcrO

--HG--
extra : rebase_source : 6f027e349e245e4aa4dbed81145a0a5d75218cb1
extra : histedit_source : eff99aee5a0e7496b0734748b29739480eb0e3fb
2018-07-04 02:46:59 +00:00
Dustin J. Mitchell
9b317841af Bug 1470886 - only produce tasks for recognized tasks_for; r=tomprince
This carefully maintains tasks as an array by putting the conditional inside of
that array.  Note that `[{$if: 'false', then: 1}]` returns `[]` in JSON-e --
the missing `else` branch is treated as a missing array element.

MozReview-Commit-ID: 9ARIxW3gfWo

--HG--
extra : rebase_source : 304ce14ccc9abc9f4f48f3179adb981b5fe55a0e
2018-07-03 18:07:42 +00:00
Brindusan Cristian
df2e2473fb Backed out changeset 66956b121b93 (bug 1470886) for signin exceptions. CLOSED TREE 2018-07-03 21:39:52 +03:00
Dustin J. Mitchell
af478ed758 Bug 1470886 - only produce tasks for recognized tasks_for r=tomprince
This also updates actions to "see through" the conditional.  Soon we won't be
using kind=task, so this hack will be less important.

MozReview-Commit-ID: Aa6g9ZqoPMa

--HG--
extra : rebase_source : 7434f2047c48ff0d1fa6de9e3419fb4e0bf0bb72
2018-06-25 18:21:03 +00:00
Coroiu Cristina
54208e7808 Backed out changeset 63a6f0d75b74 (bug 1470886) for failing Geko decision task on a CLOSED TREE 2018-07-02 17:55:30 +03:00
Dustin J. Mitchell
087a4c8924 Bug 1470886 - only produce tasks for recognized tasks_for r=tomprince
MozReview-Commit-ID: Aa6g9ZqoPMa

--HG--
extra : rebase_source : e7df4e66ee2d8ca1feadb845163a0d3c8544537f
2018-06-25 18:21:03 +00:00
Dustin J. Mitchell
af304cf4c7 Bug 1437958 - notify taskcluster-notifications@ on action task failure; r=bstack
MozReview-Commit-ID: Fe3gUUmJkny

--HG--
extra : rebase_source : 563dba25c2fbd2b10ebd3ffc78572deaa414cdf6
2018-06-11 15:20:37 +00:00
Aki Sasaki
2f37d56e67 bug 1432364 - remove comment about docker sha allowlists. r=gps
In bug 1328719, we added support for rebuilding the decision/action task definition via json-e.
In bug 1459705, we're killing support for cot v1, which relied on docker sha allowlists and decision task command parsing. Because we no longer use the docker sha allowlists, let's remove this comment.

MozReview-Commit-ID: HntXmoSzUij

--HG--
extra : rebase_source : 3869737cc8b2cce75965235657c2a3bc427952df
2018-05-29 12:45:21 -07:00
Dustin J. Mitchell
2ed7526fb7 Bug 1415868 - change ACTION_TASK_GROUP_ID to be the taskGroupId of the target task; r=aki
MozReview-Commit-ID: 8Hkga4MmmtG

--HG--
extra : rebase_source : 6512a6c2188affdf9cf13e795f36eebbeefee2ef
2018-05-18 22:16:43 +00:00
Dustin J. Mitchell
aeb0a55c25 Bug 1415868 - remove ACTION_TASK r=jonasfj,tomprince
For kind=hook, the spec doesn't include this value as it's untrustworthy.

For kind=task, it's still untrustworthy, but there is no privilege escalation
so that's not important. Still, it dramatically expands the size of the task
definition.

MozReview-Commit-ID: 6scQ2ZwxP10

--HG--
extra : rebase_source : 4dc34390a510091ddc26023755992995fe358e47
2018-04-27 22:24:42 +00:00
Dustin J. Mitchell
edbae96f0c Bug 1415868 - include in-tree:hook-action:..{level}-* in decision task scopes; r=jonasfj,tomprince
The inclusion of this scope limits the actions initiated within this decision
task's task group.

MozReview-Commit-ID: E5gP9UR3pdu

--HG--
extra : rebase_source : 335a4f3bb15bdf3a9bd9c75a692fabb1417a5461
2018-04-25 21:41:54 +00:00
Gregory Szorc
0eb25614c9 Bug 1456326 - Use latest decision image for decision task; r=dustin
As part of this we also change the cache name to ensure that
the new image uses a separate cache from the old image.

MozReview-Commit-ID: J4DmgupnyS

--HG--
extra : rebase_source : 44c0ee3de8b9a7a4854c462e2796662c998c02b0
2018-04-23 18:01:22 -07:00
Tom Prince
0de4a5fd3d Bug 1455448: Don't include firefox in the decision task index; r=dustin,mshal,rail,Callek a=release
The decision task is used for everything built as part of a push (for
mozilla-central, this is firefox, devedition and fennec, as well as tasks that
aren't strictly part of any product). Thus, having `firefox` encoded as part of
the decision task doesn't make sense.

This changes the route from
    index.gecko.v2.${repository.project}.latest.firefox.decision
to
    index.gecko.v2.${repository.project}.latest.taskgraph.decision
while leaving the latter for backwards compatability with tools that expect it.

Differential Revision: https://phabricator.services.mozilla.com/D996

--HG--
extra : rebase_source : c4c4691bb4633225e5e37b21982b916f76353e27
extra : source : 6ef1607a3e63250eefbda5333d61fd338c23311d
2018-04-19 15:32:02 -06:00