Commit Graph

4491 Commits

Author SHA1 Message Date
Ricky Stewart
c0cea3b0fa Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Henri Sivonen
4362f51641 Bug 1666300 part 2 - Parse into an inert document. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D93478
2020-10-23 12:48:52 +00:00
Razvan Maries
b4044e05f9 Backed out 3 changesets (bug 1666300, bug 1667113) for perma failures on browser_parsable_css.js. CLOSED TREE
Backed out changeset 29c5257d0a06 (bug 1667113)
Backed out changeset 0f0fc78ad521 (bug 1666300)
Backed out changeset 9b0c50269ef7 (bug 1666300)
2020-10-22 14:04:15 +03:00
Henri Sivonen
8439bf4064 Bug 1666300 part 2 - Parse into an inert document. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D93478
2020-10-19 13:42:31 +00:00
Dorel Luca
1ff59cb7a3 Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart
50762dacab Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Emilio Cobos Álvarez
f813f5248d Bug 1669664 - Don't speculatively load scripts, etc inside a template element. r=hsivonen
I guess in order to make this 100% sound we should check the whole
template mode stack, but that seemed more expensive than what I'd really
like, and I think it's not likely to be an issue in practice (maybe we
can too-eagerly preload some images inside tables inside templates, or
something of that sort?).

Differential Revision: https://phabricator.services.mozilla.com/D92773
2020-10-14 21:58:50 +00:00
Ricky Stewart
362abcf949 Bug 1670357 - Remove make targets for cleaning: clean, realclean, clobber, distclean, clobber_all, everything r=firefox-build-system-reviewers,mhentges
The `clobber` targets are superseded by `mach clobber`, so we don't need them for any reason. The `clean` target is meant to get you to a post-`configure` state, but it doesn't really work, and if it's necessary for you to be in that state for some reason you can just clobber and re-`configure`, so it doesn't seem worth it to get it working again. Instead, delete all of them. Also delete `everything` which is not useful when `clobber` doesn't exist.

Differential Revision: https://phabricator.services.mozilla.com/D93514
2020-10-15 20:37:18 +00:00
Henri Sivonen
aeee6b217b Bug 1607762 - Make the refcount of nsHtml5OwningUTF16Buffer atomic. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D92936
2020-10-14 15:29:44 +00:00
Bogdan Tara
f07a7512b9 Backed out changeset 0191bd914f91 (bug 1669664) for test_login_item.html failures a=backout 2020-10-09 00:01:18 +03:00
Emilio Cobos Álvarez
35ada269d3 Bug 1669664 - Don't speculatively load scripts, etc inside a template element. r=hsivonen
I guess in order to make this 100% sound we should check the whole
template mode stack, but that seemed more expensive than what I'd really
like, and I think it's not likely to be an issue in practice (maybe we
can too-eagerly preload some images inside tables inside templates, or
something of that sort?).

Differential Revision: https://phabricator.services.mozilla.com/D92773
2020-10-08 10:58:27 +00:00
Simon Giesecke
de7bab0f06 Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D82325
2020-09-23 15:17:15 +00:00
Makoto Kato
c48e63ea6f Bug 1425291 - Part 2. Add autocapitalize attribute to htmlparser. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D86675
2020-09-15 14:26:14 +00:00
Henri Sivonen
76563e652c Bug 1606499 - Abort document on location.reload(). r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D89439
2020-09-10 14:37:16 +00:00
Henri Sivonen
bb3eb9db34 Bug 1663921 - Make the speculative parser honor the non-xlink: versions of SVG href. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D89604
2020-09-10 11:37:07 +00:00
Gerald Squelart
5f9ff13253 Bug 1663543 - Convert PROFILER_ADD_MARKER and 2-arg profiler_add_marker to PROFILER_MARKER_UNTYPED - r=gregtatum
Mostly mechanical change, with some extra work where non-literal names are provided.
Also, when this is the only profiler call in a file, `#include "GeckoProfiler.h"` can be changed to `#include "mozilla/ProfilerMarkers.h"`.

Differential Revision: https://phabricator.services.mozilla.com/D89415
2020-09-10 03:02:36 +00:00
Kagami Sascha Rosylight
0f5ce0d9b6 Bug 1646140 - Fire SVG onload only when scripting is enabled r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D89218
2020-09-07 14:45:12 +00:00
Zibi Braniecki
e32d8044f7 Bug 1661646 - Extend YSOD Telemetry with error_code and location. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D88535
2020-08-28 22:04:13 +00:00
Zibi Braniecki
535300fcb7 Bug 1657242 - Report telemetry for Yellow Screen of Death. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D85951
2020-08-10 17:38:00 +00:00
Simon Giesecke
1e02318b49 Bug 1653335 - Replace MakeSpan uses by constructor calls. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D83817
2020-08-07 07:49:47 +00:00
Simon Giesecke
dea5b543db Bug 1653335 - Remove uses of MakeSpan in return statements. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D83812
2020-08-07 07:42:50 +00:00
Sean Feng
98f103468e Bug 1653474 - Update meta element related tests r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D84546
2020-08-05 16:27:22 +00:00
Sean Feng
75047f597c Bug 1653474 - Process META elements when it's inserted r=smaug
Unlike other engine vendors, we process meta elements
at parser, instead of when they are inserted. This
leads some web compact issues.

This patch aligns us with other vendors.

Differential Revision: https://phabricator.services.mozilla.com/D84545
2020-08-05 16:32:57 +00:00
Matt Brundage
f8a95de9bc Bug 1650326 - Fix typo in error message about over-deep tree. DONTBUILD NPOTB r=alchen
Differential Revision: https://phabricator.services.mozilla.com/D82151
2020-08-03 11:09:33 +00:00
Mike Bremford
f58ab49971 Bug 1650330 - Ensure every Locator is also a Locator2 (#10). DONTBUILD NPOTB r=alchen
* Replace org.xml.sax.helpers.LocatorImpl with nu.validator.htmlparser.impl.LocatorImpl

* instanceof before cast to Locator2

Differential Revision: https://phabricator.services.mozilla.com/D82153
2020-08-03 12:30:12 +00:00
Simon Pieters
8932345bb3 Bug 1650329 - Improve message: bad start tag in noscript in head. r=alchen
Differential Revision: https://phabricator.services.mozilla.com/D82152
2020-08-03 12:30:12 +00:00
Michael[tm] Smith
0793c41754 Bug 1650323 - Add suppress "unchecked" for a TreeBuilder method. DONTBUILD NPOTB r=alchen
In `nu.validator.htmlparser.impl.TreeBuilder`, this change adds
`@SuppressWarnings("unchecked")` to the `getUnusedStackNode()` method.

Differential Revision: https://phabricator.services.mozilla.com/D82149
2020-08-03 11:14:51 +00:00
Michael[tm] Smith
8399e9fd77 Bug 1650320 - Drop parse error for missing </caption> end tag. r=alchen
See https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-incaption:stack-of-open-elements-2
The parse error for this case was dropped from the spec in
https://github.com/whatwg/html/commit/759ee62

Relates to https://github.com/validator/validator/issues/593
and https://bugzilla.mozilla.org/show_bug.cgi?id=1429415

Differential Revision: https://phabricator.services.mozilla.com/D82146
2020-07-06 12:45:48 +00:00
Michael[tm] Smith
23655261b6 Bug 1650105 - Emit error (not warning) for HTML4/XHTML1 doctype. DONTBUILD NPOTB r=alchen
Since 2594493 HTML4/XHTML1
doctypes have caused the warning `Obsolete doctype. Expected <!DOCTYPE html>`.
This change makes that message an error rather than just a warning — bringing
the parser into conformance with whatwg/html@31c20af
(whatwg/html#2049).

Differential Revision: https://phabricator.services.mozilla.com/D82028
2020-07-06 12:45:18 +00:00
Michael[tm] Smith
c53017c5a8 Bug 1650090 - Stop reporting HTML4-specific parse errors. DONTBUILD NPOTB r=alchen
Differential Revision: https://phabricator.services.mozilla.com/D82021
2020-08-03 11:03:02 +00:00
Simon Pieters
48a99da41f Bug 1650085 - Remove warning about comments before doctype. DONTBUILD NPOTB r=alchen
This only applied to IE6..9, and does not apply to conditional comments.

Differential Revision: https://phabricator.services.mozilla.com/D82015
2020-07-08 11:33:21 +00:00
Michael[tm] Smith
fd65b5299d Bug 1650077 - Report error always for Transitional doctype. DONTBUILD NPOTB r=alchen
Fixes https://github.com/validator/validator/issues/408 Thanks @still-dreaming-1

Differential Revision: https://phabricator.services.mozilla.com/D82010
2020-08-03 10:57:42 +00:00
Michael[tm] Smith
7f7f8f9d1f Bug 1650059 - Report 1024 as byte limit for meta charset sniff. DONTBUILD NPOTB r=alchen
Fixes https://github.com/validator/validator/issues/232

Differential Revision: https://phabricator.services.mozilla.com/D81999
2020-07-06 12:44:15 +00:00
Michael[tm] Smith
e52b75de58 Bug 1003273 - Fix "non-space characters insided a table" typo. DONTBUILD NPOTB r=alchen
Differential Revision: https://phabricator.services.mozilla.com/D81996
2020-08-03 10:47:53 +00:00
Michael[tm] Smith
eb17e73a0a Bug 1077211 - Fix grammar problem in HTML parser error message. r=flod,alchen
Differential Revision: https://phabricator.services.mozilla.com/D81995
2020-07-03 10:22:42 +00:00
Frederik Braun
a7153982e8 Bug 1366973: Rename security flags to not contain DATA anymore r=geckoview-reviewers,ckerschb,snorp
Differential Revision: https://phabricator.services.mozilla.com/D83490
2020-07-15 11:20:45 +00:00
Sylvestre Ledru
caf785c695 Bug 1519636 - Reformat recent changes to the Google coding style r=andi
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D82178
2020-07-04 09:38:43 +00:00
Simon Giesecke
e3c223da3e Bug 1648010 - Fix uses of NS_LITERAL_STRING with C string literals. r=geckoview-reviewers,agi,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80861
2020-07-01 08:34:12 +00:00
Simon Giesecke
cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Henri Sivonen
2d63627ce0 Bug 1647728 - Unify kCharsetFromUserForced and kCharsetFromParentForced. r=m_kato
For making further changes less messy.

Differential Revision: https://phabricator.services.mozilla.com/D80813
2020-06-25 03:25:03 +00:00
Makoto Kato
41fc689975 Bug 1490661 - Part 2. Add enterkeyhint attribute to htmlparser. r=hsivonen
Bug 1618295 isn't merged into https://github.com/validator/htmlparser, I copy
it from /parser/html/javasrc/AttributeName.java

Differential Revision: https://phabricator.services.mozilla.com/D79642
2020-06-23 06:37:43 +00:00
Henri Sivonen
0ac48d1d0c Bug 1645313 - Instantiate mozilla::JapaneseDetector only when needed. r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D80456
2020-06-23 01:40:53 +00:00
Jean-Yves Avenard
87438519f0 Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj
Before P1, GetCurrentThreadSerialEventTarget would have always returned the same data as NS_GetCurrentThread, making the comment incorrect Now it will properly return the running TaskQueue if any.

This change of name more clearly exposes what they are doing, as we aren't always dealing with threads directly; but a nsISerialEventTarget

Differential Revision: https://phabricator.services.mozilla.com/D80354
2020-06-23 05:05:36 +00:00
tkhan
6ccabd4784 Bug 1602668 - M(1) manifest and test changes. r=kmag,karlt,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D70362
2020-06-22 19:09:49 +00:00
Henri Sivonen
d5b9be12ce Bug 1603712 - Remove intl.charset.detector.ng.enabled pref and resulting dead code. r=Gijs,fluent-reviewers,valentin,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D79101
2020-06-15 15:32:21 +00:00
Henri Sivonen
0469ed0adb Bug 1555523 test. r=alchen
Differential Revision: https://phabricator.services.mozilla.com/D35129
2020-06-05 07:04:29 +00:00
Henri Sivonen
8f21b214e6 Bug 1636607 - Use prefix match for public identifiers that trigger the Almost Standards Mode. r=alchen
Implements a part of the spec change
https://searchfox.org/whatwg-html/diff/9345b201261c452868a68780ece85370f17644a3/source#42357
that was originally missed.

Differential Revision: https://phabricator.services.mozilla.com/D74658
2020-06-11 13:29:57 +00:00
Frederik Braun
6eac45b147 Bug 1644070 - add missing URLish attributes to TreeSanitizer r=hsivonen
This adds the elements `formaction`, `data`, `ping`, `poster`.

We can't really add a test for the `<object data>`, since we never
allow `<object>` elements in the first place and we don't allow
settings exceptions for temporarily allowed elements.
Same for `poster` elements, since it's only used in media elements
and those are either all allowed or none.

Differential Revision: https://phabricator.services.mozilla.com/D78638
2020-06-10 07:24:05 +00:00
Emilio Cobos Álvarez
54fd961a29 Bug 1641245 - Make string comparators not virtual. r=froydnj,necko-reviewers,geckoview-reviewers,jgilbert,agi,valentin
There's no use case for stateful comparators, so they can be just plain
function pointers.

This is used in some hot places like CSS selector matching.

Differential Revision: https://phabricator.services.mozilla.com/D77084
2020-05-27 18:11:12 +00:00
Emilio Cobos Álvarez
c3b7227771 Bug 1639392 - Merge nsIStyleSheetLinkingElement and nsStyleLinkElement, and call it LinkStyle. r=jwatt
Which is the spec term. nsIStyleSheetLinkingElement is even more
confusing since it may not be an element at all (see: processing
instructions).

Differential Revision: https://phabricator.services.mozilla.com/D76071
2020-05-21 03:07:16 +00:00