Automatic update from web-platform-tests
[FlexNG] Set MinSizeShouldEncompassIntrinsicSize
SetMinBlockSizeShouldEncompassIntrinsicSize() on a flex item
to allow the item to grow as a result of fragmentation.
In order for this flag to have an effect on flex items inside
a column flex container, we also had to SetIsFixedBlockSize()
to false.
This will be used to expand the flex lines if needed.
Bug: 660611
Change-Id: I8890cc54262c14664706b9cb9efb141a453dceff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276791
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#941410}
--
wpt-commits: dc91bc44ac13e268173db8afe9ee7eb6cfbf73d1
wpt-pr: 31611
Automatic update from web-platform-tests
Add test for layout containment inside a fit-content parent (#31617)
--
wpt-commits: 274541188260b060f4f060b72a30f1dabd3c78b8
wpt-pr: 31617
Automatic update from web-platform-tests
[inert] Let modal dialogs make the root element inert
From https://html.spec.whatwg.org/multipage/interaction.html#inert,
> A Document document is blocked by a modal dialog subject if subject is
> the topmost dialog element in document's top layer. While document is
> so blocked, every node that is connected to document, with the
> exception of the subject element and its shadow-including descendants,
> must be marked inert.
This doesn't exclude the root element, so it should also be inert.
Simply doing this change would break these tests:
- html/dialog/modal-dialog-ancestor-is-inert.html
- html/dialog/modal-dialog-blocks-mouse-events.html
Excluding the root element in HitTestResult::SetInnerNode avoids that.
Note I plan to track inertness in ComputedStyle, and then remove both
Node::IsInert and hit test retargeting for inert. So this patch is just
temporary, to align with the final behavior.
Also note that only the the root element (documentElement) is affected.
The root node (document), represented as rootWebArea in a11y, will still
not become inert when there is a modal dialog or fullscreen element.
Bug: 692360
TEST=All/DumpAccessibilityTreeTest.AccessibilityModalDialogOpened/blink
TEST=All/DumpAccessibilityTreeTest.AccessibilityModalDialogStack/blink
TEST=All/DumpAccessibilityTreeTest.AccessibilityOpenModal/blink
TEST=external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-node-is-unfocusable.html
Change-Id: I8ce7905a85e386fae6163423f5e078b6c4588db1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3263132
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#941302}
--
wpt-commits: 0457111e7109ec3d9e575aa421b96d8c36ce2ae8
wpt-pr: 31533
Automatic update from web-platform-tests
Move move-after-transition.html to WPT
Removed unused styles. Converted from a pixel test to asserts. Ensure
initial transition is triggered, and that there is no additional
transition after setting transition-property to 'none'.
Bug: 1267553
Change-Id: I302709dee4990f2871d6c248852bd23993cda754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3275545
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#941300}
--
wpt-commits: 26bb6529ea8b19b93a1f878ebba79353f87d4da0
wpt-pr: 31616
Automatic update from web-platform-tests
WebTransport: Use UseCounter::Count
Use UseCounter::Count in web_transport.cc instead of
ExecutionContext::CountUse. The difference that that the UseCounter
variant performs a null check and so can safely be used after the
ExecutionContext has been destroyed.
Add a test that it safe to access WebTransport getters even after
the frame in which the WebTransport was created has been destroyed.
BUG=1269525
Change-Id: I4af26f3e34adcfcf28bf39f99f6e694fb61d91c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276626
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#941183}
--
wpt-commits: 6d1c0336a90465a5524ef31ec7819e35ceb45845
wpt-pr: 31615
Automatic update from web-platform-tests
[GridFragmentation] Position items based on their row position.
Previously we'd decide if a grid-item should be placed in the current
fragmentainer based on their global position.
This was ok - but a better strategy is to try and keep them with their
row. This wasn't initially important, but as break avoidance is row
based, when we try to shift a row to a subsequent fragmentainer we'll
potentially end up with an item which has already been placed.
This has the side-effect that a grid-item with a negative block-start
margin, may be placed above the start fragmentainer edge - which seems
ok.
I added this as a tentative testcase.
Bug: 614667
Change-Id: I65486307fd72f8e5f8cb7f87ebce66c5569deedf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276728
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#941176}
--
wpt-commits: 0615ca344e889600c5cadbee05307e4fae5a2977
wpt-pr: 31605
Automatic update from web-platform-tests
Revert "Add a WPT for pointerevent user activation trigger."
This reverts commit 34b3146d8dfc1e44715703e4cf97779fc7c8688d.
Reason for revert: Suspected cause of crbug.com/1269035, will
verify before submitting.
Original change's description:
> Add a WPT for pointerevent user activation trigger.
>
> Related to HTML issue: https://github.com/whatwg/html/issues/3849
>
> Also fix double-activation in Chrome's gesture tap.
>
> Bug: 826293, 1265587
> Change-Id: I3bc3bcbcfeda242512fb777a1c8881c475fed5fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254213
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#940118}
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 826293, 1265587
Change-Id: I4bc041f2254c382c00ce3596d61742ba84c79660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3277061
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Owners-Override: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/main@{#940996}
--
wpt-commits: eca3a50a442ab21283638efbf1617492924f5fdd
wpt-pr: 31608
Automatic update from web-platform-tests
adding new client hint Sec-CH-UA-Full-Version-List
Changes:
* adding new client hint sec-ch-ua-full-version-list
* spec changes to match https://wicg.github.io/ua-client-hints/#interface
* devtool backend changes
* wpt tests to verify the new clint hint
devTool frontend change will be in a separate cl:
* https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3261035
Design doc:
* https://docs.google.com/document/d/1QnbHD7yv1gL7dSnQb6cxL5ILYBLAtkRmEGC6wy9Wu0Y/edit?usp=sharing
Bug: 1249246
Change-Id: I06a9a8ec6512a96bb0f5a9e2ae270380195f913c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256910
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ali Beyad <abeyad@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Victor Tan <victortan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940839}
--
wpt-commits: 9bb25759452dcad9edd83e676f83c73a7bf9f16e
wpt-pr: 31503
Automatic update from web-platform-tests
Move color-transition-premultiplied.html to WPT
Defers style change until after the page has been rendered. Changes the
test to use the web-animations API instead if windows.internals. Fixed
off by one error in an expected color. Moved from being an internal
test to a WPT test.
Bug: 1267553
Change-Id: Icf0c51b1a49b0ba256c9c1afcc906649df78f19d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3273014
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940835}
--
wpt-commits: 3d1dfbeb08197cf2969965045c2aead5edfdbddb
wpt-pr: 31585
Automatic update from web-platform-tests
[@layer] Cascade VTT-embedded style as element-attached style
As per https://github.com/w3c/csswg-drafts/issues/6735:
WebVTT-embedded style has the same cascade precedence as the style
attribute. Therefore, important WebVTT-embedded style should take
precedence over important author layered style.
This patch ensures that.
Bug: 1095765
Change-Id: I352ff87294235433bcf006e233a2ca7514d4f990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3273710
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940808}
--
wpt-commits: 20d6038632233d23b144c8f1e1cc02c35665efbf
wpt-pr: 31591
Automatic update from web-platform-tests
add unit test for get_run_info
--
Add extra data about Safari/WebKit to run_info
--
wpt-commits: 165245557fc8b36eca73d506b19a03e63a428e28, ecde07fcd19960af177a4bd3dd374043c5856f75
wpt-pr: 29884
Automatic update from web-platform-tests
Move transition-end-event-shorthand.html to WPT and deflake.
Ensure that page has rendered before doing the style update to trigger
transitions. Switched to using the web-animations API in place of
windows.internals for cross-platform support.
Bug: 1267553
Change-Id: Ia6af19d38b50a1479ff43a7e9742d8575e646732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3272694
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940784}
--
wpt-commits: f8650c51a171bf03a624de906484244000561273
wpt-pr: 31583
Automatic update from web-platform-tests
URL: use ß instead of β to show interop issue better
--
wpt-commits: 55f9cf18627b655439c5775db2cc74b58fea3676
wpt-pr: 31596
Automatic update from web-platform-tests
[css-conditional-3] Test contents of @media and @supports.
--
wpt-commits: adcd6787bbf28c9c6b8294099c9c5817e72cb662
wpt-pr: 31589
Automatic update from web-platform-tests
serial: Check for detached buffers when writing
This change adds check in SerialPortUnderlyingSink::WriteData() to
ensure that the V8BufferSource being written to the Mojo data pipe has
not been detached since it was passed to the WritableStream.
Bug: 1267627
Change-Id: I63d48584eb0be1c1d87c27115900aa5c17931fcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3269348
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940631}
--
wpt-commits: fa18309c97011b6e222fd24e6e5a4b358aac9d77
wpt-pr: 31553
Automatic update from web-platform-tests
MSE-in-Workers: Fix deadlock on duration reduction
If MediaSourceInWorkers is enabled but MediaSourceNewAbortAndDuration is
not enabled, then when MediaSource duration is reduced, a deprecated
code path calls each SourceBuffer in the MediaSource to remove the media
that might potentially be truncated by the duration reduction. This
remove call itself took the same lock that is already held in the caller
in this case, causing unresponsive page due to double-lock on the
CrossThreadMediaSourceAttachment's lock.
This change calls Remove_Locked instead, since the preconditions checked
in SourceBuffer::remove are already enforced in
MediaSource::setDuration, and the double-lock is avoided.
This change also fixes a stray call to setting duration in a
MSE-in-Worker test to use the correct interface (though such call would
not have hit this double-lock on bots since those bots enable all
experimental web platform features.)
BUG=1268614,878133
TEST=manually confirmed repro fixed locally
Change-Id: I1a144cdab9bae5f66b6e1137c2b275c392c12023
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3274133
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Will Cassella <cassew@chromium.org>
Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Will Cassella <cassew@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940603}
--
wpt-commits: cc6a981ed8a6988e31e657fd43f8a19dc6068a44
wpt-pr: 31590
Automatic update from web-platform-tests
Ignore overflow inside monolithic content for fragmentation.
This is a revert of the fix for bug 1178742, and it will make us
compatible with Firefox. The exact behavior isn't defined in the spec.
See https://github.com/w3c/csswg-drafts/issues/6056
This change will also make it more sensible to fix crbug.com/1242348
and also easier to make the initial column balancing pass more in sync
with actual fragmentation (in a follow-up CL).
Bug: 1178742, 829028
Change-Id: I1bea2fce39b20723d14398ae54cc7f06fa54eb4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3270687
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940591}
--
wpt-commits: 8010b3d2e76d0f365f087abe4972775b352dad6e
wpt-pr: 31580
Automatic update from web-platform-tests
[@layer] Ensure layer establishment behavior on failed/unmatched imports
As per https://github.com/w3c/csswg-drafts/issues/6776:
1. @import with unmatched media query shouldn't establish layer
2. @import that fails to load should still establish layer
This patch adds test cases for it and also fixes our behavior on 1.
Bug: 1095765
Change-Id: Ia7d2c9921b4b93173546cbd78ab243dac3f92420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3272669
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940505}
--
wpt-commits: c21a4bab57696f57f98fe063fd976e88e6556de4
wpt-pr: 31586
Automatic update from web-platform-tests
Tests for ::placeholder and ::file-selector-button inheritance
Both of those elements are tree-abiding pseudo elements which should
inherit from their originating elements per spec.
Bug: 922869
Change-Id: Ia00a9a421895e6fcd48b7403da97360dae73f91e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3268596
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940495}
--
wpt-commits: f9d614349dbb0ce3ab5180f6fcfe24f727b34dac
wpt-pr: 31579
Automatic update from web-platform-tests
[FlexNG] Fragmentation for stretched items
As suggested in CL:3256656, refactor ApplyStretchAlignmentToChild()
to use BuildSpaceForLayout. To accomplish this, pass the final line
cross size into BuildSpaceForLayout during the final layout pass for
stretched items.
By doing this we can remove ApplyStretchAlignmentToChild(), and call
into LayoutWithBlockFragmentation() for stretched items if applicable
(since that will also call into BuildSpaceForLayout).
A new wpt test was added to test basic fragmentation for stretched flex
items.
virtual/layout_ng_flex_frag/fast/multicol/flexbox/doubly-nested-with-zero-width-flexbox-and-forced-break-crash.html
is now being skipped due to a timeout. Seems to be caused by the
forced break. This test was not timing out before since fragmentation
was not being applied to the test previously. This will be
investigated in a follow-up.
Bug: 660611
Change-Id: Ifefbe1480c7134c5fbf215cd1e03a8e79e45f1ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3267938
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940473}
--
wpt-commits: 76ecf1910addf9f0f49d25c978790a8a15573fc5
wpt-pr: 31561
Automatic update from web-platform-tests
Move change-duration-during-transtion.html to WPT
In the process of moving the test, a few changes were made to address
test flakes. Though the test was triggering to style updates, the
second update could complete before the page was rendered, which would
result in no transition being triggered. The test was accelerated by
forcing the animation to finish, rather than waiting on the
transitionend event.
Bug: 1267553
Change-Id: Id8eb7b86ccad76b0ec33050c7103fd21d16530a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3270068
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940458}
--
wpt-commits: 7f625604ff78d716ad4b7130543cb54aa400a1fb
wpt-pr: 31567
Automatic update from web-platform-tests
Move transition-timing-function.html to WPT and deflake
The original test did not properly ensure that the style change would be
picked up after rendering the page. Thus, we might not see transition
animations. The test also relied on windows.internals, which does not
provide cross-browser support. Moved the test to WPT and switched to
using appropriate web-animation API calls. Dropped the webkit prefix
from the test. Finally, updated the expected target values. Two of the
values in the original test were off by 1, but matched the overly loose
tolerance. The updated version computes the expected value of the cubic
Bezier easing functions.
Note, this is one of 6 flaky tests associated with the bug. Next step is
to port the remaining tests unless WPT equivalents can be found.
Bug: 1267553
Change-Id: If083981a705709d9d0f95b83429d986170dee3d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3269980
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940433}
--
wpt-commits: 0aebe5d1145f727f5cfedb7f2aeb7c6f53274dd8
wpt-pr: 31565
Automatic update from web-platform-tests
[@layer] Make 'revert-layer' work in keyframes
As per the recent CSSWG resolution [1], 'revert-layer' in keyframes
should revert from the animation origin. This patch implements that.
[1] https://github.com/w3c/csswg-drafts/issues/6749#issuecomment-960303732
Bug: 1095765
Change-Id: I3f093548da61108c24c05c6a679e9b1d85207467
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3232606
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940387}
--
wpt-commits: 96eed7c0ae5e3539dcc70ee4a777158f5237bde3
wpt-pr: 31319
