Commit Graph

68 Commits

Author SHA1 Message Date
Phil
348c4c37ff Bug 1256773 - eslint issues fix for devtools/client/webconsole/panel.js. r=lclark 2016-04-06 15:35:00 +02:00
Dave Townsend
92b18b36e8 Bug 1257246: Update eslint rules for eslint 2. r=MattN
Rename the rules that ESLint 2 no longer supports to the new names. Ignore the
microformat test suite as it is external code.

MozReview-Commit-ID: BgIxFERjHp1

--HG--
extra : rebase_source : 9f02a87f9a843b427b021caa72db9eb766287151
extra : histedit_source : 954abc7e447ac6cdd36290ade7adec626f4fe4fb
2016-04-05 11:33:12 -07:00
Alexis Métaireau
88915017a0 Bug 1250104 - Import the "jsesc" library for escaping JavaScript strings. r=rnewman
--HG--
extra : rebase_source : 4aa4b917473d8a6d3ca9796c1bbb9d9d59b7b73a
2016-02-24 15:40:55 +01:00
Jan Odvarko
781ed5c343 Bug 1257173 - Make JSON viewer code eslint clean; r=linclark
MozReview-Commit-ID: LUzs6Pb4c3z

--HG--
extra : rebase_source : 72554e907dd29bb5ab60ed8b0b4c29facf1d4a85
2016-03-17 22:26:53 -07:00
Tom Tromey
fbafa60ad1 Bug 1255799 - make devtools/client/webconsole eslint-clean; r=odvarko
MozReview-Commit-ID: AnaXFFHlNLM
2016-03-16 08:16:00 +01:00
Wes Kocher
a80b3e7f67 Merge m-c to fx-team, a=merge
MozReview-Commit-ID: FyYG71q4yxf
2016-03-08 16:09:09 -08:00
Gijs Kruitbosch
ac0ad4fb40 Bug 1245649 - ignore readability JS files when running eslint, rs=implied-by-mossop
MozReview-Commit-ID: JdD35U8ZKvu
2016-03-08 17:00:47 +00:00
Myk Melez
db9a40ca42 Bug 1238079 - remove the desktop web runtime; r=fabrice,mossop,gps,jryans,jmaher,marco 2016-03-07 13:33:12 -08:00
Patrick Brosset
138604079b Bug 1252099 - Final eslint cleanups in devtools/client/inspector/markup/test; r=miker
Many event-bubble tests had max-len issues that would have been really
awkward to fix by wrapping the lines. So I decided to disable eslint for
those lines instead.

This patch fixes the last remaining eslint issues and un-ignores the
directory in .eslintignore.

MozReview-Commit-ID: KQ8qtrFceaf

--HG--
extra : rebase_source : d907de27c9d866af174ac8135f8317520c4d87a2
2016-03-02 16:14:16 +01:00
Alexandre Poirot
ffdbd09825 Bug 1245875 - Remove Tilt from tree. r=vporof,jwalker 2016-03-03 02:27:22 -08:00
Brendan Dahl
2ece6215a9 Bug 1235869 - Remove web runtime from android. r=myk 2016-02-29 10:31:00 +01:00
Yury Delendik
d3e1f74458 Bug 1250046 - Remove Shumway core files. r=till 2016-02-23 18:07:05 -06:00
Sebastian Hengst
d34912b8e7 Bug 1251916 - Use standard JavaScript features in toolkit/components/passwordmgr to pass eslint checks: enable eslint. r=MattN
MozReview-Commit-ID: F8nvRExCbff

--HG--
extra : rebase_source : 07d5a9136de52a2af8f8591884f564f7c3284299
extra : amend_source : 5762ef9d2ddc1d1023a68a411a2f5584d0ee15e1
2016-02-28 14:12:00 -08:00
Sebastian Hengst
979f65c7b2 Bug 1251748 - Remove eslint exclusion of removed pocket directory. r=mixedpuppy
MozReview-Commit-ID: HwYV5HYkGYL
2016-02-26 23:22:03 +01:00
Tim Nguyen
5b9b9eda76 Bug 1251720 - Remove Storage Inspector directory from .eslintignore. r=pbro
MozReview-Commit-ID: 1J0FJcnF69v
2016-02-26 21:54:09 +01:00
Wes Kocher
1b22811473 Backed out changeset 26bbd4cee816 (bug 1250104) because the test it added is failing
MozReview-Commit-ID: 5RWr4L5CzV2
2016-02-26 09:52:24 -08:00
Alexis Métaireau
779b41d21f Bug 1250104 - Import the "jsesc" library for escaping JavaScript strings. r=rnewman 2016-02-24 15:40:55 +01:00
Patrick Brosset
3e2897155c Bug 1242898 - Clean devtools/client/animationinspector of eslint errors; r=me
MozReview-Commit-ID: 8kRnACID8A6
2016-02-26 12:55:57 +01:00
Patrick Brosset
a31b063cce Bug 1246677 - 7 - Clean remaining ruleview and tests eslint warnings; r=jdescottes
MozReview-Commit-ID: BcyEv4fUWJZ

--HG--
extra : rebase_source : d589e9df51222df10db1e2095f5018d8c44bcb5a
2016-02-23 17:09:01 +01:00
Ryan VanderMeulen
b92db8e975 Backed out 10 changesets (bug 1246677) for causing frequent OSX browser_rules_completion-existing-property_01.js failures (10.6 and 10.10).
Backed out changeset a6d3a7a5e4ea (bug 1246677)
Backed out changeset 5dcb51fcef15 (bug 1246677)
Backed out changeset e450c5329a06 (bug 1246677)
Backed out changeset a65e8badc4c4 (bug 1246677)
Backed out changeset 0cdde48161bb (bug 1246677)
Backed out changeset bab3de413d37 (bug 1246677)
Backed out changeset e4f6cc6197cb (bug 1246677)
Backed out changeset 34e6b56e419d (bug 1246677)
Backed out changeset 5067508e5db4 (bug 1246677)
Backed out changeset 913b4129466e (bug 1246677)
2016-02-24 21:04:31 -05:00
Patrick Brosset
e8e084446b Bug 1246677 - 7 - Clean remaining ruleview and tests eslint warnings; r=jdescottes
MozReview-Commit-ID: BcyEv4fUWJZ

--HG--
extra : rebase_source : cb63ed3c966567fe298bf67cafdbf08e36118712
2016-02-23 17:09:01 +01:00
Dave Townsend
688e1344df Bug 1245916: Add additional browser window scripts to eslint globals. r=felipe
This adds more of the scripts that browser.js relies on and also makes
browser-chrome head files import the browser.js globals.

The MOZ_JSDOWNLOADS block in contentAreaUtils only seems to hide a single
function, I don't see any need to keep hiding that now we're on by default.

MozReview-Commit-ID: 5zvF3JtJrZG

--HG--
extra : rebase_source : 94daff602b51d7ad57a24872d9eba9b304cf2da9
extra : source : b554c7ce41c42f16c2279ae88fd9567da7509bff
2016-02-05 12:16:39 -08:00
Dave Townsend
9d6c28bf7c Bug 1245916: XBL bindings should support global declarations in comments. r=miker
To properly lint XBL files we need to support things like import-globals-from
and other ESlint comment directives so we have to pass comments through to the
code blocks that ESlint parses. Unfortunately the way the XBL processor works
now is by passing a separate code block for every method/property/etc. in the
XBL and ESlint doesn't retain state across the blocks so we would have to prefix
every block with every comment. Instead this change makes us output just a
single block that roughly looks like this:

<comments>
var bindings = {
  "<binding-id>": {
    <binding-part-name>: function() { ... }
  }
}

This has some interesting bonuses. Defining the same ID twice will cause a lint
failure. Same for the same field in a binding. The line mapping is a little
harder and there are still a few lines that won't map directly back to the
original file but they should be rare cases. The only downside is that since
some bindings have the same binding declared differently for different platforms
we have to exclude those from linting for now.

MozReview-Commit-ID: CAsPt5dtf6T

--HG--
extra : rebase_source : 91a60ef0359ef53093fe197ed63dbc4e1a9f10a5
extra : source : 01675e4828b524c04a9057d68b41e9cc01ca1bb9
2016-02-05 12:13:34 -08:00
Phil Ringnalda
9dc941a05d Backed out 5 changesets (bug 1245916) for browser-chrome and devtools bustages
CLOSED TREE

Backed out changeset 70eca07367f4 (bug 1245916)
Backed out changeset 04c1740aa499 (bug 1245916)
Backed out changeset b554c7ce41c4 (bug 1245916)
Backed out changeset 01675e4828b5 (bug 1245916)
Backed out changeset 878db4caf845 (bug 1245916)
2016-02-15 13:58:27 -08:00
Dave Townsend
8f0976db4f Bug 1245916: Add additional browser window scripts to eslint globals. r=felipe
This adds more of the scripts that browser.js relies on and also makes
browser-chrome head files import the browser.js globals.

The MOZ_JSDOWNLOADS block in contentAreaUtils only seems to hide a single
function, I don't see any need to keep hiding that now we're on by default.

MozReview-Commit-ID: 5zvF3JtJrZG

--HG--
extra : rebase_source : a99f752b053765b621cf03965bda0c586a9eb1cb
2016-02-05 12:16:39 -08:00
Dave Townsend
5425cecf02 Bug 1245916: XBL bindings should support global declarations in comments. r=miker
To properly lint XBL files we need to support things like import-globals-from
and other ESlint comment directives so we have to pass comments through to the
code blocks that ESlint parses. Unfortunately the way the XBL processor works
now is by passing a separate code block for every method/property/etc. in the
XBL and ESlint doesn't retain state across the blocks so we would have to prefix
every block with every comment. Instead this change makes us output just a
single block that roughly looks like this:

<comments>
var bindings = {
  "<binding-id>": {
    <binding-part-name>: function() { ... }
  }
}

This has some interesting bonuses. Defining the same ID twice will cause a lint
failure. Same for the same field in a binding. The line mapping is a little
harder and there are still a few lines that won't map directly back to the
original file but they should be rare cases. The only downside is that since
some bindings have the same binding declared differently for different platforms
we have to exclude those from linting for now.

MozReview-Commit-ID: CAsPt5dtf6T

--HG--
extra : rebase_source : 700db61686d5eac3f05f758ad1ce505bcdb6aa7f
2016-02-05 12:13:34 -08:00
Gijs Kruitbosch
1b8fd05302 Bug 1246591 - fix moz.build file and .eslintignore, r=MattN
--HG--
extra : commitid : JDnRUikojj9
extra : rebase_source : 7075c06b2ef03490728d752a8c754c97e5ed75dd
2016-02-08 12:58:28 +00:00
Patrick Brosset
02105f3428 Bug 1244755 - 3 - Remove CPOW usages and eslint warnings from devtools/client/inspector/layout; r=miker
--HG--
extra : commitid : C78quZjX7oH
extra : rebase_source : 86d67bf697d50ed162ae9c01d96329db3d87bcae
extra : histedit_source : 97e16f53f0c63e8265e603841cb73d751f74e69e
2016-02-04 20:56:32 +01:00
Joe Whitfield-Seed
135346b144 Bug 1245496 - Fix eslint errors in about:debugging. r=janx 2016-02-04 20:10:08 +00:00
Hector Zhao
9397ebc869 Bug 1242977 - Make services eslintable. r=markh
--HG--
extra : rebase_source : 55938ea80a97dc92df10c073cc45c54ff4cb94c7
2016-02-02 10:37:50 +08:00
Tom Tromey
2c8e61ac71 Bug 1240183 - make styleeditor eslint-clean; r=pbro 2016-01-29 08:25:26 -07:00
chaithanya
6a47f9e3eb Bug 1090880 - Remove FUEL.r=mak
--HG--
extra : commitid : C5SfTW1i0bJ
2016-01-28 16:47:26 +01:00
Carsten "Tomcat" Book
92b2943e68 Merge mozilla-central to mozilla-inbound 2016-01-27 12:10:56 +01:00
Cykesiopka
7ccd56ad60 Bug 1242254 - Enable initial set of eslint rules for PSM. r=dkeeler
These rules are copied from toolkit/.eslintrc (with non-passing rules excluded and previously commented out and passing rules included).

--HG--
extra : rebase_source : 0afa42350cc961cbb3cf6d985b3978f4dc5d3dcb
2016-01-24 02:35:36 -08:00
Patrick Brosset
985beb4e9c Bug 1242689 - Fix eslint errors in devtools/client/*.js and un-ignore the files; r=tromey
--HG--
extra : commitid : 76W5rnBhXFZ
extra : rebase_source : b8ab20a08648924fe8d508efed76ae46a0d99b1a
extra : histedit_source : 9e56a71166fc5017eaa22ad5aedccaa5d585ad68%2C6dc936e4406a7930ea0419b199c2f71f0fe94911
2016-01-26 10:53:45 +01:00
Gabriel Luong
9f804b7b10 Bug 1242278 - Eslint cleanup of Inspector markup view r=pbro 2016-01-25 15:00:04 -05:00
Jared Wein
3f6801477a Bug 1242137 - Fix eslint errors in /browser/components/customizableui. r=gijs
--HG--
extra : commitid : CTMv8KOMjRK
extra : rebase_source : 768fb80e4652c1f0e14eea9e32da8eff795f1659
extra : amend_source : bd695a57c00c8004b048ccd4673465d66bea22c6
extra : histedit_source : ca0c6fcb719d0e7f0895de1bd429fa9804833f65
2016-01-23 14:55:27 -05:00
Jared Wein
2dbe57ccdf Bug 1241993 - Fix eslint errors in nsBrowserGlue.js. r=gijs
--HG--
extra : commitid : 5XwsMNzJWOo
extra : rebase_source : 979ff3d416d2e56defbcae2416a33b2662c2d543
extra : amend_source : 8388277586649e30da71f469eab172b647e76265
extra : histedit_source : 39b723f2eeaa1aee216c80bc637994a0a2089881
2016-01-22 15:48:20 -05:00
Jared Wein
8bcdb781ff Bug 1242125 - Fix eslint errors in /browser/components/uitour. r=mattn
--HG--
extra : commitid : 9YOFmXUhUj9
2016-01-23 19:46:10 -05:00
Gijs Kruitbosch
ef6c115cda Bug 1200639 - part 0: fix eslint issues in nsBrowserContentHandler.js, r=jaws
--HG--
extra : commitid : KiJuaeKR5Wl
extra : rebase_source : 7b09496e783d3c87b2c602314b3efc52e8e4a852
2016-01-19 22:03:11 +00:00
Patrick Brosset
1f6d47b1c1 Bug 1213651 - Avoid server round-trips when displaying animated dom nodes; r=tromey
The main change here is that nodeFronts that have already been displayed
in the timeline are stored in a WeakMap so they can be retrieved from it
next time they're displayed and avoid a server-side round trip which, in
turn, causes the UI to flicker.

The other change is that now, it is possible to tell the animations actor
what is the current walker actor, which allows animation player actors to
directly send the NodeActor ID as part of their forms. Which, in most cases,
completely eliminates the server round-trip, because the corresponding
NodeFronts are already known on the client, so we get them from there.

The last change done here is that AnimationTargetNode now becomes a thin
wrapper on top of the new DomNodePreview component that was extracted so
it can be reused in other places.

--HG--
extra : commitid : EBVS63soQOi
extra : rebase_source : ad57513f53bc9d8d3250deb0e5a3cd3817d5631b
extra : histedit_source : 6319eafeb82f34d5cfeff1f175483c47ff71725b%2C5a2b6464611eada9deb3351bbf3c2711cecf1cff
2016-01-21 13:19:58 +01:00
Marco Bonardo
7eb562e238 Bug 1230471 - Basic eslint fixes in places. r=mconley
--HG--
extra : commitid : 3qDaDd3cKSc
extra : rebase_source : 8dc99f1b7dc0bb7bb7b9059ff4d8527685a50291
2015-12-10 06:46:49 -05:00
Georg Fritzsche
154be33ae3 Bug 1240091 - Enable linting on more toolkit modules. r=Mossop 2016-01-15 19:20:44 +01:00
Mark Banner
c7a6910039 Bug 1232707 - Build changes to support Loop imported as an add-on. r=mikedeboer,r=glandium 2016-01-14 17:53:32 +00:00
Dave Townsend
f27556ce7d Bug 1231956: Add devtools to .eslintignore. r=pbrosset
Devtools has a lot of eslint failures right now that would block us from turning
on compile time eslint checks in bug 1229588. For now I'd like to just ignore
the directory and then you can work to clean up the warnings and re-enable
checks at whatever pace you like.

--HG--
extra : rebase_source : fa20216cecf457081fc6fc65a974a73b358d1ae2
2016-01-11 14:28:54 -08:00
Dave Townsend
a1dcc24776 Bug 1238781: Add pre-processed pref file to .eslintignore. r=felipe
--HG--
extra : commitid : FulAh3Xj577
extra : rebase_source : 11cf6c7805968ae95428759148414211300c72c3
2016-01-11 15:35:50 -08:00
Dave Townsend
99e46fd0e0 Bug 1237340: Fix browser and toolkit eslint failures. r=Felipe
--HG--
extra : rebase_source : 3e1098fe6d387bed1edcad365e318c484e8989ea
2016-01-06 10:10:35 -08:00
Kris Maglione
8d948cbdfc Bug 1230776: Support scripts from HTML files in eslint. r=gps
Also removes related unused variables in mach_commands.py.

--HG--
extra : commitid : IiDVMuEZtA5
extra : rebase_source : 575a51dd0ad5450323b4da5f441f8e5d721e41d6
2015-12-05 13:17:49 -08:00
Gijs Kruitbosch
c652fdb86e Bug 1233492 - make browser/experiments eslintable, r=felipe
--HG--
extra : commitid : AlqcGlqXwrj
extra : rebase_source : 2daaa302b04cef72b173265dccdba55a538e58eb
2015-12-17 19:42:24 +00:00
Gijs Kruitbosch
2a29a25860 Bug 1233470 - make browser/modules eslintable, r=Mossop
--HG--
extra : commitid : IZkQYhmLl9V
extra : rebase_source : 82bd0ac1e9f3b3267d60d127758fa5771a5e9fc9
extra : amend_source : aa17ba3c05cd56840df3c986ba04221beeac2026
2015-12-17 18:31:08 +00:00