Byron Campen [:bwc]
41541e64f6
Bug 1494301: Single API for mtransport. r=mjf
...
Differential Revision: https://phabricator.services.mozilla.com/D7212
--HG--
extra : moz-landing-system : lando
2018-10-26 00:39:07 +00:00
Nils Ohlmeier [:drno]
2907e6ba61
Bug 1227519: remove DHE ciphers from WebRTC DTLS handshake. r=mt
...
Differential Revision: https://phabricator.services.mozilla.com/D7965
--HG--
extra : moz-landing-system : lando
2018-10-22 22:58:48 +00:00
Nils Ohlmeier [:drno]
dedc2f2c81
Bug 1498068: fixed SRTP key length assertion for GCM 128 bit. r=mt
...
Differential Revision: https://phabricator.services.mozilla.com/D8324
--HG--
extra : moz-landing-system : lando
2018-10-16 03:30:57 +00:00
Byron Campen [:bwc]
ca982a9fae
Bug 1493689 - Defer close of old stream after ICE restart. r=mjf
...
Differential Revision: https://phabricator.services.mozilla.com/D7626
--HG--
extra : rebase_source : d842ee5e65330177afc3d215f94ef69ab800412b
2018-10-04 21:30:22 -04:00
Dragana Damjanovic
9cadc84486
Bug 1473736 - Implement necko part of ESNI r=mak,kmag,mcmanus
...
--HG--
extra : rebase_source : be79870960953ef9535ccb6a440515ec4a8232d5
extra : histedit_source : 8096ab2eaf246cbbeb97bace0531b86b8c69ff66
2018-09-22 23:54:11 +03:00
Gurzau Raul
07d30b811f
Backed out changeset dc225279994a (bug 1473736) for web platform leaks
2018-09-21 04:30:10 +03:00
Dragana Damjanovic
70e0646d75
Bug 1473736 - Implement necko part of ESNI r=mak,kmag,mcmanus
...
Implement necko part of ESNI
Differential Revision: https://phabricator.services.mozilla.com/D2716
--HG--
extra : moz-landing-system : lando
2018-09-20 20:53:28 +00:00
Byron Campen [:bwc]
93985b16c9
Bug 1486012: Rework ICE restart. r=mjf
...
Differential Revision: https://phabricator.services.mozilla.com/D5897
--HG--
rename : dom/media/tests/mochitest/test_peerConnection_restartIceLocalAndRemoteRollback.html => dom/media/tests/mochitest/test_peerConnection_restartIceLocalAndRemoteRollbackNoSubsequentRestart.html
rename : dom/media/tests/mochitest/test_peerConnection_restartIceLocalRollback.html => dom/media/tests/mochitest/test_peerConnection_restartIceLocalRollbackNoSubsequentRestart.html
extra : moz-landing-system : lando
2018-09-20 16:07:51 +00:00
Dan Minor
d42f66fd2b
Bug 1492834
- Remove "Attempting to protect RTP" and related log messages; r=bwc
...
This removes the info messages and adds the packet type to the error messages.
Differential Revision: https://phabricator.services.mozilla.com/D6392
--HG--
extra : moz-landing-system : lando
2018-09-20 14:11:44 +00:00
Nils Ohlmeier [:drno]
5d1ae0414f
Bug 1491511: add Telemetry for SRTP cipher usage. r=mt
...
Bug 1491511: add Telemetry for SRTP cipher usage. r=mt
Differential Revision: https://phabricator.services.mozilla.com/D5956
--HG--
extra : moz-landing-system : lando
2018-09-19 00:08:25 +00:00
Byron Campen [:bwc]
b530163b3c
Bug 1491476: Fix strncpy length in a couple of error cases. r=mjf,drno
...
--HG--
extra : rebase_source : 5830c7df02247cea4395abe5d88dd59e5aa318b9
extra : amend_source : 6867b4861a4517d1c597cbd20074f47c7044baba
2018-09-18 16:56:25 +03:00
Nils Ohlmeier [:drno]
3dab079c7c
Bug 1479665: add GCM ciphers to SrtpFlow. r=bwc
...
add GCM ciphers to SrtpFlow
Differential Revision: https://phabricator.services.mozilla.com/D5731
--HG--
extra : moz-landing-system : lando
2018-09-14 03:12:05 +00:00
Cosmin Sabou
984ac63e0f
Backed out changeset 1a7771d373ff (bug 1479665) for causing build bustages. CLOSED TREE
2018-09-13 23:52:48 +03:00
Nils Ohlmeier [:drno]
77d354dda1
Bug 1479665: add GCM ciphers to SrtpFlow. r=bwc
...
add GCM ciphers to SrtpFlow
Differential Revision: https://phabricator.services.mozilla.com/D5731
--HG--
extra : moz-landing-system : lando
2018-09-13 17:38:50 +00:00
Nils Ohlmeier [:drno]
e88a043618
Bug 1480869: define SRTP ciphers suites inside mtransport r=mt
...
define SRTP cipher suites inside mtransport
Differential Revision: https://phabricator.services.mozilla.com/D5490
--HG--
extra : moz-landing-system : lando
2018-09-11 03:58:34 +00:00
Martin Thomson
1d41c9edcb
Bug 1485883 - Handle use_srtp extension in gecko, r=drno
...
Summary:
This implements the SRTP extension in TransportLayerDtls. My hope is
that we can expunge the SRTP code from NSS in a few releases.
Reviewers: drno
Subscribers: ekr
Tags: #secure-revision
Bug #: 1485883
Differential Revision: https://phabricator.services.mozilla.com/D4188
MozReview-Commit-ID: Cwjrn9wsCQr
2018-09-07 11:50:21 +10:00
Byron Campen [:bwc]
2a2903b7fe
Bug 1483338: Stop using level as the identifier for media transports. r=mjf
...
Differential Revision: https://phabricator.services.mozilla.com/D3448
--HG--
extra : moz-landing-system : lando
2018-08-28 19:45:58 +00:00
Nils Ohlmeier [:drno]
0362a1b463
Bug 1484024: add Telemetry histogram for DTLS ciphers on RTCPeerConnection r=francois,mt
...
Added a Telemetry histrogram which collects which DTLS cipher got
negotiated when a RTCPeerConnection connected.
Differential Revision: https://phabricator.services.mozilla.com/D3551
--HG--
extra : moz-landing-system : lando
2018-08-24 22:49:42 +00:00
Masatoshi Kimura
bcf431f3d3
Bug 1482547 - Suppress clang-cl warnings in media/mtransport/third-party/. r=froydnj
...
--HG--
extra : rebase_source : 71916734b08001258076bc10db3711b191430eb9
2018-08-11 06:08:07 +09:00
Masatoshi Kimura
3b21b7868b
Bug 1090497 - Re-enable warnings as errors on clang-cl. r=froydnj
...
--HG--
extra : rebase_source : c09366fb93e5b0f72abe1e99d3094e3d96a934fb
extra : intermediate-source : 5950c9d63c3b4fd63a25464a7b50944aaec7079f
extra : source : ca1b9a2bcc4381795f556fea2fb59066567c30f3
2018-07-31 22:10:07 +09:00
Dan Minor
0663fd94ea
Bug 1478000 - Prepend -Xclang to -Wall; r=dmajor
...
Summary: We want the clang interpretation of -Wall, not the clang-cl one,
which translates -Wall as -Weverything.
Reviewers: dmajor
Tags: #secure-revision
Bug #: 1478000
Differential Revision: https://phabricator.services.mozilla.com/D2468
--HG--
extra : rebase_source : df684c3ca3088e91d584c715f6219f4318d00c62
2018-07-27 09:12:31 -04:00
Dan Minor
66b7a2fb25
Bug 1478000 - nICEr and nrappkit should use the same warnings under clang-cl as with clang; r=dmajor
...
Summary:
This adds a clangcl flag to gyp.mozbuild and then uses that to set the same
warnings flags for clang-cl as for clang.
Reviewers: dmajor
Tags: #secure-revision
Bug #: 1478000
Differential Revision: https://phabricator.services.mozilla.com/D2427
--HG--
extra : rebase_source : 6137d2f59e5504d448d4fb32a7e734756ff76afa
2018-07-25 14:02:02 -04:00
Robert Bartlensky
32a8366815
Bug 1476640: Fix DEAD_STORE errors in media/mtransport/*.
...
Reviewers: ekr
Reviewed By: ekr
Bug #: 1476640
Differential Revision: https://phabricator.services.mozilla.com/D2265
--HG--
extra : rebase_source : ffc6fc1462635e5ccf301520407adea608794b6f
2018-07-20 19:16:38 +03:00
Nils Ohlmeier [:drno]
630efc5cec
Bug 1473840
: fixed Teredo IPv6 prefix detection. r=mjf
...
MozReview-Commit-ID: 6dRsirith0O
--HG--
extra : rebase_source : 2af77d2420464a0b0ba855d94f9cd6e088d2a777
2018-07-13 21:52:33 -07:00
Nils Ohlmeier [:drno]
cbc07da4e7
Bug 1466375: avoid NRREGGET NRREGSET redefinition. r=bwc
...
MozReview-Commit-ID: 6DdZS7bY2di
--HG--
extra : rebase_source : 8ee57ef14853a27189ef6146629be77b406f4103
2018-06-04 08:51:22 -07:00
Nils Ohlmeier [:drno]
7ba50abeee
Bug 1466375: make nICEr and nrappkit compile as unified sources. r=bwc
...
MozReview-Commit-ID: 59MXxWYd5V0
--HG--
extra : rebase_source : 3778c7aeb8c92b785977d5a612d755dbe951c56d
2018-06-01 22:58:48 -07:00
Byron Campen [:bwc]
777bf8b996
Bug 1455647 - Part 4: Make a place to live for context about media packets, to fix packet dump hooks. r+drno r=drno
...
MozReview-Commit-ID: 1HMF93mLa7r
--HG--
rename : media/mtransport/transportlayersrtp.cpp => media/webrtc/signaling/src/mediapipeline/TransportLayerPacketDumper.cpp
rename : media/mtransport/transportlayersrtp.h => media/webrtc/signaling/src/mediapipeline/TransportLayerPacketDumper.h
extra : rebase_source : 062814836325b69da17e8f592774f006e29905ad
2018-05-09 17:13:35 -05:00
Byron Campen [:bwc]
148a322296
Bug 1455647 - Part 3: Move SRTP into a TransportLayer. r=drno
...
MozReview-Commit-ID: LWZFPVDYZKb
--HG--
rename : media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp => media/mtransport/SrtpFlow.cpp
rename : media/webrtc/signaling/src/mediapipeline/SrtpFlow.h => media/mtransport/SrtpFlow.h
extra : rebase_source : 16e1e38c0c6f9153375735b7cb93a8286364df5f
2018-04-23 13:14:30 -05:00
Byron Campen [:bwc]
ab2913f71d
Bug 1455647 - Part 2: Allow TransportLayers to be arranged in trees. r=drno
...
MozReview-Commit-ID: BQgNbCsmkke
--HG--
extra : rebase_source : f21dbdd6f5477786f200a3336240d724aa8cc9b8
2018-04-27 16:57:28 -05:00
Byron Campen [:bwc]
cb8df81f4c
Bug 1455647 - Part 1: Simplify TransportFlow. r+drno r=drno
...
MozReview-Commit-ID: 1jJuln4WAw9
--HG--
extra : rebase_source : e5d9cba95e7e79815e9842edac2fc5eec54aac06
2018-04-27 12:14:40 -05:00
Emilio Cobos Álvarez
1e9c395548
Bug 1466168: Remove mozilla::Forward in favor of std::forward. r=froydnj
...
Same approach as the other bug, mostly replacing automatically by removing
'using mozilla::Forward;' and then:
s/mozilla::Forward/std::forward/
s/Forward</std::forward</
The only file that required manual fixup was TestTreeTraversal.cpp, which had
a class called TestNodeForward with template parameters :)
MozReview-Commit-ID: A88qFG5AccP
2018-06-02 09:33:26 +02:00
Emilio Cobos Álvarez
fffb25b74f
Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
...
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Jan Keromnes
88a09b356c
Bug 1464162 - Make a few vector operations more efficient by reserving size beforehand. r=jya
...
Summary:
These automated fixes were generated like so:
./mach configure --enable-clang-plugin
./mach build-backend --backend=CompileDB
run-clang-tidy-6.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,performance-inefficient-vector-operation *
Reviewers: jya
Reviewed By: jya
Subscribers: jya
Bug #: 1464162
Differential Revision: https://phabricator.services.mozilla.com/D1381
--HG--
extra : amend_source : 648dc48989c5af122a33f8d50c98c0f1efcf3874
2018-05-31 14:52:59 +03:00
Dan Minor
6a3494fbc0
Bug 1464069 - Check error code in stun_parser_libfuzz.cpp; r=drno
...
MozReview-Commit-ID: Lx32Mx8KmRm
--HG--
extra : rebase_source : 638b6d7498407c52b680ea72898c4dc155dcf3ec
2018-05-29 13:04:28 -04:00
Christian Holler
570031d38c
Bug 1464202 - Improve and centralize libFuzzer flag management. r=froydnj
...
MozReview-Commit-ID: HFrQDAZWtpo
--HG--
extra : rebase_source : ab1da001d7e9280fbfb37858505f1d0d0caf7d54
2018-05-24 21:11:46 +02:00
Dan Minor
e6ea8ef7b6
Bug 1464069 - Check for null message in nr_stun_decode_message; r=drno
...
MozReview-Commit-ID: B1SHDte4miv
--HG--
extra : rebase_source : e60dc6b48319f3cfcff2b3411f7eb8cd8928408e
2018-05-25 11:57:18 -04:00
Byron Campen [:bwc]
d2641f7ceb
Bug 1461904: Make sure to call disconnect_all on STS. r=drno
...
MozReview-Commit-ID: 2WZxajc4FZz
--HG--
extra : rebase_source : 042476cea953c8abeaba9b208dfbba0ab84c8b2e
2018-05-16 15:53:15 -05:00
Sylvestre Ledru
4f43e5effe
Bug 1461614 - Use _DEFAULT_SOURCE on top of _BSD_SOURCE to remove a warning caused by the glibc r=drno
...
MozReview-Commit-ID: 5Vso0zCzSBx
--HG--
extra : rebase_source : 06ab0c54b70647ab3befde9cf692d1030662be37
2018-05-15 11:54:22 +02:00
Michael Froman
79bc45e84a
Bug 1374699 - make warnings errors on nICEr and nrappkit builds. r=ekr
...
MozReview-Commit-ID: 7nPOPzcC925
--HG--
extra : rebase_source : b1b4bd391a71dab2bb3409b68c8680e972ee0ae4
2017-09-21 10:29:16 -05:00
Michael Froman
a3a44bb8ab
Bug 1374699 - fix .gyp file formatting by detabbing. r=ekr
...
MozReview-Commit-ID: CaUMCJgzhrQ
--HG--
extra : rebase_source : f371f42e26d6c8aa52338913a511015d9096e5dc
2017-09-21 16:56:07 -05:00
Michael Froman
d5fb082c26
Bug 1374699 - fixing compiler warnings for nrappkit. r=drno
...
MozReview-Commit-ID: CAQQvheP1Wg
--HG--
extra : rebase_source : a5c5857c84339587f6197be95534700d1aca7942
extra : source : ac789983242b806ceeeca4569ac1f5ddfcbaaba2
2017-09-21 08:56:34 -05:00
Michael Froman
dfb4c1b5bd
Bug 1374699 - fixing compiler warnings for nICEr. r=drno
...
Cleaning up compiler warnings for nICEr. Major highlights:
- set _WINSOCK_DEPRECATED_NO_WARNINGS define in nicer.gyp for Windows
builds of nICEr to avoid warnings about inet_addr use in ice_ctx.c:102,
ice_ctx.c:297, ice_parser.c:465, and transport_addr_reg.c:143.
- move nr_ice_accumulate_count from ice_ctx.{h|c} to stun_util.{h|c}
as nr_accumulate_count to quiet warnings in turn_client_ctx.c and
stun_client_ctx.c.
- stun_msg.{h|c} - change nr_stun_attr_data_.length,
nr_stun_message_attribute.encoding_length and nr_stun_message_.length
from int to UINT2 (not size_t since other lengths in this header are
UINT2).
- stun_codec.{h|c} - lengths and offsets changed from int to UINT2 to
match changes in stun_msg.{h|c}
- r_data.{h|c} - change Data.len from int to size_t
- nr_crypto.{h|c} - change nr_ice_crypto_vtbl_ lengths from int to size_t
MozReview-Commit-ID: EF5v79RpqbI
--HG--
extra : rebase_source : ead30e2359ea6a6aada4dd222137302ba86fb972
2017-07-17 11:49:49 -05:00
Tom Bannister
988d18881f
Bug 1434710 - Replaced all instances of mozilla::IndexSequence, mozilla::MakeIndexSequence and mozilla::IndexSequenceFor with std::index_sequence, std::make_index_sequence and std::index_sequence_for and removed mfbt/IndexSequence.h. r=botond
...
MozReview-Commit-ID: 1Ema7TUNr5v
--HG--
extra : rebase_source : e5bb164dbe19993214e8c16f92b0a1f5d2ff3fa1
2018-04-09 21:12:13 +10:00
Sebastian Hengst
0819f35e51
Backed out 4 changesets (bug 525063) on request from Andi. a=backout
...
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
a3a77c0312
Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan
2018-04-10 21:11:02 +02:00
Christoph Diehl
74e4e24ec3
Bug 1446583: Update location for setting trace-pc coverage flags for LibFuzzer r=drno
...
--HG--
extra : amend_source : b3cd30a440c0e0e88a238bd93fc11e013d17ea84
2018-03-17 18:07:58 +01:00
Byron Campen [:bwc]
a5fa4c3bfb
Bug 1442404: Don't spin STS when shutting down the mtransport thread. r=drno
...
MozReview-Commit-ID: 47BImEsl9xi
--HG--
extra : rebase_source : 9fd820f4db145642f1184264ae991ea0748b0479
2018-03-06 12:30:16 -06:00
Spencer Brown
f91e903df3
BUG 1415886 - Change commented argument name to match declaration r=drno
...
--HG--
extra : amend_source : 71653a1478aad3b8182cccabc9b840fa02b8b26d
2017-11-09 11:20:37 -05:00
Michael Froman
a9c9593126
Bug 1436759 - Release NrIceMediaStreams on sts thread in transport_unittests.cpp. r=bwc
...
MozReview-Commit-ID: BLasqfQJxw
--HG--
extra : rebase_source : bca09672917ce5fc4a5450864c9f461952847b3f
2018-02-14 14:24:50 -06:00
Michael Froman
dc47a5c53d
Bug 1434531 - fix missing TCP relay candidates. r=drno
...
Because the nr_transport_addr_check_compatibility check also includes
protocol, it was failing checks that used to pass. However, the actual
address used was created farther down in code by copying the current
address and setting the protocol to TCP. Moving that address copy up
in the processing flow lets the more stringent check work.
MozReview-Commit-ID: 95SOQzxuxXB
--HG--
extra : rebase_source : 95f4cf6d9f10ee4f81c56d7bbe8027c46749cfb8
2018-02-02 16:03:51 -06:00