Commit Graph

315 Commits

Author SHA1 Message Date
Byron Campen [:bwc]
41541e64f6 Bug 1494301: Single API for mtransport. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D7212

--HG--
extra : moz-landing-system : lando
2018-10-26 00:39:07 +00:00
Nils Ohlmeier [:drno]
dedc2f2c81 Bug 1498068: fixed SRTP key length assertion for GCM 128 bit. r=mt
Differential Revision: https://phabricator.services.mozilla.com/D8324

--HG--
extra : moz-landing-system : lando
2018-10-16 03:30:57 +00:00
Byron Campen [:bwc]
93985b16c9 Bug 1486012: Rework ICE restart. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D5897

--HG--
rename : dom/media/tests/mochitest/test_peerConnection_restartIceLocalAndRemoteRollback.html => dom/media/tests/mochitest/test_peerConnection_restartIceLocalAndRemoteRollbackNoSubsequentRestart.html
rename : dom/media/tests/mochitest/test_peerConnection_restartIceLocalRollback.html => dom/media/tests/mochitest/test_peerConnection_restartIceLocalRollbackNoSubsequentRestart.html
extra : moz-landing-system : lando
2018-09-20 16:07:51 +00:00
Nils Ohlmeier [:drno]
3dab079c7c Bug 1479665: add GCM ciphers to SrtpFlow. r=bwc
add GCM ciphers to SrtpFlow

Differential Revision: https://phabricator.services.mozilla.com/D5731

--HG--
extra : moz-landing-system : lando
2018-09-14 03:12:05 +00:00
Cosmin Sabou
984ac63e0f Backed out changeset 1a7771d373ff (bug 1479665) for causing build bustages. CLOSED TREE 2018-09-13 23:52:48 +03:00
Nils Ohlmeier [:drno]
77d354dda1 Bug 1479665: add GCM ciphers to SrtpFlow. r=bwc
add GCM ciphers to SrtpFlow

Differential Revision: https://phabricator.services.mozilla.com/D5731

--HG--
extra : moz-landing-system : lando
2018-09-13 17:38:50 +00:00
Nils Ohlmeier [:drno]
e88a043618 Bug 1480869: define SRTP ciphers suites inside mtransport r=mt
define SRTP cipher suites inside mtransport

Differential Revision: https://phabricator.services.mozilla.com/D5490

--HG--
extra : moz-landing-system : lando
2018-09-11 03:58:34 +00:00
Martin Thomson
1d41c9edcb Bug 1485883 - Handle use_srtp extension in gecko, r=drno
Summary:
This implements the SRTP extension in TransportLayerDtls.  My hope is
that we can expunge the SRTP code from NSS in a few releases.

Reviewers: drno

Subscribers: ekr

Tags: #secure-revision

Bug #: 1485883

Differential Revision: https://phabricator.services.mozilla.com/D4188

MozReview-Commit-ID: Cwjrn9wsCQr
2018-09-07 11:50:21 +10:00
Byron Campen [:bwc]
2a2903b7fe Bug 1483338: Stop using level as the identifier for media transports. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D3448

--HG--
extra : moz-landing-system : lando
2018-08-28 19:45:58 +00:00
Byron Campen [:bwc]
777bf8b996 Bug 1455647 - Part 4: Make a place to live for context about media packets, to fix packet dump hooks. r+drno r=drno
MozReview-Commit-ID: 1HMF93mLa7r

--HG--
rename : media/mtransport/transportlayersrtp.cpp => media/webrtc/signaling/src/mediapipeline/TransportLayerPacketDumper.cpp
rename : media/mtransport/transportlayersrtp.h => media/webrtc/signaling/src/mediapipeline/TransportLayerPacketDumper.h
extra : rebase_source : 062814836325b69da17e8f592774f006e29905ad
2018-05-09 17:13:35 -05:00
Byron Campen [:bwc]
148a322296 Bug 1455647 - Part 3: Move SRTP into a TransportLayer. r=drno
MozReview-Commit-ID: LWZFPVDYZKb

--HG--
rename : media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp => media/mtransport/SrtpFlow.cpp
rename : media/webrtc/signaling/src/mediapipeline/SrtpFlow.h => media/mtransport/SrtpFlow.h
extra : rebase_source : 16e1e38c0c6f9153375735b7cb93a8286364df5f
2018-04-23 13:14:30 -05:00
Byron Campen [:bwc]
ab2913f71d Bug 1455647 - Part 2: Allow TransportLayers to be arranged in trees. r=drno
MozReview-Commit-ID: BQgNbCsmkke

--HG--
extra : rebase_source : f21dbdd6f5477786f200a3336240d724aa8cc9b8
2018-04-27 16:57:28 -05:00
Byron Campen [:bwc]
cb8df81f4c Bug 1455647 - Part 1: Simplify TransportFlow. r+drno r=drno
MozReview-Commit-ID: 1jJuln4WAw9

--HG--
extra : rebase_source : e5d9cba95e7e79815e9842edac2fc5eec54aac06
2018-04-27 12:14:40 -05:00
Emilio Cobos Álvarez
fffb25b74f Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Jan Keromnes
88a09b356c Bug 1464162 - Make a few vector operations more efficient by reserving size beforehand. r=jya
Summary:
These automated fixes were generated like so:
    ./mach configure --enable-clang-plugin
    ./mach build-backend --backend=CompileDB
    run-clang-tidy-6.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,performance-inefficient-vector-operation *

Reviewers: jya

Reviewed By: jya

Subscribers: jya

Bug #: 1464162

Differential Revision: https://phabricator.services.mozilla.com/D1381

--HG--
extra : amend_source : 648dc48989c5af122a33f8d50c98c0f1efcf3874
2018-05-31 14:52:59 +03:00
Byron Campen [:bwc]
d2641f7ceb Bug 1461904: Make sure to call disconnect_all on STS. r=drno
MozReview-Commit-ID: 2WZxajc4FZz

--HG--
extra : rebase_source : 042476cea953c8abeaba9b208dfbba0ab84c8b2e
2018-05-16 15:53:15 -05:00
Sebastian Hengst
0819f35e51 Backed out 4 changesets (bug 525063) on request from Andi. a=backout
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
a3a77c0312 Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan 2018-04-10 21:11:02 +02:00
Michael Froman
a9c9593126 Bug 1436759 - Release NrIceMediaStreams on sts thread in transport_unittests.cpp. r=bwc
MozReview-Commit-ID: BLasqfQJxw

--HG--
extra : rebase_source : bca09672917ce5fc4a5450864c9f461952847b3f
2018-02-14 14:24:50 -06:00
David Keeler
0375f07548 bug 1432923 - fix a leak in some TransportTests r=drno
Before this patch, TransportTest::Reset would assign to p1_ and p2_ without
releasing their resources first. Since they're not RAII types, they would just
leak. This fixes the leak by a) explicitly initializing them to nullptr in the
constructor and b) deleting them if they previously had a non-null value.

MozReview-Commit-ID: 20U6sqRWg06

--HG--
extra : rebase_source : e304c7636a9b31df53d3ff0e8d7e0042f7e82494
2018-01-25 16:56:56 -08:00
Chris Peterson
37efe4d0e6 Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj
MozReview-Commit-ID: DCPTnyBooIe

--HG--
extra : rebase_source : cfec2d96faeb11656d86d760a34e0a04cacddb13
extra : intermediate-source : 6176724d63788b0fe8caa3f91607c2d93dbaa7ec
extra : source : eebbb0600447f9b64aae3bcd47b4be66c02a51ea
2017-11-05 19:37:28 -08:00
Sylvestre Ledru
9bfe27d903 Bug 1394734 - Replace CONFIG['GNU_C*'] by CONFIG['CC_TYPE'] r=glandium
MozReview-Commit-ID: 7duJk2gSd4m

--HG--
extra : rebase_source : 7312fe276e561e8c034a5f6749774ae812727f9c
2017-12-07 22:09:15 +01:00
Byron Campen [:bwc]
9fed82e6f6 Bug 1290948 - Part 6: Remove some unused code. r+drno r=drno
MozReview-Commit-ID: G1uxg77wO78

--HG--
extra : rebase_source : bb8f7238bebb48251967cc453257ea6665095535
2017-08-23 16:15:11 -05:00
Andreea Pavel
449023b47c Backed out 8 changesets (bug 1290948) for failing mochitest dom/tests/mochitest/general/test_interfaces.html r=backout on a CLOSED TREE
Backed out changeset 97a271bf671e (bug 1290948)
Backed out changeset 8ff38e646037 (bug 1290948)
Backed out changeset 314675023cd5 (bug 1290948)
Backed out changeset 1a5f090502b0 (bug 1290948)
Backed out changeset ffb6e6da955f (bug 1290948)
Backed out changeset 56c169018ceb (bug 1290948)
Backed out changeset 49878c508ce6 (bug 1290948)
Backed out changeset bbe53fb92e21 (bug 1290948)
2017-11-14 21:02:11 +02:00
Byron Campen [:bwc]
6771ce65da Bug 1290948 - Part 6: Remove some unused code. r+drno r=drno
MozReview-Commit-ID: G1uxg77wO78

--HG--
extra : rebase_source : 565120ee7722ac357b682aa2689517f2898e5c7a
2017-08-23 16:15:11 -05:00
Kris Maglione
9184710ae5 Bug 1404198: Part 2g - Switch to NS_NewTimer* in media. r=njn
MozReview-Commit-ID: 3ydSj5HfYzZ

--HG--
extra : rebase_source : 6d38da71d3c82b900b46e69c12ceb81202dd965d
2017-10-15 23:14:33 -07:00
Sylvestre Ledru
d938e24c4c Bug 1387002 - Replace .size() by .empty() when applicable in webrtc & mtransport r=jesup
MozReview-Commit-ID: 4DyftBRDEcU

--HG--
extra : rebase_source : 92b00b313060c0631e087216c6a30b421b58199d
2017-08-04 09:36:19 +02:00
Jan Keromnes
5257fdad8c Bug 1372977 - Use nullptr in /media and /dom/media (clang-tidy: modernize-use-nullptr). r=bwc 2017-06-28 15:38:00 -04:00
Dan Minor
a9df96e992 Bug 1355947 - Use TestNrSocket to build a fake ICE implementation for testing; r=drno
MozReview-Commit-ID: GhSX9t8DmTO

--HG--
extra : rebase_source : 8fea1934f88b378606b4af96d96c27560906fd88
extra : histedit_source : 4d6fc904c79c74ba8c24e816d70368ee3a850769
2017-04-18 06:54:34 -04:00
Bill McCloskey
f115503a0b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Chris Peterson
7dd51821f3 Bug 1373525 - media/mtransport: Remove unused member functions and unused member variable trickled_. r=drno
media/mtransport/test/ice_unittest.cpp:353:12 [-Wunused-member-function] unused member function 'Stream'
media/mtransport/test/ice_unittest.cpp:1394:7 [-Wunused-member-function] unused member function 'trickled'
media/mtransport/test/ice_unittest.cpp:1867:8 [-Wunused-member-function] unused member function 'SetExpectedTypes'
media/mtransport/test/transport_unittests.cpp:917:8 [-Wunused-member-function] unused member function 'InitIce'

MozReview-Commit-ID: 70PNtdc92mg

--HG--
extra : source : 5dc220c3efd5bd2f8f844eb85887a4bcfabb3990
extra : intermediate-source : 0751fb1b9b19a8451c5aba7e021bcb386962ce5d
2017-06-11 00:09:42 -07:00
Carsten "Tomcat" Book
8a1350b5a6 Backed out changeset 4f6302a98ae4 (bug 1372405)
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey
6b3e84ed5f Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
ea1b86680c Backed out changeset 9846de3bd954 (bug 1372405)
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey
4592152411 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Nils Ohlmeier [:drno]
948bfcc4f7 Bug 969715: remove INET and INET6 from sctp build env. r=jesup
MozReview-Commit-ID: 4e67tOzltoc

--HG--
extra : rebase_source : c0c134bde1b0400b3fc37aaada0187948442e9cb
2016-12-08 23:49:43 -10:00
Mike Hommey
34e619d1c1 Bug 1357323 - Remove support for gonk in the build system. r=gps
Everything depending on the widget being gonk can go away, as well as
everything depending on MOZ_AUDIO_CHANNEL_MANAGER, which was only
defined on gonk builds under b2g/ (which goes away in bug 1357326).

--HG--
extra : rebase_source : 9f0aeeb7eea8417fa4e06d662d566d67ecaf2a24
2017-04-18 16:56:09 +09:00
Michael Froman
1a2153bf46 Bug 1353575 - Switch to google stun server instead of twilio for ice_unittest.cpp. r=bwc,drno
MozReview-Commit-ID: HrS3oKjg17Z

--HG--
extra : rebase_source : a4a40bb9a5694054d736cabc7ff22b57037f6487
2017-04-04 13:47:54 -05:00
Michael Froman
032f9ca0bc Bug 1345511 - pt 1 - nICEr changes to support stun addr gathering from main process. r=bwc
Expose a tweaked version of nr_ice_get_local_addresses to allow callers to
provide pre-fetched stun addrs if they are available.  By default, the normal
call to nr_ice_gather calls this with no pre-fetched stun addrs (read
non-e10s).  In e10s, the stun addrs are discovered on the main process and
provided to nr_ice_get_local_addreses.  When nr_ice_gather is called from
the content process the local addresses have already been gathered.

In the past, nr_ice_get_local_addresses also applied policy (by removing
duplicate addrs, and, based on stun prefs, removing loopback and/or
link_local addrs.  This functionality has been moved to
nr_ice_set_local_addresses where other policy is being applied (like
default route only, forcing specific interfaces, and prioritization).

Because we're now serializing nr_local_addr (wrapped by NrIceStunAddr), we
can't assume that certain pointer references in the source nr_local_addr
are correct when calling nr_local_addr_copy.  New non-pointer-arithmetic
version of setting up the pointer on the copied nr_local_addr is used.  Also
easier to understand when walking up to it the first time.

MozReview-Commit-ID: KVRFl4dfr7J

--HG--
extra : rebase_source : c0437700ad77ee3b7f98947d3505551ca9ed43e9
2017-03-16 12:06:09 -05:00
Byron Campen [:bwc]
42465ae6db Bug 1342523 - Part 1: Clean up how controlling/offerer is specified. r=drno
MozReview-Commit-ID: D8qPAPUZC1J

--HG--
extra : rebase_source : dec5598ee2edd9168bd5c93be222cc409a7db096
2017-02-24 14:05:27 -06:00
Sylvestre Ledru
364ecfb0c7 Bug 1338086 - Remove useless else blocks in order to reduce complexity in media/mtransport/ r=drno
MozReview-Commit-ID: 9Hvf7kGOi2s

--HG--
extra : rebase_source : d7a182a4b6fc02030f3e8d0eb5cbd75c0f5ff117
2017-02-14 15:08:29 +01:00
Byron Campen [:bwc]
e59a5f112e Bug 1336182 - Part 2: Use "override" keyword to silence some warnings about inconsistency. r=drno
MozReview-Commit-ID: 1mVXvIGNBdr

--HG--
extra : rebase_source : 671fd46798807b72ee390cc37f0beae18be3d222
2017-02-06 16:44:14 -06:00
Sylvestre Ledru
24eaa6aa67 Bug 1337358 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in media/mtransport/ r=bwc=jesup
MozReview-Commit-ID: 1ALL9rdhk24

--HG--
extra : rebase_source : c1899accbe87f6d226f8bbd5922b5899362f2e26
2017-02-13 14:42:00 +01:00
srivatsav
74183ba990 Bug 1334265 - Replace double quotation marks with single quotation marks in ice_unittest.cpp. r=jesup
--HG--
extra : rebase_source : 2d90c8cdb8c16455ddedd79a90e05627fa7e599e
2017-02-02 14:42:27 +05:30
Benjamin Smedberg
29c0b37b6c Bug 1329932 - Remove unneeded nsXPCOMGlue includes. r=glandium 2017-01-10 18:40:50 +09:00
Sylvestre Ledru
2e2def32f7 Bug 1324547 - ensure we're not needlessly copying things in ranged for loop r=froydnj
MozReview-Commit-ID: 2NnjjmANem5

--HG--
extra : rebase_source : 4387ede40b6726b4a879b57e31f8428784f0bfc7
2016-12-21 18:05:50 +01:00
Nils Ohlmeier [:drno]
2ca25c39f6 Bug 1318180: turn network offline events into ice disconnected event. r=bwc,jib
MozReview-Commit-ID: Kqbicl2goL2

--HG--
extra : rebase_source : 4ed7d1364af8bd1575e2ced1bd8512405e0dd669
2016-11-17 23:16:33 -08:00
Randell Jesup
ac570b16c4 Bug 1250356: rollup of changes for webrtc after applying webrtc.org v49 update r=pkerr,ng,pehrsons,etc
See ssh://hg.mozilla.org/users/paulrkerr_gmail.com/webrtc49_merge/ for the
patch development history.
2016-12-27 19:41:02 -05:00
Nils Ohlmeier [:drno]
d933579cce Bug 852665: add support for ICE disconnected state. r=bwc
MozReview-Commit-ID: 5ONTc2Wz72O

--HG--
extra : rebase_source : 4f99ebbd4fa0e566965f94dc7b5d999bbbfd7b85
2016-10-28 22:22:17 -07:00
Nils Ohlmeier [:drno]
ecd5c4c6b9 Bug 1309129: enable redirecting of nICEr logging to NSPR logging. r=bwc
MozReview-Commit-ID: ESB6F0MlKdQ

--HG--
rename : media/mtransport/rlogringbuffer.cpp => media/mtransport/rlogconnector.cpp
rename : media/mtransport/rlogringbuffer.h => media/mtransport/rlogconnector.h
rename : media/mtransport/test/rlogringbuffer_unittest.cpp => media/mtransport/test/rlogconnector_unittest.cpp
extra : rebase_source : 33ea6c07b909c1972a2e9150241536ba56890609
2016-10-11 00:17:26 -07:00