This implements Victoria's suggestion for improving highlight line visibility.
Differential Revision: https://phabricator.services.mozilla.com/D34372
--HG--
extra : moz-landing-system : lando
In the regular webconsole input, on Enter, we check that the
input is a compilable unit, so the user don't accidentally
execute an incomplete snippet.
In the editor mode, the user will have to use Ctrl/Cmd + Enter to
execute, so we don't have to worry about Enter (it will simply
append a new line).
And since the user might deal with a large number of characters,
we don't want to prevent them to execute. If it's malformed, they
will get an error in the output and can fix their input easily, since
it wasn't cleared.
The patch adds a test to ensure this work as expected.
Differential Revision: https://phabricator.services.mozilla.com/D34522
--HG--
extra : moz-landing-system : lando
We put some objects on the InactivePropertyHelper (node, rule),
but never reset those properties, which was causing leaks in some
inspector tests.
This patch adds a unselect function that clears all the references
added in the select function.
Differential Revision: https://phabricator.services.mozilla.com/D34844
--HG--
extra : moz-landing-system : lando
The inactive CSS feature is only enabled in Nightly at
the moment, which is what's causing the test to fail
on beta simulation.
Forcing the pref to true in the test should fix the issue.
Differential Revision: https://phabricator.services.mozilla.com/D34847
--HG--
extra : moz-landing-system : lando
This test was failing due to the tab closing before a response from the tab was recieved.
It is due to the threadClient closing more quickly. This waits for the last message before closing
Differential Revision: https://phabricator.services.mozilla.com/D32718
--HG--
extra : moz-landing-system : lando
this test was failing because the threadClient was posting messages due to being unable to
find the source map. After investigating, I found that the sourcemap was formatted incorrectly. I do
not know if this was intentional. If it wasn't this fix works. If it was, then we need to find a way
to wait on source map failures, and the test name might need to be updated
Differential Revision: https://phabricator.services.mozilla.com/D32715
--HG--
extra : moz-landing-system : lando
There was an issue where this test was timing out, and due to the way it was written it was
very hard to identify where -- there were many nested promises. I rewrote the test in order to
identify the time out.
Differential Revision: https://phabricator.services.mozilla.com/D32714
--HG--
extra : moz-landing-system : lando
the test `browser_net_params_sorted` may not have been functioning for some time. While
investigating this, I discovered that we were getting an empty array for `actualKeys`. Iterating
over this array returned immediately. As a result the test always passed, even though the shape of
the data changed. I updated this code so that it waits for the dom to be populated with the number
of keys expected. I also updated the test to reflect the data the front end has today.
Differential Revision: https://phabricator.services.mozilla.com/D32713
--HG--
extra : moz-landing-system : lando
There were a few miscellaneous situations in which the test would fail due to a hanging
request. These tests passed in the past because the old way of using the threadActor did not
identify which requests had been responded to.
Differential Revision: https://phabricator.services.mozilla.com/D32711
--HG--
extra : moz-landing-system : lando
In the layout panel of the inspector, in the flex part, change color of min and max properties.
Change the min/max labels, and lock icon color of the flex outline box to the same color too.
Differential Revision: https://phabricator.services.mozilla.com/D33835
--HG--
extra : moz-landing-system : lando
If logpoint throws, set `level` to "error".
Add tests to ensure the correct level is set.
Demo function: https://luxuriant-system.glitch.me/
Add some logpoints. The first two statements are invalid. The third one is valid.
{F1311386}
In console:
{F1311387}
Differential Revision: https://phabricator.services.mozilla.com/D31157
--HG--
extra : moz-landing-system : lando
This should make the test more managable as we add properties
validators in InactivePropertyHelper.
eslint doesn't support dynamic import yet, so we have to ignore
the test file.
Differential Revision: https://phabricator.services.mozilla.com/D34677
--HG--
rename : devtools/server/tests/mochitest/test_inspector-inactive-property-helper.html => devtools/server/tests/mochitest/inactive-property-helper/gap.js
rename : devtools/server/tests/mochitest/test_inspector-inactive-property-helper.html => devtools/server/tests/mochitest/inactive-property-helper/max-min-width-height.js
rename : devtools/server/tests/mochitest/test_inspector-inactive-property-helper.html => devtools/server/tests/mochitest/inactive-property-helper/vertical-align.js
extra : moz-landing-system : lando
Added proper plural form to editor.searchResults and sourceSearch.resultsSummary1. Updated the comments and IDs for the new strings as well. Replaced all instances of old string references with new string references.
Differential Revision: https://phabricator.services.mozilla.com/D32881
--HG--
extra : moz-landing-system : lando
This allows to have more meaningful warning group messages, i.e.
"Content Blocking" is turned into something like "The resource at
'<URL>' was blocked because content blocking is enabled".
This is done by parsing the message of the first warning to put
in the group, and replacing the URL with a generic placeholder.
We take this as an opportunity to decouple content blocked messages
and storage access blocked ones, as they have slightly different
meanings and consequences.
Tests are updated to match the new labels, and a new test is
added to make sure that we can have multiple warning group in a
single "page navigation" session.
Differential Revision: https://phabricator.services.mozilla.com/D34339
--HG--
extra : moz-landing-system : lando
Hitting Ctrl+ArrowRight didn't have any effect on windows/linux.
The patch fixes this and add a test to make sure a user can
navigate from word to word using Ctrl (or Alt on OSX) and
Arrow Left/Right keys.
Differential Revision: https://phabricator.services.mozilla.com/D34312
--HG--
extra : moz-landing-system : lando
Element.nodeName is usually all-caps, and we were testing lower cased version,
which brought erroneous results.
The test wasn't picking those errors because we were creating the element from
a XHTML document, where Element.nodeName keep the casing used for their creation.
The test is modified to deal with an HTML document instead.
After the test was modified, I could see it was failing, and was then able to
do the actual feature fix.
Differential Revision: https://phabricator.services.mozilla.com/D34149
--HG--
rename : devtools/server/tests/browser/browser_inspector-inactive-property-helper.js => devtools/server/tests/mochitest/test_inspector-inactive-property-helper.html
extra : moz-landing-system : lando
Indicate in the infobar highlighter if the element is of kind grid or flex, and if it is a container or an item.
Differential Revision: https://phabricator.services.mozilla.com/D29964
--HG--
extra : moz-landing-system : lando
This patch adds a componentDidCatch handler to the Message component
so we don't crash the whole console when a message can't be rendered.
When a message causes a crash, we display an error message instead,
asking the user to file a bug. A button allow to copy the message data
so it can be attached in the bug report.
Differential Revision: https://phabricator.services.mozilla.com/D31195
--HG--
extra : moz-landing-system : lando
This makes the console code more consistent, and adds the
nice benefit of being able to check if the layout should
be modified when performing non-window-resize events that
might still impact the layout (sidebar toggle, sidebar
resizing, ...).
Differential Revision: https://phabricator.services.mozilla.com/D27668
--HG--
extra : moz-landing-system : lando
Set a minimum width on the filter bar of the Devtools Console window. When there is enough empty space
to the right of the filterbar, allow the filter buttons to be desplaying inline, rather than on their own
separate row.
Differential Revision: https://phabricator.services.mozilla.com/D20188
--HG--
extra : moz-landing-system : lando
This patch adds a componentDidCatch handler to the Message component
so we don't crash the whole console when a message can't be rendered.
When a message causes a crash, we display an error message instead,
asking the user to file a bug. A button allow to copy the message data
so it can be attached in the bug report.
Differential Revision: https://phabricator.services.mozilla.com/D31195
--HG--
extra : moz-landing-system : lando
Follow-up to [Bug 1093953](https://bugzilla.mozilla.org/show_bug.cgi?id=1093953) which introduced a generalized `payload` object for messages to be populated asynchronously with additional data associated with the message after it is initially received.
The reasoning is: messages can have arbitrary data payload associated with them. The rendering component for the message type will consume and validate that payload data.
Here, we replace the specialized messageTableDataByID with the generalized messagePayloadByID, update corresponding Redux actions, reducers, selectors and tests.
The only place where `tableData` is used is in the `ConsoleApiCall` message type, in the `ConsoleTable` component. We replace it with `payload` which is sent down to all message types anyway.
Differential Revision: https://phabricator.services.mozilla.com/D33975
--HG--
extra : moz-landing-system : lando
This is done so the user has a choice what kind of audit to run or what kind of audit type to filter the accessibility tree by
Differential Revision: https://phabricator.services.mozilla.com/D33183
--HG--
extra : moz-landing-system : lando
### Changes
#### Set 1 - Match cookie creation strings, remove "on" and capitalize.
- Expires on {icon long-arrow-right} Expires
- Last accessed on {icon long-arrow-right} Last accessed
- Created on {icon long-arrow-right} Created
- sameSite {icon long-arrow-right} SameSite
#### Set 2 - Re-add missing strings
- table.headers.cookies.isHttpOnly=HttpOnly
- table.headers.cookies.isSecure=Secure
- table.headers.cookies.hostOnly=HostOnly
Differential Revision: https://phabricator.services.mozilla.com/D33041
--HG--
extra : moz-landing-system : lando
Currently, if the autocomplete preference is set to false, and the user
displays the autocomplete popup with Ctrl + Space, typing other letters
won't filter the popup, which feels very weird.
This patch fixes this behaviour.
Differential Revision: https://phabricator.services.mozilla.com/D28597
--HG--
extra : moz-landing-system : lando
This patch addresses bug 888161 by adding a ‘Download File’ option to the context menu of individual source tree item files.
Differential Revision: https://phabricator.services.mozilla.com/D32828
--HG--
extra : moz-landing-system : lando
It can happen that the string we receive is quite large
and as a result takes a long time to analyze, freezing
the process.
This patch simply tracks for how long the for loop is running,
and bail out if it's greater than a given time (set to 2500 ms
for now).
This is mostly a safeguard, a future patch should try to improve
the performance of the function itself.
Differential Revision: https://phabricator.services.mozilla.com/D33791
--HG--
extra : moz-landing-system : lando
The current “go to line” keyboard shortcut `CmdOrCtrl+;` conflicts with the “step in” shortcut. The "go to line" shortcut is replaced with the shortcut for Chrome debugger and Sublime Text: `Ctrl+G`. Upper or lower cases don’t matter.
1. Current behavior:
1a) With no file open in editor; or with a file open in editor, but not pausing at a breakpoint:
`Cmd+;` or `Cmd+Shift+;` opens the “go to line” box.
1b) Pause at a breakpoint:
`Cmd+;` runs `step in`, and also opens the “go to line” box;
`Cmd+Shift+;` runs `step over`, and also opens the “go to line” box.
2) Code changes:
2a) Create gotoLineModal.key3.
2b) Update localization note.
2b) Update snapshot test.
3) After the code changes, on macOS:
3a) With no file open in editor:
`Ctrl+G` opens the “go to line” box.
3b) With a file open, but not pausing at breakpoints:
`Ctrl+G`opens the “go to line” box; hitting `Ctrl+G` again or `escape` closes the box.
3c) Pause at a breakpoint:
`Cmd+;` or `Cmd+Shift+;` doesn’t open the “go to line” box.
`Ctrl+G` opens the “go to line” box.
Differential Revision: https://phabricator.services.mozilla.com/D26256
--HG--
extra : moz-landing-system : lando
This introduce a new form of invalid messages. Until now, all the
messages were like "X has no effect on this since it's not Y".
But in this case, the width/height properties applies to all but
a few cases, which means we can't really keep the same shape of
message (or it would be "since it's not A, B, C, D, ...).
So we're switching to a message that prints the display property
of the element ("X has no effect on this element since it has a
display of Y").
In order to do that, we need to pipe the element computed display
into the inactive tooltip.
Differential Revision: https://phabricator.services.mozilla.com/D32805
--HG--
extra : moz-landing-system : lando
support for from-font listed in the CSS spec will be implemented in a later bug
Differential Revision: https://phabricator.services.mozilla.com/D33233
--HG--
extra : moz-landing-system : lando
Depends on D32867
Reference the shared list of pseudo-elements throughout the codebase:
- markup view context menu + test
- Rule editor
- box model highlighter
- node actor
- new Rules view
Differential Revision: https://phabricator.services.mozilla.com/D32868
--HG--
extra : moz-landing-system : lando
- Removes the hardcoded references from `index.xhtml` and `rules.js` and uses a centralized list of pseudo-classes to generate the checkboxes for the supported pseudo-class locks at runtime.
- Streamlines the handling for pseudo-class locks state. Fixes Bug 1536676 as a side-effect.
- Updates tests.
Differential Revision: https://phabricator.services.mozilla.com/D32867
--HG--
extra : moz-landing-system : lando
support for from-font listed in the CSS spec will be implemented in a later bug
Differential Revision: https://phabricator.services.mozilla.com/D33233
--HG--
extra : moz-landing-system : lando
They're not used internally either, so remove all ability to address them.
I haven't removed the implementation yet, as some of them are quite complex, and
I don't have a mac / windows build. We should do that when this hits release
though.
Differential Revision: https://phabricator.services.mozilla.com/D32488
--HG--
extra : moz-landing-system : lando
We also listen for the warningGroup preference change to
toggle warningGroups in the console output.
If warningGroups were disabled, we need to loop through
the state messages to create warningGroups when needed.
A test is added to ensure this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D32716
--HG--
extra : moz-landing-system : lando
We move the observer declaration closest to where the store is created
so we can dispatched action more easily.
We put all the observers in a Map so we can remove them easily when
destroying the console panel.
Differential Revision: https://phabricator.services.mozilla.com/D31591
--HG--
extra : moz-landing-system : lando
Since isPropertyUsed takes an HTMLElement and its computed style, we
need to have access to the DOM, and can't use an xpcshell test.
Differential Revision: https://phabricator.services.mozilla.com/D33454
--HG--
extra : moz-landing-system : lando
When hovering from the preview of tokenA back to tokenA, the preview shouldn't unrender and the rerender.
Before:
{F1318568}
After:
{F1318569}
Differential Revision: https://phabricator.services.mozilla.com/D31899
--HG--
extra : moz-landing-system : lando
