Commit Graph

4348 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
d05b1727e9 Bug 1800979 - Mark CSS image value loads as not cancelable. r=tnikkel
Yes, the test took 15 times as much as the fix.

Differential Revision: https://phabricator.services.mozilla.com/D162474
2022-11-20 00:22:20 +00:00
Daniel Holbert
7f83cbcfba Bug 1800342: Make NS_NewPipe2 and NS_NewPipe infallible, to reflect reality. r=xpcom-reviewers,necko-reviewers,nika,kershaw
This patch doesn't change behavior; these APIs were already effectively
infallible, in the sense that it was impossible for them to return anything
other than NS_OK.

The actual API changes here are in xpcom/io/nsIPipe.idl and
xpcom/io/nsPipe3.cpp, and the rest of this patch is just updates to callsites,
removing code that handled failure-flavored return values from these functions.
(All of this removed code was already dead code, effectively.)

Differential Revision: https://phabricator.services.mozilla.com/D161947
2022-11-14 23:22:16 +00:00
Brad Werth
987a61fc5c Bug 1798532 Part 3: Allow JPEGDecoder to handle frame data in the footer. r=tnikkel
This also modifies red-bad-marker.jpg to add a SOF6 marker (0xFFC6) in the
footer.

Differential Revision: https://phabricator.services.mozilla.com/D161637
2022-11-09 17:01:35 +00:00
Brad Werth
11d3c18e08 Bug 1798532 Part 2: Test display of a JPEG with 0xb6 markers. r=tnikkel
This has been edited to add one 0xb6 marker after the header, and one
after the end of image marker.

Depends on D161187

Differential Revision: https://phabricator.services.mozilla.com/D161332
2022-11-07 22:20:36 +00:00
Brad Werth
cbb5bf5c93 Bug 1798532 Part 1: Ignore JPEG unknown markers. r=tnikkel
This will push through any unknown marker errors from libjpeg, but still
fail for other errors. Dropping markers prevents infinite loops in processing.

Differential Revision: https://phabricator.services.mozilla.com/D161187
2022-11-07 22:20:36 +00:00
Razvan Cojocaru
1629218702 Bug 1060421 - Change the type of [Int]PointTyped::[x|y] back to [Int]CoordTyped. r=botond
[Int]CoordTyped no longer inherits Units because otherwise
instances of [Int]IntPointTyped may get one Base subobject because
it inherits Units, and others because of BasePoint's Coord members,
which end up increasing the [Int]CoordTyped's objects size (since
according to the ISO C++ standard, different Base subobject are
required to have different addresses).

Differential Revision: https://phabricator.services.mozilla.com/D160713
2022-11-04 18:29:35 +00:00
Jens Stutte
a71d351e3b Bug 1797688 - Part 6: Substitute gXPCOMThreadsShutDown with InOrBeyond(XPCOMShutdownFinal) in SurfaceCacheImpl. r=xpcom-reviewers,mccr8
To release the images, `ClearReleasingImages` basically takes all the `RefPtr<Image>` out of `mReleasingImagesOnMainThread` under a lock and then clears them, all on the main thread. This can be safely done before as late as XPCOMShutdownFinal on the main thread in order to avoid leaks.

Differential Revision: https://phabricator.services.mozilla.com/D160624
2022-11-01 14:08:45 +00:00
Jens Stutte
c9e6f9840c Bug 1797688 - Part 5: Substitute gXPCOMThreadsShutDown with InOrBeyond(XPCOMShutdownThreads) in ProgressTracker::RemoveObserver. r=xpcom-reviewers,mccr8,tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D160623
2022-11-01 14:08:44 +00:00
Jens Stutte
81a4773b22 Bug 1797688 - Part 4: Bail out from IDecodingTask::NotifyProgress and NotifyDecodeComplete InOrBeyond(XPCOMShutdownThreads). r=xpcom-reviewers,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D160622
2022-11-01 14:08:44 +00:00
Andrew Osmond
9d245b8325 Bug 1794722 - Part 2. Remove all uses of gfxVars::UseWebRender(). r=jrmuizel,media-playback-reviewers,alwu
This is always true.

Differential Revision: https://phabricator.services.mozilla.com/D160121
2022-10-28 12:36:06 +00:00
Cristian Tuns
1303ee58d8 Backed out 3 changesets (bug 1794722) for causing multiple failures on RemoteProcessMonitor CLOSED TREE
Backed out changeset 0217af5b1aa6 (bug 1794722)
Backed out changeset d7805be9dfb3 (bug 1794722)
Backed out changeset 0093f071f1a5 (bug 1794722)
2022-10-27 20:52:36 -04:00
Andrew Osmond
93abf26cbc Bug 1794722 - Part 2. Remove all uses of gfxVars::UseWebRender(). r=jrmuizel,media-playback-reviewers,alwu
This is always true.

Differential Revision: https://phabricator.services.mozilla.com/D160121
2022-10-28 00:08:03 +00:00
Timothy Nikkel
19b7441082 Bug 1794754. Return NEED_MORE_DATA from nsWebPDecoder::ReadHeader if ICC was specified but chunk not found r=aosmond
Bug 1780834 caused this bug. If we are not complete then we might need to
wait for more data to come in that has the ICCP chunk.

Differential Revision: https://phabricator.services.mozilla.com/D159137
2022-10-20 07:53:25 +00:00
Timothy Nikkel
b06cb79c08 Bug 1795779. Don't call TimeStamp::Now for the profiler every time an image is drawn if the profiler isn't active. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D159554
2022-10-18 06:57:13 +00:00
Kershaw Chang
278e75d974 Bug 1794766 - Use CancelWithReason in imgRequest and nsLoadGroup, r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D159148
2022-10-13 08:54:12 +00:00
Masatoshi Kimura
a6888b17a9 Bug 327074 - Allow RLE bitmaps with extra pixels per row to render. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D159028
2022-10-12 03:58:32 +00:00
Brad Werth
949fa28f4f Bug 1765187 Part 1: Track color primaries independently from coefficients. r=media-playback-reviewers,jgilbert,alwu
This patch attempts to read color primary information from platform
agnostic decoders. It doesn't use any of this information to change how
the video frame is displayed.

It also cleans up some VPX transfer characteristics, to ensure they are
actually retrieved from the codec information, when available.

Differential Revision: https://phabricator.services.mozilla.com/D156362
2022-10-10 20:12:58 +00:00
Chun-Min Chang
c3449a3361 Bug 1774300 - Implement VideoFrame Constructor for I420A ArrayBuffer* r=padenot,jgilbert
This patch allows constructing a VideoFrame from the ArrayBuffer* in
I420A format, which contains the I420 data with an extra alpha channel
data.

Depends on D149584

Differential Revision: https://phabricator.services.mozilla.com/D149943
2022-10-06 00:37:22 +00:00
Butkovits Atila
dd8f948670 Backed out 19 changesets (bug 1793497, bug 1774300) for causing lint failure. CLOSED TREE
Backed out changeset f5460317d244 (bug 1793497)
Backed out changeset 5af8771526a1 (bug 1774300)
Backed out changeset 3ab7aead37b5 (bug 1774300)
Backed out changeset 5f837d7e621b (bug 1774300)
Backed out changeset 56bfa6480cb5 (bug 1774300)
Backed out changeset db37fffc8519 (bug 1774300)
Backed out changeset d5d263cedbc9 (bug 1774300)
Backed out changeset 52fdd5a613f4 (bug 1774300)
Backed out changeset 6ce76e0d6fd2 (bug 1774300)
Backed out changeset c5f67f22597e (bug 1774300)
Backed out changeset 4a7dca31703e (bug 1774300)
Backed out changeset e56596b91a86 (bug 1774300)
Backed out changeset 825ae6e7be9b (bug 1774300)
Backed out changeset 19f750d86a73 (bug 1774300)
Backed out changeset 50995e55c546 (bug 1774300)
Backed out changeset 33b150b4c911 (bug 1774300)
Backed out changeset 2bc06d0e8808 (bug 1774300)
Backed out changeset ba9bc5c631b0 (bug 1774300)
Backed out changeset 4a145bdd6b86 (bug 1774300)
2022-10-05 01:05:57 +03:00
Chun-Min Chang
c4b771507e Bug 1774300 - Implement VideoFrame Constructor for I420A ArrayBuffer* r=padenot,jgilbert
This patch allows constructing a VideoFrame from the ArrayBuffer* in
I420A format, which contains the I420 data with an extra alpha channel
data.

Depends on D149584

Differential Revision: https://phabricator.services.mozilla.com/D149943
2022-10-04 21:38:26 +00:00
Mark Banner
226c0dffea Bug 1792861 - Fix ESLint no-unused-vars issues on global scopes in image/test. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D158346
2022-10-01 09:03:11 +00:00
Andrew McCreight
2da84b8ac4 Bug 1792574, part 3 - Don't include nsMemory where it isn't needed. r=xpcom-reviewers,necko-reviewers,valentin,nika
There are only 3 places where nsMemory.h is still needed (image/RasterImage.cpp,
gfx/thebes/gfxFT2FontList.cpp, and nsMemory.cpp). Remove the rest.

Differential Revision: https://phabricator.services.mozilla.com/D158213
2022-09-28 15:17:46 +00:00
Emilio Cobos Álvarez
4ec1be44bb Bug 1792435 - Fix triggering principal set-up for static image requests. r=dlrobertson
That is, for printing. Those don't have an owning request, see the
comment on the image principal code.

Differential Revision: https://phabricator.services.mozilla.com/D158193
2022-09-28 03:56:58 +00:00
Dan Robertson
2eb1b8240a Bug 1655598 - Cross origin image request should not respect image orientation. r=emilio
A cross origin image request should not respect the given style image
orientation, but should use any image orientation provided by the image.

Differential Revision: https://phabricator.services.mozilla.com/D156919
2022-09-28 03:56:57 +00:00
Dan Robertson
b7b30e5a1d Bug 1655598 - The imgIRequest uri attribute should be infallible. r=emilio
The implementation of GetURI always returns NS_OK, and therefore the URI can
be marked as infallible.

Differential Revision: https://phabricator.services.mozilla.com/D157009
2022-09-28 03:56:57 +00:00
Butkovits Atila
d45dd05bf4 Backed out 2 changesets (bug 1655598) for causing Bug 1792435. a=backout
Backed out changeset 9eb3b3e7295b (bug 1655598)
Backed out changeset 052c6f05c623 (bug 1655598)
2022-09-27 12:37:10 +03:00
Dan Robertson
607672e1b4 Bug 1655598 - Cross origin image request should not respect image orientation. r=emilio
A cross origin image request should not respect the given style image
orientation, but should use any image orientation provided by the image.

Differential Revision: https://phabricator.services.mozilla.com/D156919
2022-09-25 00:07:56 +00:00
Dan Robertson
6b7a505d18 Bug 1655598 - The imgIRequest uri attribute should be infallible. r=emilio
The implementation of GetURI always returns NS_OK, and therefore the URI can
be marked as infallible.

Differential Revision: https://phabricator.services.mozilla.com/D157009
2022-09-25 00:07:55 +00:00
Dana Keeler
923d7b2029 Bug 1790451 - make nsIChannel.securityInfo concrete as nsITransportSecurityInfo r=kershaw,necko-reviewers,valentin,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D157136
2022-09-20 03:58:49 +00:00
Nika Layzell
0316dc51b9 Bug 1790614 - Part 2: Use {ASSERT,ENSURE}_NS_{SUCCEEEDED,FAILED} in gtests, r=ahal,necko-reviewers
These macros will produce better outputs when they fail than these existing
patterns using `ENSURE_TRUE(NS_SUCCEEDED(...))` or similar, so this is a bulk
rewrite of existing tests to use them.

It should also help with discoverability when people base their tests off of
other existing tests.

Differential Revision: https://phabricator.services.mozilla.com/D157214
2022-09-15 14:51:50 +00:00
Nika Layzell
449e73f1c7 Bug 1348272 - Mark nsIInputStream and nsIOutputStream as builtinclass, r=xpcom-reviewers,necko-reviewers,barret,valentin
Differential Revision: https://phabricator.services.mozilla.com/D156893
2022-09-09 18:22:36 +00:00
Marian-Vasile Laza
78b100abc0 Backed out changeset 10ea141649b6 (bug 1348272) for causing mochitest failures on test_domparsing.xhtml. CLOSED TREE 2022-09-09 19:21:48 +03:00
Nika Layzell
b24f79de71 Bug 1348272 - Mark nsIInputStream and nsIOutputStream as builtinclass, r=xpcom-reviewers,necko-reviewers,barret,valentin
Differential Revision: https://phabricator.services.mozilla.com/D156893
2022-09-09 13:29:30 +00:00
Kershaw Chang
d164608d66 Bug 1760580 - P2: Provide a reason when request is cancelled with NS_BINDING_ABORTED, r=necko-reviewers,media-playback-reviewers,valentin,chunmin
Differential Revision: https://phabricator.services.mozilla.com/D156071
2022-09-08 09:11:19 +00:00
Kershaw Chang
cc6c147f88 Bug 1760580 - P1: Make nsIRequest support to store canceled reason, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D156070
2022-09-08 09:11:18 +00:00
Timothy Nikkel
31d2695f81 Bug 1786818. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D155462
2022-09-08 03:29:36 +00:00
Mark Banner
3644b07dd2 Bug 1786197 - Turn on ESLint rule for prefer-boolean-length-check for a few test files. r=mossop
This also moves the layout disabling to the layout section - to be enabled later.

Differential Revision: https://phabricator.services.mozilla.com/D155177
2022-08-26 13:39:39 +00:00
Timothy Nikkel
ad4d2d61f1 Bug 1784835. Use checkedint in webp encoder to avoid overflow. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D154622
2022-08-23 08:42:49 +00:00
Emilio Cobos Álvarez
645b3eb6fd Bug 1782595 - Use the preferred color-scheme to propagate to SVG images. r=tnikkel
We have tests for the explicit color-scheme in the WPT, and testing this
properly needs prefs to switch the light/dark preference so tests can't
go there.

Undoing https://hg.mozilla.org/integration/autoland/rev/f31efc2a9229
should be enough to cover the difference between preferred and used
color-scheme.

Depends on D154923

Differential Revision: https://phabricator.services.mozilla.com/D154924
2022-08-18 15:49:52 +00:00
Andi-Bogdan Postelnicu
eeac3728d2 Bug 1519636 - Reformat recent changes to the Google coding style. r=glandium
Updated with clang-format version 14.0.5 (taskcluster-DydCt-ryTuKvBYw1HQOugw)
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D154661
2022-08-16 07:08:27 +00:00
Timothy Nikkel
30b8b1b093 Bug 1782877. Encoding webp with quality 100 should use lossless. r=aosmond
Chrome and Safari do, and it makes sense.

Differential Revision: https://phabricator.services.mozilla.com/D153578
2022-08-12 23:15:38 +00:00
Mike Hommey
99d04c97e8 Bug 1784205 - Avoid returning SIID_INVALID as a SHSTOCKICONID because it's not part of the enum. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D154355
2022-08-11 08:26:53 +00:00
Fabrice Desré
c50cb528fc Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-03 16:39:41 +00:00
Andreea Pavel
3ccd75af8d Backed out changeset b9d2965591b9 (bug 1761040) for landing with wrong author CLOSED TREE DONTBUILD 2022-08-03 18:55:00 +03:00
Andreea Pavel
fdb7cb2ecd Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-03 15:27:43 +00:00
Mark Banner
7428be4a86 Bug 1782008 - Remove now unnecessary .eslintrc.js files. r=webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,denschub,rpl,alwu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D152736
2022-08-03 11:16:20 +00:00
Andreea Pavel
89d63c91e6 Backed out changeset a907159a482f (bug 1761040) for causing build bustages on a CLOSED TREE 2022-08-02 04:59:08 +03:00
Fabrice Desré
0f4ac7ad97 Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-02 00:49:41 +00:00
Timothy Nikkel
b5a9365200 Bug 1780834. If a webp file header specifies ICCP but no ICCP chunk is found just ignore it and continue. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D152588
2022-07-26 08:24:27 +00:00
Emilio Cobos Álvarez
42b7f1a58c Bug 1780788 - Use abstract strings as in-arguments for ipdl. r=nika,necko-reviewers,media-playback-reviewers,alwu,dragana
This prevents copies and avoids the hack we have to avoid this, which
right now is using nsDependent{C,}String.

Non-virtual actors can still use `nsString` if they need to on the
receiving end.

Differential Revision: https://phabricator.services.mozilla.com/D152519
2022-07-25 20:19:48 +00:00