Commit Graph

3018 Commits

Author SHA1 Message Date
Michael Layzell
c47fca1cd7 Bug 1018486 - Part 1: Changes in dom/, r=baku
MozReview-Commit-ID: 4tCUM4KRe81
2016-09-07 10:50:35 -04:00
Shawn Huang
ba9fa0d68a Bug 1267941 - Implement Storage API estimate() feature, r=janv,baku 2016-06-14 13:57:36 +01:00
Nicholas Nethercote
34dcc7b852 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");

--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
Andrea Marchesini
4dedbcc6f2 Bug 1300655 - part 2 - WorkerProxyToMainThreadRunnable::PostDispatchOnMainThread::ReleaseRunnable should implement Cancel() correctly, r=me 2016-09-06 04:48:11 +02:00
Andrea Marchesini
f4227c1a5c Bug 1300655 - WorkerProxyToMainThreadRunnable::PostDispatchOnMainThread::ReleaseRunnable should implement Cancel() correctly, r=bkelly 2016-09-06 04:35:49 +02:00
Andrea Marchesini
1738225353 Bug 1297472 - Improve nsIScriptTimeoutHandler::GetHandlerText(), r=bz 2016-09-05 21:25:13 +02:00
Olli Pettay
8744d0ccf8 Bug 1298661, let meta-stable state runnables run during sync loops, r=baku 2016-09-05 18:54:04 +03:00
Nicholas Nethercote
b71747b2ac Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
The new name makes the sense of the condition much clearer. E.g. compare:

  NS_WARN_IF_FALSE(!rv.Failed());

with:

  NS_WARNING_ASSERTION(!rv.Failed());

The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.

--HG--
extra : rebase_source : 886e57a9e433e0cb6ed635cc075b34b7ebf81853
2016-09-01 15:01:16 +10:00
Nicholas Nethercote
819433bae0 Bug 1299389 - Replace some raw pointers in nsThreadManager. r=froydnj.
nsThreadManager::get() can return a reference. This lets us remove some
redundant assertions.

nsThreadArray elements can be NotNull<>s.

--HG--
extra : rebase_source : fd49010167101bc15f7f6d01bf95fd63b81d60fb
2016-06-10 16:04:49 +10:00
Gabriele Svelto
fe73634c76 Bug 1296579 - Remove the SimplePush API r=kitcambridge,baku 2016-09-01 20:17:03 +02:00
Andrea Marchesini
e8d47ac312 Bug 790919 - Don't dispatch close event in Workers, r=bkelly 2016-08-31 21:33:05 -07:00
Boris Zbarsky
29cf04bde6 Bug 986459. The error event in a worker (firing at the worker's global) should have the original exception value in its .error property. r=baku 2016-08-29 12:30:51 -04:00
Luke Wagner
cc5c2c3ffc Bug 1283924 - Implement AsyncTask hooks for worker thread JSContexts (r=bkelly)
MozReview-Commit-ID: CU4tiYaREik

--HG--
extra : rebase_source : 35a1017de6844af78ec124ef84f355727f19cd80
2016-08-19 14:00:53 -05:00
Nicholas Nethercote
c2306345d5 Bug 1297658 - Avoid unnecessary checking in memory reporters. r=erahm.
This patch removes checking of all the callback calls in memory reporter
CollectReport() functions, because it's not useful.

The patch also does some associated clean-up.

- Replaces some uses of nsIMemoryReporterCallback with the preferred
  nsIHandleReportCallback typedef.

- Replaces aCallback/aCb/aClosure with aHandleRepor/aData for CollectReports()
  parameter names, for consistency.

- Adds MOZ_MUST_USE/[must_use] in a few places in nsIMemoryReporter.idl.

- Uses the MOZ_COLLECT_REPORT macro in all suitable places.

Overall the patch reduces code size by ~300 lines and reduces the size of
libxul by about 37 KiB on my Linux64 builds.

--HG--
extra : rebase_source : e94323614bd10463a0c5134a7276238a7ca1cf23
2016-08-24 15:23:45 +10:00
Kan-Ru Chen
b6d880aca1 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES


--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
Wes Kocher
b38dbd1378 Backed out 2 changesets (bug 1279086) for causing painting issues a=backout
Backed out changeset b1c893387fdd (bug 1279086)
Backed out changeset 277c54118c8a (bug 1279086)
2016-08-22 16:00:34 -07:00
Andrea Marchesini
13c30aacfd Bug 1286895 - Fix a talos regression, r=me 2016-08-22 12:13:15 +02:00
Andrea Marchesini
d3c5cce268 Bug 1286895 - Remove a test for checking the number of created workers, r=me 2016-08-22 12:01:53 +02:00
Andrea Marchesini
3f20309ae8 Bug 1286895 - Reintroduce a limit on number of dedicated JS web workers in Firefox, r=bkelly 2016-08-19 08:38:58 +02:00
Sebastian Hengst
3be5f0ac43 Backed out changeset f4c8b3de527e (bug 1286895) for crashing in test_bug1241485.html. r=backout 2016-08-21 11:31:35 +02:00
Andrea Marchesini
70fd734aff Bug 1286895 - Reintroduce a limit on number of dedicated JS web workers in Firefox, r=bkelly 2016-08-19 08:38:58 +02:00
Andrea Marchesini
db26797edf Bug 1296586 - Fixing some comments in WorkerPrivate, r=smaug 2016-08-21 08:41:34 +02:00
Luke Wagner
44699344bb Backed out changeset b6cf6d7a95f9
MozReview-Commit-ID: JtuQh7USSWX

--HG--
extra : rebase_source : 19e2f58ab5d26e36b24d0d5a80e1805f013f67d5
2016-08-19 17:09:56 -05:00
Bill McCloskey
1613c2cbc9 Bug 1279086 - Allow multiple interrupt callbacks (r=dvander) 2016-08-19 14:40:52 -07:00
Luke Wagner
9003b8a8b4 Bug 1283924 - Implement AsyncTask hooks for worker thread JSContexts (r=bkelly)
MozReview-Commit-ID: F31bzEH5rPR

--HG--
extra : rebase_source : ef27bc3fdc7aae1a5882672a50e0be802dffdf4e
2016-08-19 14:00:53 -05:00
Wes Kocher
3a31be9c17 Backed out 2 changesets (bug 1279086) for failures in browser_menu_item_01.js a=backout
Backed out changeset 00bb53b58e96 (bug 1279086)
Backed out changeset cff59fe2b933 (bug 1279086)
2016-08-19 12:31:55 -07:00
Bill McCloskey
95c5d71549 Bug 1279086 - Allow multiple interrupt callbacks (r=dvander) 2016-08-19 09:59:39 -07:00
Ben Kelly
d935ad2ac3 Bug 1290116 P5 Make navigator.serviceWorker.getRegistrations() ignore uninstalling registrations. r=asuth 2016-08-18 07:12:09 -07:00
Ben Kelly
846726fe4d Bug 1290116 P3 Delay removing registration until active worker is idle. r=asuth 2016-08-18 07:12:09 -07:00
Ben Kelly
1340a14939 Bug 1290116 P2 Clean up ServiceWorkerManager::StopControllingADocument(). r=asuth 2016-08-18 07:12:08 -07:00
Ben Kelly
20caf371e2 Bug 1290116 P1 Expose a ServiceWorkerRegistrationInfo::IsIdle() method. r=asuth 2016-08-18 07:12:08 -07:00
Ben Kelly
da1166fba2 Bug 1293690 P3 Force all callers of HoldWorker to provide an explicit status code that triggers failure. r=baku 2016-08-18 07:11:04 -07:00
Ben Kelly
9d7b33a00b Bug 1293690 P2 Set explicit status levels to fail at when calling WorkerHolder::HoldWorker. r=baku 2016-08-18 07:11:04 -07:00
Ben Kelly
3b1186e9b0 Bug 1293690 P1 Allow WorkerHolder::HoldWorker() callers to specify the status value they consider to be a failure. r=baku 2016-08-18 07:11:04 -07:00
Andrea Marchesini
7481ec0203 Bug 1295980 - Telemetry about the use of SharedWorkers, r=smaug 2016-08-18 08:00:18 +02:00
Phil Ringnalda
4083fafafc Backed out 10 changesets (bug 1290116, bug 1293690) for build bustage
CLOSED TREE

Backed out changeset bbc14d107fca (bug 1290116)
Backed out changeset a81b6ce5c25f (bug 1290116)
Backed out changeset e0b9c25b6125 (bug 1290116)
Backed out changeset 8e9a9ba04ce5 (bug 1290116)
Backed out changeset 2d5ad5e9ed20 (bug 1290116)
Backed out changeset eb7da0dbfc72 (bug 1290116)
Backed out changeset 6a4e8c92faae (bug 1290116)
Backed out changeset 0342d98afa10 (bug 1293690)
Backed out changeset d84b0768f0ce (bug 1293690)
Backed out changeset f9f62ade9508 (bug 1293690)
2016-08-17 21:16:43 -07:00
Ben Kelly
91fe27b9bf Bug 1290116 P5 Make navigator.serviceWorker.getRegistrations() ignore uninstalling registrations. r=asuth 2016-08-17 20:03:21 -07:00
Ben Kelly
a921c723d8 Bug 1290116 P3 Delay removing registration until active worker is idle. r=asuth 2016-08-17 20:03:21 -07:00
Ben Kelly
43fa240037 Bug 1290116 P2 Clean up ServiceWorkerManager::StopControllingADocument(). r=asuth 2016-08-17 20:03:20 -07:00
Ben Kelly
13c8aee898 Bug 1290116 P1 Expose a ServiceWorkerRegistrationInfo::IsIdle() method. r=asuth 2016-08-17 20:03:20 -07:00
Ben Kelly
a33f9a35b3 Bug 1293690 P3 Force all callers of HoldWorker to provide an explicit status code that triggers failure. r=baku 2016-08-17 20:01:35 -07:00
Ben Kelly
fa520e1fdd Bug 1293690 P2 Set explicit status levels to fail at when calling WorkerHolder::HoldWorker. r=baku 2016-08-17 20:01:35 -07:00
Ben Kelly
5f493ecd47 Bug 1293690 P1 Allow WorkerHolder::HoldWorker() callers to specify the status value they consider to be a failure. r=baku 2016-08-17 20:01:35 -07:00
Andrea Marchesini
a183983968 Bug 1264053 - MessagePort should support transferable objects in multi-e10s, r=sfink, r=smaug, r=jorendorff, r=janv 2016-07-21 15:29:42 +02:00
Nicholas Nethercote
a54e0fd248 Bug 1295053 (part 9) - Don't use NS_METHOD for dom/ functions. r=froydnj.
These don't need __stdcall on Win32.

--HG--
extra : rebase_source : 93aa569789dab107137c5493d1c86acc6701329b
2016-08-16 12:12:30 +10:00
Jeff Walden
c07ca36127 Bug 1174386 - Fix a rebase-induced pointer-to-bool conversion error. r=bustage in a CLOSED TREE 2016-08-16 09:08:00 -07:00
Andrea Marchesini
01bf6ba4a1 Bug 1288770 - Switch worker timeouts to using nsJSTimeoutHandler, r=smaug 2016-08-16 08:10:30 +02:00
Arthur Edelstein
215601494b Bug 1174386 - Make workers inherit the default Intl locale from the main thread, rather than using a bogus fallback value. r=jwalden, r=baku
--HG--
extra : rebase_source : 09f66db9914cdf865388669082f3efaca37ce558
2016-08-08 13:33:39 -07:00
Sebastian Hengst
167156e726 Backed out changeset 2d5975fd02bd (bug 1288770) for asserting in ErrorResult.h when test test_errorPropagation.html runs. r=backout 2016-08-16 17:11:22 +02:00
Andrea Marchesini
780f93ea66 Bug 1288770 - Switch worker timeouts to using nsJSTimeoutHandler, r=smaug 2016-08-16 08:10:30 +02:00