Commit Graph

5602 Commits

Author SHA1 Message Date
Marco Bonardo
eb9461aa93 Bug 1508973 - Remove getAnnotationsForItem and unused bookmark annotations APIs. r=Standard8,lina
Differential Revision: https://phabricator.services.mozilla.com/D35009

--HG--
extra : moz-landing-system : lando
2019-06-25 15:21:53 +00:00
Mark Hammond
adf91feaf8 Bug 1538015 (part 2) - restrict when incoming synced prefs are applied. r=tcsc,pauljt,Gijs
Specifically, a "control pref" for a pref must already exist locally, or
a new preference, `services.sync.prefs.dangerously_allow_arbitrary` must
be set to true.

This also removes a few preferences from the set we sync by default based
due to potential harm which can be caused syncing inappropriate values.

Differential Revision: https://phabricator.services.mozilla.com/D29775

--HG--
extra : moz-landing-system : lando
2019-06-25 04:40:58 +00:00
Mark Hammond
e5bb9b8a73 Bug 1538015 (part 1) - test only change to tighten up the checks being made. r=tcsc
This is a test-only change to make the existing synced prefs tests more
explicit about values being checked and moves a couple of prefs around to make
things a bit clearer, which should make the test changes in part 2 clearer.

Differential Revision: https://phabricator.services.mozilla.com/D29774

--HG--
extra : moz-landing-system : lando
2019-06-25 04:40:41 +00:00
Noemi Erli
2e091fbe26 Backed out 2 changesets (bug 1559514) for failures in browser_CTP_plugins.js CLOSED TREE
Backed out changeset 157999f49345 (bug 1559514)
Backed out changeset f31cd670c9ac (bug 1559514)
2019-06-21 02:00:18 +03:00
Mathieu Leplatre
4fcd8eaee9 Bug 1559514 - Emit sync event when up-to-date if JSON dump is loaded r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D35240

--HG--
extra : moz-landing-system : lando
2019-06-20 19:02:31 +00:00
Mathieu Leplatre
5a828c9d6d Bug 1559514 - Emit sync event when JSON dump is loaded from .get() r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D35239

--HG--
extra : moz-landing-system : lando
2019-06-20 20:45:55 +00:00
ffxbld
91d0636848 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D35423

--HG--
extra : moz-landing-system : lando
2019-06-20 15:37:06 +00:00
Mathieu Leplatre
31482b455c Bug 1559114 - Optimize signature verification of Remote Settings dumps r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D34879

--HG--
extra : moz-landing-system : lando
2019-06-18 23:17:50 +00:00
Mathieu Leplatre
1d103e317f Bug 1559114 - Improve debug logging of Remote Settings r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D34878

--HG--
extra : moz-landing-system : lando
2019-06-18 23:17:47 +00:00
ffxbld
b3eeba3ad1 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D35180

--HG--
extra : moz-landing-system : lando
2019-06-17 14:27:42 +00:00
ffxbld
6a9bae1546 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D34868

--HG--
extra : moz-landing-system : lando
2019-06-13 13:48:29 +00:00
Mark Hammond
c36f7aecc7 Bug 1550967 - ensure sync's username pref is set whenever FxA has a user. r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D34309

--HG--
extra : moz-landing-system : lando
2019-06-13 01:32:07 +00:00
Mathieu Leplatre
94be713565 Bug 1558812 - Upgrade kinto-offline-client to 12.4.3 r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D34715

--HG--
extra : moz-landing-system : lando
2019-06-12 14:20:59 +00:00
Boris Zbarsky
9de72a3ac6 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196

--HG--
extra : moz-landing-system : lando
2019-06-11 15:51:51 +00:00
Mathieu Leplatre
a102f01554 Bug 1543598 - Move OneCRL and Pinning blocklist clients out of services r=jcj,glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32297

--HG--
rename : services/common/tests/unit/test_blocklist_onecrl.js => security/manager/ssl/tests/unit/test_blocklist_onecrl.js
rename : services/common/tests/unit/test_blocklist_pinning.js => security/manager/ssl/tests/unit/test_blocklist_pinning.js
extra : moz-landing-system : lando
2019-06-11 10:14:40 +00:00
ffxbld
d70372dc0c No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D34344

--HG--
extra : moz-landing-system : lando
2019-06-10 13:57:19 +00:00
Sebastian Hengst
3f89105d67 Backed out changeset 4f2475241df7 (bug 1550473) on request from ckerschb. a=backou
--HG--
extra : rebase_source : 8297426f6df40a9dc94fccf514ba3f4efa88889e
2019-06-06 15:33:55 +02:00
Edouard Oger
d3751d4293 Bug 1555771 - Update Sync and FxA illustrations. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D33234

--HG--
extra : moz-landing-system : lando
2019-06-05 17:46:54 +00:00
Mathieu Leplatre
ad6b27eaf9 Bug 1556761 - Stop logging 'Initialize remote settings' all the time r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D33692

--HG--
extra : moz-landing-system : lando
2019-06-05 08:05:43 +00:00
Matthew Noorenberghe
7d5f0874a4 Bug 1148205 - Replace misnamed formSubmitURL and hostname properties on nsILoginInfo in services/fxaccounts/ r=vladikoff
Differential Revision: https://phabricator.services.mozilla.com/D33348

--HG--
extra : moz-landing-system : lando
2019-06-05 03:59:55 +00:00
Matthew Noorenberghe
e7afdd4c3e Bug 1148205 - Replace misnamed formSubmitURL and hostname properties on nsILoginInfo in services/sync/ r=markh,tcsc
Differential Revision: https://phabricator.services.mozilla.com/D33347

--HG--
extra : moz-landing-system : lando
2019-06-05 03:59:46 +00:00
Lina Cambridge
ede2c0b68a Bug 1552621 - Include optional steps in Sync engine telemetry. r=tcsc,tdsmith
Before this commit, we used event telemetry to record timing and counts
for the different steps of a bookmark merge (fetching the local tree,
new local contents, remote tree, and new remote contents; merging;
applying; fetching outgoing records; and notifying observers).

This has several limitations. We need to store all numbers as strings,
include a "flow ID" to tag events from the same merge, and collect
failure reasons twice. We also can't correlate these events to the
existing engine telemetry, meaning we can't see other stats for that
engine, or for the entire sync. Finally, we need to run separate
queries on these events for analysis, instead of extending our
existing engine dashboards.

This approach also feels like an abuse of event telemetry, so this
commit adds a "steps" field for each engine in the Sync ping. Each step
has a name, time taken, and additional named counts, like the number of
items in the tree, or merged structure stats.

Currently, only the `buffered-bookmarks` engine records these steps.

Differential Revision: https://phabricator.services.mozilla.com/D33411

--HG--
extra : moz-landing-system : lando
2019-06-04 20:08:07 +00:00
Lina Cambridge
efa5e0cc06 Bug 1552621 - Record bookmark validation telemetry for the buffered engine. r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D33410

--HG--
extra : moz-landing-system : lando
2019-06-04 20:08:51 +00:00
Lina Cambridge
0c9500bf00 Bug 1552621 - Record shutdown blocker progress in the bookmarks mirror. r=markh,tcsc
This commit introduces a `mozISyncedBookmarksMirrorProgressListener`
interface for capturing telemetry and updating shutdown blocker state
after each step of the merge, instead of waiting until the end. This
also means we can also record events for interrupted and failed merges,
and pass validation data through to the Sync ping.

Shutdown hang crash reports now have a `steps` field, indicating the
sequence of completed steps and when they were recorded. If the last
step in the hang report is `fetchLocalTree`, we know the merger is
blocked on `fetchNewLocalContents`. If the last step is
`fetchNewLocalContents`, the merger is stuck at `fetchRemoteTree`,
since that's the next step after `fetchNewLocalContents`.

This commit also implements `Driver::record_telemetry_event` to
dispatch progress callback runnables to the main thread.

Differential Revision: https://phabricator.services.mozilla.com/D31950

--HG--
extra : moz-landing-system : lando
2019-06-03 23:04:37 +00:00
Coroiu Cristina
598c42a9d2 Backed out changeset 8aca39389e35 (bug 1555771) for browser-chrome failures at browser/components/extensions/test/browser/browser_ext_tabs_events.js 2019-06-04 03:22:59 +03:00
Edouard Oger
6387709163 Bug 1555771 - Update Sync and FxA illustrations. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D33234

--HG--
extra : moz-landing-system : lando
2019-06-03 21:24:42 +00:00
shindli
7849b17acb Backed out changeset 7f8884b7de4e (bug 1555771) for causing perma browser chrome failures in browser/base/content/test/sync/browser_sync.js CLOSED TREE 2019-06-03 22:14:42 +03:00
Edouard Oger
52eba7cee8 Bug 1555771 - Update Sync and FxA illustrations. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D33234

--HG--
extra : moz-landing-system : lando
2019-06-03 17:33:47 +00:00
Mathieu Leplatre
80c3d0b5ca Bug 1553831 - Fetch metadata on sync even if local data is up-to-date r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32769

--HG--
extra : moz-landing-system : lando
2019-06-03 10:02:13 +00:00
Mathieu Leplatre
921d7af3d5 Bug 1553831 - Minor cleanups in Remote Settings client r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32768

--HG--
extra : moz-landing-system : lando
2019-06-03 09:59:29 +00:00
ffxbld
5cd2a9bc7d No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D33506

--HG--
extra : moz-landing-system : lando
2019-06-03 15:44:26 +00:00
Brian Grinstead
402bc3a970 Bug 1553188 - Part 4 - Update remaining references to browser.xul;r=bdahl
These are generally:
- Code comments to browser.xhtml
- Testcases, assertions that were mostly using browser.xul as a generic chrome URL
- References to the browser.xul path in tree

Differential Revision: https://phabricator.services.mozilla.com/D33208
2019-05-28 16:40:42 -07:00
Dorel Luca
5e31d37927 Backed out 2 changesets (bug 1553831) for XPCshell failure in services/settings/test/unit/test_remote_settings.js
Backed out changeset d03a51956262 (bug 1553831)
Backed out changeset 4f62dfaee27f (bug 1553831)
2019-05-31 14:43:50 +03:00
Mathieu Leplatre
365261e7d6 Bug 1553995 - Remote Settings should not throw with dummy server r=glasserc,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D32549

--HG--
extra : moz-landing-system : lando
2019-05-31 09:53:05 +00:00
Mathieu Leplatre
f4957e385f Bug 1553831 - Fetch metadata on sync even if local data is up-to-date r=glasserc
Depends on D32768

Differential Revision: https://phabricator.services.mozilla.com/D32769

--HG--
extra : moz-landing-system : lando
2019-05-30 19:48:49 +00:00
Mathieu Leplatre
13c9f8aeb9 Bug 1553831 - Minor cleanups in Remote Settings client r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32768

--HG--
extra : moz-landing-system : lando
2019-05-28 13:58:29 +00:00
ffxbld
669d19df08 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D33154

--HG--
extra : moz-landing-system : lando
2019-05-30 13:07:37 +00:00
Tom Ritter
11e541177c Bug 1539595 - Reject FXA messages if they don't come from the correct type of process r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D30277

--HG--
extra : moz-landing-system : lando
2019-05-29 11:32:15 +00:00
ffxbld
dafef8c4a2 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D32686

--HG--
extra : moz-landing-system : lando
2019-05-28 20:34:21 +00:00
Sebastian Hengst
fba75a919c Backed out 4 changesets (bug 1539595) for build bustage in nsAboutRedirector.cpp. CLOSED TREE
Backed out changeset 2b0bb889b087 (bug 1539595)
Backed out changeset 95f0b82ec253 (bug 1539595)
Backed out changeset 6310e6dabceb (bug 1539595)
Backed out changeset ba3e353c6957 (bug 1539595)

--HG--
rename : browser/base/content/test/tabs/browser_e10s_about_page_triggeringprincipal.js => browser/base/content/test/general/browser_e10s_about_page_triggeringprincipal.js
rename : browser/base/content/test/tabs/browser_e10s_about_process.js => browser/base/content/test/general/browser_e10s_about_process.js
rename : browser/base/content/test/tabs/browser_e10s_chrome_process.js => browser/base/content/test/general/browser_e10s_chrome_process.js
rename : browser/base/content/test/tabs/browser_e10s_javascript.js => browser/base/content/test/general/browser_e10s_javascript.js
rename : browser/base/content/test/tabs/browser_e10s_switchbrowser.js => browser/base/content/test/general/browser_e10s_switchbrowser.js
rename : browser/base/content/test/tabs/file_about_child.html => browser/base/content/test/general/file_about_child.html
rename : browser/base/content/test/tabs/file_about_parent.html => browser/base/content/test/general/file_about_parent.html
rename : browser/base/content/test/tabs/test_process_flags_chrome.html => browser/base/content/test/general/test_process_flags_chrome.html
rename : browser/base/content/test/tabs/browser_new_tab_in_privilegedabout_process_pref.js => browser/base/content/test/tabs/browser_new_tab_in_privileged_process_pref.js
2019-05-28 19:49:17 +02:00
Tom Ritter
f94a4bdb87 Bug 1539595 - Reject FXA messages if they don't come from the correct type of process r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D30277

--HG--
extra : moz-landing-system : lando
2019-05-28 14:09:08 +00:00
Mathieu Leplatre
9871d095db Bug 1554178 - Disable events sampling for uptake telemetry tests r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32484

--HG--
extra : moz-landing-system : lando
2019-05-27 07:35:45 +00:00
Mathieu Leplatre
8708f07d79 Bug 1553797 - Fix OneCRL tests when MOZ_NEW_CERT_STORAGE is disabled r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D32331

--HG--
extra : moz-landing-system : lando
2019-05-24 14:32:13 +00:00
Narcis Beleuzu
b9bb66c9e0 Backed out changeset 204c7f42d427 (bug 1554178) for xpcshell failures on test_remote_settings.js . CLOSED TREE 2019-05-25 02:41:41 +03:00
Mathieu Leplatre
daebd4816c Bug 1554178 - Disable events sampling for uptake telemetry tests r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32484

--HG--
extra : moz-landing-system : lando
2019-05-24 16:23:31 +00:00
Mathieu Leplatre
b538ac9a32 Bug 1553142 - Leverage ConsoleAPI in Remote Settings r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32138

--HG--
extra : moz-landing-system : lando
2019-05-22 14:01:53 +00:00
ffxbld
7107838f34 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D32310

--HG--
extra : moz-landing-system : lando
2019-05-23 13:21:24 +00:00
Mathieu Leplatre
8f123db7b9 Bug 1553145 - Improve Remote Settings documentation r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32130

--HG--
extra : moz-landing-system : lando
2019-05-23 09:19:37 +00:00
Michael Kaply
75cc987da6 Bug 1456140 - Remove unnecessary size args for getChildList. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D31631

--HG--
extra : moz-landing-system : lando
2019-05-21 06:20:40 +00:00
Mathieu Leplatre
ecf5714fea Bug 1548542 - Remove notions of Kinto in blocklists unit tests r=keeler,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D31221

--HG--
extra : moz-landing-system : lando
2019-05-22 11:25:04 +00:00