Commit Graph

8706 Commits

Author SHA1 Message Date
Nathan Froyd
4bb0df12f2 Bug 1604616 - check for a new enough libstdc++; r=glandium
After a C++ language version bump, It's possible to wind up in
situations where we are using a new enough compiler version, but the
libstdc++ version in use is not new enough to support new language
features: self-compiled clang with system libraries, clang from `mach
bootstrap` prior to C++ language version bump (and thus including a new
libstdc++ with the boostrapped clang), etc.

Previously, such a situation would mean that things would work fine, and
then start breaking as soon as new library features started to be used.
Let's try to catch the problem earlier, when the update happens, by
verifying that the libstdc++ version is at least as new as the GCC
version we're requiring.

Differential Revision: https://phabricator.services.mozilla.com/D57516

--HG--
extra : moz-landing-system : lando
2020-02-10 18:51:42 +00:00
Emilio Cobos Álvarez
c3cc693c75 Bug 1614198 - Update cbindgen. r=heycam
I need this to support individual #[cfg] in enum variants, which is used for
Image::PaintWorklet.

Differential Revision: https://phabricator.services.mozilla.com/D62160

--HG--
extra : moz-landing-system : lando
2020-02-10 03:06:53 +00:00
Andi-Bogdan Postelnicu
27d6c7c59b Bug 1391711 - Implement a static analysis checker to detect usages of fopen/ open like functions on win32 platform. r=sg
This is a re-work of `https://mzl.la/31Bkl47`, and because time passed and not all of the
issues reported by this checker were fixed and we want to land it, we've decided to move
from errors diagnostic messages to warnings.

Differential Revision: https://phabricator.services.mozilla.com/D61753

--HG--
extra : moz-landing-system : lando
2020-02-10 14:41:26 +00:00
Razvan Maries
22c866afe4 Backed out changeset c02a7a545a87 (bug 1613247) for causing Bug 1613926 as per Tom's request. CLOSED TREE 2020-02-07 21:59:07 +02:00
Geoff Brown
3161788df7 Bug 1603499 - Report java exceptions from minidump .extra files; r=bc
Stop using mozcrash.check_for_java_exception(), which scans logcat for uncaught
exceptions. Instead, check for java_stack in the extra dump information during
normal crash reporting; if java_stack is present, display the java exception and
stack instead of dumping a full native crash report.

Differential Revision: https://phabricator.services.mozilla.com/D61836

--HG--
extra : moz-landing-system : lando
2020-02-07 16:05:52 +00:00
Michael Forney
477f5c111e Bug 1157850 - Use portable add_dir_entries() implementation when fts.h is missing r=mhowell
fts.h is also missing on musl. Since the Solaris fallback implementation
does not use any non-standard functions, use that as the fallback when
the FTS interface is not available.

Also, fix an issue with the readdir implementation. Previously, the
absolute directory path was passed to the recursive add_dir_entries()
call, which would then prepend install path again.

Differential Revision: https://phabricator.services.mozilla.com/D61407

--HG--
extra : moz-landing-system : lando
2020-02-07 05:17:12 +00:00
Mike Hommey
623de66503 Bug 1525218 - Use minidump_stackwalk toolchain artifacts instead of tooltool packages. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D59936

--HG--
extra : moz-landing-system : lando
2020-02-06 08:39:54 +00:00
Tom Prince
ed771d2f29 Bug 1613247: Simplify sccache config; r=firefox-build-system-reviewers,chmanchester
The logic for finding the sccache configuration to use has gone through several
iterations. At this point, all the build workers set
`TASKCLUSTER_WORKER_LOCATION`, so remove the code for dealing with other
configurations. Also don't set sccache configuration if it is disabled, even
if the bucket somehow gets set.

Differential Revision: https://phabricator.services.mozilla.com/D61635

--HG--
extra : moz-landing-system : lando
2020-02-06 00:52:05 +00:00
Tom Prince
efa6a0b1ff Bug 1613247: Use calculated GCS bucket in mozconfig.cacche; r=firefox-build-system-reviewers,chmanchester
The code goes to some length to calculate the bucket to use, but then
hard-codes the bucket in the credential URL it uses.

Differential Revision: https://phabricator.services.mozilla.com/D61634

--HG--
extra : moz-landing-system : lando
2020-02-06 00:56:00 +00:00
Sylvestre Ledru
9ee8d05df3 Bug 1613074 - Enable -Wunused-function & -Wunused-variable at the build phase r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D61550

--HG--
extra : moz-landing-system : lando
2020-02-04 14:36:58 +00:00
Andi-Bogdan Postelnicu
eb2b106a8c Bug 1580260 - rework the logic for MustReturnFromCaller checker. r=froydnj
Starting with `Clang-10`, and in particular with `https://reviews.llvm.org/D66404`,
the `CFG` has been reflown in order to reduce discrepancies in destructor calls with
the actual codegen. This has also impacted the order of `CFGStmt` for `ReturnStmt`,
whereas now the AST children of the `ReturnStmt` have precedence other their parent
node.
The purpose of this patch is to fix this and add new supported cases for the `Expr`
that is generated from `ReturnStmt`.

Differential Revision: https://phabricator.services.mozilla.com/D61556

--HG--
extra : moz-landing-system : lando
2020-02-05 08:34:36 +00:00
Emilio Cobos Álvarez
d99e85ea4b Bug 1613176 - Enable -Wreturn-type-c-linkage. r=froydnj
JSAPI functions are not extern "C" anymore. This warning has a couple false
positives due to template specialization (see first patch of this bug), but we
were already working around them, because apparently some mingw builds use it.

Once I fix cbindgen to generate the specializations as needed we can remove
those workarounds, but this is green in the meantime and doesn't hurt.

Depends on D61626

Differential Revision: https://phabricator.services.mozilla.com/D61627

--HG--
extra : moz-landing-system : lando
2020-02-05 11:21:04 +00:00
J.C. Jones
3a0a8e2762 Bug 1613275 - Regenerate expired certs not handled by Bug 1607845 a=RyanVM CLOSED TREE
commands:

openssl x509 -in security/manager/ssl/tests/unit/test_missing_intermediate/missing-intermediate.pem -outform der -out security/manager/ssl/tests/unit/test_missing_intermediate/missing-intermediate.der

mach python ./build/pgo/genpgocert.py

./mach python ./security/manager/ssl/tests/unit/pycert.py <security/manager/ssl/tests/unit/test_certDB_import/emailEE.pem.certspec >security/manager/ssl/tests/unit/test_certDB_import/emailEE.pem
./mach python ./security/manager/ssl/tests/unit/pycert.py <security/manager/ssl/tests/unit/test_certDB_import/importedCA.pem.certspec >security/manager/ssl/tests/unit/test_certDB_import/importedCA.pem
./mach python ./security/manager/ssl/tests/unit/pycert.py <security/manager/ssl/tests/unit/test_intermediate_preloads/ee.pem.certspec >security/manager/ssl/tests/unit/test_intermediate_preloads/ee.pem
./mach python ./security/manager/ssl/tests/unit/pycert.py <security/manager/ssl/tests/unit/test_intermediate_preloads/ee2.pem.certspec >security/manager/ssl/tests/unit/test_intermediate_preloads/ee2.pem
./mach python ./security/manager/ssl/tests/unit/pycert.py <security/manager/ssl/tests/unit/test_intermediate_preloads/int.pem.certspec >security/manager/ssl/tests/unit/test_intermediate_preloads/int.pem
./mach python ./security/manager/ssl/tests/unit/pycert.py <security/manager/ssl/tests/unit/test_intermediate_preloads/int2.pem.certspec >security/manager/ssl/tests/unit/test_intermediate_preloads/int2.pem


Differential Revision: https://phabricator.services.mozilla.com/D61653

--HG--
extra : amend_source : ba63f416c91785a479695f342cf8db70ccd49cba
2020-02-04 20:17:49 -07:00
Chris Manchester
faa6984eb6 Bug 1612305 - Remove log from the mozilla central workspace hack. r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D61296

--HG--
extra : moz-landing-system : lando
2020-02-04 00:06:18 +00:00
Rob Lemley
bcc6b23169 Bug 1574409 - Make mozconfig.cache useable for Thunderbird builds. r=firefox-build-system-reviewers,mshal
Much of Firefox's mozocnfig.cache file is duplicated in Thunderbird's tree
in order to set a slightly different bucket name. This has led to broken buids
in the past.
The only difference is the first part of the name. With this change, a Thunderbird
mozconfig file can set $aws_prefix to "comm-central" before mozconfig.cache
gets included and be correctly configured.
GCP support is not required at this time.

Differential Revision: https://phabricator.services.mozilla.com/D61143

--HG--
extra : moz-landing-system : lando
2020-01-31 00:50:52 +00:00
Tom Ritter
ab97c8e874 Bug 1612424 - Patch nsis to call lld with --no-insert-timestamp r=froydnj
Adding --no-insert-timestamp to APPEND_LINKFLAGS for nsis is not working as it
is used for both the host and cross-compiled parts, but this option is
only valid for the Windows linker. Therefore we add it using a patch
to the cross-compilation part only.

Differential Revision: https://phabricator.services.mozilla.com/D61321

--HG--
extra : moz-landing-system : lando
2020-01-31 08:30:46 +00:00
Emilio Cobos Álvarez
4ba89c93cf Bug 1612092 - Update cbindgen. r=froydnj
v0.12.2 at least is needed to have proper v2 lockfile support.

But v0.13.0 contains extra fixes, and features that wgpu and the style system
plan to use, so let's just update to that.

Differential Revision: https://phabricator.services.mozilla.com/D61334

--HG--
extra : moz-landing-system : lando
2020-01-31 08:03:17 +00:00
David Major
ce4f2fde5b Bug 1612458 - Remove some orphaned build-clang patches r=froydnj
I noticed these unused files when they got in my way of doing searches.

Differential Revision: https://phabricator.services.mozilla.com/D61332

--HG--
extra : moz-landing-system : lando
2020-01-31 08:29:42 +00:00
Andy Grover
f659db9daf Bug 1611990 - Firefox omits Rust log messages of less than WARN level unless compiled in debug mode r=chmanchester
Differential Revision: https://phabricator.services.mozilla.com/D61254

--HG--
extra : moz-landing-system : lando
2020-01-30 04:51:51 +00:00
Ricky Stewart
232331fdb4 Bug 1610944 - configure/test_toolchain_configure.py and configure/test_toolchain_helpers.py support Python 3 r=firefox-build-system-reviewers,mshal CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D60743

--HG--
extra : source : f5b4973be6dac983ff87add5d198f959de2cec78
extra : amend_source : 30b53ec7c0a22138d43d9c7e85c6e43c9dea84b1
2020-01-23 17:15:38 +00:00
Csoregi Natalia
715ffe2f34 Merge mozilla-central to autoland. CLOSED TREE 2020-01-24 14:09:26 +02:00
Csoregi Natalia
c12e02a6be Backed out changeset f5b4973be6da (bug 1610944) for nightly bustages. a=backout 2020-01-24 13:40:32 +02:00
Dzmitry Malyshau
82be8c479a Bug 1596127 - wgpu Rust tests CI job r=ahal,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D58414

--HG--
extra : moz-landing-system : lando
2020-01-23 20:42:22 +00:00
shindli
26374765cb Backed out 2 changesets (bug 1611231) for causing a linting falure in /builds/worker/checkouts/gecko/build/docs/sccache-dist.rst CLOSED TREE
Backed out changeset c38aab2ba30b (bug 1611231)
Backed out changeset 278f992ad76d (bug 1611231)
2020-01-23 23:02:38 +02:00
Chris Manchester
5b0fdb451b Bug 1611231 - Add a note about rewrite_includes_only to sccache-dist docs. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D60879

--HG--
extra : moz-landing-system : lando
2020-01-23 20:46:42 +00:00
Ricky Stewart
e82e92605b Bug 1610944 - configure/test_toolchain_configure.py and configure/test_toolchain_helpers.py support Python 3 r=firefox-build-system-reviewers,mshal
Differential Revision: https://phabricator.services.mozilla.com/D60743

--HG--
extra : moz-landing-system : lando
2020-01-23 17:15:38 +00:00
Chris Manchester
0daada8368 Bug 1611231 - Add a note about rewrite_includes_only to sccache-dist docs. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D60879

--HG--
extra : moz-landing-system : lando
2020-01-23 21:58:52 +00:00
Cosmin Sabou
7b76379364 Backed out changeset 7c2048122a9f (bug 1610944) for causing L10n bustages. 2020-01-23 07:21:28 +02:00
Tom Prince
3ba4b04d5c Bug 1607193: Disable l10n-check by default; r=Callek,firefox-build-system-reviewers,mshal
This disables the l10n-check as part of the build, now that we have
on-push L10n jobs.

Differential Revision: https://phabricator.services.mozilla.com/D60722

--HG--
extra : moz-landing-system : lando
2020-01-22 23:36:56 +00:00
Ricky Stewart
3003ade6dd Bug 1610944 - configure/test_toolchain_configure.py and configure/test_toolchain_helpers.py support Python 3 r=firefox-build-system-reviewers,mshal
Differential Revision: https://phabricator.services.mozilla.com/D60743

--HG--
extra : moz-landing-system : lando
2020-01-22 23:46:36 +00:00
Aaron Klotz
2977b8a690 Bug 1610678: Add check to clang plugin to raise error when using namespace mozilla::java is present in C++ source; r=andi
Differential Revision: https://phabricator.services.mozilla.com/D60611

--HG--
extra : moz-landing-system : lando
2020-01-22 18:47:04 +00:00
Ricky Stewart
42ed117231 Bug 1610774 - put mozfile at the beginning of the user's path if necessary in configure r=firefox-build-system-reviewers,mshal
Differential Revision: https://phabricator.services.mozilla.com/D60705

--HG--
extra : moz-landing-system : lando
2020-01-22 18:36:14 +00:00
Ricky Stewart
27d06e3d50 Bug 1608880 - mozbuild/test/configure/test_compile_checks.py and mozbuild/test/configure/test_moz_configure.py support Python 3 r=firefox-build-system-reviewers,mshal
Differential Revision: https://phabricator.services.mozilla.com/D59757

--HG--
extra : moz-landing-system : lando
2020-01-21 23:51:28 +00:00
Chris Manchester
d30348f637 Bug 1604486 - Update profile generate sparse profile to include talos tests. r=sheehan
Differential Revision: https://phabricator.services.mozilla.com/D60463

--HG--
extra : moz-landing-system : lando
2020-01-20 23:04:39 +00:00
Simon Giesecke
b7487e7d51 Bug 1609638 - Add analysis identifying dereferences of temporary RefPtr objects. r=andi
Differential Revision: https://phabricator.services.mozilla.com/D60167

--HG--
extra : moz-landing-system : lando
2020-01-20 14:11:21 +00:00
Sebastian Hengst
8f821d77ab Backed out 3 changesets (bug 1525218) for breaking fenix, reference-browser speedometer tasks. a=backout
Backed out changeset 76036ce90611 (bug 1525218)
Backed out changeset 9c66ecb1f66c (bug 1525218)
Backed out changeset eb4b265deb5e (bug 1525218)

--HG--
extra : rebase_source : 5f1b01bd44628efff2a7e0f28a62a7ad673a73c0
2020-01-20 11:19:46 +01:00
David Major
2f04d6892b Bug 1609780 - Remove clang-8 mingw patches r=tjr
These files are unreachable as of bug 1590624.

Differential Revision: https://phabricator.services.mozilla.com/D60181

--HG--
extra : moz-landing-system : lando
2020-01-16 21:04:49 +00:00
Gabriele Svelto
96a70684f4 Bug 1588538 - Use the new Windows dump_syms tool to dump symbols in local builds r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D57094

--HG--
extra : moz-landing-system : lando
2020-01-16 14:14:13 +00:00
Mike Hommey
5378c2e839 Bug 1525218 - Use minidump_stackwalk toolchain artifacts instead of tooltool packages. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D59936

--HG--
extra : moz-landing-system : lando
2020-01-15 14:20:30 +00:00
David Major
871109ae17 Bug 1609520 - Fix lint warning after bug 1609422
Differential Revision: https://phabricator.services.mozilla.com/D60059

--HG--
extra : moz-landing-system : lando
2020-01-15 20:46:57 +00:00
David Major
5f443f7001 Bug 1609422 - Clean up an old rustc version check for pgo r=firefox-build-system-reviewers,chmanchester
We require rustc 1.39 nowadays.

Differential Revision: https://phabricator.services.mozilla.com/D60008

--HG--
extra : moz-landing-system : lando
2020-01-15 17:14:10 +00:00
Dzmitry Malyshau
69b270f2c6 Bug 1605171 - Replace wrupdater with github-sync r=tomprince
this is an evolution of wrupdater

Differential Revision: https://phabricator.services.mozilla.com/D58972

--HG--
extra : moz-landing-system : lando
2020-01-14 18:37:28 +00:00
Csoregi Natalia
57eb78c63c Backed out changeset 5d0b75e5f795 (bug 1588538) for DUMP_SYMS bustage. CLOSED TREE 2020-01-14 13:53:54 +02:00
Gabriele Svelto
e62e144c3c Bug 1588538 - Use the new Windows dump_syms tool to dump symbols in local builds r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D57094

--HG--
extra : moz-landing-system : lando
2020-01-14 10:08:52 +00:00
Emilio Cobos Álvarez
7c6f58b638 Bug 1608729 - Don't warn about multistatement macros with GCC. r=froydnj
It generates a lot of noise and we don't want to fix them. In particular, all
the cycle collector macros are like this.

Differential Revision: https://phabricator.services.mozilla.com/D59646

--HG--
extra : moz-landing-system : lando
2020-01-13 14:54:39 +00:00
Andrew Halberstadt
f23ed2d822 Bug 1563797 - Remove third_party/python/which r=Callek
This module has been replaced by 'shutil_which' and is no longer needed.

Differential Revision: https://phabricator.services.mozilla.com/D37098

--HG--
extra : moz-landing-system : lando
2020-01-13 14:24:50 +00:00
David Major
0c76842459 Bug 1608460 - Redefine MIDL names to be unique to work around a clang-cl bug r=froydnj
This is an alternative to carrying a revert of the offending changeset, since the bug doesn't show hope of a fix anytime soon, or maybe ever. This way we don't have to keep rebasing the patch as we pick up new clangs, and developers don't have to remember to apply the patch when building a local compiler.

Differential Revision: https://phabricator.services.mozilla.com/D59200

--HG--
extra : moz-landing-system : lando
2020-01-10 17:53:29 +00:00
Daniel Varga
3215317bdc Backed out changeset dd2f16711aba (bug 1606922) for causing build failures
CLOSED TREE
2020-01-11 03:08:34 +02:00
Ricky Stewart
39e4717ac8 Bug 1607512 - mozbuild/test/configure/test_checks_configure.py supports Python 3 r=ahal,mars
Differential Revision: https://phabricator.services.mozilla.com/D58970

--HG--
extra : moz-landing-system : lando
2020-01-10 21:05:03 +00:00
Ricky Stewart
6a7f736bdb Bug 1607284 - mozbuild/configure/util.py supports Python 3 r=ahal,mars
Differential Revision: https://phabricator.services.mozilla.com/D58834

--HG--
extra : moz-landing-system : lando
2020-01-10 22:09:56 +00:00