Commit Graph

357 Commits

Author SHA1 Message Date
Byron Campen [:bwc]
72bcc87880 Bug 1569183: Simplify how NrSockets specify whether they're proxied or not. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D46032

--HG--
extra : moz-landing-system : lando
2019-09-17 18:19:19 +00:00
Byron Campen [:bwc]
abf0777414 Bug 1569183: Create an ipdl struct called WebrtcProxyConfig, to cut down on the arg count on lots of functions. r=mjf,mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D45562

--HG--
extra : moz-landing-system : lando
2019-09-17 18:19:04 +00:00
Byron Campen [:bwc]
2fe90843a0 Bug 1569183: Update OnConnected callbacks to specify what type of proxying (if any) is being used, and implement IsProxied based on this information. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D45186

--HG--
extra : moz-landing-system : lando
2019-09-17 18:18:33 +00:00
Byron Campen [:bwc]
dbee4e76f5 Bug 1569183: Add a proxy policy argument to NrSocketProxyConfig, and always set this config on the NrIceCtx. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D45101

--HG--
extra : moz-landing-system : lando
2019-09-17 18:17:14 +00:00
Byron Campen [:bwc]
c368262621 Bug 1569183: Rename NrSocketProxy to NrTcpSocket, and use NrTcpSocket for TCP on content/socket process. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D45099

--HG--
rename : media/mtransport/nr_socket_proxy.cpp => media/mtransport/nr_socket_tcp.cpp
rename : media/mtransport/nr_socket_proxy.h => media/mtransport/nr_socket_tcp.h
extra : moz-landing-system : lando
2019-09-17 18:17:11 +00:00
Byron Campen [:bwc]
ffa09cee72 Bug 1569183: Rename PWebrtcProxyChannel to PWebrtcTCPSocket. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D45098

--HG--
rename : media/mtransport/WebrtcProxyChannelWrapper.cpp => media/mtransport/WebrtcTCPSocketWrapper.cpp
rename : media/mtransport/WebrtcProxyChannelWrapper.h => media/mtransport/WebrtcTCPSocketWrapper.h
rename : media/mtransport/ipc/PWebrtcProxyChannel.ipdl => media/mtransport/ipc/PWebrtcTCPSocket.ipdl
rename : media/mtransport/ipc/WebrtcProxyChannel.cpp => media/mtransport/ipc/WebrtcTCPSocket.cpp
rename : media/mtransport/ipc/WebrtcProxyChannel.h => media/mtransport/ipc/WebrtcTCPSocket.h
rename : media/mtransport/ipc/WebrtcProxyChannelCallback.h => media/mtransport/ipc/WebrtcTCPSocketCallback.h
rename : media/mtransport/ipc/WebrtcProxyChannelChild.cpp => media/mtransport/ipc/WebrtcTCPSocketChild.cpp
rename : media/mtransport/ipc/WebrtcProxyChannelChild.h => media/mtransport/ipc/WebrtcTCPSocketChild.h
rename : media/mtransport/ipc/WebrtcProxyLog.cpp => media/mtransport/ipc/WebrtcTCPSocketLog.cpp
rename : media/mtransport/ipc/WebrtcProxyLog.h => media/mtransport/ipc/WebrtcTCPSocketLog.h
rename : media/mtransport/ipc/WebrtcProxyChannelParent.cpp => media/mtransport/ipc/WebrtcTCPSocketParent.cpp
rename : media/mtransport/ipc/WebrtcProxyChannelParent.h => media/mtransport/ipc/WebrtcTCPSocketParent.h
extra : moz-landing-system : lando
2019-09-17 18:15:41 +00:00
Dan Minor
6c6b65f876 Bug 1554976 - Add plumbing to enable/disable host address obfuscation; r=mjf
This only enables mDNS on OS X for now. Some versions of Windows lack mDNS
support, there are some oddities with resolving IPv6 addresses on Linux, and
Android has not yet been tested. All of these will be addressed in follow on
bugs.

Differential Revision: https://phabricator.services.mozilla.com/D38496

--HG--
extra : moz-landing-system : lando
2019-08-28 19:50:06 +00:00
Dan Minor
6c39c9271f Bug 1554976 - Generate mDNS addresses in nricectx; r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D38493

--HG--
extra : moz-landing-system : lando
2019-08-28 19:49:24 +00:00
Gurzau Raul
a6c5c5e3ac Backed out 14 changesets (bug 1554976) for Windows build bustages on a CLOSED TREE.
Backed out changeset a9b209d9d880 (bug 1554976)
Backed out changeset 27b4dddf9597 (bug 1554976)
Backed out changeset 3e16c10bb966 (bug 1554976)
Backed out changeset 6a404fca61dc (bug 1554976)
Backed out changeset 77c4e76c8130 (bug 1554976)
Backed out changeset 24f146b86cc4 (bug 1554976)
Backed out changeset b49b4326dcfd (bug 1554976)
Backed out changeset e2c837d1e0a0 (bug 1554976)
Backed out changeset 24728144c263 (bug 1554976)
Backed out changeset a099e69241a0 (bug 1554976)
Backed out changeset 0e34595c2680 (bug 1554976)
Backed out changeset a506bb40047e (bug 1554976)
Backed out changeset 513026415092 (bug 1554976)
Backed out changeset e0fc6a1d4332 (bug 1554976)
2019-08-28 18:10:11 +03:00
Dan Minor
2da923ff0b Bug 1554976 - Add plumbing to enable/disable host address obfuscation; r=mjf
This only enables mDNS on OS X for now. Some versions of Windows lack mDNS
support, there are some oddities with resolving IPv6 addresses on Linux, and
Android has not yet been tested. All of these will be addressed in follow on
bugs.

Differential Revision: https://phabricator.services.mozilla.com/D38496

--HG--
extra : moz-landing-system : lando
2019-08-28 13:11:33 +00:00
Dan Minor
9fa62a0a55 Bug 1554976 - Generate mDNS addresses in nricectx; r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D38493

--HG--
extra : moz-landing-system : lando
2019-08-28 13:11:14 +00:00
Ryan Alderete
4b595ec1a8 Bug 1570158 - Add proxy information to candidates table in about:webrtc r=bwc,baku
This adds a field to about:webrtc which indicates whether an associated
candidate is behind a proxy or not.

Differential Revision: https://phabricator.services.mozilla.com/D39974

--HG--
extra : moz-landing-system : lando
2019-08-21 10:04:45 +00:00
Dan Minor
97c5db53eb Bug 1561923 - Remove expired WebRTC telemetry; r=drno,bwc
Differential Revision: https://phabricator.services.mozilla.com/D37757

--HG--
extra : moz-landing-system : lando
2019-07-31 19:57:55 +00:00
Byron Campen [:bwc]
ff7e1aeb02 Bug 1558887: Reduce this STUN response delay a little, since on some platforms it seems to be too long. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D37474

--HG--
extra : moz-landing-system : lando
2019-07-10 02:07:19 +00:00
Byron Campen [:bwc]
935a645aef Bug 1558886: Don't expect exactly one ready stream once ICE is connected. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D36501

--HG--
extra : moz-landing-system : lando
2019-07-08 16:13:45 +00:00
Sylvestre Ledru
f1fbd2ff00 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D33456

--HG--
extra : moz-landing-system : lando
2019-06-08 08:26:37 +00:00
Dan Minor
2477747488 Bug 1548841 - Obfuscate mDNS ICE candidate addresses; r=bwc
This adds a mdns_addr field to nICEr ICE candidates to track the mDNS address
associated with a candidate, if any. This is used to hide the real address
when generating ICE stats. This potentially could be handled at the
MediaTransportHandler level, but we need to know if a candidate is mDNS to
prevent pairing it with relay candidates, which is part of the next commit.

This adds a unit tests to check that the mDNS addresses are handled properly.
As part of doing this, TestBogusCandidate was fixed. As written, it was never
parsing the bogus candidate because it was in the wrong ICE state.

Differential Revision: https://phabricator.services.mozilla.com/D30935

--HG--
extra : moz-landing-system : lando
2019-05-15 22:55:55 +00:00
Valentin Gosu
975c55c679 Bug 1525640 - Pass TRR status from sockettransport to channel r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D26882

--HG--
extra : moz-landing-system : lando
2019-05-06 16:47:14 +00:00
Bogdan Tara
8244fce3c8 Backed out 3 changesets (bug 1525640) for frequent wpt failures CLOSED TREE
Backed out changeset d9a454afe9bf (bug 1525640)
Backed out changeset 19aa991328cb (bug 1525640)
Backed out changeset 4294abed890f (bug 1525640)
2019-05-03 00:16:20 +03:00
Valentin Gosu
50b2b648b6 Bug 1525640 - Add nsIHttpChannelInternal.isResolvedByTRR r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D26884

--HG--
extra : moz-landing-system : lando
2019-05-02 12:53:45 +00:00
Sylvestre Ledru
e226046cb8 Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan
# ignore-this-changeset

Depends on D28954

Differential Revision: https://phabricator.services.mozilla.com/D28956

--HG--
extra : moz-landing-system : lando
2019-05-01 08:47:10 +00:00
Byron Campen [:bwc]
ed8100d1c1 Bug 1545827: Rename a macro to avoid conflicts. r=mjf,drno
Differential Revision: https://phabricator.services.mozilla.com/D28845

--HG--
extra : moz-landing-system : lando
2019-04-26 14:46:43 +00:00
Byron Campen [:bwc]
fd880e95f8 Bug 1545827: Use TabId instead of PBrowserOrId, use LoadInfoArgs to avoid using the system principal on the socket process, and use PSocketProcess for the WebrtcProxyChannel when on the socket process. r=kershaw,mjf
Differential Revision: https://phabricator.services.mozilla.com/D28239

--HG--
extra : moz-landing-system : lando
2019-04-26 14:46:26 +00:00
Coroiu Cristina
8442bbf9c9 Backed out 3 changesets (bug 1525640) for causing leaks a=backout
Backed out changeset efdd32c00dc6 (bug 1525640)
Backed out changeset e71641f0465b (bug 1525640)
Backed out changeset e3539a40afdf (bug 1525640)
2019-04-13 14:57:11 +03:00
Valentin Gosu
f172b45edc Bug 1525640 - Pass TRR status from sockettransport to channel r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D26882

--HG--
extra : moz-landing-system : lando
2019-04-12 13:54:08 +00:00
Geoff Brown
8d88b9a596 Bug 1318091 - Disable failing android gtests; r=bc
Disable gtests observed to fail on Android. Some of these are simple build
failures and failures due to file permissions or paths, while other failures
are more obscure.
Once Android gtests are running on mozilla-central, I will file follow-up
bugs inviting teams to investigate the failures and re-enable Android gtests
that are important to them.

Differential Revision: https://phabricator.services.mozilla.com/D26606

--HG--
extra : moz-landing-system : lando
2019-04-08 20:58:21 +00:00
Sylvestre Ledru
03fc65347c Bug 1542146 - Apply the change with the option StatementMacros from clang-format-8 r=andi
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26280

--HG--
extra : moz-landing-system : lando
2019-04-05 21:42:17 +00:00
Csoregi Natalia
ba58e936bd Backed out changeset 4ad80127f89f (bug 1519636) for bustage on MarkupMap.h and nsAccessibilityService.cpp. CLOSED TREE 2019-04-05 09:48:19 +03:00
Sylvestre Ledru
d1c1878603 Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 21:36:16 +00:00
Narcis Beleuzu
24dbe577a5 Backed out changeset 389b6bbd76db (bug 1519636) for bustages on MarkupMap.h . CLOSED TREE 2019-04-05 00:27:56 +03:00
Sylvestre Ledru
399dbd28fe Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 20:12:23 +00:00
Byron Campen [:bwc]
c33b5e6569 Bug 1490658: Support RTCIceCandidate.usernameFragment. r=mjf,smaug
Differential Revision: https://phabricator.services.mozilla.com/D21803

--HG--
extra : moz-landing-system : lando
2019-03-08 15:24:27 +00:00
Sylvestre Ledru
41d1d79094 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D19663

--HG--
extra : moz-landing-system : lando
2019-02-15 08:15:57 +00:00
Byron Campen [:bwc]
b9265f3fe2 Bug 1526477 - Part 0: Test role for ice-lite cases. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D19232

--HG--
extra : moz-landing-system : lando
2019-02-11 16:09:24 +00:00
Byron Campen [:bwc]
68bc15c3ce Bug 1494311: Making the mtransport API a little more IPC friendly, and establishing a proper base-class. r=mt,mjf
Differential Revision: https://phabricator.services.mozilla.com/D17272

--HG--
extra : moz-landing-system : lando
2019-01-29 14:56:19 +00:00
Ehsan Akhgari
e5e885ae31 Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
# ignore-this-changeset

--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Nils Ohlmeier [:drno]
a04d4e00bd Bug 1510487: allow DTLS connection w/o SRTP extension. r=bwc
Differential Revision: https://phabricator.services.mozilla.com/D14692

--HG--
extra : moz-landing-system : lando
2019-01-17 14:16:01 +00:00
Paolo Amadini
ffa6503244 Bug 983187 - Test that downloads fail when an RST packet is received. r=mayhemer
This adds a way to simulate failed network connections, allowing the addition of test coverage that would otherwise not be available. This is used in the Downloads tests to ensure that failures at the network level are handled correctly.

Differential Revision: https://phabricator.services.mozilla.com/D15522

--HG--
extra : rebase_source : 2597b27de5213b0322520cefafe10a197d0d3b83
2019-01-09 11:48:23 +00:00
Sylvestre Ledru
6f45c666bc Bug 1513205 - Also update the tests to match the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D14595

--HG--
extra : moz-landing-system : lando
2018-12-14 18:10:35 +00:00
Paul Vitale
34ca854b9d Bug 1194010 - Block webrtc socket creation on restricted ports r=drno
Port restriction is delegated to the io service.  Port 0 is explicitly
unrestricted.

NS_CheckPortSafety emits a warning which pollutes the gtests a bit.  It is only
tested if the port is not 0.

Differential Revision: https://phabricator.services.mozilla.com/D13187

--HG--
extra : moz-landing-system : lando
2018-11-29 15:40:44 +00:00
Nils Ohlmeier [:drno]
1319a0b5d5 Bug 1507700: allow incoming STUN requests. r=bwc
Differential Revision: https://phabricator.services.mozilla.com/D12384

--HG--
extra : moz-landing-system : lando
2018-11-28 20:13:17 +00:00
Paul Vitale
09f4c06235 Bug 1203503 - part 2. replace proxy tunnel with new ipc-based tunnel r+bwc, r+mayhemer
This replaces the tunnel using a new nr_socket implementation.  Proxy detection
code is still done in the peer connction.  However, the result is only used to
detect a proxy.  The result is unused.  Address resolution is done by necko code
in the parent process.  The new socket wraps a WebrtcProxyChannel which uses
necko to handle proxy negotiation.  This has a happy side effect of enabling all
authentication modes that necko already supports for http proxies.

This adds a protocol for Necko to manage, WebrtcProxyChannel.  This new protocol
serves as a pipe for a CONNECT tunnel.  It is only used in WebRtc and not built
in no WebRtc builds.

--HG--
extra : rebase_source : a951841f95eaaa0562886cf76b405b01f1adf70e
extra : intermediate-source : 5c3da21957fc80b07188bc8a405437b858027a22
extra : source : 594a32883463ab051677ba06e22fa6d062b4b4a9
2018-06-05 12:10:16 -05:00
Byron Campen [:bwc]
41541e64f6 Bug 1494301: Single API for mtransport. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D7212

--HG--
extra : moz-landing-system : lando
2018-10-26 00:39:07 +00:00
Nils Ohlmeier [:drno]
dedc2f2c81 Bug 1498068: fixed SRTP key length assertion for GCM 128 bit. r=mt
Differential Revision: https://phabricator.services.mozilla.com/D8324

--HG--
extra : moz-landing-system : lando
2018-10-16 03:30:57 +00:00
Byron Campen [:bwc]
93985b16c9 Bug 1486012: Rework ICE restart. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D5897

--HG--
rename : dom/media/tests/mochitest/test_peerConnection_restartIceLocalAndRemoteRollback.html => dom/media/tests/mochitest/test_peerConnection_restartIceLocalAndRemoteRollbackNoSubsequentRestart.html
rename : dom/media/tests/mochitest/test_peerConnection_restartIceLocalRollback.html => dom/media/tests/mochitest/test_peerConnection_restartIceLocalRollbackNoSubsequentRestart.html
extra : moz-landing-system : lando
2018-09-20 16:07:51 +00:00
Nils Ohlmeier [:drno]
3dab079c7c Bug 1479665: add GCM ciphers to SrtpFlow. r=bwc
add GCM ciphers to SrtpFlow

Differential Revision: https://phabricator.services.mozilla.com/D5731

--HG--
extra : moz-landing-system : lando
2018-09-14 03:12:05 +00:00
Cosmin Sabou
984ac63e0f Backed out changeset 1a7771d373ff (bug 1479665) for causing build bustages. CLOSED TREE 2018-09-13 23:52:48 +03:00
Nils Ohlmeier [:drno]
77d354dda1 Bug 1479665: add GCM ciphers to SrtpFlow. r=bwc
add GCM ciphers to SrtpFlow

Differential Revision: https://phabricator.services.mozilla.com/D5731

--HG--
extra : moz-landing-system : lando
2018-09-13 17:38:50 +00:00
Nils Ohlmeier [:drno]
e88a043618 Bug 1480869: define SRTP ciphers suites inside mtransport r=mt
define SRTP cipher suites inside mtransport

Differential Revision: https://phabricator.services.mozilla.com/D5490

--HG--
extra : moz-landing-system : lando
2018-09-11 03:58:34 +00:00
Martin Thomson
1d41c9edcb Bug 1485883 - Handle use_srtp extension in gecko, r=drno
Summary:
This implements the SRTP extension in TransportLayerDtls.  My hope is
that we can expunge the SRTP code from NSS in a few releases.

Reviewers: drno

Subscribers: ekr

Tags: #secure-revision

Bug #: 1485883

Differential Revision: https://phabricator.services.mozilla.com/D4188

MozReview-Commit-ID: Cwjrn9wsCQr
2018-09-07 11:50:21 +10:00