The original code was added in bug 385263 for fixing bug 279032 that a
single font provides zero for max ascent / descent in its HHEA table
which caused Firefox to crash.
Unconditionally picking the maximum of max ascent / descent and their
em correspondents doesn't seem to be essential for working around that
case, so this patch changes it to just use the em ascent / descent when
both max ascent and descent are zero.
This fixes a webcompat problem related to Roboto font on Linux (and
presumably also Android given it uses FreeType backend as well).
MozReview-Commit-ID: EpKrfiOwnZt
--HG--
extra : rebase_source : 0619abf992fb1e1a1f3068ab172880913ebff1f1
This commit adds CI tasks to perform "plain" builds. These builds use
the same toolchains used by official builds. But that's about it. The
mozconfig changes are minimal and only set up paths to toolchain
artifacts. sccache is not used.
The main goal of these builds is to have a "reference" build that
matches an out-of-the-box build environment as much as possible. We want
this mainly so we have timing and behavior information that matches what
developers are doing.
The Windows/generic Taskcluster worker doesn't like it when you specify
an artifact directory that doesn't exist. So we needed to add a
mozharness step to ensure UPLOAD_PATH exists to prevent those tasks from
erroring.
I'm not super thrilled about using mozharness here. We definitely don't
really need mozharness. But the main thing it is providing that we care
about is the Perfherder metrics data. I don't feel like scope bloating
to move that out of mozharness at this time.
I only implemented Linux64 and Windows64 because I'm not convinced
coverage on 32-bit build variations is useful. Tasks only run on trunk
because they are informational only and we don't need to waste resources
running these on release repos and on Try. They are tier 2 because they
aren't critical to shipping Firefox.
MozReview-Commit-ID: Gl6hGYbFX9b
--HG--
extra : rebase_source : 05360d2f6e5dbfed5543726a1be4b0e5d00e0b3d
Automatic update from web-platform-testsMove AudioBuffer ctor test to WPT.
This test fails on Firefox because it signals the incorrect type on
some tests. A bug was filed and should be fixed soon.
Bug: 745778
Change-Id: Idb0ece151a3f9404b4a10ddb719cfc4982a57959
Reviewed-on: https://chromium-review.googlesource.com/1035917
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554887}
--
wpt-commits: e580c7e9126412a44880755aeb17b05e13a02a88
wpt-pr: 10720
Automatic update from web-platform-tests[css-tables] Scrollbar should be removed from OverrideLogicalHeight()
When computing the percentage height of table cell replaced children,
if the table cell has horizontal scrollbar we have to subtract
its height from the OverrideLogicalHeight().
The patch is just following a suggestion from a TODO in
LayoutBox::AvailableLogicalHeightUsing().
BUG=838144
TEST=external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001.html
Change-Id: I21f33b82978ffaeb7a6f04eb49ef2e1a52c1e8c0
Reviewed-on: https://chromium-review.googlesource.com/1035125
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#554853}
--
wpt-commits: 621c98d70bc30cae3319aef809c98929420c0f06
wpt-pr: 10714
Automatic update from web-platform-testsMakes OffscreenCanvas dispatch on MainThread and Workers
- removes old commit() from OffscreenCanvasRenderingContexts.
- makes sure that DidDraw is correctly called and triggers a BeginFrame
that will trigger a Dispatch of the frame.
Bug: 833902
Change-Id: I08ceeba9e7e00da35977bcc4e96a189b366a856c
Reviewed-on: https://chromium-review.googlesource.com/1028559
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554825}
--
wpt-commits: 161d6c4fa0dd8c24b93db569c7e76f877443ad02
wpt-pr: 10662
Automatic update from web-platform-testsHTML: document.open() and mutation events
See https://github.com/whatwg/html/pull/3598.
--
wpt-commits: e4b690a768b15c0b2aab558e97454385ec7164e1
wpt-pr: 10680
