If the browser process is not running it doesn't make sense to try to
connect to it for another 60s. Instead error out immediately.
MozReview-Commit-ID: 64DTZfEfzQj
--HG--
extra : rebase_source : 9951b1a64cbd8b387c2bc5e1152de0a975dbbe77
The marionette.defaultPrefs.port preference was changed to
marionette.port, but because we currently do not run tests in CI we
missed updating the test.
MozReview-Commit-ID: LKstRYmJcMO
--HG--
extra : rebase_source : 1633b5b82c3c8725ff66423119d7c476fa942b01
To allow the selection of the new webdriver spec conforming
"clickElement" method over the old legacy Selenium one, the
"moz:webdriverClick" capability can be used. Setting it's value
to true will enable the conforming click.
MozReview-Commit-ID: HMvFFEJDvpG
--HG--
extra : rebase_source : 34bb71f7d64d08968cd6b52760cf4d36a61cb29d
The window state concept was removed from WebDriver level 1.
MozReview-Commit-ID: 6cogstpDc0a
--HG--
extra : rebase_source : 539df9fed0761b8e9609f60c3f9b77b946829147
Since both these Rust programs are hosted in mozilla-central,
they are governed by the top-level LICENSE file. See also
toolkit/content/license.html.
MozReview-Commit-ID: 4C0fEAeJZ6h
--HG--
extra : rebase_source : f8beebd578cd816d974cc9416c6bdb1bdfa37b12
In geckodriver we need a better control about the behavior of the
crash reporter. It should be enabled by default if possible, but
never show its window when a crash actually happens. Both settings
will allow us later to analyze the generated minidump files.
Further the crash reporter will shutdown Firefox now in case of
content crashes. This prevents a possible hang of Marionette
when a command in content gets executed and the framescript
gets disconnected.
MozReview-Commit-ID: DV1E7yQlElM
--HG--
extra : rebase_source : 6273a2f45fbe5f1b21c099ed8efcea44d72ec8e3
The login reputation checks depend on a server lookup and therefore would
render non-deterministic the performance and correctness of tests.
MozReview-Commit-ID: Bil0rSZsGPT
--HG--
extra : rebase_source : ae06a028c71eee323307ecd4e62bbf1e8a14fe13
This should have been done when blockedURIs was added (bug 1237198),
when safebrowsing.enabled was renamed (bug 1025965), and when the
forbidden list format was removed (bug 1274893).
MozReview-Commit-ID: AUWR5Efcb2x
--HG--
extra : rebase_source : 990bbd4ba7a6daaa08928a697e72f2d6b5b39a5a
The login reputation checks depend on a server lookup and therefore would
render non-deterministic the performance and correctness of tests.
MozReview-Commit-ID: Bil0rSZsGPT
--HG--
extra : rebase_source : c9a641e4bf49c48bf864ed546bf2ae6eb51c27e4
This should have been done when blockedURIs was added (bug 1237198),
when safebrowsing.enabled was renamed (bug 1025965), and when the
forbidden list format was removed (bug 1274893).
MozReview-Commit-ID: AUWR5Efcb2x
--HG--
extra : rebase_source : 533b2e2296d1fe70d6c334bb1766ca26679d224f
The WebDriverCommand::FullscreenWindow command maps to an unknown
Marionette command "fullscreenWindow". The correct command is
"fullscreen".
MozReview-Commit-ID: 4th2TYcIbP2
--HG--
extra : rebase_source : 2fcd79984a31962aa18bb10b15a487907707fe8f
In case the NewSession command fails due to errors returned
by Marionette, the browser has to be killed. This is necessary
because DeleteSession always requires an existent session, and
would fail in closing the browser. So the process would continue
to be alive.
MozReview-Commit-ID: 1llX4lPNYjN
--HG--
extra : rebase_source : 0da6529e2c09358c83760fc66c997db09665e304
To allow geckodriver to create file objects in child processes, this
preference has to be set to true. As such it needs to be recommended
in Marionette and set as default preference for geckodriver.
MozReview-Commit-ID: 8bdbi5jH6Vc
--HG--
extra : rebase_source : cc8963d2b15357b6d1607854e978aa764fcbd42f
Upgrades the webdriver crate dependency to 0.29.0, which contains some
backwards incompatible changes for RectResponse. This type has been
split in two, WindowRectResponse and ElementRectResponse.
The former type contains a new "state" field which is already implemented
by Marionette. Because geckodriver is used with a range of earlier
Firefoxen, it defaults to "normal" window state if the field is not
returned from Marionette. This is acceptable.
MozReview-Commit-ID: FRxppRVmiZl
--HG--
extra : rebase_source : 4a86659f337598bb4f5623c51f5df288c8a5dd69
The marionette.defaultPrefs.port and marionette.logging preferences were
removed in https://bugzil.la/1344748, which shipped in Firefox 54.
Because the next version of geckodriver (0.19.0) will only support
Firefox 55 and greater, it is safe to remove the fallbacks.
MozReview-Commit-ID: 4fhtoRasqyB
--HG--
extra : rebase_source : 0ac6dff0343efd66312a482f2be832e95013be48
browser.dom.window.dump.enabled causes the browser console messages to
reach stdout, often confusing geckodriver users.
We don’t recommend this preference in the Marionette server, although
it is set in geckoinstance.py. This seems appropriate to the Gecko
developer audience.
Use of the dump() statement will of course still be possible in chrome
level code.
MozReview-Commit-ID: 7s7WlV2COBQ
--HG--
extra : rebase_source : 146d81109dbc547bcd1aeafe1c13ff632e90b73f
This allows tests that use Geckodriver remotely to more easily install
addons. The base64 blob is written to a temporary file before being
passed on to Marionette.
MozReview-Commit-ID: DnaBqoXCj5
--HG--
extra : rebase_source : 0c3f37b65fcb47c5a1389348e34f19b98c8183d5
The canonical geckodriver source code no longer lives on GitHub, but
in mozilla-central's testing/geckodriver directory. Linking through
searchfox.org because it provides a better UI than hg.mozilla.org.
MozReview-Commit-ID: LmnviuC7Z9Y
--HG--
extra : rebase_source : 23f0e669bd719c595300d4e7ac38bc12f4937f57
Upgrades the mozrunner crate dependency by pinning it to 0.4.1. With `./mach vendor rust' I could not find any other way to force a new version to be downloaded because cargo, as far as I understand, does not yet support using crates.io as a fallback.
This patch also pins the mozprofile and mozversion dependencies exactly, although this is strictly not needed yet because they we have the latest versions vendored in-tree.
MozReview-Commit-ID: 8emDKbiYd0S
--HG--
extra : rebase_source : c153506f481255b2f9362e94da3254013ad522ab
Overhaul of geckodriver's README to include more detailed information
about picking up prepared profiles from the filesystem using the args
capability in moz:firefoxOptions. It also includes a short example
on running Firefox in headless mode, which is available on some modern
Firefoxen on certain systems.
Also updates build instructions now that geckodriver lives in-tree.
MozReview-Commit-ID: AoJtpULBctH
--HG--
extra : rebase_source : 3697262f7050778ee1bc81ff4c26d51bf2cf86d4
Removes .version file ignore from .gitignore and creates a
testing/geckodriver/.hgignore rule file for parity with git.
MozReview-Commit-ID: HXgbLxeleAl
--HG--
extra : rebase_source : 8c1f919a77351378a580ab161e9660c5868e881f
The GetNamedCookie command currently returns a JSON Array of one,
retained cookie, after it has removed the cookies that don't match by
name.
This is in violation of the WebDriver specification, which says it must
return the cookie serialisation directly.
MozReview-Commit-ID: 9yEiarEGBez
--HG--
extra : rebase_source : ec393eec712a6f957cee22d261bcd9ed13c6ec5b
The "timeouts" command could have been removed in Firefox 55, and
"quitApplication" can be removed with Firefox 56.
MozReview-Commit-ID: Fe7x8Yy0vSb
--HG--
extra : rebase_source : fc8b2c3c27f76a472cbdd8681efff06ca60e00f7
The GetNamedCookie command currently returns a JSON Array of one,
retained cookie, after it has removed the cookies that don't match by
name.
This is in violation of the WebDriver specification, which says it must
return the cookie serialisation directly.
MozReview-Commit-ID: 9yEiarEGBez
--HG--
extra : rebase_source : ad4acfb9510354a86a0b604cacf32cfd5c4f8e5d
Because we no longer can tag geckodriver releases in mozilla-central,
we need to include build information in the program itself. In the
version information message displayed when passing the --version flag,
we now include the current tip's SHA1 and build date following the
version number.
This patch could be made simpler by dumping this information correctly
formatted into a text file in the output directory, but it was requested
in https://bugzilla.mozilla.org/show_bug.cgi?id=1374977 to also include
the version information in the log output, which means we need to access
it differently and in different places.
MozReview-Commit-ID: CbFQn7IV8ew
--HG--
extra : rebase_source : dcc38ba7b5f209e9878755d5d75b611e22b5253d