Commit Graph

862 Commits

Author SHA1 Message Date
Boris Zbarsky
c878a8bb26 Bug 1619112 part 2. Pass char literals instead of char16_t literals into ErrorResult throwing methods. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D65538

--HG--
extra : moz-landing-system : lando
2020-03-06 21:04:58 +00:00
Kris Maglione
c31aa68fb4 Bug 1535617: Part 2 - Clear weak references for most cycle collected objects on unlink. r=mccr8
This covers most cycle collected objects which support weak references, but
not the ones which inherit from a cycle collected class and don't do any cycle
collection on their own.

Differential Revision: https://phabricator.services.mozilla.com/D63962

--HG--
extra : moz-landing-system : lando
2020-02-25 19:44:39 +00:00
Eric Rahm
b9ba9be64d Bug 1322095 - Part 1b: Update callbacks to support moved args and convert nsAutoPtr usage. r=jya
In order to support the update to move args when invoking callbacks we:
 - Convert anything that was using WrapRunnable with `nsAutoPtr` to `UniquePtr`
 - Convert anything that was using a non-const ref as a param to either a
   const ref or a by-val copy

Addtionally we convert the remaining `nsAutoPtr` usage to `UniquePtr`.

Differential Revision: https://phabricator.services.mozilla.com/D59961

--HG--
extra : moz-landing-system : lando
2020-02-21 22:43:53 +00:00
David Major
c4e3b2d209 Bug 1613606 - Bonus cleanup of IPC::Principals r=nika
All of these call sites were unnecessarily converting nsIPrincipal* => IPC::Principal => nsIPrincipal*.

Differential Revision: https://phabricator.services.mozilla.com/D62327

--HG--
extra : moz-landing-system : lando
2020-02-10 20:52:56 +00:00
Edgar Chen
9e846bd48a bug 1610296 - Rename TypedArray_base::ComputeLengthAndData to TypedArray_base::ComputeState; r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D60514

--HG--
extra : moz-landing-system : lando
2020-01-23 03:22:06 +00:00
Coroiu Cristina
73c0827187 Backed out 2 changesets (bug 1322095) for build bustage at dist/include/mtransport/runnable_utils.h on a CLOSED TREE
Backed out changeset 14e115ba7f12 (bug 1322095)
Backed out changeset 078c0fe497b7 (bug 1322095)
2020-01-23 19:50:51 +02:00
Eric Rahm
e120eee6b8 Bug 1322095 - Part 1b: Update callbacks to support moved args and convert nsAutoPtr usage. r=jya
In order to support the update to move args when invoking callbacks we:
 - Convert anything that was using WrapRunnable with `nsAutoPtr` to `UniquePtr`
 - Convert anything that was using a non-const ref as a param to either a
   const ref or a by-val copy

Addtionally we convert the remaining `nsAutoPtr` usage to `UniquePtr`.

Differential Revision: https://phabricator.services.mozilla.com/D59961

--HG--
extra : moz-landing-system : lando
2020-01-23 17:38:18 +00:00
Gabriele Svelto
ace6d1063f Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55442

--HG--
extra : moz-landing-system : lando
2019-12-06 09:24:56 +00:00
Boris Zbarsky
75124bdd98 Bug 1517588. Use nsIPrincipal::IsSystemPrincipal instead of nsContentUtils::IsSystemPrincipal r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D53067

--HG--
extra : moz-landing-system : lando
2019-12-05 04:44:32 +00:00
Dorel Luca
a381d5c96d Backed out changeset f6e53d1c6518 (bug 1600545) for Android build bustage. CLOSED TREE 2019-12-04 17:32:27 +02:00
Gabriele Svelto
bc9290f767 Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55442

--HG--
extra : moz-landing-system : lando
2019-12-04 15:01:19 +00:00
Boris Zbarsky
6b410b5b48 Bug 927610 part 1. Stop using NS_ERROR_TYPE_ERR in UDPSocket. r=smaug
The only ways DispatchReceivedData can fail are if our scope is torn down, we
OOM when creating a typed array, or we fail to queue a runnable.  These all
seem like pretty unexpected situations, so NS_ERROR_UNEXPECTED seems
appropriate if we don't want to just propagate through the error from
DispatchReceivedData.

Differential Revision: https://phabricator.services.mozilla.com/D46483

--HG--
extra : moz-landing-system : lando
2019-09-24 16:53:44 +00:00
Boris Zbarsky
e26682d684 Bug 1581173 part 1. Add a way to more easily throw TypeErrors and RangeErrors with custom message strings via ErrorResult. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45932

--HG--
extra : moz-landing-system : lando
2019-09-20 02:19:18 +00:00
Byron Campen [:bwc]
fec8b0d807 Bug 1569183: Stop doing a proxy lookup to determine whether we're configured to use a proxy (for the proxy_only_if_behind_proxy pref), and instead look at whether we loaded the doc using a proxy. r=mjf,mayhemer,jld
Differential Revision: https://phabricator.services.mozilla.com/D45289

--HG--
extra : moz-landing-system : lando
2019-09-18 14:27:42 +00:00
Byron Campen [:bwc]
57de6c6130 Bug 1569183: Remove some stuff from TCPSocket that NrTcpSocketIpc was the only user of. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D45112

--HG--
extra : moz-landing-system : lando
2019-09-17 18:18:15 +00:00
Mark Banner
351d147e2f Bug 1577746 - Enable ESLint rule object-shorthand for dom/. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D44149

--HG--
extra : moz-landing-system : lando
2019-09-02 11:22:27 +00:00
Barret Rennie
c5fb688d6a Bug 1289211 - Rename InfallibleTArray to nsTArray in dom/network/ r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D36947

--HG--
extra : moz-landing-system : lando
2019-07-10 03:27:30 +00:00
Victor Porof
0a8ff0ad85 Bug 1561435 - Format dom/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35951

--HG--
extra : source : 62f3501af4bc1c0bd1ee1977a28aee04706a6663
2019-07-05 10:44:55 +02:00
Mark Banner
c51c2a8807 Bug 1558822 - Fix more issues related to shadowing of variables in dom/ code. r=perry
Differential Revision: https://phabricator.services.mozilla.com/D34760

--HG--
extra : moz-landing-system : lando
2019-06-14 18:04:01 +00:00
Boris Zbarsky
a4410ccb51 Bug 1558726. Stop using [array] in nsISocketTransportService. r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D34668

--HG--
extra : moz-landing-system : lando
2019-06-13 04:21:32 +00:00
Boris Zbarsky
8e413da004 Bug 1558738. Stop using [array] in nsIUDPSocket. r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D34672

--HG--
extra : moz-landing-system : lando
2019-06-12 07:00:01 +00:00
Sylvestre Ledru
d57d4905f1 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D30883

--HG--
extra : moz-landing-system : lando
2019-05-25 17:46:15 +00:00
arthur.iakab
af8e458c5f Backed out changeset a296439a25ff (bug 1519636) for frequent Windows cppunit failures CLOSED TREE 2019-05-24 14:26:01 +03:00
Sylvestre Ledru
c82ea97226 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D30883

--HG--
extra : moz-landing-system : lando
2019-05-24 09:59:17 +00:00
Boris Zbarsky
e26cc00e3e Bug 1550364 part 6. Stop using [array] in nsIUDPSocketInternal. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30449

--HG--
extra : moz-landing-system : lando
2019-05-09 06:55:07 +00:00
Boris Zbarsky
5ae4d7046a Bug 1550364 part 5. Get rid of nsIUDPSocketChild. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30448

--HG--
extra : moz-landing-system : lando
2019-05-09 06:55:06 +00:00
Boris Zbarsky
941d39f649 Bug 1550364 part 4. Move various methods from nsIUDPSocketChild to dom::UDPSocketChild, and simplify their signatures where possible. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30447

--HG--
extra : moz-landing-system : lando
2019-05-09 06:55:06 +00:00
Boris Zbarsky
7299b02992 Bug 1550364 part 3. Remove unused nsIUDPSocketChild methods. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30446

--HG--
extra : moz-landing-system : lando
2019-05-09 06:55:06 +00:00
Boris Zbarsky
86aa098b68 Bug 1550364 part 2. Use dom::UDPSocketChild, not nsIUDPSocketChild, in C++ code. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30445

--HG--
extra : moz-landing-system : lando
2019-05-09 06:55:05 +00:00
Boris Zbarsky
70b91760d9 Bug 1550364 part 1. Stop claiming nsIUDPSocketChild is scriptable, since we never use it from script. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30444

--HG--
extra : moz-landing-system : lando
2019-05-09 06:55:05 +00:00
Kershaw Chang
6bd2b36d88 Bug 1542593 - Don't access gNeckoChild if not on main thread r=jdm
gNeckoChild is only accessed on main thread, so we should use NS_IsMainThread to see whether we should access gNeckoChild or not.
This patch also makes UDPSocketChild::Bind return NS_ERROR_NOT_AVAILABLE when mBackgroundManager is null.

Differential Revision: https://phabricator.services.mozilla.com/D29658

--HG--
extra : moz-landing-system : lando
2019-05-02 17:29:46 +00:00
Kershaw Chang
3aad5c69c2 Bug 1541114 - Check mIPCOpen before sending messages r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D27869

--HG--
extra : moz-landing-system : lando
2019-05-02 12:00:57 +00:00
Sebastian Streich
8ac88db494 Bug 1444503 - Remove the IPC::Principal r=ckerschb,nika
***
Removed IPC References in PCContent
***
Removed IPC References on nsContentPermissionHelper
***
 Remove IPC Principal from PBrowser
***
Remove IPCPrincipal from the PaymentRequest
***
Remove IPCPrincipal from the PPresentation
***
Remove IPC Principal from PNecko

Differential Revision: https://phabricator.services.mozilla.com/D28650

--HG--
extra : moz-landing-system : lando
2019-04-25 14:18:11 +00:00
Ryan Hunt
d6509bb237 Bug 1534395 - Rename TabChild to BrowserChild. r=nika
This commit renames TabChild to BrowserChild.

Differential Revision: https://phabricator.services.mozilla.com/D28135

--HG--
rename : dom/base/InProcessTabChildMessageManager.cpp => dom/base/InProcessBrowserChildMessageManager.cpp
rename : dom/base/InProcessTabChildMessageManager.h => dom/base/InProcessBrowserChildMessageManager.h
rename : dom/ipc/TabChild.cpp => dom/ipc/BrowserChild.cpp
rename : dom/ipc/TabChild.h => dom/ipc/BrowserChild.h
extra : rebase_source : e7fcfb845a971a2760e73d517e24da18ce2551b5
extra : histedit_source : d1991334ccb107fe56e478865f22fd97b041a317
2019-04-09 17:39:01 -05:00
Ryan Hunt
0eeced87be Bug 1534395 - Rename TabParent to BrowserParent. r=nika
This commit renames TabParent to BrowserParent.

Differential Revision: https://phabricator.services.mozilla.com/D28133

--HG--
rename : dom/ipc/TabParent.cpp => dom/ipc/BrowserParent.cpp
rename : dom/ipc/TabParent.h => dom/ipc/BrowserParent.h
extra : rebase_source : d2706b9f42177d8de16068b7b1d088a44b8720a4
extra : histedit_source : a617ddac45c58050ef799116a67d2d983f2a8f6d%2C1d1dabd8761a32d548a6fbf1027be960698f6a5e
2019-04-09 16:38:15 -05:00
Brian Grinstead
381332c51e Bug 1544051 - Part 3 - Scripted change to remove references to AddTask.js r=ahal
This was generated with the script at https://bug1544051.bmoattachments.org/attachment.cgi?id=9058672

Differential Revision: https://phabricator.services.mozilla.com/D27761

--HG--
extra : moz-landing-system : lando
2019-04-18 16:51:01 +00:00
Brian Grinstead
0d460e3432 Bug 1544322 - Part 2.2 - Remove the [type] attribute for one-liner <script> tags loading files in /tests/SimpleTest/ in dom/ r=bzbarsky
This is split from the previous changeset since if we include dom/ the file size is too
large for phabricator to handle.

This is an autogenerated commit to handle scripts loading mochitest harness files, in
the simple case where the script src is on the same line as the tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 2` argument.

Differential Revision: https://phabricator.services.mozilla.com/D27457

--HG--
extra : moz-landing-system : lando
2019-04-16 03:53:28 +00:00
Brian Grinstead
6515f97bcb Bug 1544322 - Part 1 - Remove the [type] attribute for one-liner <script> tags loading files in chrome://mochikit/content/ r=bzbarsky
This is an autogenerated commit to handle scripts loading mochitest harness files, in
the simple case where the script src is on the same line as the tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 1` argument.

Differential Revision: https://phabricator.services.mozilla.com/D26812

--HG--
extra : moz-landing-system : lando
2019-04-15 20:56:58 +00:00
Bogdan Tara
a4db304253 Backed out changeset 1cf54b6a1c90 (bug 1541114) for causing crashes a=backout 2019-04-13 00:58:11 +03:00
Kershaw Chang
d6000c3224 Bug 1541114 - Check mIPCOpen before sending messages r=mayhemer
To avoid sending ipc messages after the ipc channel is closed, check |mIPCOpen| before sending messages.

Differential Revision: https://phabricator.services.mozilla.com/D26089

--HG--
extra : moz-landing-system : lando
2019-04-12 05:04:22 +00:00
Andrea Marchesini
484db81418 Bug 1455020 - Extend CheckInnerWindowCorrectness() to check the state of the worker, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D25486

--HG--
extra : moz-landing-system : lando
2019-04-01 16:46:46 +00:00
Sylvestre Ledru
4aa92e3091 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D22514
2019-03-13 10:19:06 +01:00
Andrea Marchesini
edd4b23c65 Bug 1531071 - Add OOM check in TCPSocketParent, r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D23146

--HG--
extra : moz-landing-system : lando
2019-03-12 15:10:03 +00:00
Alex Gaynor
d3a1bdd83c Bug 1532368 - replace OptionalPrincipalInfo with PrincipalInfo? in IPDL; r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D21972

--HG--
extra : moz-landing-system : lando
2019-03-05 14:41:42 +00:00
Jeff Walden
3f385ffa33 Bug 1532005 - Implement a new js/public/ArrayBuffer.h header to centralize functionality for creating and interacting with ArrayBuffers. r=sfink
Differential Revision: https://phabricator.services.mozilla.com/D21827

--HG--
extra : rebase_source : 833bbfce12d90bcb92f7cd88ec65247e48c024c0
2019-03-04 15:19:16 -08:00
Razvan Maries
65e4948ca0 Backed out 4 changesets (bug 1532005, bug 1531638) for causing perma fails and Spidermonkey fail. CLOSED TREE
Backed out changeset 4913d941de92 (bug 1532005)
Backed out changeset 9635abe5bf24 (bug 1532005)
Backed out changeset 738cf4b1126a (bug 1532005)
Backed out changeset e5d9f2ee7ac7 (bug 1531638)
2019-03-05 01:07:28 +02:00
Jeff Walden
ecb4e10bda Bug 1532005 - Implement a new js/public/ArrayBuffer.h header to centralize functionality for creating and interacting with ArrayBuffers. r=sfink
Differential Revision: https://phabricator.services.mozilla.com/D21827

--HG--
extra : rebase_source : 36c43233ad6d804bd691c8c40d6a6984331c7162
2019-02-28 17:00:56 -08:00
Ryan Hunt
00e98538aa Bug 1523969 part 6 - Move method definition inline comments to new line in 'dom/'. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D21106

--HG--
extra : rebase_source : ea3f51c2c11247114deccbc86e90fb02b8a97257
2019-02-25 16:05:29 -06:00
Jonathan Kingston
f6680698bd Bug 1525319 - Removing context from OnDataAvailable r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20881

--HG--
extra : moz-landing-system : lando
2019-02-27 23:42:27 +00:00
Jonathan Kingston
c4853316e7 Bug 1525319 - Removing context from OnStopRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20770

--HG--
extra : moz-landing-system : lando
2019-02-27 23:41:31 +00:00