Commit Graph

8418 Commits

Author SHA1 Message Date
Matthew Noorenberghe
c9c34fda3f Bug 1598717 - Only set display:block on password generation richlistitems that aren't collapsed.
Also remove dateAndTimeFormatter creation overhead.

Differential Revision: https://phabricator.services.mozilla.com/D56851

--HG--
extra : moz-landing-system : lando
2019-12-12 06:25:12 +00:00
Kearwood Kip Gilbert
19ba3b0322 Bug 1580567 - Implement XR device access permission UI r=fluent-reviewers,bzbarsky,pbz,daoshengmu,imanol
Added @rbarker as a reviewer to check if this will work well within GeckoView for FxR / Android.
Added @bzbarsky for test_interfaces.html.  -- I'd like to re-land the secure origin requirement for WebVR as part of this patch, as it doesn't help to have UI that can't guarantee the identity of the origin.  (This was backed out due to test failures originally, and since been fixed)

Differential Revision: https://phabricator.services.mozilla.com/D45951

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
extra : moz-landing-system : lando
2019-12-12 03:10:51 +00:00
Mark Hammond
5a897829db Bug 1598979 - make the device name in the sync-tabs menu visible to screen readers. r=Gijs,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D56677

--HG--
extra : moz-landing-system : lando
2019-12-11 23:45:55 +00:00
Brindusan Cristian
9c36dcbf23 Backed out 2 changesets (bug 1580567, bug 1599927) for mochitest failures at test_interfaces.html. CLOSED TREE
Backed out changeset 0e0d88942d33 (bug 1599927)
Backed out changeset 522c8d183bd5 (bug 1580567)

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js
2019-12-11 05:31:08 +02:00
Kearwood Kip Gilbert
7c8ce74b8f Bug 1580567 - Implement XR device access permission UI r=fluent-reviewers,bzbarsky,pbz,daoshengmu,imanol
Added @rbarker as a reviewer to check if this will work well within GeckoView for FxR / Android.
Added @bzbarsky for test_interfaces.html.  -- I'd like to re-land the secure origin requirement for WebVR as part of this patch, as it doesn't help to have UI that can't guarantee the identity of the origin.  (This was backed out due to test failures originally, and since been fixed)

Differential Revision: https://phabricator.services.mozilla.com/D45951

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
extra : moz-landing-system : lando
2019-12-11 01:38:17 +00:00
shindli
652f3b0296 Backed out 2 changesets (bug 1580567, bug 1599927) for causing permafailures in dom/tests/mochitest/general/test_interfaces.html CLOSED TREE
Backed out changeset aeceec922866 (bug 1599927)
Backed out changeset 29809135f18e (bug 1580567)

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js
2019-12-11 03:32:44 +02:00
Kearwood Kip Gilbert
6a9c22db45 Bug 1580567 - Implement XR device access permission UI r=fluent-reviewers,bzbarsky,pbz,daoshengmu,imanol
Added @rbarker as a reviewer to check if this will work well within GeckoView for FxR / Android.
Added @bzbarsky for test_interfaces.html.  -- I'd like to re-land the secure origin requirement for WebVR as part of this patch, as it doesn't help to have UI that can't guarantee the identity of the origin.  (This was backed out due to test failures originally, and since been fixed)

Differential Revision: https://phabricator.services.mozilla.com/D45951

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
extra : moz-landing-system : lando
2019-12-10 23:55:05 +00:00
Kirk Steuber
589b7532ea Bug 1585482 - Restructure all <xul:dialog> usages such that they are not the top level element r=bgrins
This patch also includes necessary JS changes to support this. Most commonly, the dialog was accessed with document.documentElement, which needed to be changed now that the dialog is not the top level element.

Differential Revision: https://phabricator.services.mozilla.com/D52411

--HG--
extra : moz-landing-system : lando
2019-12-10 18:25:59 +00:00
Itiel
b51c7bc9fa Bug 1601345 - Replace the "<< Go Back" text link in about:preferences#containers with a button r=Gijs,fluent-reviewers
Also fix the styling of containers to have their separators centered vertically, and make them stretch to the end.

Differential Revision: https://phabricator.services.mozilla.com/D55839

--HG--
extra : moz-landing-system : lando
2019-12-10 05:09:30 +00:00
Emma Malysz
c233a3dd80 Bug 1599444, allow users to delete past telemetry data within about:preferences#privacy r=fluent-reviewers,Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D55569

--HG--
extra : moz-landing-system : lando
2019-12-09 21:01:29 +00:00
Arthur Iakab
cb13cb47be Backed out changeset 9cf05aa4c43c (bug 1599444) for causing mass browser-chrome failures CLOSED TREE 2019-12-06 22:50:31 +02:00
Emma Malysz
7718d22ba1 Bug 1599444, allow users to delete past telemetry data within about:preferences#privacy r=fluent-reviewers,Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D55569

--HG--
extra : moz-landing-system : lando
2019-12-06 18:50:54 +00:00
Andrei Oprea
a06612790c Bug 1596118 - Remove fxa accounts badge that has been replaced by Messaging System badging r=eoger,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D52843

--HG--
extra : moz-landing-system : lando
2019-12-06 13:53:07 +00:00
Matthew Noorenberghe
beec957175 Bug 1598717 - Make the line-height of the 3 password generation lines consistent. r=sfoster
Also increase the min-width for password generation popups so at least en-US doesn't wrap.

Depends on D55742

Differential Revision: https://phabricator.services.mozilla.com/D55743

--HG--
extra : moz-landing-system : lando
2019-12-04 20:57:54 +00:00
Matthew Noorenberghe
a55e089037 Bug 1598717 - Wrap the "Firefox will save this password for this website" text. r=sfoster
Depends on D55741

Differential Revision: https://phabricator.services.mozilla.com/D55742

--HG--
extra : moz-landing-system : lando
2019-12-04 21:08:46 +00:00
Razvan Maries
30d4c4f26d Backed out changeset 15f8fa34d2f4 (bug 1580567) for perma fails on browser_temporary_permissions_expiry.js and browser_privatebrowsing_rememberprompt.js. CLOSED TREE
--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js
2019-12-05 01:05:34 +02:00
Kearwood Kip Gilbert
ef6bdce0ec Bug 1580567 - Implement XR device access permission UI r=fluent-reviewers,bzbarsky,pbz,daoshengmu,imanol
Added @rbarker as a reviewer to check if this will work well within GeckoView for FxR / Android.
Added @bzbarsky for test_interfaces.html.  -- I'd like to re-land the secure origin requirement for WebVR as part of this patch, as it doesn't help to have UI that can't guarantee the identity of the origin.  (This was backed out due to test failures originally, and since been fixed)

Differential Revision: https://phabricator.services.mozilla.com/D45951

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
extra : moz-landing-system : lando
2019-12-04 21:10:56 +00:00
Itiel
d045f2ca65 Bug 1600748 - Fix styling of the device name section on the Sync tab in about:preferences r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D55539

--HG--
extra : moz-landing-system : lando
2019-12-03 21:51:21 +00:00
Kirk Steuber
ea4c4eb27f Bug 1599258 - Ensure that unexpected body elements don't end up with display:-moz-box r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D55531

--HG--
extra : moz-landing-system : lando
2019-12-02 21:02:00 +00:00
Erica Wright
524384c096 Bug 1599778 - Info message fades below the main content panel. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D55181

--HG--
extra : moz-landing-system : lando
2019-11-28 20:35:06 +00:00
Tim Nguyen
cdbba16564 Bug 1600138 - Clean up update-icon.svg and addon-private-browsing.svg. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D55175

--HG--
extra : moz-landing-system : lando
2019-11-29 16:38:52 +00:00
Harry Twyford
0574e3e5a1 Bug 1597221 - Use Urlbar width instead of screen width for the 2-line layout. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D54584

--HG--
extra : moz-landing-system : lando
2019-11-28 19:52:20 +00:00
Dão Gottwald
0e0e7832ed Bug 1590759 - Ensure webextension theme's toolbar_field_text_focus is visible when overriding toolbar_field_focus' alpha value. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D55093

--HG--
extra : moz-landing-system : lando
2019-11-28 15:11:14 +00:00
Matthew Noorenberghe
7dca7daa86 Bug 1599752 - Partial back out of changeset c72321ba48b8 to remove subdomain suggestions in the context menu.
Differential Revision: https://phabricator.services.mozilla.com/D54937

--HG--
extra : moz-landing-system : lando
2019-11-27 14:25:19 +00:00
Harry Twyford
4f99373ef5 Bug 1599123 - Rename instances of "search icon" to "search button". r=mak
Differential Revision: https://phabricator.services.mozilla.com/D54539

--HG--
extra : moz-landing-system : lando
2019-11-26 09:38:02 +00:00
Harry Twyford
9b61c484ab Bug 1597698 - Move all megabar prefs under a urlbar.update1 branch. r=mak,dao
Differential Revision: https://phabricator.services.mozilla.com/D54146

--HG--
extra : moz-landing-system : lando
2019-11-26 17:15:31 +00:00
Sylvestre Ledru
e94f355d96 Bug 1596911 - Add missing license headers on the new managed extensions r=Gijs,MattN
Depends on D53267

Differential Revision: https://phabricator.services.mozilla.com/D53269

--HG--
extra : moz-landing-system : lando
2019-11-26 15:00:00 +00:00
Mike Conley
d4899e5209 Bug 1598886 - Mirror the Picture-in-Picture icons for RTL locales. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D54582

--HG--
extra : moz-landing-system : lando
2019-11-25 20:19:30 +00:00
Harry Twyford
6192f9f83e Bug 1599217 - Clean up child selectors regressed by bug 1586284. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D54593

--HG--
extra : moz-landing-system : lando
2019-11-25 20:11:27 +00:00
Marco Bonardo
7a05ce8403 Bug 1597086 - Limit size of the search bar panel. r=Standard8
Wrapping one-off buttons into a container confuses layout that lets the richlist
box to grow unconditionally. This problem is already partially visible by
opening the searchbar continuously, sometimes strings are not properly overflowing
with ellipsis, they are just overflowing.
Setting a width on the panel limits its size properly, though this won't fix the
layout sometimes not properly cutting the richlistbox. It's likely there an
underlying bug in the widget or calculations when widgets are not visible.

This also correctly forces showing at least 3 one-off buttons per row, the
existing code is not sufficient for that because search-one-offs.js sets a
max-width that is smaller than 3 buttons.

Similarly, it corrects a calculation in the urlbar one-offs, where we should
show at least 4 buttons, but due to a not considered margin we only show 3.

Finally, this removes a few rules that are not necessary with the current design.

Differential Revision: https://phabricator.services.mozilla.com/D53968

--HG--
extra : moz-landing-system : lando
2019-11-25 13:48:04 +00:00
Matthew Noorenberghe
66f2568013 Bug 1566536 - Support password generation in private windows. r=sfoster
* Inform users in autocomplete that using a generated password will cause it to be automatically saved.
* Don't fill generated passwords from the context menu directly, that menu item (renamed) should simply force the generation UI to appear in autocomplete.

Differential Revision: https://phabricator.services.mozilla.com/D54338

--HG--
extra : moz-landing-system : lando
2019-11-23 03:26:03 +00:00
Tim Nguyen
dc104f14fc Bug 1597120 - Replace usages of XUL mousethrough with CSS pointer-events. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D53348

--HG--
extra : moz-landing-system : lando
2019-11-22 13:15:00 +00:00
Marco Bonardo
dea2608089 Bug 1586284 - Modify the flex layout to give urls more space on small screens. r=dao
Let the url wrap, when the screen size is smaller than a threshold.
Along with a new proposal by Verdi for the toolbar overflow behavior, this
allows the urlbar to stay usable in small windows.

Because the title in Quantum Bar should never be empty, a few rules can be
simplified, so they also apply to the url when it's not a sibling of the other
result parts.

Differential Revision: https://phabricator.services.mozilla.com/D53178

--HG--
extra : moz-landing-system : lando
2019-11-22 10:05:45 +00:00
Brian Grinstead
d497e5fd20 Bug 1596591 - Rename inc.xul files to inc.xhtml r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D53843

--HG--
rename : browser/base/content/browser-allTabsMenu.inc.xul => browser/base/content/browser-allTabsMenu.inc.xhtml
rename : browser/base/content/macWindow.inc.xul => browser/base/content/macWindow.inc.xhtml
rename : browser/components/controlcenter/content/identityPanel.inc.xul => browser/components/controlcenter/content/identityPanel.inc.xhtml
rename : browser/components/controlcenter/content/protectionsPanel.inc.xul => browser/components/controlcenter/content/protectionsPanel.inc.xhtml
rename : browser/components/customizableui/content/customizeMode.inc.xul => browser/components/customizableui/content/customizeMode.inc.xhtml
rename : browser/components/customizableui/content/panelUI.inc.xul => browser/components/customizableui/content/panelUI.inc.xhtml
rename : browser/components/downloads/content/downloadsCommands.inc.xul => browser/components/downloads/content/downloadsCommands.inc.xhtml
rename : browser/components/downloads/content/downloadsContextMenu.inc.xul => browser/components/downloads/content/downloadsContextMenu.inc.xhtml
rename : browser/components/downloads/content/downloadsPanel.inc.xul => browser/components/downloads/content/downloadsPanel.inc.xhtml
rename : browser/components/downloads/content/downloadsStrings.inc.xul => browser/components/downloads/content/downloadsStrings.inc.xhtml
rename : browser/components/places/content/bookmarksHistoryTooltip.inc.xul => browser/components/places/content/bookmarksHistoryTooltip.inc.xhtml
rename : browser/components/places/content/editBookmarkPanel.inc.xul => browser/components/places/content/editBookmarkPanel.inc.xhtml
rename : browser/components/places/content/placesCommands.inc.xul => browser/components/places/content/placesCommands.inc.xhtml
rename : browser/components/places/content/placesContextMenu.inc.xul => browser/components/places/content/placesContextMenu.inc.xhtml
extra : moz-landing-system : lando
2019-11-21 09:46:01 +00:00
Harry Twyford
d7c31e9a0d Bug 1593825 - Implement badged favicons. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D53148

--HG--
extra : moz-landing-system : lando
2019-11-21 14:58:15 +00:00
Harry Twyford
d3de0e27da Bug 1593664 - Add urlbar.megabar.expandTextOnFocus pref and increase font size to the equivalent of 15px on focus. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D53723

--HG--
extra : moz-landing-system : lando
2019-11-21 09:15:21 +00:00
Brendan Dahl
2ab3c9fcc8 Bug 1597068 - Revert navigator toolbox sheet anchor changes. r=dao
I'm not exactly sure what changed, but the changes from bug 149582 are no
longer needed to fix test_queryCaretRect.htm and the position of the
drop down dialog.

Differential Revision: https://phabricator.services.mozilla.com/D54066

--HG--
extra : moz-landing-system : lando
2019-11-21 09:12:04 +00:00
Tim Nguyen
3250ee2a10 Bug 1598034 - Fix misaligned question mark in CFR popup header. r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D53986

--HG--
extra : moz-landing-system : lando
2019-11-20 17:09:32 +00:00
Drew Willcoxon
174a54fc65 Bug 1597077 - Fix padding for tip results. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D53329

--HG--
extra : moz-landing-system : lando
2019-11-19 18:26:18 +00:00
Tim Nguyen
1d2e747df1 Bug 1529534 - Convert the page info dialog XUL grids to HTML tables. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D20643

--HG--
extra : moz-landing-system : lando
2019-11-19 16:50:58 +00:00
Marco Bonardo
5aa3cf5e49 Bug 1594062 - urlbar part - When selecting a one-off button with the keyboard, show action text on a search heuristic result. r=Standard8
When a one-off button is the only selection, and the heuristic result is the
a search, forcibly show its action text, so the search engine name is visible.

This doesn't handle cases where the heuristic results are not searches, because
it would be a lot more complex and involve heavy design changes. Those cases
should be less common, representing searches for urls or non-search strings on
other engines.

Differential Revision: https://phabricator.services.mozilla.com/D53785

--HG--
extra : moz-landing-system : lando
2019-11-19 15:53:59 +00:00
Tim Nguyen
492214c05c Bug 1596966 - Set min-height: 0 on <stack> children. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D53294

--HG--
extra : moz-landing-system : lando
2019-11-16 02:00:01 +00:00
Tim Nguyen
c4a4d07ff5 Bug 1596725 - Fix plugin icon and badge appearance. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D53265

--HG--
extra : moz-landing-system : lando
2019-11-15 22:50:13 +00:00
Dão Gottwald
aab7b9850f Bug 1596366 - Clean up selectors after bug 1492582. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D52983

--HG--
extra : moz-landing-system : lando
2019-11-15 17:23:26 +00:00
Harry Twyford
12ad663a2b Bug 1593965 - Use new drag & drop indicators for tabs and the bookmarks toolbar. r=mak,dao
Differential Revision: https://phabricator.services.mozilla.com/D52822

--HG--
extra : moz-landing-system : lando
2019-11-15 14:45:22 +00:00
Noemi Erli
7fe084de5f Backed out changeset 81b1c17310c2 (bug 1593965) for causing failures in browser_startup_images.js CLOSED TREE 2019-11-15 13:58:00 +02:00
Gijs Kruitbosch
5b1dbc026d Bug 1595772 - make overflow panel arrow position in customize mode more reliably correct, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D52934

--HG--
extra : moz-landing-system : lando
2019-11-15 10:25:06 +00:00
Harry Twyford
140236d492 Bug 1593965 - Use new drag & drop indicators for tabs and the bookmarks toolbar. r=mak,dao
Differential Revision: https://phabricator.services.mozilla.com/D52822

--HG--
extra : moz-landing-system : lando
2019-11-15 10:27:50 +00:00
Matthew Noorenberghe
5899ac5cb2 Bug 1200472 - Include subdomain login fill suggestions in the context menu. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D51354

--HG--
extra : moz-landing-system : lando
2019-11-15 01:03:48 +00:00
Kirk Steuber
2ad7a54783 Bug 1588142 - about:preferences - migrate the root xul:window element to an html:html element r=Gijs,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D51712

--HG--
extra : moz-landing-system : lando
2019-11-14 00:17:01 +00:00