Commit Graph

8079 Commits

Author SHA1 Message Date
Marco Zehe
c8821fff8b Bug 1608883 - Add test for multiple aria-details relations, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D64109

--HG--
extra : moz-landing-system : lando
2020-02-26 00:05:29 +00:00
James Teh
515c09fa73 Bug 1602692: Enable a11y tests for Fission which depend on TakeFocus. r=yzen
nsFocusManager::SetFocus (and thus Accessible::TakeFocus) was fixed for Fission in bug 1556627.
Most of these tests now pass without modification.
browser_caching_value.js needed to be tweaked slightly to synthesize a key in the OOP iframe instead of the top level document.

Differential Revision: https://phabricator.services.mozilla.com/D64254

--HG--
extra : moz-landing-system : lando
2020-02-26 00:36:02 +00:00
Eitan Isaacson
8e38a4587c Bug 1616466 - Support expand/collapse android accessibility actions. r=Jamie,geckoview-reviewers,snorp
Differential Revision: https://phabricator.services.mozilla.com/D63290

--HG--
extra : moz-landing-system : lando
2020-02-25 22:37:00 +00:00
Kris Maglione
f3354d4788 Bug 1617254: Rename BrowsingContext.getChildren() to .children. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D63699

--HG--
extra : moz-landing-system : lando
2020-02-25 22:33:53 +00:00
Arthur Iakab
73b6d9dca6 Backed out changeset 5616425b54da (bug 1617254)for casuing multiple browser-chrome failures.
CLOSED TREE
2020-02-26 00:09:34 +02:00
Kris Maglione
c65ef42473 Bug 1617254: Rename BrowsingContext.getChildren() to .children. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D63699

--HG--
extra : moz-landing-system : lando
2020-02-25 21:03:58 +00:00
Noemi Erli
6b488deed0 Backed out changeset 034e2e79ecfa (bug 1617254) for causing build bustages CLOSED TREE 2020-02-25 21:59:14 +02:00
Kris Maglione
c31aa68fb4 Bug 1535617: Part 2 - Clear weak references for most cycle collected objects on unlink. r=mccr8
This covers most cycle collected objects which support weak references, but
not the ones which inherit from a cycle collected class and don't do any cycle
collection on their own.

Differential Revision: https://phabricator.services.mozilla.com/D63962

--HG--
extra : moz-landing-system : lando
2020-02-25 19:44:39 +00:00
Kris Maglione
e4c4115afb Bug 1617254: Rename BrowsingContext.getChildren() to .children. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D63699

--HG--
extra : moz-landing-system : lando
2020-02-25 19:39:25 +00:00
Simon Giesecke
aaf6cb4e75 Bug 1617628 - Hide nsBaseHashtable Put overloads in nsRefPtrHashtable subclass. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63899

--HG--
extra : moz-landing-system : lando
2020-02-25 17:03:36 +00:00
Eitan Isaacson
9701de3f19 Bug 1614834 - Advertise and implement AXScrollToVisible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D63580

--HG--
extra : moz-landing-system : lando
2020-02-25 00:05:00 +00:00
Dorel Luca
2075a0e4ab Backed out changeset 0a9ee19aaa48 (bug 1614834) for Build bustages on /build/src/accessible/mac/mozAccessible.mm. CLOSED TREE 2020-02-24 21:03:51 +02:00
Eitan Isaacson
54ca0747e1 Bug 1614834 - Advertise and implement AXScrollToVisible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D63580

--HG--
extra : moz-landing-system : lando
2020-02-24 17:30:25 +00:00
Emilio Cobos Álvarez
8d0f4ce3ca Bug 1617472 - Remove kTextDecorationStyleKTable. r=heycam
In a somewhat easy way. There are better ways to do this (moving
text-decoration-style to be a proper cbindgen enum class or such), but this
does the job for now.

Depends on D63794

Differential Revision: https://phabricator.services.mozilla.com/D63795

--HG--
extra : moz-landing-system : lando
2020-02-24 13:30:46 +00:00
Emilio Cobos Álvarez
1ff4460ea3 Bug 1617472 - Remove kTextAlignKTable. r=heycam
Depends on D63793

Differential Revision: https://phabricator.services.mozilla.com/D63794

--HG--
extra : moz-landing-system : lando
2020-02-24 13:30:44 +00:00
Marco Zehe
a464412e8e Bug 1616851 - For grouping, calculate name from subtree if requested by other accessible object, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D63619

--HG--
extra : moz-landing-system : lando
2020-02-24 06:52:19 +00:00
James Teh
c604c6018c Bug 1616078: Don't use HTMLListBulletAccessible for CSS ::marker content. r=eeejay,emilio,MarcoZ
::marker content gets handled like text from any other CSS pseudo-class.
Therefore, using HTMLListBulletAccessible ends up duplicating the content already exposed in the a11y tree.
Now, we only use HTMLListBulletAccessible for nsBulletFrames instead of all marker frames.

As part of this, remove nsContainerFrame::GetSpokenMarkerContent, since we no longer need it to retrieve ::marker content.
The bulk of its other work was done by nsBulletFrame::GetSpokenContent, which we now call directly.
It also handled producing a default bullet character for list-style-image, but it makes sense for this to live in the a11y code.

Differential Revision: https://phabricator.services.mozilla.com/D63443

--HG--
extra : moz-landing-system : lando
2020-02-21 01:23:37 +00:00
Eitan Isaacson
1e2369f4ca Bug 1615562 - Don't move accessible focus if caret is collapsed or not on focusable. r=Jamie
If a keyboard-focused accessible is removed, the caret jumps to its
nearest ancestor. To avoid arbitrary accessibility focus moves, ignore
caret events that have no selection and are not focusable items.

Differential Revision: https://phabricator.services.mozilla.com/D63541

--HG--
extra : moz-landing-system : lando
2020-02-20 21:49:20 +00:00
Eitan Isaacson
777e8fba2d Bug 1616797 - Check that accessible's frame still exists in scroll dispatcher r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D63546

--HG--
extra : moz-landing-system : lando
2020-02-20 21:12:43 +00:00
Simon Giesecke
9350e6b741 Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.

Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.

Differential Revision: https://phabricator.services.mozilla.com/D62604

--HG--
extra : moz-landing-system : lando
2020-02-20 11:40:14 +00:00
Dorel Luca
d5f9df8ee1 Backed out 2 changesets (bug 1613985) for Build bustage on Windows2012. CLOSED TREE
Backed out changeset fd177b40b561 (bug 1613985)
Backed out changeset fb6d62b7f28d (bug 1613985)
2020-02-19 22:22:41 +02:00
Simon Giesecke
59b23375c0 Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.

Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.

Differential Revision: https://phabricator.services.mozilla.com/D62604

--HG--
extra : moz-landing-system : lando
2020-02-19 18:05:38 +00:00
James Teh
ac0a51e32c Bug 1596007: Fire an a11y state change event when an image's size becomes available. r=eeejay,emilio
Differential Revision: https://phabricator.services.mozilla.com/D62871

--HG--
extra : moz-landing-system : lando
2020-02-18 17:22:35 +00:00
Eitan Isaacson
5f6ff669bf Bug 1616146 - Cache accessibility focus boundaries in java. r=Jamie
This allows `performAction` to immediately return false if a boundary is
reached and allow TalkBack to navigate past the web view.

Change viewport cache listener to reorder since it should catch all tree
mutations in the document.

Differential Revision: https://phabricator.services.mozilla.com/D63117

--HG--
extra : moz-landing-system : lando
2020-02-18 21:09:06 +00:00
Mike Shal
d8e4653d19 Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
GENERATED_FILES now defaults to python3 unless py2=True is specified as
an argument. All existing GENERATED_FILES scripts and GeneratedFile
templates have the py2=True attribute added, so this patch should
effectively be a no-op.

Going forward, individual scripts can be converted to python3 and their
corresponding py2=True attribute can be deleted. In effect, this patch
will be backed out in pieces until all scripts run in python3, at which
point the py2 attribute itself can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D60919

--HG--
extra : moz-landing-system : lando
2020-02-14 13:22:46 +00:00
Mirko Brodesser
f170973369 Bug 1615581: part 1) Rename TableSelection to TableSelectionMode. r=jfkthame
See part 2) why this is necessary.

Differential Revision: https://phabricator.services.mozilla.com/D62902

--HG--
extra : moz-landing-system : lando
2020-02-18 12:28:45 +00:00
James Teh
809ba18b5c Bug 1505974: Include the subtree of role="alert" when referenced by aria-labelledby/describedby. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D63037

--HG--
extra : moz-landing-system : lando
2020-02-17 06:39:24 +00:00
James Teh
5fef6bfb48 Bug 1118086: When a menupopup is shown, if aria-activedescendant is set, redirect focus appropriately. r=eeejay
Normally, XUL menupopups contain XUL menuitems, and XUL menuitems fire DOMMenuitemActive events from layout to manage a11y focus.
However, the new parent process select dropdown implementation uses a menulist containing div elements instead of XUL menuitems.
DOMMenuItemActive doesn't work for div elements because we check Accessible::ContainerWidget(), and that doesn't know to return the menupopup for div elements.
Since aria-activedescendant is the more web standard way to handle this, the new select dropdown implementation uses aria-activedescendant.

Differential Revision: https://phabricator.services.mozilla.com/D62677

--HG--
extra : moz-landing-system : lando
2020-02-17 04:06:00 +00:00
Eitan Isaacson
a98323bb51 Bug 1611060 - Dispatch a11y scroll events for all DOM scrolls. r=Jamie
Currently, only documents dispatch scroll events when in reality any
element can have scrollable overflows.

Differential Revision: https://phabricator.services.mozilla.com/D62665

--HG--
extra : moz-landing-system : lando
2020-02-17 04:09:34 +00:00
Morgan Reschenberg
7c8049bbaf Bug 1611428: Add accessibilityLabel function to support aria-label on MacOS. r=eeejay,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D62470

--HG--
extra : moz-landing-system : lando
2020-02-14 21:20:27 +00:00
Eitan Isaacson
1fedcb34de Bug 1615502 - Support list items with display:contents. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D62947

--HG--
extra : moz-landing-system : lando
2020-02-14 21:14:02 +00:00
Morgan Reschenberg
2c5b5be3cf Bug 746531: Remove Mac-specific casing in listcontrols focus test. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D62455

--HG--
extra : moz-landing-system : lando
2020-02-13 00:06:46 +00:00
Cosmin Sabou
ff39f9206d Backed out 2 changesets (bug 1613263, bug 1611326) for presummably causing l10n langpack bustages. a=backout
Backed out changeset 77e54e76848a (bug 1611326)
Backed out changeset 36ba18ac3a68 (bug 1613263)
2020-02-14 15:02:21 +02:00
Mike Shal
ad0c283ab2 Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
GENERATED_FILES now defaults to python3 unless py2=True is specified as
an argument. All existing GENERATED_FILES scripts and GeneratedFile
templates have the py2=True attribute added, so this patch should
effectively be a no-op.

Going forward, individual scripts can be converted to python3 and their
corresponding py2=True attribute can be deleted. In effect, this patch
will be backed out in pieces until all scripts run in python3, at which
point the py2 attribute itself can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D60919

--HG--
extra : moz-landing-system : lando
2020-02-13 23:07:04 +00:00
Brindusan Cristian
e2fb6b8344 Backed out changeset 7fefed11f117 (bug 1611326) for build bustages at update-1.xpi.stub. CLOSED TREE 2020-02-13 23:33:34 +02:00
Mike Shal
e6464dd404 Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
GENERATED_FILES now defaults to python3 unless py2=True is specified as
an argument. All existing GENERATED_FILES scripts and GeneratedFile
templates have the py2=True attribute added, so this patch should
effectively be a no-op.

Going forward, individual scripts can be converted to python3 and their
corresponding py2=True attribute can be deleted. In effect, this patch
will be backed out in pieces until all scripts run in python3, at which
point the py2 attribute itself can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D60919

--HG--
extra : moz-landing-system : lando
2020-02-13 20:31:50 +00:00
Simon Giesecke
b50347f917 Bug 1611415 - Prefer using std::move over forget. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
2020-02-13 14:38:48 +00:00
Eitan Isaacson
809ed89d61 Bug 895323 - Don't create bullet accessible when list style is none. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D62537

--HG--
extra : moz-landing-system : lando
2020-02-12 06:25:29 +00:00
Eitan Isaacson
6bbdeee348 Bug 1614835 - Advertise focusable state to OSX correctly. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D62523

--HG--
extra : moz-landing-system : lando
2020-02-13 00:09:16 +00:00
shindli
91aa0518dd Backed out changeset 0c982bc69cb3 (bug 1611415) for causing build bustages in /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr CLOSED TREE 2020-02-12 20:13:29 +02:00
Simon Giesecke
f604a47fa5 Bug 1611415 - Applied FixItHints from mozilla-non-std-move. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
2020-02-12 17:24:41 +00:00
Simon Giesecke
244019e207 Bug 1613985 - Use default for equivalent-to-default constructors/destructors in accessibility. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D62569

--HG--
extra : moz-landing-system : lando
2020-02-12 13:39:21 +00:00
Mirko Brodesser
36437a9d2d Bug 1613378: part 9) Clarify dependency to mFrameSelection in Selection when adding/removing ranges. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D62198

--HG--
extra : moz-landing-system : lando
2020-02-12 12:27:32 +00:00
Eitan Isaacson
ff0625bca4 Bug 1614079 - Pass accessibilityHitTest to content process. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D62311

--HG--
extra : moz-landing-system : lando
2020-02-10 23:36:36 +00:00
Eitan Isaacson
697e001179 Bug 1604103 - Instead of pruning links and headings use contentDescription. r=Jamie
Chrome prunes the subtrees of links and headings (with single text leaf
children) and we mimic this in Gecko. The problem is that sometimes a
heading can be a child of a link, and it would be impossible to reach
when navigating by headings.

The main reason we mimiced chrome is because we would getthe name of the
node and its subtree uttered, so you would hear the name of the node
twice. By using contentDescription we can suppress the subtree from
TalkBack's utterance and preserve the node's children for heading
navigation.

Differential Revision: https://phabricator.services.mozilla.com/D61766

--HG--
extra : moz-landing-system : lando
2020-02-06 04:11:47 +00:00
Aaron Klotz
e9f01af788 Bug 1613531: Eliminate the a11y telemetry thread in favour of background task; r=Jamie
We replace the a11y telemetry thread with a call to the new
`NS_DispatchBackgroundTask` infrastructure. We use `NS_DISPATCH_EVENT_MAY_BLOCK`
because the task performs some I/O to load the instantiator's version info.

I also took the opportunity to eliminate some redundant copying.

Differential Revision: https://phabricator.services.mozilla.com/D61769

--HG--
extra : moz-landing-system : lando
2020-02-06 00:24:26 +00:00
Yura Zenevich
38f55cdb70 Bug 1429575 - removing test disabling conditions. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D61729

--HG--
extra : moz-landing-system : lando
2020-02-06 00:30:08 +00:00
Kendall Werts
a3b87c2eaa Bug 1613250 - Bring long press for new container tab menu back. r=Gijs,flod
Added long press as well as the old tooltip language back
and updated 2 tests.

Differential Revision: https://phabricator.services.mozilla.com/D61717

--HG--
extra : moz-landing-system : lando
2020-02-05 21:50:58 +00:00
Morgan Reschenberg
6d7530b618 Bug 1590216: Test for a EVENT_TEXT_CARET_MOVED when text is selected in the URL bar of a new window. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D56781

--HG--
extra : moz-landing-system : lando
2020-02-04 11:25:01 +00:00
Eitan Isaacson
fa1647cd96 Bug 1590216 - Reset selection manager to focused element if its frame is recreated. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D61371

--HG--
extra : moz-landing-system : lando
2020-02-05 00:31:57 +00:00