Commit Graph

159 Commits

Author SHA1 Message Date
Nicholas Nethercote
abe8a4f58a Bug 1202526 (part 6) - Use PLDHashTable::RemoveEntry() in XULDocument. r=bz.
This avoids repeating the hash table search in order to remove the entry.
2015-09-07 19:20:16 -07:00
Masayuki Nakano
ed770e838f Bug 895274 part.94 Rename NS_XUL_COMMAND to eXULCommand r=smaug 2015-09-04 19:54:12 +09:00
Masayuki Nakano
3efcbf8648 Bug 895274 part.92 Rename NS_XUL_COMMAND_UPDATE to eXULCommandUpdate r=smaug 2015-09-04 19:54:12 +09:00
Masayuki Nakano
be8fa51fa8 Bug 895274 part.91 Rename NS_XUL_BROADCAST to eXULBroadcast r=smaug 2015-09-04 19:54:12 +09:00
Masayuki Nakano
d194119036 Bug 895274 part.85 Rename NS_DRAGDROP_GESTURE to eLegacyDragGesture r=smaug 2015-09-02 15:08:03 +09:00
Masayuki Nakano
a9a7f7c99f Bug 895274 part.78 Rename NS_DRAGDROP_START to eDragStart r=smaug 2015-09-02 15:08:01 +09:00
Masayuki Nakano
cafe2dfc67 Bug 895274 part.51 Rename NS_CONTEXTMENU to eContextMenu r=smaug 2015-09-01 00:20:06 +09:00
Nicholas Nethercote
f44287005f Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.

--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
Masayuki Nakano
a516285180 Bug 895274 part.31 Rename NS_MOUSE_CLICK to eMouseClick r=smaug 2015-08-29 08:58:32 +09:00
Masayuki Nakano
b9439c75d9 Bug 895274 part.30 Rename NS_MOUSE_DOUBLECLICK to eMouseDoubleClick r=smaug 2015-08-29 08:58:31 +09:00
Masayuki Nakano
db00b74a82 Bug 895274 part.27 Rename NS_MOUSE_BUTTON_DOWN to eMouseDown r=smaug 2015-08-29 08:58:30 +09:00
Masayuki Nakano
30fdd39afb Bug 895274 part.26 Rename NS_MOUSE_BUTTON_UP to eMouseUp r=smaug 2015-08-29 08:58:30 +09:00
Masayuki Nakano
66f2c27305 Bug 895274 part.1 Rename WidgetEvent::message to WidgetEvent::mMessage r=smaug 2015-08-22 10:34:51 +09:00
Aryeh Gregor
4cb17f538e Bug 874838 - Make CreateElem return Element. r=khuey 2015-08-13 07:50:00 -04:00
Andrew McCreight
9040168887 Bug 1193572, part 4 - Make script element ownership more direct. r=baku
Rather than keep around a raw pointer |script| and depend on the fact
that |child| will keep alive the same object, make |script| strong,
then pass the reference off to |child| when we're finished with it.

I removed the comment about deleting |script| on failure because the
existing stack smart pointers already are doing this.

Also fix a tiny style nit.
2015-08-13 14:24:59 -07:00
Andrew McCreight
5c5e123a34 Bug 1193572, part 3 - Don't re-initialize mType for XUL proto elements. r=baku
These are already set in the constructor.
2015-08-13 14:24:59 -07:00
Andrew McCreight
f248610a58 Bug 1193572, part 2 - nsXULPrototypeElement::Deserialize should use fallible SetCapacity. r=baku
I think this prevents a crash if we end up with a bogus cache value.
2015-08-13 14:24:59 -07:00
Andrew McCreight
ca1c853c7d Bug 1193572, part 1 - Don't use return values of failing calls in XUL deserialize methods. r=baku 2015-08-13 14:24:59 -07:00
Andrew McCreight
7940d1c93b Bug 1193086 - Remove some null checks of infallible new code in XUL. r=baku 2015-08-13 14:24:59 -07:00
Birunthan Mohanathas
7315345693 Bug 1191100 - Remove XPIDL signature comments in .cpp files. r=ehsan
Comment-only so DONTBUILD.
2015-08-04 16:17:36 -07:00
Andrew McCreight
070bac14d5 Bug 1190608, part 5 - Sink the declaration of i in nsXULElement.cpp. r=poiru 2015-08-04 13:06:15 -07:00
Andrew McCreight
0da5862c52 Bug 1190608, part 4 - Brace a few ifs in nsXULElement.cpp. r=poiru 2015-08-04 13:06:14 -07:00
Andrew McCreight
c9f23a2889 Bug 1190608, part 3 - Remove some infallible new checks in nsXULElement.cpp. r=poiru 2015-08-04 13:06:14 -07:00
Andrew McCreight
b33b88ac2a Bug 1190608, part 2 - Tuck elses in nsXULElement.cpp. r=poiru 2015-08-04 13:06:14 -07:00
Andrew McCreight
e7300e3a7f Bug 1190608, part 1 - Delete trailing whitespace in nsXULElement.cpp and nsXULPrototypeCache.cpp. r=poiru
Also, change the mode line for nsXULElement.cpp to match reality, which is 4 space indentation.
2015-08-04 13:06:14 -07:00
Andrew McCreight
4d7a6fb042 Bug 1188234, part 4 - Don't append null to mChildren. r=smaug
Other code does not expect random nulls in this array, so avoid adding
them, just in case we somehow end up looking at it. This code returns
right after the append so it should be okay.
2015-08-04 13:06:14 -07:00
Andrew McCreight
d2b89d08f4 Bug 1188234, part 3 - Make allocation of nsXULPrototypeAttribute fallible in nsXULPrototypeElement::Deserialize(). r=smaug
If we read out a bogus value of |mNumAttributes|, it could be
extremely large, causing the allocation of |mAttributes| to fail.
2015-08-04 13:06:14 -07:00
Andrew McCreight
1403dc04f6 Bug 1188234, part 2 - Add bounds checking in nsXULPrototypeElement::Deserialize(). r=smaug
Make sure we don't do an out-of-bounds read if we read out a bogus value.
2015-08-04 13:06:14 -07:00
Andrew McCreight
b47cfa38e0 Bug 1188234, part 1 - Initialize |number|. r=smaug
If the first Read32() fails, |number| will be garbage.
2015-08-04 13:06:14 -07:00
Robert O'Callahan
efd3df82d6 Bug 1184842. Add aNewValue to nsIMutationObserver::AttributeWillChange. r=peterv
--HG--
extra : commitid : 8C2GnpowyCS
extra : rebase_source : 3f2948df48fe13f65425345f7b674e4e4869c861
2015-07-25 18:05:19 +12:00
Robert O'Callahan
d5d49432af Bug 1184842. Allow BeforeSetAttr to preparse aValue. r=peterv
We will pass the preparsed value into AttributeWillChange.

--HG--
extra : commitid : HCiY4DRKWkC
extra : rebase_source : aa17a819a20578322380d388299279e4e41a690b
2015-08-01 17:14:06 +12:00
Robert O'Callahan
1e49288224 Bug 1184842. Pass aOldValue to all mutation observers. r=peterv
--HG--
extra : commitid : CYjyQn3BAqb
extra : rebase_source : ef153c7cf1e08a058d8de6a76dbe7dc343a299fb
2015-07-25 18:01:19 +12:00
Robert O'Callahan
34bc743227 Bug 1184842. Change nsAttrAndChildArray::SetAndTakeAttr to nsAttrAndChildArray::SetAndSwapAttr. r=peterv
--HG--
extra : commitid : 5EYBuEzNOek
extra : rebase_source : 52da7c8f8693834a9639f5ac65b758fb223c6f03
2015-07-22 14:09:41 +12:00
Boris Zbarsky
e417498f7d Bug 1181920. Persist XUL attributes off a scriptrunner. r=peterv 2015-07-14 15:28:57 -04:00
Birunthan Mohanathas
a8939590de Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
The bulk of this commit was generated by running:

  run-clang-tidy.py \
    -checks='-*,llvm-namespace-comment' \
    -header-filter=^/.../mozilla-central/.* \
    -fix
2015-07-13 08:25:42 -07:00
Geoff Brown
52d4e225a0 Bug 1026290 - Update mochitest-chrome manifests for android; r=jgriffin 2015-07-10 14:41:59 -06:00
Dragana Damjanovic
7987d2203e Bug 905127 - Part 2 - remove unnecessary nsNetUtil.h includes r=jduell 2015-07-06 07:55:00 +02:00
Andrew McCreight
10dd21a3ef Bug 886459, part 3 - Remove simple uses of nsIJSRuntimeService to get the JSRuntime. r=bholley 2015-06-26 18:44:14 -07:00
Jim Chen
d77273ce23 Bug 1166356 - Properly detect double-caching in nsXULPrototypeCache; r=ehsan 2015-06-16 19:45:29 -04:00
Jim Chen
435a558d68 Bug 1168916 - Get rid of redundant pref callback in nsXULPrototypeCache; r=janv 2015-06-16 19:45:29 -04:00
Andrea Marchesini
84fd2a875a Bug 1172189 - Fix overflow in nsXULContentSink.cpp. r=ehsan 2015-06-12 10:06:19 -04:00
Eric Rahm
75c4bebb79 Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-03 15:25:57 -07:00
Eric Rahm
cc58068318 Bug 1165515 - Part 5: Convert instances of PR_LOG_ALWAYS. r=froydnj
Most instances were converted to PR_LOG_INFO, some to PR_LOG_DEBUG, and some
to PR_LOG_ERROR.
2015-06-03 15:22:30 -07:00
Eric Rahm
f50b813989 Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj 2015-06-03 15:22:28 -07:00
Nicholas Nethercote
383a496bf6 Bug 1170416 (part 5) - Remove PLDHashTable::IsInitialized(). r=froydnj.
|mOps| is always non-null now, and there's no longer any distinction between
and uninitialized and initialized table. Yay.

--HG--
extra : rebase_source : 3d1fb72aee4dd21ff20db0ff3166d4e932ade897
2015-05-20 21:23:55 -07:00
Nicholas Nethercote
e849e6588b Bug 1170416 (part 3) - Remove the PLDHashTable2 typedef. r=froydnj.
--HG--
extra : rebase_source : 9510ea47204fffa163cac43aeaaac6ae1ad80419
2015-05-19 16:46:17 -07:00
Carsten "Tomcat" Book
5471309381 Backed out 14 changesets (bug 1165515) for linux x64 e10s m2 test failures
Backed out changeset d68dcf2ef372 (bug 1165515)
Backed out changeset 7c3b45a47811 (bug 1165515)
Backed out changeset b668b617bef2 (bug 1165515)
Backed out changeset d0916e1283a2 (bug 1165515)
Backed out changeset ac4dc7489942 (bug 1165515)
Backed out changeset e9632ce8bc65 (bug 1165515)
Backed out changeset c16d215cc7e4 (bug 1165515)
Backed out changeset e4d474f3c51a (bug 1165515)
Backed out changeset d87680bf9f7c (bug 1165515)
Backed out changeset b3c0a45ba99e (bug 1165515)
Backed out changeset 9370fa197674 (bug 1165515)
Backed out changeset 50970d668ca1 (bug 1165515)
Backed out changeset ffa4eb6d24b9 (bug 1165515)
Backed out changeset 5fcf1203cc1d (bug 1165515)

--HG--
extra : rebase_source : 6fb850d063cbabe738f97f0380302153e3eae97a
2015-06-02 13:05:56 +02:00
Eric Rahm
a9afd68cef Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-01 22:17:33 -07:00
Eric Rahm
28978ade8c Bug 1165515 - Part 5: Convert instances of PR_LOG_ALWAYS. r=froydnj
Most instances were converted to PR_LOG_INFO, some to PR_LOG_DEBUG, and some
to PR_LOG_ERROR.
2015-06-01 22:17:21 -07:00
Eric Rahm
141e0ff4a2 Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj 2015-06-01 22:17:19 -07:00