Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-24 18:55:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
643,530 Commits 615 Branches 98 Tags 5.9 GiB
ca3a12dacd
Commit Graph

17555 Commits

Author SHA1 Message Date
Dragana Damjanovic
1f783b0261 Bug 1528317 - Return NS_ERROR_NET_HTTP2_SENT_GOAWAY only when we have a protocol error. r=valentin 
In bug 1050329 we have introduced a new error and an error page to show that there is a h2 protocol error. The problem is that we show that error when we close a h2 connection for any reason, like a network timeout. Also Http2Session::SessionError does not return NS_ERROR_ILLEGAL_VALUE error but NS_ERROR_NET_HTTP2_SENT_GOAWAY.

Differential Revision: https://phabricator.services.mozilla.com/D22525

--HG--
extra : moz-landing-system : lando
 2019-03-07 21:03:27 +00:00
Valentin Gosu
28c9aa9535 Bug 1437661 - Use fallible AppendUTF16toUTF8 to avoid OOM crash r=JuniorHsu 
Differential Revision: https://phabricator.services.mozilla.com/D22412

--HG--
extra : moz-landing-system : lando
 2019-03-07 17:23:35 +00:00
Valentin Gosu
24a1ef834b Bug 1435141 - Check for user certificates on a background thread to avoid main thread IO r=keeler 
Differential Revision: https://phabricator.services.mozilla.com/D22488

--HG--
extra : moz-landing-system : lando
 2019-03-07 20:34:12 +00:00
arthur.iakab
93997623bd Merge mozilla-central to autoland a=merge on a CLOSED TREE 2019-03-08 00:14:12 +02:00
Valentin Gosu
8c1966b736 Bug 1530691 - Ignore OnStartRequest/StopRequest/DataAvailable after HttpChannelChild::ActorDestroy(Deletion) is called r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D21908

--HG--
extra : moz-landing-system : lando
 2019-03-07 20:59:56 +00:00
Ciure Andrei
712dd2bb8c Backed out 16 changesets (bug 1525245) for perma failing test_document_cookie.html CLOSED TREE 
Backed out changeset 3fd27215698f (bug 1525245)
Backed out changeset d9a9e8e77873 (bug 1525245)
Backed out changeset 0e6f7be92e3f (bug 1525245)
Backed out changeset 6790802e2fa5 (bug 1525245)
Backed out changeset a5a9e01116ed (bug 1525245)
Backed out changeset 66e19a0c38dd (bug 1525245)
Backed out changeset fb90d51ba853 (bug 1525245)
Backed out changeset 4772db3625b3 (bug 1525245)
Backed out changeset 9affaf0cb998 (bug 1525245)
Backed out changeset a91b7ebe8bdd (bug 1525245)
Backed out changeset c2a13a7480e1 (bug 1525245)
Backed out changeset abe4482fa137 (bug 1525245)
Backed out changeset b3920c0bcf84 (bug 1525245)
Backed out changeset 0821b81f2724 (bug 1525245)
Backed out changeset 70bed2ad7899 (bug 1525245)
Backed out changeset 5f72ba232cc8 (bug 1525245)
 2019-03-07 17:54:18 +02:00
Andrea Marchesini
b5e89a20d6 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 15 - Comments, r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D21906

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:22:30 +00:00
Andrea Marchesini
f5aaaac0e2 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 14 - Test for cookies policy, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21697

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:22:18 +00:00
Andrea Marchesini
54a53b2d9e Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 13 - Cookies, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21696

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:21:50 +00:00
Andrea Marchesini
6856f88972 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21538

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:21:15 +00:00
Andrea Marchesini
78f43c5536 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 11 - windows/workers/documents must keep the current cookie settings and ignore changes, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18960

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:18:45 +00:00
Andrea Marchesini
5fccb35782 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 9 - Tests for DOM Cache and cookie settings changing, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18957

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:17:57 +00:00
Andrea Marchesini
9668d47aab Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 8 - Tests for ServiceWorkers and cookie settings changing, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18956

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:17:55 +00:00
Andrea Marchesini
9334965076 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 7 - Tests for IndexedDB and cookie settings changing, r=Ehsan,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D18955

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:17:50 +00:00
Andrea Marchesini
4fa0ec8a85 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 6 - Tests for SharedWorker and cookie settings changing, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18954

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:16:31 +00:00
Andrea Marchesini
f02eab2c7d Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 5 - BroadcastChannel must be blocked when cookie jar access is denied to avoid communication between live and new documents, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18953

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:16:13 +00:00
Andrea Marchesini
012a1b062f Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 4 - Storage tests, r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D18952

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:15:50 +00:00
Andrea Marchesini
f44f894eb1 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 1 - information stored into loadInfo, r=Ehsan,ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D18949

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:14:36 +00:00
Jan Varga
4ecb0bc14c Bug 1526891 - Part 2: Make it possible to use MozURL by QuotaManager for all URIs (instead of using nsIPrincipal); r=nika,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D20906
 2019-02-23 10:13:08 +01:00
Kershaw Chang
2870a6daed Bug 1532231 - Properly check if a DNSRequest is in array r=dragana 
Differential Revision: https://phabricator.services.mozilla.com/D21902

--HG--
extra : moz-landing-system : lando
 2019-03-06 22:15:41 +00:00
Alex Gaynor
9a784d8ef8 Bug 1533066 - replace OptionalIPCClientInfo with IPCClientInfo? in IPDL; r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D22332

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:57:04 +00:00
Dorel Luca
ac34e1d973 Backed out 16 changesets (bug 1525245) for Android failures. CLOSED TREE 
Backed out changeset 9f8a1b410320 (bug 1525245)
Backed out changeset 0ef284a9a1d5 (bug 1525245)
Backed out changeset 835e5f642a03 (bug 1525245)
Backed out changeset 362f5a8d033c (bug 1525245)
Backed out changeset 9da3ab33cf67 (bug 1525245)
Backed out changeset 6aacd2d6e835 (bug 1525245)
Backed out changeset 8ff9e8f45e02 (bug 1525245)
Backed out changeset 2020227181cc (bug 1525245)
Backed out changeset fc3c64c330b9 (bug 1525245)
Backed out changeset 2762bf88e050 (bug 1525245)
Backed out changeset ffc10fdc50a6 (bug 1525245)
Backed out changeset bb6ade1207d7 (bug 1525245)
Backed out changeset 1875eb5085e4 (bug 1525245)
Backed out changeset 7e4f67a6d6f1 (bug 1525245)
Backed out changeset e671fc9581eb (bug 1525245)
Backed out changeset b89f5def8d0d (bug 1525245)
 2019-03-06 21:07:49 +02:00
Dorel Luca
4b0b9944c9 Backed out 2 changesets (bug 1516325) for xpcshell failures in netwerk/test/unit/test_udpsocket.js. CLOSED TREE 
Backed out changeset 7f9508dc59e1 (bug 1516325)
Backed out changeset 28eb88277ffc (bug 1516325)
 2019-03-06 20:51:39 +02:00
Andrea Marchesini
f3be1866e2 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 15 - Comments, r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D21906

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:05:17 +00:00
Andrea Marchesini
4643d957ad Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 14 - Test for cookies policy, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21697

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:04:55 +00:00
Andrea Marchesini
89b7c3883a Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 13 - Cookies, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21696

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:04:29 +00:00
Andrea Marchesini
4fabb4a2a8 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21538

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:04:06 +00:00
Andrea Marchesini
cc423cd937 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 11 - windows/workers/documents must keep the current cookie settings and ignore changes, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18960

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:03:33 +00:00
Andrea Marchesini
89ed086455 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 9 - Tests for DOM Cache and cookie settings changing, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18957

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:02:43 +00:00
Andrea Marchesini
7433e39d29 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 8 - Tests for ServiceWorkers and cookie settings changing, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18956

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:02:25 +00:00
Andrea Marchesini
1367c07970 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 7 - Tests for IndexedDB and cookie settings changing, r=Ehsan,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D18955

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:02:04 +00:00
Andrea Marchesini
b2540a417d Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 6 - Tests for SharedWorker and cookie settings changing, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18954

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:01:42 +00:00
Andrea Marchesini
6373795d50 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 5 - BroadcastChannel must be blocked when cookie jar access is denied to avoid communication between live and new documents, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18953

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:01:24 +00:00
Andrea Marchesini
241c861dc5 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 4 - Storage tests, r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D18952

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:01:07 +00:00
Andrea Marchesini
2fb61cb48b Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 1 - information stored into loadInfo, r=Ehsan,ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D18949

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:00:39 +00:00
Jed Davis
0004ada24c Bug 1516325 - Don't poll for POLLPRI on Necko self-pipe on Unix. r=dragana 
Necko uses a pipe-to-self pattern in its event loop, except that on
Windows the pipe is a socket, and we're checking for PR_POLL_EXCEPT for
Windows-specific reasons and treating it as an error.  On Unix this
isn't necessary, and it causes interoperability problems with MacOS,
which asserts POLLPRI (which is what PR_POLL_EXCEPT maps to) as well
as POLLIN on pipes whenever normal data can be read.  (This may be a
standards violation by MacOS, but it's simple enough to work around.)

Differential Revision: https://phabricator.services.mozilla.com/D21321

--HG--
extra : moz-landing-system : lando
 2019-03-04 15:39:15 +00:00
Alex Gaynor
e5279ff3f7 Bug 1532727 - replace OptionalURIParams with URIParams? in IPDL; r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D22138

--HG--
extra : moz-landing-system : lando
 2019-03-06 14:05:50 +00:00
Andrea Marchesini
c93bd63729 Bug 1532734 - Rename Cryptomining to CryptominingProtection, r=dimi 
Depends on D22144

Differential Revision: https://phabricator.services.mozilla.com/D22145

--HG--
rename : netwerk/url-classifier/UrlClassifierFeatureCryptomining.cpp => netwerk/url-classifier/UrlClassifierFeatureCryptominingProtection.cpp
rename : netwerk/url-classifier/UrlClassifierFeatureCryptomining.h => netwerk/url-classifier/UrlClassifierFeatureCryptominingProtection.h
extra : moz-landing-system : lando
 2019-03-05 19:11:06 +00:00
Andrea Marchesini
45fe87a8dc Bug 1532734 - Rename Fingerprinting to FingerprintingProtection, r=dimi 
Differential Revision: https://phabricator.services.mozilla.com/D22144

--HG--
rename : netwerk/url-classifier/UrlClassifierFeatureFingerprinting.cpp => netwerk/url-classifier/UrlClassifierFeatureFingerprintingProtection.cpp
rename : netwerk/url-classifier/UrlClassifierFeatureFingerprinting.h => netwerk/url-classifier/UrlClassifierFeatureFingerprintingProtection.h
extra : moz-landing-system : lando
 2019-03-05 19:10:43 +00:00
Valentin Gosu
49ba8dc323 Bug 1532324 - Remove manual NS_RELEASE from netwerk/* r=JuniorHsu 
Differential Revision: https://phabricator.services.mozilla.com/D22005

--HG--
extra : moz-landing-system : lando
 2019-03-05 18:43:02 +00:00
Alex Gaynor
d3a1bdd83c Bug 1532368 - replace OptionalPrincipalInfo with PrincipalInfo? in IPDL; r=ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D21972

--HG--
extra : moz-landing-system : lando
 2019-03-05 14:41:42 +00:00
Jeff Walden
3f385ffa33 Bug 1532005 - Implement a new js/public/ArrayBuffer.h header to centralize functionality for creating and interacting with ArrayBuffers. r=sfink 
Differential Revision: https://phabricator.services.mozilla.com/D21827

--HG--
extra : rebase_source : 833bbfce12d90bcb92f7cd88ec65247e48c024c0
 2019-03-04 15:19:16 -08:00
Luke Wagner
80a840b62f Bug 1487113 - Use CloseWithStatus in ScriptLoader.cpp to indicate failure (r=baku) 2019-03-04 19:35:41 -06:00
Razvan Maries
65e4948ca0 Backed out 4 changesets (bug 1532005, bug 1531638) for causing perma fails and Spidermonkey fail. CLOSED TREE 
Backed out changeset 4913d941de92 (bug 1532005)
Backed out changeset 9635abe5bf24 (bug 1532005)
Backed out changeset 738cf4b1126a (bug 1532005)
Backed out changeset e5d9f2ee7ac7 (bug 1531638)
 2019-03-05 01:07:28 +02:00
Ciure Andrei
5ebab45abd Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2019-03-04 23:54:12 +02:00
Dana Keeler
8393579e78 bug 1531958 - make http2 test certificates more consistent with existing test certificate infrastructure r=dragana 
This patch uses the existing xpcshell test certificate infrastructure
(pycert/pykey) to manage the http2 test certificates (and gets rid of some uses
of nsIBadCertListener2 as a bonus).

Differential Revision: https://phabricator.services.mozilla.com/D21814

--HG--
rename : netwerk/test/unit/CA.cert.der => netwerk/test/unit/http2-ca.pem
rename : testing/xpcshell/moz-http2/http2-key.pem => testing/xpcshell/moz-http2/http2-cert.key
extra : moz-landing-system : lando
 2019-03-04 15:42:07 +00:00
Alex Gaynor
dccb3bee8b Bug 1531827 - replace OptionalLoadInfoArgs with LoadInfoArgs? in IPDL; r=ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D21722

--HG--
extra : moz-landing-system : lando
 2019-03-04 06:30:00 +00:00
Michal Novotny
b22590cbfb Bug 1527293 - Loading a large script transferred with Content-Range from cache returns empty file, r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D21403

--HG--
extra : moz-landing-system : lando
 2019-03-01 13:04:36 +00:00
Jeff Walden
ecb4e10bda Bug 1532005 - Implement a new js/public/ArrayBuffer.h header to centralize functionality for creating and interacting with ArrayBuffers. r=sfink 
Differential Revision: https://phabricator.services.mozilla.com/D21827

--HG--
extra : rebase_source : 36c43233ad6d804bd691c8c40d6a6984331c7162
 2019-02-28 17:00:56 -08:00
Byron Campen [:bwc]
3b19aecf4f Bug 1528352: Logging improvements in nsUDPSocket, and handle negative returns from PR_RecvFrom properly. r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D20565

--HG--
extra : moz-landing-system : lando
 2019-02-28 15:17:27 +00:00
Gurzau Raul
6b94d177d1 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-03-01 09:28:28 +02:00
Alex Gaynor
f789c68941 Bug 1531476 - replace MaybeFileDesc with FileDescriptor? in IPDL; r=mccr8 
Also contains a small amount of unrelated devirtualization of IPC methods.

Differential Revision: https://phabricator.services.mozilla.com/D21592

--HG--
extra : moz-landing-system : lando
 2019-02-28 21:20:40 +00:00
Narcis Beleuzu
407ce9fb1a Backed out 4 changesets (bug 1525458) for mochitest failures on test_chrome_ext_trackingprotection.html . CLOSED TREE 
Backed out changeset 96c38e4a3d23 (bug 1525458)
Backed out changeset 1755b771e8c7 (bug 1525458)
Backed out changeset c6177206b968 (bug 1525458)
Backed out changeset 5ce026db31b0 (bug 1525458)
 2019-02-28 20:35:58 +02:00
Ehsan Akhgari
cfb1b88614 Bug 1525458 - Part 1: Only emit the loaded events for various content blocking categories in the presence of an allow-list entry for the top-level document when content would have been blocked otherwise; r=baku,dimi 
Previously the code here used to emit the loaded events for every
resource examined by the URL Classifier Features (in other words, every
third party resource).  But we only need to emit the events in cases
where without the presence of the allow-list we would have blocked the
content.

Differential Revision: https://phabricator.services.mozilla.com/D20874

--HG--
extra : moz-landing-system : lando
 2019-02-28 15:29:10 +00:00
Cosmin Sabou
00f3836a87 Merge mozilla-inbound to mozilla-central. a=merge 2019-02-28 12:57:50 +02:00
Boris Zbarsky
9c5da5f234 Bug 1489308 part 9. Remove now-unused wyciwyg bits. r=mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D17327

--HG--
rename : dom/html/test/browser_refresh_wyciwyg_url.js => dom/html/test/browser_refresh_after_document_write.js
rename : dom/html/test/file_refresh_wyciwyg_url.html => dom/html/test/file_refresh_after_document_write.html
extra : moz-landing-system : lando
 2019-02-28 01:09:48 +00:00
Jonathan Kingston
f6680698bd Bug 1525319 - Removing context from OnDataAvailable r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20881

--HG--
extra : moz-landing-system : lando
 2019-02-27 23:42:27 +00:00
Jonathan Kingston
dd4c731d8c Bug 1525319 - Changing js to remove context from onStartRequest and onStopRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20771

--HG--
extra : moz-landing-system : lando
 2019-02-27 23:41:54 +00:00
Jonathan Kingston
c4853316e7 Bug 1525319 - Removing context from OnStopRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20770

--HG--
extra : moz-landing-system : lando
 2019-02-27 23:41:31 +00:00
Jonathan Kingston
f7e35ae39e Bug 1525319 - Removing context from OnStartRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20769

--HG--
extra : moz-landing-system : lando
 2019-02-27 23:41:04 +00:00
Ciure Andrei
a5c0678ae4 Backed out changeset d158405da514 (bug 1528352) for perma failing test_udpsocket.js CLOSED TREE 2019-02-28 01:58:42 +02:00
Byron Campen [:bwc]
973021e793 Bug 1528352: Logging improvements in nsUDPSocket, and handle negative returns from PR_RecvFrom properly. r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D20565

--HG--
extra : moz-landing-system : lando
 2019-02-27 15:39:57 +00:00
Ciure Andrei
8d2894e70d Backed out 12 changesets (bug 1525245) for failing worker-interception.https.html CLOSED TREE 
Backed out changeset 009e7457b990 (bug 1525245)
Backed out changeset efb2e8fca464 (bug 1525245)
Backed out changeset 6a8401de3237 (bug 1525245)
Backed out changeset 38e802661b14 (bug 1525245)
Backed out changeset d02e3f436390 (bug 1525245)
Backed out changeset 10afd61b7582 (bug 1525245)
Backed out changeset 6b92fb3666d1 (bug 1525245)
Backed out changeset 476af2d7efe5 (bug 1525245)
Backed out changeset 43ad14e323a1 (bug 1525245)
Backed out changeset 94295e3fb027 (bug 1525245)
Backed out changeset d01ead2270e9 (bug 1525245)
Backed out changeset 6bdda622a04a (bug 1525245)
 2019-02-28 00:55:39 +02:00
Andrea Marchesini
26364d101d Bug 1487113 - AltDataOutputStreamChild must be nsIAsyncOutputStream, r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D21379

--HG--
extra : moz-landing-system : lando
 2019-02-27 20:50:48 +00:00
Andrea Marchesini
6dd0ecd7d0 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - new CookieSettings for SharedWorkers and ServiceWorkers, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21357

--HG--
extra : moz-landing-system : lando
 2019-02-27 19:58:26 +00:00
Andrea Marchesini
477f2b65c3 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 11 - windows/workers/documents must keep the current cookie settings and ignore changes, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18960

--HG--
extra : moz-landing-system : lando
 2019-02-27 19:58:07 +00:00
Andrea Marchesini
1b7b09b29f Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 9 - Tests for DOM Cache and cookie settings changing, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18957

--HG--
extra : moz-landing-system : lando
 2019-02-27 19:57:27 +00:00
Andrea Marchesini
13d01cb0bd Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 8 - Tests for ServiceWorkers and cookie settings changing, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18956

--HG--
extra : moz-landing-system : lando
 2019-02-27 19:57:09 +00:00
Andrea Marchesini
bbf2814e97 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 7 - Tests for IndexedDB and cookie settings changing, r=Ehsan,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D18955

--HG--
extra : moz-landing-system : lando
 2019-02-27 19:56:57 +00:00
Andrea Marchesini
19d747280e Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 6 - Tests for SharedWorker and cookie settings changing, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18954

--HG--
extra : moz-landing-system : lando
 2019-02-27 19:56:39 +00:00
Andrea Marchesini
2c669f9cbd Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 5 - BroadcastChannel must be blocked when cookie jar access is denied to avoid communication between live and new documents, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18953

--HG--
extra : moz-landing-system : lando
 2019-02-27 19:56:20 +00:00
Andrea Marchesini
27309db8bb Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 4 - Storage tests, r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D18952

--HG--
extra : moz-landing-system : lando
 2019-02-27 19:56:07 +00:00
Andrea Marchesini
dec5a16bcd Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 1 - information stored into loadInfo, r=Ehsan,ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D18949

--HG--
extra : moz-landing-system : lando
 2019-02-27 19:55:11 +00:00
Honza Bambas
3b626a1544 Bug 1527827 - Add ShutdownPhase::ShutdownCycleCollector triggered after the CycleCollector shutdown, r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D21047

--HG--
extra : moz-landing-system : lando
 2019-02-27 12:57:11 +00:00
Ehsan Akhgari
45c7ece733 Bug 1530076 - Part 1: Add support for modifying the default referrer policy that is applied to third-party trackers when the cookie policy is set to reject third-party trackers; r=valentin 
This is more complex than merely modifying NS_GetDefaultReferrerPolicy()
because at the time most (all?) callers call nsIHttpChannel::SetReferrer/
nsIHttpChannel::SetReferrerWithPolicy before the channel is opened,
which means we won't know whether the channel is a tracking resource or
not yet.  So we would need to re-evaluate this decision after that
information becomes available.  For that, we need to remember the
original URI argument passed to these functions since that information
is currently destroyed and isn't persisted anywhere in the system.

Differential Revision: https://phabricator.services.mozilla.com/D20901

--HG--
extra : moz-landing-system : lando
 2019-02-26 21:30:27 +00:00
Jeff Walden
a25f0304c2 Bug 1453456 - Remove nsCRT::IsAscii(char16_t) in favor of mozilla::IsAscii. r=froydnj 2019-02-25 12:21:15 -08:00
Jan Varga
aa63590c8e Bug 1526615 - Part 1: Add support for RealPort and Directory to MozURL; r=nika 
Differential Revision: https://phabricator.services.mozilla.com/D19282
 2019-02-10 10:20:09 +01:00
Jan Varga
de8bd6609d Bug 1517089 - Part 8: Add GetBaseDomainFromSchemeHost to ThirdPartyUtil and make ThirdPartyUtil ref counting thread safe; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D19202
 2019-02-08 21:01:46 +01:00
Ehsan Akhgari
66c9fa5c58 Bug 1529836 - Part 2: Add a test for capping the maximum life-time of client-side cookies; r=baku 
Depends on D20780

Differential Revision: https://phabricator.services.mozilla.com/D20781

--HG--
extra : moz-landing-system : lando
 2019-02-26 18:34:10 +00:00
Ehsan Akhgari
95562b6904 Bug 1529836 - Part 1: Add support for capping the maximum life-time of client-side cookies; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D20780

--HG--
extra : moz-landing-system : lando
 2019-02-26 18:34:37 +00:00
Gurzau Raul
a12ddd1865 Backed out 11 changesets (bug 1525245) for failing at test_cookies_thirdparty.js on a CLOSED TREE. 
Backed out changeset 1dcb31a1d5be (bug 1525245)
Backed out changeset 4cde0e38ada8 (bug 1525245)
Backed out changeset d3e99dd3fc32 (bug 1525245)
Backed out changeset a565014fdd8d (bug 1525245)
Backed out changeset 20f336320ce1 (bug 1525245)
Backed out changeset d8ee13b6a17d (bug 1525245)
Backed out changeset b79ec111bf41 (bug 1525245)
Backed out changeset 858d08371107 (bug 1525245)
Backed out changeset 1c359cdcf69f (bug 1525245)
Backed out changeset d65fb2d2a243 (bug 1525245)
Backed out changeset 28147c8790d3 (bug 1525245)
 2019-02-26 22:09:25 +02:00
Andrea Marchesini
fc669b1e23 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 11 - windows/workers/documents must keep the current cookie settings and ignore changes, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18960

--HG--
extra : moz-landing-system : lando
 2019-02-26 17:43:58 +00:00
Andrea Marchesini
d1cca7f210 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 9 - Tests for DOM Cache and cookie settings changing, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18957

--HG--
extra : moz-landing-system : lando
 2019-02-26 17:38:23 +00:00
Andrea Marchesini
043af4a25c Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 8 - Tests for ServiceWorkers and cookie settings changing, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18956

--HG--
extra : moz-landing-system : lando
 2019-02-26 17:37:57 +00:00
Andrea Marchesini
4b57994849 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 7 - Tests for IndexedDB and cookie settings changing, r=Ehsan,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D18955

--HG--
extra : moz-landing-system : lando
 2019-02-26 17:37:50 +00:00
Andrea Marchesini
9e327d8957 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 6 - Tests for SharedWorker and cookie settings changing, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18954

--HG--
extra : moz-landing-system : lando
 2019-02-26 17:37:48 +00:00
Andrea Marchesini
084ddbbf6d Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 5 - BroadcastChannel must be blocked when cookie jar access is denied to avoid communication between live and new documents, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18953

--HG--
extra : moz-landing-system : lando
 2019-02-26 17:37:46 +00:00
Andrea Marchesini
29eaa174c6 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 4 - Storage tests, r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D18952

--HG--
extra : moz-landing-system : lando
 2019-02-26 17:36:26 +00:00
Andrea Marchesini
309c007d8d Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 1 - information stored into loadInfo, r=Ehsan,ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D18949

--HG--
extra : moz-landing-system : lando
 2019-02-26 17:34:36 +00:00
Narcis Beleuzu
36e0294e17 Backed out 2 changesets (bug 1529836) for mochitest failures on test_documentcookies_maxage.html . CLOSED TREE 
Backed out changeset d8ec58f95f80 (bug 1529836)
Backed out changeset 2fa205089aea (bug 1529836)
 2019-02-26 17:57:02 +02:00
Ehsan Akhgari
c8ce081831 Bug 1529836 - Part 2: Add a test for capping the maximum life-time of client-side cookies; r=baku 
Depends on D20780

Differential Revision: https://phabricator.services.mozilla.com/D20781

--HG--
extra : moz-landing-system : lando
 2019-02-25 06:57:10 +00:00
Ehsan Akhgari
949ce9392e Bug 1529836 - Part 1: Add support for capping the maximum life-time of client-side cookies; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D20780

--HG--
extra : moz-landing-system : lando
 2019-02-25 06:57:23 +00:00
Ehsan Akhgari
0ba3cee181 Bug 1529784 - Remove an unnecessary call to SchemeIs; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D20782

--HG--
extra : moz-landing-system : lando
 2019-02-25 06:57:50 +00:00
dlee
49b5e37cc4 Bug 1529728 - P1. Move the TopWindowURI check out of the UC_LOG_ENABLED check. r=baku 
The TopWindowURI is necessary for UrlClassifierCommon::ShouldEnableClassifier.
It shouldn't be in the UC_LOG_ENABLED block.

Differential Revision: https://phabricator.services.mozilla.com/D21780

--HG--
extra : moz-landing-system : lando
 2019-03-04 07:12:19 +00:00
Ryan Hunt
3c3b5fab3d Bug 1523969 part 19 - Move method definition inline comments to new line in 'netwerk/'. r=dragana 
Differential Revision: https://phabricator.services.mozilla.com/D21120

--HG--
extra : rebase_source : e16845aa3669ed7b5bf9da57cdd08636e5b4500c
 2019-02-25 16:11:11 -06:00
Ehsan Akhgari
8a0d0f80e0 Bug 1525458 - Part 1: Only emit the loaded events for various content blocking categories in the presence of an allow-list entry for the top-level document when content would have been blocked otherwise; r=baku,dimi 
Previously the code here used to emit the loaded events for every
resource examined by the URL Classifier Features (in other words, every
third party resource).  But we only need to emit the events in cases
where without the presence of the allow-list we would have blocked the
content.

Differential Revision: https://phabricator.services.mozilla.com/D20874
 2019-02-28 17:10:16 -05:00
Kris Maglione
4f0e434bce Bug 1518863: Part 5 - More extension protocol handler cleanup. r=aswan 
This is not strictly related to the rest of the patches, but it was annoying
me while I wrote them.

Differential Revision: https://phabricator.services.mozilla.com/D21450

--HG--
extra : rebase_source : d9fa9ce79e63c2098e74fd401ccaccf7bf22eabf
 2019-02-26 21:09:40 -08:00
Kris Maglione
1a8317619b Bug 1518863: Part 2 - Delay extension protocol requests until extension is ready. r=aswan 
We don't want extension protocol load requests to begin loading until the
extension is far enough initialized to run code. If we load it before then,
the extension framework will either fail to recognize the extension entirely,
or may begin running its scripts in an incomplete environment.

This patch adds a slow path which adds a promise handler and creats a stub
channel only in the case when the extension is not ready. In the normal,
already-initialized case, we take the more direct path.

Differential Revision: https://phabricator.services.mozilla.com/D21447

--HG--
extra : rebase_source : ca770d241ff68192716feace67cd512565ae6b24
 2019-02-27 11:54:31 -08:00
Kris Maglione
1b7d2f811a Bug 1518863: Part 0 - Minor extension protocol handler cleanup. r=aswan 
These are trivial issues that I'd rather keep out of the main patch.

Differential Revision: https://phabricator.services.mozilla.com/D21444

--HG--
extra : rebase_source : c607248dd2d44673b84f4bc99464c3f15a639add
 2019-02-26 12:58:55 -08:00
Byron Campen [:bwc]
25ad4a9108 Bug 1521879 - Part 1.1: Compensate for changes to how IPC headers are generated in the last rebase. r=mjf 
Differential Revision: https://phabricator.services.mozilla.com/D19975

--HG--
rename : media/webrtc/signaling/src/peerconnection/MediaTransportHandlerParent.h => dom/media/webrtc/MediaTransportParent.h
rename : media/webrtc/signaling/src/peerconnection/MediaTransportHandlerParent.cpp => media/webrtc/signaling/src/peerconnection/MediaTransportParent.cpp
extra : moz-landing-system : lando
 2019-02-25 21:50:58 +00:00
Byron Campen [:bwc]
8b6cc6a51f Bug 1521879 - Part 1: IPC-based MediaTransport implementation r=mjf 
Differential Revision: https://phabricator.services.mozilla.com/D17273

--HG--
extra : moz-landing-system : lando
 2019-02-25 21:50:42 +00:00
Noemi Erli
7e23372938 Merge mozilla-central to autoland. a=merge CLOSED TREE 
--HG--
extra : rebase_source : de8796d5d7d7079af1b895a2f537371885f8cc6c
 2019-02-26 00:09:40 +02:00
Christoph Kerschbaumer
c8bb3d7749 Bug 1529869: Remove the 2 from speculate speculative(Anonymous)Connect2 within nsISpeculativeConnect.idl. r=valentin 2019-02-24 20:26:56 +01:00
Gurzau Raul
e6740c75fc Backed out 10 changesets (bug 1521879) for causing bug 1530107. a=backout 
Backed out changeset f597a73a6eac (bug 1521879)
Backed out changeset 0bb76534f207 (bug 1521879)
Backed out changeset abcb8be12adf (bug 1521879)
Backed out changeset ed6c8d3bbfde (bug 1521879)
Backed out changeset 1addf1e15b55 (bug 1521879)
Backed out changeset 6b709cd9a479 (bug 1521879)
Backed out changeset 07747027c59c (bug 1521879)
Backed out changeset a6105ccc188c (bug 1521879)
Backed out changeset 48c9c643e7bb (bug 1521879)
Backed out changeset d4004105a04a (bug 1521879)
 2019-02-25 12:12:15 +02:00
Nika Layzell
a5cbaaf6e7 Bug 1522579 - Part 4: Remove {As,Is}ContentParent, r=mccr8 
These casts are now unnecessary after Part 2, due to all consumers directly
using `ContentParent`.

Depends on D20551

Differential Revision: https://phabricator.services.mozilla.com/D20552

--HG--
extra : moz-landing-system : lando
 2019-02-25 20:04:51 +00:00
Nika Layzell
305c3ca912 Bug 1522579 - Part 3: Remove consumers of nsIContentChild, r=mccr8 
Like Part 2, however for `nsIContentChild`.

Depends on D20550

Differential Revision: https://phabricator.services.mozilla.com/D20551

--HG--
extra : moz-landing-system : lando
 2019-02-25 20:04:49 +00:00
Nika Layzell
1e93329f70 Bug 1522579 - Part 2: Remove consumers of nsIContentParent, r=mccr8 
This patch tries to move them to `ContentParent` instead.

`ProcessPriorityManagerImpl::ObserveContentParentCreated` could not be moved
due to using `do_QueryInterface` to cast from a `nsISupports` down to the
`ContentParent` object. This could be fixed to remove the interfaces entirely,
but I left that for a follow-up.

Depends on D20549

Differential Revision: https://phabricator.services.mozilla.com/D20550

--HG--
extra : moz-landing-system : lando
 2019-02-25 20:04:47 +00:00
Alex Gaynor
0e903787da Bug 1415508 - use Span in constructing a byte input stream; r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D20687

--HG--
extra : moz-landing-system : lando
 2019-02-25 19:11:20 +00:00
Agi Sferro
d6b900089c Bug 1522137 - Make resource://android return a nsIJARURI. r=snorp,mayhemer,bzbarsky 
resource://android URIs always point to a "jar:" URI so it doesn't make sense
that the returned URL object implements nsIFileURL.

This also makes it so extensions can be loaded from a resource://android URI.

Audited all places where we use `nsIJARURI` and check for places where we
assume it looks like `jar:`: the only (!) place where we do that is here:

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/dom/xhr/XMLHttpRequestMainThread.cpp#1852

Where we have special handling for `jar:` URIs. It looks like we would have
less special handling for such a request to a `resource://android` and it could
be fixed by just checking for the interface instead, but that's what's already
happening today so it should work. That code is never reached for
`resource://android` URIs as `mIsMappedArrayBuffer` is false for those URIs
(see #2822). And the code is consistent in checking for the scheme instead of
the interface (the other check is here:
https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/dom/xhr/XMLHttpRequestMainThread.cpp#2822)

Audited all places where we do `EqualsLiteral("jar")`:
https://searchfox.org/mozilla-central/search?q=.EqualsLiteral%28%22jar%22%29&path=

`SubstituteRemoteChannel`: looks interesting, but uses
`nsISubstitutingProtocolHandler::ResolveURI` to first get the real URI (which
is a `jar:`) so it works for our case.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/protocol/res/ExtensionProtocolHandler.cpp#414

`SubstitutingProtocolHandler.cpp`

This case is explicitly fixed by this change, making it account for both
`"jar"` and `"resource"`.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/protocol/res/SubstitutingProtocolHandler.cpp#299

`ReadSourceFromFileName`: this also looks interesting, but uses the channel to
get the URI which returns the real `"jar"` URI and not the mapped `"resource"`.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/js/xpconnect/src/XPCJSRuntime.cpp#2837

`nsStringBundle.cpp`

Accounts for both `"jar"` and `"resource"`, so it should work the same.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/intl/strres/nsStringBundle.cpp#437

Audited all places where we use `nsINestedURI` to make sure they would work for
a `nsIJARURI` which does not implement `nsINestedURI`.

`BrowserContentHandler.jsm`

Uses `nsINestedURI` to figure out if a URI is local or not and then it checks
whether it's a `"file"`, `"resource"` or `"chrome"` URI, for a `nsIJARURI &
nsINestedURI` it would return a `"file"` which passes the test, for a
`nsIJARURI` alone it would return `"resource"` which is also considered local
by this code, so the result wouldn't change.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/browser/components/BrowserContentHandler.jsm#395-399

`nsScriptSecurityManager.cpp`

`GetOriginFromURI`: This is the reason why `SubstitutingJARURI` doesn't
implement `nsINestedURI`, the origin is computed starting from the innermost
URI, which in our case would be a file. The behavior in our case is that the
origin from a `resource://android` URI behaves like other `resource://` URIs,
which is what we expect.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/caps/nsScriptSecurityManager.cpp#169

`CheckLoadURIWithPrincipal`: for `nsIJARURI & nsINestedURI` this code will only
allow pages from the same jar to be in the same origin (which is correct), for
`nsIJARURI` this code is unreachable and it would allow every
`resource://android` to load every other `resource://android` URI (which is
essentially the same thing).

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/caps/nsScriptSecurityManager.cpp#874-876

`nsDocShell.cpp`

`DisplayLoadError`: Just looping through the nested URI chain to build an error
message, no concerns here (it would just ignore the `jar:` part, which is
fine).

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/docshell/base/nsDocShell.cpp#3986

`DoURILoad`: Looking for `view-source`, no concerns for `resource://android`.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/docshell/base/nsDocShell.cpp#9645

`nsObjectLoadingContent.cpp`

Also looking for `view-source`, no concerns.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/dom/base/nsObjectLoadingContent.cpp#2004

`nsIconURI.cpp`/`nsIconURI.h`

Exposing `nsINestedURI`. No concerns.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/image/decoders/icon/nsIconURI.cpp#58

`nsJARURI.cpp`/`nsJARURI.h`

Exposing `nsINestedURI`, the subject of this audit.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/modules/libjar/nsJARURI.cpp#45

`nsIOService.cpp`

`URIChainHasFlags`: This code looks at the chain of nested URIs to figure out
if the chain of protocols has a certain flags. for `nsIJARURI & nsINestedURI`
it would look at both `jar:` and `file:` protocols, while in `nsIJARURI` it
would only look at the `resource:` protocol, which is our intention, since we
want this URI to be treated like a `resource:` URI and nothing else. Note the
`resource:` URI is always local (enforced by `NewURI`), so this should be ok.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/base/nsIOService.cpp#1494

`nsNetUtil.cpp`/`nsNetUtil.h`

Implementation of `NS_ImplGetInnermostURI`, which wouldn't work for `nsIJARURI`
alone, as expected.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/base/nsNetUtil.h#704

`nsSimpleNestedURI.cpp`/`nsSimpleNestedURI.h`

Implementing `nsINestedURI` for `nsSimpleNestedURI`, no concerns.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/base/nsSimpleNestedURI.cpp#19

`nsViewSourceHandler.cpp`

Looking at `view-source` inner URI to get the flags, no concerns.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/protocol/viewsource/nsViewSourceHandler.cpp#49

`nsHtml5StreamParser.cpp`/`nsHtml5TreeOpExecutor.cpp`

More `view-source` handling code. No concerns.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/parser/html/nsHtml5StreamParser.cpp#310

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/parser/html/nsHtml5TreeOpExecutor.cpp#884

`DownloadPlatform.cpp`

`IsURLPossiblyFromWeb`: This line is unreachable as the method would return
true because resource has `URI_IS_UI_RESOURCE`.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/components/downloads/DownloadPlatform.cpp#314

`getAnonymizedPath`: This code looks a little scary, and it's the first one
that seems to conflate the fact that `jar: == nsINestedURI`.

On the android case (line 2130) this code manually replaces the
`resource://android` URI with a `jar:` URI, so it wouldn't matter whether
`resource://android` implements `nsINestedURI` or not.

Actually this code could be a lot easier by using
`nsISubstitutingURL::resolveURI`, maybe I should open a bug.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/components/search/SearchService.jsm#2148

`getRemoteTypeForURIObject`: This also looks interesting. The switch at line
157 would go straight to line 218 for `resource:` URIs (irrespective of
`nsINestedURI`) and then for `nsINestedURI` we would look at the `jar:` URI
(and eventually the `file:` URI). While for not `nsINestedURI` we would call
straight to `validatedWebRemoteType`. This might return `WEB_REMOTE_TYPE`
instead of `FILE_REMOTE_TYPE`, but since it's already happening it should be ok
(`resource://android` maps _today_ to a `jar:` file that return
`WEB_RETURN_TYPE`)

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/modules/E10SUtils.jsm#150

`getURIHost`:

This is another piece of code that benefits from not implementing
`nsINestedURI` as the host would be correctly `"android"` instead of the apk
path.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/mozapps/downloads/DownloadUtils.jsm#390

`initDialog`:

Download dialog would show the `resource://android` URI instead of the actual
`jar:` URI, kind of expected.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/mozapps/downloads/HelperAppDlg.jsm#423

There are no places in the codebase where we do `== "jar"`. Looks like I've
already looked at all hits for "jar" too.

Checked for `"jar:` too and It looks like they are all from code that tries to
build a `jar:` URI manually which is fine for this change.

Audited all `schemeIs("jar")` occurrences:
https://searchfox.org/mozilla-central/search?q=schemeIs(%22jar%22)&path=

`browser-identity.js`

Uses the channel URI which is always resolved to `jar:`, so that works
regardless.  See also:
https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/protocol/res/SubstitutingProtocolHandler.cpp#229

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/browser/base/content/browser-siteIdentity.js#812

`tabbrowser.js`

Only for `scheme == "about"` URIs.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/browser/base/content/tabbrowser.js#789

`HelperAppDialog.js`

Treats "jar:" and "resource" the same way.

https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/mobile/android/components/HelperAppDialog.js#63

`WebNavigationContent.js`

This code checks if the scheme is "jar" and if the original URI is "resource"
it will use that instead, so in our case it will use the "resource" URI either
way.

https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/toolkit/modules/addons/WebNavigationContent.js#158

Depends on D18740

Differential Revision: https://phabricator.services.mozilla.com/D16913

--HG--
extra : moz-landing-system : lando
 2019-02-25 15:38:33 +00:00
Agi Sferro
3ba359e0a9 Bug 1522137 - Move resource://android handler to C++. r=mayhemer 
This is needed to make the handler to avoid race conditions where some code
tries to access a resource://android URI before the handler has been
registered.

Depends on D18739

Differential Revision: https://phabricator.services.mozilla.com/D18740

--HG--
extra : moz-landing-system : lando
 2019-02-25 15:38:21 +00:00
Agi Sferro
31607a16bb Bug 1522137 - Fix HasSubstitution for special cases. r=bzbarsky 
Before this change, HasSubstitution would return false for "gre" or "app" which
is incorrect, since these handlers exist.

Differential Revision: https://phabricator.services.mozilla.com/D18739

--HG--
extra : moz-landing-system : lando
 2019-02-25 15:38:08 +00:00
Andreea Pavel
cd1b27ad4d Backed out 6 changesets (bug 1522579) for build bustages on a CLOSED TREE 
Backed out changeset 3c8320baa230 (bug 1522579)
Backed out changeset 0a288a3d85cd (bug 1522579)
Backed out changeset ecfd27e7d150 (bug 1522579)
Backed out changeset eda40fca0758 (bug 1522579)
Backed out changeset 5c7aafa32a0a (bug 1522579)
Backed out changeset a3c5a2c16411 (bug 1522579)
 2019-02-25 18:19:38 +02:00
Nika Layzell
73b719457a Bug 1522579 - Part 4: Remove {As,Is}ContentParent, r=mccr8 
These casts are now unnecessary after Part 2, due to all consumers directly
using `ContentParent`.

Depends on D20551

Differential Revision: https://phabricator.services.mozilla.com/D20552

--HG--
extra : moz-landing-system : lando
 2019-02-25 15:51:21 +00:00
Nika Layzell
da5b73b6a0 Bug 1522579 - Part 3: Remove consumers of nsIContentChild, r=mccr8 
Like Part 2, however for `nsIContentChild`.

Depends on D20550

Differential Revision: https://phabricator.services.mozilla.com/D20551

--HG--
extra : moz-landing-system : lando
 2019-02-25 15:51:19 +00:00
Nika Layzell
ae293bbea9 Bug 1522579 - Part 2: Remove consumers of nsIContentParent, r=mccr8 
This patch tries to move them to `ContentParent` instead.

`ProcessPriorityManagerImpl::ObserveContentParentCreated` could not be moved
due to using `do_QueryInterface` to cast from a `nsISupports` down to the
`ContentParent` object. This could be fixed to remove the interfaces entirely,
but I left that for a follow-up.

Depends on D20549

Differential Revision: https://phabricator.services.mozilla.com/D20550

--HG--
extra : moz-landing-system : lando
 2019-02-25 15:51:12 +00:00
Tarek Ziadé
2420a8ebb9 Bug 1502917 - Adding ChromeUtils.RequestProcInfo() - r=Ehsan,mstange,kershaw,mhowell 
This patch introduces a new module in widget that implements a simple API to
retrieve system information about a process and its threads.

This function is wrapped into ChromeUtils.RequestProcInfo to return information
about processes started by Firefox.

The use case for this API is to monitor Firefox resources usage in projects
like the battery usage done by the data science team.

Differential Revision: https://phabricator.services.mozilla.com/D10069

--HG--
extra : moz-landing-system : lando
 2019-02-23 18:07:59 +00:00
Nika Layzell
4b1ca2241a Bug 1528493 - Part 2: Move OptionalIPCStream to use new maybe types, r=baku 
Depends on D20067

Differential Revision: https://phabricator.services.mozilla.com/D20068

--HG--
extra : moz-landing-system : lando
 2019-02-22 18:46:14 +00:00
Coroiu Cristina
41959946c9 Merge mozilla-central to autoland a=merge on a CLOSED TREE 2019-02-22 18:39:27 +02:00
Coroiu Cristina
4a72e9cc9a Merge inbound to mozilla-central a=merge 2019-02-22 18:30:44 +02:00
Dorel Luca
e2b65baabd Backed out changeset cd5dbeee8c5d (bug 1502917) for build bustage. CLOSED TREE 2019-02-22 14:32:42 +02:00
Tarek Ziadé
983d831bbe Bug 1502917 - Adding ChromeUtils.RequestProcInfo() - r=Ehsan,mstange,kershaw,mhowell 
This patch introduces a new module in widget that implements a simple API to
retrieve system information about a process and its threads.

This function is wrapped into ChromeUtils.RequestProcInfo to return information
about processes started by Firefox.

The use case for this API is to monitor Firefox resources usage in projects
like the battery usage done by the data science team.

Differential Revision: https://phabricator.services.mozilla.com/D10069

--HG--
extra : moz-landing-system : lando
 2019-02-21 23:05:44 +00:00
Dorel Luca
3797ffa10d Merge mozilla-central to mozilla-inbound. CLOSED TREE 2019-02-22 09:27:34 +02:00
Michal Novotny
77aec0bd07 Bug 1529498 - null pointer writes in mozilla::net::Predictor::LearnNative, r=valentin 
Make sure necko child is initialized before using gNeckoChild in the child process.
 2019-02-21 04:16:00 +02:00
Narcis Beleuzu
1cc1d33847 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-02-21 18:11:40 +02:00
Oana Pop Rus
e3f2246ee8 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-02-21 11:42:10 +02:00
Oana Pop Rus
b36e97fc77 Merge inbound to mozilla-central. a=merge 2019-02-21 11:31:00 +02:00
Andrea Marchesini
dc1879093e Bug 1526214 - Get rid of telemetry for network.cookie.leave-secure-alone, r=Ehsan 
Depends on D19125

Differential Revision: https://phabricator.services.mozilla.com/D20450

--HG--
extra : moz-landing-system : lando
 2019-02-20 19:06:02 +00:00
Andrea Marchesini
9e8594dfcb Bug 1526214 - Get rid of network.cookie.leave-secure-alone, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D19125

--HG--
extra : moz-landing-system : lando
 2019-02-20 09:42:22 +00:00
Gurzau Raul
dd9cb929e6 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-02-21 23:56:21 +02:00
Brindusan Cristian
136394135f Backed out 9 changesets (bug 1521879) for flake failures at /transforms/tests.py. CLOSED TREE 
Backed out changeset baac167868b3 (bug 1521879)
Backed out changeset 54ac1b47b736 (bug 1521879)
Backed out changeset 94b62c6f22e2 (bug 1521879)
Backed out changeset d44f15fd4529 (bug 1521879)
Backed out changeset 761fca0514fb (bug 1521879)
Backed out changeset 0b85b1a7c1ce (bug 1521879)
Backed out changeset 5dc76e863a02 (bug 1521879)
Backed out changeset 604b9a007fe5 (bug 1521879)
Backed out changeset c414d82a5325 (bug 1521879)
 2019-02-21 19:32:31 +02:00
Byron Campen [:bwc]
bc939b7978 Bug 1521879 - Part 1.1: Compensate for changes to how IPC headers are generated in the last rebase. r=mjf 
Differential Revision: https://phabricator.services.mozilla.com/D19975

--HG--
rename : media/webrtc/signaling/src/peerconnection/MediaTransportHandlerParent.h => dom/media/webrtc/MediaTransportParent.h
rename : media/webrtc/signaling/src/peerconnection/MediaTransportHandlerParent.cpp => media/webrtc/signaling/src/peerconnection/MediaTransportParent.cpp
extra : moz-landing-system : lando
 2019-02-21 15:33:57 +00:00
Byron Campen [:bwc]
4604113749 Bug 1521879 - Part 1: IPC-based MediaTransport implementation r=mjf 
Differential Revision: https://phabricator.services.mozilla.com/D17273

--HG--
extra : moz-landing-system : lando
 2019-02-21 16:42:12 +00:00
Junior Hsu
b7e28eddd2 Bug 1507110 - Allow hijacking localhost only if network.proxy.allow_hijacking_localhost is set r=Gijs,mayhemer,mkaply,jmaher 
Differential Revision: https://phabricator.services.mozilla.com/D19325

--HG--
extra : moz-landing-system : lando
 2019-02-19 21:53:22 +00:00
ffxbld
3eb37eed08 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM 
Differential Revision: https://phabricator.services.mozilla.com/D20646

--HG--
extra : moz-landing-system : lando
 2019-02-21 14:10:20 +00:00
Cosmin Sabou
9f8b29287b Merge mozilla-central to autoland. 2019-02-21 05:43:34 +02:00
Cosmin Sabou
f3db52f4cf Merge mozilla-inbound to mozilla-central. a=merge 2019-02-21 05:42:03 +02:00
Masatoshi Kimura
e59e3b3e20 Bug 1528651 - Fix some trivial warnings and re-enable warnings-as-errors on Windows in some directories. r=dmajor 
--HG--
extra : source : 5ee9efeda9e67f6af0521be85266703763cc4c50
 2019-02-19 20:42:11 +09:00
Christoph Kerschbaumer
54df1cb98c Bug 1528677: Remove nullchecks for loadinfo since we have loadinfo on all channels. r=baku 2019-02-20 13:27:25 +01:00
Valentin Gosu
cee418d221 Bug 1529274 - Remove debugging code for bug 1153929 r=JuniorHsu 
The code was added to diagnose an issue that was likely due to heap corruption.
The vtable of the objects was sometimes 0. More details in bug 1153929.
That crash doesn't reproduce anymore so it should be OK to remove.

Differential Revision: https://phabricator.services.mozilla.com/D20561

--HG--
extra : moz-landing-system : lando
 2019-02-20 21:02:23 +00:00
Andrea Marchesini
d316a3043b Bug 1487113 - nsICacheInfoChannel.preferAlternativeDataType() should expose alt-data as optional if required - tests, r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20201

--HG--
extra : moz-landing-system : lando
 2019-02-20 10:05:57 +00:00
Andrea Marchesini
64d3f6f9da Bug 1487113 - nsICacheInfoChannel.preferAlternativeDataType() should expose alt-data as optional if required, r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20200

--HG--
extra : moz-landing-system : lando
 2019-02-20 10:05:42 +00:00
Bogdan Tara
fe6bbffa96 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-02-19 19:36:33 +02:00
Ehsan Akhgari
1597efb46d Bug 1528563 - Initialize mFrameBrowsingContextID inside LoadInfo's copy constructor; r=nika 
Differential Revision: https://phabricator.services.mozilla.com/D20072

--HG--
extra : moz-landing-system : lando
 2019-02-19 16:21:45 +00:00
Andrea Marchesini
c607e645dc Bug 1528596 - Devirtualize accesses to nsUrlClassifierUtils, r=dimi 
Differential Revision: https://phabricator.services.mozilla.com/D20086

--HG--
extra : moz-landing-system : lando
 2019-02-19 14:35:57 +00:00
Masatoshi Kimura
e25fbce870 Bug 1528651 - Re-enable warnings-as-errors on Windows in some directories. r=dmajor 
--HG--
extra : source : ba86ea25070b37f4725834e1c2d9ec4c0783e119
 2019-02-17 15:03:02 +09:00
Christoph Kerschbaumer
e96de0f53f Bug 1528934: Remove unused nsSecCheckWrapChannel. r=valentin 2019-02-19 13:49:38 +01:00
Ciure Andrei
fe3f244555 Backed out 3 changesets (bug 1487113) for perma failing test_alt-data_stream_wrap.js CLOSED TREE 
Backed out changeset 831ac8c662c0 (bug 1487113)
Backed out changeset a8406df01e95 (bug 1487113)
Backed out changeset 1e97c3573ce6 (bug 1487113)
 2019-02-19 11:43:13 +02:00
Andrea Marchesini
aff51ab9f6 Bug 1487113 - nsICacheInfoChannel.preferAlternativeDataType() should expose alt-data as optional if required - tests, r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20201

--HG--
extra : moz-landing-system : lando
 2019-02-19 07:38:44 +00:00
Andrea Marchesini
52efd15b05 Bug 1487113 - nsICacheInfoChannel.preferAlternativeDataType() should expose alt-data as optional if required, r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20200

--HG--
extra : moz-landing-system : lando
 2019-02-19 07:38:31 +00:00
Valentin Gosu
7ddb1bc889 Bug 1528188 - Get the HttpChannelParentListener via the parent r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D20184

--HG--
extra : moz-landing-system : lando
 2019-02-18 21:37:44 +00:00